Andrew Morton napsal(a):
> On Tue, 17 Apr 2007 22:02:10 +0200 (CEST) Jiri Slaby <[EMAIL PROTECTED]>
> wrote:
>
>> phantom, add a new driver
[...]
>> +#define PHANTOM_VERSION "n0.9.4"
>
> That's an impressive version number ;)
fork of 0.8 or so 2.4 linux driver -> the n in the meaning of new :)
>> +#define PHM_MAX_TORQUES 3
>> +
>> +#define PHN_CONTROL 0x6
>> +#define PHN_CTL_AMP 0x1
>> +#define PHN_CTL_BUT 0x2
>> +#define PHN_CTL_IRQ 0x10
>> +
>> +#define PHN_IRQCTL 0x4c
>> +
>> +#define PHN_ZERO_FORCE 2048
>
>
I have no clue too, cut&paste from sensable 2.4 driver. But I'll document as
much as possible.
>> +#define PCI_ENCODER(dev, axis) ((0 - (int)ioread32((dev)->iaddr + (axis)))
>> & \
>> +0x)
>
> Is there any reason why this cannot be a lower-cased inline C function?
> Nicer to read, typesafe, etc.
yes, I'll switch it.
>> +#define PHB_RUNNING 1
>> +#define PHB_RESET 2
>> +
>> +static struct PH_CLASSTYPE *phantom_class;
>
> I guess that PH_CLASSTYPE is some protect-me-from-gregkh compatibility
> thing. But there isn't such a macro in the tree. I switched this to plain
> old `class'.
Yes, my bad.
>> +
>> +static irqreturn_t phantom_isr(int irq, void *data)
>> +{
>> +struct phantom_device *dev = data;
>> +struct input_dev *idev = dev->idev;
>> +unsigned int a, hw_status;
>> +
>> +hw_status = ioread32(dev->iaddr + PHN_CONTROL);
>> +if (!(hw_status & PHN_CTL_IRQ))
>> +return IRQ_NONE;
>> +
>> +iowrite32(0, dev->iaddr);
>> +wmb();
>> +iowrite32(0xc0, dev->iaddr);
>
> there too.
Seems reasonable, it can't be reordered. (I hope this holds on all archs.)
>> +if (unlikely(idev == NULL))
>> +return IRQ_HANDLED;
>
> Can this happen? If so, a comment explaining why would be nice.
In the case of DEBUG_SHIRQ=y. Comment will be added or better -- devinit code
reordered.
thanks for notes,
--
http://www.fi.muni.cz/~xslaby/Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
