Re: [PATCH 0/1][RESUBMIT] input: fix weird issue of synaptics psmouse sync lost
I meant to send this to linux-input On 04/09/2013 08:30 PM, James M Leddy wrote: > We have been using this patch in Ubuntu kernels for 5 months now > without issue. Since patch author Eric Miao no longer works for us, > I'm sending to the list so that other distros can take advantage of > this. > > Last we left off, the suggestion was to make this generic across the > entire range of protocols, not just synaptics. I'm against this for > two reasons. The first is that I don't want to have to ask for > additional testing (I don't have access to the machine). The second > and far more important reason is that I am afraid that this will break > other non-synaptics touchpads, and even though we have a wide range of > hardware, it is impossible to guarantee that it'll work on everything > out there. I will do it however if it's the way we need to go with > this. > > Please let me know what you think, or if you need any additional > information or testing. > > James M Leddy (1): > input: fix weird issue of synaptics psmouse sync lost > after resume > > drivers/input/mouse/synaptics.c |2 ++ > 1 file changed, 2 insertions(+) > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/1][RESUBMIT] input: fix weird issue of synaptics psmouse sync lost after resume
From: Eric Miao
In summary, the symptom is intermittent key events lost after resume
on some machines with synaptics touchpad (seems this is synaptics _only_),
and key events loss is due to serio port reconnect after psmouse sync lost.
Removing psmouse and inserting it back during the suspend/resume process
is able to work around the issue, so the difference between
psmouse_connect()
and psmouse_reconnect() is the key to the root cause of this problem.
After comparing the two different paths, synaptics driver has its own
implementation of synaptics_reconnect(), and the missing psmouse_probe()
seems significant, the patch below added psmouse_probe() to the reconnect
process, and has been verified many times that the issue could not be
reliably
reproduced.
There are two PS/2 commands in psmouse_probe():
1. PSMOUSE_CMD_GETID
2. PSMOUSE_CMD_RESET_DIS
Only the PSMOUSE_CMD_GETID seems to be significant. The
PSMOUSE_CMD_RESET_DIS is irrelevant to this issue after trying
several times. So we have only implemented this patch to issue
the PSMOUSE_CMD_GETID so far.
Tested-by: Daniel Manrique
Signed-off-by: James M Leddy
---
drivers/input/mouse/synaptics.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/mouse/synaptics.c
b/drivers/input/mouse/synaptics.c
index 12d12ca..3438a9d 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -1355,6 +1355,7 @@ static int synaptics_reconnect(struct psmouse
*psmouse)
{
struct synaptics_data *priv = psmouse->private;
struct synaptics_data old_priv = *priv;
+ unsigned char param[2];
int retry = 0;
int error;
@@ -1370,6 +1371,7 @@ static int synaptics_reconnect(struct psmouse
*psmouse)
*/
ssleep(1);
}
+ ps2_command(&psmouse->ps2dev, param, PSMOUSE_CMD_GETID);
error = synaptics_detect(psmouse, 0);
} while (error && ++retry < 3);
-- 1.7.9.5
Re: Possible regression 3.8.7 -> 3.9 with Dell touchpad
On 05/10/2013 03:39 PM, Tibor Billes wrote: > From: Dmitry Torokhov Sent: 05/10/13 12:54 AM >> >> On Thu, May 09, 2013 at 10:59:58PM +0200, Tibor Billes wrote: >>> Hi, >>> >>> I found that after upgrading my kernel from 3.8.7 to 3.9 my touchpad only >>> works partly. By that I mean I can use the touchpad to move the cursor >>> around, but I cannot click with it by tapping. >> >> Is the touchpad recognized as ALPS or PS/2 mouse in 3.8.7? Also, can you >> check that touchpad tapping is enabled in your desktop environment? > > In 3.8.7 it is recognized as PS/2 mouse and the desktop environment doesn't > even offer any touchpad settings. In 3.9.1 the touchpad is recognized as > 'AlpsPS/2 ALPS DualPoint TouchPad' and yes, the touchpad settings appeared, > and yes, clicking was disabled. Enabled it, works like a charm :) > > So what happened is that the 3.8.7 kernel did not recognize my touchpad, so > it fell back to PS/2 which worked well for me. The 3.9 kernel recongizes my > touchpad correctly because Kevin updated the driver, and my system started > using a different configuration as it knew it was a touchpad and not some > PS/2 device. Am I right? I recall looking for touchpad settings in one of the > 3.8.x kernels and I didn't find any so I didn't bother looking for it again > in 3.9... > > In this case I'm sorry for the false report, and thank you guys for the > driver update :) This sounds about right. I expect that if you enable tap to click in your settings (should be under "Mouse and Touchpad" if you're using gnome-control-center) you should be good. > >> Thanks. >> >>> My machine is a Dell >>> Latitude E5530. Since it is 100% reproducible on my machine, I bisected it, >>> and found this commit: >>> >>> commit 1302bac33d9e88cd43e482191a806998f3ed43cc >>> Author: Kevin Cernekee >>> Date: Wed Feb 13 22:27:08 2013 -0800 >>> >>>Input: ALPS - add support for "Rushmore" touchpads >>> >>>Rushmore touchpads are found on Dell E6230/E6430/E6530. They use the V3 >>>protocol with slightly tweaked init sequences and report formats. >>> >>>The E7 report is 73 03 0a, and the EC report is 88 08 1d >>> >>>Credits: Emmanuel Thome reported the MT bitmap changes. >>> >>>Signed-off-by: Kevin Cernekee >>>Tested-by: Dave Turvene >>>Signed-off-by: Dmitry Torokhov >>> >>> I did the bisection between 3.8.7 and 3.9, but also tried 3.9.1, it is bad >>> too. I also tried reverting that commit to make sure that it really is >>> what made my touchpad not working. The revert did fix my problem. >>> >>> That's all I gathered so far, but I'd be happy to help further in any way >>> I can, just let me know. >>> >>> Thanks, >>> Tibor >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-input" in >>> the body of a message to majord...@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> -- >> Dmitry > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] Remap micmute to F20
Because of a limitation of the X11 protocol, we can't use micmute in it's current mapping. I've chosen to map this to F20, since we do similar things with the touchpad buttons for the same reason. Whatever we use, we will have to agree with xkeyboard-config. http://lists.freedesktop.org/archives/xorg-devel/2012-August/033442.html Signed-off-by: James M. Leddy --- keymaps/module-lenovo |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/keymaps/module-lenovo b/keymaps/module-lenovo index 8e38883..f94678d 100644 --- a/keymaps/module-lenovo +++ b/keymaps/module-lenovo @@ -14,4 +14,4 @@ 0x15 volumedown 0x16 mute 0x17 prog1 # ThinkPad/ThinkVantage button (high keycode: "vendor") -0x1A micmute # Microphone mute +0x1A f20 # Microphone mute -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Remap micmute to F20
On 08/28/2012 07:36 PM, Bastien Nocera wrote: > Em Tue, 2012-08-28 às 19:32 -0400, James M Leddy escreveu: >> Because of a limitation of the X11 protocol, we can't use micmute in >> it's current mapping. I've chosen to map this to F20, since we do >> similar things with the touchpad buttons for the same reason. Whatever >> we use, we will have to agree with xkeyboard-config. >> >> http://lists.freedesktop.org/archives/xorg-devel/2012-August/033442.html > > Feel free to implement this once you're done :) > https://bugzilla.gnome.org/show_bug.cgi?id=651051 Already ahead of you :) Just have to make sure the patch applies cleanly upstream. Thanks for the bug number. https://bazaar.launchpad.net/~jm-leddy/ubuntu/quantal/gnome-settings-daemon/micmute/view/head:/debian/patches/micmute.patch > > Cheers > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Remap micmute to F20
On 08/29/2012 11:43 AM, James M Leddy wrote: > On 08/28/2012 07:36 PM, Bastien Nocera wrote: >> Em Tue, 2012-08-28 às 19:32 -0400, James M Leddy escreveu: >>> Because of a limitation of the X11 protocol, we can't use micmute in >>> it's current mapping. I've chosen to map this to F20, since we do >>> similar things with the touchpad buttons for the same reason. Whatever >>> we use, we will have to agree with xkeyboard-config. >>> >>> http://lists.freedesktop.org/archives/xorg-devel/2012-August/033442.html >> >> Feel free to implement this once you're done :) >> https://bugzilla.gnome.org/show_bug.cgi?id=651051 > > Already ahead of you :) Just have to make sure the patch applies cleanly > upstream. Thanks for the bug number. > > https://bazaar.launchpad.net/~jm-leddy/ubuntu/quantal/gnome-settings-daemon/micmute/view/head:/debian/patches/micmute.patch Just realized this is unity specific, I'll work on a gnome-shell version this week or next. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
