[PATCH 31/45] clk: qcom: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Signed-off-by: Stephen Boyd 
---
 drivers/clk/qcom/mmcc-msm8960.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/mmcc-msm8960.c b/drivers/clk/qcom/mmcc-msm8960.c
index 9711bca9cc06..2de05e321ad0 100644
--- a/drivers/clk/qcom/mmcc-msm8960.c
+++ b/drivers/clk/qcom/mmcc-msm8960.c
@@ -19,6 +19,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 26/45] clk: tegra: Properly include clk.h

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Only include clk.h in files that are using
it. Also add in a clkdev.h include that was missing in a file
using clkdev APIs.

Cc: Peter De Schrijver 
Cc: Thierry Reding 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/tegra/clk-divider.c  | 1 -
 drivers/clk/tegra/clk-periph-gate.c  | 1 -
 drivers/clk/tegra/clk-periph.c   | 1 -
 drivers/clk/tegra/clk-pll-out.c  | 1 -
 drivers/clk/tegra/clk-pll.c  | 2 +-
 drivers/clk/tegra/clk-super.c| 1 -
 drivers/clk/tegra/clk-tegra-audio.c  | 1 -
 drivers/clk/tegra/clk-tegra-fixed.c  | 1 -
 drivers/clk/tegra/clk-tegra-periph.c | 1 -
 drivers/clk/tegra/clk-tegra-pmc.c| 1 -
 drivers/clk/tegra/clk-tegra-super-gen4.c | 1 -
 drivers/clk/tegra/clk-tegra114.c | 2 --
 drivers/clk/tegra/clk-tegra124.c | 1 -
 drivers/clk/tegra/clk-tegra20.c  | 1 -
 drivers/clk/tegra/clk-tegra30.c  | 1 -
 drivers/clk/tegra/clk.c  | 1 +
 include/linux/clk/tegra.h| 3 ++-
 17 files changed, 4 insertions(+), 17 deletions(-)

diff --git a/drivers/clk/tegra/clk-divider.c b/drivers/clk/tegra/clk-divider.c
index 59a5714dfe18..48c83efda4cf 100644
--- a/drivers/clk/tegra/clk-divider.c
+++ b/drivers/clk/tegra/clk-divider.c
@@ -19,7 +19,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include "clk.h"
 
diff --git a/drivers/clk/tegra/clk-periph-gate.c 
b/drivers/clk/tegra/clk-periph-gate.c
index 0aa8830ae7cc..d28d6e95020f 100644
--- a/drivers/clk/tegra/clk-periph-gate.c
+++ b/drivers/clk/tegra/clk-periph-gate.c
@@ -14,7 +14,6 @@
  * along with this program.  If not, see .
  */
 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/tegra/clk-periph.c b/drivers/clk/tegra/clk-periph.c
index d84ae49d0e05..ec5b6113b012 100644
--- a/drivers/clk/tegra/clk-periph.c
+++ b/drivers/clk/tegra/clk-periph.c
@@ -14,7 +14,6 @@
  * along with this program.  If not, see .
  */
 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/tegra/clk-pll-out.c b/drivers/clk/tegra/clk-pll-out.c
index 3598987a451d..257cae0c1488 100644
--- a/drivers/clk/tegra/clk-pll-out.c
+++ b/drivers/clk/tegra/clk-pll-out.c
@@ -20,7 +20,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include "clk.h"
 
diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index 05c6d08a6695..63499c461482 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -18,8 +18,8 @@
 #include 
 #include 
 #include 
-#include 
 #include 
+#include 
 
 #include "clk.h"
 
diff --git a/drivers/clk/tegra/clk-super.c b/drivers/clk/tegra/clk-super.c
index 2fd924d38606..131d1b5085e2 100644
--- a/drivers/clk/tegra/clk-super.c
+++ b/drivers/clk/tegra/clk-super.c
@@ -20,7 +20,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include "clk.h"
 
diff --git a/drivers/clk/tegra/clk-tegra-audio.c 
b/drivers/clk/tegra/clk-tegra-audio.c
index 5c38aab2c5b8..11e3ad7ad7a3 100644
--- a/drivers/clk/tegra/clk-tegra-audio.c
+++ b/drivers/clk/tegra/clk-tegra-audio.c
@@ -15,7 +15,6 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/tegra/clk-tegra-fixed.c 
b/drivers/clk/tegra/clk-tegra-fixed.c
index 605676d368eb..da0b5941c89f 100644
--- a/drivers/clk/tegra/clk-tegra-fixed.c
+++ b/drivers/clk/tegra/clk-tegra-fixed.c
@@ -15,7 +15,6 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/tegra/clk-tegra-periph.c 
b/drivers/clk/tegra/clk-tegra-periph.c
index 46af9244ba74..cb6ab830941d 100644
--- a/drivers/clk/tegra/clk-tegra-periph.c
+++ b/drivers/clk/tegra/clk-tegra-periph.c
@@ -15,7 +15,6 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/tegra/clk-tegra-pmc.c 
b/drivers/clk/tegra/clk-tegra-pmc.c
index 08b21c1ee867..91377abfefa1 100644
--- a/drivers/clk/tegra/clk-tegra-pmc.c
+++ b/drivers/clk/tegra/clk-tegra-pmc.c
@@ -15,7 +15,6 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/tegra/clk-tegra-super-gen4.c 
b/drivers/clk/tegra/clk-tegra-super-gen4.c
index feb3201c85ce..ecd7ff736b74 100644
--- a/drivers/clk/tegra/clk-tegra-super-gen4.c
+++ b/drivers/clk/tegra/clk-tegra-super-gen4.c
@@ -15,7 +15,6 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
index 8237d16b4075..db5871519bf5 100644
--- a/drivers/clk/tegra/clk-tegra114.c
+++ b/drivers/clk/tegra/clk-tegra114.c
@@ -15,9 +15,7 @@
  */
 
 #include 
-#include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c
index e8cca3eac007..0c44cc7f8558 100644
--- a/drivers/clk/tegra/clk-tegra124.c
+++ b/drivers/clk/tegra/clk-tegra124.c
@@ -15,7 +15,6 @@
  */
 
 #include 
-#include 
 #include 

[PATCH 12/45] clk: wm831x: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.

Cc: Mark Brown 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-wm831x.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-wm831x.c b/drivers/clk/clk-wm831x.c
index ef67719f4e52..43f9d15255f4 100644
--- a/drivers/clk/clk-wm831x.c
+++ b/drivers/clk/clk-wm831x.c
@@ -12,7 +12,6 @@
  *
  */
 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 30/45] clk: highbank: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Rob Herring 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-highbank.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk-highbank.c b/drivers/clk/clk-highbank.c
index 2e7e9d9798cb..be3a21abb185 100644
--- a/drivers/clk/clk-highbank.c
+++ b/drivers/clk/clk-highbank.c
@@ -17,6 +17,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 11/45] clk: u300: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver. Also add in slab.h because without clkdev.h
compilation of this file would fail.

Cc: Linus Walleij 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-u300.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-u300.c b/drivers/clk/clk-u300.c
index 18bf5e576b93..95d1742dac30 100644
--- a/drivers/clk/clk-u300.c
+++ b/drivers/clk/clk-u300.c
@@ -5,8 +5,8 @@
  * Author: Linus Walleij 
  * Author: Jonas Aaberg 
  */
-#include 
 #include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 42/45] clk: samsung: s5pv210-audss: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Kukjin Kim 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/samsung/clk-s5pv210-audss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/samsung/clk-s5pv210-audss.c 
b/drivers/clk/samsung/clk-s5pv210-audss.c
index de4455b75e8a..eefb84b22566 100644
--- a/drivers/clk/samsung/clk-s5pv210-audss.c
+++ b/drivers/clk/samsung/clk-s5pv210-audss.c
@@ -13,8 +13,8 @@
  * Driver for Audio Subsystem Clock Controller of S5PV210-compatible SoCs.
 */
 
-#include 
 #include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 39/45] clk: si570: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Guenter Roeck 
Cc: Soren Brinkmann 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-si570.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk-si570.c b/drivers/clk/clk-si570.c
index 20a5aec98b1a..cf478aa9fa5d 100644
--- a/drivers/clk/clk-si570.c
+++ b/drivers/clk/clk-si570.c
@@ -19,6 +19,7 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 25/45] clk: socfpga: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.

Cc: Viresh Kumar 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/spear/spear1310_clock.c | 1 -
 drivers/clk/spear/spear1340_clock.c | 1 -
 drivers/clk/spear/spear3xx_clock.c  | 1 -
 drivers/clk/spear/spear6xx_clock.c  | 1 -
 4 files changed, 4 deletions(-)

diff --git a/drivers/clk/spear/spear1310_clock.c 
b/drivers/clk/spear/spear1310_clock.c
index 4daa5977793a..7cd010f6e12d 100644
--- a/drivers/clk/spear/spear1310_clock.c
+++ b/drivers/clk/spear/spear1310_clock.c
@@ -11,7 +11,6 @@
  * warranty of any kind, whether express or implied.
  */
 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/spear/spear1340_clock.c 
b/drivers/clk/spear/spear1340_clock.c
index 5a5c6648308d..eef57a2e39ee 100644
--- a/drivers/clk/spear/spear1340_clock.c
+++ b/drivers/clk/spear/spear1340_clock.c
@@ -11,7 +11,6 @@
  * warranty of any kind, whether express or implied.
  */
 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/spear/spear3xx_clock.c 
b/drivers/clk/spear/spear3xx_clock.c
index bb5f387774e2..ce2a94c64049 100644
--- a/drivers/clk/spear/spear3xx_clock.c
+++ b/drivers/clk/spear/spear3xx_clock.c
@@ -9,7 +9,6 @@
  * warranty of any kind, whether express or implied.
  */
 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/spear/spear6xx_clock.c 
b/drivers/clk/spear/spear6xx_clock.c
index 4f649c9cb094..46a4dafe46a7 100644
--- a/drivers/clk/spear/spear6xx_clock.c
+++ b/drivers/clk/spear/spear6xx_clock.c
@@ -9,7 +9,6 @@
  * warranty of any kind, whether express or implied.
  */
 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 38/45] clk: moxart: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Jonas Jensen 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-moxart.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk-moxart.c b/drivers/clk/clk-moxart.c
index 5181b89c3cb2..f37f719643ec 100644
--- a/drivers/clk/clk-moxart.c
+++ b/drivers/clk/clk-moxart.c
@@ -10,6 +10,7 @@
  * warranty of any kind, whether express or implied.
  */
 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 44/45] clk: at91: Include clk.h and slab.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly. Also include slab.h instead of relying on clkdev.h
for it.

Cc: Boris BREZILLON 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/at91/clk-slow.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/at91/clk-slow.c b/drivers/clk/at91/clk-slow.c
index 98a84a865fe1..0a7aef39ab5b 100644
--- a/drivers/clk/at91/clk-slow.c
+++ b/drivers/clk/at91/clk-slow.c
@@ -10,8 +10,10 @@
  *
  */
 
+#include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 40/45] clk: ingenic: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Paul Burton 
Cc: Paul Cercueil 
Cc: Ralf Baechle 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/ingenic/cgu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/ingenic/cgu.c b/drivers/clk/ingenic/cgu.c
index b936cdd1a13c..7cfb7b2a2ed6 100644
--- a/drivers/clk/ingenic/cgu.c
+++ b/drivers/clk/ingenic/cgu.c
@@ -16,6 +16,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 22/45] clk: samsung: Properly include clk.h and clkdev.h

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Only include clk.h in files that are
using it. The clkdev.h header isn't always used either, so remove
it and add in slab.h where files were relying on it to include
slab for them.

Cc: Chanwoo Choi 
Cc: Sylwester Nawrocki 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/samsung/clk-cpu.c   | 3 +++
 drivers/clk/samsung/clk-exynos-audss.c  | 3 ++-
 drivers/clk/samsung/clk-exynos-clkout.c | 2 +-
 drivers/clk/samsung/clk-exynos3250.c| 2 --
 drivers/clk/samsung/clk-exynos4.c   | 2 +-
 drivers/clk/samsung/clk-exynos4415.c| 2 --
 drivers/clk/samsung/clk-exynos5250.c| 2 --
 drivers/clk/samsung/clk-exynos5260.c| 2 --
 drivers/clk/samsung/clk-exynos5410.c| 2 --
 drivers/clk/samsung/clk-exynos5420.c| 3 +--
 drivers/clk/samsung/clk-exynos5433.c| 2 --
 drivers/clk/samsung/clk-exynos5440.c| 2 --
 drivers/clk/samsung/clk-exynos7.c   | 2 --
 drivers/clk/samsung/clk-pll.c   | 2 ++
 drivers/clk/samsung/clk-s3c2410.c   | 2 --
 drivers/clk/samsung/clk-s3c2412.c   | 2 --
 drivers/clk/samsung/clk-s3c2443.c   | 2 --
 drivers/clk/samsung/clk-s3c64xx.c   | 2 --
 drivers/clk/samsung/clk-s5pv210.c   | 2 --
 drivers/clk/samsung/clk.c   | 4 
 drivers/clk/samsung/clk.h   | 3 ++-
 21 files changed, 16 insertions(+), 32 deletions(-)

diff --git a/drivers/clk/samsung/clk-cpu.c b/drivers/clk/samsung/clk-cpu.c
index 3a1fe07cfe9e..8e7f36f105c1 100644
--- a/drivers/clk/samsung/clk-cpu.c
+++ b/drivers/clk/samsung/clk-cpu.c
@@ -33,6 +33,9 @@
 */
 
 #include 
+#include 
+#include 
+#include 
 #include "clk-cpu.h"
 
 #define E4210_SRC_CPU  0x0
diff --git a/drivers/clk/samsung/clk-exynos-audss.c 
b/drivers/clk/samsung/clk-exynos-audss.c
index 454b02ae486a..4e9584d79089 100644
--- a/drivers/clk/samsung/clk-exynos-audss.c
+++ b/drivers/clk/samsung/clk-exynos-audss.c
@@ -9,8 +9,9 @@
  * Common Clock Framework support for Audio Subsystem Clock Controller.
 */
 
-#include 
+#include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/samsung/clk-exynos-clkout.c 
b/drivers/clk/samsung/clk-exynos-clkout.c
index 03a52228b6d1..7cd02ff37a1f 100644
--- a/drivers/clk/samsung/clk-exynos-clkout.c
+++ b/drivers/clk/samsung/clk-exynos-clkout.c
@@ -9,8 +9,8 @@
  * Clock driver for Exynos clock output
  */
 
+#include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/samsung/clk-exynos3250.c 
b/drivers/clk/samsung/clk-exynos3250.c
index 538de66a759e..c940fddb0847 100644
--- a/drivers/clk/samsung/clk-exynos3250.c
+++ b/drivers/clk/samsung/clk-exynos3250.c
@@ -8,8 +8,6 @@
  * Common Clock Framework support for Exynos3250 SoC.
  */
 
-#include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/samsung/clk-exynos4.c 
b/drivers/clk/samsung/clk-exynos4.c
index cae2c048488d..65e20eb6356e 100644
--- a/drivers/clk/samsung/clk-exynos4.c
+++ b/drivers/clk/samsung/clk-exynos4.c
@@ -11,8 +11,8 @@
 */
 
 #include 
+#include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/samsung/clk-exynos4415.c 
b/drivers/clk/samsung/clk-exynos4415.c
index 6c78b09c829f..92c39f6efec8 100644
--- a/drivers/clk/samsung/clk-exynos4415.c
+++ b/drivers/clk/samsung/clk-exynos4415.c
@@ -9,8 +9,6 @@
  * Common Clock Framework support for Exynos4415 SoC.
  */
 
-#include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/samsung/clk-exynos5250.c 
b/drivers/clk/samsung/clk-exynos5250.c
index 70ec3d2608a1..aa356db587df 100644
--- a/drivers/clk/samsung/clk-exynos5250.c
+++ b/drivers/clk/samsung/clk-exynos5250.c
@@ -11,8 +11,6 @@
 */
 
 #include 
-#include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/samsung/clk-exynos5260.c 
b/drivers/clk/samsung/clk-exynos5260.c
index 06f96eb7cf93..d1a29f6c1084 100644
--- a/drivers/clk/samsung/clk-exynos5260.c
+++ b/drivers/clk/samsung/clk-exynos5260.c
@@ -9,8 +9,6 @@
  * Common Clock Framework support for Exynos5260 SoC.
  */
 
-#include 
-#include 
 #include 
 #include 
 
diff --git a/drivers/clk/samsung/clk-exynos5410.c 
b/drivers/clk/samsung/clk-exynos5410.c
index 231475bc2b99..d5d5dcabc4a9 100644
--- a/drivers/clk/samsung/clk-exynos5410.c
+++ b/drivers/clk/samsung/clk-exynos5410.c
@@ -11,8 +11,6 @@
 
 #include 
 
-#include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/samsung/clk-exynos5420.c 
b/drivers/clk/samsung/clk-exynos5420.c
index a1d731ca8f48..389af3c15ec4 100644
--- a/drivers/clk/samsung/clk-exynos5420.c
+++ b/drivers/clk/samsung/clk-exynos5420.c
@@ -11,8 +11,7 @@
 */
 
 #include 
-#include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/samsung/clk-exynos5433.c 
b/drivers/clk/samsung/clk-exynos5433.c
index 39c95649d3d0..cee062c588de 100644
--- a/drivers/clk/samsung/clk-exynos5433.c
+++ b/drivers/clk/samsung/clk-exynos5433.c
@@ -9,8 +9,6 @@
  * Common 

[PATCH 32/45] clk: st: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Gabriel Fernandez 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/st/clk-flexgen.c | 1 +
 drivers/clk/st/clkgen-fsyn.c | 1 +
 drivers/clk/st/clkgen-mux.c  | 1 +
 drivers/clk/st/clkgen-pll.c  | 1 +
 4 files changed, 4 insertions(+)

diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c
index 657ca14ba709..8e0dbb1f81f8 100644
--- a/drivers/clk/st/clk-flexgen.c
+++ b/drivers/clk/st/clk-flexgen.c
@@ -5,6 +5,7 @@
  * Author:  Maxime Coquelin  for ST-Microelectronics.
  * License terms:  GNU General Public License (GPL), version 2  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c
index e94197f04b0b..90c20717a6bb 100644
--- a/drivers/clk/st/clkgen-fsyn.c
+++ b/drivers/clk/st/clkgen-fsyn.c
@@ -15,6 +15,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 #include "clkgen.h"
diff --git a/drivers/clk/st/clkgen-mux.c b/drivers/clk/st/clkgen-mux.c
index 4fbe6e099587..4fc95d5332e2 100644
--- a/drivers/clk/st/clkgen-mux.c
+++ b/drivers/clk/st/clkgen-mux.c
@@ -15,6 +15,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 static DEFINE_SPINLOCK(clkgena_divmux_lock);
diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
index 106532207213..cdb14b9bb942 100644
--- a/drivers/clk/st/clkgen-pll.c
+++ b/drivers/clk/st/clkgen-pll.c
@@ -16,6 +16,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 #include "clkgen.h"
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 28/45] clk: versatile: Remove clk.h and clkdev.h includes

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver. Also remove clkdev.h in files that aren't using
it and replace them with slab.h in files that were relying on the
implicit include of slab.h in clkdev.h.

Cc: Linus Walleij 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/versatile/clk-icst.c  | 5 +++--
 drivers/clk/versatile/clk-impd1.c | 1 -
 drivers/clk/versatile/clk-realview.c  | 1 -
 drivers/clk/versatile/clk-sp810.c | 3 ++-
 drivers/clk/versatile/clk-versatile.c | 2 --
 5 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c
index bc96f103bd7c..a3893ea2199d 100644
--- a/drivers/clk/versatile/clk-icst.c
+++ b/drivers/clk/versatile/clk-icst.c
@@ -13,8 +13,9 @@
  * ICST clock code from the ARM tree should probably be merged into this
  * file.
  */
-#include 
-#include 
+#include 
+#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/versatile/clk-impd1.c 
b/drivers/clk/versatile/clk-impd1.c
index 1cc1330dc570..65c842a21c62 100644
--- a/drivers/clk/versatile/clk-impd1.c
+++ b/drivers/clk/versatile/clk-impd1.c
@@ -7,7 +7,6 @@
  * published by the Free Software Foundation.
  */
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/versatile/clk-realview.c 
b/drivers/clk/versatile/clk-realview.c
index c8b523117fb7..940cc6f14578 100644
--- a/drivers/clk/versatile/clk-realview.c
+++ b/drivers/clk/versatile/clk-realview.c
@@ -6,7 +6,6 @@
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
  */
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/versatile/clk-sp810.c 
b/drivers/clk/versatile/clk-sp810.c
index a96dd8e53fdb..64b0129a0216 100644
--- a/drivers/clk/versatile/clk-sp810.c
+++ b/drivers/clk/versatile/clk-sp810.c
@@ -12,7 +12,8 @@
  */
 
 #include 
-#include 
+#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/versatile/clk-versatile.c 
b/drivers/clk/versatile/clk-versatile.c
index 7a4f8635bd1e..71fa5da89afd 100644
--- a/drivers/clk/versatile/clk-versatile.c
+++ b/drivers/clk/versatile/clk-versatile.c
@@ -8,8 +8,6 @@
  * published by the Free Software Foundation.
  */
 #include 
-#include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 35/45] clk: zynq: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Sören Brinkmann 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/zynq/clkc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c
index de614384bb44..38a65c3e62fc 100644
--- a/drivers/clk/zynq/clkc.c
+++ b/drivers/clk/zynq/clkc.c
@@ -19,6 +19,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 29/45] clk: bcm: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Alex Elder 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/bcm/clk-kona.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c
index 79a98506c433..5638de8c6489 100644
--- a/drivers/clk/bcm/clk-kona.c
+++ b/drivers/clk/bcm/clk-kona.c
@@ -16,6 +16,7 @@
 
 #include 
 #include 
+#include 
 
 /*
  * "Policies" affect the frequencies of bus clocks provided by a
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 27/45] clk: ux500: Remove clk.h and clkdev.h includes

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver. Also remove clkdev.h in files that aren't using
it.

Cc: Linus Walleij 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/ux500/abx500-clk.c   | 1 -
 drivers/clk/ux500/clk.h  | 3 ++-
 drivers/clk/ux500/u8500_clk.c| 1 -
 drivers/clk/ux500/u8500_of_clk.c | 2 --
 drivers/clk/ux500/u8540_clk.c| 1 -
 drivers/clk/ux500/u9540_clk.c| 2 --
 6 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/clk/ux500/abx500-clk.c b/drivers/clk/ux500/abx500-clk.c
index 3e5e05101302..222425d08ab6 100644
--- a/drivers/clk/ux500/abx500-clk.c
+++ b/drivers/clk/ux500/abx500-clk.c
@@ -13,7 +13,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/ux500/clk.h b/drivers/clk/ux500/clk.h
index a2bb92d85ee0..b42485da704e 100644
--- a/drivers/clk/ux500/clk.h
+++ b/drivers/clk/ux500/clk.h
@@ -10,10 +10,11 @@
 #ifndef __UX500_CLK_H
 #define __UX500_CLK_H
 
-#include 
 #include 
 #include 
 
+struct clk;
+
 struct clk *clk_reg_prcc_pclk(const char *name,
  const char *parent_name,
  resource_size_t phy_base,
diff --git a/drivers/clk/ux500/u8500_clk.c b/drivers/clk/ux500/u8500_clk.c
index 4626b97b7d83..1c7b639d9222 100644
--- a/drivers/clk/ux500/u8500_clk.c
+++ b/drivers/clk/ux500/u8500_clk.c
@@ -7,7 +7,6 @@
  * License terms: GNU General Public License (GPL) version 2
  */
 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/ux500/u8500_of_clk.c b/drivers/clk/ux500/u8500_of_clk.c
index e319ef912dc6..c3e3b20e4b43 100644
--- a/drivers/clk/ux500/u8500_of_clk.c
+++ b/drivers/clk/ux500/u8500_of_clk.c
@@ -8,8 +8,6 @@
  */
 
 #include 
-#include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/ux500/u8540_clk.c b/drivers/clk/ux500/u8540_clk.c
index 20c8add90d11..d0de335ea1e9 100644
--- a/drivers/clk/ux500/u8540_clk.c
+++ b/drivers/clk/ux500/u8540_clk.c
@@ -7,7 +7,6 @@
  * License terms: GNU General Public License (GPL) version 2
  */
 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/ux500/u9540_clk.c b/drivers/clk/ux500/u9540_clk.c
index 44794782e7e0..179bd3871b34 100644
--- a/drivers/clk/ux500/u9540_clk.c
+++ b/drivers/clk/ux500/u9540_clk.c
@@ -7,8 +7,6 @@
  * License terms: GNU General Public License (GPL) version 2
  */
 
-#include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 06/45] clk: nomadik: Remove clk.h and clkdev.h includes

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver. This driver also includes clkdev.h even though
it isn't used, so drop it too and add slab.h to make sure
everything still compiles.

Cc: Linus Walleij 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-nomadik.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
index c9487179f25f..e4d8a991c58f 100644
--- a/drivers/clk/clk-nomadik.c
+++ b/drivers/clk/clk-nomadik.c
@@ -8,8 +8,7 @@
 #define pr_fmt(fmt) "Nomadik SRC clocks: " fmt
 
 #include 
-#include 
-#include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 36/45] clk: Include clk.h in clk.c

[Stephen Boyd]

This file implements the clk API and so it should include clk.h
directly instead of indirectly including it through
clk-provider.h.

Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ddb4b541016f..89e531a3f384 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -9,6 +9,7 @@
  * Standard functionality for the common clock API.  See Documentation/clk.txt
  */
 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 08/45] clk: rk808: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.

Cc: Chris Zhong 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-rk808.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-rk808.c b/drivers/clk/clk-rk808.c
index 83902b9cd49e..0fee2f4ca258 100644
--- a/drivers/clk/clk-rk808.c
+++ b/drivers/clk/clk-rk808.c
@@ -15,7 +15,6 @@
  * more details.
  */
 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 24/45] clk: socfpga: Remove clk.h and clkdev.h includes

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver. The clkdev.h include isn't used either, remove
it and add in slab.h to make sure things keep compiling.

Cc: Dinh Nguyen 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/socfpga/clk-gate-a10.c   | 1 +
 drivers/clk/socfpga/clk-gate.c   | 3 +--
 drivers/clk/socfpga/clk-periph-a10.c | 1 +
 drivers/clk/socfpga/clk-periph.c | 3 +--
 drivers/clk/socfpga/clk-pll-a10.c| 1 +
 drivers/clk/socfpga/clk-pll.c| 3 +--
 drivers/clk/socfpga/clk.h| 1 -
 7 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/clk/socfpga/clk-gate-a10.c 
b/drivers/clk/socfpga/clk-gate-a10.c
index 83c6780ff4b2..538ca504dea1 100644
--- a/drivers/clk/socfpga/clk-gate-a10.c
+++ b/drivers/clk/socfpga/clk-gate-a10.c
@@ -13,6 +13,7 @@
  * You should have received a copy of the GNU General Public License along with
  * this program.  If not, see .
  */
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/socfpga/clk-gate.c b/drivers/clk/socfpga/clk-gate.c
index 82449cd76fd7..37e0bb60ac68 100644
--- a/drivers/clk/socfpga/clk-gate.c
+++ b/drivers/clk/socfpga/clk-gate.c
@@ -15,8 +15,7 @@
  * Based from clk-highbank.c
  *
  */
-#include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/socfpga/clk-periph-a10.c 
b/drivers/clk/socfpga/clk-periph-a10.c
index 9d0181b5a6a4..64f93acbbd25 100644
--- a/drivers/clk/socfpga/clk-periph-a10.c
+++ b/drivers/clk/socfpga/clk-periph-a10.c
@@ -13,6 +13,7 @@
  * You should have received a copy of the GNU General Public License along with
  * this program.  If not, see .
  */
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/socfpga/clk-periph.c b/drivers/clk/socfpga/clk-periph.c
index 83aeaa219d14..ab9c8164a98f 100644
--- a/drivers/clk/socfpga/clk-periph.c
+++ b/drivers/clk/socfpga/clk-periph.c
@@ -15,8 +15,7 @@
  * Based from clk-highbank.c
  *
  */
-#include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/socfpga/clk-pll-a10.c 
b/drivers/clk/socfpga/clk-pll-a10.c
index 1178b11babca..402d630bd531 100644
--- a/drivers/clk/socfpga/clk-pll-a10.c
+++ b/drivers/clk/socfpga/clk-pll-a10.c
@@ -13,6 +13,7 @@
  * You should have received a copy of the GNU General Public License along with
  * this program.  If not, see .
  */
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/socfpga/clk-pll.c b/drivers/clk/socfpga/clk-pll.c
index 8f26b5234947..c7f463172e4b 100644
--- a/drivers/clk/socfpga/clk-pll.c
+++ b/drivers/clk/socfpga/clk-pll.c
@@ -15,8 +15,7 @@
  * Based from clk-highbank.c
  *
  */
-#include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/socfpga/clk.h b/drivers/clk/socfpga/clk.h
index 603973ab7e29..f4219202844a 100644
--- a/drivers/clk/socfpga/clk.h
+++ b/drivers/clk/socfpga/clk.h
@@ -18,7 +18,6 @@
 #define __SOCFPGA_CLK_H
 
 #include 
-#include 
 
 /* Clock Manager offsets */
 #define CLKMGR_CTRL0x0
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 45/45] clk: Remove clk.h from clk-provider.h

[Stephen Boyd]

Remove clk.h from clk-provider.h so that we can clearly split clk
providers from clk consumers. This will allow us to quickly
detect when clock providers are using the consumer APIs by
looking at the includes.

Signed-off-by: Stephen Boyd 
---
 include/linux/clk-provider.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 78842f46f152..36fa555ff431 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -11,7 +11,6 @@
 #ifndef __LINUX_CLK_PROVIDER_H
 #define __LINUX_CLK_PROVIDER_H
 
-#include 
 #include 
 #include 
 
@@ -33,6 +32,7 @@
 #define CLK_GET_ACCURACY_NOCACHE BIT(8) /* do not use the cached clk accuracy 
*/
 #define CLK_RECALC_NEW_RATES   BIT(9) /* recalc rates after notifications */
 
+struct clk;
 struct clk_hw;
 struct clk_core;
 struct dentry;
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 18/45] clk: mvebu: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Only include the header if necessary. The
clkdev.h include isn't used here either, so drop it and add in
slab.h to keep things compiling.

Cc: Boris Brezillon 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/mvebu/clk-cpu.c | 3 ++-
 drivers/clk/mvebu/common.c  | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c
index 3821a88077ea..86888a658d4c 100644
--- a/drivers/clk/mvebu/clk-cpu.c
+++ b/drivers/clk/mvebu/clk-cpu.c
@@ -10,7 +10,8 @@
  * warranty of any kind, whether express or implied.
  */
 #include 
-#include 
+#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/mvebu/common.c b/drivers/clk/mvebu/common.c
index 15b370ff3748..4a22429cd7a2 100644
--- a/drivers/clk/mvebu/common.c
+++ b/drivers/clk/mvebu/common.c
@@ -13,8 +13,8 @@
  */
 
 #include 
+#include 
 #include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 17/45] clk: mmp: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver. The clkdev.h include isn't used either, so drop
it and add in slab.h to keep things compiling.

Cc: Chao Xie 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/mmp/clk-apbc.c | 1 -
 drivers/clk/mmp/clk-apmu.c | 1 -
 drivers/clk/mmp/clk.c  | 3 +--
 3 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/clk/mmp/clk-apbc.c b/drivers/clk/mmp/clk-apbc.c
index 09d41c717c52..4c717db05f2d 100644
--- a/drivers/clk/mmp/clk-apbc.c
+++ b/drivers/clk/mmp/clk-apbc.c
@@ -10,7 +10,6 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/mmp/clk-apmu.c b/drivers/clk/mmp/clk-apmu.c
index cdcf2d7f321e..47b5542ce50f 100644
--- a/drivers/clk/mmp/clk-apmu.c
+++ b/drivers/clk/mmp/clk-apmu.c
@@ -10,7 +10,6 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/mmp/clk.c b/drivers/clk/mmp/clk.c
index cf038ef54c59..61893fe73251 100644
--- a/drivers/clk/mmp/clk.c
+++ b/drivers/clk/mmp/clk.c
@@ -1,7 +1,6 @@
 #include 
-#include 
 #include 
-#include 
+#include 
 #include 
 #include 
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 41/45] clk: pistachio: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Andrew Bresticker 
Cc: Ralf Baechle 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/pistachio/clk.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/pistachio/clk.c b/drivers/clk/pistachio/clk.c
index 85faa83e1bd7..698cad4f509e 100644
--- a/drivers/clk/pistachio/clk.c
+++ b/drivers/clk/pistachio/clk.c
@@ -6,6 +6,7 @@
  * version 2, as published by the Free Software Foundation.
  */
 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 37/45] clk: cdce925: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Mike Looijmans 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-cdce925.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c
index 85fafb41e6ca..089bf88ffa8d 100644
--- a/drivers/clk/clk-cdce925.c
+++ b/drivers/clk/clk-cdce925.c
@@ -10,6 +10,7 @@
  * Copyright (C) 2014, Topic Embedded Products
  * Licenced under GPL
  */
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 34/45] clk: ti: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Tero Kristo 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/ti/apll.c| 1 +
 drivers/clk/ti/clk-33xx.c| 1 +
 drivers/clk/ti/clk-3xxx-legacy.c | 1 +
 drivers/clk/ti/clk-3xxx.c| 1 +
 drivers/clk/ti/clk-43xx.c| 1 +
 drivers/clk/ti/clk-dra7-atl.c| 1 +
 drivers/clk/ti/clk.c | 1 +
 drivers/clk/ti/clockdomain.c | 1 +
 drivers/clk/ti/dpll.c| 1 +
 drivers/clk/ti/fapll.c   | 1 +
 10 files changed, 10 insertions(+)

diff --git a/drivers/clk/ti/apll.c b/drivers/clk/ti/apll.c
index 49baf3831546..671f4d89db93 100644
--- a/drivers/clk/ti/apll.c
+++ b/drivers/clk/ti/apll.c
@@ -15,6 +15,7 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/ti/clk-33xx.c b/drivers/clk/ti/clk-33xx.c
index 028b33783d38..9616bcdba220 100644
--- a/drivers/clk/ti/clk-33xx.c
+++ b/drivers/clk/ti/clk-33xx.c
@@ -16,6 +16,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/clk/ti/clk-3xxx-legacy.c b/drivers/clk/ti/clk-3xxx-legacy.c
index 0b61548d569b..0fbf8a917955 100644
--- a/drivers/clk/ti/clk-3xxx-legacy.c
+++ b/drivers/clk/ti/clk-3xxx-legacy.c
@@ -15,6 +15,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c
index 757636d166cf..5df21b258658 100644
--- a/drivers/clk/ti/clk-3xxx.c
+++ b/drivers/clk/ti/clk-3xxx.c
@@ -16,6 +16,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/clk/ti/clk-43xx.c b/drivers/clk/ti/clk-43xx.c
index 3795fce8a830..39a594c0d100 100644
--- a/drivers/clk/ti/clk-43xx.c
+++ b/drivers/clk/ti/clk-43xx.c
@@ -16,6 +16,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index 19e543a32e2b..2e14dfb588f4 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -16,6 +16,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/ti/clk.c b/drivers/clk/ti/clk.c
index 64bb5e8a3b8c..7132cec33f00 100644
--- a/drivers/clk/ti/clk.c
+++ b/drivers/clk/ti/clk.c
@@ -15,6 +15,7 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c
index b82ef07f3403..41eb5d105846 100644
--- a/drivers/clk/ti/clockdomain.c
+++ b/drivers/clk/ti/clockdomain.c
@@ -15,6 +15,7 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/ti/dpll.c b/drivers/clk/ti/dpll.c
index 2aacf7a3bcae..74e94b9bae55 100644
--- a/drivers/clk/ti/dpll.c
+++ b/drivers/clk/ti/dpll.c
@@ -15,6 +15,7 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
index 730aa62454a2..f158c2ab019d 100644
--- a/drivers/clk/ti/fapll.c
+++ b/drivers/clk/ti/fapll.c
@@ -9,6 +9,7 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 43/45] clk: ti: Switch clk-provider.h include to clk.h

[Stephen Boyd]

This file isn't a clock provider but uses the consumer API, so
include clk.h instead of clk-provider.h.

Cc: Tero Kristo 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/ti/clk-2xxx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/ti/clk-2xxx.c b/drivers/clk/ti/clk-2xxx.c
index c808ab3d2bb2..20cf5eed8c3d 100644
--- a/drivers/clk/ti/clk-2xxx.c
+++ b/drivers/clk/ti/clk-2xxx.c
@@ -16,7 +16,7 @@
 
 #include 
 #include 
-#include 
+#include 
 #include 
 
 static struct ti_dt_clk omap2xxx_clks[] = {
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 21/45] clk: rockchip: Properly include clk.h

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Only include clk.h if it's actually used.

Cc: Heiko Stuebner 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/rockchip/clk-cpu.c   | 1 +
 drivers/clk/rockchip/clk-mmc-phase.c | 1 +
 drivers/clk/rockchip/clk-pll.c   | 1 -
 drivers/clk/rockchip/clk-rk3188.c| 1 +
 drivers/clk/rockchip/clk.h   | 4 ++--
 5 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/rockchip/clk-cpu.c b/drivers/clk/rockchip/clk-cpu.c
index fb7721bd37e6..330870a6d8bf 100644
--- a/drivers/clk/rockchip/clk-cpu.c
+++ b/drivers/clk/rockchip/clk-cpu.c
@@ -35,6 +35,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include "clk.h"
 
diff --git a/drivers/clk/rockchip/clk-mmc-phase.c 
b/drivers/clk/rockchip/clk-mmc-phase.c
index e9f8df324e7c..3244c6e391d7 100644
--- a/drivers/clk/rockchip/clk-mmc-phase.c
+++ b/drivers/clk/rockchip/clk-mmc-phase.c
@@ -14,6 +14,7 @@
  */
 
 #include 
+#include 
 #include 
 #include "clk.h"
 
diff --git a/drivers/clk/rockchip/clk-pll.c b/drivers/clk/rockchip/clk-pll.c
index 76027261f7ed..1f88dd158b93 100644
--- a/drivers/clk/rockchip/clk-pll.c
+++ b/drivers/clk/rockchip/clk-pll.c
@@ -17,7 +17,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include "clk.h"
diff --git a/drivers/clk/rockchip/clk-rk3188.c 
b/drivers/clk/rockchip/clk-rk3188.c
index e4f9d472f1ff..91ea848c9d18 100644
--- a/drivers/clk/rockchip/clk-rk3188.c
+++ b/drivers/clk/rockchip/clk-rk3188.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/rockchip/clk.h b/drivers/clk/rockchip/clk.h
index 6b092673048a..1b16781b67c5 100644
--- a/drivers/clk/rockchip/clk.h
+++ b/drivers/clk/rockchip/clk.h
@@ -24,8 +24,8 @@
 #define CLK_ROCKCHIP_CLK_H
 
 #include 
-#include 
-#include 
+
+struct clk;
 
 #define HIWORD_UPDATE(val, mask, shift) \
((val) << (shift) | (mask) << ((shift) + 16))
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 33/45] clk: sunxi: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Chen-Yu Tsai 
Cc: Maxime Ripard 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/sunxi/clk-mod0.c   | 3 ++-
 drivers/clk/sunxi/clk-sun8i-mbus.c | 2 +-
 drivers/clk/sunxi/clk-sun9i-core.c | 2 +-
 drivers/clk/sunxi/clk-sun9i-mmc.c  | 3 ++-
 drivers/clk/sunxi/clk-sunxi.c  | 2 ++
 drivers/clk/sunxi/clk-usb.c| 3 ++-
 6 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/sunxi/clk-mod0.c b/drivers/clk/sunxi/clk-mod0.c
index 9d028aec58e5..39ba5c3d5d3a 100644
--- a/drivers/clk/sunxi/clk-mod0.c
+++ b/drivers/clk/sunxi/clk-mod0.c
@@ -14,8 +14,9 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
-#include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/clk/sunxi/clk-sun8i-mbus.c 
b/drivers/clk/sunxi/clk-sun8i-mbus.c
index 14cd026064bf..bf117a636d23 100644
--- a/drivers/clk/sunxi/clk-sun8i-mbus.c
+++ b/drivers/clk/sunxi/clk-sun8i-mbus.c
@@ -14,8 +14,8 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
-#include 
 #include 
 
 #include "clk-factors.h"
diff --git a/drivers/clk/sunxi/clk-sun9i-core.c 
b/drivers/clk/sunxi/clk-sun9i-core.c
index 887f4ea161bb..6c4c98324d3c 100644
--- a/drivers/clk/sunxi/clk-sun9i-core.c
+++ b/drivers/clk/sunxi/clk-sun9i-core.c
@@ -14,8 +14,8 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/sunxi/clk-sun9i-mmc.c 
b/drivers/clk/sunxi/clk-sun9i-mmc.c
index 710c273648d7..abc9a216b36c 100644
--- a/drivers/clk/sunxi/clk-sun9i-mmc.c
+++ b/drivers/clk/sunxi/clk-sun9i-mmc.c
@@ -14,8 +14,9 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index 9a82f17d2d73..3be234138d1d 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -14,6 +14,8 @@
  * GNU General Public License for more details.
  */
 
+#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/sunxi/clk-usb.c b/drivers/clk/sunxi/clk-usb.c
index 3a25f9588e67..ecaf9dadcf6b 100644
--- a/drivers/clk/sunxi/clk-usb.c
+++ b/drivers/clk/sunxi/clk-usb.c
@@ -14,8 +14,9 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 19/45] clk: mxs: Include clk.h in C files that use it

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. The clk.h include is being included in all
mxs files because it's part of mxs/clk.h even though nothing
actually requires it in that file. Move the clk.h include to the
C files that are actually using it and remove the clk.h include
from the header file. The clkdev.h include isn't used either, so
drop it too.

Cc: Shawn Guo 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/mxs/clk-div.c   | 1 -
 drivers/clk/mxs/clk-frac.c  | 1 -
 drivers/clk/mxs/clk-imx23.c | 3 +--
 drivers/clk/mxs/clk-imx28.c | 2 +-
 drivers/clk/mxs/clk-pll.c   | 1 -
 drivers/clk/mxs/clk-ref.c   | 1 -
 drivers/clk/mxs/clk.h   | 3 ++-
 7 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/clk/mxs/clk-div.c b/drivers/clk/mxs/clk-div.c
index 90e1da93877e..049ee27d5a22 100644
--- a/drivers/clk/mxs/clk-div.c
+++ b/drivers/clk/mxs/clk-div.c
@@ -9,7 +9,6 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/mxs/clk-frac.c b/drivers/clk/mxs/clk-frac.c
index e6aa6b567d68..73f0240569ac 100644
--- a/drivers/clk/mxs/clk-frac.c
+++ b/drivers/clk/mxs/clk-frac.c
@@ -9,7 +9,6 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/mxs/clk-imx23.c b/drivers/clk/mxs/clk-imx23.c
index 32216f9b7f03..f01876af6bb8 100644
--- a/drivers/clk/mxs/clk-imx23.c
+++ b/drivers/clk/mxs/clk-imx23.c
@@ -9,9 +9,8 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
-#include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c
index a68670868baa..6b572b759f9a 100644
--- a/drivers/clk/mxs/clk-imx28.c
+++ b/drivers/clk/mxs/clk-imx28.c
@@ -9,9 +9,9 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
-#include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/mxs/clk-pll.c b/drivers/clk/mxs/clk-pll.c
index fadae41833ec..d4ca79a868e0 100644
--- a/drivers/clk/mxs/clk-pll.c
+++ b/drivers/clk/mxs/clk-pll.c
@@ -9,7 +9,6 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/mxs/clk-ref.c b/drivers/clk/mxs/clk-ref.c
index 4adeed6c2f94..495f99b7965e 100644
--- a/drivers/clk/mxs/clk-ref.c
+++ b/drivers/clk/mxs/clk-ref.c
@@ -9,7 +9,6 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/mxs/clk.h b/drivers/clk/mxs/clk.h
index f07d821dd75d..a4590956d2a2 100644
--- a/drivers/clk/mxs/clk.h
+++ b/drivers/clk/mxs/clk.h
@@ -12,7 +12,8 @@
 #ifndef __MXS_CLK_H
 #define __MXS_CLK_H
 
-#include 
+struct clk;
+
 #include 
 #include 
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 01/45] clk: axi-clkgen: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.

Cc: Lars-Peter Clausen 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-axi-clkgen.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-axi-clkgen.c b/drivers/clk/clk-axi-clkgen.c
index e619285c6def..3bcd42fbb55e 100644
--- a/drivers/clk/clk-axi-clkgen.c
+++ b/drivers/clk/clk-axi-clkgen.c
@@ -10,7 +10,6 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 23/45] clk: sirf: Properly include clk.h

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Move the include of clk.h into
clk-common.c because that's the only file that's really using
clk.h, even if it's included into the atlas6 and prima2 files.

Cc: Barry Song 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/sirf/clk-atlas6.c | 1 -
 drivers/clk/sirf/clk-common.c | 2 ++
 drivers/clk/sirf/clk-prima2.c | 1 -
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/sirf/clk-atlas6.c b/drivers/clk/sirf/clk-atlas6.c
index d63b76ca60c3..c5eaa9d16247 100644
--- a/drivers/clk/sirf/clk-atlas6.c
+++ b/drivers/clk/sirf/clk-atlas6.c
@@ -10,7 +10,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/sirf/clk-common.c b/drivers/clk/sirf/clk-common.c
index 9fc285d784d3..2f64d4beeb52 100644
--- a/drivers/clk/sirf/clk-common.c
+++ b/drivers/clk/sirf/clk-common.c
@@ -7,6 +7,8 @@
  * Licensed under GPLv2 or later.
  */
 
+#include 
+
 #define KHZ 1000
 #define MHZ (KHZ * KHZ)
 
diff --git a/drivers/clk/sirf/clk-prima2.c b/drivers/clk/sirf/clk-prima2.c
index 6968e2ebcd8a..f92c40264342 100644
--- a/drivers/clk/sirf/clk-prima2.c
+++ b/drivers/clk/sirf/clk-prima2.c
@@ -10,7 +10,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 09/45] clk: si5351: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Sebastian Hesselbarth 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-si5351.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
index e39e1e680b3c..9e6de57eae3b 100644
--- a/drivers/clk/clk-si5351.c
+++ b/drivers/clk/clk-si5351.c
@@ -18,7 +18,7 @@
 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 05/45] clk: mux: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.

Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-mux.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-mux.c b/drivers/clk/clk-mux.c
index 6066a01b20ea..c705cf573569 100644
--- a/drivers/clk/clk-mux.c
+++ b/drivers/clk/clk-mux.c
@@ -10,7 +10,6 @@
  * Simple multiplexer clock implementation
  */
 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 03/45] clk: clps711x: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.

Cc: Alexander Shiyan 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-clps711x.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-clps711x.c b/drivers/clk/clk-clps711x.c
index 715eec1a9902..ff4ef4f1df62 100644
--- a/drivers/clk/clk-clps711x.c
+++ b/drivers/clk/clk-clps711x.c
@@ -9,7 +9,6 @@
  * (at your option) any later version.
  */
 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 20/45] clk: nxp: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.

Cc: Joachim Eastwood 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/nxp/clk-lpc18xx-cgu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/nxp/clk-lpc18xx-cgu.c 
b/drivers/clk/nxp/clk-lpc18xx-cgu.c
index 81e9e1c788f4..e0a3cb8970ab 100644
--- a/drivers/clk/nxp/clk-lpc18xx-cgu.c
+++ b/drivers/clk/nxp/clk-lpc18xx-cgu.c
@@ -8,7 +8,6 @@
  * warranty of any kind, whether express or implied.
  */
 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 02/45] clk: cdce706: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Max Filippov 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-cdce706.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk-cdce706.c b/drivers/clk/clk-cdce706.c
index f01164fada5d..21830526fd8e 100644
--- a/drivers/clk/clk-cdce706.c
+++ b/drivers/clk/clk-cdce706.c
@@ -10,6 +10,7 @@
  * published by the Free Software Foundation.
  */
 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 00/45] Remove clk.h from clk-provider.h (clk drivers part)

[Stephen Boyd]

This is the third set in a series of patches that removes
clk.h from clk-provider.h. This allows us to clearly see what
provider drivers are using the consumer API (clk.h) by
checking the includes. Currently clk.h is included by
clk-provider.h even though it doesn't need to, so quite a few
clk provider drivers are relying on the implicit include.

Stephen Boyd (45):
  clk: axi-clkgen: Remove clk.h include
  clk: cdce706: Include clk.h
  clk: clps711x: Remove clk.h include
  clk: efm32gg: Remove clk.h include
  clk: mux: Remove clk.h include
  clk: nomadik: Remove clk.h and clkdev.h includes
  clk: palmas: Remove clkdev.h includes
  clk: rk808: Remove clk.h include
  clk: si5351: Include clk.h
  clk: twl6040: Remove clk.h include
  clk: u300: Remove clk.h include
  clk: wm831x: Remove clk.h include
  clk: hisilicon: Remove clk.h include
  clk: keystone: Remove clk.h include
  clk: mediatek: Properly include clk.h
  clk: meson8b: Properly include clk.h
  clk: mmp: Remove clk.h include
  clk: mvebu: Remove clk.h include
  clk: mxs: Include clk.h in C files that use it
  clk: nxp: Remove clk.h include
  clk: rockchip: Properly include clk.h
  clk: samsung: Properly include clk.h and clkdev.h
  clk: sirf: Properly include clk.h
  clk: socfpga: Remove clk.h and clkdev.h includes
  clk: socfpga: Remove clk.h include
  clk: tegra: Properly include clk.h
  clk: ux500: Remove clk.h and clkdev.h includes
  clk: versatile: Remove clk.h and clkdev.h includes
  clk: bcm: Include clk.h
  clk: highbank: Include clk.h
  clk: qcom: Include clk.h
  clk: st: Include clk.h
  clk: sunxi: Include clk.h
  clk: ti: Include clk.h
  clk: zynq: Include clk.h
  clk: Include clk.h in clk.c
  clk: cdce925: Include clk.h
  clk: moxart: Include clk.h
  clk: si570: Include clk.h
  clk: ingenic: Include clk.h
  clk: pistachio: Include clk.h
  clk: samsung: s5pv210-audss: Include clk.h
  clk: ti: Switch clk-provider.h include to clk.h
  clk: at91: Include clk.h and slab.h
  clk: Remove clk.h from clk-provider.h

 drivers/clk/at91/clk-slow.c   | 2 ++
 drivers/clk/bcm/clk-kona.c| 1 +
 drivers/clk/clk-axi-clkgen.c  | 1 -
 drivers/clk/clk-cdce706.c | 1 +
 drivers/clk/clk-cdce925.c | 1 +
 drivers/clk/clk-clps711x.c| 1 -
 drivers/clk/clk-efm32gg.c | 1 -
 drivers/clk/clk-highbank.c| 1 +
 drivers/clk/clk-moxart.c  | 1 +
 drivers/clk/clk-mux.c | 1 -
 drivers/clk/clk-nomadik.c | 3 +--
 drivers/clk/clk-palmas.c  | 1 -
 drivers/clk/clk-rk808.c   | 1 -
 drivers/clk/clk-si5351.c  | 2 +-
 drivers/clk/clk-si570.c   | 1 +
 drivers/clk/clk-twl6040.c | 1 -
 drivers/clk/clk-u300.c| 2 +-
 drivers/clk/clk-wm831x.c  | 1 -
 drivers/clk/clk.c | 1 +
 drivers/clk/hisilicon/clk-hi3620.c| 2 --
 drivers/clk/hisilicon/clk-hip04.c | 2 --
 drivers/clk/hisilicon/clk.c   | 3 +--
 drivers/clk/hisilicon/clkgate-separated.c | 2 --
 drivers/clk/ingenic/cgu.c | 1 +
 drivers/clk/keystone/gate.c   | 1 -
 drivers/clk/keystone/pll.c| 1 -
 drivers/clk/mediatek/clk-gate.h   | 3 ++-
 drivers/clk/mediatek/clk-mt8135.c | 1 +
 drivers/clk/mediatek/clk-mt8173.c | 1 +
 drivers/clk/mediatek/clk-mtk.h| 3 ++-
 drivers/clk/meson/clk-cpu.c   | 1 +
 drivers/clk/meson/clkc.c  | 1 -
 drivers/clk/mmp/clk-apbc.c| 1 -
 drivers/clk/mmp/clk-apmu.c| 1 -
 drivers/clk/mmp/clk.c | 3 +--
 drivers/clk/mvebu/clk-cpu.c   | 3 ++-
 drivers/clk/mvebu/common.c| 2 +-
 drivers/clk/mxs/clk-div.c | 1 -
 drivers/clk/mxs/clk-frac.c| 1 -
 drivers/clk/mxs/clk-imx23.c   | 3 +--
 drivers/clk/mxs/clk-imx28.c   | 2 +-
 drivers/clk/mxs/clk-pll.c | 1 -
 drivers/clk/mxs/clk-ref.c | 1 -
 drivers/clk/mxs/clk.h | 3 ++-
 drivers/clk/nxp/clk-lpc18xx-cgu.c | 1 -
 drivers/clk/pistachio/clk.c   | 1 +
 drivers/clk/qcom/mmcc-msm8960.c   | 1 +
 drivers/clk/rockchip/clk-cpu.c| 1 +
 drivers/clk/rockchip/clk-mmc-phase.c  | 1 +
 drivers/clk/rockchip/clk-pll.c| 1 -
 drivers/clk/rockchip/clk-rk3188.c | 1 +
 drivers/clk/rockchip/clk.h| 4 ++--
 drivers/clk/samsung/clk-cpu.c | 3 +++
 drivers/clk/samsung/clk-exynos-audss.c| 3 ++-
 drivers/clk/samsung/clk-exynos-clkout.c   | 2 +-
 drivers/clk/samsung/clk-exynos3250.c  | 2 --
 drivers/clk/samsung/clk-exynos4.c | 2 +-
 drivers/clk/samsung/clk-exynos4415.c  | 2 --
 drivers/clk/samsung/clk-exynos5250.c  | 2 --
 drivers/clk/samsung/clk-exynos5260.c  | 2 --
 

[PATCH 13/45] clk: hisilicon: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver. Also drop the clkdev.h include in files that
aren't using it.

Cc: Bintian Wang 
Cc: Zhangfei Gao 
Cc: Haojian Zhuang 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/hisilicon/clk-hi3620.c| 2 --
 drivers/clk/hisilicon/clk-hip04.c | 2 --
 drivers/clk/hisilicon/clk.c   | 3 +--
 drivers/clk/hisilicon/clkgate-separated.c | 2 --
 4 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/clk/hisilicon/clk-hi3620.c 
b/drivers/clk/hisilicon/clk-hi3620.c
index 715d34a5ef9b..5502803a391e 100644
--- a/drivers/clk/hisilicon/clk-hi3620.c
+++ b/drivers/clk/hisilicon/clk-hi3620.c
@@ -25,13 +25,11 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
 #include 
 #include 
-#include 
 
 #include 
 
diff --git a/drivers/clk/hisilicon/clk-hip04.c 
b/drivers/clk/hisilicon/clk-hip04.c
index 132b57a0ce09..8ca967308343 100644
--- a/drivers/clk/hisilicon/clk-hip04.c
+++ b/drivers/clk/hisilicon/clk-hip04.c
@@ -24,13 +24,11 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
 #include 
 #include 
-#include 
 
 #include 
 
diff --git a/drivers/clk/hisilicon/clk.c b/drivers/clk/hisilicon/clk.c
index c90a89739b03..155e2e6c8316 100644
--- a/drivers/clk/hisilicon/clk.c
+++ b/drivers/clk/hisilicon/clk.c
@@ -24,15 +24,14 @@
  */
 
 #include 
-#include 
 #include 
+#include 
 #include 
 #include 
 #include 
 #include 
 #include 
 #include 
-#include 
 
 #include "clk.h"
 
diff --git a/drivers/clk/hisilicon/clkgate-separated.c 
b/drivers/clk/hisilicon/clkgate-separated.c
index b03d5a7246f9..a47812f56a17 100644
--- a/drivers/clk/hisilicon/clkgate-separated.c
+++ b/drivers/clk/hisilicon/clkgate-separated.c
@@ -25,10 +25,8 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
-#include 
 
 #include "clk.h"
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 10/45] clk: twl6040: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.

Cc: Peter Ujfalusi 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-twl6040.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-twl6040.c b/drivers/clk/clk-twl6040.c
index 4a755135bcd3..3094b10c6149 100644
--- a/drivers/clk/clk-twl6040.c
+++ b/drivers/clk/clk-twl6040.c
@@ -20,7 +20,6 @@
 *
 */
 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 15/45] clk: mediatek: Properly include clk.h

[Stephen Boyd]

We don't need to include clk.h in header files, just forward
declare struct clk here. This leads us to a few places where the
include of clk.h was missing in C files. Add them.

Cc: James Liao 
Cc: Henry Chen 
Cc: Sascha Hauer 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/mediatek/clk-gate.h   | 3 ++-
 drivers/clk/mediatek/clk-mt8135.c | 1 +
 drivers/clk/mediatek/clk-mt8173.c | 1 +
 drivers/clk/mediatek/clk-mtk.h| 3 ++-
 4 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/mediatek/clk-gate.h b/drivers/clk/mediatek/clk-gate.h
index 6b6780b1e9c5..11e25c992948 100644
--- a/drivers/clk/mediatek/clk-gate.h
+++ b/drivers/clk/mediatek/clk-gate.h
@@ -16,9 +16,10 @@
 #define __DRV_CLK_GATE_H
 
 #include 
-#include 
 #include 
 
+struct clk;
+
 struct mtk_clk_gate {
struct clk_hw   hw;
struct regmap   *regmap;
diff --git a/drivers/clk/mediatek/clk-mt8135.c 
b/drivers/clk/mediatek/clk-mt8135.c
index 08b4b849b491..07c21e44b4b3 100644
--- a/drivers/clk/mediatek/clk-mt8135.c
+++ b/drivers/clk/mediatek/clk-mt8135.c
@@ -12,6 +12,7 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/mediatek/clk-mt8173.c 
b/drivers/clk/mediatek/clk-mt8173.c
index 4b9e04cdf7e8..2e0f17be9ea0 100644
--- a/drivers/clk/mediatek/clk-mt8173.c
+++ b/drivers/clk/mediatek/clk-mt8173.c
@@ -12,6 +12,7 @@
  * GNU General Public License for more details.
  */
 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/mediatek/clk-mtk.h b/drivers/clk/mediatek/clk-mtk.h
index 9dda9d8ad10b..624716c4776b 100644
--- a/drivers/clk/mediatek/clk-mtk.h
+++ b/drivers/clk/mediatek/clk-mtk.h
@@ -17,9 +17,10 @@
 
 #include 
 #include 
-#include 
 #include 
 
+struct clk;
+
 #define MAX_MUX_GATE_BIT   31
 #define INVALID_MUX_GATE_BIT   (MAX_MUX_GATE_BIT + 1)
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 07/45] clk: palmas: Remove clkdev.h includes

[Stephen Boyd]

This driver includes clkdev.h even though it isn't used, so drop
it.

Cc: Peter Ujfalusi 
Cc: Nishanth Menon 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-palmas.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-palmas.c b/drivers/clk/clk-palmas.c
index 45a535ab48aa..8e3039f0c3f9 100644
--- a/drivers/clk/clk-palmas.c
+++ b/drivers/clk/clk-palmas.c
@@ -18,7 +18,6 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 04/45] clk: efm32gg: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.

Cc: Uwe Kleine-König 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/clk-efm32gg.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-efm32gg.c b/drivers/clk/clk-efm32gg.c
index 73a8d0ff530c..bac4553f04b8 100644
--- a/drivers/clk/clk-efm32gg.c
+++ b/drivers/clk/clk-efm32gg.c
@@ -6,7 +6,6 @@
  * the terms of the GNU General Public License version 2 as published by the
  * Free Software Foundation.
  */
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 16/45] clk: meson8b: Properly include clk.h

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Only include clk.h if it's actually used.

Cc: Carlo Caione 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/meson/clk-cpu.c | 1 +
 drivers/clk/meson/clkc.c| 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/meson/clk-cpu.c b/drivers/clk/meson/clk-cpu.c
index 71ad493b94df..f7c30ea54ca8 100644
--- a/drivers/clk/meson/clk-cpu.c
+++ b/drivers/clk/meson/clk-cpu.c
@@ -35,6 +35,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #define MESON_CPU_CLK_CNTL10x00
diff --git a/drivers/clk/meson/clkc.c b/drivers/clk/meson/clkc.c
index b8c511c5e7a7..c83ae1367abc 100644
--- a/drivers/clk/meson/clkc.c
+++ b/drivers/clk/meson/clkc.c
@@ -15,7 +15,6 @@
  * this program.  If not, see .
  */
 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 14/45] clk: keystone: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.

Cc: Ivan Khoronzhuk 
Cc: Murali Karicheri 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/keystone/gate.c | 1 -
 drivers/clk/keystone/pll.c  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/clk/keystone/gate.c b/drivers/clk/keystone/gate.c
index 86f1e362eafb..aed5af23895b 100644
--- a/drivers/clk/keystone/gate.c
+++ b/drivers/clk/keystone/gate.c
@@ -10,7 +10,6 @@
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
  */
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/clk/keystone/pll.c b/drivers/clk/keystone/pll.c
index 4a375ead70e9..25443e4d139f 100644
--- a/drivers/clk/keystone/pll.c
+++ b/drivers/clk/keystone/pll.c
@@ -10,7 +10,6 @@
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
  */
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs

[Greg KH]

On Fri, Jul 10, 2015 at 11:46:07PM +0200, Pavel Machek wrote:
> On Fri 2015-07-10 14:50:12, Felipe Balbi wrote:
> > Hi,
> > 
> > On Thu, Jul 09, 2015 at 11:39:22PM +0200, Pavel Machek wrote:
> > > Hi!
> > > 
> > > sysfs should contain one value per file. This one has at least two,
> > > with nice english sentence as a bonus.
> > > 
> > > root@n900:/sys/devices/platform/6800.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> > > cat vbus
> > > Vbus off, timeout 1100 msec
> > > 
> > > :-(.
> > 
> > patches are always welcome.
> 
> You'd have to at least describe how you'd like to see it solved if you
> wanted to pretend you maintain it... 2 new attributes? What should be
> their names?
> 
> Signed-off-by: Pavel Machek 
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f6362d7..2e85300 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6900,7 +6900,7 @@ MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER
>  M:   Felipe Balbi 
>  L:   linux-...@vger.kernel.org
>  T:   git git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
> -S:   Maintained
> +S:   Odd fixes
>  F:   drivers/usb/musb/

Don't be a jerk, you are _this_ close to being added to my killfile...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: kdbus: credential faking

[Greg KH]

On Fri, Jul 10, 2015 at 10:47:32AM -0400, Stephen Smalley wrote:
> On 07/10/2015 09:43 AM, David Herrmann wrote:
> > Hi
> > 
> > On Fri, Jul 10, 2015 at 3:25 PM, Stephen Smalley  wrote:
> >> On 07/09/2015 06:22 PM, David Herrmann wrote:
> >>> To be clear, faking metadata has one use-case, and one use-case only:
> >>> dbus1 compatibility
> >>>
> >>> In dbus1, clients connect to a unix-socket placed in the file-system
> >>> hierarchy. To avoid breaking ABI for old clients, we support a
> >>> unix-kdbus proxy. This proxy is called systemd-bus-proxyd. It is
> >>> spawned once for each bus we proxy and simply remarshals messages from
> >>> the client to kdbus and vice versa.
> >>
> >> Is this truly necessary?  Can't the distributions just update the client
> >> side libraries to use kdbus if enabled and be done with it?  Doesn't
> >> this proxy undo many of the benefits of using kdbus in the first place?
> > 
> > We need binary compatibility to dbus1. There're millions of
> > applications and language bindings with dbus1 compiled in, which we
> > cannot suddenly break.
> 
> So, are you saying that there are many applications that statically link
> the dbus1 library implementation (thus the distributions can't just push
> an updated shared library that switches from using the socket to using
> kdbus), and that many of these applications are third party applications
> not packaged by the distributions (thus the distributions cannot just do
> a mass rebuild to update these applications too)?

Yes.

There are also programs that use "native" dbus libraries written in
other languages than C that use the unix-socket to talk the dbus
protocol to the system.  As a specific example, Go has one of these
libraries, and it's built statically into go binaries, so there is no
"system library" that could be updated for these binaries to avoid this
interface.

I'm sure over time that these libraries will move toward using kdbus
"directly" if it is present, but at the moment, we don't have that
luxury.

> Otherwise, I would think that the use of a socket would just be an
> implementation detail and you would be free to change it without
> affecting dbus1 library ABI compatibility.

I wish we could, but we can't break programs that are currently running
today, that would be pretty mean.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

[Josh Cartwright]

On Fri, Jul 10, 2015 at 07:06:23PM -0400, Chris Metcalf wrote:
> On 7/10/2015 6:45 PM, Josh Cartwright wrote:
> >>+static inline const struct cpumask *housekeeping_cpumask(void)
> >>>+{
> >>>+#ifdef CONFIG_NO_HZ_FULL
> >>>+  if (tick_nohz_full_enabled())
> >>>+  return housekeeping_mask;
> >>>+#endif
> >Just a small comment:
> >
> >We can take these checks out from under a #ifdef CONFIG_NO_HZ_FULL
> >check, given that are stubbed tick_nohz_full_enabled() defined above.
> 
> True for the "if" clause, but the "housekeeping_mask" variable is only defined
> under CONFIG_NO_HZ_FULL.

Indeed!  I should have read more carefully.

Sorry for the noise.

  Josh


signature.asc
Description: PGP signature

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

[Chris Metcalf]

On 7/10/2015 6:45 PM, Josh Cartwright wrote:

+static inline const struct cpumask *housekeeping_cpumask(void)
>+{
>+#ifdef CONFIG_NO_HZ_FULL
>+   if (tick_nohz_full_enabled())
>+   return housekeeping_mask;
>+#endif

Just a small comment:

We can take these checks out from under a #ifdef CONFIG_NO_HZ_FULL
check, given that are stubbed tick_nohz_full_enabled() defined above.


True for the "if" clause, but the "housekeeping_mask" variable is only defined
under CONFIG_NO_HZ_FULL.

--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 7/7] lib/vsprintf.c: Include clk.h

[Stephen Boyd]

This file uses the clk API so it should include clk.h directly
instead of indirectly including it through clk-provider.h.

Cc: Geert Uytterhoeven 
Signed-off-by: Stephen Boyd 
---

Please ack so this can go through clk-tree.

 lib/vsprintf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index da39c608a28c..95cd63b43b99 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -17,6 +17,7 @@
  */
 
 #include 
+#include 
 #include 
 #include   /* for KSYM_SYMBOL_LEN */
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 6/7] simplefb: Include clk.h

[Stephen Boyd]

This driver uses the consumer API, so include clk.h explicitly
instead of impliclty through the provider API.

Cc: Luc Verhaegen 
Cc: Hans de Goede 
Cc: Geert Uytterhoeven 
Cc: Maxime Ripard 
Cc: David Herrmann 
Cc: Tomi Valkeinen 
Signed-off-by: Stephen Boyd 
---

Please ack so this can go through clk-tree.

 drivers/video/fbdev/simplefb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
index 1085c0432158..52c5c7e63b52 100644
--- a/drivers/video/fbdev/simplefb.c
+++ b/drivers/video/fbdev/simplefb.c
@@ -26,6 +26,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 5/7] ACPI: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the includes here because these are
provider drivers.

Cc: Ken Xue 
Cc: Mika Westerberg 
Cc: Rafael J. Wysocki 
Signed-off-by: Stephen Boyd 
---

Please ack so this can go through clk-tree. Otherwise it's ok
to go through the acpi tree.

 drivers/acpi/acpi_apd.c  | 1 -
 drivers/acpi/acpi_lpss.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 3984ea96e5f7..a450e7af877c 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -16,7 +16,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include "internal.h"
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 569ee090343f..6817b18ed722 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -11,7 +11,6 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 4/7] clocksource: cadence_ttc: Remove clk-provider.h include

[Stephen Boyd]

This file doesn't use the clk provider APIs. Remove the include.

Cc: Michal Simek 
Cc: Daniel Lezcano 
Signed-off-by: Stephen Boyd 
---

Please ack if you want this to go through clk-tree, otherwise
it's ok to take it through the clocksource side.

 drivers/clocksource/cadence_ttc_timer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clocksource/cadence_ttc_timer.c 
b/drivers/clocksource/cadence_ttc_timer.c
index 510c8a1d37b3..5ea91e3818d0 100644
--- a/drivers/clocksource/cadence_ttc_timer.c
+++ b/drivers/clocksource/cadence_ttc_timer.c
@@ -16,7 +16,6 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 0/7] Remove clk.h from clk-provider.h (non-clk drivers part)

[Stephen Boyd]

This is the second set in a series of patches that removes
clk.h from clk-provider.h. This allows us to clearly see what
provider drivers are using the consumer API (clk.h) by
checking the includes. Currently clk.h is included by
clk-provider.h even though it doesn't need to so quite a few
clk provider drivers are relying on the implicit include.

Cc: Gerhard Sittig 
Cc: Scott Wood 
Cc: Anatolij Gustschin 
Cc: Sören Brinkmann 
Cc: Greg Kroah-Hartman 
Cc: Daniel Mack 
Cc: Haojian Zhuang 
Cc: Robert Jarzmik 
Cc: Mark Brown 
Cc: Michal Simek 
Cc: Daniel Lezcano 
Cc: Ken Xue 
Cc: Mika Westerberg 
Cc: Rafael J. Wysocki 
Cc: Luc Verhaegen 
Cc: Hans de Goede 
Cc: Geert Uytterhoeven 
Cc: Maxime Ripard 
Cc: David Herrmann 
Cc: Tomi Valkeinen 
Cc: Geert Uytterhoeven 

Stephen Boyd (7):
  powerpc/512x: clk: Include clk.h
  staging: clocking-wizard: Include clk.h
  spi: spi-pxa2xx: Remove clk.h include
  clocksource: cadence_ttc: Remove clk-provider.h include
  ACPI: Remove clk.h include
  simplefb: Include clk.h
  lib/vsprintf.c: Include clk.h

 arch/powerpc/platforms/512x/clock-commonclk.c   | 1 +
 drivers/acpi/acpi_apd.c | 1 -
 drivers/acpi/acpi_lpss.c| 1 -
 drivers/clocksource/cadence_ttc_timer.c | 1 -
 drivers/spi/spi-pxa2xx-pci.c| 1 -
 drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 +
 drivers/video/fbdev/simplefb.c  | 1 +
 lib/vsprintf.c  | 1 +
 8 files changed, 4 insertions(+), 4 deletions(-)

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/7] spi: spi-pxa2xx: Remove clk.h include

[Stephen Boyd]

Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.

Cc: Daniel Mack 
Cc: Haojian Zhuang 
Cc: Robert Jarzmik 
Cc: Mark Brown 
Signed-off-by: Stephen Boyd 
---

Please ack so this can go through the clk tree. Otherwise
it's ok to go through spi tree.

 drivers/spi/spi-pxa2xx-pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c
index 3cfd4357489a..d19d7f28aecb 100644
--- a/drivers/spi/spi-pxa2xx-pci.c
+++ b/drivers/spi/spi-pxa2xx-pci.c
@@ -7,7 +7,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/7] staging: clocking-wizard: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Sören Brinkmann 
Cc: Greg Kroah-Hartman 
Signed-off-by: Stephen Boyd 
---

Please ack so this can go through the clk-tree.

 drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c 
b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
index 5455bf3d5a91..b8e2f611fd47 100644
--- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
+++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
@@ -19,6 +19,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/7] powerpc/512x: clk: Include clk.h

[Stephen Boyd]

This clock provider uses the consumer API, so include clk.h
explicitly.

Cc: Gerhard Sittig 
Cc: Scott Wood 
Cc: Anatolij Gustschin 
Signed-off-by: Stephen Boyd 
---

Please ack so this can go through the clk-tree.

 arch/powerpc/platforms/512x/clock-commonclk.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/512x/clock-commonclk.c 
b/arch/powerpc/platforms/512x/clock-commonclk.c
index f691bcabd710..c50ea76ba66c 100644
--- a/arch/powerpc/platforms/512x/clock-commonclk.c
+++ b/arch/powerpc/platforms/512x/clock-commonclk.c
@@ -12,6 +12,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH] ixgbe: Remove bimodal SR-IOV disabling

[Rose, Gregory V]

> -Original Message-
> From: Alex Williamson [mailto:alex.william...@redhat.com]
> Sent: Friday, July 10, 2015 3:44 PM
> To: Rose, Gregory V
> Cc: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T;
> net...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ixgbe: Remove bimodal SR-IOV disabling
> 
> On Fri, 2015-07-10 at 21:36 +, Rose, Gregory V wrote:
> >
> > > -Original Message-
> > > From: Alex Williamson [mailto:alex.william...@redhat.com]
> > > Sent: Friday, July 10, 2015 2:32 PM
> > > To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T
> > > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Rose,
> > > Gregory V
> > > Subject: [PATCH] ixgbe: Remove bimodal SR-IOV disabling
> > >
> > > When unbinding an SR-IOV device with VFs configured from ixgbe, the
> > > driver behaves in one of two ways.  If max_vfs was specified, the
> > > SR-IOV state is disabled, removing the VFs.  The occurs regardless
> > > of whether the VF count was later modified through sysfs.  If
> > > however max_vfs is zero, such as by not specifying the module
> > > parameter, the VFs persist after the PF is unbound from ixgbe.  If
> > > the PF is then bound to vfio-pci to be assigned to a VM, the PF is
> non-functional.
> > >
> > > >From the comment, commit da36b64736cf ("ixgbe: Implement PCI SR-IOV
> > > sysfs callback operation") clearly intended this alternate behavior,
> > > but probably didn't realize the PF doesn't work in this mode.
> > >
> > > This bimodal behavior is confusing to users and results in a state
> > > where the PF is broken for other uses unless the user sets
> > > sriov_numvfs to zero prior to unbinding the device.  Remove this
> > > behavior so that VFs are removed and the PF is functional for other
> > > uses after unbind, regardless of the way VFs are enabled.
> > >
> > > Signed-off-by: Alex Williamson 
> > > Cc: Greg Rose 
> > > Cc: Jeff Kirsher 
> > > ---
> > >
> > > I can only think that not disabling SR-IOV was meant to enable some
> > > sort of persistence for VFs, but that's probably better accomplished
> > > with either udev rules and/or modprobe.d install scripts.
> > >
> > >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |7 +--
> > >  1 file changed, 1 insertion(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > > b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > > index 5be12a0..de04e3e 100644
> > > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > > @@ -8810,12 +8810,7 @@ static void ixgbe_remove(struct pci_dev *pdev)
> > >   unregister_netdev(netdev);
> > >
> > >  #ifdef CONFIG_PCI_IOV
> > > - /*
> > > -  * Only disable SR-IOV on unload if the user specified the now
> > > -  * deprecated max_vfs module parameter.
> > > -  */
> > > - if (max_vfs)
> > > - ixgbe_disable_sriov(adapter);
> > > + ixgbe_disable_sriov(adapter);
> > >  #endif
> > >   ixgbe_clear_interrupt_scheme(adapter);
> > >
> >
> > Please remove max_vfs module parameter - it is deprecated and should be
> removed from upstream builds.  Dave let us get away with a kernel module a
> few years ago because the other necessary infrastructure to enable SR-IOV
> virtual functions via the PCIe interface was not available.  Now that it's
> there it should be removed and vendors/end users should be forced to move
> away from this.
> 
> I can't really say I'm in favor of removing that option.  It's probably
> going to break a lot of people because doing the udev rules right is hard.
> The sysfs sriov interface has been tossed over the wall as the right way
> to do things, but there's really no infrastructure to facilitate even the
> simple peanut butter, everybody gets the same number of VFs, interface
> that max_vfs provides.  I think the existence of this bug is probably a
> good indication that the sysfs interface has not really been adopted yet.
> Thanks,

Alright, I'll go with that reasoning.

Acked-by: Greg Rose 


> 
> Alex

N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i

[PATCH] arm64: Remove clk-provider.h include

[Stephen Boyd]

This file doesn't use the clk provider APIs. Remove the include.

Cc: Catalin Marinas 
Cc: Will Deacon 
Signed-off-by: Stephen Boyd 
---

Please ack if you want this to go through the clk-tree (along
with quite a few other patches that do the same thing). Otherwise,
it's fine if it's applied to the arm64 tree.

 arch/arm64/kernel/setup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
index f3067d4d4e35..926ae8d9abc5 100644
--- a/arch/arm64/kernel/setup.c
+++ b/arch/arm64/kernel/setup.c
@@ -34,7 +34,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] vhost-blk: Add vhost-blk support v6

[Ming Lin]

On Sat, Dec 1, 2012 at 5:33 PM, Asias He  wrote:
> vhost-blk is an in-kernel virito-blk device accelerator.
>
> Due to lack of proper in-kernel AIO interface, this version converts
> guest's I/O request to bio and use submit_bio() to submit I/O directly.
> So this version any supports raw block device as guest's disk image,
> e.g. /dev/sda, /dev/ram0. We can add file based image support to
> vhost-blk once we have in-kernel AIO interface. There are some work in
> progress for in-kernel AIO interface from Dave Kleikamp and Zach Brown:
>
>http://marc.info/?l=linux-fsdevel=133312234313122
>
> Performance evaluation:
> -
> LKVM: Fio with libaio ioengine on 1 Fusion IO device
> IOPS(k)BeforeAfterImprovement
> seq-read   107   121  +13.0%
> seq-write  130   179  +37.6%
> rnd-read   102   122  +19.6%
> rnd-write  125   159  +27.0%
>
> QEMU: Fio with libaio ioengine on 1 Fusion IO device
> IOPS(k)BeforeAfterImprovement
> seq-read   76123  +61.8%
> seq-write  139   173  +24.4%
> rnd-read   73120  +64.3%
> rnd-write  75156  +108.0%
>
> QEMU: Fio with libaio ioengine on 1 Ramdisk device
> IOPS(k)BeforeAfterImprovement
> seq-read   138   437  +216%
> seq-write  191   436  +128%
> rnd-read   137   426  +210%
> rnd-write  140   415  +196%
>
> QEMU: Fio with libaio ioengine on 8 Ramdisk device
> 50% read + 50% write
> IOPS(k)BeforeAfterImprovement
> randrw 64/64 189/189  +195%/+195%
>
> Userspace bits:
> -
> 1) LKVM
> The latest vhost-blk userspace bits for kvm tool can be found here:
> g...@github.com:asias/linux-kvm.git blk.vhost-blk
>
> 2) QEMU
> The latest vhost-blk userspace prototype for QEMU can be found here:
> g...@github.com:asias/qemu.git blk.vhost-blk
>
> Changes in v6:
> - Use inline req_page_list to reduce kmalloc
> - Switch to single thread model, thanks mst!
> - Wait until requests fired before vhost_blk_flush to be finished
>
> Changes in v5:
> - Do not assume the buffer layout
> - Fix wakeup race
>
> Changes in v4:
> - Mark req->status as userspace pointer
> - Use __copy_to_user() instead of copy_to_user() in vhost_blk_set_status()
> - Add if (need_resched()) schedule() in blk thread
> - Kill vhost_blk_stop_vq() and move it into vhost_blk_stop()
> - Use vq_err() instead of pr_warn()
> - Fail un Unsupported request
> - Add flush in vhost_blk_set_features()
>
> Changes in v3:
> - Sending REQ_FLUSH bio instead of vfs_fsync, thanks Christoph!
> - Check file passed by user is a raw block device file
>
> Acked-by: David S. Miller 
> Signed-off-by: Asias He 

Hi Asias,

Is this still under development or stopped?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/7] ARM: hisi: Remove clk-provider.h include

[Stephen Boyd]

This file doesn't use the clk provider APIs. Remove the include.

Cc: Haojian Zhuang 
Cc: Wei Xu 
Signed-off-by: Stephen Boyd 
---

Please ack if you want this to go through clk-tree.

 arch/arm/mach-hisi/hisilicon.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-hisi/hisilicon.c b/arch/arm/mach-hisi/hisilicon.c
index c6bd7c7bd4aa..8cc62150116a 100644
--- a/arch/arm/mach-hisi/hisilicon.c
+++ b/arch/arm/mach-hisi/hisilicon.c
@@ -11,7 +11,6 @@
  * published by the Free Software Foundation.
 */
 
-#include 
 #include 
 #include 
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 6/7] ARM: s3c64xx: Remove clk-provider.h include

[Stephen Boyd]

This file doesn't use the clk provider APIs. Remove the include.

Signed-off-by: Stephen Boyd 
---
 arch/arm/mach-s3c64xx/common.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-s3c64xx/common.c b/arch/arm/mach-s3c64xx/common.c
index 16547f2641a3..25d6676f8d6e 100644
--- a/arch/arm/mach-s3c64xx/common.c
+++ b/arch/arm/mach-s3c64xx/common.c
@@ -21,7 +21,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/7] ARM: at91: Remove clk-provider.h include

[Stephen Boyd]

This file doesn't use the clk provider APIs. Remove the include.

Cc: Alexandre Belloni 
Cc: Boris Brezillon 
Cc: Nicolas Ferre 
Signed-off-by: Stephen Boyd 
---

Please ack if you want this to go through clk-tree.

 arch/arm/mach-at91/at91rm9200.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-at91/at91rm9200.c b/arch/arm/mach-at91/at91rm9200.c
index eaf58f88ef5d..685826c4a710 100644
--- a/arch/arm/mach-at91/at91rm9200.c
+++ b/arch/arm/mach-at91/at91rm9200.c
@@ -8,7 +8,6 @@
  * Licensed under GPLv2 or later.
  */
 
-#include 
 #include 
 #include 
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 5/7] ARM: orion5x: Remove clk-provider.h include

[Stephen Boyd]

This file doesn't use the clk provider APIs. Remove the include.

Cc: Thomas Petazzoni 
Signed-off-by: Stephen Boyd 
---

Please ack if you want this to go through clk-tree.

 arch/arm/mach-orion5x/board-dt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-orion5x/board-dt.c b/arch/arm/mach-orion5x/board-dt.c
index 79f033b1ddff..d0871786dd8a 100644
--- a/arch/arm/mach-orion5x/board-dt.c
+++ b/arch/arm/mach-orion5x/board-dt.c
@@ -16,7 +16,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/7] ARM: keystone: Remove clk-provider.h include

[Stephen Boyd]

This file doesn't use the clk provider APIs. Remove the include.

Cc: Nishanth Menon 
Cc: Sekhar Nori 
Cc: Santosh Shilimkar 
Signed-off-by: Stephen Boyd 
---

Please ack if you want this to go through clk-tree.

 arch/arm/mach-keystone/pm_domain.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-keystone/pm_domain.c 
b/arch/arm/mach-keystone/pm_domain.c
index edea697e8253..e283939a216f 100644
--- a/arch/arm/mach-keystone/pm_domain.c
+++ b/arch/arm/mach-keystone/pm_domain.c
@@ -16,7 +16,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 static struct dev_pm_domain keystone_pm_domain = {
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 7/7] ARM: OMAP2+: Include clk.h

[Stephen Boyd]

These files use the consumer API, so include clk.h explicitly.

Cc: Tero Kristo 
Cc: Tony Lindgren 
Signed-off-by: Stephen Boyd 
---

Please ack so this can be routed through clk-tree. Otherwise
when clk.h is removed from clk-provider.h these files will
fail to compile.

 arch/arm/mach-omap2/clock.c  | 1 +
 arch/arm/mach-omap2/omap_hwmod.c | 1 +
 arch/arm/mach-omap2/pm24xx.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index a699d7169307..f664dc664ded 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -20,6 +20,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index d78c12e7cb5e..de43e4c9a865 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -130,6 +130,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/arch/arm/mach-omap2/pm24xx.c b/arch/arm/mach-omap2/pm24xx.c
index b1aad7e1426c..2a1a4180d5d0 100644
--- a/arch/arm/mach-omap2/pm24xx.c
+++ b/arch/arm/mach-omap2/pm24xx.c
@@ -25,6 +25,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 0/7] Remove clk.h from clk-provider.h (ARM part)

[Stephen Boyd]

This is the first set in a series of patches that removes
clk.h from clk-provider.h. This allows us to clearly see what
provider drivers are using the consumer API (clk.h) by
checking the includes. Currently clk.h is included by
clk-provider.h even though it doesn't need to so quite a few
clk provider drivers are relying on the implicit include.

Stephen Boyd (7):
  ARM: at91: Remove clk-provider.h include
  ARM: hisi: Remove clk-provider.h include
  ARM: keystone: Remove clk-provider.h include
  ARM: mvebu: Remove clk-provider.h include
  ARM: orion5x: Remove clk-provider.h include
  ARM: s3c64xx: Remove clk-provider.h include
  ARM: OMAP2+: Include clk.h

 arch/arm/mach-at91/at91rm9200.c| 1 -
 arch/arm/mach-hisi/hisilicon.c | 1 -
 arch/arm/mach-keystone/pm_domain.c | 1 -
 arch/arm/mach-mvebu/board-v7.c | 1 -
 arch/arm/mach-omap2/clock.c| 1 +
 arch/arm/mach-omap2/omap_hwmod.c   | 1 +
 arch/arm/mach-omap2/pm24xx.c   | 1 +
 arch/arm/mach-orion5x/board-dt.c   | 1 -
 arch/arm/mach-s3c64xx/common.c | 1 -
 9 files changed, 3 insertions(+), 6 deletions(-)

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 4/7] ARM: mvebu: Remove clk-provider.h include

[Stephen Boyd]

This file doesn't use the clk provider APIs. Remove the include.

Cc: Thomas Petazzoni 
Cc: Gregory CLEMENT 
Signed-off-by: Stephen Boyd 
---

Please ack if you want this to go through clk-tree.

 arch/arm/mach-mvebu/board-v7.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-mvebu/board-v7.c b/arch/arm/mach-mvebu/board-v7.c
index afee9083ad92..9f739f3cad4c 100644
--- a/arch/arm/mach-mvebu/board-v7.c
+++ b/arch/arm/mach-mvebu/board-v7.c
@@ -14,7 +14,6 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

[Josh Cartwright]

On Fri, Jul 10, 2015 at 03:37:25PM -0400, Chris Metcalf wrote:
> Normally the tilegx networking shim sends irqs to all the cores
> to distribute the load of processing incoming-packet interrupts,
> so that you can get to multiple Gb's of traffic inbound.
> 
> However, in nohz_full mode we don't want to interrupt the
> nohz_full cores by default, so we limit the set of cores we use
> to only the online housekeeping cores.
> 
> To make client code easier to read, we introduce a new nohz_full
> accessor, housekeeping_cpumask(), which returns a pointer to the
> housekeeping_mask if nohz_full is enabled, and otherwise returns
> the cpu_possible_mask.
> 
> Signed-off-by: Chris Metcalf 
> ---
[..]
> +static inline const struct cpumask *housekeeping_cpumask(void)
> +{
> +#ifdef CONFIG_NO_HZ_FULL
> + if (tick_nohz_full_enabled())
> + return housekeeping_mask;
> +#endif

Just a small comment:

We can take these checks out from under a #ifdef CONFIG_NO_HZ_FULL
check, given that are stubbed tick_nohz_full_enabled() defined above.

  Josh


signature.asc
Description: PGP signature

Re: [PATCH] ixgbe: Remove bimodal SR-IOV disabling

[Alex Williamson]

On Fri, 2015-07-10 at 21:36 +, Rose, Gregory V wrote:
> 
> > -Original Message-
> > From: Alex Williamson [mailto:alex.william...@redhat.com]
> > Sent: Friday, July 10, 2015 2:32 PM
> > To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T
> > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Rose, Gregory V
> > Subject: [PATCH] ixgbe: Remove bimodal SR-IOV disabling
> > 
> > When unbinding an SR-IOV device with VFs configured from ixgbe, the driver
> > behaves in one of two ways.  If max_vfs was specified, the SR-IOV state is
> > disabled, removing the VFs.  The occurs regardless of whether the VF count
> > was later modified through sysfs.  If however max_vfs is zero, such as by
> > not specifying the module parameter, the VFs persist after the PF is
> > unbound from ixgbe.  If the PF is then bound to vfio-pci to be assigned to
> > a VM, the PF is non-functional.
> > 
> > >From the comment, commit da36b64736cf ("ixgbe: Implement PCI SR-IOV
> > sysfs callback operation") clearly intended this alternate behavior, but
> > probably didn't realize the PF doesn't work in this mode.
> > 
> > This bimodal behavior is confusing to users and results in a state where
> > the PF is broken for other uses unless the user sets sriov_numvfs to zero
> > prior to unbinding the device.  Remove this behavior so that VFs are
> > removed and the PF is functional for other uses after unbind, regardless
> > of the way VFs are enabled.
> > 
> > Signed-off-by: Alex Williamson 
> > Cc: Greg Rose 
> > Cc: Jeff Kirsher 
> > ---
> > 
> > I can only think that not disabling SR-IOV was meant to enable some sort
> > of persistence for VFs, but that's probably better accomplished with
> > either udev rules and/or modprobe.d install scripts.
> > 
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |7 +--
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > index 5be12a0..de04e3e 100644
> > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > @@ -8810,12 +8810,7 @@ static void ixgbe_remove(struct pci_dev *pdev)
> > unregister_netdev(netdev);
> > 
> >  #ifdef CONFIG_PCI_IOV
> > -   /*
> > -* Only disable SR-IOV on unload if the user specified the now
> > -* deprecated max_vfs module parameter.
> > -*/
> > -   if (max_vfs)
> > -   ixgbe_disable_sriov(adapter);
> > +   ixgbe_disable_sriov(adapter);
> >  #endif
> > ixgbe_clear_interrupt_scheme(adapter);
> > 
> 
> Please remove max_vfs module parameter - it is deprecated and should be 
> removed from upstream builds.  Dave let us get away with a kernel module a 
> few years ago because the other necessary infrastructure to enable SR-IOV 
> virtual functions via the PCIe interface was not available.  Now that it's 
> there it should be removed and vendors/end users should be forced to move 
> away from this.

I can't really say I'm in favor of removing that option.  It's probably
going to break a lot of people because doing the udev rules right is
hard.  The sysfs sriov interface has been tossed over the wall as the
right way to do things, but there's really no infrastructure to
facilitate even the simple peanut butter, everybody gets the same number
of VFs, interface that max_vfs provides.  I think the existence of this
bug is probably a good indication that the sysfs interface has not
really been adopted yet.  Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Good Day

[abdullahmohad02]

Good Day

I know that this mail will come to you as a surprise as we have never
met before, but need not to worry as I am contacting you independently
of my Investigation and no one is informed of this communication. I
need your Urgent assistance in transferring the sum of $7.5 million
immediately to your Private account. The money has been here in our
Bank lying dormant for years now without anybody coming for the claim
of it.

I want to release the money to you as the relative to our deceased
customer (The account owner) MR. ANDREAS SCHRANNER who died a long
with his supposed NEXT OF KIN since 2003. The Banking law here does
not allow such money to stay more than 13 Years, because the money
will be recalled to the Bank treasury account as unclaimed fund.

By indicating your interest contact me through my private email
address ( abdullahmoha...@gmail.com )  I will send you the full
details on how the Business will be executed. Please respond urgently
and delete if you are not interested

Regards,

Mr. Abdullah Mohad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: Linux 4.2-rc1

[Ming Lei]

On Sat, Jul 11, 2015 at 5:47 AM, Linus Torvalds
 wrote:
> But my patch (which is committed now) solves it all for you?
>
> I'm going to just assume it's timing, and there is no major real reason why
> it started triggering just now...

Now I see it, the issue is triggered when firmware request is
timed out, and Shuah's reported should be caused by the following
commit 0cb64249(firmware_loader: abort request if wait_for_completion
is interrupted).

But your patch is correct for this issue too.

Thanks,
Ming

>
>  Linus
>
> On Jul 10, 2015 2:33 PM, "Shuah Khan"  wrote:
>>
>> On 07/10/2015 11:11 AM, Linus Torvalds wrote:
>> > On Fri, Jul 10, 2015 at 9:58 AM, Shuah Khan 
>> > wrote:
>> >>
>> >> I am not sure why this patch would cause the problem I am seeing.
>> >> This patch itself looks like a cleanup type patch and doesn't
>> >> really fix a bug. I am building with this patch reverted at the
>> >> moment to confirm.
>> >
>> > Smells to me like it's just a timing issue, and that mayeb the bisect
>> > failed because it's not 100% repeatable. Or maybe it *was* 100%
>> > repeatable, but simply because that commit changed the timing of the
>> > bootup scripts etc.
>> >
>> > But yes, trying it with the revert in place is a good idea just to
>> > make sure. And perhaps checking that kernel more than a few times to
>> > verify just how repeatable it is.
>> >
>>
>> Quick update. Reverting didn't help. I think I mentioned I am seeing
>> hangs during poweroff and reboot. I am seeing hangs during boot as well.
>> I think there is a timing problem that manifests into the following
>> 3 variations:
>>
>> 1. NULL pointer dereference alert, boots fine and runs fine - hangs
>>during poweroff and reboot
>> 2. Hangs during boot. When booted in recovery, it runs into repeated
>>errors which looks very much like the same call trace I see in the
>>alert.
>>
>> Please see attached images. These two are rolling failures repeated
>> during udev initialization. It is related to firmware loading it looks
>> like.
>>
>> thanks,
>> -- Shuah
>>
>> --
>> Shuah Khan
>> Sr. Linux Kernel Developer
>> Open Source Innovation Group
>> Samsung Research America (Silicon Valley)
>> shua...@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC] mm/shrinker: define INIT_SHRINKER macro

[Andrew Morton]

On Fri, 10 Jul 2015 10:12:11 +0900 Sergey Senozhatsky 
 wrote:

> Shrinker API does not handle nicely unregister_shrinker() on a not-registered
> ->shrinker. Looking at shrinker users, they all have to (a) carry on some sort
> of a flag telling that "unregister_shrinker()" will not blow up... or (b) just
> be fishy
> 
> ...
>
> I was thinking of a trivial INIT_SHRINKER macro to init `struct shrinker'
> internal members (composed in email client, not tested)
> 
> include/linux/shrinker.h
> 
> #define INIT_SHRINKER(s)  \
>   do {\
>   (s)->nr_deferred = NULL;\
>   INIT_LIST_HEAD(&(s)->list); \
>   } while (0)

Spose so.  Although it would be simpler to change unregister_shrinker()
to bale out if list.next==NULL and then say "all zeroes is the
initialized state".

> --- a/include/linux/shrinker.h
> +++ b/include/linux/shrinker.h
> @@ -63,6 +63,12 @@ struct shrinker {
>  };
>  #define DEFAULT_SEEKS 2 /* A good number if you don't know better. */
>  
> +#define INIT_SHRINKER(s) \
> + do {\
> + INIT_LIST_HEAD(&(s)->list); \
> + (s)->nr_deferred = NULL;\
> + } while (0)
> +

The only reason to make this a macro would be so that it can be used at
compile-time, with something like

static struct shrinker my_shrinker = INIT_SHRINKER(_shrinker);

But as we're not planning on doing that, we implement it in C, please.

Also, shrinker_init() would be a better name.  Although we already
mucked up shrinker_register() and shrinker_unregister().


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[GIT PULL] clk: fixes for 4.2

[Stephen Boyd]

The following changes since commit 358bdf892f6bfacf20884b54a35ab038321f06f9:

  clk: stm32: Add clock driver for STM32F4[23]xxx devices (2015-06-22 16:17:01 
-0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git 
tags/clk-fixes-for-linus

for you to fetch changes up to 56551da9255f20ffd3a9711728a1a3ad4b7100af:

  drivers: clk: st: Incorrect register offset used for lock_status (2015-07-07 
16:05:08 -0700)


A small set of fixes for problems found by smatch in new drivers
that we added this rc and a handful of driver fixes that came in
during the merge window.


Daniel Thompson (1):
  clk: stm32: Fix out-by-one error path in the index lookup

David Dueck (1):
  clk: at91: do not leak resources

Gabriel Fernandez (3):
  drivers: clk: st: Remove unused code
  drivers: clk: st: Fix FSYN channel values
  drivers: clk: st: Fix mux bit-setting for Cortex A9 clocks

Giuseppe Cavallaro (1):
  drivers: clk: st: Fix flexgen lock init

Hai Li (1):
  clk: qcom: Use parent rate when set rate to pixel RCG clock

Pankaj Dev (2):
  drivers: clk: st: Add CLK_GET_RATE_NOCACHE flag to clocks
  drivers: clk: st: Incorrect register offset used for lock_status

Ray Jui (2):
  clk: iproc: fix memory leak from clock name
  clk: iproc: fix bit manipulation arithmetic

Sascha Hauer (1):
  clk: mediatek: mt8173: Fix enabling of critical clocks

 drivers/clk/at91/clk-h32mx.c  |  4 +++-
 drivers/clk/at91/clk-main.c   |  4 +++-
 drivers/clk/at91/clk-master.c |  8 ++--
 drivers/clk/at91/clk-pll.c|  8 ++--
 drivers/clk/at91/clk-system.c |  8 ++--
 drivers/clk/at91/clk-utmi.c   |  8 ++--
 drivers/clk/bcm/clk-iproc-asiu.c  |  6 +-
 drivers/clk/bcm/clk-iproc-pll.c   | 13 -
 drivers/clk/clk-stm32f4.c |  2 +-
 drivers/clk/mediatek/clk-mt8173.c | 26 +-
 drivers/clk/qcom/clk-rcg2.c   |  9 +++--
 drivers/clk/st/clk-flexgen.c  |  4 +++-
 drivers/clk/st/clkgen-fsyn.c  | 12 
 drivers/clk/st/clkgen-mux.c   | 10 ++
 drivers/clk/st/clkgen-pll.c   |  2 +-
 15 files changed, 74 insertions(+), 50 deletions(-)

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC PATCH v4 3/3] bpf: Introduce function for outputing data to perf event

[Alexei Starovoitov]

On 7/10/15 3:03 AM, He Kuang wrote:

There're scenarios that we need an eBPF program to record not only
kprobe point args, but also the PMU counters, time latencies or the
number of cache misses between two probe points and other information
when the probe point is entered.

This patch adds a new trace event to establish infrastruction for bpf to
output data to perf. Userspace perf tools can detect and use this event
as using the existing tracepoint events.

New bpf trace event entry in debugfs:

  /sys/kernel/debug/tracing/events/bpf/bpf_output_data

Userspace perf tools detect the new tracepoint event as:

  bpf:bpf_output_data  [Tracepoint event]


Nice! This approach looks cleanest so far.


+TRACE_EVENT(bpf_output_data,
+
+   TP_PROTO(u64 *src, int len),
+
+   TP_ARGS(src, len),
+
+   TP_STRUCT__entry(
+   __dynamic_array(u64,buf,len)
+   ),
+
+   TP_fast_assign(
+   memcpy(__get_dynamic_array(buf), src, len * sizeof(u64));


may be make it 'u8' array? The extra multiply and...


+static u64 bpf_output_trace_data(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
+{
+   void *src = (void *) (long) r1;
+   int size = (int) r2;
+
+   trace_bpf_output_data(src, size / sizeof(u64));


.. and this silent round down could be confusing to use.
With array of u8, the program can push any structured data into it
and let user space interpret it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] Add support for reading SMBIOS Slot number for PCI devices

[Jordan Hargrave]

From: Jordan Hargrave 

There currently isn't an easy way to determine which PCI devices belong to
system slots.  This patch adds support to read SMBIOS Type 9 (System Slots).

Signed-off-by: Jordan Hargrave 
---
 drivers/firmware/dmi_scan.c | 39 
 drivers/pci/pci-label.c | 89 +
 include/linux/dmi.h |  1 +
 3 files changed, 129 insertions(+)

diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index ac1ce4a..8f95897 100644
--- a/drivers/firmware/dmi_scan.c
+++ b/drivers/firmware/dmi_scan.c
@@ -356,6 +356,41 @@ static void __init dmi_save_extended_devices(const struct 
dmi_header *dm)
dmi_save_one_device(*d & 0x7f, dmi_string_nosave(dm, *(d - 1)));
 }
 
+static void __init dmi_save_dev_slot(int instance, int segment, int bus, int 
devfn, const char *name)
+{
+   struct dmi_dev_onboard *slot;
+   
+   slot = dmi_alloc(sizeof(*slot) + strlen(name) + 1);
+   if (!slot) {
+   printk(KERN_ERR "dmi_save_system_slot: out of memory.\n");
+   return;
+   }
+   slot->instance = instance;
+   slot->segment = segment;
+   slot->bus = bus;
+   slot->devfn = devfn;
+
+   strcpy((char *)[1], name);
+   slot->dev.type = DMI_DEV_TYPE_SYSTEM_SLOT;
+   slot->dev.name = (char *)[1];
+   slot->dev.device_data = slot;
+
+   list_add(>dev.list, _devices);
+}
+
+
+static void __init dmi_save_system_slot(const struct dmi_header *dm)
+{
+   const char *name;
+   const u8 *d = (u8*)dm;
+   
+   if (dm->type == DMI_ENTRY_SYSTEM_SLOT && dm->length >= 0x11) {
+   name = dmi_string_nosave(dm, *(d + 0x04));
+   dmi_save_dev_slot(*(u16 *)(d + 0x09), *(u16 *)(d + 0xD), 
+ *(d + 0xF), *(d + 0x10), name);
+   }
+}
+
 static void __init count_mem_devices(const struct dmi_header *dm, void *v)
 {
if (dm->type != DMI_ENTRY_MEM_DEVICE)
@@ -437,6 +472,10 @@ static void __init dmi_decode(const struct dmi_header *dm, 
void *dummy)
break;
case 41:/* Onboard Devices Extended Information */
dmi_save_extended_devices(dm);
+   break;
+   case 9: /* System Slots */
+   dmi_save_system_slot(dm);
+   break;
}
 }
 
diff --git a/drivers/pci/pci-label.c b/drivers/pci/pci-label.c
index 024b5c1..38dfb45 100644
--- a/drivers/pci/pci-label.c
+++ b/drivers/pci/pci-label.c
@@ -125,14 +125,103 @@ static struct attribute_group smbios_attr_group = {
.is_visible = smbios_instance_string_exist,
 };
 
+static int smbios_getslot(struct pci_dev *pdev)
+{
+   struct pci_dev *sdev;
+   struct dmi_dev_onboard *dslot;
+   const struct dmi_device *dmi;
+   u8 sub, sec, bus;
+
+   dmi = NULL;
+   if (pdev->is_virtfn) {
+   /* Get Physical device for SR-IOV */
+   pdev = pdev->physfn;
+   }
+   bus = pdev->bus->number;
+   while ((dmi = dmi_find_device(DMI_DEV_TYPE_SYSTEM_SLOT, NULL, dmi)) != 
NULL) {
+   sec = sub = -1;
+
+   dslot = dmi->device_data;
+   sdev = pci_get_domain_bus_and_slot(dslot->segment, dslot->bus, 
dslot->devfn);
+   if (sdev == NULL)
+   continue;
+
+   if (sdev->hdr_type == PCI_HEADER_TYPE_BRIDGE) {
+   pci_read_config_byte(sdev, PCI_SECONDARY_BUS, );
+   pci_read_config_byte(sdev, PCI_SUBORDINATE_BUS, );
+   if (bus >= sec && bus <= sub) {
+   /* device is child of bridge */
+   return dslot->instance;
+   }
+   }
+   if (pci_domain_nr(sdev->bus) == pci_domain_nr(pdev->bus) &&
+   sdev->bus->number == pdev->bus->number &&
+   PCI_SLOT(sdev->devfn) == PCI_SLOT(pdev->devfn)) {
+   /* Match domain:bus:dev.  If PCIE root, only match 
function */
+   if (PCI_FUNC(sdev->devfn) == PCI_FUNC(pdev->devfn) ||
+   pci_pcie_type(sdev) != PCI_EXP_TYPE_ROOT_PORT) {
+   return dslot->instance;
+   }
+   }
+   }
+   return -ENODEV;
+}
+ 
+static ssize_t smbiosslot_show(struct device *dev,
+  struct device_attribute *attr, char *buf)
+{
+   struct pci_dev *pdev;
+   int slot;
+ 
+   pdev = to_pci_dev(dev);
+   slot = smbios_getslot(pdev);
+   if (slot > 0) {
+   return scnprintf(buf, PAGE_SIZE, "%d\n", slot);
+   }
+   return 0;
+}
+
+static umode_t smbios_slot_exist(struct kobject *kobj, struct attribute *attr,
+int n)
+{
+   struct device *dev;
+   struct pci_dev *pdev;
+
+   dev = container_of(kobj, struct device, kobj);
+   pdev = 

Re: Linux 4.2-rc1

[Shuah Khan]

On 07/10/2015 03:47 PM, Linus Torvalds wrote:
> But my patch (which is committed now) solves it all for you?
> 
> I'm going to just assume it's timing, and there is no major real reason why
> it started triggering just now...
> 
>  Linus

Yes. With your patch I didn't see the problem.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shua...@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[GIT PULL] x86/ras material for 4.3 queue

[Luck, Tony]

Some of these almost made it into 4.2, then we found a bug and
delayed to fix it.  Bug fixes have now been merged back into
the original patch series.

The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754:

  Linux 4.2-rc1 (2015-07-05 11:01:52 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git 
tags/please-pull-ras-for-4.3

for you to fetch changes up to 60e23e3342d0ff1201e8ce160a3624bd2ce5ff79:

  x86/mce: Clear Local MCE opt-in before kexec (2015-07-06 14:21:12 -0700)


1) Chen Gong series to make mce logging safer in #MC context
2) Boris deleted drain_mcelog_buffer() - don't want/need it now
3) Ashok fixed a local machine check corner case with kexec


Ashok Raj (2):
  x86/mce: Remove unused function declarations
  x86/mce: Clear Local MCE opt-in before kexec

Borislav Petkov (1):
  x86/mce: Kill drain_mcelog_buffer()

Chen, Gong (4):
  x86/mce: Provide a lockless memory pool to save error records
  x86/mce: Don't use percpu workqueues
  x86/mce: Remove the MCE ring for Action Optional errors
  x86/mce: Avoid potential deadlock due to printk() in MCE context

 arch/x86/Kconfig  |   1 +
 arch/x86/include/asm/mce.h|   8 +-
 arch/x86/include/uapi/asm/mce.h   |   3 +-
 arch/x86/kernel/cpu/mcheck/Makefile   |   2 +-
 arch/x86/kernel/cpu/mcheck/mce-apei.c |   1 -
 arch/x86/kernel/cpu/mcheck/mce-genpool.c  |  99 +
 arch/x86/kernel/cpu/mcheck/mce-internal.h |  12 ++
 arch/x86/kernel/cpu/mcheck/mce.c  | 221 ++
 arch/x86/kernel/cpu/mcheck/mce_intel.c|  20 ++-
 arch/x86/kernel/process.c |   2 +
 arch/x86/kernel/smp.c |   2 +
 11 files changed, 242 insertions(+), 129 deletions(-)
 create mode 100644 arch/x86/kernel/cpu/mcheck/mce-genpool.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/3] special_mapping_fault() is broken

[Andrew Morton]

On Fri, 10 Jul 2015 18:51:21 +0200 Oleg Nesterov  wrote:

> special_mapping_fault() is absolutely broken. It seems it was always
> wrong, but this didn't matter until vdso/vvar started to use more than
> one page.
> 
> The patches are the same, just 1/3 was re-diffed on top of the recent
> 6b7339f4c31ad "mm: avoid setting up anonymous pages into file mapping"
> from Kirill.
> 
> And after this change vma_is_anonymous() becomes really trivial, it
> simply checks vm_ops == NULL. However, I do think the helper makes
> sense. There are a lot of ->vm_ops != NULL checks, the helper makes
> the caller's code more understandable (self-documented) and this is
> more grep-friendly.

I'm trying to work out which kernel version(s) this should go into,
without a lot of success.

What do we think the worst-case effects of the bug?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2] cris: arch-v10: kgdb: Add volatile for static variable is_dyn_brkp

[Chen Gang]

Within one C file, current gcc can optimize the global static variables
according to the C code, but it will skip assembly code -- it will pass
them to gas directly.

if the static variable is used between C code and assembly code in one C
file (e.g. is_dyn_brkp in kgdb.c), it needs volatile to let gcc know it
should not be optimized, or it may cause issue.

The related error in this case:

LD  init/built-in.o
  arch/cris/arch-v10/kernel/built-in.o: In function `kgdb_handle_breakpoint':
  (.text+0x2aca): undefined reference to `is_dyn_brkp'
  arch/cris/arch-v10/kernel/built-in.o: In function `is_static':
  kgdb.c:(.text+0x2ada): undefined reference to `is_dyn_brkp'


Signed-off-by: Chen Gang 
---
 arch/cris/arch-v10/kernel/kgdb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/cris/arch-v10/kernel/kgdb.c b/arch/cris/arch-v10/kernel/kgdb.c
index 5b61335..8faddd3 100644
--- a/arch/cris/arch-v10/kernel/kgdb.c
+++ b/arch/cris/arch-v10/kernel/kgdb.c
@@ -351,7 +351,7 @@ char internal_stack[INTERNAL_STACK_SIZE];
breakpoint to be handled. A static breakpoint uses the content of register
BRP as it is whereas a dynamic breakpoint requires subtraction with 2
in order to execute the instruction. The first breakpoint is static. */
-static unsigned char is_dyn_brkp = 0;
+static volatile unsigned char is_dyn_brkp;
 
 /* String library /
 /* Single-step over library functions creates trap loops. */
-- 
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] cris: arch-v10: kgdb: Use BAR instead of DTP0 for register P12

[Chen Gang]

For arch-v10, there is no DTP0 register, and at present, assembler know
BAR, so use BAR instead of DTP0, the related error (with allmodconfig):

CC  arch/cris/arch-v10/kernel/kgdb.o
  {standard input}: Assembler messages:
  {standard input}:6: Error: Illegal operands
  {standard input}:6: Error: Illegal operands

Signed-off-by: Chen Gang 
---
 arch/cris/arch-v10/kernel/kgdb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/cris/arch-v10/kernel/kgdb.c b/arch/cris/arch-v10/kernel/kgdb.c
index 22d846b..5b61335 100644
--- a/arch/cris/arch-v10/kernel/kgdb.c
+++ b/arch/cris/arch-v10/kernel/kgdb.c
@@ -970,7 +970,7 @@ asm ("\n"
 "  move $ibr,[cris_reg+0x4E]  ; P9,\n"
 "  move $irp,[cris_reg+0x52]  ; P10,\n"
 "  move $srp,[cris_reg+0x56]  ; P11,\n"
-"  move $dtp0,[cris_reg+0x5A] ; P12, register BAR, assembler might not 
know BAR\n"
+"  move $bar,[cris_reg+0x5A]  ; P12,\n"
 "; P13, register DCCR already saved\n"
 ";; Due to the old assembler-versions BRP might not be recognized\n"
 "  .word 0xE670  ; move brp,r0\n"
@@ -1063,7 +1063,7 @@ asm ("\n"
 "  move $ibr,[cris_reg+0x4E]  ; P9,\n"
 "  move $irp,[cris_reg+0x52]  ; P10,\n"
 "  move $srp,[cris_reg+0x56]  ; P11,\n"
-"  move $dtp0,[cris_reg+0x5A] ; P12, register BAR, assembler might not 
know BAR\n"
+"  move $bar,[cris_reg+0x5A]  ; P12,\n"
 "; P13, register DCCR already saved\n"
 ";; Due to the old assembler-versions BRP might not be recognized\n"
 "  .word 0xE670  ; move brp,r0\n"
-- 
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: musb-hdrc: "Vbus off, timeout 1100 msec" message does not belong in sysfs

[Pavel Machek]

On Fri 2015-07-10 14:50:12, Felipe Balbi wrote:
> Hi,
> 
> On Thu, Jul 09, 2015 at 11:39:22PM +0200, Pavel Machek wrote:
> > Hi!
> > 
> > sysfs should contain one value per file. This one has at least two,
> > with nice english sentence as a bonus.
> > 
> > root@n900:/sys/devices/platform/6800.ocp/480ab000.usb_otg_hs/musb-hdrc.0.auto#
> > cat vbus
> > Vbus off, timeout 1100 msec
> > 
> > :-(.
> 
> patches are always welcome.

You'd have to at least describe how you'd like to see it solved if you
wanted to pretend you maintain it... 2 new attributes? What should be
their names?

Signed-off-by: Pavel Machek 

diff --git a/MAINTAINERS b/MAINTAINERS
index f6362d7..2e85300 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6900,7 +6900,7 @@ MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER
 M: Felipe Balbi 
 L: linux-...@vger.kernel.org
 T: git git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
-S: Maintained
+S: Odd fixes
 F: drivers/usb/musb/
 
 MXL5007T MEDIA DRIVER


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 1/4] tools: iio: Move printf failure messages to stderr

[Hartmut Knaack]

Cristina Opriceana schrieb am 10.07.2015 um 12:56:
> Replace printf error messages with fprintf(stderr, ...) in order
> to ensure consistency and to make faults easier to identify.
> This patch uses coccinelle to detect and apply the changes.
> 

Hi Cristina,
I just had a look at the series. You have all cases I regard necessary
covered. There are however a few cases which probably qualify as error
messages, too. Please see inline.
However, for my personal taste, this could have been merged all in a
single patch. Especially the third patch should have been included in
this one (as during review, people certainly think that you missed the
second line, just to find it fixed two patches later).

> Signed-off-by: Cristina Opriceana 
> ---
> Changes in v2:
>  - s/failiure/failure
> 
>  tools/iio/generic_buffer.c| 17 ++---
>  tools/iio/iio_event_monitor.c |  6 +++---
>  tools/iio/iio_utils.c | 34 --
>  3 files changed, 33 insertions(+), 24 deletions(-)
> 
> diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c
> index 0e73723..2f4e12f 100644
> --- a/tools/iio/generic_buffer.c
> +++ b/tools/iio/generic_buffer.c
> @@ -271,7 +271,7 @@ int main(int argc, char **argv)
>   }
>  
>   if (device_name == NULL) {
> - printf("Device name not set\n");
> + fprintf(stderr, "Device name not set\n");
>   print_usage();
>   return -1;
>   }
> @@ -279,7 +279,7 @@ int main(int argc, char **argv)
>   /* Find the device requested */
>   dev_num = find_type_by_name(device_name, "iio:device");
>   if (dev_num < 0) {
> - printf("Failed to find the %s\n", device_name);
> + fprintf(stderr, "Failed to find the %s\n", device_name);
>   return dev_num;
>   }
>  
> @@ -307,7 +307,8 @@ int main(int argc, char **argv)
>   /* Verify the trigger exists */
>   trig_num = find_type_by_name(trigger_name, "trigger");
>   if (trig_num < 0) {
> - printf("Failed to find the trigger %s\n", trigger_name);
> + fprintf(stderr, "Failed to find the trigger %s\n",
> + trigger_name);
>   ret = trig_num;
>   goto error_free_triggername;
>   }
> @@ -323,7 +324,7 @@ int main(int argc, char **argv)
>*/
>   ret = build_channel_array(dev_dir_name, , _channels);
>   if (ret) {
> - printf("Problem reading scan element information\n");
> + fprintf(stderr, "Problem reading scan element information\n");
>   printf("diag %s\n", dev_dir_name);

My preference would even be to print it all in just one fprintf.

>   goto error_free_triggername;
>   }
> @@ -350,7 +351,8 @@ int main(int argc, char **argv)
>   dev_dir_name,
>   trigger_name);
>   if (ret < 0) {
> - printf("Failed to write current_trigger file\n");
> + fprintf(stderr,
> + "Failed to write current_trigger file\n");
>   goto error_free_buf_dir_name;
>   }
>   }
> @@ -382,7 +384,7 @@ int main(int argc, char **argv)
>   fp = open(buffer_access, O_RDONLY | O_NONBLOCK);
>   if (fp == -1) { /* TODO: If it isn't there make the node */
>   ret = -errno;
> - printf("Failed to open %s\n", buffer_access);
> + fprintf(stderr, "Failed to open %s\n", buffer_access);
>   goto error_free_buffer_access;
>   }
>  

At line 410 we have a block:
read_size = read(fp, data, toread * scan_size);
if (read_size < 0) {
if (errno == EAGAIN) {
printf("nothing available\n");
continue;

I'm tempted to say,that this should go to stderr, as well. Any opinions?

> @@ -431,7 +433,8 @@ int main(int argc, char **argv)
>   ret = write_sysfs_string("trigger/current_trigger",
>dev_dir_name, "NULL");
>   if (ret < 0)
> - printf("Failed to write to %s\n", dev_dir_name);
> + fprintf(stderr, "Failed to write to %s\n",
> + dev_dir_name);
>  
>  error_close_buffer_access:
>   if (close(fp) == -1)
> diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
> index 703f4cb..843bc4c 100644
> --- a/tools/iio/iio_event_monitor.c
> +++ b/tools/iio/iio_event_monitor.c

At line 217:
if (!event_is_known(event)) {
printf("Unknown event: time: %lld, id: %llx\n",
   event->timestamp, event->id);

return;
Better have this on stderr, as well?

> @@ -278,14 +278,14 @@ int 

Re: [PATCH] Lindent: Handle missing indent gracefully

[Andrew Morton]

On Fri, 10 Jul 2015 10:04:07 -0700 Joe Perches  wrote:

> > Le Friday 10 July 2015 __ 04:51 -0700, Joe Perches a __crit :
> > > On Fri, 2015-07-10 at 13:47 +0200, Jean Delvare wrote:
> > > > If indent is not found, bail out immediately instead of spitting
> > > > random shell script error messages.
> > > 
> > > OK, but can't we just delete Lindent instead?
> > 
> > Because...?
> 
> It's just not very useful in today's development space.

I've very occasionally used Lindent.  It's useful if the input is an
utter mess.  You feed it through Lindent as a first pass then get in and
do the remainder by hand.

It can be less work than doing the whole conversion by hand.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH] ixgbe: Remove bimodal SR-IOV disabling

[Rose, Gregory V]

> -Original Message-
> From: Alex Williamson [mailto:alex.william...@redhat.com]
> Sent: Friday, July 10, 2015 2:32 PM
> To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T
> Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Rose, Gregory V
> Subject: [PATCH] ixgbe: Remove bimodal SR-IOV disabling
> 
> When unbinding an SR-IOV device with VFs configured from ixgbe, the driver
> behaves in one of two ways.  If max_vfs was specified, the SR-IOV state is
> disabled, removing the VFs.  The occurs regardless of whether the VF count
> was later modified through sysfs.  If however max_vfs is zero, such as by
> not specifying the module parameter, the VFs persist after the PF is
> unbound from ixgbe.  If the PF is then bound to vfio-pci to be assigned to
> a VM, the PF is non-functional.
> 
> >From the comment, commit da36b64736cf ("ixgbe: Implement PCI SR-IOV
> sysfs callback operation") clearly intended this alternate behavior, but
> probably didn't realize the PF doesn't work in this mode.
> 
> This bimodal behavior is confusing to users and results in a state where
> the PF is broken for other uses unless the user sets sriov_numvfs to zero
> prior to unbinding the device.  Remove this behavior so that VFs are
> removed and the PF is functional for other uses after unbind, regardless
> of the way VFs are enabled.
> 
> Signed-off-by: Alex Williamson 
> Cc: Greg Rose 
> Cc: Jeff Kirsher 
> ---
> 
> I can only think that not disabling SR-IOV was meant to enable some sort
> of persistence for VFs, but that's probably better accomplished with
> either udev rules and/or modprobe.d install scripts.
> 
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |7 +--
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index 5be12a0..de04e3e 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -8810,12 +8810,7 @@ static void ixgbe_remove(struct pci_dev *pdev)
>   unregister_netdev(netdev);
> 
>  #ifdef CONFIG_PCI_IOV
> - /*
> -  * Only disable SR-IOV on unload if the user specified the now
> -  * deprecated max_vfs module parameter.
> -  */
> - if (max_vfs)
> - ixgbe_disable_sriov(adapter);
> + ixgbe_disable_sriov(adapter);
>  #endif
>   ixgbe_clear_interrupt_scheme(adapter);
> 

Please remove max_vfs module parameter - it is deprecated and should be removed 
from upstream builds.  Dave let us get away with a kernel module a few years 
ago because the other necessary infrastructure to enable SR-IOV virtual 
functions via the PCIe interface was not available.  Now that it's there it 
should be removed and vendors/end users should be forced to move away from this.

Thanks,

- Greg Rose
Intel Corp.
Networking Division

[PATCH] ixgbe: Remove bimodal SR-IOV disabling

[Alex Williamson]

When unbinding an SR-IOV device with VFs configured from ixgbe, the
driver behaves in one of two ways.  If max_vfs was specified, the
SR-IOV state is disabled, removing the VFs.  The occurs regardless of
whether the VF count was later modified through sysfs.  If however
max_vfs is zero, such as by not specifying the module parameter, the
VFs persist after the PF is unbound from ixgbe.  If the PF is then
bound to vfio-pci to be assigned to a VM, the PF is non-functional.

>From the comment, commit da36b64736cf ("ixgbe: Implement PCI SR-IOV
sysfs callback operation") clearly intended this alternate behavior,
but probably didn't realize the PF doesn't work in this mode.

This bimodal behavior is confusing to users and results in a state
where the PF is broken for other uses unless the user sets
sriov_numvfs to zero prior to unbinding the device.  Remove this
behavior so that VFs are removed and the PF is functional for other
uses after unbind, regardless of the way VFs are enabled.

Signed-off-by: Alex Williamson 
Cc: Greg Rose 
Cc: Jeff Kirsher 
---

I can only think that not disabling SR-IOV was meant to enable some
sort of persistence for VFs, but that's probably better accomplished
with either udev rules and/or modprobe.d install scripts.

 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c 
b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 5be12a0..de04e3e 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -8810,12 +8810,7 @@ static void ixgbe_remove(struct pci_dev *pdev)
unregister_netdev(netdev);
 
 #ifdef CONFIG_PCI_IOV
-   /*
-* Only disable SR-IOV on unload if the user specified the now
-* deprecated max_vfs module parameter.
-*/
-   if (max_vfs)
-   ixgbe_disable_sriov(adapter);
+   ixgbe_disable_sriov(adapter);
 #endif
ixgbe_clear_interrupt_scheme(adapter);
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Darlehen anbieten 1.5%

[Lloyds TSB Bank PLC]

Guten Tag,

 Dies ist Lloyds TSB Bank plc Kredite anbieten.

   Lloyds TSB bietet flexible und erschwingliche Kredite für jeden Zweck zu 
helfen, Ihre Ziele zu erreichen. wir Darlehen zu niedrigen Zinssatz von 1,5%. 
Hier sind einige wichtige Merkmale der persönlichen Kredit von Lloyds TSB 
angeboten. Hier sind die Loan Factors arbeiten wir mit den führenden britischen 
Broker, die den Zugang zu Top-Kreditgeber haben und in der Lage, die beste 
finanzielle Lösung zu einem erschwinglichen price.Please finden, wenn Sie 
interessiert sind kontaktieren Sie uns bitte über diese E-Mail: 
lloyds25...@hotmail.com


Nach der Reaktion, werden Sie einen Antrag auf Kredit fill erhalten. Keine 
soziale Sicherheit und keine Bonitätsprüfung, 100% garantiert.

Es wird uns eine Ehre, wenn Sie uns erlauben, zu Ihren Diensten.


Mehr Informationen benötigt

Ihre Namen:
Adresse: ...
Telefon: ...
Benötigte Menge: 
Dauer: ...
Beruf: ...
Monatliches Einkommen Level: 
Geschlecht: ...
Geburtsdatum: 
Status: ..
Land: ..
Zweck: .

Treffen Sie Ihre finanziellen Bedürfnisse ist unser Stolz.

Dr. John Mahama
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [patch V2] mm/slub: Move slab initialization into irq enabled region

[Christoph Lameter]

Acked-by: Christoph Lameter 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH -mm] parse_integer: add checkpatch.pl notice

[Alexey Dobriyan]

* remove check for strict_strto*(), they were fully removed long ago,

* add check for simple_strto*(), suggest replacements

  sscanf() is a bit icky to suggest because it accepts arbitrary amount
  of whitespace before any integer conversion, but assume programmer
  knows such twist and don't use sscanf() where real strictness is
  required (yes, sure...).

Signed-off-by: Alexey Dobriyan 
---

 scripts/checkpatch.pl |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5498,10 +5498,10 @@ sub process {
 "consider using a completion\n" . $herecurr);
}
 
-# recommend kstrto* over simple_strto* and strict_strto*
-   if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
+# simple_strto*() is deprecated
+   if ($line =~ /\b(simple_strto(l|ll|ul|ull))\s*\(/) {
WARN("CONSIDER_KSTRTO",
-"$1 is obsolete, use k$3 instead\n" . $herecurr);
+"$1 is obsolete, use parse_integer(), kstrto*(), 
kstrto*_from_user(), sscanf() instead\n" . $herecurr);
}
 
 # check for __initcall(), use device_initcall() explicitly or more appropriate 
function please
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH TRIVIAL] README: GTK+ is a acronym

[Jonathan Corbet]

On Mon,  6 Jul 2015 14:33:21 -0300
Diego Viola  wrote:

> - "make gconfig" X windows (Gtk) based configuration tool.
> + "make gconfig" X windows (GTK+) based configuration tool.

Applied to the docs tree, thanks.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] x86: Fix pXd_flags() to handle _PAGE_PAT_LARGE

[Toshi Kani]

On Fri, 2015-07-10 at 05:57 +0200, Juergen Gross wrote:
> On 07/09/2015 07:03 PM, Toshi Kani wrote:
> > The PAT bit gets relocated to bit 12 when PUD and PMD mappings are
> > used.  This bit 12, however, is not covered by PTE_FLAGS_MASK, 
> > which
> > is corrently used for masking the flag bits for all cases.
> > 
> > Fix pud_flags() and pmd_flags() to cover the PAT bit, 
> > _PAGE_PAT_LARGE,
> > when they are used to map a large page with _PAGE_PSE set.
  :
> Hmm, I think this covers only half of the problem. pud_pfn() and
> pmd_pfn() will return wrong results for large pages with PAT bit
> set as well.
> 
> I'd rather use something like:
> 
> static inline unsigned long pmd_pfn_mask(pmd_t pmd)
> {
>   if (pmd_large(pmd))
>   return PMD_PAGE_MASK & PHYSICAL_PAGE_MASK;
>   else
>   return PTE_PFN_MASK;
> }
> 
> static inline unsigned long pmd_flags_mask(pmd_t pmd)
> {
>   if (pmd_large(pmd))
>   return ~(PMD_PAGE_MASK & PHYSICAL_PAGE_MASK);
>   else
>   return ~PTE_PFN_MASK;
> }
> 
> static inline unsigned long pmd_pfn(pmd_t pmd)
> {
>  return (pmd_val(pmd) & pmd_pfn_mask(pmd)) >> PAGE_SHIFT;
> }
> 
> static inline pmdval_t pmd_flags(pmd_t pmd)
> {
>   return native_pmd_val(pmd) & ~pmd_flags_mask(pmd);
> }

Thanks for the suggestion!  I agree that it is cleaner in this way.  I
am updating the patches and found the following changes are needed as
well:

 - Define PGTABLE_LEVELS to 2 in
"arch/x86/entry/vdso/vdso32/vclock_gettime.c".  This file redefines to
X86_32.  Setting to 2 levels (since X86_PAE is not set) allows  be included to define PMD_SHIFT.

 - Move PUD_PAGE_SIZE & PUD_PAGE_MASK from  to
.  This allows X86_32 to refer the PUD macros.

 - Nit: pmd_large() cannot be used in pmd_xxx_mask() since it calls
pmd_flags().  Use (native_pud_val(pud) & _PAGE_PSE), instead.

Thanks,
-Toshi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] fixed_phy: handle link-down case

[Stas Sergeev]

10.07.2015 23:44, Florian Fainelli пишет:

On 10/07/15 09:41, Stas Sergeev wrote:

Currently fixed_phy driver recognizes only the link-up state.
This simple patch adds an implementation of link-down state.
The actual change is 1-line, the rest is an indentation.

It is not clear to me how this is useful, if you have a link_update
callback manipulating the link state, the fixed PHY driver returns
appropriate MII_BMSR values and always re-initializes everything.

It returns the appropriate values only for link status (when its down),
but it still returns speed, duplex etc as if the link is up. I had hard
times finding the relevant specs, but from what I have googled,
when link is down, the speed/duplex/etc status fields should _also_
be zero, which is what my patch does.
What is more important is that fixed_phy_add() would return
-EINVAL if you didn't specify speed while the link is down.
This is an absolute must-fix, or I will have to add an arbitrary
speed value again, on which you already objected.


Is this meant to be some sort of optimization? If so, you could just
avoid the re-intendation completely and do a goto instead?

Oh, c'mon... Adding goto just to keep the _patch_ smaller?
(not smaller code, just a smaller patch)
Well, this is certainly something that can be done, feel free
to request that explicitly and I'll release v3 next week.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

[Scott Wood]

On Fri, 2015-07-10 at 15:57 -0500, Pledge Roy-R01356 wrote:
> > 
> > On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote:
> > > On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
> > > > +#ifdef CONFIG_FSL_DPA_CHECKING
> > > > +#define DPA_ASSERT(x) \
> > > > +   do { \
> > > > +   if (!(x)) { \
> > > > +   pr_crit("ASSERT: (%s:%d) %s\n", __FILE__, 
> > > > __LINE__, \
> > > > +   __stringify_1(x)); \
> > > > +   dump_stack(); \
> > > > +   panic("assertion failure"); \
> > > 
> > > Not my call, but why panic() here?
> > 
> > I'm pretty sure I've complained about this before (as well as all the
> > BUG_ONs).
> > 
> Is the concern here just the call to panic()?  I'm happy to change what 
> happens when an issue is detected but the DPA_ASSERT() calls are very 
> useful when testing changes to the driver and when bringing up the drivers 
> on new silicon variants. 

Use WARN_ON() or a variant thereof.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] backlight: lp855x: use private data for regulator control

[Kim, Milo]

Hi Paul,

On 7/11/2015 5:52 AM, Kim, Milo wrote:

Hi Paul,

On 7/11/2015 5:49 AM, Sean Paul wrote:

On Fri, Jul 10, 2015 at 4:43 PM, Kim, Milo  wrote:

Hi Paul,


On 7/11/2015 12:01 AM, Sean Paul wrote:


On Fri, Jul 10, 2015 at 4:26 AM, Milo Kim  wrote:


LP855x backlight device can be enabled by external VDD input.
The 'supply' data is used for this purpose.
It's kind of private data which runs internally, so there is no reason to
expose to the platform data.

And devm_regulator_get() is moved from _parse_dt() to _probe().
Regulator consumer(lp855x) can control regulator not only from DT but
also
from platform data configuration in a source file such like board-*.c.

If 'power' regulator driver is not ready, lp855x should continue to work
because the power supply control is optional. So -EPROBE_DEFER return
code
is removed.

v1->v2:
 Keeps optional property '-supply' in LP855x DT binding.

Cc: Sean Paul 
Cc: Jingoo Han 
Cc: Lee Jones 
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Milo Kim 
---
drivers/video/backlight/lp855x_bl.c  | 20 +---
include/linux/platform_data/lp855x.h |  2 --
2 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/drivers/video/backlight/lp855x_bl.c
b/drivers/video/backlight/lp855x_bl.c
index a26d3bb..277d5ca 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -73,6 +73,7 @@ struct lp855x {
   struct device *dev;
   struct lp855x_platform_data *pdata;
   struct pwm_device *pwm;
+   struct regulator *supply;   /* regulator for VDD input */
};

static int lp855x_write_byte(struct lp855x *lp, u8 reg, u8 data)
@@ -384,13 +385,6 @@ static int lp855x_parse_dt(struct lp855x *lp)
   pdata->rom_data = [0];
   }

-   pdata->supply = devm_regulator_get(dev, "power");
-   if (IS_ERR(pdata->supply)) {
-   if (PTR_ERR(pdata->supply) == -EPROBE_DEFER)
-   return -EPROBE_DEFER;
-   pdata->supply = NULL;
-   }
-
   lp->pdata = pdata;

   return 0;
@@ -431,8 +425,12 @@ static int lp855x_probe(struct i2c_client *cl, const
struct i2c_device_id *id)
   else
   lp->mode = REGISTER_BASED;

-   if (lp->pdata->supply) {
-   ret = regulator_enable(lp->pdata->supply);
+   lp->supply = devm_regulator_get(lp->dev, "power");
+   if (IS_ERR(lp->supply))
+   lp->supply = NULL;




Hi Milo,
You removed the probe deferral handling on the regulator and broke
probe deferral in cases where the regulator isn't ready.



This power supply is optional. Even if lp855x can not get regulator driver,
it should work. (And I saw same comment in the DT. The 'power-supply'
property is optional). So -EPORBE_DEFER is not necessary in _probe().



I respectfully disagree. devm_regulator_get can return EPROBE_DEFER if
the regulator is valid (and specified in the dt), but not ready to be
used yet. In this case, your patch will assume it doesn't exist and
will never use it. This Is Bad.


So do you think this power supply should be mandatory in this driver?


The devm_regulator_get_optinonal() seems the right API for this case.
Let me take a look at and get back to you.

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] drivers: qcom: Select QCOM_SCM unconditionally for QCOM_PM

[Stephen Boyd]

On 07/10/2015 01:18 PM, Lina Iyer wrote:
> Enable QCOM_SCM for QCOM power management driver
>
> Signed-off-by: Lina Iyer 

Acked-by: Stephen Boyd 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] virt: IRQ bypass manager

[Paolo Bonzini]

On 10/07/2015 19:52, Alex Williamson wrote:
> Perhaps if a second consumer comes along that would be justification for
> tying it elsewhere in the build system.  ARM will obviously need to do
> similar.  Are there better options?
> 
> Also, there's no maintainer for the top level virt/ directory.  Paolo,
> would you feel comfortable taking this, maybe with some additional acks?

That's okay; alternatively, we can share it since after all you wrote
most of it.

Paolo

> That would probably be the most convenient for merging the consumer code.
> Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[patch V2] mm/slub: Move slab initialization into irq enabled region

[Thomas Gleixner]

Initializing a new slab can introduce rather large latencies because
most of the initialization runs always with interrupts disabled.

There is no point in doing so. The newly allocated slab is not visible
yet, so there is no reason to protect it against concurrent alloc/free.

Move the expensive parts of the initialization into allocate_slab(),
so for all allocations with GFP_WAIT set, interrupts are enabled.

Signed-off-by: Thomas Gleixner 
Cc: Christoph Lameter 
Cc: Pekka Enberg 
Cc: David Rientjes 
Cc: Joonsoo Kim 
Cc: Andrew Morton 
Cc: linux...@kvack.org
Cc: Sebastian Andrzej Siewior 
Cc: Steven Rostedt 
Cc: Peter Zijlstra 
---

V2: Removed the extra NULL checks as suggested by Steven and Christoph

 mm/slub.c |   89 +-
 1 file changed, 42 insertions(+), 47 deletions(-)

Index: linux/mm/slub.c
===
--- linux.orig/mm/slub.c
+++ linux/mm/slub.c
@@ -1306,6 +1306,17 @@ static inline void slab_free_hook(struct
kasan_slab_free(s, x);
 }
 
+static void setup_object(struct kmem_cache *s, struct page *page,
+   void *object)
+{
+   setup_object_debug(s, page, object);
+   if (unlikely(s->ctor)) {
+   kasan_unpoison_object_data(s, object);
+   s->ctor(object);
+   kasan_poison_object_data(s, object);
+   }
+}
+
 /*
  * Slab allocation and freeing
  */
@@ -1336,6 +1347,8 @@ static struct page *allocate_slab(struct
struct page *page;
struct kmem_cache_order_objects oo = s->oo;
gfp_t alloc_gfp;
+   void *start, *p;
+   int idx, order;
 
flags &= gfp_allowed_mask;
 
@@ -1359,13 +1372,13 @@ static struct page *allocate_slab(struct
 * Try a lower order alloc if possible
 */
page = alloc_slab_page(s, alloc_gfp, node, oo);
-
-   if (page)
-   stat(s, ORDER_FALLBACK);
+   if (unlikely(!page))
+   goto out;
+   stat(s, ORDER_FALLBACK);
}
 
-   if (kmemcheck_enabled && page
-   && !(s->flags & (SLAB_NOTRACK | DEBUG_DEFAULT_FLAGS))) {
+   if (kmemcheck_enabled &&
+   !(s->flags & (SLAB_NOTRACK | DEBUG_DEFAULT_FLAGS))) {
int pages = 1 << oo_order(oo);
 
kmemcheck_alloc_shadow(page, oo_order(oo), alloc_gfp, node);
@@ -1380,51 +1393,9 @@ static struct page *allocate_slab(struct
kmemcheck_mark_unallocated_pages(page, pages);
}
 
-   if (flags & __GFP_WAIT)
-   local_irq_disable();
-   if (!page)
-   return NULL;
-
page->objects = oo_objects(oo);
-   mod_zone_page_state(page_zone(page),
-   (s->flags & SLAB_RECLAIM_ACCOUNT) ?
-   NR_SLAB_RECLAIMABLE : NR_SLAB_UNRECLAIMABLE,
-   1 << oo_order(oo));
-
-   return page;
-}
-
-static void setup_object(struct kmem_cache *s, struct page *page,
-   void *object)
-{
-   setup_object_debug(s, page, object);
-   if (unlikely(s->ctor)) {
-   kasan_unpoison_object_data(s, object);
-   s->ctor(object);
-   kasan_poison_object_data(s, object);
-   }
-}
-
-static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
-{
-   struct page *page;
-   void *start;
-   void *p;
-   int order;
-   int idx;
-
-   if (unlikely(flags & GFP_SLAB_BUG_MASK)) {
-   pr_emerg("gfp: %u\n", flags & GFP_SLAB_BUG_MASK);
-   BUG();
-   }
-
-   page = allocate_slab(s,
-   flags & (GFP_RECLAIM_MASK | GFP_CONSTRAINT_MASK), node);
-   if (!page)
-   goto out;
 
order = compound_order(page);
-   inc_slabs_node(s, page_to_nid(page), page->objects);
page->slab_cache = s;
__SetPageSlab(page);
if (page->pfmemalloc)
@@ -1448,10 +1419,34 @@ static struct page *new_slab(struct kmem
page->freelist = start;
page->inuse = page->objects;
page->frozen = 1;
+
 out:
+   if (flags & __GFP_WAIT)
+   local_irq_disable();
+   if (!page)
+   return NULL;
+
+   mod_zone_page_state(page_zone(page),
+   (s->flags & SLAB_RECLAIM_ACCOUNT) ?
+   NR_SLAB_RECLAIMABLE : NR_SLAB_UNRECLAIMABLE,
+   1 << oo_order(oo));
+
+   inc_slabs_node(s, page_to_nid(page), page->objects);
+
return page;
 }
 
+static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
+{
+   if (unlikely(flags & GFP_SLAB_BUG_MASK)) {
+   pr_emerg("gfp: %u\n", flags & GFP_SLAB_BUG_MASK);
+   BUG();
+   }
+
+   return allocate_slab(s,
+   flags & (GFP_RECLAIM_MASK | GFP_CONSTRAINT_MASK), node);
+}
+
 static void __free_slab(struct kmem_cache *s, struct page 

[GIT PULL] parisc fixes for v4.2

[Helge Deller]

Hi Linus,

please pull the latest fixes for the parisc architecture for v4.2-rc2 from:

  git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git 
parisc-4.2-1

We have one important patch from Dave Anglin and myself which fixes PTE/TLB
race conditions which caused random segmentation faults on our debian buildd
servers, and one patch from Alex Ivanov which speeds up the graphical text
console on the STI framebuffer driver.

Thanks,
Helge


Alex Ivanov (1):
  stifb: Implement hardware accelerated copyarea

John David Anglin (1):
  parisc: Fix some PTE/TLB race conditions and optimize __flush_tlb_range 
based on timing results

 arch/parisc/include/asm/pgtable.h  |  55 +
 arch/parisc/include/asm/tlbflush.h |  53 ++--
 arch/parisc/kernel/cache.c | 105 +++-
 arch/parisc/kernel/entry.S | 163 ++---
 arch/parisc/kernel/traps.c |   4 -
 drivers/video/fbdev/stifb.c|  40 -
 6 files changed, 250 insertions(+), 170 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/3] of_mdio: add new DT property 'autoneg' for fixed-link

[Stas Sergeev]

10.07.2015 23:39, Florian Fainelli пишет:

- in-band status is an implementation delail, and it is
specific to a particular protocols. If you request the
in-band status for some protocol that doesn't support
it, perhaps you should get -EINVAL, because such a
config makes no sense. With autonegotiation, the rules
are not that strict: it can be "unimplemented", which doesn't
necessary mean nonsense in the config.

So by specifying "autoneg", you are not specific about the kind of
auto-negotiation protocol available, which is precisely my point: you
need to go down to that level of detail for this to be useful. So maybe
something like:

autoneg = "in-band-status" would actually be a better thing in terms of
description because then you would tell what can be made available/working?

I would agree with this if your argument below is true (see below).


- autonegotiation is a wider term, and may be implemented
by some other means than the in-band status (which is
probably impossible for a fixed-link though).

- In the terms that the driver uses, it is autonegotiation, eg
MVNETA_GMAC_AUTONEG_CONFIG. And when you go down
the implementation details, you see MVNETA_GMAC_INBAND_AN_ENABLE,
which is just one AN bit of many.

But arguably, there could be another auto-negotiation method, which is
not in-band status related, which means that you would need a way to
distinguish between using in-band status, or using something else or
nothing, would not you?

"something else" is a big question here.
Can you think of _any_ other way that is both not an MDIO
(suits to fixed-link) and not an in-band?
If the answer is yes (even theoretically), then
autoneg = "in-band" | "off"
may make sense. Otherwise boolean just looks enough.
If we would implement autoneg outside of the fixed-link,
then its semantic would likely be
autoneg = "mdio" | "in-band" | "off"
But the fact that we put it under fixed-link where only a
single AN possibility exist, may probably be underlined by
a semantic specific to fixed-link.

One may also argue that
autoneg = "any-possible-autoneg-that-works" is better than
specifying it explicitly, which is exactly what the boolean does.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/