On 6/8/2023 8:16 PM, Dan Williams wrote:
[..]
+static inline int dax_mem2blk_err(int err)
+{
+       return (err == -EHWPOISON) ? -EIO : err;
+}

I think it is worth a comment on this function to indicate where this
helper is *not* used. I.e. it's easy to grep for where the error code is
converted for file I/O errors, but the subtlety of when the
dax_direct_acces() return value is not translated for fault handling
deserves a comment when we wonder why this function exists in a few
years time.

Good point!  v5 coming up next.

thanks!
-jane

Reply via email to