[PATCH -next] ASoC: rt1019: make symbol 'rt1019_i2c_driver' static

2021-03-19 Thread 'w00385741
From: Wei Yongjun 

The sparse tool complains as follows:

sound/soc/codecs/rt1019.c:927:19: warning:
 symbol 'rt1019_i2c_driver' was not declared. Should it be static?

This symbol is not used outside of rt1019.c, so this
commit marks it static.

Fixes: 7ec79d3850d0 ("ASoC: rt1019: add rt1019 amplifier driver")
Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
---
 sound/soc/codecs/rt1019.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rt1019.c b/sound/soc/codecs/rt1019.c
index fb275686a00f..5138f028d9f2 100644
--- a/sound/soc/codecs/rt1019.c
+++ b/sound/soc/codecs/rt1019.c
@@ -924,7 +924,7 @@ static int rt1019_i2c_probe(struct i2c_client *i2c,
_component_dev_rt1019, rt1019_dai, ARRAY_SIZE(rt1019_dai));
 }
 
-struct i2c_driver rt1019_i2c_driver = {
+static struct i2c_driver rt1019_i2c_driver = {
.driver = {
.name = "rt1019",
.of_match_table = of_match_ptr(rt1019_of_match),



[PATCH -next] phy: sparx5_serdes: Fix return value check in sparx5_serdes_probe()

2021-03-18 Thread 'w00385741
From: Wei Yongjun 

In case of error, the function devm_ioremap() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Fixes: 2ff8a1eeb5aa ("phy: Add Sparx5 ethernet serdes PHY driver")
Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
---
 drivers/phy/microchip/sparx5_serdes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/microchip/sparx5_serdes.c 
b/drivers/phy/microchip/sparx5_serdes.c
index 06bcf0c166cf..dd854d825000 100644
--- a/drivers/phy/microchip/sparx5_serdes.c
+++ b/drivers/phy/microchip/sparx5_serdes.c
@@ -2438,10 +2438,10 @@ static int sparx5_serdes_probe(struct platform_device 
*pdev)
 
iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
iomem = devm_ioremap(priv->dev, iores->start, iores->end - iores->start 
+ 1);
-   if (IS_ERR(iomem)) {
+   if (!iomem) {
dev_err(priv->dev, "Unable to get serdes registers: %s\n",
iores->name);
-   return PTR_ERR(iomem);
+   return -ENOMEM;
}
for (idx = 0; idx < ARRAY_SIZE(sparx5_serdes_iomap); idx++) {
struct sparx5_serdes_io_resource *iomap = 
_serdes_iomap[idx];