Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session
This problem exists at least from v3.16. The upstream kernel still exists this issue. I have tested my patch and the following panic is disappeared. Thanks, - Alex #dmesg [ 1160.788676] sd 16:0:0:0: [sde] Attached SCSI disk [ 1383.962626] target_core_get_fabric() failed for usb_gadget [ 1404.788910] TARGET_CORE[iSCSI]: Unsupported SCSI Opcode 0x1b, sending CHECK_CONDITION. [ 1404.858451] BUG: unable to handle kernel NULL pointer dereference at 01f8 [ 1404.858911] IP: [] iscsi_target_login_thread+0x728/0x10b0 [iscsi_target_mod] [ 1404.859746] PGD 230c29067 PUD 232060067 PMD 0 [ 1404.859963] Oops: [#1] SMP [ 1404.860154] Modules linked in: crc32c_generic tcm_loop tcm_qla2xxx qla2xxx iscsi_target_mod ib_srpt vhost_scsi vhost tcm_fc libfc scsi_transport_fc scsi_tgt target_core_file target_core_iblock target_core_pscsi target_core_mod configfs nbd vmw_vsock_vmci_transport vsock bridge stp llc vmhgfs(O) snd_ens1371 snd_rawmidi snd_seq_device snd_ac97_codec snd_pcm snd_timer snd vmw_balloon evdev soundcore ac97_bus gameport ppdev pcspkr sg psmouse serio_raw parport_pc vmwgfx parport battery ttm drm_kms_helper drm i2c_piix4 shpchp i2c_core vmw_vmci processor thermal_sys ac button binfmt_misc md_mod ib_iser rdma_cm iw_cm ib_cm ib_sa ib_mad ib_core ib_addr iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi hid_generic usbhid hid ext4 crc16 mbcache jbd2 sd_mod crc_t10dif crct10dif_generic crct10dif_common ata_generic [ 1404.861278] mptspi scsi_transport_spi mptscsih ata_piix uhci_hcd ehci_pci ehci_hcd mptbase libata usbcore e1000 usb_common scsi_mod sunrpc dm_mirror dm_region_hash dm_log dm_mod autofs4 [ 1404.861742] CPU: 2 PID: 1865 Comm: iscsi_np Tainted: G O 3.16.0-4-amd64 #1 Debian 3.16.7-ckt25-1 [ 1404.861868] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 07/02/2015 [ 1404.862033] task: 880234c849a0 ti: 8800b9c2 task.ti: 8800b9c2 [ 1404.862114] RIP: 0010:[] [] iscsi_target_login_thread+0x728/0x10b0 [iscsi_target_mod] [ 1404.862233] RSP: 0018:8800b9c23e60 EFLAGS: 00010246 [ 1404.862282] RAX: RBX: 88023125b800 RCX: 8802b4d8d000 [ 1404.862344] RDX: 002d RSI: fe01 RDI: 880233ef1800 [ 1404.862406] RBP: 8800b9651a00 R08: d5a073de R09: 88023487e6c0 [ 1404.862585] R10: ead0c2e5 R11: d039ef6a R12: 88023125b854 [ 1404.865580] R13: 88023125b908 R14: 880233ef1800 R15: 880234c849a0 [ 1404.867732] FS: 7fba67e2fb80() GS:88023e64() knlGS: [ 1404.869772] CS: 0010 DS: ES: CR0: 8005003b [ 1404.871850] CR2: 01f8 CR3: 000230ffa000 CR4: 07e0 [ 1404.874271] Stack: [ 1404.877492] 88023125b908 00ff880234c849a0 88023125b858 88023481f400 [ 1404.880162] 81510d00 880230768000 8800b9c23fd8 00012f00 [ 1404.883545] 880234c849a0 880233e9da40 88023125b800 a05edeb0 [ 1404.885865] Call Trace: [ 1404.888384] [] ? __schedule+0x250/0x700 [ 1404.890619] [] ? iscsi_target_login_sess_out+0x240/0x240 [iscsi_target_mod] [ 1404.892668] [] ? kthread+0xbd/0xe0 [ 1404.894646] [] ? kthread_create_on_node+0x180/0x180 [ 1404.896553] [] ? ret_from_fork+0x58/0x90 [ 1404.898556] [] ? kthread_create_on_node+0x180/0x180 [ 1404.900597] Code: 09 00 00 48 89 ea 4c 89 f6 48 89 df e8 52 1b 00 00 85 c0 0f 88 82 02 00 00 0f b6 44 24 0f 4c 89 f7 88 45 09 49 8b 86 d8 04 00 00 <4c> 8b a8 f8 01 00 00 49 8b 86 a0 04 00 00 ff 90 98 00 00 00 41 [ 1404.906962] RIP [] iscsi_target_login_thread+0x728/0x10b0 [iscsi_target_mod] [ 1404.908962] RSP [ 1404.910940] CR2: 01f8 [ 1404.917670] ---[ end trace d29d8c681ab2bdfb ]--- [ 1419.859690] iSCSI Login timeout on Network Portal 10.182.70.69:3260 [ 1479.832056] iSCSI Login timeout on Network Portal 10.182.70.68:3260 [ 1479.835739] iSCSI Login negotiation failed. [ 1549.332632] iSCSI Login timeout on Network Portal 10.182.70.68:3260 [ 1549.338432] iSCSI Login negotiation failed. [ 1564.358423] iSCSI Login timeout on Network Portal 10.182.70.68:3260 [ 1564.362443] iSCSI Login negotiation failed. 2016-07-12 6:15 GMT+08:00 Feng Li: > From: Feng Li > > In MC/S scenario, the conn->sess has been set NULL in > iscsi_login_non_zero_tsih_s1 when the second connection comes here, > then kernel panic. > > The conn->sess will be assigned in iscsi_login_non_zero_tsih_s2. So > we should check whether it's NULL before calling. > > Signed-off-by: Feng Li > --- > drivers/target/iscsi/iscsi_target_login.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/target/iscsi/iscsi_target_login.c > b/drivers/target/iscsi/iscsi_target_login.c > index b5212f0..adf419f 100644 > --- a/drivers/target/iscsi/iscsi_target_login.c > +++ b/drivers/target/iscsi/iscsi_target_login.c > @@ -1371,8 +1371,9 @@
Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session
This problem exists at least from v3.16. The upstream kernel still exists this issue. I have tested my patch and the following panic is disappeared. Thanks, - Alex #dmesg [ 1160.788676] sd 16:0:0:0: [sde] Attached SCSI disk [ 1383.962626] target_core_get_fabric() failed for usb_gadget [ 1404.788910] TARGET_CORE[iSCSI]: Unsupported SCSI Opcode 0x1b, sending CHECK_CONDITION. [ 1404.858451] BUG: unable to handle kernel NULL pointer dereference at 01f8 [ 1404.858911] IP: [] iscsi_target_login_thread+0x728/0x10b0 [iscsi_target_mod] [ 1404.859746] PGD 230c29067 PUD 232060067 PMD 0 [ 1404.859963] Oops: [#1] SMP [ 1404.860154] Modules linked in: crc32c_generic tcm_loop tcm_qla2xxx qla2xxx iscsi_target_mod ib_srpt vhost_scsi vhost tcm_fc libfc scsi_transport_fc scsi_tgt target_core_file target_core_iblock target_core_pscsi target_core_mod configfs nbd vmw_vsock_vmci_transport vsock bridge stp llc vmhgfs(O) snd_ens1371 snd_rawmidi snd_seq_device snd_ac97_codec snd_pcm snd_timer snd vmw_balloon evdev soundcore ac97_bus gameport ppdev pcspkr sg psmouse serio_raw parport_pc vmwgfx parport battery ttm drm_kms_helper drm i2c_piix4 shpchp i2c_core vmw_vmci processor thermal_sys ac button binfmt_misc md_mod ib_iser rdma_cm iw_cm ib_cm ib_sa ib_mad ib_core ib_addr iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi hid_generic usbhid hid ext4 crc16 mbcache jbd2 sd_mod crc_t10dif crct10dif_generic crct10dif_common ata_generic [ 1404.861278] mptspi scsi_transport_spi mptscsih ata_piix uhci_hcd ehci_pci ehci_hcd mptbase libata usbcore e1000 usb_common scsi_mod sunrpc dm_mirror dm_region_hash dm_log dm_mod autofs4 [ 1404.861742] CPU: 2 PID: 1865 Comm: iscsi_np Tainted: G O 3.16.0-4-amd64 #1 Debian 3.16.7-ckt25-1 [ 1404.861868] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 07/02/2015 [ 1404.862033] task: 880234c849a0 ti: 8800b9c2 task.ti: 8800b9c2 [ 1404.862114] RIP: 0010:[] [] iscsi_target_login_thread+0x728/0x10b0 [iscsi_target_mod] [ 1404.862233] RSP: 0018:8800b9c23e60 EFLAGS: 00010246 [ 1404.862282] RAX: RBX: 88023125b800 RCX: 8802b4d8d000 [ 1404.862344] RDX: 002d RSI: fe01 RDI: 880233ef1800 [ 1404.862406] RBP: 8800b9651a00 R08: d5a073de R09: 88023487e6c0 [ 1404.862585] R10: ead0c2e5 R11: d039ef6a R12: 88023125b854 [ 1404.865580] R13: 88023125b908 R14: 880233ef1800 R15: 880234c849a0 [ 1404.867732] FS: 7fba67e2fb80() GS:88023e64() knlGS: [ 1404.869772] CS: 0010 DS: ES: CR0: 8005003b [ 1404.871850] CR2: 01f8 CR3: 000230ffa000 CR4: 07e0 [ 1404.874271] Stack: [ 1404.877492] 88023125b908 00ff880234c849a0 88023125b858 88023481f400 [ 1404.880162] 81510d00 880230768000 8800b9c23fd8 00012f00 [ 1404.883545] 880234c849a0 880233e9da40 88023125b800 a05edeb0 [ 1404.885865] Call Trace: [ 1404.888384] [] ? __schedule+0x250/0x700 [ 1404.890619] [] ? iscsi_target_login_sess_out+0x240/0x240 [iscsi_target_mod] [ 1404.892668] [] ? kthread+0xbd/0xe0 [ 1404.894646] [] ? kthread_create_on_node+0x180/0x180 [ 1404.896553] [] ? ret_from_fork+0x58/0x90 [ 1404.898556] [] ? kthread_create_on_node+0x180/0x180 [ 1404.900597] Code: 09 00 00 48 89 ea 4c 89 f6 48 89 df e8 52 1b 00 00 85 c0 0f 88 82 02 00 00 0f b6 44 24 0f 4c 89 f7 88 45 09 49 8b 86 d8 04 00 00 <4c> 8b a8 f8 01 00 00 49 8b 86 a0 04 00 00 ff 90 98 00 00 00 41 [ 1404.906962] RIP [] iscsi_target_login_thread+0x728/0x10b0 [iscsi_target_mod] [ 1404.908962] RSP [ 1404.910940] CR2: 01f8 [ 1404.917670] ---[ end trace d29d8c681ab2bdfb ]--- [ 1419.859690] iSCSI Login timeout on Network Portal 10.182.70.69:3260 [ 1479.832056] iSCSI Login timeout on Network Portal 10.182.70.68:3260 [ 1479.835739] iSCSI Login negotiation failed. [ 1549.332632] iSCSI Login timeout on Network Portal 10.182.70.68:3260 [ 1549.338432] iSCSI Login negotiation failed. [ 1564.358423] iSCSI Login timeout on Network Portal 10.182.70.68:3260 [ 1564.362443] iSCSI Login negotiation failed. 2016-07-12 6:15 GMT+08:00 Feng Li : > From: Feng Li > > In MC/S scenario, the conn->sess has been set NULL in > iscsi_login_non_zero_tsih_s1 when the second connection comes here, > then kernel panic. > > The conn->sess will be assigned in iscsi_login_non_zero_tsih_s2. So > we should check whether it's NULL before calling. > > Signed-off-by: Feng Li > --- > drivers/target/iscsi/iscsi_target_login.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/target/iscsi/iscsi_target_login.c > b/drivers/target/iscsi/iscsi_target_login.c > index b5212f0..adf419f 100644 > --- a/drivers/target/iscsi/iscsi_target_login.c > +++ b/drivers/target/iscsi/iscsi_target_login.c > @@ -1371,8 +1371,9 @@ static int __iscsi_target_login_thread(struct iscsi_np > *np) >
Encounter a panic when I'm doing my daily work
Hi folks, This is the stack, very long. Anyone could share your experience that how to debug the issue? Thanks. Apr 11 15:39:11 debian kernel: [ 5634.976658] INFO: rcu_sched detected stalls on CPUs/tasks: { 0} (detected by 2, t=22073 jiffies, g=102346, c=102345, q=61) Apr 11 15:39:11 debian kernel: [ 5634.979555] sending NMI to all CPUs: Apr 11 15:39:11 debian kernel: [ 5634.979935] NMI backtrace for cpu 2 Apr 11 15:39:11 debian kernel: [ 5634.980123] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G O 3.16.0-4-amd64 #1 Debian 3.16.7-ckt25-1 Apr 11 15:39:11 debian kernel: [ 5634.980140] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 07/02/2015 Apr 11 15:39:11 debian kernel: [ 5634.980212] task: 880139ffa0d0 ti: 880139848000 task.ti: 880139848000 Apr 11 15:39:11 debian kernel: [ 5634.980243] RIP: 0010:[] [] default_send_IPI_mask_sequence_phys+0xad/0xe0 Apr 11 15:39:11 debian kernel: [ 5634.980776] RSP: 0018:88013a643e18 EFLAGS: 0046 Apr 11 15:39:11 debian kernel: [ 5634.980790] RAX: 0400 RBX: a0ea RCX: 0002 Apr 11 15:39:11 debian kernel: [ 5634.980802] RDX: 0002 RSI: 0200 RDI: 0300 Apr 11 15:39:11 debian kernel: [ 5634.980815] RBP: 818e28e0 R08: 818e28e0 R09: 0677 Apr 11 15:39:11 debian kernel: [ 5634.980827] R10: R11: 88013a643b96 R12: 0400 Apr 11 15:39:11 debian kernel: [ 5634.980840] R13: 0096 R14: 0002 R15: 0004 Apr 11 15:39:11 debian kernel: [ 5634.980917] FS: 7fc2af615740() GS:88013a64() knlGS: Apr 11 15:39:11 debian kernel: [ 5634.980931] CS: 0010 DS: ES: CR0: 8005003b Apr 11 15:39:11 debian kernel: [ 5634.980943] CR2: 7fad5b599000 CR3: b7c85000 CR4: 07e0 Apr 11 15:39:11 debian kernel: [ 5634.981074] Stack: Apr 11 15:39:11 debian kernel: [ 5634.981125] 0002 88013a64d660 81853780 0002 Apr 11 15:39:11 debian kernel: [ 5634.981176] 818e2e40 003d 81853840 810469c3 Apr 11 15:39:11 debian kernel: [ 5634.981181] 88013a64d660 810c5add 0001 0083 Apr 11 15:39:11 debian kernel: [ 5634.981217] Call Trace: Apr 11 15:39:11 debian kernel: [ 5634.981349] Apr 11 15:39:11 debian kernel: [ 5634.981557] [] ? arch_trigger_all_cpu_backtrace+0xc3/0x140 Apr 11 15:39:11 debian kernel: [ 5634.981657] [] ? rcu_check_callbacks+0x60d/0x630 Apr 11 15:39:11 debian kernel: [ 5634.981664] [] ? tick_sched_handle.isra.16+0x60/0x60 Apr 11 15:39:11 debian kernel: [ 5634.981683] [] ? update_process_times+0x40/0x70 Apr 11 15:39:11 debian kernel: [ 5634.981688] [] ? tick_sched_handle.isra.16+0x20/0x60 Apr 11 15:39:11 debian kernel: [ 5634.981692] [] ? tick_sched_timer+0x3c/0x60 Apr 11 15:39:11 debian kernel: [ 5634.981703] [] ? __run_hrtimer+0x67/0x1c0 Apr 11 15:39:11 debian kernel: [ 5634.981706] [] ? hrtimer_interrupt+0xe9/0x220 Apr 11 15:39:11 debian kernel: [ 5634.981774] [] ? smp_apic_timer_interrupt+0x3b/0x60 Apr 11 15:39:11 debian kernel: [ 5634.981781] [] ? apic_timer_interrupt+0x6d/0x80 Apr 11 15:39:11 debian kernel: [ 5634.981808] Apr 11 15:39:11 debian kernel: [ 5634.981840] [] ? idle_notifier_unregister+0x20/0x20 Apr 11 15:39:11 debian kernel: [ 5634.981886] [] ? native_safe_halt+0x2/0x10 Apr 11 15:39:11 debian kernel: [ 5634.981891] [] ? default_idle+0x19/0xb0 Apr 11 15:39:11 debian kernel: [ 5634.981922] [] ? cpu_startup_entry+0x340/0x400 Apr 11 15:39:11 debian kernel: [ 5634.981927] [] ? start_secondary+0x20f/0x2d0 Apr 11 15:39:11 debian kernel: [ 5634.981958] Code: 8b 0c 25 00 53 5f ff 80 e5 10 75 f2 44 89 f8 c1 e0 18 89 04 25 10 53 5f ff 41 83 fe 02 44 89 e0 41 0f 45 c6 89 04 25 00 53 5f ff 91 4c 89 ef 57 9d 66 66 90 66 90 48 83 c4 08 5b 5d 41 5c 41 Apr 11 15:39:11 debian kernel: [ 5634.982407] NMI backtrace for cpu 1 Apr 11 15:39:11 debian kernel: [ 5634.983053] CPU: 1 PID: 3295 Comm: sshd Tainted: G O 3.16.0-4-amd64 #1 Debian 3.16.7-ckt25-1 Apr 11 15:39:11 debian kernel: [ 5634.983084] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 07/02/2015 Apr 11 15:39:11 debian kernel: [ 5634.983156] task: 8801375ceb60 ti: 88007b43 task.ti: 88007b43 Apr 11 15:39:11 debian kernel: [ 5634.983221] RIP: 0010:[] [] _raw_spin_lock_bh+0x31/0x40 Apr 11 15:39:11 debian kernel: [ 5634.984386] RSP: 0018:88007b433d18 EFLAGS: 0297 Apr 11 15:39:11 debian kernel: [ 5634.984404] RAX: 128b RBX: 8800ba1a0840 RCX: 128c Apr 11 15:39:11 debian kernel: [ 5634.984418] RDX: 128c RSI: RDI: 8800ba1a08b0 Apr 11 15:39:11 debian kernel: [ 5634.984431] RBP: 4000 R08: 0040 R09: Apr 11 15:39:11 debian kernel: [ 5634.984445] R10: R11: 0246 R12:
Encounter a panic when I'm doing my daily work
Hi folks, This is the stack, very long. Anyone could share your experience that how to debug the issue? Thanks. Apr 11 15:39:11 debian kernel: [ 5634.976658] INFO: rcu_sched detected stalls on CPUs/tasks: { 0} (detected by 2, t=22073 jiffies, g=102346, c=102345, q=61) Apr 11 15:39:11 debian kernel: [ 5634.979555] sending NMI to all CPUs: Apr 11 15:39:11 debian kernel: [ 5634.979935] NMI backtrace for cpu 2 Apr 11 15:39:11 debian kernel: [ 5634.980123] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G O 3.16.0-4-amd64 #1 Debian 3.16.7-ckt25-1 Apr 11 15:39:11 debian kernel: [ 5634.980140] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 07/02/2015 Apr 11 15:39:11 debian kernel: [ 5634.980212] task: 880139ffa0d0 ti: 880139848000 task.ti: 880139848000 Apr 11 15:39:11 debian kernel: [ 5634.980243] RIP: 0010:[] [] default_send_IPI_mask_sequence_phys+0xad/0xe0 Apr 11 15:39:11 debian kernel: [ 5634.980776] RSP: 0018:88013a643e18 EFLAGS: 0046 Apr 11 15:39:11 debian kernel: [ 5634.980790] RAX: 0400 RBX: a0ea RCX: 0002 Apr 11 15:39:11 debian kernel: [ 5634.980802] RDX: 0002 RSI: 0200 RDI: 0300 Apr 11 15:39:11 debian kernel: [ 5634.980815] RBP: 818e28e0 R08: 818e28e0 R09: 0677 Apr 11 15:39:11 debian kernel: [ 5634.980827] R10: R11: 88013a643b96 R12: 0400 Apr 11 15:39:11 debian kernel: [ 5634.980840] R13: 0096 R14: 0002 R15: 0004 Apr 11 15:39:11 debian kernel: [ 5634.980917] FS: 7fc2af615740() GS:88013a64() knlGS: Apr 11 15:39:11 debian kernel: [ 5634.980931] CS: 0010 DS: ES: CR0: 8005003b Apr 11 15:39:11 debian kernel: [ 5634.980943] CR2: 7fad5b599000 CR3: b7c85000 CR4: 07e0 Apr 11 15:39:11 debian kernel: [ 5634.981074] Stack: Apr 11 15:39:11 debian kernel: [ 5634.981125] 0002 88013a64d660 81853780 0002 Apr 11 15:39:11 debian kernel: [ 5634.981176] 818e2e40 003d 81853840 810469c3 Apr 11 15:39:11 debian kernel: [ 5634.981181] 88013a64d660 810c5add 0001 0083 Apr 11 15:39:11 debian kernel: [ 5634.981217] Call Trace: Apr 11 15:39:11 debian kernel: [ 5634.981349] Apr 11 15:39:11 debian kernel: [ 5634.981557] [] ? arch_trigger_all_cpu_backtrace+0xc3/0x140 Apr 11 15:39:11 debian kernel: [ 5634.981657] [] ? rcu_check_callbacks+0x60d/0x630 Apr 11 15:39:11 debian kernel: [ 5634.981664] [] ? tick_sched_handle.isra.16+0x60/0x60 Apr 11 15:39:11 debian kernel: [ 5634.981683] [] ? update_process_times+0x40/0x70 Apr 11 15:39:11 debian kernel: [ 5634.981688] [] ? tick_sched_handle.isra.16+0x20/0x60 Apr 11 15:39:11 debian kernel: [ 5634.981692] [] ? tick_sched_timer+0x3c/0x60 Apr 11 15:39:11 debian kernel: [ 5634.981703] [] ? __run_hrtimer+0x67/0x1c0 Apr 11 15:39:11 debian kernel: [ 5634.981706] [] ? hrtimer_interrupt+0xe9/0x220 Apr 11 15:39:11 debian kernel: [ 5634.981774] [] ? smp_apic_timer_interrupt+0x3b/0x60 Apr 11 15:39:11 debian kernel: [ 5634.981781] [] ? apic_timer_interrupt+0x6d/0x80 Apr 11 15:39:11 debian kernel: [ 5634.981808] Apr 11 15:39:11 debian kernel: [ 5634.981840] [] ? idle_notifier_unregister+0x20/0x20 Apr 11 15:39:11 debian kernel: [ 5634.981886] [] ? native_safe_halt+0x2/0x10 Apr 11 15:39:11 debian kernel: [ 5634.981891] [] ? default_idle+0x19/0xb0 Apr 11 15:39:11 debian kernel: [ 5634.981922] [] ? cpu_startup_entry+0x340/0x400 Apr 11 15:39:11 debian kernel: [ 5634.981927] [] ? start_secondary+0x20f/0x2d0 Apr 11 15:39:11 debian kernel: [ 5634.981958] Code: 8b 0c 25 00 53 5f ff 80 e5 10 75 f2 44 89 f8 c1 e0 18 89 04 25 10 53 5f ff 41 83 fe 02 44 89 e0 41 0f 45 c6 89 04 25 00 53 5f ff 91 4c 89 ef 57 9d 66 66 90 66 90 48 83 c4 08 5b 5d 41 5c 41 Apr 11 15:39:11 debian kernel: [ 5634.982407] NMI backtrace for cpu 1 Apr 11 15:39:11 debian kernel: [ 5634.983053] CPU: 1 PID: 3295 Comm: sshd Tainted: G O 3.16.0-4-amd64 #1 Debian 3.16.7-ckt25-1 Apr 11 15:39:11 debian kernel: [ 5634.983084] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 07/02/2015 Apr 11 15:39:11 debian kernel: [ 5634.983156] task: 8801375ceb60 ti: 88007b43 task.ti: 88007b43 Apr 11 15:39:11 debian kernel: [ 5634.983221] RIP: 0010:[] [] _raw_spin_lock_bh+0x31/0x40 Apr 11 15:39:11 debian kernel: [ 5634.984386] RSP: 0018:88007b433d18 EFLAGS: 0297 Apr 11 15:39:11 debian kernel: [ 5634.984404] RAX: 128b RBX: 8800ba1a0840 RCX: 128c Apr 11 15:39:11 debian kernel: [ 5634.984418] RDX: 128c RSI: RDI: 8800ba1a08b0 Apr 11 15:39:11 debian kernel: [ 5634.984431] RBP: 4000 R08: 0040 R09: Apr 11 15:39:11 debian kernel: [ 5634.984445] R10: R11: 0246 R12:
[PATCH] drivers/scsi: fix macro in sg
This patch fix the macro transport_class_to_sdev to the resonable name and use the macro. Signed-off-by: vonnyfly --- drivers/scsi/sg.c |6 +++--- include/scsi/scsi_device.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 9d7b7db..be7f132 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1454,10 +1454,10 @@ out_unlock: static int sg_add_device(struct device *cl_dev, struct class_interface *cl_intf) { - struct scsi_device *scsidp = to_scsi_device(cl_dev->parent); - struct gendisk *disk; + struct scsi_device *scsidp = transport_class_to_scsi_device(cl_dev); + struct gendisk *disk = NULL; Sg_device *sdp = NULL; - struct cdev * cdev = NULL; + struct cdev *cdev = NULL; int error; unsigned long iflags; diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index ae84b22..f6a5473 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -227,7 +227,7 @@ struct scsi_dh_data { container_of(d, struct scsi_device, sdev_gendev) #define class_to_sdev(d) \ container_of(d, struct scsi_device, sdev_dev) -#define transport_class_to_sdev(class_dev) \ +#define transport_class_to_scsi_device(class_dev) \ to_scsi_device(class_dev->parent) #define sdev_dbg(sdev, fmt, a...) \ -- 1.7.10.4 -- Thanks and Best Regards, Feng Li(Alex) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] drivers/scsi: fix macro in sg
This patch fix the macro transport_class_to_sdev to the resonable name and use the macro. Signed-off-by: vonnyfly lifeng1...@gmail.com --- drivers/scsi/sg.c |6 +++--- include/scsi/scsi_device.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 9d7b7db..be7f132 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1454,10 +1454,10 @@ out_unlock: static int sg_add_device(struct device *cl_dev, struct class_interface *cl_intf) { - struct scsi_device *scsidp = to_scsi_device(cl_dev-parent); - struct gendisk *disk; + struct scsi_device *scsidp = transport_class_to_scsi_device(cl_dev); + struct gendisk *disk = NULL; Sg_device *sdp = NULL; - struct cdev * cdev = NULL; + struct cdev *cdev = NULL; int error; unsigned long iflags; diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index ae84b22..f6a5473 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -227,7 +227,7 @@ struct scsi_dh_data { container_of(d, struct scsi_device, sdev_gendev) #define class_to_sdev(d) \ container_of(d, struct scsi_device, sdev_dev) -#define transport_class_to_sdev(class_dev) \ +#define transport_class_to_scsi_device(class_dev) \ to_scsi_device(class_dev-parent) #define sdev_dbg(sdev, fmt, a...) \ -- 1.7.10.4 -- Thanks and Best Regards, Feng Li(Alex) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] fs/cepth compile error
I try to compile kernel v3.9.2 v3.9.5, It outputs couldn't find fs/cepth/ioctl.o Go to the dir and couldn't find the ioctl.c,only a ioctl.h file.But the ioctl.h isn't included by other file. So simply remove ioctl.o from the Makefile to fix. Thanks commit d8e29a9f5a2474ac0dcb26baa3cf29075f3ce980 Author: vonnyfly Date: Mon Jun 10 14:53:38 2013 +0800 fix ioctl.o not find error --- fs/ceph/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/Makefile b/fs/ceph/Makefile index bd35212..e0d2294 100644 --- a/fs/ceph/Makefile +++ b/fs/ceph/Makefile @@ -4,7 +4,7 @@ obj-$(CONFIG_CEPH_FS) += ceph.o -ceph-y := super.o inode.o dir.o file.o locks.o addr.o ioctl.o \ +ceph-y := super.o inode.o dir.o file.o locks.o addr.o \ export.o caps.o snap.o xattr.o \ mds_client.o mdsmap.o strings.o ceph_frag.o \ debugfs.o -- Thanks and Best Regards, vonnyfly Cell:13401157876 Email :lifeng1...@gmail.com Addr: Rm. 911,DaYunCun,Zhichun Road,Haidian Districts Beijing,100191 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] fs/cepth compile error
I try to compile kernel v3.9.2 v3.9.5, It outputs couldn't find fs/cepth/ioctl.o Go to the dir and couldn't find the ioctl.c,only a ioctl.h file.But the ioctl.h isn't included by other file. So simply remove ioctl.o from the Makefile to fix. Thanks commit d8e29a9f5a2474ac0dcb26baa3cf29075f3ce980 Author: vonnyfly lifeng1...@gmail.com Date: Mon Jun 10 14:53:38 2013 +0800 fix ioctl.o not find error --- fs/ceph/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/Makefile b/fs/ceph/Makefile index bd35212..e0d2294 100644 --- a/fs/ceph/Makefile +++ b/fs/ceph/Makefile @@ -4,7 +4,7 @@ obj-$(CONFIG_CEPH_FS) += ceph.o -ceph-y := super.o inode.o dir.o file.o locks.o addr.o ioctl.o \ +ceph-y := super.o inode.o dir.o file.o locks.o addr.o \ export.o caps.o snap.o xattr.o \ mds_client.o mdsmap.o strings.o ceph_frag.o \ debugfs.o -- Thanks and Best Regards, vonnyfly Cell:13401157876 Email :lifeng1...@gmail.com Addr: Rm. 911,DaYunCun,Zhichun Road,Haidian Districts Beijing,100191 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/