[PATCH] Staging:rtl8192u: fixed coding style issues
Fixed the following coding style issues:
r819xU_firmware.c:72: ERROR: space required after that ',' (ctx:VxO)
r819xU_firmware.c:72: ERROR: space required before that '&' (ctx:OxV)
r819xU_firmware.c:72: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:97: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:248: ERROR: space required after that ',' (ctx:VxO)
r819xU_firmware.c:248: ERROR: space required before that '&' (ctx:OxV)
r819xU_firmware.c:260: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:260: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:265: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:265: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:325: ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Aldo Iljazi
---
drivers/staging/rtl8192u/r819xU_firmware.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c
b/drivers/staging/rtl8192u/r819xU_firmware.c
index d27b1e2..a7d3033 100644
--- a/drivers/staging/rtl8192u/r819xU_firmware.c
+++ b/drivers/staging/rtl8192u/r819xU_firmware.c
@@ -66,7 +66,7 @@ static bool fw_download_code(struct net_device *dev, u8
*code_virtual_address,
skb = dev_alloc_skb(USB_HWDESC_HEADER_LEN + frag_length + 4);
if (!skb)
return false;
- memcpy((unsigned char *)(skb->cb),&dev,sizeof(dev));
+ memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
tcb_desc = (cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
tcb_desc->queue_index = TXCMD_QUEUE;
tcb_desc->bCmdOrInit = DESC_PACKET_TYPE_INIT;
@@ -91,7 +91,7 @@ static bool fw_download_code(struct net_device *dev, u8
*code_virtual_address,
if (!priv->ieee80211->check_nic_enough_desc(dev, index) ||
(!skb_queue_empty(&priv->ieee80211->skb_waitQ[index])) ||
(priv->ieee80211->queue_stop)) {
-
RT_TRACE(COMP_FIRMWARE,"=>
tx full!\n");
+ RT_TRACE(COMP_FIRMWARE,
"=> tx full!\n");
skb_queue_tail(&priv->ieee80211->skb_waitQ[tcb_desc->queue_index], skb);
} else {
priv->ieee80211->softmac_hard_start_xmit(skb, dev);
@@ -242,7 +242,7 @@ bool init_firmware(struct net_device *dev)
* or read image file from array. Default load from IMG file
*/
if (rst_opt == OPT_SYSTEM_RESET) {
- rc = request_firmware(&fw_entry,
fw_name[init_step],&priv->udev->dev);
+ rc = request_firmware(&fw_entry, fw_name[init_step],
&priv->udev->dev);
if (rc < 0) {
RT_TRACE(COMP_ERR, "request firmware fail!\n");
goto download_firmware_fail;
@@ -254,12 +254,12 @@ bool init_firmware(struct net_device *dev)
}
if (init_step != FW_INIT_STEP1_MAIN) {
-
memcpy(pfirmware->firmware_buf,fw_entry->data,fw_entry->size);
+ memcpy(pfirmware->firmware_buf, fw_entry->data,
fw_entry->size);
mapped_file = pfirmware->firmware_buf;
file_length = fw_entry->size;
} else {
memset(pfirmware->firmware_buf, 0, 128);
-
memcpy(&pfirmware->firmware_buf[128],fw_entry->data,fw_entry->size);
+ memcpy(&pfirmware->firmware_buf[128],
fw_entry->data, fw_entry->size);
mapped_file = pfirmware->firmware_buf;
file_length = fw_entry->size + 128;
}
@@ -319,7 +319,7 @@ bool init_firmware(struct net_device *dev)
rt_status = CPUcheck_firmware_ready(dev);
if (!rt_status) {
- RT_TRACE(COMP_ERR, "CPUcheck_firmware_ready
fail(%d)!\n",rt_status);
+ RT_TRACE(COMP_ERR, "CPUcheck_firmware_ready
fail(%d)!\n", rt_status);
goto download_firmware_fail;
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: speakup: synth.c: removed a space
Samuel Thibault wrote: > Err, I'd rather make it really visible that the for loop doesn't have > its first statement? Wouldn't it be better if you add a comment there? So it would follow the coding style? -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: speakup: synth.c: removed a space
Line 468: Removed a space before a semicolon. Signed-off-by: Aldo Iljazi --- drivers/staging/speakup/synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index 0b3549b..2a4b348 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup/synth.c @@ -465,7 +465,7 @@ void synth_remove(struct spk_synth *in_synth) if (in_synth == synths[i]) break; } - for ( ; synths[i] != NULL; i++) /* compress table */ + for (; synths[i] != NULL; i++) /* compress table */ synths[i] = synths[i+1]; module_status = 0; mutex_unlock(&spk_mutex); -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: usbip: vhci_hcd.c: removed a space
Line 921: Removed the space before the semicolon.
Signed-off-by: Aldo Iljazi
---
drivers/staging/usbip/vhci_hcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
index e810ad5..fa3e0b2 100644
--- a/drivers/staging/usbip/vhci_hcd.c
+++ b/drivers/staging/usbip/vhci_hcd.c
@@ -918,7 +918,7 @@ static void vhci_stop(struct usb_hcd *hcd)
sysfs_remove_group(&vhci_dev(vhci)->kobj, &dev_attr_group);
/* 2. shutdown all the ports of vhci_hcd */
- for (rhport = 0 ; rhport < VHCI_NPORTS; rhport++) {
+ for (rhport = 0; rhport < VHCI_NPORTS; rhport++) {
struct vhci_device *vdev = &vhci->vdev[rhport];
usbip_event_add(&vdev->ud, VDEV_EVENT_REMOVED);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] Drivers: staging: dgap: checkpatch.pl cleanups
A few checkpatch cleanups, particularly:
Lines 26, 60: Removed trailing whitespace.
Lines 36-38, 42-44, 47: Removed spaces at the start of the lines.
Signed-off-by: Aldo Iljazi
---
drivers/staging/dgap/dgap_downld.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/dgap/dgap_downld.h
b/drivers/staging/dgap/dgap_downld.h
index 271ac19..b471284 100644
--- a/drivers/staging/dgap/dgap_downld.h
+++ b/drivers/staging/dgap/dgap_downld.h
@@ -23,7 +23,7 @@
*/
/*
-** downld.h
+** downld.h
** - describes the interface between the user level download process
**and the concentrator download driver.
*/
@@ -33,18 +33,18 @@
struct fepimg {
-int type; /* board type */
-intlen;/* length of image */
-char fepimage[1]; /* beginning of image */
+ int type; /* board type */
+ int len;/* length of image */
+ char fepimage[1]; /* beginning of image */
};
struct downldio {
-unsigned int req_type; /* FEP or concentrator */
-unsigned int bdid; /* opaque board identifier */
-union {
- struct downld_t dl; /* download structure */
- struct fepimg fi; /* fep/bios image structure */
-} image;
+ unsigned int req_type; /* FEP or concentrator */
+ unsigned int bdid; /* opaque board identifier */
+ union {
+ struct downld_t dl; /* download structure */
+ struct fepimg fi; /* fep/bios image structure */
+ } image;
};
#define DIGI_DLREQ_GET (('d'<<8) | 220)
@@ -57,7 +57,7 @@ struct downldio {
#define DIGI_NUKE_RESET_ALL (1 << 31)
#define DIGI_NUKE_INHIBIT_POLLER (1 << 30)
#define DIGI_NUKE_BRD_NUMB0x0f
-
+
#defineDLREQ_BIOS 0
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] Drivers: staging: dgap: checkpatch.pl cleanups
A few checkpatch cleanups, particularly:
Lines 83, 87, 89, 196: Removed spaces before tabs.
Lines 141, 265.267: Removed trailing whitespace.
Signed-off-by: Aldo Iljazi
---
drivers/staging/dgap/dgap_conf.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/dgap/dgap_conf.h b/drivers/staging/dgap/dgap_conf.h
index 8809701..32ac17c 100644
--- a/drivers/staging/dgap/dgap_conf.h
+++ b/drivers/staging/dgap/dgap_conf.h
@@ -80,13 +80,13 @@
#define MC8E8K 36
#define AVANFS 42 /* start of Avanstar family definitions */
-#define A8P42
+#define A8P42
#define A16P 43
#define AVANFE 43 /* end of Avanstar family definitions */
#define DA2000FS 44 /* start of AccelePort 2000 family definitions
*/
-#define DA22 44 /* AccelePort 2002 */
-#define DA24 45 /* AccelePort 2004 */
+#define DA22 44 /* AccelePort 2002 */
+#define DA24 45 /* AccelePort 2004 */
#define DA28 46 /* AccelePort 2008 */
#define DA216 47 /* AccelePort 2016 */
#define DAR4 48 /* AccelePort RAS 4 port */
@@ -138,11 +138,11 @@
#defineCU 91
#definePRINT 92
#defineXPRINT 93
-#define CMAJOR 94
-#define ALTPIN 95
-#define STARTO 96
-#define USEINTR 97
-#define PCIINFO 98
+#define CMAJOR 94
+#define ALTPIN 95
+#define STARTO 96
+#define USEINTR97
+#define PCIINFO98
#defineTTSIZ 100
#defineCHSIZ 101
@@ -193,7 +193,7 @@ struct cnode {
union {
struct {
- char type; /* Board Type */
+ char type; /* Board Type */
short port; /* I/O Address */
char *portstr; /* I/O Address in string */
long addr; /* Memory Address */
@@ -262,9 +262,9 @@ struct cnode {
} module;
char *ttyname;
-
+
char *cuname;
-
+
char *printname;
int majornumber;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: dgnc: dgnc_trace.c: fixed coding style issues
Fixed the following coding style issues:
Lines 66-70: Replaced spaced with tabs.
Lines 75, 98, 182: Inserted space before the open parenthesis.
Line 89: Inserted spaces around that '='
Signed-off-by: Aldo Iljazi
---
drivers/staging/dgnc/dgnc_trace.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_trace.c
b/drivers/staging/dgnc/dgnc_trace.c
index a98b7d4..e59b781 100644
--- a/drivers/staging/dgnc/dgnc_trace.c
+++ b/drivers/staging/dgnc/dgnc_trace.c
@@ -63,16 +63,16 @@ void dgnc_tracef(const char *fmt, ...)
void dgnc_tracef(const char *fmt, ...)
{
- va_list ap;
- char buf[TRC_MAXMSG+1];
- size_t lenbuf;
- int i;
- static int failed = FALSE;
+ va_list ap;
+ charbuf[TRC_MAXMSG+1];
+ size_t lenbuf;
+ int i;
+ static int failed = FALSE;
# if defined(TRC_TO_KMEM)
unsigned longflags;
#endif
- if(failed)
+ if (failed)
return;
# if defined(TRC_TO_KMEM)
DGNC_LOCK(dgnc_tracef_lock, flags);
@@ -86,7 +86,7 @@ void dgnc_tracef(const char *fmt, ...)
# if defined(TRC_TO_KMEM)
{
- static int initd=0;
+ static int initd = 0;
/*
* Now, in addition to (or instead of) printing this stuff out
@@ -95,7 +95,7 @@ void dgnc_tracef(const char *fmt, ...)
*/
if (!initd) {
dgnc_trcbuf = (char *) vmalloc(dgnc_trcbuf_size);
- if(!dgnc_trcbuf) {
+ if (!dgnc_trcbuf) {
failed = TRUE;
printk("dgnc: tracing init failed!\n");
return;
@@ -179,6 +179,6 @@ void dgnc_tracef(const char *fmt, ...)
*/
void dgnc_tracer_free(void)
{
- if(dgnc_trcbuf)
+ if (dgnc_trcbuf)
vfree(dgnc_trcbuf);
}
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: Android: Checkpatch cleanups.
alarm-dev.c:
Lines 71,72: Removed parantheses since return is not a function.
Signed-off-by: Aldo Iljazi
---
drivers/staging/android/alarm-dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/alarm-dev.c
b/drivers/staging/android/alarm-dev.c
index 647694f..ccf74ee 100644
--- a/drivers/staging/android/alarm-dev.c
+++ b/drivers/staging/android/alarm-dev.c
@@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
*/
static int is_wakeup(enum android_alarm_type type)
{
- return (type == ANDROID_ALARM_RTC_WAKEUP ||
- type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
+ return type == ANDROID_ALARM_RTC_WAKEUP ||
+ type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
}
--
1.8.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: ced1401: ced_ioc.c: Removed whitespace
Line 633: Removed whitespace.
Signed-off-by: Aldo Iljazi
---
drivers/staging/ced1401/ced_ioc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ced1401/ced_ioc.c
b/drivers/staging/ced1401/ced_ioc.c
index 62efd74..043a932 100644
--- a/drivers/staging/ced1401/ced_ioc.c
+++ b/drivers/staging/ced1401/ced_ioc.c
@@ -630,7 +630,7 @@ int ClearArea(DEVICE_EXTENSION *pdx, int nArea)
}
spin_unlock_irq(&pdx->stagedLock);
- if (pPages) { /* if we decided to release the memory
*/
+ if (pPages) { /* if we decided to release the memory
*/
/* Now we must undo the pinning down of the
pages. We will assume the worst and mark */
/* all the pages as dirty. Don't be tempted to
move this up above as you must not be */
/* holding a spin lock to do this stuff as it
is not atomic. */
--
1.8.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Drivers: staging: ft1000-usb: ft1000_proc.c: fixed a few styling issues.
Fixed a few styling issues, particularly:
Lines 36,42: Inserted a space before the open paranthesis.
Line 50: Removed space between function name and open parenthesis.
Lines 56,57: Removed trailing whitespace.
lines: 130, 133: Replaced spaces with tabs for identation.
Signed-off-by: Aldo Iljazi
---
drivers/staging/ft1000/ft1000-usb/ft1000_proc.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c
b/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c
index 5ead942..2575d0d 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_proc.c
@@ -33,13 +33,13 @@
#define seq_putx(m, message, size, var) \
seq_printf(m, message); \
- for(i = 0; i < (size - 1); i++) \
+ for (i = 0; i < (size - 1); i++) \
seq_printf(m, "%02x:", var[i]); \
seq_printf(m, "%02x\n", var[i])
#define seq_putd(m, message, size, var) \
seq_printf(m, message); \
- for(i = 0; i < (size - 1); i++) \
+ for (i = 0; i < (size - 1); i++) \
seq_printf(m, "%d.", var[i]); \
seq_printf(m, "%d\n", var[i])
@@ -47,14 +47,14 @@
#define FTNET_PROC init_net.proc_net
-int ft1000_read_dpram16 (struct ft1000_usb *ft1000dev, u16 indx,
+int ft1000_read_dpram16(struct ft1000_usb *ft1000dev, u16 indx,
u8 *buffer, u8 highlow);
static int ft1000ReadProc(struct seq_file *m, void *v)
{
- static const char *status[] = {
- "Idle (Disconnect)",
+ static const char *status[] = {
+ "Idle (Disconnect)",
"Searching",
"Active (Connected)",
"Waiting for L2",
@@ -127,10 +127,10 @@ static int ft1000ReadProc(struct seq_file *m, void *v)
}
seq_printf(m, "Connection Time: %02ld:%02ld:%02ld\n",
- ((delta / 3600) % 24), ((delta / 60) % 60), (delta % 60));
+ ((delta / 3600) % 24), ((delta / 60) % 60), (delta % 60));
seq_printf(m, "Connection Time[s]: %ld\n", delta);
seq_printf(m, "Asic ID: %s\n",
- (info->AsicID) == ELECTRABUZZ_ID ? "ELECTRABUZZ ASIC" : "MAGNEMITE
ASIC");
+ (info->AsicID) == ELECTRABUZZ_ID ? "ELECTRABUZZ ASIC" : "MAGNEMITE
ASIC");
seq_putx(m, "SKU: ", SKUSZ, info->Sku);
seq_putx(m, "EUI64: ", EUISZ, info->eui64);
seq_putd(m, "DSP version number: ", DSPVERSZ, info->DspVer);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Are you interested in a Linux Kernel Off-topic Mailing List?
Levente Kurusa wrote: > Umm, I wanted to see your website but it seems that your domain is only > registered, > but no NS has been set so far it seems. (or not propagated yet) Go to http://www.aldo.io -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Are you interested in a Linux Kernel Off-topic Mailing List?
Aldo Iljazi wrote: > I created it, here it is lk...@googlegroups.com > > https://groups.google.com/d/forum/lkoml Okay guys I moved it to my custom domain using the http://www.nabble.com service. Go to http://aldo.io and subscribe ;) -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Are you interested in a Linux Kernel Off-topic Mailing List?
Aldo Iljazi wrote: > Hello everyone. I am thinking of creating a Mailing List for our > community but for unofficial topics. I think it would help to know each > other and it would expand our conversation into different areas. > > Politics and Religion are prohibited topics. I was thinking the areas of > discussion to be more on Science, Sports, Life, Philosophy etc. > > What do you think? > > I also created a poll here: http://poll.fm/4hqba > -- > Aldo Iljazi I created it, here it is lk...@googlegroups.com https://groups.google.com/d/forum/lkoml -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] FS: BTRFS: fixed coding style issues
David Sterba wrote: > On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: > > Fixed three coding style issues. Replaced spaces with tabs. > > > > Signed-off-by: Aldo Iljazi > > --- > > fs/btrfs/dev-replace.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c > > index 9efb94e..b2fe609 100644 > > --- a/fs/btrfs/dev-replace.c > > +++ b/fs/btrfs/dev-replace.c > > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, > > printk_in_rcu(KERN_INFO > > "btrfs: dev_replace from %s (devid %llu) to %s) > > started\n", > > src_device->missing ? "" : > > - rcu_str_deref(src_device->name), > > + rcu_str_deref(src_device->name), > > What's the change here? I don't think we need to fix whitespace, this > makes searching in patch history more boring, namely in case where the > code looks exactly the same before and after the patch. > > The style issues should be best fixed when the patch is about to be > merged, doing it later like this is kind of not welcome, speaking for > myself. There are lots of opportunities to do real code cleanups. > > > david Okay thanks. -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: ft1000: ft1000_download: fixed coding style issues
Greg KH wrote: > On Sun, Nov 10, 2013 at 03:44:20PM +0200, Aldo Iljazi wrote: > > Fixed the following coding style issues: > > Note that I added the filename to the Subject:, please do so in the > future to make it easier to see what exactly you are changing. You are right. I'll do that. -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Are you interested in a Linux Kernel Off-topic Mailing List?
Aldo Iljazi wrote: > Hello everyone. I am thinking of creating a Mailing List for our > community but for unofficial topics. I think it would help to know each > other and it would expand our conversation into different areas. > > Politics and Religion are prohibited topics. I was thinking the areas of > discussion to be more on Science, Sports, Life, Philosophy etc. > > What do you think? > > I also created a poll here: http://poll.fm/4hqba > -- > Aldo Iljazi This poll is going to run for another 24 hours. So please vote if you are interested (or not). Thanks. -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: ft1000: fixed coding style issues
Fixed the following coding style issues:
Lines 84-91,99-106,275,514: Replaced spaces at the start of the lines
with tabs.
Lines 205,271: Inserted spaces after the commas.
Lines 275,1060,1065: Indented the code with tabs instead of spaces.
Line 275: Inserted spaces around '=' and '<', also moved the trailing
statement on the next line.
Line 512: Removed space between function name and open parenthesis.
Line 839: Removed space after '&'.
Line 853: Removed space after '&'.
Signed-off-by: Aldo Iljazi
---
.../staging/ft1000/ft1000-usb/ft1000_download.c| 57 +++---
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
index 68ded17..170908a 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
@@ -81,29 +81,29 @@
#define DWNLD_MAG1_PS_HDR_LOC0x03
struct dsp_file_hdr {
- long version_id; // Version ID of this image format.
- long package_id; // Package ID of code release.
- long build_date; // Date/time stamp when file was
built.
- long commands_offset; // Offset to attached commands in
Pseudo Hdr format.
- long loader_offset; // Offset to bootloader code.
- long loader_code_address; // Start address of bootloader.
- long loader_code_end; // Where bootloader code ends.
- long loader_code_size;
- long version_data_offset; // Offset were scrambled version
data begins.
- long version_data_size; // Size, in words, of scrambled
version data.
- long nDspImages; // Number of DSP images in file.
+ long version_id; // Version ID of this image
format.
+ long package_id; // Package ID of code release.
+ long build_date; // Date/time stamp when file was
built.
+ long commands_offset; // Offset to attached commands
in Pseudo Hdr format.
+ long loader_offset; // Offset to bootloader code.
+ long loader_code_address; // Start address of bootloader.
+ long loader_code_end; // Where bootloader code ends.
+ long loader_code_size;
+ long version_data_offset; // Offset were scrambled version
data begins.
+ long version_data_size; // Size, in words, of scrambled
version data.
+ long nDspImages; // Number of DSP images in file.
};
#pragma pack(1)
struct dsp_image_info {
- long coff_date; // Date/time when DSP Coff image was
built.
- long begin_offset;// Offset in file where image begins.
- long end_offset; // Offset in file where image begins.
- long run_address; // On chip Start address of DSP code.
- long image_size; // Size of image.
- long version; // Embedded version # of DSP code.
- unsigned shortchecksum;// DSP File checksum
- unsigned shortpad1;
+ long coff_date; // Date/time when DSP Coff image
was built.
+ long begin_offset;// Offset in file where image
begins.
+ long end_offset; // Offset in file where image
begins.
+ long run_address; // On chip Start address of DSP
code.
+ long image_size; // Size of image.
+ long version; // Embedded version # of DSP
code.
+ unsigned shortchecksum;// DSP File checksum
+ unsigned shortpad1;
};
@@ -202,7 +202,7 @@ static u16 get_handshake(struct ft1000_usb *ft1000dev, u16
expected_value)
}
/* write the handshake value to the handshake location */
-static void put_handshake(struct ft1000_usb *ft1000dev,u16 handshake_value)
+static void put_handshake(struct ft1000_usb *ft1000dev, u16 handshake_value)
{
u32 tempx;
u16 tempword;
@@ -268,11 +268,12 @@ static u16 get_handshake_usb(struct ft1000_usb
*ft1000dev, u16 expected_value)
return HANDSHAKE_TIMEOUT_VALUE;
}
-static void put_handshake_usb(struct ft1000_usb *ft1000dev,u16 handshake_value)
+static void put_handshake_usb(struct ft1000_usb *ft1000dev, u16
handshake_value)
{
int i;
-for (i=0; i<1000; i++);
+ for (i = 0; i < 1000; i++)
+ ;
}
static u16 get_request_type(struct ft1000_usb *ft1000dev)
@@ -509,9 +510,9 @@ static int write_blk(struct ft1000_usb *ft1000dev, u16
**pUsFile, u8 **pUcFile,
return status;
}
-sta
Are you interested in a Linux Kernel Off-topic Mailing List?
Hello everyone. I am thinking of creating a Mailing List for our community but for unofficial topics. I think it would help to know each other and it would expand our conversation into different areas. Politics and Religion are prohibited topics. I was thinking the areas of discussion to be more on Science, Sports, Life, Philosophy etc. What do you think? I also created a poll here: http://poll.fm/4hqba -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] FS: BTRFS: fixed coding style issues
David Sterba wrote: > On Tue, Nov 05, 2013 at 12:40:16PM +0200, Aldo Iljazi wrote: > > > > I replaced the spaces with tabs, as the kernel coding style suggests. > > > > > > I repeat: > > > > > > Whitespace changes are just noise, we don't need them at this point of > > > development phase of btrfs. > > > > > > david > > > > Okay then ignore the patch. > > Well, this also applies to patches with subject 'BTRFS: fixed coding style > issues' Okay then. -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] FS: BTRFS: fixed coding style issues
David Sterba wrote: > On Tue, Nov 05, 2013 at 12:32:37PM +0200, Aldo Iljazi wrote: > > David Sterba wrote: > > > > > On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: > > > > Fixed three coding style issues. Replaced spaces with tabs. > > > > > > > > Signed-off-by: Aldo Iljazi > > > > --- > > > > fs/btrfs/dev-replace.c | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c > > > > index 9efb94e..b2fe609 100644 > > > > --- a/fs/btrfs/dev-replace.c > > > > +++ b/fs/btrfs/dev-replace.c > > > > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, > > > > printk_in_rcu(KERN_INFO > > > > "btrfs: dev_replace from %s (devid %llu) to %s) > > > > started\n", > > > > src_device->missing ? "" : > > > > - rcu_str_deref(src_device->name), > > > > + rcu_str_deref(src_device->name), > > > > > > What's the change here? I don't think we need to fix whitespace, this > > > makes > > > searching in patch history more tedious, namely in case where the code > > > looks > > > exactly the same before and after the patch. > > > > > > The style issues should be best fixed when the patch is about to be > > > merged, doing it later like this is kind of not welcome, speaking for > > > myself. There are lots of opportunities to do real code cleanups. > > > > > > Whitespace changes are just noise, we don't need them at this point of > > > development phase of btrfs. > > > > > > > > > david > > > > I replaced the spaces with tabs, as the kernel coding style suggests. > > I repeat: > > Whitespace changes are just noise, we don't need them at this point of > development phase of btrfs. > > david Okay then ignore the patch. -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] FS: BTRFS: fixed coding style issues
David Sterba wrote: > On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: > > Fixed three coding style issues. Replaced spaces with tabs. > > > > Signed-off-by: Aldo Iljazi > > --- > > fs/btrfs/dev-replace.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c > > index 9efb94e..b2fe609 100644 > > --- a/fs/btrfs/dev-replace.c > > +++ b/fs/btrfs/dev-replace.c > > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, > > printk_in_rcu(KERN_INFO > > "btrfs: dev_replace from %s (devid %llu) to %s) > > started\n", > > src_device->missing ? "" : > > - rcu_str_deref(src_device->name), > > + rcu_str_deref(src_device->name), > > What's the change here? I don't think we need to fix whitespace, this makes > searching in patch history more tedious, namely in case where the code looks > exactly the same before and after the patch. > > The style issues should be best fixed when the patch is about to be > merged, doing it later like this is kind of not welcome, speaking for > myself. There are lots of opportunities to do real code cleanups. > > Whitespace changes are just noise, we don't need them at this point of > development phase of btrfs. > > > david I replaced the spaces with tabs, as the kernel coding style suggests. -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] BTRFS: fixed a coding style issue
Line 31: Removed spaces before the semicolons.
Signed-off-by: Aldo Iljazi
---
fs/btrfs/print-tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/print-tree.c b/fs/btrfs/print-tree.c
index 0088bed..19dd143 100644
--- a/fs/btrfs/print-tree.c
+++ b/fs/btrfs/print-tree.c
@@ -28,7 +28,7 @@ static void print_chunk(struct extent_buffer *eb, struct
btrfs_chunk *chunk)
"num_stripes %d\n",
btrfs_chunk_length(eb, chunk), btrfs_chunk_owner(eb, chunk),
btrfs_chunk_type(eb, chunk), num_stripes);
- for (i = 0 ; i < num_stripes ; i++) {
+ for (i = 0; i < num_stripes; i++) {
printk(KERN_INFO "\t\t\tstripe %d devid %llu offset %llu\n", i,
btrfs_stripe_devid_nr(eb, chunk, i),
btrfs_stripe_offset_nr(eb, chunk, i));
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] BTRFS: fixed a coding style issue
Line 265: Inserted a space before the open parenthesis. Signed-off-by: Aldo Iljazi --- fs/btrfs/async-thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c index 08cc08f..8aec751 100644 --- a/fs/btrfs/async-thread.c +++ b/fs/btrfs/async-thread.c @@ -262,7 +262,7 @@ static struct btrfs_work *get_next_work(struct btrfs_worker_thread *worker, struct btrfs_work *work = NULL; struct list_head *cur = NULL; - if(!list_empty(prio_head)) + if (!list_empty(prio_head)) cur = prio_head->next; smp_mb(); -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] BTRFS: fixed two coding style issues
Line 26 and 31: Replaced spaces with tabs at the start of the lines.
Signed-off-by: Aldo Iljazi
---
fs/btrfs/struct-funcs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/struct-funcs.c b/fs/btrfs/struct-funcs.c
index b976597..09528ec 100644
--- a/fs/btrfs/struct-funcs.c
+++ b/fs/btrfs/struct-funcs.c
@@ -23,12 +23,12 @@
static inline u8 get_unaligned_le8(const void *p)
{
- return *(u8 *)p;
+ return *(u8 *)p;
}
static inline void put_unaligned_le8(u8 val, void *p)
{
- *(u8 *)p = val;
+ *(u8 *)p = val;
}
/*
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] BTRFS: fixed coding style issues
Line 4989: Inserted a space after the comma.
Lines 7986 and 8274: Inserted a space before the open parenthesis.
Signed-off-by: Aldo Iljazi
---
fs/btrfs/extent-tree.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index d58bef1..3bcd7c0 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -4986,7 +4986,7 @@ int btrfs_delalloc_reserve_metadata(struct inode *inode,
u64 num_bytes)
mutex_unlock(&BTRFS_I(inode)->delalloc_mutex);
if (to_reserve)
- trace_btrfs_space_reservation(root->fs_info,"delalloc",
+ trace_btrfs_space_reservation(root->fs_info, "delalloc",
btrfs_ino(inode), to_reserve, 1);
block_rsv_add_bytes(block_rsv, to_reserve, 1);
@@ -7983,7 +7983,7 @@ u64 btrfs_account_ro_block_groups_free_space(struct
btrfs_space_info *sinfo)
spin_lock(&sinfo->lock);
- for(i = 0; i < BTRFS_NR_RAID_TYPES; i++)
+ for (i = 0; i < BTRFS_NR_RAID_TYPES; i++)
if (!list_empty(&sinfo->block_groups[i]))
free_bytes += __btrfs_get_ro_block_group_free_space(
&sinfo->block_groups[i]);
@@ -8271,7 +8271,7 @@ int btrfs_free_block_groups(struct btrfs_fs_info *info)
release_global_block_rsv(info);
- while(!list_empty(&info->space_info)) {
+ while (!list_empty(&info->space_info)) {
space_info = list_entry(info->space_info.next,
struct btrfs_space_info,
list);
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 3.12 released .. and 4.0 plans?
Jan Engelhardt wrote: > > On Monday 2013-11-04 01:10, Linus Torvalds wrote: > > > >Onto a totally different topic: we're getting to release numbers where > >I have to take off my socks to count that high again. I'm ok with > >3. [...] [4.0 "ok, after 3.19 (or whatever),"] > > What would you do when the major number becomes such an unpleasant > highteen number? (That will be in ~64 years if you wrap after x.19.) > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ I guess renaming the kernel would be an option. (Linus would be ~106 years old by the way.) -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] FS: BTRFS: fixed a styling issue
Line 363:
Added a space before the open parenthesis.
Signed-off-by: Aldo Iljazi
---
fs/btrfs/compression.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
index 6aad98c..91338d2 100644
--- a/fs/btrfs/compression.c
+++ b/fs/btrfs/compression.c
@@ -360,7 +360,7 @@ int btrfs_submit_compressed_write(struct inode *inode, u64
start,
bdev = BTRFS_I(inode)->root->fs_info->fs_devices->latest_bdev;
bio = compressed_bio_alloc(bdev, first_byte, GFP_NOFS);
- if(!bio) {
+ if (!bio) {
kfree(cb);
return -ENOMEM;
}
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] FS: BTRFS: fixed coding style issues
Fixed three coding style issues. Replaced spaces with tabs. Signed-off-by: Aldo Iljazi --- fs/btrfs/dev-replace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c index 9efb94e..b2fe609 100644 --- a/fs/btrfs/dev-replace.c +++ b/fs/btrfs/dev-replace.c @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, printk_in_rcu(KERN_INFO "btrfs: dev_replace from %s (devid %llu) to %s) started\n", src_device->missing ? "" : - rcu_str_deref(src_device->name), + rcu_str_deref(src_device->name), src_device->devid, rcu_str_deref(tgt_device->name)); @@ -500,7 +500,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info, printk_in_rcu(KERN_ERR "btrfs: btrfs_scrub_dev(%s, %llu, %s) failed %d\n", src_device->missing ? "" : - rcu_str_deref(src_device->name), + rcu_str_deref(src_device->name), src_device->devid, rcu_str_deref(tgt_device->name), scrub_ret); btrfs_dev_replace_unlock(dev_replace); @@ -515,7 +515,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info, printk_in_rcu(KERN_INFO "btrfs: dev_replace from %s (devid %llu) to %s) finished\n", src_device->missing ? "" : - rcu_str_deref(src_device->name), + rcu_str_deref(src_device->name), src_device->devid, rcu_str_deref(tgt_device->name)); tgt_device->is_tgtdev_for_dev_replace = 0; -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: ft1000: fixed a few styling issues
Dan Carpenter wrote: > On Mon, Nov 04, 2013 at 02:15:22PM +0200, Aldo Iljazi wrote: > > Fixed the following styling issues: > > > > Line 30: > > Removed space before open square bracket '[' > > > > Lines 31 to 155: > > Moved the commas that were in the start of the lines, to the end of the > > lines. > > Inserted spaces after the commas. > > Inserted a one tab indentation to each line. > > > > Signed-off-by: Aldo Iljazi > > Looks nice. Thank you. > > Reviewed-by: Dan Carpenter > > regards, > dan carpenter > I am sorry for the previous mess. I am new to this. -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: ft1000: fixed a few styling issues
Fixed the following styling issues:
Line 30:
Removed space before open square bracket '['
Lines 31 to 155:
Moved the commas that were in the start of the lines, to the end of the lines.
Inserted spaces after the commas.
Inserted a one tab indentation to each line.
Signed-off-by: Aldo Iljazi
---
drivers/staging/ft1000/ft1000-pcmcia/boot.h | 252 ++--
1 file changed, 126 insertions(+), 126 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
index 9dce54e..915165e 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
+++ b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
@@ -27,132 +27,132 @@
#define _BOOTH_
// Official bootloader
-static unsigned char bootimage [] = {
-0x00,0x00,0x01,0x5E,0x00,0x00
-,0x00,0x00,0x00,0x00,0x02,0xD7
-,0x00,0x00,0x01,0x5E,0x46,0xB3
-,0xE6,0x02,0x00,0x98,0xE6,0x8C
-,0x00,0x98,0xFB,0x92,0xFF,0xFF
-,0x98,0xFB,0x94,0xFF,0xFF,0x98
-,0xFB,0x06,0x08,0x00,0x98,0xFB
-,0x96,0x84,0x00,0x98,0xFB,0x08
-,0x1C,0x00,0x98,0xFB,0x51,0x25
-,0x10,0x1C,0x00,0xE6,0x51,0x01
-,0x07,0xFD,0x4C,0xFF,0x20,0xF5
-,0x51,0x02,0x20,0x08,0x00,0x4C
-,0xFF,0x20,0x3C,0x00,0xC0,0x64
-,0x98,0xC0,0x66,0x98,0xC0,0x68
-,0x98,0xC0,0x6A,0x98,0xC0,0x6C
-,0x98,0x90,0x08,0x90,0x09,0x90
-,0x0A,0x90,0x0B,0x90,0x0C,0x90
-,0x0D,0x90,0x0E,0x90,0x0F,0x90
-,0x04,0x90,0x06,0xFB,0x51,0x22
-,0x16,0x08,0x03,0xFB,0x51,0x52
-,0x16,0x08,0x04,0xFB,0x51,0x24
-,0x2B,0x08,0x06,0xFB,0x51,0x54
-,0x2B,0x08,0x07,0xFB,0x51,0x24
-,0x2B,0x08,0x09,0xFB,0x51,0x54
-,0x2B,0x08,0x0A,0xFB,0x51,0x12
-,0x16,0x08,0x0C,0xFB,0x51,0x52
-,0x16,0x08,0x0D,0x78,0x00,0x00
-,0x00,0x16,0x00,0x00,0xEC,0x31
-,0xAE,0x00,0x00,0x81,0x4C,0x0F
-,0xE6,0x43,0xFF,0xEC,0x31,0x4E
-,0x00,0x00,0x91,0xEC,0x31,0xAE
-,0x00,0x00,0x91,0x4C,0x0F,0xE6
-,0x43,0xFF,0xEC,0x31,0x5E,0x00
-,0x00,0xA1,0xEB,0x31,0x08,0x00
-,0x00,0xA6,0xEB,0x31,0x08,0x00
-,0x00,0xAC,0x3C,0x00,0xEB,0x31
-,0x08,0x00,0x00,0xA8,0x76,0xFE
-,0xFE,0x08,0xEB,0x31,0x08,0x20
-,0x00,0x00,0x76,0xFF,0xFF,0x18
-,0xED,0x31,0x08,0x20,0x00,0x00
-,0x26,0x10,0x04,0x10,0xF5,0x3C
-,0x01,0x3C,0x00,0x08,0x01,0x12
-,0x3C,0x11,0x3C,0x00,0x08,0x01
-,0x0B,0x08,0x00,0x6D,0xEC,0x31
-,0xAE,0x20,0x00,0x06,0xED,0x4D
-,0x08,0x00,0x00,0x67,0x80,0x6F
-,0x00,0x01,0x0B,0x6F,0x00,0x02
-,0x2E,0x76,0xEE,0x01,0x48,0x06
-,0x01,0x39,0xED,0x4D,0x18,0x00
-,0x02,0xED,0x4D,0x08,0x00,0x04
-,0x14,0x06,0xA4,0xED,0x31,0x22
-,0x00,0x00,0xAC,0x76,0xEE,0x07
-,0x48,0x6D,0x22,0x01,0x1E,0x08
-,0x01,0x58,0xEB,0x31,0x08,0x00
-,0x00,0xAC,0x06,0xFF,0xBA,0x3C
-,0x00,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x30,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x00
-,0x00,0xA2,0x91,0x00,0x9C,0x3C
-,0x80,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x20,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x20
-,0x00,0x04,0x42,0x10,0x90,0x08
-,0xEC,0x31,0xAE,0x20,0x00,0x06
-,0xA4,0x41,0x08,0x00,0xB6,0xED
-,0x41,0x28,0x7D,0xFF,0xFF,0x22
-,0xB3,0x40,0x98,0x2A,0x32,0xEB
-,0x41,0x28,0xB4,0x43,0xFC,0x05
-,0xFF,0xE6,0xA0,0x31,0x20,0x00
-,0x06,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x20,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x20
-,0x00,0x04,0x42,0x10,0x90,0x08
-,0xEC,0x31,0xAE,0x20,0x00,0x06
-,0xA4,0x41,0x08,0x00,0x68,0xED
-,0x41,0x28,0x7D,0xFF,0xFF,0x22
-,0xB3,0x40,0x98,0x2A,0x32,0xEB
-,0x41,0x28,0xB4,0x43,0xFC,0x05
-,0xFF,0xE6,0x48,0x04,0xEB,0x31
-,0x08,0x20,0x00,0x04,0xEB,0x31
-,0x18,0x20,0x00,0x02,0x3C,0x11
-,0xEB,0x31,0x18,0x20,0x00,0x00
-,0xED,0x31,0x08,0x20,0x00,0x00
-,0x04,0x10,0xF7,0xED,0x31,0x08
-,0x20,0x00,0x02,0x66,0x00,0x6F
-,0x00,0x01,0x16,0x76,0xEE,0x06
-,0x48,0x4A,0x1E,0x48,0x04,0xED
-,0x31,0x08,0x20,0x00,0x04,0xEB
-,0x31,0x08,0x00,0x00,0xA4,0x48
-,0x04,0xED,0x31,0x08,0x20,0x00
-,0x04,0xEB,0x31,0x08,0x00,0x00
-,0xA2,0x48,0x04,0x20,0x20,0x4A
-,0x7C,0x46,0x82,0x50,0x05,0x50
-,0x15,0xB5,0x1E,0x98,0xED,0x31
-,0x08,0x00,0x00,0xA8,0x10,0x47
-,0x3B,0x2C,0x01,0xDB,0x40,0x11
-,0x98,0xC1,0x1E,0x98,0x10,0x07
-,0x30,0xF9,0x40,0x07,0x18,0x98
-,0x2A,0x10,0xEB,0x31,0x08,0x00
-,0x00,0xA8,0xA4,0x1E,0x98,0xBB
-,0x1E,0x98,0x50,0x14,0x50,0x04
-,0x46,0x83,0x48,0x04,0x02,0x01
-,0x00,0x50,0x05,0x50,0x15,0x10
-,0x87,0x3F,0x90,0x2B,0x18,0x01
-,0x00,0xC0,0x31,0x00,0x00,0xAE
-,0xDF,0x41,0x00,0x08,0x00,0x1A
-,0x42,0x11,0x67,0x01,0xDF,0x41
-,0x02,0x08,0x00,0x10,0x42,0x11
-,0x62,0x01,0xB4,0x43,0x4A,0x68
-,0x50,0x14,0x50,0x04,0x24,0x10
-,0x48,0x04,0xF2,0x31,0x00,0x01
-,0x00,0x00,0xAE,0xF6,0x31,0x00
-,0x01,0x00,0x00,0xAE,0x62,0xE4
-,0xE5,0x61,0x04,0x48,0x04,0xE5
-,0x63,0x05,0x48,0x04,0x20,0x20
-,0x00,0x00,0x00,0x00
+static unsigned char bootimage[] = {
+ 0x00, 0x00, 0x01, 0x5E, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x02, 0xD7,
+ 0x00, 0x00, 0x01, 0x5E, 0x46, 0xB3,
+ 0xE6, 0x02, 0x00, 0x98, 0xE6, 0x8C,
+
Re: [PATCH] Staging: ft1000: fixed a few styling issues
Dan Carpenter wrote: > On Mon, Nov 04, 2013 at 10:40:36AM +0200, Aldo Iljazi wrote: > > Dan Carpenter wrote: > > > > > On Mon, Nov 04, 2013 at 10:17:04AM +0200, Aldo Iljazi wrote: > > > > Dan Carpenter wrote: > > > > > > > > > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > > > > > Fixed a few styling issues, specifically: > > > > > > > > > > > > > > > > Gar... No one wants to read that changelog. That was over 700 lines > > > > > of repeated text. > > > > > > > > > > regards, > > > > > dan carpenter > > > > > > > > > > > > > > > > > > > > > > > You are right. I'll be careful next time. > > > > Should I resend? > > > > > > Yes, please. Also could you indent all the numbers one tab? > > > > In the beggining of the line or inbetween too? > > At the begining of the line only. > > regards, > dan carpenter > I am on it! -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: ft1000: fixed a few styling issues
Dan Carpenter wrote: > On Mon, Nov 04, 2013 at 10:17:04AM +0200, Aldo Iljazi wrote: > > Dan Carpenter wrote: > > > > > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > > > Fixed a few styling issues, specifically: > > > > > > > > > > Gar... No one wants to read that changelog. That was over 700 lines > > > of repeated text. > > > > > > regards, > > > dan carpenter > > > > > > > > > > > > > You are right. I'll be careful next time. > > Should I resend? > > Yes, please. Also could you indent all the numbers one tab? > > regards, > dan carpenter > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ In the beggining of the line or inbetween too? -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: ft1000: fixed a few styling issues
Dan Carpenter wrote: > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > Fixed a few styling issues, specifically: > > > > Gar... No one wants to read that changelog. That was over 700 lines > of repeated text. > > regards, > dan carpenter > > > You are right. I'll be careful next time. Should I resend? -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: A Desktop Linux idea: modulized open hardware database for the linux kernel config
andreas.thalham...@linux.com wrote: > Hello LKML! > > I am a Linux Desktop user since around 2001. Doing the math, that’s more than > a decade! > > Having watched http://www.youtube.com/watch?v=jjRAKuis7T8 (LinuxCon 2013, > Dirk > Hohndel and Linus Torvalds on stage) I decided to share an idea I had to make > kernel building easier for computer end-users: > > How aboud a free and open hardware database for configuring Linux? > > My idea would make a very simple to get kernel configuration for a modulized > hardware and feature base. It should be some kind of open for everybody > database in which everyone may participate. > > (This would off course only be of use for power users or developers. Regular > users will use stock kernels from their Linux distribution anyway. BTW, I use > Gentoo Linux.) > > An example: > My computer is a PC. The motherboard is an MSI 890FXA-GD70, it has an AMD > Phenom II X6 1090T in the CPU slot. So this setup would be the basic entry to > look for, which will provide a kernel configurtion for this specific > hardware. > For example, the module for the Fintek F71889ED Super IO Sensor has to be > selected (CONFIG_SENSORS_F71882FG) as well as CONFIG_SENSORS_K10TEMP for the > CPU. > > I know lm_sensors has a tools for that already: sensors-detect. But not > everything is covered there, is there? > > Then I would also combine this config with a config module for my graphics > card. It is a Radeon HD 6770, so readonkms has to be selected properly. Some > kernel parameters may also be wise, such as video=radeondrmfb, radeon.aspm=1 > and radeon.dpm=1. > > It should also be possible to combine this config with a config module for my > monitor. This will show that the resolution of this monitor is 1680x1050. > Unfortunately this resultution is not part of the VESA BIOS, so the kernel > command-line parameter video=radeondrmfb will be expanded by 1680x1050-32@60. > > Some basic profiles may define how the PC will be used: i.e. as a file > server, > as a Desktop conputer or as a gaming computer. A "cutting edge with all the > new features" profile may select everything that is usable for this computer. > > Every ISA/EISA/VLB/PCI/AGP/PCIe expansion card can and will add some config > settings to the big kernel configuration. I.e. if you had a DVB-TV card or > whatever. > > A basic "All USB-end-user-devices" config module for all possible USB devices > may select everything except those self-made stuff, like a thermal probe. On > the other hand, specific stuff should be allowed too. I.e. the Digitus > Cardreader All-in-one, USB 3.0 (DA-70330) – is a specific reader module > required (CONFIG_USB_STORAGE_*)? > > In the end there would be a hardware database, maybe combined with a wiki, > that includes developer information like hardware addresses and such as well > as user reports and kernel configuration modules for that hardware. > > Jumping to a newer kernel will automatically set the new/changed > CONFIG_SOMETHING for the selected profile. > > This would also be handy for Laptops and very narrow configured hardware such > as Apple computers (my Power Mac G4 for example). > > A tool for this could go into the kernel sources. It would detect the > hardware > present in the system using everything that is available (e.g. lspci) and > show > a configuration menu (make config-alike) that will enable the user to select > or deselect specific hardware config modules and profiles (i.e. "file > server"). > > Compiling a new kernel will then not result in searching the whole kernel > config for new or changed options like it is now (just recently I had to > change video=radeonfb to video=radeonkmsfb in my GRUB config). > > For kernel developers this could also be a very useful tool, because users > can > point to the specific hardware that makes troubles on Linux. And, like it is > in a community, developers may be able to reach users willing to participate > in testing new patches for fixing these troubles… > > This is just an idea. Now it’s out there – do with it whatever you like. The > idea is hereby released under the GPL-2 :-) > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ So, you are saying that this should be available for power users only, since it requires kernel compilation. I have a few points to make. 1. Wouldn't power users know how to configure the kernel anyway for their system? 2. What
[PATCH] Staging: ft1000: fixed a few styling issues
(ctx:VxV) boot.h:128: ERROR: space required after that ',' (ctx:VxV) boot.h:128: ERROR: space required after that ',' (ctx:VxV) boot.h:128: ERROR: space required after that ',' (ctx:VxV) boot.h:129: ERROR: space required after that ',' (ctx:ExV) boot.h:129: ERROR: space required after that ',' (ctx:VxV) boot.h:129: ERROR: space required after that ',' (ctx:VxV) boot.h:129: ERROR: space required after that ',' (ctx:VxV) boot.h:129: ERROR: space required after that ',' (ctx:VxV) boot.h:129: ERROR: space required after that ',' (ctx:VxV) boot.h:130: ERROR: space required after that ',' (ctx:ExV) boot.h:130: ERROR: space required after that ',' (ctx:VxV) boot.h:130: ERROR: space required after that ',' (ctx:VxV) boot.h:130: ERROR: space required after that ',' (ctx:VxV) boot.h:130: ERROR: space required after that ',' (ctx:VxV) boot.h:130: ERROR: space required after that ',' (ctx:VxV) boot.h:131: ERROR: space required after that ',' (ctx:ExV) boot.h:131: ERROR: space required after that ',' (ctx:VxV) boot.h:131: ERROR: space required after that ',' (ctx:VxV) boot.h:131: ERROR: space required after that ',' (ctx:VxV) boot.h:131: ERROR: space required after that ',' (ctx:VxV) boot.h:131: ERROR: space required after that ',' (ctx:VxV) boot.h:132: ERROR: space required after that ',' (ctx:ExV) boot.h:132: ERROR: space required after that ',' (ctx:VxV) boot.h:132: ERROR: space required after that ',' (ctx:VxV) boot.h:132: ERROR: space required after that ',' (ctx:VxV) boot.h:132: ERROR: space required after that ',' (ctx:VxV) boot.h:132: ERROR: space required after that ',' (ctx:VxV) boot.h:133: ERROR: space required after that ',' (ctx:ExV) boot.h:133: ERROR: space required after that ',' (ctx:VxV) boot.h:133: ERROR: space required after that ',' (ctx:VxV) boot.h:133: ERROR: space required after that ',' (ctx:VxV) boot.h:133: ERROR: space required after that ',' (ctx:VxV) boot.h:133: ERROR: space required after that ',' (ctx:VxV) boot.h:134: ERROR: space required after that ',' (ctx:ExV) boot.h:134: ERROR: space required after that ',' (ctx:VxV) boot.h:134: ERROR: space required after that ',' (ctx:VxV) boot.h:134: ERROR: space required after that ',' (ctx:VxV) boot.h:134: ERROR: space required after that ',' (ctx:VxV) boot.h:134: ERROR: space required after that ',' (ctx:VxV) boot.h:135: ERROR: space required after that ',' (ctx:ExV) boot.h:135: ERROR: space required after that ',' (ctx:VxV) boot.h:135: ERROR: space required after that ',' (ctx:VxV) boot.h:135: ERROR: space required after that ',' (ctx:VxV) boot.h:135: ERROR: space required after that ',' (ctx:VxV) boot.h:135: ERROR: space required after that ',' (ctx:VxV) boot.h:136: ERROR: space required after that ',' (ctx:ExV) boot.h:136: ERROR: space required after that ',' (ctx:VxV) boot.h:136: ERROR: space required after that ',' (ctx:VxV) boot.h:136: ERROR: space required after that ',' (ctx:VxV) boot.h:136: ERROR: space required after that ',' (ctx:VxV) boot.h:136: ERROR: space required after that ',' (ctx:VxV) boot.h:137: ERROR: space required after that ',' (ctx:ExV) boot.h:137: ERROR: space required after that ',' (ctx:VxV) boot.h:137: ERROR: space required after that ',' (ctx:VxV) boot.h:137: ERROR: space required after that ',' (ctx:VxV) boot.h:137: ERROR: space required after that ',' (ctx:VxV) boot.h:137: ERROR: space required after that ',' (ctx:VxV) boot.h:138: ERROR: space required after that ',' (ctx:ExV) boot.h:138: ERROR: space required after that ',' (ctx:VxV) boot.h:138: ERROR: space required after that ',' (ctx:VxV) boot.h:138: ERROR: space required after that ',' (ctx:VxV) boot.h:138: ERROR: space required after that ',' (ctx:VxV) boot.h:138: ERROR: space required after that ',' (ctx:VxV) boot.h:139: ERROR: space required after that ',' (ctx:ExV) boot.h:139: ERROR: space required after that ',' (ctx:VxV) boot.h:139: ERROR: space required after that ',' (ctx:VxV) boot.h:139: ERROR: space required after that ',' (ctx:VxV) boot.h:139: ERROR: space required after that ',' (ctx:VxV) boot.h:139: ERROR: space required after that ',' (ctx:VxV) boot.h:140: ERROR: space required after that ',' (ctx:ExV) boot.h:140: ERROR: space required after that ',' (ctx:VxV) boot.h:140: ERROR: space required after that ',' (ctx:VxV) boot.h:140: ERROR: space req
Re: [PATCH] Staging: ft1000: fixed coding style issues
Dan Carpenter wrote: > On Sat, Nov 02, 2013 at 11:18:20PM +0200, Aldo Iljazi wrote: > > Aldo Iljazi wrote: > > > > > Fixed a few coding style issues that checkpatch reported. > > > > > > Specifically: > > > > > > 1. line over 80 characters issue on the lines 9 and 10. > > > 2. space prohibited before open square bracket '[' issue on the lines > > > 31. > > > 3. inserted space after comma on lines 32 to 156. > > > > > > Signed-off-by: Aldo Iljazi > > This file is easy to review so you may as well fix all the issues. > > Clean up the license block so it's in the normal format. Put the commas > at the end of the line instead of the beginning. > > regards, > dan carpenter > Okay I'll resend later. -- Aldo Iljazi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Staging: ft1000: fixed coding style issues
Aldo Iljazi wrote:
> Fixed a few coding style issues that checkpatch reported.
>
> Specifically:
>
> 1. line over 80 characters issue on the lines 9 and 10.
> 2. space prohibited before open square bracket '[' issue on the lines
> 31.
> 3. inserted space after comma on lines 32 to 156.
>
> Signed-off-by: Aldo Iljazi
> ---
> drivers/staging/ft1000/ft1000-pcmcia/boot.h | 263
> ++--
> 1 file changed, 132 insertions(+), 131 deletions(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
> b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
> index 9dce54e..f384bc2 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
> @@ -6,11 +6,12 @@
> // This program is free software; you can redistribute it and/or modify it
> // under the terms of the GNU General Public License as published by the Free
> // Software Foundation; either version 2 of the License, or (at your option)
> any
> -// later version. This program is distributed in the hope that it will be
> useful,
> -// but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY
> -// or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
> for
> -// more details. You should have received a copy of the GNU General Public
> -// License along with this program; if not, write to the
> +// later version. This program is distributed in the hope that it will be
> +// useful, but WITHOUT ANY WARRANTY; without even the implied warranty of
> +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> +// See the GNU General Public License for more details.
> +// You should have received a copy of the GNU General Public License
> +// along with this program; if not, write to the
> // Free Software Foundation, Inc., 59 Temple Place -
> // Suite 330, Boston, MA 02111-1307, USA.
> //---
> @@ -27,132 +28,132 @@
> #define _BOOTH_
>
> // Official bootloader
> -static unsigned char bootimage [] = {
> -0x00,0x00,0x01,0x5E,0x00,0x00
> -,0x00,0x00,0x00,0x00,0x02,0xD7
> -,0x00,0x00,0x01,0x5E,0x46,0xB3
> -,0xE6,0x02,0x00,0x98,0xE6,0x8C
> -,0x00,0x98,0xFB,0x92,0xFF,0xFF
> -,0x98,0xFB,0x94,0xFF,0xFF,0x98
> -,0xFB,0x06,0x08,0x00,0x98,0xFB
> -,0x96,0x84,0x00,0x98,0xFB,0x08
> -,0x1C,0x00,0x98,0xFB,0x51,0x25
> -,0x10,0x1C,0x00,0xE6,0x51,0x01
> -,0x07,0xFD,0x4C,0xFF,0x20,0xF5
> -,0x51,0x02,0x20,0x08,0x00,0x4C
> -,0xFF,0x20,0x3C,0x00,0xC0,0x64
> -,0x98,0xC0,0x66,0x98,0xC0,0x68
> -,0x98,0xC0,0x6A,0x98,0xC0,0x6C
> -,0x98,0x90,0x08,0x90,0x09,0x90
> -,0x0A,0x90,0x0B,0x90,0x0C,0x90
> -,0x0D,0x90,0x0E,0x90,0x0F,0x90
> -,0x04,0x90,0x06,0xFB,0x51,0x22
> -,0x16,0x08,0x03,0xFB,0x51,0x52
> -,0x16,0x08,0x04,0xFB,0x51,0x24
> -,0x2B,0x08,0x06,0xFB,0x51,0x54
> -,0x2B,0x08,0x07,0xFB,0x51,0x24
> -,0x2B,0x08,0x09,0xFB,0x51,0x54
> -,0x2B,0x08,0x0A,0xFB,0x51,0x12
> -,0x16,0x08,0x0C,0xFB,0x51,0x52
> -,0x16,0x08,0x0D,0x78,0x00,0x00
> -,0x00,0x16,0x00,0x00,0xEC,0x31
> -,0xAE,0x00,0x00,0x81,0x4C,0x0F
> -,0xE6,0x43,0xFF,0xEC,0x31,0x4E
> -,0x00,0x00,0x91,0xEC,0x31,0xAE
> -,0x00,0x00,0x91,0x4C,0x0F,0xE6
> -,0x43,0xFF,0xEC,0x31,0x5E,0x00
> -,0x00,0xA1,0xEB,0x31,0x08,0x00
> -,0x00,0xA6,0xEB,0x31,0x08,0x00
> -,0x00,0xAC,0x3C,0x00,0xEB,0x31
> -,0x08,0x00,0x00,0xA8,0x76,0xFE
> -,0xFE,0x08,0xEB,0x31,0x08,0x20
> -,0x00,0x00,0x76,0xFF,0xFF,0x18
> -,0xED,0x31,0x08,0x20,0x00,0x00
> -,0x26,0x10,0x04,0x10,0xF5,0x3C
> -,0x01,0x3C,0x00,0x08,0x01,0x12
> -,0x3C,0x11,0x3C,0x00,0x08,0x01
> -,0x0B,0x08,0x00,0x6D,0xEC,0x31
> -,0xAE,0x20,0x00,0x06,0xED,0x4D
> -,0x08,0x00,0x00,0x67,0x80,0x6F
> -,0x00,0x01,0x0B,0x6F,0x00,0x02
> -,0x2E,0x76,0xEE,0x01,0x48,0x06
> -,0x01,0x39,0xED,0x4D,0x18,0x00
> -,0x02,0xED,0x4D,0x08,0x00,0x04
> -,0x14,0x06,0xA4,0xED,0x31,0x22
> -,0x00,0x00,0xAC,0x76,0xEE,0x07
> -,0x48,0x6D,0x22,0x01,0x1E,0x08
> -,0x01,0x58,0xEB,0x31,0x08,0x00
> -,0x00,0xAC,0x06,0xFF,0xBA,0x3C
> -,0x00,0xEB,0x31,0x08,0x20,0x00
> -,0x04,0x3C,0x30,0xEB,0x31,0x08
> -,0x20,0x00,0x02,0x3C,0x10,0xEB
> -,0x31,0x08,0x20,0x00,0x00,0xED
> -,0x31,0x08,0x20,0x00,0x00,0x04
> -,0x10,0xF7,0xED,0x31,0x08,0x00
> -,0x00,0xA2,0x91,0x00,0x9C,0x3C
> -,0x80,0xEB,0x31,0x08,0x20,0x00
> -,0x04,0x3C,0x20,0xEB,0x31,0x08
> -,0x20,0x00,0x02,0x3C,0x10,0xEB
> -,0x31,0x08,0x20,0x00,0x00,0xED
> -,0x31,0x08,0x20,0x00,0x00,0x04
> -,0x10,0xF7,0xED,0x31,0x08,0x20
> -,0x00,0x04,0x42,0x10,0x90,0x08
> -,0xEC,0x31,0xAE,0x20,0x00,0x06
> -,0xA4,0x41,0x08,0x00,0xB6,0xED
> -,0x41,0x28,0x7D,0xFF,0xFF,0x22
> -,0xB3,0x40,0x98,0x2A,0x32,0xEB
> -,0x41,0x28,0xB4,0x43,0xFC,0x05
> -,0xFF,0xE6,0xA0,0x31,0x20,0x
[PATCH] Staging: ft1000: fixed coding style issues
Fixed a few coding style issues that checkpatch reported.
Specifically:
1. line over 80 characters issue on the lines 9 and 10.
2. space prohibited before open square bracket '[' issue on the lines
31.
3. inserted space after comma on lines 32 to 156.
Signed-off-by: Aldo Iljazi
---
drivers/staging/ft1000/ft1000-pcmcia/boot.h | 263 ++--
1 file changed, 132 insertions(+), 131 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
index 9dce54e..f384bc2 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
+++ b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
@@ -6,11 +6,12 @@
// This program is free software; you can redistribute it and/or modify it
// under the terms of the GNU General Public License as published by the Free
// Software Foundation; either version 2 of the License, or (at your option)
any
-// later version. This program is distributed in the hope that it will be
useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY
-// or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
-// more details. You should have received a copy of the GNU General Public
-// License along with this program; if not, write to the
+// later version. This program is distributed in the hope that it will be
+// useful, but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+// See the GNU General Public License for more details.
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the
// Free Software Foundation, Inc., 59 Temple Place -
// Suite 330, Boston, MA 02111-1307, USA.
//---
@@ -27,132 +28,132 @@
#define _BOOTH_
// Official bootloader
-static unsigned char bootimage [] = {
-0x00,0x00,0x01,0x5E,0x00,0x00
-,0x00,0x00,0x00,0x00,0x02,0xD7
-,0x00,0x00,0x01,0x5E,0x46,0xB3
-,0xE6,0x02,0x00,0x98,0xE6,0x8C
-,0x00,0x98,0xFB,0x92,0xFF,0xFF
-,0x98,0xFB,0x94,0xFF,0xFF,0x98
-,0xFB,0x06,0x08,0x00,0x98,0xFB
-,0x96,0x84,0x00,0x98,0xFB,0x08
-,0x1C,0x00,0x98,0xFB,0x51,0x25
-,0x10,0x1C,0x00,0xE6,0x51,0x01
-,0x07,0xFD,0x4C,0xFF,0x20,0xF5
-,0x51,0x02,0x20,0x08,0x00,0x4C
-,0xFF,0x20,0x3C,0x00,0xC0,0x64
-,0x98,0xC0,0x66,0x98,0xC0,0x68
-,0x98,0xC0,0x6A,0x98,0xC0,0x6C
-,0x98,0x90,0x08,0x90,0x09,0x90
-,0x0A,0x90,0x0B,0x90,0x0C,0x90
-,0x0D,0x90,0x0E,0x90,0x0F,0x90
-,0x04,0x90,0x06,0xFB,0x51,0x22
-,0x16,0x08,0x03,0xFB,0x51,0x52
-,0x16,0x08,0x04,0xFB,0x51,0x24
-,0x2B,0x08,0x06,0xFB,0x51,0x54
-,0x2B,0x08,0x07,0xFB,0x51,0x24
-,0x2B,0x08,0x09,0xFB,0x51,0x54
-,0x2B,0x08,0x0A,0xFB,0x51,0x12
-,0x16,0x08,0x0C,0xFB,0x51,0x52
-,0x16,0x08,0x0D,0x78,0x00,0x00
-,0x00,0x16,0x00,0x00,0xEC,0x31
-,0xAE,0x00,0x00,0x81,0x4C,0x0F
-,0xE6,0x43,0xFF,0xEC,0x31,0x4E
-,0x00,0x00,0x91,0xEC,0x31,0xAE
-,0x00,0x00,0x91,0x4C,0x0F,0xE6
-,0x43,0xFF,0xEC,0x31,0x5E,0x00
-,0x00,0xA1,0xEB,0x31,0x08,0x00
-,0x00,0xA6,0xEB,0x31,0x08,0x00
-,0x00,0xAC,0x3C,0x00,0xEB,0x31
-,0x08,0x00,0x00,0xA8,0x76,0xFE
-,0xFE,0x08,0xEB,0x31,0x08,0x20
-,0x00,0x00,0x76,0xFF,0xFF,0x18
-,0xED,0x31,0x08,0x20,0x00,0x00
-,0x26,0x10,0x04,0x10,0xF5,0x3C
-,0x01,0x3C,0x00,0x08,0x01,0x12
-,0x3C,0x11,0x3C,0x00,0x08,0x01
-,0x0B,0x08,0x00,0x6D,0xEC,0x31
-,0xAE,0x20,0x00,0x06,0xED,0x4D
-,0x08,0x00,0x00,0x67,0x80,0x6F
-,0x00,0x01,0x0B,0x6F,0x00,0x02
-,0x2E,0x76,0xEE,0x01,0x48,0x06
-,0x01,0x39,0xED,0x4D,0x18,0x00
-,0x02,0xED,0x4D,0x08,0x00,0x04
-,0x14,0x06,0xA4,0xED,0x31,0x22
-,0x00,0x00,0xAC,0x76,0xEE,0x07
-,0x48,0x6D,0x22,0x01,0x1E,0x08
-,0x01,0x58,0xEB,0x31,0x08,0x00
-,0x00,0xAC,0x06,0xFF,0xBA,0x3C
-,0x00,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x30,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x00
-,0x00,0xA2,0x91,0x00,0x9C,0x3C
-,0x80,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x20,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x20
-,0x00,0x04,0x42,0x10,0x90,0x08
-,0xEC,0x31,0xAE,0x20,0x00,0x06
-,0xA4,0x41,0x08,0x00,0xB6,0xED
-,0x41,0x28,0x7D,0xFF,0xFF,0x22
-,0xB3,0x40,0x98,0x2A,0x32,0xEB
-,0x41,0x28,0xB4,0x43,0xFC,0x05
-,0xFF,0xE6,0xA0,0x31,0x20,0x00
-,0x06,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x20,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x20
-,0x00,0x04,0x42,0x10,0x90,0x08
-,0xEC,0x31,0xAE,0x20,0x00,0x06
-,0xA4,0x41,0x08,0x00,0x68,0xED
-,0x41,0x28,0x7D,0xFF,0xFF,0x22
-,0xB3,0x40,0x98,0x2A,0x32,0xEB
-,0x41,0x28,0xB4,0x43,0xFC,0x05
-,0xFF,0xE6,0x48,0x04,0xEB,0x31
-,0x08,0x20,0x00,0x04,0xEB,0x31
-,0x18,0x20,0x00,0x02,0x3C,0x11
-,0xEB,0x31,0x18,0x20,0x00,0x00
-,0xED,0x31,0x08,0x20,0x00,0x00
-,0x04,0x10,0xF7,0xED,0x31,0x08
-,0x20,0x00,0x02,0x66,0x00,0x6F
-,0x00,0x01,0x16,0x76
[PATCH] Staging: ft1000: fixed coding style issues
Fixed a few coding style issues that checkpatch reported.
Specifically:
1. line over 80 characters issue on the lines 9 and 10.
2. space prohibited before open square bracket '[' issue on the lines
31.
3. iserted space after comma on lines to 156
Signed-off-by: Aldo Iljazi
---
drivers/staging/ft1000/ft1000-pcmcia/boot.h | 263 ++--
1 file changed, 132 insertions(+), 131 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
index 9dce54e..f384bc2 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
+++ b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
@@ -6,11 +6,12 @@
// This program is free software; you can redistribute it and/or modify it
// under the terms of the GNU General Public License as published by the Free
// Software Foundation; either version 2 of the License, or (at your option)
any
-// later version. This program is distributed in the hope that it will be
useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY
-// or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
-// more details. You should have received a copy of the GNU General Public
-// License along with this program; if not, write to the
+// later version. This program is distributed in the hope that it will be
+// useful, but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+// See the GNU General Public License for more details.
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the
// Free Software Foundation, Inc., 59 Temple Place -
// Suite 330, Boston, MA 02111-1307, USA.
//---
@@ -27,132 +28,132 @@
#define _BOOTH_
// Official bootloader
-static unsigned char bootimage [] = {
-0x00,0x00,0x01,0x5E,0x00,0x00
-,0x00,0x00,0x00,0x00,0x02,0xD7
-,0x00,0x00,0x01,0x5E,0x46,0xB3
-,0xE6,0x02,0x00,0x98,0xE6,0x8C
-,0x00,0x98,0xFB,0x92,0xFF,0xFF
-,0x98,0xFB,0x94,0xFF,0xFF,0x98
-,0xFB,0x06,0x08,0x00,0x98,0xFB
-,0x96,0x84,0x00,0x98,0xFB,0x08
-,0x1C,0x00,0x98,0xFB,0x51,0x25
-,0x10,0x1C,0x00,0xE6,0x51,0x01
-,0x07,0xFD,0x4C,0xFF,0x20,0xF5
-,0x51,0x02,0x20,0x08,0x00,0x4C
-,0xFF,0x20,0x3C,0x00,0xC0,0x64
-,0x98,0xC0,0x66,0x98,0xC0,0x68
-,0x98,0xC0,0x6A,0x98,0xC0,0x6C
-,0x98,0x90,0x08,0x90,0x09,0x90
-,0x0A,0x90,0x0B,0x90,0x0C,0x90
-,0x0D,0x90,0x0E,0x90,0x0F,0x90
-,0x04,0x90,0x06,0xFB,0x51,0x22
-,0x16,0x08,0x03,0xFB,0x51,0x52
-,0x16,0x08,0x04,0xFB,0x51,0x24
-,0x2B,0x08,0x06,0xFB,0x51,0x54
-,0x2B,0x08,0x07,0xFB,0x51,0x24
-,0x2B,0x08,0x09,0xFB,0x51,0x54
-,0x2B,0x08,0x0A,0xFB,0x51,0x12
-,0x16,0x08,0x0C,0xFB,0x51,0x52
-,0x16,0x08,0x0D,0x78,0x00,0x00
-,0x00,0x16,0x00,0x00,0xEC,0x31
-,0xAE,0x00,0x00,0x81,0x4C,0x0F
-,0xE6,0x43,0xFF,0xEC,0x31,0x4E
-,0x00,0x00,0x91,0xEC,0x31,0xAE
-,0x00,0x00,0x91,0x4C,0x0F,0xE6
-,0x43,0xFF,0xEC,0x31,0x5E,0x00
-,0x00,0xA1,0xEB,0x31,0x08,0x00
-,0x00,0xA6,0xEB,0x31,0x08,0x00
-,0x00,0xAC,0x3C,0x00,0xEB,0x31
-,0x08,0x00,0x00,0xA8,0x76,0xFE
-,0xFE,0x08,0xEB,0x31,0x08,0x20
-,0x00,0x00,0x76,0xFF,0xFF,0x18
-,0xED,0x31,0x08,0x20,0x00,0x00
-,0x26,0x10,0x04,0x10,0xF5,0x3C
-,0x01,0x3C,0x00,0x08,0x01,0x12
-,0x3C,0x11,0x3C,0x00,0x08,0x01
-,0x0B,0x08,0x00,0x6D,0xEC,0x31
-,0xAE,0x20,0x00,0x06,0xED,0x4D
-,0x08,0x00,0x00,0x67,0x80,0x6F
-,0x00,0x01,0x0B,0x6F,0x00,0x02
-,0x2E,0x76,0xEE,0x01,0x48,0x06
-,0x01,0x39,0xED,0x4D,0x18,0x00
-,0x02,0xED,0x4D,0x08,0x00,0x04
-,0x14,0x06,0xA4,0xED,0x31,0x22
-,0x00,0x00,0xAC,0x76,0xEE,0x07
-,0x48,0x6D,0x22,0x01,0x1E,0x08
-,0x01,0x58,0xEB,0x31,0x08,0x00
-,0x00,0xAC,0x06,0xFF,0xBA,0x3C
-,0x00,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x30,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x00
-,0x00,0xA2,0x91,0x00,0x9C,0x3C
-,0x80,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x20,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x20
-,0x00,0x04,0x42,0x10,0x90,0x08
-,0xEC,0x31,0xAE,0x20,0x00,0x06
-,0xA4,0x41,0x08,0x00,0xB6,0xED
-,0x41,0x28,0x7D,0xFF,0xFF,0x22
-,0xB3,0x40,0x98,0x2A,0x32,0xEB
-,0x41,0x28,0xB4,0x43,0xFC,0x05
-,0xFF,0xE6,0xA0,0x31,0x20,0x00
-,0x06,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x20,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x20
-,0x00,0x04,0x42,0x10,0x90,0x08
-,0xEC,0x31,0xAE,0x20,0x00,0x06
-,0xA4,0x41,0x08,0x00,0x68,0xED
-,0x41,0x28,0x7D,0xFF,0xFF,0x22
-,0xB3,0x40,0x98,0x2A,0x32,0xEB
-,0x41,0x28,0xB4,0x43,0xFC,0x05
-,0xFF,0xE6,0x48,0x04,0xEB,0x31
-,0x08,0x20,0x00,0x04,0xEB,0x31
-,0x18,0x20,0x00,0x02,0x3C,0x11
-,0xEB,0x31,0x18,0x20,0x00,0x00
-,0xED,0x31,0x08,0x20,0x00,0x00
-,0x04,0x10,0xF7,0xED,0x31,0x08
-,0x20,0x00,0x02,0x66,0x00,0x6F
-,0x00,0x01,0x16,0x76
[PATCH] Staging: ft1000: fixed coding style issues
Fixed a few coding style issues that checkpatch reported.
Specifically:
1. line over 80 characters issue on the lines 9 and 10.
2. space prohibited before open square bracket '[' issue on the lines
30 to 155.
Signed-off-by: Aldo Iljazi
---
drivers/staging/ft1000/ft1000-pcmcia/boot.h | 263 ++--
1 file changed, 132 insertions(+), 131 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
index 9dce54e..f384bc2 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/boot.h
+++ b/drivers/staging/ft1000/ft1000-pcmcia/boot.h
@@ -6,11 +6,12 @@
// This program is free software; you can redistribute it and/or modify it
// under the terms of the GNU General Public License as published by the Free
// Software Foundation; either version 2 of the License, or (at your option)
any
-// later version. This program is distributed in the hope that it will be
useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY
-// or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
-// more details. You should have received a copy of the GNU General Public
-// License along with this program; if not, write to the
+// later version. This program is distributed in the hope that it will be
+// useful, but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+// See the GNU General Public License for more details.
+// You should have received a copy of the GNU General Public License
+// along with this program; if not, write to the
// Free Software Foundation, Inc., 59 Temple Place -
// Suite 330, Boston, MA 02111-1307, USA.
//---
@@ -27,132 +28,132 @@
#define _BOOTH_
// Official bootloader
-static unsigned char bootimage [] = {
-0x00,0x00,0x01,0x5E,0x00,0x00
-,0x00,0x00,0x00,0x00,0x02,0xD7
-,0x00,0x00,0x01,0x5E,0x46,0xB3
-,0xE6,0x02,0x00,0x98,0xE6,0x8C
-,0x00,0x98,0xFB,0x92,0xFF,0xFF
-,0x98,0xFB,0x94,0xFF,0xFF,0x98
-,0xFB,0x06,0x08,0x00,0x98,0xFB
-,0x96,0x84,0x00,0x98,0xFB,0x08
-,0x1C,0x00,0x98,0xFB,0x51,0x25
-,0x10,0x1C,0x00,0xE6,0x51,0x01
-,0x07,0xFD,0x4C,0xFF,0x20,0xF5
-,0x51,0x02,0x20,0x08,0x00,0x4C
-,0xFF,0x20,0x3C,0x00,0xC0,0x64
-,0x98,0xC0,0x66,0x98,0xC0,0x68
-,0x98,0xC0,0x6A,0x98,0xC0,0x6C
-,0x98,0x90,0x08,0x90,0x09,0x90
-,0x0A,0x90,0x0B,0x90,0x0C,0x90
-,0x0D,0x90,0x0E,0x90,0x0F,0x90
-,0x04,0x90,0x06,0xFB,0x51,0x22
-,0x16,0x08,0x03,0xFB,0x51,0x52
-,0x16,0x08,0x04,0xFB,0x51,0x24
-,0x2B,0x08,0x06,0xFB,0x51,0x54
-,0x2B,0x08,0x07,0xFB,0x51,0x24
-,0x2B,0x08,0x09,0xFB,0x51,0x54
-,0x2B,0x08,0x0A,0xFB,0x51,0x12
-,0x16,0x08,0x0C,0xFB,0x51,0x52
-,0x16,0x08,0x0D,0x78,0x00,0x00
-,0x00,0x16,0x00,0x00,0xEC,0x31
-,0xAE,0x00,0x00,0x81,0x4C,0x0F
-,0xE6,0x43,0xFF,0xEC,0x31,0x4E
-,0x00,0x00,0x91,0xEC,0x31,0xAE
-,0x00,0x00,0x91,0x4C,0x0F,0xE6
-,0x43,0xFF,0xEC,0x31,0x5E,0x00
-,0x00,0xA1,0xEB,0x31,0x08,0x00
-,0x00,0xA6,0xEB,0x31,0x08,0x00
-,0x00,0xAC,0x3C,0x00,0xEB,0x31
-,0x08,0x00,0x00,0xA8,0x76,0xFE
-,0xFE,0x08,0xEB,0x31,0x08,0x20
-,0x00,0x00,0x76,0xFF,0xFF,0x18
-,0xED,0x31,0x08,0x20,0x00,0x00
-,0x26,0x10,0x04,0x10,0xF5,0x3C
-,0x01,0x3C,0x00,0x08,0x01,0x12
-,0x3C,0x11,0x3C,0x00,0x08,0x01
-,0x0B,0x08,0x00,0x6D,0xEC,0x31
-,0xAE,0x20,0x00,0x06,0xED,0x4D
-,0x08,0x00,0x00,0x67,0x80,0x6F
-,0x00,0x01,0x0B,0x6F,0x00,0x02
-,0x2E,0x76,0xEE,0x01,0x48,0x06
-,0x01,0x39,0xED,0x4D,0x18,0x00
-,0x02,0xED,0x4D,0x08,0x00,0x04
-,0x14,0x06,0xA4,0xED,0x31,0x22
-,0x00,0x00,0xAC,0x76,0xEE,0x07
-,0x48,0x6D,0x22,0x01,0x1E,0x08
-,0x01,0x58,0xEB,0x31,0x08,0x00
-,0x00,0xAC,0x06,0xFF,0xBA,0x3C
-,0x00,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x30,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x00
-,0x00,0xA2,0x91,0x00,0x9C,0x3C
-,0x80,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x20,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x20
-,0x00,0x04,0x42,0x10,0x90,0x08
-,0xEC,0x31,0xAE,0x20,0x00,0x06
-,0xA4,0x41,0x08,0x00,0xB6,0xED
-,0x41,0x28,0x7D,0xFF,0xFF,0x22
-,0xB3,0x40,0x98,0x2A,0x32,0xEB
-,0x41,0x28,0xB4,0x43,0xFC,0x05
-,0xFF,0xE6,0xA0,0x31,0x20,0x00
-,0x06,0xEB,0x31,0x08,0x20,0x00
-,0x04,0x3C,0x20,0xEB,0x31,0x08
-,0x20,0x00,0x02,0x3C,0x10,0xEB
-,0x31,0x08,0x20,0x00,0x00,0xED
-,0x31,0x08,0x20,0x00,0x00,0x04
-,0x10,0xF7,0xED,0x31,0x08,0x20
-,0x00,0x04,0x42,0x10,0x90,0x08
-,0xEC,0x31,0xAE,0x20,0x00,0x06
-,0xA4,0x41,0x08,0x00,0x68,0xED
-,0x41,0x28,0x7D,0xFF,0xFF,0x22
-,0xB3,0x40,0x98,0x2A,0x32,0xEB
-,0x41,0x28,0xB4,0x43,0xFC,0x05
-,0xFF,0xE6,0x48,0x04,0xEB,0x31
-,0x08,0x20,0x00,0x04,0xEB,0x31
-,0x18,0x20,0x00,0x02,0x3C,0x11
-,0xEB,0x31,0x18,0x20,0x00,0x00
-,0xED,0x31,0x08,0x20,0x00,0x00
-,0x04,0x10,0xF7,0xED,0x31,0x08
-,0x20,0x00,0x02,0x66,0x00,0x6F
-,0x00,0x01,0x16,0x76,0xEE,0x06
-,0x48,0x4A,0x1E,0x48
Re: Proposal for menuconfig removal
On 24-10-2013 20:06, Richard Weinberger wrote: On Thu, Oct 24, 2013 at 7:03 PM, Aldo Iljazi wrote: On 24-10-2013 19:59, Alexander Holler wrote: Am 24.10.2013 18:52, schrieb Aldo Iljazi: On 24-10-2013 19:43, Alexander Holler wrote: Am 24.10.2013 18:39, schrieb Randy Dunlap: nconfig supports use of or just numeric key for the same functions. Ah, that isn't mentioned in the global help. Regards, Alexander Holler Therefore, it can be done? Currently almost nobody is using nconfig, there is zero reason to drop menuconfig. This is just a proposal anyway. -- http://aldo.io -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Proposal for menuconfig removal
On 24-10-2013 19:59, Alexander Holler wrote: Am 24.10.2013 18:52, schrieb Aldo Iljazi: On 24-10-2013 19:43, Alexander Holler wrote: Am 24.10.2013 18:39, schrieb Randy Dunlap: nconfig supports use of or just numeric key for the same functions. Ah, that isn't mentioned in the global help. Regards, Alexander Holler Therefore, it can be done? Aldo -- http://aldo.io -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Proposal for menuconfig removal
Since nconfig is there, menuconfig is redundant. I am proposing to remove it from the kernel. -- http://aldo.io -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: ft1000: fixed two coding style issues
Fixed two coding style issues, specifically:
ft1000_proc.c:35: ERROR: space required before the open parenthesis '('
ft1000_proc.c:42: ERROR: space required before the open parenthesis '('
Signed-off-by: Aldo Iljazi
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
index b2330f1..88f6f9c 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c
@@ -32,14 +32,14 @@
#define seq_putx(m, message, size, var) \
seq_printf(m, message); \
- for(i = 0; i < (size - 1); i++) { \
+ for (i = 0; i < (size - 1); i++) { \
seq_printf(m, "%02x:", var[i]); \
} \
seq_printf(m, "%02x\n", var[i])
#define seq_putd(m, message, size, var) \
seq_printf(m, message); \
- for(i = 0; i < (size - 1); i++) { \
+ for (i = 0; i < (size - 1); i++) { \
seq_printf(m, "%d.", var[i]); \
} \
seq_printf(m, "%d\n", var[i])
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: bcm: nvm: fixed space prohibition
Fixed space prohibition before semicolon, particularly:
nvm.c:106: WARNING: space prohibited before semicolon
nvm.c:1098: WARNING: space prohibited before semicolon
nvm.c:1279: WARNING: space prohibited before semicolon
nvm.c:2834: WARNING: space prohibited before semicolon
nvm.c:3361: WARNING: space prohibited before semicolon
nvm.c:4453: WARNING: space prohibited before semicolon
Signed-off-by: Aldo Iljazi
---
drivers/staging/bcm/nvm.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/bcm/nvm.c b/drivers/staging/bcm/nvm.c
index 91a5715..1f5b62b 100644
--- a/drivers/staging/bcm/nvm.c
+++ b/drivers/staging/bcm/nvm.c
@@ -103,7 +103,7 @@ static UCHAR ReadEEPROMStatusRegister(struct
bcm_mini_adapter *Adapter)
}
if (!(dwRetries%RETRIES_PER_DELAY))
udelay(1000);
- uiStatus = 0 ;
+ uiStatus = 0;
}
return uiData;
} /* ReadEEPROMStatusRegister */
@@ -1095,7 +1095,7 @@ static int BeceemFlashBulkWrite(struct bcm_mini_adapter
*Adapter,
goto BeceemFlashBulkWrite_EXIT;
}
uiTemp = uiTemp - 1;
- index = index + 1 ;
+ index = index + 1;
}
}
Adapter->SelectedChip = RESET_CHIP_SELECT;
@@ -1276,7 +1276,7 @@ static int BeceemFlashBulkWriteStatus(struct
bcm_mini_adapter *Adapter,
goto BeceemFlashBulkWriteStatus_EXIT;
}
uiTemp = uiTemp - 1;
- index = index + 1 ;
+ index = index + 1;
}
}
@@ -2831,7 +2831,7 @@ int BcmGetSectionValEndOffset(struct bcm_mini_adapter
*Adapter, enum bcm_flash2x
SectEndOffset = INVALID_OFFSET;
}
- return SectEndOffset ;
+ return SectEndOffset;
}
/*
@@ -3358,7 +3358,7 @@ int BcmSetActiveSection(struct bcm_mini_adapter *Adapter,
enum bcm_flash2x_secti
/* struct bcm_dsd_header sDSD = {0};
* struct bcm_iso_header sISO = {0};
*/
- int HighestPriDSD = 0 ;
+ int HighestPriDSD = 0;
int HighestPriISO = 0;
Status = IsSectionWritable(Adapter, eFlash2xSectVal);
@@ -4450,7 +4450,7 @@ int WriteToFlashWithoutSectorErase(struct
bcm_mini_adapter *Adapter,
BcmDoChipSelect(Adapter, uiOffset);
uiPartOffset = (uiOffset & (FLASH_PART_SIZE - 1)) +
GetFlashBaseAddr(Adapter);
- for (i = 0 ; i < uiNumBytes; i += Adapter->ulFlashWriteSize) {
+ for (i = 0; i < uiNumBytes; i += Adapter->ulFlashWriteSize) {
if (Adapter->ulFlashWriteSize == BYTE_WRITE_SUPPORT)
Status = flashByteWrite(Adapter, uiPartOffset,
pcBuff);
else
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Drivers: tty: n_gsm.c: fixed 7 errors & 6 warnings that checkpatch complained
On Mon, Jul 08, 2013 at 10:28:00PM +0300, Aldo Iljazi wrote:
> Specifically:
> n_gsm.c:810: ERROR: space required before the open parenthesis '('
> n_gsm.c:830: WARNING: line over 80 characters
> n_gsm.c:971: ERROR: trailing whitespace
> n_gsm.c:984: ERROR: code indent should use tabs where possible
> n_gsm.c:984: WARNING: please, no space before tabs
> n_gsm.c:984: WARNING: please, no spaces at the start of a line
> n_gsm.c:1141: WARNING: space prohibited before semicolon
> n_gsm.c:1743: ERROR: space required before the open brace '{'
> n_gsm.c:1744: WARNING: line over 80 characters
> n_gsm.c:1745: ERROR: code indent should use tabs where possible
> n_gsm.c:1746: ERROR: code indent should use tabs where possible
> n_gsm.c:2908: WARNING: line over 80 characters
> n_gsm.c:2912: ERROR: trailing whitespace
>
> Signed-off-by: Aldo Iljazi
> ---
> drivers/tty/n_gsm.c | 29 -
> 1 file changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index 6422390..c0f76da 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -807,7 +807,7 @@ static int gsm_dlci_data_output(struct gsm_mux *gsm,
> struct gsm_dlci *dlci)
> int h = dlci->adaption - 1;
>
> total_size = 0;
> - while(1) {
> + while (1) {
> len = kfifo_len(dlci->fifo);
> if (len == 0)
> return total_size;
> @@ -827,8 +827,8 @@ static int gsm_dlci_data_output(struct gsm_mux *gsm,
> struct gsm_dlci *dlci)
> switch (dlci->adaption) {
> case 1: /* Unstructured */
> break;
> - case 2: /* Unstructed with modem bits. Always one byte as we
> never
> -send inline break data */
> + case 2: /* Unstructed with modem bits.
> + Always one byte as we never send inline break data */
> *dp++ = gsm_encode_modem(dlci);
> break;
> }
> @@ -968,7 +968,7 @@ static void gsm_dlci_data_kick(struct gsm_dlci *dlci)
> unsigned long flags;
> int sweep;
>
> - if (dlci->constipated)
> + if (dlci->constipated)
> return;
>
> spin_lock_irqsave(&dlci->gsm->tx_lock, flags);
> @@ -981,7 +981,7 @@ static void gsm_dlci_data_kick(struct gsm_dlci *dlci)
> gsm_dlci_data_output(dlci->gsm, dlci);
> }
> if (sweep)
> - gsm_dlci_data_sweep(dlci->gsm);
> + gsm_dlci_data_sweep(dlci->gsm);
> spin_unlock_irqrestore(&dlci->gsm->tx_lock, flags);
> }
>
> @@ -1138,7 +1138,7 @@ static void gsm_control_modem(struct gsm_mux *gsm, u8
> *data, int clen)
> static void gsm_control_rls(struct gsm_mux *gsm, u8 *data, int clen)
> {
> struct tty_port *port;
> - unsigned int addr = 0 ;
> + unsigned int addr = 0;
> u8 bits;
> int len = clen;
> u8 *dp = data;
> @@ -1740,10 +1740,11 @@ static void gsm_queue(struct gsm_mux *gsm)
>
> if ((gsm->control & ~PF) == UI)
> gsm->fcs = gsm_fcs_add_block(gsm->fcs, gsm->buf, gsm->len);
> - if (gsm->encoding == 0){
> - /* WARNING: gsm->received_fcs is used for gsm->encoding = 0
> only.
> - In this case it contain the last piece of data
> - required to generate final CRC */
> + if (gsm->encoding == 0) {
> + /* WARNING: gsm->received_fcs is used for
> + gsm->encoding = 0 only.
> + In this case it contain the last piece of data
> + required to generate final CRC */
> gsm->fcs = gsm_fcs_add(gsm->fcs, gsm->received_fcs);
> }
> if (gsm->fcs != GOOD_FCS) {
> @@ -2904,9 +2905,11 @@ static int gsmtty_install(struct tty_driver *driver,
> struct tty_struct *tty)
> gsm = gsm_mux[mux];
> if (gsm->dead)
> return -EL2HLT;
> - /* If DLCI 0 is not yet fully open return an error. This is ok from a
> locking
> -perspective as we don't have to worry about this if DLCI0 is lost */
> - if (gsm->dlci[0] && gsm->dlci[0]->state != DLCI_OPEN)
> + /* If DLCI 0 is not yet fully open return an error.
> + This is ok from a locking
> + perspective as we don't have to worry about this
> + if DLCI0 is lost */
> + if (gsm->dlci[0] && gsm->dlci[0]->state != DLCI_OPEN)
> return -EL2NSYNC;
> dlci = gsm->dlci[line];
> if (dlci == NULL) {
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: csr: csr_wifi_router_sef.c: fixed a brace coding style issue
On Sat, Jul 06, 2013 at 12:03:14AM +0300, Aldo Iljazi wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Aldo Iljazi
> ---
> drivers/staging/csr/csr_wifi_router_sef.c |3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/csr/csr_wifi_router_sef.c
> b/drivers/staging/csr/csr_wifi_router_sef.c
> index 45a10fb..bdb7d3b 100644
> --- a/drivers/staging/csr/csr_wifi_router_sef.c
> +++ b/drivers/staging/csr/csr_wifi_router_sef.c
> @@ -9,8 +9,7 @@
>
> */
> #include "csr_wifi_router_sef.h"
>
> -const CsrWifiRouterStateHandlerType
> CsrWifiRouterDownstreamStateHandlers[CSR_WIFI_ROUTER_PRIM_DOWNSTREAM_COUNT] =
> -{
> +const CsrWifiRouterStateHandlerType
> CsrWifiRouterDownstreamStateHandlers[CSR_WIFI_ROUTER_PRIM_DOWNSTREAM_COUNT] =
> {
> /* 0x */ CsrWifiRouterMaPacketSubscribeReqHandler,
> /* 0x0001 */ CsrWifiRouterMaPacketUnsubscribeReqHandler,
> /* 0x0002 */ CsrWifiRouterMaPacketReqHandler,
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Drivers: tty: n_gsm.c: fixed 7 errors & 6 warnings that checkpatch complained
Specifically:
n_gsm.c:810: ERROR: space required before the open parenthesis '('
n_gsm.c:830: WARNING: line over 80 characters
n_gsm.c:971: ERROR: trailing whitespace
n_gsm.c:984: ERROR: code indent should use tabs where possible
n_gsm.c:984: WARNING: please, no space before tabs
n_gsm.c:984: WARNING: please, no spaces at the start of a line
n_gsm.c:1141: WARNING: space prohibited before semicolon
n_gsm.c:1743: ERROR: space required before the open brace '{'
n_gsm.c:1744: WARNING: line over 80 characters
n_gsm.c:1745: ERROR: code indent should use tabs where possible
n_gsm.c:1746: ERROR: code indent should use tabs where possible
n_gsm.c:2908: WARNING: line over 80 characters
n_gsm.c:2912: ERROR: trailing whitespace
Signed-off-by: Aldo Iljazi
---
drivers/tty/n_gsm.c | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 6422390..c0f76da 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -807,7 +807,7 @@ static int gsm_dlci_data_output(struct gsm_mux *gsm, struct
gsm_dlci *dlci)
int h = dlci->adaption - 1;
total_size = 0;
- while(1) {
+ while (1) {
len = kfifo_len(dlci->fifo);
if (len == 0)
return total_size;
@@ -827,8 +827,8 @@ static int gsm_dlci_data_output(struct gsm_mux *gsm, struct
gsm_dlci *dlci)
switch (dlci->adaption) {
case 1: /* Unstructured */
break;
- case 2: /* Unstructed with modem bits. Always one byte as we
never
- send inline break data */
+ case 2: /* Unstructed with modem bits.
+ Always one byte as we never send inline break data */
*dp++ = gsm_encode_modem(dlci);
break;
}
@@ -968,7 +968,7 @@ static void gsm_dlci_data_kick(struct gsm_dlci *dlci)
unsigned long flags;
int sweep;
- if (dlci->constipated)
+ if (dlci->constipated)
return;
spin_lock_irqsave(&dlci->gsm->tx_lock, flags);
@@ -981,7 +981,7 @@ static void gsm_dlci_data_kick(struct gsm_dlci *dlci)
gsm_dlci_data_output(dlci->gsm, dlci);
}
if (sweep)
- gsm_dlci_data_sweep(dlci->gsm);
+ gsm_dlci_data_sweep(dlci->gsm);
spin_unlock_irqrestore(&dlci->gsm->tx_lock, flags);
}
@@ -1138,7 +1138,7 @@ static void gsm_control_modem(struct gsm_mux *gsm, u8
*data, int clen)
static void gsm_control_rls(struct gsm_mux *gsm, u8 *data, int clen)
{
struct tty_port *port;
- unsigned int addr = 0 ;
+ unsigned int addr = 0;
u8 bits;
int len = clen;
u8 *dp = data;
@@ -1740,10 +1740,11 @@ static void gsm_queue(struct gsm_mux *gsm)
if ((gsm->control & ~PF) == UI)
gsm->fcs = gsm_fcs_add_block(gsm->fcs, gsm->buf, gsm->len);
- if (gsm->encoding == 0){
- /* WARNING: gsm->received_fcs is used for gsm->encoding = 0
only.
- In this case it contain the last piece of data
- required to generate final CRC */
+ if (gsm->encoding == 0) {
+ /* WARNING: gsm->received_fcs is used for
+ gsm->encoding = 0 only.
+ In this case it contain the last piece of data
+ required to generate final CRC */
gsm->fcs = gsm_fcs_add(gsm->fcs, gsm->received_fcs);
}
if (gsm->fcs != GOOD_FCS) {
@@ -2904,9 +2905,11 @@ static int gsmtty_install(struct tty_driver *driver,
struct tty_struct *tty)
gsm = gsm_mux[mux];
if (gsm->dead)
return -EL2HLT;
- /* If DLCI 0 is not yet fully open return an error. This is ok from a
locking
- perspective as we don't have to worry about this if DLCI0 is lost */
- if (gsm->dlci[0] && gsm->dlci[0]->state != DLCI_OPEN)
+ /* If DLCI 0 is not yet fully open return an error.
+ This is ok from a locking
+ perspective as we don't have to worry about this
+ if DLCI0 is lost */
+ if (gsm->dlci[0] && gsm->dlci[0]->state != DLCI_OPEN)
return -EL2NSYNC;
dlci = gsm->dlci[line];
if (dlci == NULL) {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: cxt1e1: ossiRelease.c: fixed a coding style issue.
Fixed a coding style issue, specifically checkpatch.pl complain: ossiRelease.c:27: WARNING: line over 80 characters Signed-off-by: Aldo Iljazi --- drivers/staging/cxt1e1/ossiRelease.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/cxt1e1/ossiRelease.c b/drivers/staging/cxt1e1/ossiRelease.c index f17a902..35575bf 100644 --- a/drivers/staging/cxt1e1/ossiRelease.c +++ b/drivers/staging/cxt1e1/ossiRelease.c @@ -24,6 +24,7 @@ *- */ -char pmcc4_OSSI_release[] = "$Release: PMCC4_3_1B, Copyright (c) 2008 One Stop Systems$"; +char pmcc4_OSSI_release[] = "$Release: PMCC4_3_1B, " +"Copyright (c) 2008 One Stop Systems$"; /*** End-of-File ***/ -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: csr: csr_wifi_router_sef.c: fixed a brace coding style issue
Fixed a coding style issue.
Signed-off-by: Aldo Iljazi
---
drivers/staging/csr/csr_wifi_router_sef.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/csr/csr_wifi_router_sef.c
b/drivers/staging/csr/csr_wifi_router_sef.c
index 45a10fb..bdb7d3b 100644
--- a/drivers/staging/csr/csr_wifi_router_sef.c
+++ b/drivers/staging/csr/csr_wifi_router_sef.c
@@ -9,8 +9,7 @@
*/
#include "csr_wifi_router_sef.h"
-const CsrWifiRouterStateHandlerType
CsrWifiRouterDownstreamStateHandlers[CSR_WIFI_ROUTER_PRIM_DOWNSTREAM_COUNT] =
-{
+const CsrWifiRouterStateHandlerType
CsrWifiRouterDownstreamStateHandlers[CSR_WIFI_ROUTER_PRIM_DOWNSTREAM_COUNT] = {
/* 0x */ CsrWifiRouterMaPacketSubscribeReqHandler,
/* 0x0001 */ CsrWifiRouterMaPacketUnsubscribeReqHandler,
/* 0x0002 */ CsrWifiRouterMaPacketReqHandler,
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: ft1000-pcmcia: ft1000_dnld.c: fixed four checkpatch
Fixed four checkpatch error complains, specifically:
ft1000_dnld.c:512: ERROR: space prohibited after that '&' (ctx:WxW)
ft1000_dnld.c:514: ERROR: space prohibited after that '&' (ctx:WxW)
ft1000_dnld.c:694: ERROR: space prohibited before that close parenthesis ')'
ft1000_dnld.c:713: ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Aldo Iljazi
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c
b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c
index f892598..6311b2f 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c
@@ -509,9 +509,9 @@ int card_download(struct net_device *dev, const u8
*pFileStart,
(long)(info->DSPInfoBlklen + 1)
/ 2;
put_request_value(dev, word_length);
pMailBoxData =
- (struct drv_msg *) &
info->DSPInfoBlk[0];
+ (struct drv_msg *)
&info->DSPInfoBlk[0];
pUsData =
- (u16 *) & pMailBoxData->data[0];
+ (u16 *) &pMailBoxData->data[0];
/* Provide mutual exclusive access
while reading ASIC registers. */
spin_lock_irqsave(&info->dpram_lock,
flags);
@@ -691,7 +691,7 @@ int card_download(struct net_device *dev, const u8
*pFileStart,
if (pHdr->portdest == 0x80 /* DspOAM */
&& (pHdr->portsrc == 0x00 /* Driver */
- || pHdr->portsrc == 0x10 /* FMM */ )) {
+ || pHdr->portsrc == 0x10 /* FMM */)) {
uiState = STATE_SECTION_PROV;
} else {
DEBUG(1,
@@ -710,7 +710,7 @@ int card_download(struct net_device *dev, const u8
*pFileStart,
pHdr = (struct pseudo_hdr *) pUcFile;
if (pHdr->checksum == hdr_checksum(pHdr)) {
- if (pHdr->portdest != 0x80 /* Dsp OAM */ ) {
+ if (pHdr->portdest != 0x80 /* Dsp OAM */) {
uiState = STATE_DONE_PROV;
break;
}
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: anrdroid: sync.c: fixed all checkpatch warnings
Specifically fixed:
sync.c:128: WARNING: braces {} are not necessary for single statement blocks
sync.c:879: WARNING: Prefer seq_puts to seq_printf
sync.c:883: WARNING: Prefer seq_puts to seq_printf
sync.c:898: WARNING: Prefer seq_puts to seq_printf
sync.c:902: WARNING: Prefer seq_puts to seq_printf
sync.c:943: WARNING: Prefer seq_puts to seq_printf
sync.c:952: WARNING: Prefer seq_puts to seq_printf
sync.c:956: WARNING: Prefer seq_puts to seq_printf
sync.c:964: WARNING: Prefer seq_puts to seq_printf
total: 9 warnings,
Signed-off-by: Aldo Iljazi
---
drivers/staging/android/sync.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index 3893a35..8bd5bf3 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
@@ -125,9 +125,8 @@ static void sync_timeline_remove_pt(struct sync_pt *pt)
spin_unlock_irqrestore(&obj->active_list_lock, flags);
spin_lock_irqsave(&obj->child_list_lock, flags);
- if (!list_empty(&pt->child_list)) {
+ if (!list_empty(&pt->child_list))
list_del_init(&pt->child_list);
- }
spin_unlock_irqrestore(&obj->child_list_lock, flags);
}
@@ -876,11 +875,11 @@ static void sync_print_pt(struct seq_file *s, struct
sync_pt *pt, bool fence)
seq_printf(s, " / %s", value);
}
} else if (pt->parent->ops->print_pt) {
- seq_printf(s, ": ");
+ seq_puts(s, ": ");
pt->parent->ops->print_pt(s, pt);
}
- seq_printf(s, "\n");
+ seq_puts(s, "\n");
}
static void sync_print_obj(struct seq_file *s, struct sync_timeline *obj)
@@ -893,13 +892,13 @@ static void sync_print_obj(struct seq_file *s, struct
sync_timeline *obj)
if (obj->ops->timeline_value_str) {
char value[64];
obj->ops->timeline_value_str(obj, value, sizeof(value));
- seq_printf(s, ": %s", value);
+ seq_puts(s, ": %s", value);
} else if (obj->ops->print_obj) {
- seq_printf(s, ": ");
+ seq_puts(s, ": ");
obj->ops->print_obj(s, obj);
}
- seq_printf(s, "\n");
+ seq_puts(s, "\n");
spin_lock_irqsave(&obj->child_list_lock, flags);
list_for_each(pos, &obj->child_list_head) {
@@ -940,7 +939,7 @@ static int sync_debugfs_show(struct seq_file *s, void
*unused)
unsigned long flags;
struct list_head *pos;
- seq_printf(s, "objs:\n--\n");
+ seq_puts(s, "objs:\n--\n");
spin_lock_irqsave(&sync_timeline_list_lock, flags);
list_for_each(pos, &sync_timeline_list_head) {
@@ -949,11 +948,11 @@ static int sync_debugfs_show(struct seq_file *s, void
*unused)
sync_timeline_list);
sync_print_obj(s, obj);
- seq_printf(s, "\n");
+ seq_puts(s, "\n");
}
spin_unlock_irqrestore(&sync_timeline_list_lock, flags);
- seq_printf(s, "fences:\n--\n");
+ seq_puts(s, "fences:\n--\n");
spin_lock_irqsave(&sync_fence_list_lock, flags);
list_for_each(pos, &sync_fence_list_head) {
@@ -961,7 +960,7 @@ static int sync_debugfs_show(struct seq_file *s, void
*unused)
container_of(pos, struct sync_fence, sync_fence_list);
sync_print_fence(s, fence);
- seq_printf(s, "\n");
+ seq_puts(s, "\n");
}
spin_unlock_irqrestore(&sync_fence_list_lock, flags);
return 0;
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Staging: anrdroid: sync.c: fixed all checkpatch errors and warnings
Signed-off-by: Aldo Iljazi
---
drivers/staging/android/sync.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index 3893a35..8bd5bf3 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
@@ -125,9 +125,8 @@ static void sync_timeline_remove_pt(struct sync_pt *pt)
spin_unlock_irqrestore(&obj->active_list_lock, flags);
spin_lock_irqsave(&obj->child_list_lock, flags);
- if (!list_empty(&pt->child_list)) {
+ if (!list_empty(&pt->child_list))
list_del_init(&pt->child_list);
- }
spin_unlock_irqrestore(&obj->child_list_lock, flags);
}
@@ -876,11 +875,11 @@ static void sync_print_pt(struct seq_file *s, struct
sync_pt *pt, bool fence)
seq_printf(s, " / %s", value);
}
} else if (pt->parent->ops->print_pt) {
- seq_printf(s, ": ");
+ seq_puts(s, ": ");
pt->parent->ops->print_pt(s, pt);
}
- seq_printf(s, "\n");
+ seq_puts(s, "\n");
}
static void sync_print_obj(struct seq_file *s, struct sync_timeline *obj)
@@ -893,13 +892,13 @@ static void sync_print_obj(struct seq_file *s, struct
sync_timeline *obj)
if (obj->ops->timeline_value_str) {
char value[64];
obj->ops->timeline_value_str(obj, value, sizeof(value));
- seq_printf(s, ": %s", value);
+ seq_puts(s, ": %s", value);
} else if (obj->ops->print_obj) {
- seq_printf(s, ": ");
+ seq_puts(s, ": ");
obj->ops->print_obj(s, obj);
}
- seq_printf(s, "\n");
+ seq_puts(s, "\n");
spin_lock_irqsave(&obj->child_list_lock, flags);
list_for_each(pos, &obj->child_list_head) {
@@ -940,7 +939,7 @@ static int sync_debugfs_show(struct seq_file *s, void
*unused)
unsigned long flags;
struct list_head *pos;
- seq_printf(s, "objs:\n--\n");
+ seq_puts(s, "objs:\n--\n");
spin_lock_irqsave(&sync_timeline_list_lock, flags);
list_for_each(pos, &sync_timeline_list_head) {
@@ -949,11 +948,11 @@ static int sync_debugfs_show(struct seq_file *s, void
*unused)
sync_timeline_list);
sync_print_obj(s, obj);
- seq_printf(s, "\n");
+ seq_puts(s, "\n");
}
spin_unlock_irqrestore(&sync_timeline_list_lock, flags);
- seq_printf(s, "fences:\n--\n");
+ seq_puts(s, "fences:\n--\n");
spin_lock_irqsave(&sync_fence_list_lock, flags);
list_for_each(pos, &sync_fence_list_head) {
@@ -961,7 +960,7 @@ static int sync_debugfs_show(struct seq_file *s, void
*unused)
container_of(pos, struct sync_fence, sync_fence_list);
sync_print_fence(s, fence);
- seq_printf(s, "\n");
+ seq_puts(s, "\n");
}
spin_unlock_irqrestore(&sync_fence_list_lock, flags);
return 0;
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
