Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support
On Wed, 3 Dec 2014 11:28:55 +0530 Sanchayan Maity wrote: > The clock is not strictly enforced, as this would > break the i.MX devices. The clocking for the i.MX > devices seems to be enabled elsewhere and enabling > RTC SNVS for Vybrid results in a crash. This patch > adds the clock support but also makes it optional > so Vybrid platform can use the clock if defined > while making sure not to break i.MX . > > Signed-off-by: Sanchayan Maity Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support
On Thu, 04 Dec 2014 13:29:58 +0100 Stefan Agner wrote: > > Acked-by: Alessandro Zummo > > Through which tree is this going upstream? Andrew usually picks up those small patches, unless there's a more appropriate tree. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64()
On Thu, 29 Jan 2015 00:12:09 +0800 Xunlei Pang wrote: > ping Alessandro -EBUSY . saw that, looks fine anyhow, but would like to have a deeper look. we have still some time 'till 2038, right? ;) -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: rtc/hctosys.c Problem during kernel boot
I'm testing them and they're working fine so far. Will handle them the next week. -- Best regards, Alessandro Zummo Tower Technologies Sent from my iPhone, please excuse my brevity. > On 21/giu/2014, at 15:08, Alexander Holler wrote: > > Am 12.06.2014 01:53, schrieb John Stultz: > >> You can read some of the previous discussion here: >> https://lkml.org/lkml/2013/6/17/533 >> >> I'd be very interested in patches to resolve this! > > And the silence as response to my repost of my already working patches just > proved that isn't true. > > So (John Whitmore), I suggest to not post patches, Linux kernel maintainers > don't really have an interest in getting things done or to fix bugs, they > just need fresh meat they can review in order to have job security and prove > their status. > > I really wonder what's their expectation. Do they really think other people > have to incorporate their (often silly) requests, making the maintainers > themself not responsible for their requested changes? Do they think other > people have fun and time to write and post patches again and again just to > make some arbitrary maintainer happy? > > If there really would be an interest, a reasonable approach would be to just > take my patches and put a patch on top with whatever changes someone thinks > are needed. As I don't think there are changes needed, I will not add such > changes using my name as author. > > And don't try to tell me I'm uncooperative. I've spend time to write these > patches and even have written documentation I don't need myself. The > uncooperative people which are blocking almost everthing and which do ignore > bugs have become these people which are calling themself Linux kernel > maintainers which do expect other people have to play remote keyboard and > have to take responsibility for changes maintainers don't want to be > responsible for themself. > > So the above quoted sentence is just another "marketing" verbiage, at least > in my point of view. > > Alexander Holler > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [rtc-linux] [PATCH] drivers/rtc/interface.c: check the error after __rtc_read_time()
On Fri, 4 Jul 2014 10:22:26 +0900 Hyogi Gim wrote: > In __rtc_set_alarm(), the error after __rtc_read_time() is not checked. > If rtc device fail to read time, we cannot guarantee the following process. > > Add the verification code for returned __rtc_read_time() error. > > Signed-off-by: Hyogi Gim Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64()
On Wed, 18 Mar 2015 10:37:26 -0700 John Stultz wrote: > Hey Alessandro, > I was hoping to let these go through you (with your review), but if > you're still too busy I can queue them if you'd rather. Hello, will review today and let you know. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64()
On Wed, 18 Mar 2015 10:37:26 -0700 John Stultz wrote: > On Wed, Jan 28, 2015 at 10:27 AM, Alessandro Zummo > wrote: > > On Thu, 29 Jan 2015 00:12:09 +0800 > > Xunlei Pang wrote: > > > >> ping Alessandro > > > > -EBUSY . saw that, looks fine anyhow, but would like to > > have a deeper look. we have still some time 'till 2038, right? ;) > > Hey Alessandro, > I was hoping to let these go through you (with your review), but if > you're still too busy I can queue them if you'd rather. Looks fine to me. The only thing that I would change is the naming of the drivername_rtc_set_mmss in the drivers: it should end with mmss64 when it's changed. But that's probably just me being pedantic. Acked-by: Alessandro Zummo Can you please queue them? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] MAINTAINERS: Add Alexandre Belloni as an RTC maintainer
On Wed, 25 Mar 2015 22:57:31 +0100 Alexandre Belloni wrote: > I'd like to propose myself as the RTC susbsystem co-maintainer, to mainly help > Alessandro reviewing incoming patches and maintain a subsystem tree to avoid > having the RTC patches going through trees when they have no particular > dependencies. Thanks :) A few things I consider important: - a driver for a new hardware usually causes no harm to the subsystem - a patch for an existing driver should be approved by the original author, if possible. there are a few chips out there that are quite rare or have multiple wiring configuration and break very easily. -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [rtc-linux] Re: [PATCH] MAINTAINERS: Add Alexandre Belloni as an RTC maintainer
On Sat, 28 Mar 2015 22:29:20 +0100 Alexandre Belloni wrote: > I'll keep that in mind. > Could you give me permissions on the rtc-linux patchwork? Sure. Let me find the way to do it :) -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log
On Tue, 31 Mar 2015 20:18:28 -0700 Joe Perches wrote: > Neither __func__ or __FILE__ is really useful here. > The message is already specific enough without it. > > If anything, it'd probably be better to add > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Seems reasonable given that pr_fmt is widely used elsewhere. I don't like too much the need to have one define for each file, but it's the way it works :-/ -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 4/4] rtc/imxdi: Update driver to address time issues
On Sat, 29 Nov 2014 00:20:00 +0800 "pang.xunlei" wrote: > Anyway, they are ungraceful being there. I'll refine this patchset carefully > according to your valuable suggestions, and will send out another version. > > Thanks for your review! I have quite the feeling those patches will cause headaches to a lot of people. Too many of this stuff seems a copy & paste work, without actually looking/thinking to the side effects. Is there any particular reason your are pursuing this? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [5/5] drivers/rtc/sa1100: Replace deprecated rtc_tm_to_time() and rtc_time_to_tm()
On Mon, 1 Jun 2015 21:59:09 +0200 Alexandre Belloni wrote: > I feel that we still have a bit of time before having to hurry and find > a proper solution ;) agreed :) -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH v3] rtc: ds1307: add trickle charger device tree binding
On Mon, 8 Sep 2014 07:26:57 -0400 Jason Cooper wrote: > Most likely, the rtc maintainer will take the series with the DT > maintainers Acks. You made all the binding changes as discussed by Mark > and I, so fwiw, > > Acked-by: Jason Cooper Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] char: make misc_deregister a void function
On Thu, 30 Jul 2015 15:59:57 -0700 Greg Kroah-Hartman wrote: > If the different subsystem maintainers want to give me an ack for this, > I'd appreciate it. I'd like to just take the single patch in through > the char-misc tree in one piece. RTC Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c
On Mon, 4 Jan 2016 10:45:46 +0100 Alexandre Belloni wrote: > I'm not sure it is useful to do that renaming. It is usual to have one > driver that supports multiple chips named with the forst chip it > supported. > > Also, what would happen if for example rk855 is not compatible at all > with the previous implementations? Alexandre is absolutely right. There's no need to rename a driver, it would just piss off people who are used to that name and have it in their scripts. Like when your eth0 gets renamed to some obscure enXXX . -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
