Re: [BUG] rfcomm
On Saturday 16 February 2008, Dave Young wrote: > Hi, alon > > Please try the attached patch, hope it fixes your problem. > > Regards > dave Does not work... :( Alon. Feb 16 23:41:33 alon1 usb 3-1: configuration #1 chosen from 1 choice Feb 16 23:41:33 alon1 BUG: unable to handle kernel NULL pointer dereference at virtual address 0008 Feb 16 23:41:33 alon1 printing eip: c01b2db6 *pde = Feb 16 23:41:33 alon1 Oops: [#1] PREEMPT Feb 16 23:41:33 alon1 Modules linked in: ppp_deflate zlib_deflate zlib_inflate bsd_comp ppp_async rfcomm l2cap hci_usb vmnet(P) vmmon(P) tun radeon drm autofs4 ipv6 aes_generic crypto_algapi ieee80211_crypt_ccmp nf_nat_irc nf_nat_ftp nf_conntrack_irc nf_conntrack_ftp ipt_MASQUERADE iptable_nat nf_nat ipt_REJECT xt_tcpudp ipt_LOG xt_limit xt_state nf_conntrack_ipv4 nf_conntrack iptable_filter ip_tables x_tables snd_pcm_oss snd_mixer_oss snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device bluetooth ppp_generic slhc ioatdma dca cfq_iosched cpufreq_powersave cpufreq_ondemand cpufreq_conservative acpi_cpufreq freq_table uinput fan af_packet nls_cp1255 nls_iso8859_1 nls_utf8 nls_base pcmcia snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm nsc_ircc snd_timer ipw2200 thinkpad_acpi irda snd ehci_hcd yenta_socket uhci_hcd psmouse ieee80211 soundcore intel_agp hwmon rsrc_nonstatic pcspkr e1000 crc_ccitt snd_page_alloc i2c_i801 ieee80211_crypt pcmcia_core agpgart thermal battery nvram rtc sr_mod ac sg firmware_class button processor cdrom unix usbcore evdev ext3 jbd ext2 mbcache loop ata_piix libata sd_mod scsi_mod Feb 16 23:41:33 alon1 Feb 16 23:41:33 alon1 Pid: 4, comm: events/0 Tainted: P (2.6.24-gentoo-r2 #1) Feb 16 23:41:33 alon1 EIP: 0060:[] EFLAGS: 00010282 CPU: 0 Feb 16 23:41:33 alon1 EIP is at sysfs_get_dentry+0x26/0x80 Feb 16 23:41:33 alon1 EAX: EBX: ECX: EDX: f48a2210 Feb 16 23:41:33 alon1 ESI: f72eb900 EDI: f4803ae0 EBP: f4803ae0 ESP: f7c49efc Feb 16 23:41:33 alon1 hcid[7004]: HCI dev 0 registered Feb 16 23:41:33 alon1 DS: 007b ES: 007b FS: GS: SS: 0068 Feb 16 23:41:33 alon1 Process events/0 (pid: 4, ti=f7c48000 task=f7c3efc0 task.ti=f7c48000) Feb 16 23:41:33 alon1 Stack: f7cb6140 f4822668 f7e71e10 c01b304d fffe c030ba9c Feb 16 23:41:33 alon1 f7cb6140 f4822668 f6da6720 f7cb6140 f4822668 f6da6720 c030ba8e c01ce20b Feb 16 23:41:33 alon1 f6e9dd00 c030ba8e f6da6720 f6e9dd00 f6e9dd00 f4822600 Feb 16 23:41:33 alon1 Call Trace: Feb 16 23:41:33 alon1 [] sysfs_move_dir+0x3d/0x1f0 Feb 16 23:41:33 alon1 [] kobject_move+0x9b/0x120 Feb 16 23:41:33 alon1 [] device_move+0x51/0x110 Feb 16 23:41:33 alon1 [] del_conn+0x0/0x70 [bluetooth] Feb 16 23:41:33 alon1 [] del_conn+0x19/0x70 [bluetooth] Feb 16 23:41:33 alon1 [] run_workqueue+0x81/0x140 Feb 16 23:41:33 alon1 [] schedule+0x168/0x2e0 Feb 16 23:41:33 alon1 [] autoremove_wake_function+0x0/0x50 Feb 16 23:41:33 alon1 [] worker_thread+0x9b/0xf0 Feb 16 23:41:33 alon1 [] autoremove_wake_function+0x0/0x50 Feb 16 23:41:33 alon1 [] worker_thread+0x0/0xf0 Feb 16 23:41:33 alon1 [] kthread+0x42/0x70 Feb 16 23:41:33 alon1 [] kthread+0x0/0x70 Feb 16 23:41:33 alon1 [] kernel_thread_helper+0x7/0x18 Feb 16 23:41:33 alon1 === Feb 16 23:41:33 alon1 Code: 26 00 00 00 00 57 89 c7 a1 50 1b 3a c0 56 53 8b 70 38 85 f6 74 08 8b 0e 85 c9 74 58 ff 06 8b 56 50 39 fa 74 47 89 fb eb 02 89 c3 <8b> 43 08 39 c2 75 f7 8b 46 08 83 c0 68 e8 98 e7 10 00 8b 43 10 Feb 16 23:41:33 alon1 EIP: [] sysfs_get_dentry+0x26/0x80 SS:ESP 0068:f7c49efc Feb 16 23:41:33 alon1 ---[ end trace aae864e9592acc1d ]--- Feb 16 23:41:33 alon1 hcid[7004]: HCI dev 0 up Feb 16 23:41:33 alon1 hcid[7004]: Device hci0 has been added Feb 16 23:41:33 alon1 hcid[7004]: Starting security manager 0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[BUG] rfcomm
On Tuesday 06 November 2007, Alon Bar-Lev wrote: > On 11/6/07, Dave Young <[EMAIL PROTECTED]> wrote: > > Hi, > > sorry for reply again, this seems a diffrent issue ... > > All that I do is running pppd over the rfcomm, suspending the system and > resume. > I don't load any binary module. > > Alon. > Tried 2.6.24.1... PLEASE fix this. Thanks! --- Feb 11 17:46:05 alon1 Restarting tasks ... <6>usb 2-1: USB disconnect, address 10 Feb 11 17:46:05 alon1 done. Feb 11 17:46:05 alon1 usb 3-1: USB disconnect, address 7 Feb 11 17:46:05 alon1 usb 3-2: USB disconnect, address 6 Feb 11 17:46:05 alon1 usb 3-1: new full speed USB device using uhci_hcd and address 8 Feb 11 17:46:05 alon1 usb 3-1: configuration #1 chosen from 1 choice Feb 11 17:46:05 alon1 BUG: unable to handle kernel NULL pointer dereference at virtual address 0008 Feb 11 17:46:05 alon1 printing eip: c01b2da6 *pde = Feb 11 17:46:05 alon1 Oops: [#1] PREEMPT Feb 11 17:46:05 alon1 Modules linked in: aes_generic crypto_algapi ieee80211_crypt_ccmp ppp_deflate zlib_deflate zlib_inflate bsd_comp ppp_async thinkpad_acpi hwmon nvram vmnet(P) vmmon(P) tun radeon drm autofs4 ipv6 nf_nat_irc nf_nat_ftp nf_conntrack_irc nf_conntrack_ftp ipt_MASQUERADE iptable_nat nf_nat ipt_REJECT xt_tcpudp ipt_LOG xt_limit xt_state nf_conntrack_ipv4 nf_conntrack iptable_filter ip_tables x_tables rfcomm l2cap snd_pcm_oss snd_mixer_oss snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device ppp_generic slhc ioatdma dca cfq_iosched cpufreq_powersave cpufreq_ondemand cpufreq_conservative acpi_cpufreq freq_table uinput fan af_packet nls_cp1255 nls_iso8859_1 nls_utf8 nls_base hci_usb bluetooth pcmcia snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm ipw2200 nsc_ircc snd_timer irda ieee80211 snd psmouse yenta_socket ehci_hcd pcspkr ieee80211_crypt e1000 rsrc_nonstatic uhci_hcd soundcore i2c_i801 intel_agp crc_ccitt thermal sr_mod pcmcia_core snd_page_alloc battery rtc firmware_class agpgart ac processor cdrom sg button unix usbcore evdev ext3 jbd ext2 mbcache loop ata_piix libata sd_mod scsi_mod Feb 11 17:46:05 alon1 Feb 11 17:46:05 alon1 Pid: 4, comm: events/0 Tainted: P (2.6.24-gentoo-r1 #1) Feb 11 17:46:05 alon1 EIP: 0060:[] EFLAGS: 00010286 CPU: 0 Feb 11 17:46:05 alon1 EIP is at sysfs_get_dentry+0x26/0x80 Feb 11 17:46:05 alon1 EAX: EBX: ECX: EDX: ebf21000 Feb 11 17:46:05 alon1 ESI: eab4e880 EDI: f713bb40 EBP: f713bb40 ESP: f7c49f00 Feb 11 17:46:05 alon1 DS: 007b ES: 007b FS: GS: SS: 0068 Feb 11 17:46:05 alon1 Process events/0 (pid: 4, ti=f7c48000 task=f7c3efc0 task.ti=f7c48000) Feb 11 17:46:05 alon1 Stack: f7c97120 f7135a68 f7e71e10 c01b303d fffe c030ba9c Feb 11 17:46:05 alon1 f7c97120 f7135a68 f2fefb40 f7c97120 f7135a68 f2fefb40 c030ba8e c01ce1fb Feb 11 17:46:05 alon1 f75f1b00 c030ba8e f2fefb40 f75f1b00 f75f1b00 f7135a00 Feb 11 17:46:05 alon1 Call Trace: Feb 11 17:46:05 alon1 [] sysfs_move_dir+0x3d/0x1f0 Feb 11 17:46:05 alon1 [] kobject_move+0x9b/0x120 Feb 11 17:46:05 alon1 [] device_move+0x51/0x110 Feb 11 17:46:05 alon1 [] del_conn+0x0/0x40 [bluetooth] Feb 11 17:46:05 alon1 [] del_conn+0x10/0x40 [bluetooth] Feb 11 17:46:05 alon1 [] run_workqueue+0x81/0x140 Feb 11 17:46:05 alon1 [] schedule+0x168/0x2e0 Feb 11 17:46:05 alon1 [] autoremove_wake_function+0x0/0x50 Feb 11 17:46:05 alon1 [] worker_thread+0x9b/0xf0 Feb 11 17:46:05 alon1 [] autoremove_wake_function+0x0/0x50 Feb 11 17:46:05 alon1 [] worker_thread+0x0/0xf0 Feb 11 17:46:05 alon1 [] kthread+0x42/0x70 Feb 11 17:46:05 alon1 [] kthread+0x0/0x70 Feb 11 17:46:05 alon1 [] kernel_thread_helper+0x7/0x18 Feb 11 17:46:05 alon1 === Feb 11 17:46:05 alon1 Code: 26 00 00 00 00 57 89 c7 a1 50 1b 3a c0 56 53 8b 70 38 85 f6 74 08 8b 0e 85 c9 74 58 ff 06 8b 56 50 39 fa 74 47 89 fb eb 02 89 c3 <8b> 43 08 39 c2 75 f7 8b 46 08 83 c0 68 e8 98 e7 10 00 8b 43 10 Feb 11 17:46:05 alon1 EIP: [] sysfs_get_dentry+0x26/0x80 SS:ESP 0068:f7c49f00 Feb 11 17:46:05 alon1 ---[ end trace a8cb8bc51a9b0e12 ]--- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)
On 12/25/07, Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > > So suspend modes on these boards are not supported? > > Only "Always On" configuration is supported? > > Sleep mode is supported according to the code. But as I've said PM bits > haven't been maintained -- probably since the submission. Thanks! Will it be maintained? Are there any plans? Is there, a missing features list (TODO)? Or this is completely unsupported board? Best Regards, Alon Bar-Lev. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)
Thank you for your reply! On 12/25/07, Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > PM code is generally broken and unmaintained, so no wonder. I don't > remember if anyone has fixed CPU context restoration code (it uses a "skewed" > stack frame). So suspend modes on these boards are not supported? Only "Always On" configuration is supported? Or there is another method to preserve power? Best Regards, Alon Bar-Lev. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)
Hello, Forgot to write that I checked mips & linus gits, and the problem still exists. Best Regards, Alon Bar-Lev. On 12/23/07, Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > Hello, > > When I have: > CONFIG_MIPS_DB1550 > CONFIG_SOC_AU1550 > CONFIG_SOC_AU1X00 > CONFIG_PM > > MEM_SDREFCFG is used at: > arch/mips/au1000/common/power.c::pm_do_freq() > > While the MEM_SDREFCFG constant is declare only for CONFIG_SOC_AU1000, > CONFIG_SOC_AU1500, CONFIG_SOC_AU1100 at: > include/asm-mips/mach-au1x00/au1000.h > > Maybe MEM_SDREFCFG should be defined for CONFIG_SOC_AU1X00? > Or there should be #ifdef for its usage in power.c? > > Best Regards, > Alon Bar-Lev. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[MIPS] MEM_SDREFCFG is not defined for Alchemy DB1550 (compile fail)
Hello, When I have: CONFIG_MIPS_DB1550 CONFIG_SOC_AU1550 CONFIG_SOC_AU1X00 CONFIG_PM MEM_SDREFCFG is used at: arch/mips/au1000/common/power.c::pm_do_freq() While the MEM_SDREFCFG constant is declare only for CONFIG_SOC_AU1000, CONFIG_SOC_AU1500, CONFIG_SOC_AU1100 at: include/asm-mips/mach-au1x00/au1000.h Maybe MEM_SDREFCFG should be defined for CONFIG_SOC_AU1X00? Or there should be #ifdef for its usage in power.c? Best Regards, Alon Bar-Lev. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [MIPS] Build an embedded initramfs into mips kernel
Thank you for your help. Indeed the dynamic loader of uclibc is the cause. I upgraded to latest uclibc-0.9.29, and finally the files was linked against uclibc's ld. But it did not work... Tried to run a dynamic linked executable via static shell, and got floating point exception. Tried to compile toolchain and uclibc with softfloat, but still did not work. So I moved to glibc and all works correctly. Thank you for quick response! I will continue the discussion at uclibc lists. Best Regards, Alon Bar-Lev. On 12/19/07, Willy Tarreau <[EMAIL PROTECTED]> wrote: > On Wed, Dec 19, 2007 at 12:09:46AM +0200, Alon Bar-Lev wrote: > > On 12/18/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > > > Make sure your /init doesn't depend on an interpreter or library which > > > isn't available. > > > > Thank you for your answer. > > > > I already checked. > > > > /init is hardlink to busybox, it depends on libc.so.0 which is available at > > /lib > > Are you sure that libc.so.0 is enough and that you don't need any ld.so ? > > > But shouldn't I get a different error code if this is the case? > > If it does not find part of the dynamic linker or libraries, this error > makes sense to me. > > You should try to build a static init with any stupid thing such as a > hello world to ensure that the problem really comes from the init and > nothing else. > > Regards, > Willy > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [MIPS] Build an embedded initramfs into mips kernel
On 12/18/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Make sure your /init doesn't depend on an interpreter or library which > isn't available. Thank you for your answer. I already checked. /init is hardlink to busybox, it depends on libc.so.0 which is available at /lib But shouldn't I get a different error code if this is the case? Best Regards, Alon Bar-Lev. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[MIPS] Build an embedded initramfs into mips kernel
Hello, I am trying to build a basic initramfs image into the kernel, using the CONFIG_INITRAMFS_SOURCE. The required result is a single image loaded into a target containing usermode application (busybox). I use cross compile mipsel-unknown-linux-uclibc in order to build the kernel and the initramfs's usermode. The cpio image is created using cpio -o -H newc command. The same configuration works with i586-pc-linux-uclibc cross compile. printk at init/main.c::run_init_process() shows that the kernel_execve() returns -2 (ENOENT) for /init and -14 (EFAULT) for /*/init. Looking at the initramfs /init is available and executable. Any reason why I get ENOENT? Any special procedure should be performed for mips arch? Best Regards, Alon Bar-Lev. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ldminfo compilation
On Wednesday 12 December 2007, Luciano Rocha wrote:
> Anyway, how to compile with the sources of:
Thank you so much
I didn't think of using 2.4 headers... bad me!
Anyway, I can now hack this to compile with uclibc...
I don't know if it works yet, but at least it builds now (26KB)
I had to use newer kernel, as I had some gcc related errors in
include/asm/processor.h
and CONFIG_SMP related conflicts.
I truly hope maintainer will find some time to make it regular 2.6.X user mode
application... There are many packages that use kernel headers, but are much
easier to build, without sharing one object between kernel and userspace.
Best Regards,
Alon Bar-Lev
So just for the record...
I am using the following script to build:
ldm=linux-ldm-0.0.8
kernel=linux-2.4.35.4
wget --continue http://downloads.sourceforge.net/linux-ntfs/$ldm.tar.bz2
wget --continue http://www.kernel.org/pub/linux/kernel/v2.4/$kernel.tar.bz2
tar xjf $ldm.tar.bz2
cd $ldm
patch -p1 < ../$ldm-build.diff
tar xjf ../$kernel.tar.bz2
yes n | make -C $kernel ARCH=i386 oldconfig dep
make clean
make KERNEL=$(pwd)/$kernel LDMINFO_LDFLAGS=-static
#make KERNEL=$(pwd)/$kernel LDMINFO_CC=i586-pc-linux-uclibc-gcc
And the following patch:
---
diff -urNp linux-ldm-0.0.8.org/Makefile linux-ldm-0.0.8/Makefile
--- linux-ldm-0.0.8.org/Makefile2002-03-09 03:58:42.0 +0200
+++ linux-ldm-0.0.8/Makefile2007-12-13 00:38:09.0 +0200
@@ -27,7 +27,14 @@ CFLAGS += -fomit-frame-pointer
CFLAGS += -fno-strict-aliasing
CFLAGS += -pipe
CFLAGS += -mpreferred-stack-boundary=2
-CFLAGS += -march=$(shell uname -m)
+
+# libc fixups
+
+CFLAGS += -D__off_t_defined
+CFLAGS += -D__sigset_t_defined
+CFLAGS += -D_TIME_H
+CFLAGS += -D__defined_schedparam
+CFLAGS += -D__sched_param=sched_param
# ld flags
diff -urNp linux-ldm-0.0.8.org/test/compat.c linux-ldm-0.0.8/test/compat.c
--- linux-ldm-0.0.8.org/test/compat.c 2002-08-05 18:46:51.0 +0300
+++ linux-ldm-0.0.8/test/compat.c 2007-12-13 00:38:09.0 +0200
@@ -171,7 +171,7 @@ unsigned char *read_dev_sector (struct b
return bh->b_data;
}
-void __free_pages(struct page *page, unsigned int order)
+FASTCALL() void __free_pages(struct page *page, unsigned int order)
{
atomic_dec (&page->count);
if (atomic_read (&page->count) < 1) {
diff -urNp linux-ldm-0.0.8.org/test/Makefile linux-ldm-0.0.8/test/Makefile
--- linux-ldm-0.0.8.org/test/Makefile 2002-02-23 18:38:51.0 +0200
+++ linux-ldm-0.0.8/test/Makefile 2007-12-13 00:39:58.0 +0200
@@ -8,6 +8,8 @@ INFODEP = $(LDMDEP) compat.o copy.o dump
OUT= ldminfo sparse
+LDMINFO_CC = $(CC)
+
CFLAGS += -include extra.h
CFLAGS += -I$(KERNEL)/include
CFLAGS += -I$(KERNEL)/fs/partitions
@@ -15,13 +17,13 @@ CFLAGS += -I$(KERNEL)/fs/partitions
all: $(OUT)
.c.o:
- $(CC) $(CFLAGS) -c $< -o $@
+ $(LDMINFO_CC) $(CFLAGS) -c $< -o $@
ldminfo: $(INFODEP)
- $(CC) -o ldminfo $(INFODEP)
+ $(LDMINFO_CC) $(LDMINFO_LDFLAGS) -o ldminfo $(INFODEP)
sparse:
- $(CC) -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 sparse.c -o $@
+ $(LDMINFO_CC) -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 sparse.c -o $@
clean:
$(RM) $(OUT) $(OBJ)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: ldminfo compilation
On 12/12/07, Luciano Rocha <[EMAIL PROTECTED]> wrote: > Those are for the kernel module setting the partition tables. If you're > only interested in the ldminfo utility: > make -C ldmutil CPP='g++ -static' > > Substitute g++ for the C++ compiler you want to use. Hi! Thank you for your reply! I don't really understand how to use the output of ldmutil in order to do the dmsetup... All the instructions are for ldminfo... And the C++ dependency does not work well with uclibc... I tried to compile this using uclibc++, but the exception handling of uclibc++ is broken for some strange reason... And I don't wish to introduce the overhead of the C++ libraries to my system... If ldmutil contain all the information, I will backport this to C and be happy... :) Can you please tell me how you use the output of this utility to merge a spanned partition on two separate disks? Best Regards, Alon Bar-Lev. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
ldminfo compilation
Hello, I need to compile the ldminfo utility of linux-ntfs's package linux-ldm. I need this as static or uclibc based. The author stated in the Documentation/filesystems/ntfs.txt: """You will find the precompiled (i386) ldminfo utility there. NOTE: You will not be able to compile this yourself easily so use the binary version!""" I don't like to use binary versions, but this is not so important I cannot use this dynamic linked x86 anyway. Looking at the sources, it seems that the linux headers used in order to build this are out of date... Has anyone succeeded in compiling this? Are there alternatives? I need to extract the information from ldm partition in order to dmsetup it correctly. I've contacted the author, Richard Russon <[EMAIL PROTECTED]> but got no response. Best Regards, Alon Bar-Lev. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Bluez-devel] [BUG] rfcomm]
On 11/6/07, Dave Young <[EMAIL PROTECTED]> wrote: > Hi, > sorry for reply again, this seems a diffrent issue ... All that I do is running pppd over the rfcomm, suspending the system and resume. I don't load any binary module. Alon. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Bluez-devel] [BUG] rfcomm]
On 11/5/07, Dave Young <[EMAIL PROTECTED]> wrote: > Hi, > I managed to produce this bug last weekend. I debugged it and found a > rfcomm_dev refcnt BUG. > please try the patch of attachment, sorry for attachement because of > my gmail/mutt configuration problem. > > I post it in below thread: > http://lkml.org/lkml/2007/11/4/207 It actually worse... :( Best Regards, Alon Bar-Lev --- terrupt :02:01.0[A] -> Link [LNKA] -> GSI 11 (level, low) -> IRQ 11 ieee80211_crypt: registered algorithm 'NULL' ieee80211: 802.11 data/management/control stack, git-1.1.13 ieee80211: Copyright (C) 2004-2005 Intel Corporation <[EMAIL PROTECTED]> ipw2200: Intel(R) PRO/Wireless 2200/2915 Network Driver, 1.2.2kmprq ipw2200: Copyright(c) 2003-2006 Intel Corporation Synaptics Touchpad, model: 1, fw: 5.9, id: 0x2c6ab1, caps: 0x884793/0x0 serio: Synaptics pass-through port at isa0060/serio1/input0 input: SynPS/2 Synaptics TouchPad as /devices/platform/i8042/serio1/input/input2 pnp: Device 00:0c activated. nsc-ircc, chip->init nsc-ircc, Found chip at base=0x02e nsc-ircc, driver loaded (Dag Brattli) IrDA: Registered device irda0 nsc-ircc, Found dongle: HP HSDL-1100/HSDL-2100 e1000: :02:01.0: e1000_probe: (PCI:33MHz:32-bit) 00:11:25:2e:e5:1f e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection Yenta: CardBus bridge found at :02:00.1 [1014:0552] Yenta: Using INTVAL to route CSC interrupts to PCI Yenta: Routing CardBus interrupts to PCI Yenta TI: socket :02:00.1, mfunc 0x01d21b22, devctl 0x64 Yenta: ISA IRQ mask 0x04b0, PCI irq 11 Socket status: 3086 pcmcia: parent PCI bridge I/O window: 0x4000 - 0x8fff pcmcia: parent PCI bridge Memory window: 0xc020 - 0xcfff pcmcia: parent PCI bridge Memory window: 0xe800 - 0xefff ACPI: PCI Interrupt :00:1f.5[B] -> Link [LNKB] -> GSI 11 (level, low) -> IRQ 11 PCI: Setting latency timer of device :00:1f.5 to 64 udev: renamed network interface eth0 to eth1 usb 2-1: new full speed USB device using uhci_hcd and address 3 usb 2-1: configuration #1 chosen from 1 choice usb 3-1: new full speed USB device using uhci_hcd and address 2 usb 3-1: configuration #1 chosen from 1 choice Bluetooth: Core ver 2.11 NET: Registered protocol family 31 Bluetooth: HCI device and connection manager initialized Bluetooth: HCI socket layer initialized Bluetooth: HCI USB driver ver 2.9 intel8x0_measure_ac97_clock: measured 50304 usecs intel8x0: clocking to 48000 ACPI: PCI Interrupt :02:02.0[A] -> Link [LNKC] -> GSI 11 (level, low) -> IRQ 11 ipw2200: Detected Intel PRO/Wireless 2200BG Network Connection usb 3-2: new full speed USB device using uhci_hcd and address 3 usb 3-2: configuration #1 chosen from 1 choice usbcore: registered new interface driver hci_usb ipw2200: Detected geography ZZR (14 802.11bg channels, 0 802.11a channels) IBM TrackPoint firmware: 0x0e, buttons: 3/3 input: TPPS/2 IBM TrackPoint as /devices/platform/i8042/serio1/serio2/input/input3 EXT3 FS on loop5, internal journal NET: Registered protocol family 17 Non-volatile memory driver v1.2 thinkpad_acpi: ThinkPad ACPI Extras v0.16 thinkpad_acpi: http://ibm-acpi.sf.net/ thinkpad_acpi: ThinkPad BIOS 1RETDPWW (3.21 ), EC 1RHT71WW-3.04 thinkpad_acpi: IBM ThinkPad T42 input: ThinkPad Extra Buttons as /devices/virtual/input/input4 hdaps: IBM ThinkPad T42 detected. hdaps: initial latch check good (0x01). hdaps: device successfully initialized. input: hdaps as /devices/platform/hdaps/input/input5 hdaps: driver successfully loaded. ACPI: AC Adapter [AC] (on-line) ACPI: Battery Slot [BAT0] (battery present) input: Power Button (FF) as /devices/virtual/input/input6 ACPI: Power Button (FF) [PWRF] input: Lid Switch as /devices/virtual/input/input7 ACPI: Lid Switch [LID] input: Sleep Button (CM) as /devices/virtual/input/input8 ACPI: Sleep Button (CM) [SLPB] ACPI: CPU0 (power states: C1[C1] C2[C2] C3[C3]) ACPI: Processor [CPU] (supports 8 throttling states) ACPI: Thermal Zone [THM0] (57 C) Marking TSC unstable due to: possible TSC halt in C2. Time: acpi_pm clocksource has been installed. IBM machine detected. Enabling interrupts during APM calls. apm: BIOS version 1.2 Flags 0x03 (Driver version 1.16ac) dazuko: loaded, version=2.3.4 io scheduler cfq registered Module ioatdma cannot be unloaded due to unsafe usage in drivers/dma/ioatdma.c:805 PPP generic driver version 2.4.2 SCSI subsystem initialized Adding 1465120k swap on /dev/loop/4. Priority:-1 extents:1 across:1465120k hda: selected mode 0x45 hda: cache flushes supported hdc: selected mode 0x42 hdc: host side 80-wire cable detection failed, limiting max speed to UDMA33 hdc: UDMA speeds >UDMA33 cannot be set Bluetooth: L2CAP ver 2.8 Bluetooth: L2CAP socket layer initialized Bluetooth: RFCOMM socket layer initialized Bluetooth: RFCOMM TTY layer initialized Bluetooth: RFCOMM ver 1.8 ip_tables: (C) 2000-2006 Netfilter Core Team nf_conntrack version 0.5.0 (16384 buckets, 65536 max) e
Re: [BUG] rfcomm]
On 10/23/07, Marcel Holtmann <[EMAIL PROTECTED]> wrote: > the code in net/bluetooth/rfcomm/tty.c contains two calls to > device_move(). Please comment these out and try again. At least then we > know that it is in issue on how we use the driver model. No bugs... Looks OK, although I don't know what removed :) Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUG] rfcomm]
On 10/23/07, Marcel Holtmann <[EMAIL PROTECTED]> wrote: > still another one to go :( Anyway since you have experience and you have > a way to reproduce it, please test the latest kernel from Linus' Git > tree. I can reproduce this. But I cannot use git snapshot as I have too much dependencies. > I can also whip up a patch that disables the device_move() usage and see > if that is the reason for the falling over. This would be nice! I can test separate patches. Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUG] rfcomm]
On 10/23/07, Marcel Holtmann <[EMAIL PROTECTED]> wrote: > nice. I've never used it. Currently I am using what comes with Ubuntu > 7.10 and that seems to work. Have you tried to suspend while pppd is using rfcomm? The fact that it happens with suspend2 and uswsusp means that the issue is suspend blind. Do you need any more information in order to determine what is the problem? Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUG] rfcomm]
On 10/23/07, Marcel Holtmann <[EMAIL PROTECTED]> wrote: > first of all, please check if this still happens with 2.6.23, because we > had some patches in the area of the RFCOMM TTY code that might have > fixed this. These messages are of 2.6.23. > Second, can you try without uswsusp or suspend2. Both of > them are not upstream and I can't tell how much these would effect this > kind of behavior. How can I test this without doing suspend? uswsusp is not upstream?!?! Rafael? Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[BUG] rfcomm]
Hello, I have this issue for long time (At least from linux-2.6.18). I think it is about time I report this... :) When coming out of suspend (uswsusp or suspend2) if rfcomm was active it creates this dump. If you need any more info I will be glad to provide. Best Regards, Alon Bar-Lev. --- Oct 23 17:51:33 alon1 acpid: received event "button/power PWRF 0080 0001" Oct 23 17:51:33 alon1 acpid: notifying client 7903[0:0] Oct 23 17:51:33 alon1 acpid: notifying client 7804[0:0] Oct 23 17:51:33 alon1 acpid: executing action "/etc/acpi/default.sh button/power PWRF 0080 0001" Oct 23 17:52:13 alon1 ntpd[8186]: synchronized to 192.115.25.179, stratum 2 Oct 23 17:52:16 alon1 swsusp: Marking nosave pages: 0009f000 - 0010 Oct 23 17:52:16 alon1 swsusp: Basic memory bitmaps created Oct 23 19:41:22 alon1 pppd[25041]: Hangup (SIGHUP) Oct 23 19:41:22 alon1 pppd[25041]: Modem hangup Oct 23 19:41:22 alon1 pppd[25041]: Connect time 384.5 minutes. Oct 23 19:41:22 alon1 pppd[25041]: Sent 512470 bytes, received 1546102 bytes. Oct 23 19:41:22 alon1 pppd[25041]: Connection terminated. Oct 23 19:41:40 alon1 Stopping tasks ... done. Oct 23 19:41:40 alon1 Shrinking memory... - \ | / - \ | / - \ | / - \ | / - \ | / - \ | / - \ | / - \ | / - \ | / - \ | done (224831 pages freed) Oct 23 19:41:40 alon1 Freed 899324 kbytes in 14.70 seconds (61.17 MB/s) Oct 23 19:41:40 alon1 Suspending console(s) Oct 23 19:41:40 alon1 usbfs 2-2:1.0: no suspend for driver usbfs? Oct 23 19:41:40 alon1 pnp: Device 00:0c disabled. Oct 23 19:41:40 alon1 eth0: Going into suspend... Oct 23 19:41:40 alon1 ACPI: PCI interrupt for device :02:02.0 disabled Oct 23 19:41:40 alon1 ACPI handle has no context! Oct 23 19:41:40 alon1 ACPI: PCI interrupt for device :02:01.0 disabled Oct 23 19:41:40 alon1 ACPI handle has no context! Oct 23 19:41:40 alon1 radeonfb (:01:00.0): suspending for event: 1... Oct 23 19:41:40 alon1 ACPI: PCI interrupt for device :00:1f.5 disabled Oct 23 19:41:40 alon1 ACPI: PCI interrupt for device :00:1d.7 disabled Oct 23 19:41:40 alon1 ACPI: PCI interrupt for device :00:1d.2 disabled Oct 23 19:41:40 alon1 ACPI: PCI interrupt for device :00:1d.1 disabled Oct 23 19:41:40 alon1 ACPI: PCI interrupt for device :00:1d.0 disabled Oct 23 19:41:40 alon1 swsusp: critical section: Oct 23 19:41:40 alon1 swsusp: Need to copy 126188 pages Oct 23 19:41:40 alon1 Intel machine check architecture supported. Oct 23 19:41:40 alon1 Intel machine check reporting enabled on CPU#0. Oct 23 19:41:40 alon1 ACPI: PCI Interrupt :00:1d.0[A] -> Link [LNKA] -> GSI 11 (level, low) -> IRQ 11 Oct 23 19:41:40 alon1 PCI: Setting latency timer of device :00:1d.0 to 64 Oct 23 19:41:40 alon1 usb usb1: root hub lost power or was reset Oct 23 19:41:40 alon1 ACPI: PCI Interrupt :00:1d.1[B] -> Link [LNKD] -> GSI 11 (level, low) -> IRQ 11 Oct 23 19:41:40 alon1 PCI: Setting latency timer of device :00:1d.1 to 64 Oct 23 19:41:40 alon1 usb usb2: root hub lost power or was reset Oct 23 19:41:40 alon1 ACPI: PCI Interrupt :00:1d.2[C] -> Link [LNKC] -> GSI 11 (level, low) -> IRQ 11 Oct 23 19:41:40 alon1 PCI: Setting latency timer of device :00:1d.2 to 64 Oct 23 19:41:40 alon1 usb usb3: root hub lost power or was reset Oct 23 19:41:40 alon1 ACPI: PCI Interrupt :00:1d.7[D] -> Link [LNKH] -> GSI 11 (level, low) -> IRQ 11 Oct 23 19:41:40 alon1 PCI: Setting latency timer of device :00:1d.7 to 64 Oct 23 19:41:40 alon1 usb usb4: root hub lost power or was reset Oct 23 19:41:40 alon1 ehci_hcd :00:1d.7: debug port 1 Oct 23 19:41:40 alon1 PCI: cache line size of 32 is not supported by device :00:1d.7 Oct 23 19:41:40 alon1 PCI: Setting latency timer of device :00:1e.0 to 64 Oct 23 19:41:40 alon1 ACPI: PCI Interrupt :00:1f.1[A] -> Link [LNKC] -> GSI 11 (level, low) -> IRQ 11 Oct 23 19:41:42 alon1 PM: Writing back config space on device :00:1f.5 at offset 1 (was 297, writing 293) Oct 23 19:41:42 alon1 ACPI: PCI Interrupt :00:1f.5[B] -> Link [LNKB] -> GSI 11 (level, low) -> IRQ 11 Oct 23 19:41:42 alon1 PCI: Setting latency timer of device :00:1f.5 to 64 Oct 23 19:41:42 alon1 radeonfb (:01:00.0): resuming from state: 1... Oct 23 19:41:42 alon1 PM: Writing back config space on device :02:00.0 at offset f (was 3c0010b, writing 5c0010b) Oct 23 19:41:42 alon1 PM: Writing back config space on device :02:00.0 at offset 3 (was 824008, writing 82a810) Oct 23 19:41:42 alon1 PM: Writing back config space on device :02:00.0 at offset 1 (was 2100107, writing 217) Oct 23 19:41:42 alon1 PM: Writing back config space on device :02:00.1 at offset f (was 3c0020b, writing 5c0020b) Oct 23 19:41:42 alon1 PM: Writing back config space on device :02:00.1 at offset 3 (was 824008, writing 82a810) Oct 23 19:41:42 alon1 PM: Writing back config space on device :02:00.1 a
Re: [RFC][PATCH 1/2 -mm] kexec based hibernation -v3: kexec jump
On 9/21/07, Huang, Ying <[EMAIL PROTECTED]> wrote: > This is fairly simple in fact. For example, you can specify the > bdev/sectors in kernel command line when do kexec load "kexec -l <...> > --append='...'", then the image writing system can get it through > "cat /proc/cmdline". I hope you take into account encrypted swap configuration. Currently all three suspend implementations support using encrypted swap in order to suspend/resume. A configuration which forces the user to remap encryption on the kexec kernel during suspend is not valid. Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Suspend2 is getting a new name.
On 7/2/07, Fabio Comolli <[EMAIL PROTECTED]> wrote: Hi. On 7/2/07, Nigel Cunningham <[EMAIL PROTECTED]> wrote: > Hi all. > > Suspend2's name is changing to "TuxOnIce". > Am I the only person on this list thinking that a plain "hibernate" will be a much better choice? No you are not the only one :) Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)
On 4/25/07, Pavel Machek <[EMAIL PROTECTED]> wrote: Ok ok ok, suspend-to-disk has some other uses, too. But ... you are really using suspend-to-disk as a workaround for "my desktop takes too much power when idle". Imagine pressing "lock screensaver" combination, and your machine going to low power mode (3W?), immediately. (Quiet, too; you can't generate much noise for 3W). In the morning, you'd just press any key, machine would power up, immediately... ok, you'd have to ifconfig eth0 down, so that spurious packets on the local net would wake your machine, with all its fans etc. Pavel You are assuming that: 1. You have battery backup, or external power never fail. 2. You don't disconnect the filesystem from the device. 3. The security level of turned on device equals to a turned off one. 4. You turn on the same device that turned off. 5. You do not wish to boot another OS on this machine. None of the above are always true... but why assume? Just make this work... If Nigel wish to maintain this please let him, you can be in charge of the s2ram. Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [REPOST] x86_64, i386: Add command line length to boot protocol
Hello, I really don' t understand why you insist that the boot protocol =2.02 had 255 limit! Please remove this from the description. You want to add size, that's OK, but please don't mess with previous definitions. Boot protocol 2.02 introduced the null terminated string truncated by kernel, which can be at any size. Best Regards, Alon Bar-Lev. On 3/15/07, Bernhard Walle <[EMAIL PROTECTED]> wrote: Because the command line is increased to 2048 characters after 2.6.21, it's not possible for boot loaders and userspace tools to determine the length of the command line the kernel can understand. The benefit of knowing the length is that users can be warned if the command line size is too long which prevents surprise if things don't work after bootup. This patch updates the boot protocol to contain a field called "cmdline_size" that contain the length of the command line (excluding the terminating zero). The patch also adds missing fields (of protocol version 2.05) to the x86_64 setup code. Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]> Cc: Alon Bar-Lev <[EMAIL PROTECTED]> --- Documentation/i386/boot.txt | 23 +-- arch/i386/boot/setup.S |7 ++- arch/x86_64/boot/setup.S| 15 ++- 3 files changed, 37 insertions(+), 8 deletions(-) Index: longer-cmdline-boot-proto-mm/Documentation/i386/boot.txt === --- longer-cmdline-boot-proto-mm.orig/Documentation/i386/boot.txt +++ longer-cmdline-boot-proto-mm/Documentation/i386/boot.txt @@ -2,7 +2,7 @@ H. Peter Anvin <[EMAIL PROTECTED]> - Last update 2007-01-26 + Last update 2007-03-06 On the i386 platform, the Linux kernel uses a rather complicated boot convention. This has evolved partially due to historical aspects, as @@ -35,9 +35,13 @@ Protocol 2.03: (Kernel 2.4.18-pre1) Expl initrd address available to the bootloader. Protocol 2.04: (Kernel 2.6.14) Extend the syssize field to four bytes. + Protocol 2.05: (Kernel 2.6.20) Make protected mode kernel relocatable. Introduce relocatable_kernel and kernel_alignment fields. +Protocol 2.06: (Kernel 2.6.22) Added a field that contains the size of + the boot command line + MEMORY LAYOUT @@ -133,6 +137,8 @@ Offset Proto NameMeaning 022C/4 2.03+ initrd_addr_max Highest legal initrd address 0230/4 2.05+ kernel_alignment Physical addr alignment required for kernel 0234/1 2.05+ relocatable_kernel Whether kernel is relocatable or not +0235/3 N/A pad2Unused +0238/4 2.06+ cmdline_sizeMaximum size of the kernel command line (1) For backwards compatibility, if the setup_sects field contains 0, the real value is 4. @@ -233,6 +239,12 @@ filled out, however: if your ramdisk is exactly 131072 bytes long and this field is 0x37FF, you can start your ramdisk at 0x37FE.) + cmdline_size: + The maximum size of the command line without the terminating + zero. This means that the command line can contain at most + cmdline_size characters. With protocol version 2.05 and + earlier, the maximum size was 255. + THE KERNEL COMMAND LINE @@ -241,11 +253,10 @@ loader to communicate with the kernel. relevant to the boot loader itself, see "special command line options" below. -The kernel command line is a null-terminated string currently up to -255 characters long, plus the final null. A string that is too long -will be automatically truncated by the kernel, a boot loader may allow -a longer command line to be passed to permit future kernels to extend -this limit. +The kernel command line is a null-terminated string. The maximum +length can be retrieved from the field cmdline_size. Before protocol +version 2.06, the maximum was 255 characters. A string that is too +long will be automatically truncated by the kernel. If the boot protocol version is 2.02 or later, the address of the kernel command line is given by the header field cmd_line_ptr (see Index: longer-cmdline-boot-proto-mm/arch/i386/boot/setup.S === --- longer-cmdline-boot-proto-mm.orig/arch/i386/boot/setup.S +++ longer-cmdline-boot-proto-mm/arch/i386/boot/setup.S @@ -52,6 +52,7 @@ #include #include #include +#include /* Signature words to ensure LILO loaded us right */ #define SIG1 0xAA55 @@ -81,7 +82,7 @@ start: # This is the setup header, and it must start at %cs:2 (old 0x9020:2) .ascii "HdrS" # header signature - .word 0x0205 # header version number (>= 0x0105) + .word 0x0206 # header version number (>= 0x0105)
Re: [PATCH] x86_64, i386: Add command line length to boot protocol
On 3/6/07, Bernhard Walle <[EMAIL PROTECTED]> wrote: +The kernel command line is a null-terminated string. The maximum +length can be retrieved from the field cmdline_size. Before protocol +version 2.06, the maximum was 255 characters. A string that is too +long will be automatically truncated by the kernel. This is incorrect. Since 2.02, the maximum was null terminated string truncated by kernel. Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG
On 2/9/07, James Ketrenos <[EMAIL PROTECTED]> wrote: Ok. Now... any questions? No... Just that it is great news! Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/34] __initdata cleanup
On 2/9/07, Andrew Morton <[EMAIL PROTECTED]> wrote: If we really do have a problem here it'd be better to fix it in some central and global fashion: either by ensuring that each architecture's startup code will zero this memory or by some compiler/linker option such as -fno-common. Great, But what about the variables that are not in global scope? As I understand from init.h description: "Don't forget to initialize data not at file scope, i.e. within a function, as gcc otherwise puts the data into the bss section and not into the init section." Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/34] __initdata cleanup
On Friday 09 February 2007, Heiko Carstens wrote:
> And the top-level Makefile has:
>
> CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
>-fno-strict-aliasing -fno-common
>
> Note the -fno-common.
>
> And indeed all the __initdata annotated local and global variables on
> s390 are in the init.data section. So I'm wondering what this patch
> series is about. Or I must have missed something.
>
Hmmm... You have a valid point!
So it reduces the patch to the following.
>From the previous discussion I was afraid that I added some invalid variables.
Thanks!
Best Regards,
Alon Bar-Lev.
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/e820.c
linux-2.6.20-rc6-mm3/arch/x86_64/kernel/e820.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/e820.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/e820.c
@@ -402,10 +402,10 @@ static int __init sanitize_e820_map(stru
struct e820entry *pbios; /* pointer to original bios entry */
unsigned long long addr; /* address for this change point */
};
- static struct change_member change_point_list[2*E820MAX] __initdata;
- static struct change_member *change_point[2*E820MAX] __initdata;
- static struct e820entry *overlap_list[E820MAX] __initdata;
- static struct e820entry new_bios[E820MAX] __initdata;
+ static struct change_member change_point_list[2*E820MAX] __initdata =
{{0}};
+ static struct change_member *change_point[2*E820MAX] __initdata = {0};
+ static struct e820entry *overlap_list[E820MAX] __initdata = {0};
+ static struct e820entry new_bios[E820MAX] __initdata = {{0}};
struct change_member *change_tmp;
unsigned long current_type, last_type;
unsigned long long last_addr;
diff -urNp linux-2.6.20-rc6-mm3.org/fs/nfs/nfsroot.c
linux-2.6.20-rc6-mm3/fs/nfs/nfsroot.c
--- linux-2.6.20-rc6-mm3.org/fs/nfs/nfsroot.c 2007-01-25 04:19:28.0
+0200
+++ linux-2.6.20-rc6-mm3/fs/nfs/nfsroot.c 2007-01-31 22:19:30.0
+0200
@@ -289,7 +289,7 @@ static int __init root_nfs_parse(char *n
*/
static int __init root_nfs_name(char *name)
{
- static char buf[NFS_MAXPATHLEN] __initdata;
+ static char buf[NFS_MAXPATHLEN] __initdata = { 0, };
char *cp;
/* Set some default values */
diff -urNp linux-2.6.20-rc6-mm3.org/init/main.c linux-2.6.20-rc6-mm3/init/main.c
--- linux-2.6.20-rc6-mm3.org/init/main.c2007-01-31 22:15:41.0
+0200
+++ linux-2.6.20-rc6-mm3/init/main.c2007-01-31 22:19:30.0 +0200
@@ -470,7 +470,7 @@ static int __init do_early_param(char *p
void __init parse_early_param(void)
{
static __initdata int done = 0;
- static __initdata char tmp_cmdline[COMMAND_LINE_SIZE];
+ static __initdata char tmp_cmdline[COMMAND_LINE_SIZE] = "";
if (done)
return;
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/input/keyboard/amikbd.c
linux-2.6.20-rc6-mm3/drivers/input/keyboard/amikbd.c
--- linux-2.6.20-rc6-mm3.org/drivers/input/keyboard/amikbd.c2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/input/keyboard/amikbd.c2007-01-31
22:19:30.0 +0200
@@ -215,7 +215,7 @@ static int __init amikbd_init(void)
set_bit(i, amikbd_dev->keybit);
for (i = 0; i < MAX_NR_KEYMAPS; i++) {
- static u_short temp_map[NR_KEYS] __initdata;
+ static u_short temp_map[NR_KEYS] __initdata = {0};
if (!key_maps[i])
continue;
memset(temp_map, 0, sizeof(temp_map));
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 01/34] __initdata cleanup - alpha
On 2/9/07, Jiri Slaby <[EMAIL PROTECTED]> wrote: > -static char __initdata command_line[COMMAND_LINE_SIZE]; > +static char __initdata command_line[COMMAND_LINE_SIZE] = ""; Why is this "= 0" to static global variables needed? Please review http://lkml.org/lkml/2007/1/22/267 Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 04/34] __initdata cleanup - frv
Trivial. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.20-rc6-mm3.org/arch/frv/kernel/setup.c linux-2.6.20-rc6-mm3/arch/frv/kernel/setup.c --- linux-2.6.20-rc6-mm3.org/arch/frv/kernel/setup.c2007-01-31 22:15:30.0 +0200 +++ linux-2.6.20-rc6-mm3/arch/frv/kernel/setup.c2007-01-31 22:19:30.0 +0200 @@ -105,13 +105,13 @@ unsigned long __nongprelbss memory_end; unsigned long __nongprelbss dma_coherent_mem_start; unsigned long __nongprelbss dma_coherent_mem_end; -unsigned long __initdata __sdram_old_base; -unsigned long __initdata num_mappedpages; +unsigned long __initdata __sdram_old_base = 0l; +unsigned long __initdata num_mappedpages = 0l; struct cpuinfo_frv __nongprelbss boot_cpu_data; -char __initdata command_line[COMMAND_LINE_SIZE]; -char __initdata redboot_command_line[COMMAND_LINE_SIZE]; +char __initdata command_line[COMMAND_LINE_SIZE] = ""; +char __initdata redboot_command_line[COMMAND_LINE_SIZE] = ""; #ifdef CONFIG_PM #define __pminit - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 07/34] __initdata cleanup - ia64
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/acpi.c
linux-2.6.20-rc6-mm3/arch/ia64/kernel/acpi.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/acpi.c2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/kernel/acpi.c2007-01-31
22:19:30.0 +0200
@@ -158,9 +158,9 @@ char *__acpi_map_table(unsigned long phy
Boot-time Table Parsing
--
*/
-static int total_cpus __initdata;
-static int available_cpus __initdata;
-struct acpi_table_madt *acpi_madt __initdata;
+static int total_cpus __initdata = 0;
+static int available_cpus __initdata = 0;
+struct acpi_table_madt *acpi_madt __initdata = NULL;
static u8 has_8259;
static int __init
@@ -229,7 +229,7 @@ acpi_parse_iosapic(struct acpi_subtable_
return iosapic_init(iosapic->address, iosapic->global_irq_base);
}
-static unsigned int __initdata acpi_madt_rev;
+static unsigned int __initdata acpi_madt_rev = 0;
static int __init
acpi_parse_plat_int_src(struct acpi_subtable_header * header,
@@ -401,11 +401,11 @@ static int __init acpi_parse_madt(struct
#define PXM_FLAG_LEN ((MAX_PXM_DOMAINS + 1)/32)
-static int __initdata srat_num_cpus; /* number of cpus */
-static u32 __devinitdata pxm_flag[PXM_FLAG_LEN];
+static int __initdata srat_num_cpus = 0; /* number of cpus */
+static u32 __devinitdata pxm_flag[PXM_FLAG_LEN] = {0};
#define pxm_bit_set(bit) (set_bit(bit,(void *)pxm_flag))
#define pxm_bit_test(bit) (test_bit(bit,(void *)pxm_flag))
-static struct acpi_table_slit __initdata *slit_table;
+static struct acpi_table_slit __initdata *slit_table = NULL;
static int get_processor_proximity_domain(struct acpi_srat_cpu_affinity *pa)
{
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/machvec.c
linux-2.6.20-rc6-mm3/arch/ia64/kernel/machvec.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/machvec.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/kernel/machvec.c 2007-01-31
22:19:30.0 +0200
@@ -13,7 +13,7 @@
struct ia64_machine_vector ia64_mv;
EXPORT_SYMBOL(ia64_mv);
-static __initdata const char *mvec_name;
+static __initdata const char *mvec_name = NULL;
static __init int setup_mvec(char *s)
{
mvec_name = s;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/mca.c
linux-2.6.20-rc6-mm3/arch/ia64/kernel/mca.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/mca.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/kernel/mca.c 2007-01-31 22:19:30.0
+0200
@@ -138,7 +138,7 @@ static int cpe_poll_enabled = 1;
extern void salinfo_log_wakeup(int type, u8 *buffer, u64 size, int irqsafe);
-static int mca_init __initdata;
+static int mca_init __initdata = 0;
/*
* limited & delayed printing support for MCA/INIT handler
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/setup.c
linux-2.6.20-rc6-mm3/arch/ia64/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/setup.c 2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/kernel/setup.c 2007-01-31
22:19:30.0 +0200
@@ -131,8 +131,8 @@ EXPORT_SYMBOL(ia64_max_iommu_merge_mask)
/*
* We use a special marker for the end of memory and it uses the extra (+1)
slot
*/
-struct rsvd_region rsvd_region[IA64_MAX_RSVD_REGIONS + 1] __initdata;
-int num_rsvd_regions __initdata;
+struct rsvd_region rsvd_region[IA64_MAX_RSVD_REGIONS + 1] __initdata = {{0}};
+int num_rsvd_regions __initdata = 0;
/*
@@ -432,7 +432,7 @@ check_for_logical_procs (void)
}
#endif
-static __initdata int nomca;
+static __initdata int nomca = 0;
static __init int setup_nomca(char *s)
{
nomca = 1;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/smpboot.c
linux-2.6.20-rc6-mm3/arch/ia64/kernel/smpboot.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/kernel/smpboot.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/kernel/smpboot.c 2007-01-31
22:19:30.0 +0200
@@ -148,11 +148,11 @@ EXPORT_SYMBOL(ia64_cpu_to_sapicid);
static volatile cpumask_t cpu_callin_map;
-struct smp_boot_data smp_boot_data __initdata;
+struct smp_boot_data smp_boot_data __initdata = {0};
unsigned long ap_wakeup_vector = -1; /* External Int use to wakeup APs */
-char __initdata no_int_routing;
+char __initdata no_int_routing = 0;
unsigned char smp_int_redirect; /* are INT and IPI redirectable by the
chipset? */
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ia64/mm/discontig.c
linux-2.6.20-rc6-mm3/arch/ia64/mm/discontig.c
--- linux-2.6.20-rc6-mm3.org/arch/ia64/mm/discontig.c 2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/ia64/mm/discontig.c 2007-01-31
22:19:30.0 +0200
@@ -44,8 +44,8 @@ struct early_node_data {
unsigned long max_pfn
[PATCH 08/34] __initdata cleanup - m32r
Trivial.
**NOT TESTED***
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/m32r/kernel/setup.c
linux-2.6.20-rc6-mm3/arch/m32r/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/m32r/kernel/setup.c 2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/m32r/kernel/setup.c 2007-01-31
22:19:30.0 +0200
@@ -64,7 +64,7 @@ struct screen_info screen_info = {
extern int root_mountflags;
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
static struct resource data_resource = {
.name = "Kernel data",
diff -urNp linux-2.6.20-rc6-mm3.org/arch/m32r/mm/discontig.c
linux-2.6.20-rc6-mm3/arch/m32r/mm/discontig.c
--- linux-2.6.20-rc6-mm3.org/arch/m32r/mm/discontig.c 2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/m32r/mm/discontig.c 2007-01-31
22:19:30.0 +0200
@@ -20,7 +20,7 @@ extern char _end[];
struct pglist_data *node_data[MAX_NUMNODES];
EXPORT_SYMBOL(node_data);
-static bootmem_data_t node_bdata[MAX_NUMNODES] __initdata;
+static bootmem_data_t node_bdata[MAX_NUMNODES] __initdata = {{0}};
pg_data_t m32r_node_data[MAX_NUMNODES];
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 06/34] __initdata cleanup - i386
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/acpi/boot.c
linux-2.6.20-rc6-mm3/arch/i386/kernel/acpi/boot.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/acpi/boot.c 2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/acpi/boot.c 2007-01-31
22:20:36.0 +0200
@@ -72,7 +72,7 @@ static inline int acpi_madt_oem_check(ch
#define PREFIX "ACPI: "
int acpi_noirq;/* skip ACPI IRQ initialization
*/
-int acpi_pci_disabled __initdata; /* skip ACPI PCI scan and IRQ
initialization */
+int acpi_pci_disabled __initdata = 0; /* skip ACPI PCI scan and IRQ
initialization */
int acpi_ht __initdata = 1;/* enable HT */
int acpi_lapic;
@@ -80,10 +80,10 @@ int acpi_ioapic;
int acpi_strict;
EXPORT_SYMBOL(acpi_strict);
-u8 acpi_sci_flags __initdata;
-int acpi_sci_override_gsi __initdata;
-int acpi_skip_timer_override __initdata;
-int acpi_use_timer_override __initdata;
+u8 acpi_sci_flags __initdata = 0;
+int acpi_sci_override_gsi __initdata = 0;
+int acpi_skip_timer_override __initdata = 0;
+int acpi_use_timer_override __initdata = 0;
#ifdef CONFIG_X86_LOCAL_APIC
static u64 acpi_lapic_addr __initdata = APIC_DEFAULT_PHYS_BASE;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/acpi/earlyquirk.c
linux-2.6.20-rc6-mm3/arch/i386/kernel/acpi/earlyquirk.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/acpi/earlyquirk.c 2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/acpi/earlyquirk.c 2007-01-31
22:19:30.0 +0200
@@ -13,7 +13,7 @@
#ifdef CONFIG_ACPI
-static int nvidia_hpet_detected __initdata;
+static int nvidia_hpet_detected __initdata = 0;
static int __init nvidia_hpet_check(struct acpi_table_header *header)
{
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/cpu/mtrr/generic.c
linux-2.6.20-rc6-mm3/arch/i386/kernel/cpu/mtrr/generic.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/cpu/mtrr/generic.c
2007-01-25 04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/cpu/mtrr/generic.c2007-01-31
22:19:30.0 +0200
@@ -26,7 +26,7 @@ static struct mtrr_state mtrr_state = {}
#undef MODULE_PARAM_PREFIX
#define MODULE_PARAM_PREFIX "mtrr."
-static __initdata int mtrr_show;
+static __initdata int mtrr_show = 0;
module_param_named(show, mtrr_show, bool, 0);
/* Get the MSR pair relating to a var range */
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/e820.c
linux-2.6.20-rc6-mm3/arch/i386/kernel/e820.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/e820.c2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/e820.c2007-01-31
22:19:30.0 +0200
@@ -26,10 +26,10 @@ struct change_member {
struct e820entry *pbios; /* pointer to original bios entry */
unsigned long long addr; /* address for this change point */
};
-static struct change_member change_point_list[2*E820MAX] __initdata;
-static struct change_member *change_point[2*E820MAX] __initdata;
-static struct e820entry *overlap_list[E820MAX] __initdata;
-static struct e820entry new_bios[E820MAX] __initdata;
+static struct change_member change_point_list[2*E820MAX] __initdata = {{0}};
+static struct change_member *change_point[2*E820MAX] __initdata = {0};
+static struct e820entry *overlap_list[E820MAX] __initdata = {0};
+static struct e820entry new_bios[E820MAX] __initdata = {{0}};
/* For PCI or other memory-mapped resources */
unsigned long pci_mem_start = 0x1000;
#ifdef CONFIG_PCI
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/io_apic.c
linux-2.6.20-rc6-mm3/arch/i386/kernel/io_apic.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/io_apic.c 2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/io_apic.c 2007-01-31
22:19:30.0 +0200
@@ -72,7 +72,7 @@ int sis_apic_bug = -1;
*/
int nr_ioapic_registers[MAX_IO_APICS];
-static int disable_timer_pin_1 __initdata;
+static int disable_timer_pin_1 __initdata = 0;
/*
* Rough estimation of how many shared IRQs there are, can
@@ -1920,7 +1920,7 @@ static void __init setup_ioapic_ids_from
static void __init setup_ioapic_ids_from_mpc(void) { }
#endif
-int no_timer_check __initdata;
+int no_timer_check __initdata = 0;
static int __init notimercheck(char *s)
{
diff -urNp linux-2.6.20-rc6-mm3.org/arch/i386/kernel/setup.c
linux-2.6.20-rc6-mm3/arch/i386/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/i386/kernel/setup.c 2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/i386/kernel/setup.c 2007-01-31
22:19:30.0 +0200
@@ -133,9 +133,9 @@ unsigned long saved_videomode;
#define RAMDISK_PROMPT_FLAG0x8000
#define RAMDISK_LOAD_FLAG 0x4000
-static char __initdata command_line[COMMAND_LINE_SIZE];
+sta
[PATCH 05/34] __initdata cleanup - h8300
Trivial. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.20-rc6-mm3.org/arch/h8300/kernel/setup.c linux-2.6.20-rc6-mm3/arch/h8300/kernel/setup.c --- linux-2.6.20-rc6-mm3.org/arch/h8300/kernel/setup.c 2007-01-31 22:15:30.0 +0200 +++ linux-2.6.20-rc6-mm3/arch/h8300/kernel/setup.c 2007-01-31 22:19:30.0 +0200 @@ -54,7 +54,7 @@ unsigned long rom_length; unsigned long memory_start; unsigned long memory_end; -char __initdata command_line[COMMAND_LINE_SIZE]; +char __initdata command_line[COMMAND_LINE_SIZE] = ""; extern int _stext, _etext, _sdata, _edata, _sbss, _ebss, _end; extern int _ramstart, _ramend; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 16/34] __initdata cleanup - sparc64
Trivial.
**NOT TESTED***
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/sparc64/mm/init.c
linux-2.6.20-rc6-mm3/arch/sparc64/mm/init.c
--- linux-2.6.20-rc6-mm3.org/arch/sparc64/mm/init.c
+++ linux-2.6.20-rc6-mm3/arch/sparc64/mm/init.c
@@ -64,10 +64,10 @@ struct tsb swapper_4m_tsb[KERNEL_TSB4M_N
#define MAX_BANKS 32
-static struct linux_prom64_registers pavail[MAX_BANKS] __initdata;
-static struct linux_prom64_registers pavail_rescan[MAX_BANKS] __initdata;
-static int pavail_ents __initdata;
-static int pavail_rescan_ents __initdata;
+static struct linux_prom64_registers pavail[MAX_BANKS] __initdata = {{0}};
+static struct linux_prom64_registers pavail_rescan[MAX_BANKS] __initdata =
{{0}};
+static int pavail_ents __initdata = 0;
+static int pavail_rescan_ents __initdata = 0;
static int cmp_p64(const void *a, const void *b)
{
@@ -1109,8 +1109,8 @@ static unsigned long __init bootmem_init
return end_pfn;
}
-static struct linux_prom64_registers pall[MAX_BANKS] __initdata;
-static int pall_ents __initdata;
+static struct linux_prom64_registers pall[MAX_BANKS] __initdata = {{0}};
+static int pall_ents __initdata = 0;
#ifdef CONFIG_DEBUG_PAGEALLOC
static unsigned long kernel_map_range(unsigned long pstart, unsigned long
pend, pgprot_t prot)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 01/34] __initdata cleanup - alpha
Trivial. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/setup.c linux-2.6.20-rc6-mm3/arch/alpha/kernel/setup.c --- linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/setup.c 2007-01-31 22:15:30.0 +0200 +++ linux-2.6.20-rc6-mm3/arch/alpha/kernel/setup.c 2007-01-31 22:19:30.0 +0200 @@ -122,7 +122,7 @@ static void get_sysnames(unsigned long, char **, char **); static void determine_cpu_caches (unsigned int); -static char __initdata command_line[COMMAND_LINE_SIZE]; +static char __initdata command_line[COMMAND_LINE_SIZE] = ""; /* * The format of "screen_info" is strange, and due to early diff -urNp linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/smc37c669.c linux-2.6.20-rc6-mm3/arch/alpha/kernel/smc37c669.c --- linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/smc37c669.c 2007-01-25 04:19:28.0 +0200 +++ linux-2.6.20-rc6-mm3/arch/alpha/kernel/smc37c669.c 2007-01-31 22:19:30.0 +0200 @@ -996,7 +996,7 @@ static SMC37c669_CONFIG_REGS *SMC37c669 ** and standard ISA IRQs. ** */ -static SMC37c669_IRQ_TRANSLATION_ENTRY *SMC37c669_irq_table __initdata; +static SMC37c669_IRQ_TRANSLATION_ENTRY *SMC37c669_irq_table __initdata = NULL; /* ** The following definition is for the default IRQ @@ -1045,7 +1045,7 @@ static SMC37c669_IRQ_TRANSLATION_ENTRY * ** ISA DMA channels. ** */ -static SMC37c669_DRQ_TRANSLATION_ENTRY *SMC37c669_drq_table __initdata; +static SMC37c669_DRQ_TRANSLATION_ENTRY *SMC37c669_drq_table __initdata = NULL; /* ** The following definition is the default DRQ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 17/34] __initdata cleanup - v850
Trivial. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.20-rc6-mm3.org/arch/v850/kernel/setup.c linux-2.6.20-rc6-mm3/arch/v850/kernel/setup.c --- linux-2.6.20-rc6-mm3.org/arch/v850/kernel/setup.c 2007-01-31 22:15:32.0 +0200 +++ linux-2.6.20-rc6-mm3/arch/v850/kernel/setup.c 2007-01-31 22:19:30.0 +0200 @@ -42,7 +42,7 @@ extern char _root_fs_image_start __attri extern char _root_fs_image_end __attribute__ ((__weak__)); -char __initdata command_line[COMMAND_LINE_SIZE]; +char __initdata command_line[COMMAND_LINE_SIZE] = ""; /* Memory not used by the kernel. */ static unsigned long total_ram_pages; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 14/34] __initdata cleanup - s390
Trivial.
**NOT TESTED***
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/s390/kernel/setup.c
linux-2.6.20-rc6-mm3/arch/s390/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/s390/kernel/setup.c
+++ linux-2.6.20-rc6-mm3/arch/s390/kernel/setup.c
@@ -74,9 +74,9 @@ unsigned int console_devno = -1;
unsigned int console_irq = -1;
unsigned long machine_flags = 0;
-struct mem_chunk __initdata memory_chunk[MEMORY_CHUNKS];
+struct mem_chunk __initdata memory_chunk[MEMORY_CHUNKS] = {{0}};
volatile int __cpu_logical_map[NR_CPUS]; /* logical cpu to cpu address */
-static unsigned long __initdata memory_end;
+static unsigned long __initdata memory_end = 0l;
/*
* This is set up by the setup-routine at boot-time
diff -urNp linux-2.6.20-rc6-mm3.org/arch/s390/kernel/smp.c
linux-2.6.20-rc6-mm3/arch/s390/kernel/smp.c
--- linux-2.6.20-rc6-mm3.org/arch/s390/kernel/smp.c
+++ linux-2.6.20-rc6-mm3/arch/s390/kernel/smp.c
@@ -603,8 +603,8 @@ __cpu_up(unsigned int cpu)
return 0;
}
-static unsigned int __initdata additional_cpus;
-static unsigned int __initdata possible_cpus;
+static unsigned int __initdata additional_cpus = 0;
+static unsigned int __initdata possible_cpus = 0;
void __init smp_setup_cpu_possible_map(void)
{
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/s390/block/xpram.c
linux-2.6.20-rc6-mm3/drivers/s390/block/xpram.c
--- linux-2.6.20-rc6-mm3.org/drivers/s390/block/xpram.c
+++ linux-2.6.20-rc6-mm3/drivers/s390/block/xpram.c
@@ -63,7 +63,7 @@ static int xpram_devs;
* Parameter parsing functions.
*/
static int __initdata devs = XPRAM_DEVS;
-static char __initdata *sizes[XPRAM_MAX_DEVS];
+static char __initdata *sizes[XPRAM_MAX_DEVS] = {0};
module_param(devs, int, 0);
module_param_array(sizes, charp, NULL, 0);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 13/34] __initdata cleanup - ppc
Trivial.
**NOT TESTED***
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/bamboo.c
linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/bamboo.c
--- linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/bamboo.c2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/bamboo.c2007-01-31
22:19:30.0 +0200
@@ -50,7 +50,7 @@
extern bd_t __res;
-static struct ibm44x_clocks clocks __initdata;
+static struct ibm44x_clocks clocks __initdata = {0};
/*
* Bamboo external IRQ triggering/polarity settings
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/ebony.c
linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/ebony.c
--- linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/ebony.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/ebony.c 2007-01-31
22:19:30.0 +0200
@@ -53,7 +53,7 @@
extern bd_t __res;
-static struct ibm44x_clocks clocks __initdata;
+static struct ibm44x_clocks clocks __initdata = {0};
/*
* Ebony external IRQ triggering/polarity settings
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/luan.c
linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/luan.c
--- linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/luan.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/luan.c 2007-01-31
22:19:30.0 +0200
@@ -51,7 +51,7 @@
extern bd_t __res;
-static struct ibm44x_clocks clocks __initdata;
+static struct ibm44x_clocks clocks __initdata = {0};
static void __init
luan_calibrate_decr(void)
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/ocotea.c
linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/ocotea.c
--- linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/ocotea.c2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/ocotea.c2007-01-31
22:19:30.0 +0200
@@ -51,7 +51,7 @@
extern bd_t __res;
-static struct ibm44x_clocks clocks __initdata;
+static struct ibm44x_clocks clocks __initdata = {0};
static void __init
ocotea_calibrate_decr(void)
diff -urNp linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/yucca.c
linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/yucca.c
--- linux-2.6.20-rc6-mm3.org/arch/ppc/platforms/4xx/yucca.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/ppc/platforms/4xx/yucca.c 2007-01-31
22:19:30.0 +0200
@@ -53,7 +53,7 @@
extern bd_t __res;
-static struct ibm44x_clocks clocks __initdata;
+static struct ibm44x_clocks clocks __initdata = {0};
static void __init
yucca_calibrate_decr(void)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 18/34] __initdata cleanup - x86_64
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/crypto/aes.c
linux-2.6.20-rc6-mm3/arch/x86_64/crypto/aes.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/crypto/aes.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/crypto/aes.c
@@ -83,10 +83,10 @@ struct aes_ctx
#define E_KEY (&ctx->buf[0])
#define D_KEY (&ctx->buf[60])
-static u8 pow_tab[256] __initdata;
-static u8 log_tab[256] __initdata;
-static u8 sbx_tab[256] __initdata;
-static u8 isb_tab[256] __initdata;
+static u8 pow_tab[256] __initdata = {0};
+static u8 log_tab[256] __initdata = {0};
+static u8 sbx_tab[256] __initdata = {0};
+static u8 isb_tab[256] __initdata = {0};
static u32 rco_tab[10];
u32 aes_ft_tab[4][256];
u32 aes_it_tab[4][256];
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/apic.c
linux-2.6.20-rc6-mm3/arch/x86_64/kernel/apic.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/apic.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/apic.c
@@ -43,9 +43,9 @@
int apic_mapped;
int apic_verbosity;
int apic_runs_main_timer;
-int apic_calibrate_pmtmr __initdata;
+int apic_calibrate_pmtmr __initdata = 0;
-int disable_apic_timer __initdata;
+int disable_apic_timer __initdata = 0;
static struct resource *ioapic_resources;
static struct resource lapic_resource = {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/e820.c
linux-2.6.20-rc6-mm3/arch/x86_64/kernel/e820.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/e820.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/e820.c
@@ -25,7 +25,7 @@
#include
#include
-struct e820map e820 __initdata;
+struct e820map e820 __initdata = {0};
/*
* PFN of last memory page.
@@ -402,10 +402,10 @@ static int __init sanitize_e820_map(stru
struct e820entry *pbios; /* pointer to original bios entry */
unsigned long long addr; /* address for this change point */
};
- static struct change_member change_point_list[2*E820MAX] __initdata;
- static struct change_member *change_point[2*E820MAX] __initdata;
- static struct e820entry *overlap_list[E820MAX] __initdata;
- static struct e820entry new_bios[E820MAX] __initdata;
+ static struct change_member change_point_list[2*E820MAX] __initdata =
{{0}};
+ static struct change_member *change_point[2*E820MAX] __initdata = {0};
+ static struct e820entry *overlap_list[E820MAX] __initdata = {0};
+ static struct e820entry new_bios[E820MAX] __initdata = {{0}};
struct change_member *change_tmp;
unsigned long current_type, last_type;
unsigned long long last_addr;
@@ -618,7 +618,7 @@ static int __init parse_memopt(char *p)
}
early_param("mem", parse_memopt);
-static int userdef __initdata;
+static int userdef __initdata = 0;
static int __init parse_memmap_opt(char *p)
{
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/early_printk.c
linux-2.6.20-rc6-mm3/arch/x86_64/kernel/early_printk.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/early_printk.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/early_printk.c
@@ -213,7 +213,7 @@ void early_printk(const char *fmt, ...)
va_end(ap);
}
-static int __initdata keep_early;
+static int __initdata keep_early = 0;
static int __init setup_early_printk(char *buf)
{
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/early-quirks.c
linux-2.6.20-rc6-mm3/arch/x86_64/kernel/early-quirks.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/early-quirks.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/early-quirks.c
@@ -30,7 +30,7 @@ static void via_bugs(void)
#ifdef CONFIG_ACPI
-static int nvidia_hpet_detected __initdata;
+static int nvidia_hpet_detected __initdata = 0;
static int __init nvidia_hpet_check(struct acpi_table_header *header)
{
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/io_apic.c
linux-2.6.20-rc6-mm3/arch/x86_64/kernel/io_apic.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/io_apic.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/io_apic.c
@@ -55,7 +55,7 @@ int sis_apic_bug; /* not actually suppor
static int no_timer_check;
-static int disable_timer_pin_1 __initdata;
+static int disable_timer_pin_1 __initdata = 0;
int timer_over_8254 __initdata = 1;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/mpparse.c
linux-2.6.20-rc6-mm3/arch/x86_64/kernel/mpparse.c
--- linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/mpparse.c
+++ linux-2.6.20-rc6-mm3/arch/x86_64/kernel/mpparse.c
@@ -62,7 +62,7 @@ unsigned int boot_cpu_id = -1U;
/* Internal processor count */
unsigned int num_processors __initdata = 0;
-unsigned disabled_cpus __initdata;
+unsigned disabled_cpus __initdata = 0;
/* Bitmask of physically existing CPUs */
physid_mask_t phys_cpu_present_map = PHYSID_MASK_NONE;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/x86_64/kernel/pci-calgary.c
linux-2.6.20-rc6-mm3/arch/x86_64/kernel/pci-calgary.c
--- linux-2.6.2
[PATCH 12/34] __initdata cleanup - powerpc
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/legacy_serial.c
linux-2.6.20-rc6-mm3/arch/powerpc/kernel/legacy_serial.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/legacy_serial.c
2007-01-31 22:15:31.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/kernel/legacy_serial.c2007-01-31
22:19:30.0 +0200
@@ -565,7 +565,7 @@ static int __init check_legacy_serial_co
DBG("Found serial console at ttyS%d\n", offset);
if (speed) {
- static char __initdata opt[16];
+ static char __initdata opt[16] = {0};
sprintf(opt, "%d", speed);
return add_preferred_console("ttyS", offset, opt);
} else
diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/pci_32.c
linux-2.6.20-rc6-mm3/arch/powerpc/kernel/pci_32.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/pci_32.c 2007-01-31
22:15:31.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/kernel/pci_32.c 2007-01-31
22:19:30.0 +0200
@@ -889,7 +889,7 @@ void __init
pci_process_bridge_OF_ranges(struct pci_controller *hose,
struct device_node *dev, int primary)
{
- static unsigned int static_lc_ranges[256] __initdata;
+ static unsigned int static_lc_ranges[256] __initdata = {0};
const unsigned int *dt_ranges;
unsigned int *lc_ranges, *ranges, *prev, size;
int rlen = 0, orig_rlen;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/prom.c
linux-2.6.20-rc6-mm3/arch/powerpc/kernel/prom.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/prom.c 2007-01-31
22:15:31.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/kernel/prom.c 2007-01-31
22:19:30.0 +0200
@@ -60,8 +60,8 @@
#endif
-static int __initdata dt_root_addr_cells;
-static int __initdata dt_root_size_cells;
+static int __initdata dt_root_addr_cells = 0;
+static int __initdata dt_root_size_cells = 0;
#ifdef CONFIG_PPC64
int __initdata iommu_is_off;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/prom_init.c
linux-2.6.20-rc6-mm3/arch/powerpc/kernel/prom_init.c
--- linux-2.6.20-rc6-mm3.org/arch/powerpc/kernel/prom_init.c2007-01-31
22:15:31.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/powerpc/kernel/prom_init.c2007-01-31
22:19:30.0 +0200
@@ -157,26 +157,26 @@ extern void copy_and_flush(unsigned long
unsigned long size, unsigned long offset);
/* prom structure */
-static struct prom_t __initdata prom;
+static struct prom_t __initdata prom = {0};
-static unsigned long prom_entry __initdata;
+static unsigned long prom_entry __initdata = 0l;
#define PROM_SCRATCH_SIZE 256
-static char __initdata of_stdout_device[256];
-static char __initdata prom_scratch[PROM_SCRATCH_SIZE];
+static char __initdata of_stdout_device[256] = {0};
+static char __initdata prom_scratch[PROM_SCRATCH_SIZE] = {0};
-static unsigned long __initdata dt_header_start;
-static unsigned long __initdata dt_struct_start, dt_struct_end;
-static unsigned long __initdata dt_string_start, dt_string_end;
+static unsigned long __initdata dt_header_start = 0l;
+static unsigned long __initdata dt_struct_start = 0l, dt_struct_end = 0l;
+static unsigned long __initdata dt_string_start = 0l, dt_string_end = 0l;
-static unsigned long __initdata prom_initrd_start, prom_initrd_end;
+static unsigned long __initdata prom_initrd_start = 0l, prom_initrd_end = 0l;
#ifdef CONFIG_PPC64
-static int __initdata prom_iommu_force_on;
-static int __initdata prom_iommu_off;
-static unsigned long __initdata prom_tce_alloc_start;
-static unsigned long __initdata prom_tce_alloc_end;
+static int __initdata prom_iommu_force_on = 0;
+static int __initdata prom_iommu_off = 0;
+static unsigned long __initdata prom_tce_alloc_start = 0l;
+static unsigned long __initdata prom_tce_alloc_end = 0l;
#endif
/* Platforms codes are now obsolete in the kernel. Now only used within this
@@ -189,20 +189,20 @@ static unsigned long __initdata prom_tce
#define PLATFORM_POWERMAC 0x0400
#define PLATFORM_GENERIC 0x0500
-static int __initdata of_platform;
+static int __initdata of_platform = 0;
-static char __initdata prom_cmd_line[COMMAND_LINE_SIZE];
+static char __initdata prom_cmd_line[COMMAND_LINE_SIZE] = "";
-static unsigned long __initdata alloc_top;
-static unsigned long __initdata alloc_top_high;
-static unsigned long __initdata alloc_bottom;
-static unsigned long __initdata rmo_top;
-static unsigned long __initdata ram_top;
+static unsigned long __initdata alloc_top = 0l;
+static unsigned long __initdata alloc_top_high = 0l;
+static unsigned long __initdata alloc_bottom = 0l;
+static unsigned long __initdata rmo_top = 0l;
+static unsigned long __initdata ram_top = 0l;
-static struct mem_map_entry __initdata mem_reser
[PATCH 09/34] __initdata cleanup - m68knommu
Trivial. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.20-rc6-mm3.org/arch/m68knommu/kernel/setup.c linux-2.6.20-rc6-mm3/arch/m68knommu/kernel/setup.c --- linux-2.6.20-rc6-mm3.org/arch/m68knommu/kernel/setup.c 2007-01-31 22:15:31.0 +0200 +++ linux-2.6.20-rc6-mm3/arch/m68knommu/kernel/setup.c 2007-01-31 22:19:30.0 +0200 @@ -44,7 +44,7 @@ unsigned long memory_end; EXPORT_SYMBOL(memory_start); EXPORT_SYMBOL(memory_end); -char __initdata command_line[COMMAND_LINE_SIZE]; +char __initdata command_line[COMMAND_LINE_SIZE] = ""; /* setup some dummy routines */ static void dummy_waitbut(void) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 21/34] __initdata cleanup - aes
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/crypto/aes.c
linux-2.6.20-rc6-mm3/crypto/aes.c
--- linux-2.6.20-rc6-mm3.org/crypto/aes.c 2007-01-25 04:19:28.0
+0200
+++ linux-2.6.20-rc6-mm3/crypto/aes.c 2007-01-31 22:19:30.0 +0200
@@ -81,10 +81,10 @@ struct aes_ctx {
#define E_KEY (&ctx->buf[0])
#define D_KEY (&ctx->buf[60])
-static u8 pow_tab[256] __initdata;
-static u8 log_tab[256] __initdata;
-static u8 sbx_tab[256] __initdata;
-static u8 isb_tab[256] __initdata;
+static u8 pow_tab[256] __initdata = {0};
+static u8 log_tab[256] __initdata = {0};
+static u8 sbx_tab[256] __initdata = {0};
+static u8 isb_tab[256] __initdata = {0};
static u32 rco_tab[10];
static u32 ft_tab[4][256];
static u32 it_tab[4][256];
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 10/34] __initdata cleanup - mips
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/kernel/traps.c
linux-2.6.20-rc6-mm3/arch/mips/kernel/traps.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/kernel/traps.c
+++ linux-2.6.20-rc6-mm3/arch/mips/kernel/traps.c
@@ -1432,7 +1432,7 @@ void __init set_uncached_handler (unsign
memcpy((void *)(uncached_ebase + offset), addr, size);
}
-static int __initdata rdhwr_noopt;
+static int __initdata rdhwr_noopt = 0;
static int __init set_rdhwr_noopt(char *str)
{
rdhwr_noopt = 1;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/mm/pg-r4k.c
linux-2.6.20-rc6-mm3/arch/mips/mm/pg-r4k.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/mm/pg-r4k.c
+++ linux-2.6.20-rc6-mm3/arch/mips/mm/pg-r4k.c
@@ -67,13 +67,13 @@ EXPORT_SYMBOL(copy_page);
static int pref_offset_clear __initdata = 512;
static int pref_offset_copy __initdata = 256;
-static unsigned int pref_src_mode __initdata;
-static unsigned int pref_dst_mode __initdata;
+static unsigned int pref_src_mode __initdata = 0;
+static unsigned int pref_dst_mode __initdata = 0;
-static int load_offset __initdata;
-static int store_offset __initdata;
+static int load_offset __initdata = 0;
+static int store_offset __initdata = 0;
-static unsigned int __initdata *dest, *epc;
+static unsigned int __initdata *dest = NULL, *epc = NULL;
static unsigned int instruction_pending;
static union mips_instruction delayed_mi;
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/mm/tlbex.c
linux-2.6.20-rc6-mm3/arch/mips/mm/tlbex.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/mm/tlbex.c
+++ linux-2.6.20-rc6-mm3/arch/mips/mm/tlbex.c
@@ -728,11 +728,11 @@ il_bgez(u32 **p, struct reloc **r, unsig
* We deliberately chose a buffer size of 128, so we won't scribble
* over anything important on overflow before we panic.
*/
-static __initdata u32 tlb_handler[128];
+static __initdata u32 tlb_handler[128] = {0};
/* simply assume worst case size for labels and relocs */
-static __initdata struct label labels[128];
-static __initdata struct reloc relocs[128];
+static __initdata struct label labels[128] = {{NULL}};
+static __initdata struct reloc relocs[128] = {{NULL}};
/*
* The R3000 TLB handler is simple.
@@ -786,7 +786,7 @@ static void __init build_r3000_tlb_refil
* other one.To keep things simple, we first assume linear space,
* then we relocate it to the final handler layout as needed.
*/
-static __initdata u32 final_handler[64];
+static __initdata u32 final_handler[64] = {0};
/*
* Hazards
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/mm/tlb-r4k.c
linux-2.6.20-rc6-mm3/arch/mips/mm/tlb-r4k.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/mm/tlb-r4k.c
+++ linux-2.6.20-rc6-mm3/arch/mips/mm/tlb-r4k.c
@@ -367,7 +367,7 @@ void __init add_wired_entry(unsigned lon
* lifetime of the system
*/
-static int temp_tlb_entry __initdata;
+static int temp_tlb_entry __initdata = 0;
__init int add_temporary_entry(unsigned long entrylo0, unsigned long entrylo1,
unsigned long entryhi, unsigned long pagemask)
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/pci/fixup-malta.c
linux-2.6.20-rc6-mm3/arch/mips/pci/fixup-malta.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/pci/fixup-malta.c
+++ linux-2.6.20-rc6-mm3/arch/mips/pci/fixup-malta.c
@@ -8,7 +8,7 @@
#define PCID 4
/* This table is filled in by interrogating the PIIX4 chip */
-static char pci_irq[5] __initdata;
+static char pci_irq[5] __initdata = {0};
static char irq_tab[][5] __initdata = {
/* INTAINTBINTCINTD */
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/pmc-sierra/yosemite/smp.c
linux-2.6.20-rc6-mm3/arch/mips/pmc-sierra/yosemite/smp.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/pmc-sierra/yosemite/smp.c
+++ linux-2.6.20-rc6-mm3/arch/mips/pmc-sierra/yosemite/smp.c
@@ -9,11 +9,11 @@
static __initdata DEFINE_SPINLOCK(launch_lock);
-static unsigned long secondary_sp __initdata;
-static unsigned long secondary_gp __initdata;
+static unsigned long secondary_sp __initdata = 0l;
+static unsigned long secondary_gp __initdata = 0l;
static unsigned char launchstack[LAUNCHSTACK_SIZE] __initdata
- __attribute__((aligned(2 * sizeof(long;
+ __attribute__((aligned(2 * sizeof(long = {0};
static void __init prom_smp_bootstrap(void)
{
diff -urNp linux-2.6.20-rc6-mm3.org/arch/mips/sgi-ip27/ip27-memory.c
linux-2.6.20-rc6-mm3/arch/mips/sgi-ip27/ip27-memory.c
--- linux-2.6.20-rc6-mm3.org/arch/mips/sgi-ip27/ip27-memory.c
+++ linux-2.6.20-rc6-mm3/arch/mips/sgi-ip27/ip27-memory.c
@@ -34,9 +34,9 @@
#define SLOT_IGNORED 0x
-static short __initdata slot_lastfilled_cache[MAX_COMPACT_NODES];
-static unsigned short __initdata
slot_psize_cache[MAX_COMPACT_NODES][MAX_MEM_SLOTS];
-static struct bootmem_data __initdata plat_node_bdata[MAX_COMPACT_NODES];
+static short __initdata slot_lastfilled_cache[MAX_COMPACT_NODE
[PATCH 20/34] __initdata cleanup - acpi
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/acpi/ec.c
linux-2.6.20-rc6-mm3/drivers/acpi/ec.c
--- linux-2.6.20-rc6-mm3.org/drivers/acpi/ec.c 2007-01-31 22:15:32.0
+0200
+++ linux-2.6.20-rc6-mm3/drivers/acpi/ec.c 2007-01-31 22:19:30.0
+0200
@@ -911,7 +911,7 @@ static int __init acpi_ec_get_real_ecdt(
return -ENODEV;
}
-static int __initdata acpi_fake_ecdt_enabled;
+static int __initdata acpi_fake_ecdt_enabled = 0;
int __init acpi_ec_ecdt_probe(void)
{
acpi_status status;
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/acpi/tables.c
linux-2.6.20-rc6-mm3/drivers/acpi/tables.c
--- linux-2.6.20-rc6-mm3.org/drivers/acpi/tables.c 2007-01-31
22:15:32.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/acpi/tables.c 2007-01-31 22:21:09.0
+0200
@@ -40,7 +40,7 @@
static char *mps_inti_flags_polarity[] = { "dfl", "high", "res", "low" };
static char *mps_inti_flags_trigger[] = { "dfl", "edge", "res", "level" };
-static struct acpi_table_desc initial_tables[ACPI_MAX_TABLES] __initdata;
+static struct acpi_table_desc initial_tables[ACPI_MAX_TABLES] __initdata =
{{0}};
void acpi_table_print_madt_entry(struct acpi_subtable_header * header)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 25/34] __initdata cleanup - input
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/input/joystick/db9.c
linux-2.6.20-rc6-mm3/drivers/input/joystick/db9.c
--- linux-2.6.20-rc6-mm3.org/drivers/input/joystick/db9.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/input/joystick/db9.c 2007-01-31
23:18:42.0 +0200
@@ -50,7 +50,7 @@ struct db9_config {
};
#define DB9_MAX_PORTS 3
-static struct db9_config db9[DB9_MAX_PORTS] __initdata;
+static struct db9_config db9[DB9_MAX_PORTS] __initdata = {{{0}}};
module_param_array_named(dev, db9[0].args, int, &db9[0].nargs, 0);
MODULE_PARM_DESC(dev, "Describes first attached device (,)");
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/input/joystick/gamecon.c
linux-2.6.20-rc6-mm3/drivers/input/joystick/gamecon.c
--- linux-2.6.20-rc6-mm3.org/drivers/input/joystick/gamecon.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/input/joystick/gamecon.c 2007-01-31
23:18:54.0 +0200
@@ -51,7 +51,7 @@ struct gc_config {
int nargs;
};
-static struct gc_config gc[GC_MAX_PORTS] __initdata;
+static struct gc_config gc[GC_MAX_PORTS] __initdata = {{{0}}};
module_param_array_named(map, gc[0].args, int, &gc[0].nargs, 0);
MODULE_PARM_DESC(map, "Describes first set of devices
(,,,..)");
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/input/joystick/turbografx.c
linux-2.6.20-rc6-mm3/drivers/input/joystick/turbografx.c
--- linux-2.6.20-rc6-mm3.org/drivers/input/joystick/turbografx.c
2007-01-25 04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/input/joystick/turbografx.c2007-01-31
23:19:07.0 +0200
@@ -51,7 +51,7 @@ struct tgfx_config {
int nargs;
};
-static struct tgfx_config tgfx[TGFX_MAX_PORTS] __initdata;
+static struct tgfx_config tgfx[TGFX_MAX_PORTS] __initdata = {{{0}}};
module_param_array_named(map, tgfx[0].args, int, &tgfx[0].nargs, 0);
MODULE_PARM_DESC(map, "Describes first set of devices
(,,,..");
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/input/keyboard/amikbd.c
linux-2.6.20-rc6-mm3/drivers/input/keyboard/amikbd.c
--- linux-2.6.20-rc6-mm3.org/drivers/input/keyboard/amikbd.c2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/input/keyboard/amikbd.c2007-01-31
22:19:30.0 +0200
@@ -215,7 +215,7 @@ static int __init amikbd_init(void)
set_bit(i, amikbd_dev->keybit);
for (i = 0; i < MAX_NR_KEYMAPS; i++) {
- static u_short temp_map[NR_KEYS] __initdata;
+ static u_short temp_map[NR_KEYS] __initdata = {0};
if (!key_maps[i])
continue;
memset(temp_map, 0, sizeof(temp_map));
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 19/34] __initdata cleanup - xtensa
Trivial.
**NOT TESTED***
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/xtensa/kernel/setup.c
linux-2.6.20-rc6-mm3/arch/xtensa/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/xtensa/kernel/setup.c
+++ linux-2.6.20-rc6-mm3/arch/xtensa/kernel/setup.c
@@ -78,13 +78,13 @@ extern unsigned long loops_per_jiffy;
/* Command line specified as configuration option. */
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
#ifdef CONFIG_CMDLINE_BOOL
static char default_command_line[COMMAND_LINE_SIZE] __initdata =
CONFIG_CMDLINE;
#endif
-sysmem_info_t __initdata sysmem;
+sysmem_info_t __initdata sysmem = {0};
#ifdef CONFIG_BLK_DEV_INITRD
int initrd_is_mapped;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 34/34] __initdata cleanup - video
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/video/console/sticore.c
linux-2.6.20-rc6-mm3/drivers/video/console/sticore.c
--- linux-2.6.20-rc6-mm3.org/drivers/video/console/sticore.c
+++ linux-2.6.20-rc6-mm3/drivers/video/console/sticore.c
@@ -289,9 +289,9 @@ __setup("sti=", sti_setup);
static char __initdata *font_name[MAX_STI_ROMS] = { "VGA8x16", };
-static int __initdata font_index[MAX_STI_ROMS],
- font_height[MAX_STI_ROMS],
- font_width[MAX_STI_ROMS];
+static int __initdata font_index[MAX_STI_ROMS] = {0},
+ font_height[MAX_STI_ROMS] = {0},
+ font_width[MAX_STI_ROMS] = {0};
#ifndef MODULE
static int __init sti_font_setup(char *str)
{
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/video/skeletonfb.c
linux-2.6.20-rc6-mm3/drivers/video/skeletonfb.c
--- linux-2.6.20-rc6-mm3.org/drivers/video/skeletonfb.c
+++ linux-2.6.20-rc6-mm3/drivers/video/skeletonfb.c
@@ -123,7 +123,7 @@ static struct fb_info info;
* Each one represents the state of the hardware. Most hardware have
* just one hardware state. These here represent the default state(s).
*/
-static struct xxx_par __initdata current_par;
+static struct xxx_par __initdata current_par = {0};
int xxxfb_init(void);
int xxxfb_setup(char*);
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/video/stifb.c
linux-2.6.20-rc6-mm3/drivers/video/stifb.c
--- linux-2.6.20-rc6-mm3.org/drivers/video/stifb.c
+++ linux-2.6.20-rc6-mm3/drivers/video/stifb.c
@@ -111,7 +111,7 @@ struct stifb_info {
u32 pseudo_palette[16];
};
-static int __initdata stifb_bpp_pref[MAX_STI_ROMS];
+static int __initdata stifb_bpp_pref[MAX_STI_ROMS] = {0};
/* --- chipset specific functions -- */
@@ -1298,7 +1298,7 @@ out_err0:
return -ENXIO;
}
-static int stifb_disabled __initdata;
+static int stifb_disabled __initdata = 0;
int __init
stifb_setup(char *options);
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/video/vesafb.c
linux-2.6.20-rc6-mm3/drivers/video/vesafb.c
--- linux-2.6.20-rc6-mm3.org/drivers/video/vesafb.c
+++ linux-2.6.20-rc6-mm3/drivers/video/vesafb.c
@@ -49,8 +49,8 @@ static struct fb_fix_screeninfo vesafb_f
static int inverse__read_mostly;
static int mtrr __read_mostly; /* disable mtrr */
-static int vram_remap __initdata;/* Set amount of memory to be
used */
-static int vram_total __initdata;/* Set total amount of memory */
+static int vram_remap __initdata = 0;/* Set amount of memory
to be used */
+static int vram_total __initdata = 0;/* Set total amount of
memory */
static int pmi_setpal __read_mostly = 1; /* pmi for palette changes ???
*/
static int ypan __read_mostly; /* 0..nothing, 1..ypan,
2..ywrap */
static void (*pmi_start)(void) __read_mostly;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 33/34] __initdata cleanup - serial
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/serial/8250_early.c
linux-2.6.20-rc6-mm3/drivers/serial/8250_early.c
--- linux-2.6.20-rc6-mm3.org/drivers/serial/8250_early.c2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/serial/8250_early.c2007-01-31
22:19:30.0 +0200
@@ -41,8 +41,8 @@ struct early_uart_device {
unsigned int baud;
};
-static struct early_uart_device early_device __initdata;
-static int early_uart_registered __initdata;
+static struct early_uart_device early_device __initdata = 0;
+static int early_uart_registered __initdata = 0;
static unsigned int __init serial_in(struct uart_port *port, int offset)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 30/34] __initdata cleanup - parallel
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/parport/parport_gsc.c
linux-2.6.20-rc6-mm3/drivers/parport/parport_gsc.c
--- linux-2.6.20-rc6-mm3.org/drivers/parport/parport_gsc.c 2007-01-31
22:15:40.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/parport/parport_gsc.c 2007-01-31
22:19:30.0 +0200
@@ -350,7 +350,7 @@ struct parport *__devinit parport_gsc_pr
#define PARPORT_GSC_OFFSET 0x800
-static int __initdata parport_count;
+static int __initdata parport_count = 0;
static int __devinit parport_init_chip(struct parisc_device *dev)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 31/34] __initdata cleanup - pnp
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/pnp/pnpacpi/core.c
linux-2.6.20-rc6-mm3/drivers/pnp/pnpacpi/core.c
--- linux-2.6.20-rc6-mm3.org/drivers/pnp/pnpacpi/core.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/pnp/pnpacpi/core.c 2007-01-31
22:19:30.0 +0200
@@ -236,7 +236,7 @@ static acpi_status __init pnpacpi_add_de
return AE_OK;
}
-int pnpacpi_disabled __initdata;
+int pnpacpi_disabled __initdata = 0;
static int __init pnpacpi_init(void)
{
if (acpi_disabled || pnpacpi_disabled) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 29/34] __initdata cleanup - net
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/net/decnet/dn_dev.c
linux-2.6.20-rc6-mm3/net/decnet/dn_dev.c
--- linux-2.6.20-rc6-mm3.org/net/decnet/dn_dev.c2007-01-31
22:15:42.0 +0200
+++ linux-2.6.20-rc6-mm3/net/decnet/dn_dev.c2007-01-31 22:19:30.0
+0200
@@ -1461,7 +1461,7 @@ static struct rtnetlink_link dnet_rtnetl
};
-static int __initdata addr[2];
+static int __initdata addr[2] = {0, 0};
module_param_array(addr, int, NULL, 0444);
MODULE_PARM_DESC(addr, "The DECnet address of this machine: area,node");
diff -urNp linux-2.6.20-rc6-mm3.org/net/ipv4/route.c
linux-2.6.20-rc6-mm3/net/ipv4/route.c
--- linux-2.6.20-rc6-mm3.org/net/ipv4/route.c 2007-01-31 22:15:42.0
+0200
+++ linux-2.6.20-rc6-mm3/net/ipv4/route.c 2007-01-31 22:19:30.0
+0200
@@ -3103,7 +3103,7 @@ static int ip_rt_acct_read(char *buffer,
#endif /* CONFIG_PROC_FS */
#endif /* CONFIG_NET_CLS_ROUTE */
-static __initdata unsigned long rhash_entries;
+static __initdata unsigned long rhash_entries = 0l;
static int __init set_rhash_entries(char *str)
{
if (!str)
diff -urNp linux-2.6.20-rc6-mm3.org/net/ipv4/tcp.c
linux-2.6.20-rc6-mm3/net/ipv4/tcp.c
--- linux-2.6.20-rc6-mm3.org/net/ipv4/tcp.c 2007-01-31 22:15:42.0
+0200
+++ linux-2.6.20-rc6-mm3/net/ipv4/tcp.c 2007-01-31 22:19:30.0 +0200
@@ -2385,7 +2385,7 @@ EXPORT_SYMBOL(__tcp_put_md5sig_pool);
extern void __skb_cb_too_small_for_tcp(int, int);
extern struct tcp_congestion_ops tcp_reno;
-static __initdata unsigned long thash_entries;
+static __initdata unsigned long thash_entries = 0l;
static int __init set_thash_entries(char *str)
{
if (!str)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 28/34] __initdata cleanup - mtd
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/mtd/devices/block2mtd.c
linux-2.6.20-rc6-mm3/drivers/mtd/devices/block2mtd.c
--- linux-2.6.20-rc6-mm3.org/drivers/mtd/devices/block2mtd.c2007-01-31
22:15:40.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/mtd/devices/block2mtd.c2007-01-31
22:19:30.0 +0200
@@ -424,7 +424,7 @@ static inline void kill_final_newline(ch
#ifndef MODULE
static int block2mtd_init_called = 0;
-static __initdata char block2mtd_paramline[80 + 12]; /* 80 for device, 12 for
erase size */
+static __initdata char block2mtd_paramline[80 + 12] = {0}; /* 80 for device,
12 for erase size */
#endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 22/34] __initdata cleanup - fs
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/fs/dcache.c linux-2.6.20-rc6-mm3/fs/dcache.c
--- linux-2.6.20-rc6-mm3.org/fs/dcache.c2007-01-25 04:19:28.0
+0200
+++ linux-2.6.20-rc6-mm3/fs/dcache.c2007-01-31 22:19:30.0 +0200
@@ -2009,7 +2009,7 @@ ino_t find_inode_number(struct dentry *d
return ino;
}
-static __initdata unsigned long dhash_entries;
+static __initdata unsigned long dhash_entries = 0l;
static int __init set_dhash_entries(char *str)
{
if (!str)
diff -urNp linux-2.6.20-rc6-mm3.org/fs/inode.c linux-2.6.20-rc6-mm3/fs/inode.c
--- linux-2.6.20-rc6-mm3.org/fs/inode.c 2007-01-31 22:15:41.0 +0200
+++ linux-2.6.20-rc6-mm3/fs/inode.c 2007-01-31 22:19:30.0 +0200
@@ -1355,7 +1355,7 @@ void inode_double_unlock(struct inode *i
}
EXPORT_SYMBOL(inode_double_unlock);
-static __initdata unsigned long ihash_entries;
+static __initdata unsigned long ihash_entries = 0l;
static int __init set_ihash_entries(char *str)
{
if (!str)
diff -urNp linux-2.6.20-rc6-mm3.org/fs/nfs/nfsroot.c
linux-2.6.20-rc6-mm3/fs/nfs/nfsroot.c
--- linux-2.6.20-rc6-mm3.org/fs/nfs/nfsroot.c 2007-01-25 04:19:28.0
+0200
+++ linux-2.6.20-rc6-mm3/fs/nfs/nfsroot.c 2007-01-31 22:19:30.0
+0200
@@ -289,7 +289,7 @@ static int __init root_nfs_parse(char *n
*/
static int __init root_nfs_name(char *name)
{
- static char buf[NFS_MAXPATHLEN] __initdata;
+ static char buf[NFS_MAXPATHLEN] __initdata = { 0, };
char *cp;
/* Set some default values */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 27/34] __initdata cleanup - mm
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/mm/page_alloc.c
linux-2.6.20-rc6-mm3/mm/page_alloc.c
--- linux-2.6.20-rc6-mm3.org/mm/page_alloc.c2007-01-31 22:15:42.0
+0200
+++ linux-2.6.20-rc6-mm3/mm/page_alloc.c2007-01-31 22:19:30.0
+0200
@@ -101,9 +101,9 @@ static char * const zone_names[MAX_NR_ZO
int min_free_kbytes = 1024;
-unsigned long __meminitdata nr_kernel_pages;
-unsigned long __meminitdata nr_all_pages;
-static unsigned long __initdata dma_reserve;
+unsigned long __meminitdata nr_kernel_pages = 0l;
+unsigned long __meminitdata nr_all_pages = 0l;
+static unsigned long __initdata dma_reserve = 0l;
#ifdef CONFIG_ARCH_POPULATES_NODE_MAP
/*
@@ -126,13 +126,13 @@ static unsigned long __initdata dma_rese
#endif
#endif
- struct node_active_region __initdata early_node_map[MAX_ACTIVE_REGIONS];
- int __initdata nr_nodemap_entries;
- unsigned long __initdata arch_zone_lowest_possible_pfn[MAX_NR_ZONES];
- unsigned long __initdata arch_zone_highest_possible_pfn[MAX_NR_ZONES];
+ struct node_active_region __initdata early_node_map[MAX_ACTIVE_REGIONS] =
{{0}};
+ int __initdata nr_nodemap_entries = 0;
+ unsigned long __initdata arch_zone_lowest_possible_pfn[MAX_NR_ZONES] = {0};
+ unsigned long __initdata arch_zone_highest_possible_pfn[MAX_NR_ZONES] = {0};
#ifdef CONFIG_MEMORY_HOTPLUG_RESERVE
- unsigned long __initdata node_boundary_start_pfn[MAX_NUMNODES];
- unsigned long __initdata node_boundary_end_pfn[MAX_NUMNODES];
+ unsigned long __initdata node_boundary_start_pfn[MAX_NUMNODES] = {0};
+ unsigned long __initdata node_boundary_end_pfn[MAX_NUMNODES] = {0};
#endif /* CONFIG_MEMORY_HOTPLUG_RESERVE */
#endif /* CONFIG_ARCH_POPULATES_NODE_MAP */
@@ -1776,7 +1776,7 @@ static int __meminit build_zonelists_nod
#ifdef CONFIG_NUMA
#define MAX_NODE_LOAD (num_online_nodes())
-static int __meminitdata node_load[MAX_NUMNODES];
+static int __meminitdata node_load[MAX_NUMNODES] = {0};
/**
* find_next_best_node - find the next node that should appear in a given
node's fallback list
* @node: node whose fallback list we're appending
diff -urNp linux-2.6.20-rc6-mm3.org/mm/slab.c linux-2.6.20-rc6-mm3/mm/slab.c
--- linux-2.6.20-rc6-mm3.org/mm/slab.c 2007-01-31 22:15:42.0 +0200
+++ linux-2.6.20-rc6-mm3/mm/slab.c 2007-01-31 22:19:30.0 +0200
@@ -305,7 +305,7 @@ struct kmem_list3 {
* Need this for bootstrapping a per node allocator.
*/
#define NUM_INIT_LISTS (2 * MAX_NUMNODES + 1)
-struct kmem_list3 __initdata initkmem_list3[NUM_INIT_LISTS];
+struct kmem_list3 __initdata initkmem_list3[NUM_INIT_LISTS] = {{{0}}};
#defineCACHE_CACHE 0
#defineSIZE_AC 1
#defineSIZE_L3 (1 + MAX_NUMNODES)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 23/34] __initdata cleanup - ide
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/ide/ide.c
linux-2.6.20-rc6-mm3/drivers/ide/ide.c
--- linux-2.6.20-rc6-mm3.org/drivers/ide/ide.c 2007-01-31 22:15:39.0
+0200
+++ linux-2.6.20-rc6-mm3/drivers/ide/ide.c 2007-01-31 22:19:30.0
+0200
@@ -1483,27 +1483,27 @@ static int __init match_parm (char *s, c
}
#ifdef CONFIG_BLK_DEV_ALI14XX
-static int __initdata probe_ali14xx;
+static int __initdata probe_ali14xx = 0;
extern int ali14xx_init(void);
#endif
#ifdef CONFIG_BLK_DEV_UMC8672
-static int __initdata probe_umc8672;
+static int __initdata probe_umc8672 = 0;
extern int umc8672_init(void);
#endif
#ifdef CONFIG_BLK_DEV_DTC2278
-static int __initdata probe_dtc2278;
+static int __initdata probe_dtc2278 = 0;
extern int dtc2278_init(void);
#endif
#ifdef CONFIG_BLK_DEV_HT6560B
-static int __initdata probe_ht6560b;
+static int __initdata probe_ht6560b = 0;
extern int ht6560b_init(void);
#endif
#ifdef CONFIG_BLK_DEV_QD65XX
-static int __initdata probe_qd65xx;
+static int __initdata probe_qd65xx = 0;
extern int qd65xx_init(void);
#endif
-static int __initdata is_chipset_set[MAX_HWIFS];
+static int __initdata is_chipset_set[MAX_HWIFS] = {0};
/*
* ide_setup() gets called VERY EARLY during initialization,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 24/34] __initdata cleanup - init
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/init/do_mounts.c
linux-2.6.20-rc6-mm3/init/do_mounts.c
--- linux-2.6.20-rc6-mm3.org/init/do_mounts.c 2007-01-25 04:19:28.0
+0200
+++ linux-2.6.20-rc6-mm3/init/do_mounts.c 2007-01-31 22:19:30.0
+0200
@@ -18,11 +18,11 @@
extern int get_filesystem_list(char * buf);
-int __initdata rd_doload; /* 1 = load RAM disk, 0 = don't load */
+int __initdata rd_doload = 0; /* 1 = load RAM disk, 0 = don't load */
int root_mountflags = MS_RDONLY | MS_SILENT;
-char * __initdata root_device_name;
-static char __initdata saved_root_name[64];
+char * __initdata root_device_name = NULL;
+static char __initdata saved_root_name[64] = "";
dev_t ROOT_DEV;
@@ -214,21 +214,21 @@ static int __init root_dev_setup(char *l
__setup("root=", root_dev_setup);
-static char * __initdata root_mount_data;
+static char * __initdata root_mount_data = NULL;
static int __init root_data_setup(char *str)
{
root_mount_data = str;
return 1;
}
-static char * __initdata root_fs_names;
+static char * __initdata root_fs_names = NULL;
static int __init fs_names_setup(char *str)
{
root_fs_names = str;
return 1;
}
-static unsigned int __initdata root_delay;
+static unsigned int __initdata root_delay = 0;
static int __init root_delay_setup(char *str)
{
root_delay = simple_strtoul(str, NULL, 0);
diff -urNp linux-2.6.20-rc6-mm3.org/init/do_mounts_initrd.c
linux-2.6.20-rc6-mm3/init/do_mounts_initrd.c
--- linux-2.6.20-rc6-mm3.org/init/do_mounts_initrd.c2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/init/do_mounts_initrd.c2007-01-31
22:19:30.0 +0200
@@ -13,7 +13,7 @@
unsigned long initrd_start, initrd_end;
int initrd_below_start_ok;
unsigned int real_root_dev;/* do_proc_dointvec cannot handle kdev_t */
-static int __initdata old_fd, root_fd;
+static int __initdata old_fd = 0, root_fd = 0;
static int __initdata mount_initrd = 1;
static int __init no_initrd(char *str)
diff -urNp linux-2.6.20-rc6-mm3.org/init/do_mounts_md.c
linux-2.6.20-rc6-mm3/init/do_mounts_md.c
--- linux-2.6.20-rc6-mm3.org/init/do_mounts_md.c2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/init/do_mounts_md.c2007-01-31 22:19:30.0
+0200
@@ -12,7 +12,7 @@
* The code for that is here.
*/
-static int __initdata raid_noautodetect, raid_autopart;
+static int __initdata raid_noautodetect = 0, raid_autopart = 0;
static struct {
int minor;
@@ -20,9 +20,9 @@ static struct {
int level;
int chunk;
char *device_names;
-} md_setup_args[256] __initdata;
+} md_setup_args[256] __initdata = {{0}};
-static int md_setup_ents __initdata;
+static int md_setup_ents __initdata = 0;
extern int mdp_major;
/*
diff -urNp linux-2.6.20-rc6-mm3.org/init/initramfs.c
linux-2.6.20-rc6-mm3/init/initramfs.c
--- linux-2.6.20-rc6-mm3.org/init/initramfs.c 2007-01-31 22:15:41.0
+0200
+++ linux-2.6.20-rc6-mm3/init/initramfs.c 2007-01-31 22:19:30.0
+0200
@@ -7,7 +7,7 @@
#include
#include
-static __initdata char *message;
+static __initdata char *message = NULL;
static void __init error(char *x)
{
if (!message)
@@ -33,7 +33,7 @@ static __initdata struct hash {
mode_t mode;
struct hash *next;
char name[N_ALIGN(PATH_MAX)];
-} *head[32];
+} *head[32] = {0};
static inline int hash(int major, int minor, int ino)
{
@@ -84,12 +84,12 @@ static void __init free_hash(void)
/* cpio header parsing */
-static __initdata unsigned long ino, major, minor, nlink;
-static __initdata mode_t mode;
-static __initdata unsigned long body_len, name_len;
-static __initdata uid_t uid;
-static __initdata gid_t gid;
-static __initdata unsigned rdev;
+static __initdata unsigned long ino = 0l, major = 0l, minor = 0l, nlink = 0l;
+static __initdata mode_t mode = 0;
+static __initdata unsigned long body_len = 0l, name_len = 0l;
+static __initdata uid_t uid = 0;
+static __initdata gid_t gid = 0;
+static __initdata unsigned rdev = 0;
static void __init parse_header(char *s)
{
@@ -125,13 +125,13 @@ static __initdata enum state {
CopyFile,
GotSymlink,
Reset
-} state, next_state;
+} state = Start, next_state = Start;
-static __initdata char *victim;
-static __initdata unsigned count;
-static __initdata loff_t this_header, next_header;
+static __initdata char *victim = NULL;
+static __initdata unsigned count = 0;
+static __initdata loff_t this_header = 0, next_header = 0;
-static __initdata int dry_run;
+static __initdata int dry_run = 0;
static inline void eat(unsigned n)
{
@@ -140,9 +140,9 @@ static inline void eat(unsigned n)
count -= n;
}
-static __initdata char *collected;
-static __initdata int remains;
-static __initdata char *c
[PATCH 32/34] __initdata cleanup - scsi
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/scsi/aha1542.c
linux-2.6.20-rc6-mm3/drivers/scsi/aha1542.c
--- linux-2.6.20-rc6-mm3.org/drivers/scsi/aha1542.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/scsi/aha1542.c 2007-01-31 22:19:30.0
+0200
@@ -943,7 +943,7 @@ fail:
}
#ifndef MODULE
-static char *setup_str[MAXBOARDS] __initdata;
+static char *setup_str[MAXBOARDS] __initdata = {0};
static int setup_idx = 0;
static void __init aha1542_setup(char *str, int *ints)
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/scsi/pluto.c
linux-2.6.20-rc6-mm3/drivers/scsi/pluto.c
--- linux-2.6.20-rc6-mm3.org/drivers/scsi/pluto.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/scsi/pluto.c 2007-01-31 22:19:30.0
+0200
@@ -47,7 +47,7 @@ static struct ctrl_inquiry {
Scsi_Cmnd cmd;
char inquiry[256];
fc_channel *fc;
-} *fcs __initdata;
+} *fcs __initdata = NULL;
static int fcscount __initdata = 0;
static atomic_t fcss __initdata = ATOMIC_INIT(0);
DECLARE_MUTEX_LOCKED(fc_sem);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 26/34] __initdata cleanup - intel-rng
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/drivers/char/hw_random/intel-rng.c
linux-2.6.20-rc6-mm3/drivers/char/hw_random/intel-rng.c
--- linux-2.6.20-rc6-mm3.org/drivers/char/hw_random/intel-rng.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/drivers/char/hw_random/intel-rng.c 2007-01-31
22:19:30.0 +0200
@@ -143,7 +143,7 @@ static const struct pci_device_id pci_tb
};
MODULE_DEVICE_TABLE(pci, pci_tbl);
-static __initdata int no_fwh_detect;
+static __initdata int no_fwh_detect = 0;
module_param(no_fwh_detect, int, 0);
MODULE_PARM_DESC(no_fwh_detect, "Skip FWH detection:\n"
" positive value - skip if FWH space locked
read-only\n"
@@ -219,7 +219,7 @@ static struct hwrng intel_rng = {
#ifdef CONFIG_SMP
-static char __initdata waitflag;
+static char __initdata waitflag = 0;
static void __init intel_init_wait(void *unused)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 11/34] __initdata cleanup - parisc
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/parisc/kernel/setup.c
linux-2.6.20-rc6-mm3/arch/parisc/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/parisc/kernel/setup.c 2007-01-31
22:15:31.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/parisc/kernel/setup.c 2007-01-31
22:19:30.0 +0200
@@ -45,7 +45,7 @@
#include
#include
-char __initdata command_line[COMMAND_LINE_SIZE] __read_mostly;
+char __initdata command_line[COMMAND_LINE_SIZE] __read_mostly = "";
/* Intended for ccio/sba/cpu statistics under /proc/bus/{runway|gsc} */
struct proc_dir_entry * proc_runway_root __read_mostly = NULL;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 03/34] __initdata cleanup - avr32
Trivial.
**NOT TESTED***
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/avr32/boards/atstk1000/atstk1002.c
linux-2.6.20-rc6-mm3/arch/avr32/boards/atstk1000/atstk1002.c
--- linux-2.6.20-rc6-mm3.org/arch/avr32/boards/atstk1000/atstk1002.c
+++ linux-2.6.20-rc6-mm3/arch/avr32/boards/atstk1000/atstk1002.c
@@ -27,9 +27,9 @@ struct eth_addr {
u8 addr[6];
};
-static struct eth_addr __initdata hw_addr[2];
+static struct eth_addr __initdata hw_addr[2] = {{{0}}};
-static struct eth_platform_data __initdata eth_data[2];
+static struct eth_platform_data __initdata eth_data[2] = {{0}};
extern struct lcdc_platform_data atstk1000_fb0_data;
static struct spi_board_info spi_board_info[] __initdata = {
diff -urNp linux-2.6.20-rc6-mm3.org/arch/avr32/boards/atstk1000/setup.c
linux-2.6.20-rc6-mm3/arch/avr32/boards/atstk1000/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/avr32/boards/atstk1000/setup.c
+++ linux-2.6.20-rc6-mm3/arch/avr32/boards/atstk1000/setup.c
@@ -17,9 +17,9 @@
#include
/* Initialized by bootloader-specific startup code. */
-struct tag *bootloader_tags __initdata;
+struct tag *bootloader_tags __initdata = NULL;
-struct lcdc_platform_data __initdata atstk1000_fb0_data;
+struct lcdc_platform_data __initdata atstk1000_fb0_data = {0};
void __init board_setup_fbmem(unsigned long fbmem_start,
unsigned long fbmem_size)
diff -urNp linux-2.6.20-rc6-mm3.org/arch/avr32/kernel/setup.c
linux-2.6.20-rc6-mm3/arch/avr32/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/avr32/kernel/setup.c
+++ linux-2.6.20-rc6-mm3/arch/avr32/kernel/setup.c
@@ -44,13 +44,13 @@ struct avr32_cpuinfo boot_cpu_data = {
};
EXPORT_SYMBOL(boot_cpu_data);
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
/*
* Should be more than enough, but if you have a _really_ complex
* setup, you might need to increase the size of this...
*/
-static struct tag_mem_range __initdata mem_range_cache[32];
+static struct tag_mem_range __initdata mem_range_cache[32] = {{0}};
static unsigned mem_range_next_free;
/*
@@ -87,8 +87,8 @@ static struct resource mem_res[] = {
* Board-specific code may use these variables to set up platform data
* for the framebuffer driver if fbmem_size is nonzero.
*/
-static unsigned long __initdata fbmem_start;
-static unsigned long __initdata fbmem_size;
+static unsigned long __initdata fbmem_start = 0l;
+static unsigned long __initdata fbmem_size = 0l;
/*
* "fbmem=xxx[kKmM]" allocates the specified amount of boot memory for
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 15/34] __initdata cleanup - sh
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/sh/kernel/early_printk.c
linux-2.6.20-rc6-mm3/arch/sh/kernel/early_printk.c
--- linux-2.6.20-rc6-mm3.org/arch/sh/kernel/early_printk.c 2007-01-31
22:15:32.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/sh/kernel/early_printk.c 2007-01-31
22:19:30.0 +0200
@@ -163,7 +163,7 @@ static struct console *early_console =
#endif
;
-static int __initdata keep_early;
+static int __initdata keep_early = 0;
static int early_console_initialized;
int __init setup_early_printk(char *buf)
diff -urNp linux-2.6.20-rc6-mm3.org/arch/sh/kernel/timers/timer.c
linux-2.6.20-rc6-mm3/arch/sh/kernel/timers/timer.c
--- linux-2.6.20-rc6-mm3.org/arch/sh/kernel/timers/timer.c 2007-01-25
04:19:28.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/sh/kernel/timers/timer.c 2007-01-31
22:19:30.0 +0200
@@ -26,7 +26,7 @@ static struct sys_timer *sys_timers[] __
NULL,
};
-static char timer_override[10] __initdata;
+static char timer_override[10] __initdata = {0};
static int __init timer_setup(char *str)
{
if (str)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 02/34] __initdata cleanup - arm
Trivial.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc6-mm3.org/arch/arm/kernel/setup.c
linux-2.6.20-rc6-mm3/arch/arm/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/arm/kernel/setup.c2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/arm/kernel/setup.c2007-01-31
22:19:30.0 +0200
@@ -106,7 +106,7 @@ unsigned long phys_initrd_size __initdat
static struct meminfo meminfo __initdata = { 0, };
static const char *cpu_name;
static const char *machine_name;
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
static char default_command_line[COMMAND_LINE_SIZE] __initdata =
CONFIG_CMDLINE;
static union { char c[4]; unsigned long l; } endian_test __initdata = { { 'l',
'?', '?', 'b' } };
@@ -753,7 +753,7 @@ static struct init_tags {
{ 0, ATAG_NONE }
};
-static void (*init_machine)(void) __initdata;
+static void (*init_machine)(void) __initdata = NULL;
static int __init customize_machine(void)
{
diff -urNp linux-2.6.20-rc6-mm3.org/arch/arm26/kernel/setup.c
linux-2.6.20-rc6-mm3/arch/arm26/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/arm26/kernel/setup.c 2007-01-31
22:15:30.0 +0200
+++ linux-2.6.20-rc6-mm3/arch/arm26/kernel/setup.c 2007-01-31
22:19:30.0 +0200
@@ -80,7 +80,7 @@ unsigned long phys_initrd_size __initdat
static struct meminfo meminfo __initdata = { 0, };
static struct proc_info_item proc_info;
static const char *machine_name;
-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";
static char default_command_line[COMMAND_LINE_SIZE] __initdata =
CONFIG_CMDLINE;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: 2.6.20 -- Loads of section mismatches
On 2/5/07, Miles Lane <[EMAIL PROTECTED]> wrote: Are any of these worth fixing? I am preparing a patch for this. I will submit it soon. Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Dynamic kernel command-line - fixups
Remove in-source externs, linux/init.h is included in all cases.
This is a fixups for "Dynamic kernel command-line" patch.
It includes the ia64 fixup already added.
It also includes some uml __init fixups so that we can __initdata also its
command_line.
[[[ I will resubmit it to next mm version as you requested,
I don't mean to bother you. if you find this simple
enough you have an option to include this. ]]]
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.20-rc4-mm1.dyn-cmdline/arch/ia64/kernel/efi.c
linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/ia64/kernel/efi.c
--- linux-2.6.20-rc4-mm1.dyn-cmdline/arch/ia64/kernel/efi.c 2007-01-22
23:32:30.0 +0200
+++ linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/ia64/kernel/efi.c
2007-01-27 21:56:07.0 +0200
@@ -413,7 +413,6 @@ efi_init (void)
efi_char16_t *c16;
u64 efi_desc_size;
char *cp, vendor[100] = "unknown";
- extern char __initdata boot_command_line[];
int i;
/* it's too early to be able to use the standard kernel command line
support... */
diff -urNp linux-2.6.20-rc4-mm1.dyn-cmdline/arch/ia64/kernel/sal.c
linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/ia64/kernel/sal.c
--- linux-2.6.20-rc4-mm1.dyn-cmdline/arch/ia64/kernel/sal.c 2007-01-22
23:32:30.0 +0200
+++ linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/ia64/kernel/sal.c
2007-01-27 21:57:07.0 +0200
@@ -194,7 +194,6 @@ static void __init
chk_nointroute_opt(void)
{
char *cp;
- extern char __initdata boot_command_line[];
for (cp = boot_command_line; *cp; ) {
if (memcmp(cp, "nointroute", 10) == 0) {
diff -urNp linux-2.6.20-rc4-mm1.dyn-cmdline/arch/parisc/mm/init.c
linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/parisc/mm/init.c
--- linux-2.6.20-rc4-mm1.dyn-cmdline/arch/parisc/mm/init.c 2007-01-22
23:32:30.0 +0200
+++ linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/parisc/mm/init.c
2007-01-27 22:06:51.0 +0200
@@ -77,7 +77,6 @@ static void __init mem_limit_func(void)
{
char *cp, *end;
unsigned long limit;
- extern char __initdata boot_command_line[];
/* We need this before __setup() functions are called */
diff -urNp linux-2.6.20-rc4-mm1.dyn-cmdline/arch/um/include/user_util.h
linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/um/include/user_util.h
--- linux-2.6.20-rc4-mm1.dyn-cmdline/arch/um/include/user_util.h
2007-01-22 23:32:31.0 +0200
+++ linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/um/include/user_util.h
2007-01-27 21:57:41.0 +0200
@@ -38,8 +38,6 @@ extern unsigned long long highmem;
extern char host_info[];
-extern char __initdata boot_command_line[];
-
extern unsigned long _stext, _etext, _sdata, _edata, __bss_start, _end;
extern unsigned long _unprotected_end;
extern unsigned long brk_start;
diff -urNp linux-2.6.20-rc4-mm1.dyn-cmdline/arch/um/kernel/um_arch.c
linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/um/kernel/um_arch.c
--- linux-2.6.20-rc4-mm1.dyn-cmdline/arch/um/kernel/um_arch.c 2007-01-22
23:32:31.0 +0200
+++ linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/um/kernel/um_arch.c
2007-01-27 22:28:48.0 +0200
@@ -44,9 +44,9 @@
#define DEFAULT_COMMAND_LINE "root=98:0"
/* Changed in linux_main and setup_arch, which run before SMP is started */
-static char command_line[COMMAND_LINE_SIZE] = { 0 };
+static char __initdata command_line[COMMAND_LINE_SIZE] = { 0 };
-static void add_arg(char *arg)
+static void __init add_arg(char *arg)
{
if (strlen(command_line) + strlen(arg) + 1 > COMMAND_LINE_SIZE) {
printf("add_arg: Too many command line arguments!\n");
@@ -331,7 +331,7 @@ EXPORT_SYMBOL(end_iomem);
extern char __binary_start;
-int linux_main(int argc, char **argv)
+int __init linux_main(int argc, char **argv)
{
unsigned long avail, diff;
unsigned long virtmem_size, max_physmem;
diff -urNp linux-2.6.20-rc4-mm1.dyn-cmdline/arch/x86_64/kernel/head64.c
linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/x86_64/kernel/head64.c
--- linux-2.6.20-rc4-mm1.dyn-cmdline/arch/x86_64/kernel/head64.c
2007-01-22 23:32:31.0 +0200
+++ linux-2.6.20-rc4-mm1.dyn-cmdline.fixups/arch/x86_64/kernel/head64.c
2007-01-27 21:57:26.0 +0200
@@ -34,8 +34,6 @@ static void __init clear_bss(void)
#define OLD_CL_BASE_ADDR0x9
#define OLD_CL_OFFSET 0x90022
-extern char __initdata boot_command_line[];
-
static void __init copy_bootdata(char *real_mode_data)
{
int new_data;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: + dynamic-kernel-command-line-sparc64-fix.patch added to -mm tree
On 1/27/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
diff -puN drivers/sbus/char/openprom.c~dynamic-kernel-command-line-sparc64-fix
drivers/sbus/char/openprom.c
--- a/drivers/sbus/char/openprom.c~dynamic-kernel-command-line-sparc64-fix
+++ a/drivers/sbus/char/openprom.c
@@ -283,7 +283,7 @@ static int oprompath2node(void __user *a
static int opromgetbootargs(void __user *argp, struct openpromio *op, int
bufsize)
{
- char *buf = saved_command_line;
+ char *buf = boot_command_line;
int len = strlen(buf);
if (len > bufsize)
Hello Andrew,
I don't think this is correct.
The boot_command_line should only be used by init code.
Drivers should continue to use saved_command_line.
I don't know why saved_command_line cannot be resolved and
boot_command_line can be.
They are both located in linux/init.h
extern char __initdata boot_command_line[];
extern char *saved_command_line;
And the drivers/sbus/char/openprom.c do include it and I assume
__ASSEMBLY__ is not defined.
Best Regards,
Alon Bar-Lev.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 10/26] Dynamic kernel command-line - ia64
On 1/27/07, Andrew Morton <[EMAIL PROTECTED]> wrote: no no no no no no no. Just because some whacked-out weenie went and put extern declarations in .c files doesn't mean that we should copy them. It doesn't even compile. Sorry... I don't have all environments. Please. Go through the entire patchset, yank all those wrong private declarations of boot_command_line[] and put a *single, kernel-wide* declaration into a single, shared header file. I thought of this, while I was making the patch, I could not understand why the maintainer did not simply #include I can add this to any module which declares this by-itself but because I cannot test all arch, I am afraid it will cause more problems. Preparing a patch... :) Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/26] Dynamic kernel command-line - arm
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: > Rossell, I am confused. > There are many places in kernel where there is static __initdata > without initialization. Should all these be corrected too? Or your > comment applies only to none static global data? From what I remembered from previous mails on this list (which is what caused me to pick up on this), and what I later quoted from the gcc manual, all those places (where something is marked __initdata but is not explicitly initialised) would appear to be incorrect. So they should probably be fixed up. Well... A lot of places in the kernel needs to be fixed, regardless this patch... I can probably creat a patch for this as well... But since I don't an expert in this one... We need to be sure this should be fixed. Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/26] Dynamic kernel command-line - arm
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: > So it will be fine if I initialize it to "" and remove the static from > the your example? Why do you want to remove the static? Rossell, I am confused. There are many places in kernel where there is static __initdata without initialization. Should all these be corrected too? Or your comment applies only to none static global data? Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/26] Dynamic kernel command-line - arm
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote: Why do you want to remove the static? Since current design declare a buffer in main.c which is used by arch specific startup code, mainly setup.c. Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/26] Dynamic kernel command-line - arm
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote:
See Message-ID: <[EMAIL PROTECTED]> sent on
18 January in this thread. Such strings might as well be initialised to
an empty string.
So it will be fine if I initialize it to "" and remove the static from
the your example?
BTW: Is there a difference between "" and initialize it to {0}?
Thanks for you help!
Alon Bar-Lev.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/26] Dynamic kernel command-line - arm
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote:
which reflects precisely what I've been saying concerning the addition
of __initdata.
Great!
So what do you thing we should do?
Modify this:
char __initdata boot_command_line[COMMAND_LINE_SIZE];
Into:
char __initdata boot_command_line[COMMAND_LINE_SIZE] = {0};
Or:
static char __initdata _boot_command_line[COMMAND_LINE_SIZE];
char __initdata *boot_command_line = _boot_command_line;
Or any other option... I will glad to receive any convention you see right.
Best Regards,
Alon Bar-Lev.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/26] Dynamic kernel command-line - arm
On 1/22/07, Bernhard Walle <[EMAIL PROTECTED]> wrote: I refreshed the patches from Alon against 2.6.20-rc4-mm1. Or was I totally wrong? I don't know what is "Avoid top-posting? ;)" I hope it is a good thing... :) I will look at it again and submit it as requested. Thank you, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/26] Dynamic kernel command-line - arm
Hello Andrew, Can I do anything more in order to be closer to merge? Some general comments... or should I CC other people etc... I submitted this several times but got almost no architecture to ACK. I just don't know how we can progress with this issue... All we wanted is to break the 256 limit in x86... Best Regards, Alon Bar-Lev. On 1/22/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 18 Jan 2007 15:23:26 + Russell King <[EMAIL PROTECTED]> wrote: > On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote: > > Russell King wrote: > > > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: > > >> -static char command_line[COMMAND_LINE_SIZE]; > > >> +static char __initdata command_line[COMMAND_LINE_SIZE]; > > > > > > Uninitialised data is placed in the BSS. Adding __initdata to BSS > > > data causes grief. > > > > > > > Static variables are implicitly initialized to zero. Does that also > > count as initialization? > > No. As I say, they're placed in the BSS. The BSS is zeroed as part of > the C runtime initialisation. I don't understand the objection. With the above change, command_line[] will end up consuming COMMAND_LINE_SIZE bytes of .data.init and will be reliably initialized to all-zeros by the compiler (won't it?) > If you want to place a variable in a specific section, it must be > explicitly initialised. Eg, > > static char __initdata command_line[COMMAND_LINE_SIZE] = ""; > > However, there is a bigger question here: that is the tradeoff between > making this variable part of the on-disk kernel image, but throw away > the memory at runtime, or to leave it in the BSS where it will not be > part of the on-disk kernel image, but will not be thrown away at > runtime. Yes, it'll take some space in vmlinux. We could perhaps create a new __initbss to prevent that, I assume. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/26] Dynamic kernel command-line - arm
On 1/18/07, Bodo Eggert <[EMAIL PROTECTED]> wrote: Alon Bar-Lev <[EMAIL PROTECTED]> wrote: > On 1/18/07, Russell King <[EMAIL PROTECTED]> wrote: >> On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: >> > 2. Set command_line as __initdata. >> You can't. >> >> > -static char command_line[COMMAND_LINE_SIZE]; >> > +static char __initdata command_line[COMMAND_LINE_SIZE]; >> >> Uninitialised data is placed in the BSS. Adding __initdata to BSS >> data causes grief. > There are many places in kernel that uses __initdata for uninitialized > variables. > > For example: > static int __initdata is_chipset_set[MAX_HWIFS]; > > So all these current places are wrong? > If I initialize the data will it be OK. objdump -t vmlinux |grep -3 is_chipset_set suggests that it's placed into .init.data here, not into .bss. Russell ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/26] Dynamic kernel command-line - arm
On 1/18/07, Russell King <[EMAIL PROTECTED]> wrote: If you want to place a variable in a specific section, it must be explicitly initialised. Eg, static char __initdata command_line[COMMAND_LINE_SIZE] = ""; However, there is a bigger question here: that is the tradeoff between making this variable part of the on-disk kernel image, but throw away the memory at runtime, or to leave it in the BSS where it will not be part of the on-disk kernel image, but will not be thrown away at runtime. This patch is a result of trying to extend the kernel command-line size on x86 to more than 256 bytes. People requested to not allocate a larger buffers for small systems. I don't know who should decide the tradeoff... So what you basically say is that many modules need to be fixed... ./arch/avr32/boards/atstk1000/setup.c ./arch/frv/kernel/setup.c ./arch/i386/kernel/acpi/boot.c ./arch/i386/kernel/mpparse.c ./arch/i386/kernel/setup.c ./arch/ia64/kernel/setup.c Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/26] Dynamic kernel command-line - arm
On 1/18/07, Russell King <[EMAIL PROTECTED]> wrote: On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: > 2. Set command_line as __initdata. You can't. > -static char command_line[COMMAND_LINE_SIZE]; > +static char __initdata command_line[COMMAND_LINE_SIZE]; Uninitialised data is placed in the BSS. Adding __initdata to BSS data causes grief. Thanks for the reply! There are many places in kernel that uses __initdata for uninitialized variables. For example: ./drivers/ide/ide.c:static int __initdata probe_ali14xx; ./drivers/ide/ide.c:static int __initdata probe_umc8672; ./drivers/ide/ide.c:static int __initdata probe_dtc2278; ./drivers/ide/ide.c:static int __initdata probe_ht6560b; ./drivers/ide/ide.c:static int __initdata probe_qd65xx; static int __initdata is_chipset_set[MAX_HWIFS]; So all these current places are wrong? If I initialize the data will it be OK. Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: kernel cmdline: root=/dev/sdb1,/dev/sda1 "fallback"?
On 1/17/07, Tomasz Chmielewski <[EMAIL PROTECTED]> wrote: Another obstacle would be to place the initramfs image on the same partition as the kernel (normally, I dd kernel to /dev/mtd1). As far as I know you can embed the initramfs into the kernel image using CONFIG_INITRAMFS_SOURCE. http://www.timesys.com/timesource/initramfs.htm Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: kernel cmdline: root=/dev/sdb1,/dev/sda1 "fallback"?
On 1/17/07, Tomasz Chmielewski <[EMAIL PROTECTED]> wrote: Does this make sense? Why not add this logic into your initramfs? Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 25/26] Dynamic kernel command-line - x86_64
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/include/asm-x86_64/bootsetup.h
linux-2.6.19/include/asm-x86_64/bootsetup.h
--- linux-2.6.19.org/include/asm-x86_64/bootsetup.h 2006-11-29
23:57:37.0 +0200
+++ linux-2.6.19/include/asm-x86_64/bootsetup.h 2006-12-02 11:31:33.0
+0200
@@ -31,7 +31,7 @@ extern char x86_boot_params[BOOT_PARAM_S
#define EDD_MBR_SIG_NR (*(unsigned char *) (PARAM+EDD_MBR_SIG_NR_BUF))
#define EDD_MBR_SIGNATURE ((unsigned int *) (PARAM+EDD_MBR_SIG_BUF))
#define EDD_BUF ((struct edd_info *) (PARAM+EDDBUF))
-#define COMMAND_LINE saved_command_line
+#define COMMAND_LINE boot_command_line
#define RAMDISK_IMAGE_START_MASK 0x07FF
#define RAMDISK_PROMPT_FLAG0x8000
diff -urNp linux-2.6.19.org/arch/x86_64/kernel/head64.c
linux-2.6.19/arch/x86_64/kernel/head64.c
--- linux-2.6.19.org/arch/x86_64/kernel/head64.c2006-11-29
23:57:37.0 +0200
+++ linux-2.6.19/arch/x86_64/kernel/head64.c2006-12-02 11:31:33.0
+0200
@@ -34,7 +34,7 @@ static void __init clear_bss(void)
#define OLD_CL_BASE_ADDR0x9
#define OLD_CL_OFFSET 0x90022
-extern char saved_command_line[];
+extern char __initdata boot_command_line[];
static void __init copy_bootdata(char *real_mode_data)
{
@@ -50,7 +50,7 @@ static void __init copy_bootdata(char *r
new_data = OLD_CL_BASE_ADDR + * (u16 *) OLD_CL_OFFSET;
}
command_line = (char *) ((u64)(new_data));
- memcpy(saved_command_line, command_line, COMMAND_LINE_SIZE);
+ memcpy(boot_command_line, command_line, COMMAND_LINE_SIZE);
}
void __init x86_64_start_kernel(char * real_mode_data)
diff -urNp linux-2.6.19.org/arch/x86_64/kernel/setup.c
linux-2.6.19/arch/x86_64/kernel/setup.c
--- linux-2.6.19.org/arch/x86_64/kernel/setup.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/x86_64/kernel/setup.c 2006-12-02 11:31:33.0
+0200
@@ -100,7 +100,7 @@ EXPORT_SYMBOL_GPL(edid_info);
extern int root_mountflags;
-char command_line[COMMAND_LINE_SIZE];
+char __initdata command_line[COMMAND_LINE_SIZE];
struct resource standard_io_resources[] = {
{ .name = "dma1", .start = 0x00, .end = 0x1f,
@@ -343,7 +343,7 @@ static void discover_ebda(void)
void __init setup_arch(char **cmdline_p)
{
- printk(KERN_INFO "Command line: %s\n", saved_command_line);
+ printk(KERN_INFO "Command line: %s\n", boot_command_line);
ROOT_DEV = old_decode_dev(ORIG_ROOT_DEV);
screen_info = SCREEN_INFO;
@@ -373,7 +373,7 @@ void __init setup_arch(char **cmdline_p)
early_identify_cpu(&boot_cpu_data);
- strlcpy(command_line, saved_command_line, COMMAND_LINE_SIZE);
+ strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
*cmdline_p = command_line;
parse_early_param();
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 09/26] Dynamic kernel command-line - i386
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/i386/kernel/head.S
linux-2.6.19/arch/i386/kernel/head.S
--- linux-2.6.19.org/arch/i386/kernel/head.S2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/i386/kernel/head.S2006-12-02 11:31:32.0
+0200
@@ -97,7 +97,7 @@ ENTRY(startup_32)
movzwl OLD_CL_OFFSET,%esi
addl $(OLD_CL_BASE_ADDR),%esi
2:
- movl $(saved_command_line - __PAGE_OFFSET),%edi
+ movl $(boot_command_line - __PAGE_OFFSET),%edi
movl $(COMMAND_LINE_SIZE/4),%ecx
rep
movsl
diff -urNp linux-2.6.19.org/arch/i386/kernel/setup.c
linux-2.6.19/arch/i386/kernel/setup.c
--- linux-2.6.19.org/arch/i386/kernel/setup.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/i386/kernel/setup.c 2006-12-02 11:31:32.0
+0200
@@ -145,7 +145,7 @@ unsigned long saved_videomode;
#define RAMDISK_PROMPT_FLAG0x8000
#define RAMDISK_LOAD_FLAG 0x4000
-static char command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE];
unsigned char __initdata boot_params[PARAM_SIZE];
@@ -1405,7 +1405,7 @@ void __init setup_arch(char **cmdline_p)
print_memory_map("user");
}
- strlcpy(command_line, saved_command_line, COMMAND_LINE_SIZE);
+ strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
*cmdline_p = command_line;
max_low_pfn = setup_memory();
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 21/26] Dynamic kernel command-line - sparc
Rename saved_command_line into boot_command_line. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.19.org/arch/sparc/kernel/setup.c linux-2.6.19/arch/sparc/kernel/setup.c --- linux-2.6.19.org/arch/sparc/kernel/setup.c 2006-11-29 23:57:37.0 +0200 +++ linux-2.6.19/arch/sparc/kernel/setup.c 2006-12-02 11:31:33.0 +0200 @@ -246,7 +246,7 @@ void __init setup_arch(char **cmdline_p) /* Initialize PROM console and command line. */ *cmdline_p = prom_getbootargs(); - strcpy(saved_command_line, *cmdline_p); + strcpy(boot_command_line, *cmdline_p); /* Set sparc_cpu_model */ sparc_cpu_model = sun_unknown; diff -urNp linux-2.6.19.org/arch/sparc/kernel/sparc_ksyms.c linux-2.6.19/arch/sparc/kernel/sparc_ksyms.c --- linux-2.6.19.org/arch/sparc/kernel/sparc_ksyms.c2006-11-29 23:57:37.0 +0200 +++ linux-2.6.19/arch/sparc/kernel/sparc_ksyms.c2006-12-02 11:31:33.0 +0200 @@ -237,7 +237,7 @@ EXPORT_SYMBOL(prom_getproplen); EXPORT_SYMBOL(prom_getproperty); EXPORT_SYMBOL(prom_node_has_property); EXPORT_SYMBOL(prom_setprop); -EXPORT_SYMBOL(saved_command_line); +EXPORT_SYMBOL(boot_command_line); EXPORT_SYMBOL(prom_apply_obio_ranges); EXPORT_SYMBOL(prom_feval); EXPORT_SYMBOL(prom_getbool); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 02/26] Dynamic kernel command-line - alpha
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/alpha/kernel/setup.c
linux-2.6.19/arch/alpha/kernel/setup.c
--- linux-2.6.19.org/arch/alpha/kernel/setup.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/alpha/kernel/setup.c 2006-12-02 11:31:32.0
+0200
@@ -122,7 +122,7 @@ static void get_sysnames(unsigned long,
char **, char **);
static void determine_cpu_caches (unsigned int);
-static char command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE];
/*
* The format of "screen_info" is strange, and due to early
@@ -547,7 +547,7 @@ setup_arch(char **cmdline_p)
} else {
strlcpy(command_line, COMMAND_LINE, sizeof command_line);
}
- strcpy(saved_command_line, command_line);
+ strcpy(boot_command_line, command_line);
*cmdline_p = command_line;
/*
@@ -589,7 +589,7 @@ setup_arch(char **cmdline_p)
}
/* Replace the command line, now that we've killed it with strsep. */
- strcpy(command_line, saved_command_line);
+ strcpy(command_line, boot_command_line);
/* If we want SRM console printk echoing early, do it now. */
if (alpha_using_srm && srmcons_output) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 08/26] Dynamic kernel command-line - h8300
1. Rename saved_command_line into boot_command_line. 2. Set command_line as __initdata. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.19.org/arch/h8300/kernel/setup.c linux-2.6.19/arch/h8300/kernel/setup.c --- linux-2.6.19.org/arch/h8300/kernel/setup.c 2006-11-29 23:57:37.0 +0200 +++ linux-2.6.19/arch/h8300/kernel/setup.c 2006-12-02 11:31:32.0 +0200 @@ -54,7 +54,7 @@ unsigned long rom_length; unsigned long memory_start; unsigned long memory_end; -char command_line[COMMAND_LINE_SIZE]; +char __initdata command_line[COMMAND_LINE_SIZE]; extern int _stext, _etext, _sdata, _edata, _sbss, _ebss, _end; extern int _ramstart, _ramend; @@ -154,8 +154,8 @@ void __init setup_arch(char **cmdline_p) #endif /* Keep a copy of command line */ *cmdline_p = &command_line[0]; - memcpy(saved_command_line, command_line, COMMAND_LINE_SIZE); - saved_command_line[COMMAND_LINE_SIZE-1] = 0; + memcpy(boot_command_line, command_line, COMMAND_LINE_SIZE); + boot_command_line[COMMAND_LINE_SIZE-1] = 0; #ifdef DEBUG if (strlen(*cmdline_p)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 07/26] Dynamic kernel command-line - frv
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/frv/kernel/setup.c
linux-2.6.19/arch/frv/kernel/setup.c
--- linux-2.6.19.org/arch/frv/kernel/setup.c2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/frv/kernel/setup.c2006-12-02 11:31:32.0
+0200
@@ -110,7 +110,7 @@ unsigned long __initdata num_mappedpages
struct cpuinfo_frv __nongprelbss boot_cpu_data;
-char command_line[COMMAND_LINE_SIZE];
+char __initdata command_line[COMMAND_LINE_SIZE];
char __initdata redboot_command_line[COMMAND_LINE_SIZE];
#ifdef CONFIG_PM
@@ -762,7 +762,7 @@ void __init setup_arch(char **cmdline_p)
printk("uClinux FR-V port done by Red Hat Inc <[EMAIL PROTECTED]>\n");
#endif
- memcpy(saved_command_line, redboot_command_line, COMMAND_LINE_SIZE);
+ memcpy(boot_command_line, redboot_command_line, COMMAND_LINE_SIZE);
determine_cpu();
determine_clocks(1);
@@ -803,7 +803,7 @@ void __init setup_arch(char **cmdline_p)
#endif
/* deal with the command line - RedBoot may have passed one to the
kernel */
- memcpy(command_line, saved_command_line, sizeof(command_line));
+ memcpy(command_line, boot_command_line, sizeof(command_line));
*cmdline_p = &command_line[0];
parse_cmdline_early(command_line);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 13/26] Dynamic kernel command-line - m68knommu
1. Rename saved_command_line into boot_command_line. 2. Set command_line as __initdata. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.19.org/arch/m68knommu/kernel/setup.c linux-2.6.19/arch/m68knommu/kernel/setup.c --- linux-2.6.19.org/arch/m68knommu/kernel/setup.c 2006-11-29 23:57:37.0 +0200 +++ linux-2.6.19/arch/m68knommu/kernel/setup.c 2006-12-02 11:31:32.0 +0200 @@ -47,7 +47,7 @@ unsigned long memory_end; EXPORT_SYMBOL(memory_start); EXPORT_SYMBOL(memory_end); -char command_line[COMMAND_LINE_SIZE]; +char __initdata command_line[COMMAND_LINE_SIZE]; /* setup some dummy routines */ static void dummy_waitbut(void) @@ -234,8 +234,8 @@ void setup_arch(char **cmdline_p) /* Keep a copy of command line */ *cmdline_p = &command_line[0]; - memcpy(saved_command_line, command_line, COMMAND_LINE_SIZE); - saved_command_line[COMMAND_LINE_SIZE-1] = 0; + memcpy(boot_command_line, command_line, COMMAND_LINE_SIZE); + boot_command_line[COMMAND_LINE_SIZE-1] = 0; #ifdef DEBUG if (strlen(*cmdline_p)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 20/26] Dynamic kernel command-line - sh64
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Acked-by: Paul Mundt <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/sh64/kernel/setup.c
linux-2.6.19/arch/sh64/kernel/setup.c
--- linux-2.6.19.org/arch/sh64/kernel/setup.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/sh64/kernel/setup.c 2006-12-02 11:31:33.0
+0200
@@ -83,7 +83,7 @@ extern int sh64_tlb_init(void);
#define RAMDISK_PROMPT_FLAG0x8000
#define RAMDISK_LOAD_FLAG 0x4000
-static char command_line[COMMAND_LINE_SIZE] = { 0, };
+static char __initdata command_line[COMMAND_LINE_SIZE] = { 0, };
unsigned long long memory_start = CONFIG_MEMORY_START;
unsigned long long memory_end = CONFIG_MEMORY_START +
(CONFIG_MEMORY_SIZE_IN_MB * 1024 * 1024);
@@ -95,8 +95,8 @@ static inline void parse_mem_cmdline (ch
int len = 0;
/* Save unparsed command line copy for /proc/cmdline */
- memcpy(saved_command_line, COMMAND_LINE, COMMAND_LINE_SIZE);
- saved_command_line[COMMAND_LINE_SIZE-1] = '\0';
+ memcpy(boot_command_line, COMMAND_LINE, COMMAND_LINE_SIZE);
+ boot_command_line[COMMAND_LINE_SIZE-1] = '\0';
for (;;) {
/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 12/26] Dynamic kernel command-line - m68k
Rename saved_command_line into boot_command_line. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.19.org/arch/m68k/kernel/setup.c linux-2.6.19/arch/m68k/kernel/setup.c --- linux-2.6.19.org/arch/m68k/kernel/setup.c 2006-11-29 23:57:37.0 +0200 +++ linux-2.6.19/arch/m68k/kernel/setup.c 2006-12-02 11:31:32.0 +0200 @@ -256,7 +256,7 @@ void __init setup_arch(char **cmdline_p) init_mm.brk = (unsigned long) &_end; *cmdline_p = m68k_command_line; - memcpy(saved_command_line, *cmdline_p, CL_SIZE); + memcpy(boot_command_line, *cmdline_p, CL_SIZE); /* Parse the command line for arch-specific options. * For the m68k, this is currently only "debug=xxx" to enable printing - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 19/26] Dynamic kernel command-line - sh
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
Acked-by: Paul Mundt <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/sh/kernel/setup.c
linux-2.6.19/arch/sh/kernel/setup.c
--- linux-2.6.19.org/arch/sh/kernel/setup.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/sh/kernel/setup.c 2006-12-02 11:31:33.0 +0200
@@ -75,7 +75,7 @@ static struct sh_machine_vector* __init
#define RAMDISK_PROMPT_FLAG0x8000
#define RAMDISK_LOAD_FLAG 0x4000
-static char command_line[COMMAND_LINE_SIZE] = { 0, };
+static char __initdata command_line[COMMAND_LINE_SIZE] = { 0, };
static struct resource code_resource = { .name = "Kernel code", };
static struct resource data_resource = { .name = "Kernel data", };
@@ -91,8 +91,8 @@ static inline void parse_cmdline (char *
int len = 0;
/* Save unparsed command line copy for /proc/cmdline */
- memcpy(saved_command_line, COMMAND_LINE, COMMAND_LINE_SIZE);
- saved_command_line[COMMAND_LINE_SIZE-1] = '\0';
+ memcpy(boot_command_line, COMMAND_LINE, COMMAND_LINE_SIZE);
+ boot_command_line[COMMAND_LINE_SIZE-1] = '\0';
memory_start = (unsigned long)PAGE_OFFSET+__MEMORY_START;
memory_end = memory_start + __MEMORY_SIZE;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 06/26] Dynamic kernel command-line - cris
1. Rename saved_command_line into boot_command_line.
2. Set cris_command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/cris/kernel/setup.c
linux-2.6.19/arch/cris/kernel/setup.c
--- linux-2.6.19.org/arch/cris/kernel/setup.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/cris/kernel/setup.c 2006-12-02 11:31:32.0
+0200
@@ -29,7 +29,7 @@ struct screen_info screen_info;
extern int root_mountflags;
extern char _etext, _edata, _end;
-char cris_command_line[COMMAND_LINE_SIZE] = { 0, };
+char __initdata cris_command_line[COMMAND_LINE_SIZE] = { 0, };
extern const unsigned long text_start, edata; /* set by the linker script */
extern unsigned long dram_start, dram_end;
@@ -153,8 +153,8 @@ setup_arch(char **cmdline_p)
#endif
/* Save command line for future references. */
- memcpy(saved_command_line, cris_command_line, COMMAND_LINE_SIZE);
- saved_command_line[COMMAND_LINE_SIZE - 1] = '\0';
+ memcpy(boot_command_line, cris_command_line, COMMAND_LINE_SIZE);
+ boot_command_line[COMMAND_LINE_SIZE - 1] = '\0';
/* give credit for the CRIS port */
show_etrax_copyright();
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 24/26] Dynamic kernel command-line - v850
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/v850/kernel/setup.c
linux-2.6.19/arch/v850/kernel/setup.c
--- linux-2.6.19.org/arch/v850/kernel/setup.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/v850/kernel/setup.c 2006-12-02 11:31:33.0
+0200
@@ -42,7 +42,7 @@ extern char _root_fs_image_start __attri
extern char _root_fs_image_end __attribute__ ((__weak__));
-char command_line[COMMAND_LINE_SIZE];
+char __initdata command_line[COMMAND_LINE_SIZE];
/* Memory not used by the kernel. */
static unsigned long total_ram_pages;
@@ -64,8 +64,8 @@ void __init setup_arch (char **cmdline)
{
/* Keep a copy of command line */
*cmdline = command_line;
- memcpy (saved_command_line, command_line, COMMAND_LINE_SIZE);
- saved_command_line[COMMAND_LINE_SIZE - 1] = '\0';
+ memcpy (boot_command_line, command_line, COMMAND_LINE_SIZE);
+ boot_command_line[COMMAND_LINE_SIZE - 1] = '\0';
console_verbose ();
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 26/26] Dynamic kernel command-line - xtensa
1. Rename saved_command_line into boot_command_line. 2. Set command_line as __initdata. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.19.org/arch/xtensa/kernel/setup.c linux-2.6.19/arch/xtensa/kernel/setup.c --- linux-2.6.19.org/arch/xtensa/kernel/setup.c 2006-11-29 23:57:37.0 +0200 +++ linux-2.6.19/arch/xtensa/kernel/setup.c 2006-12-02 11:31:33.0 +0200 @@ -80,7 +80,7 @@ extern unsigned long loops_per_jiffy; /* Command line specified as configuration option. */ -static char command_line[COMMAND_LINE_SIZE]; +static char __initdata command_line[COMMAND_LINE_SIZE]; #ifdef CONFIG_CMDLINE_BOOL static char default_command_line[COMMAND_LINE_SIZE] __initdata = CONFIG_CMDLINE; @@ -255,8 +255,8 @@ void __init setup_arch(char **cmdline_p) extern int mem_reserve(unsigned long, unsigned long, int); extern void bootmem_init(void); - memcpy(saved_command_line, command_line, COMMAND_LINE_SIZE); - saved_command_line[COMMAND_LINE_SIZE-1] = '\0'; + memcpy(boot_command_line, command_line, COMMAND_LINE_SIZE); + boot_command_line[COMMAND_LINE_SIZE-1] = '\0'; *cmdline_p = command_line; /* Reserve some memory regions */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 14/26] Dynamic kernel command-line - mips
Rename saved_command_line into boot_command_line. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.19.org/arch/mips/kernel/setup.c linux-2.6.19/arch/mips/kernel/setup.c --- linux-2.6.19.org/arch/mips/kernel/setup.c 2006-11-29 23:57:37.0 +0200 +++ linux-2.6.19/arch/mips/kernel/setup.c 2006-12-02 11:31:33.0 +0200 @@ -409,7 +409,7 @@ static void __init arch_mem_init(char ** print_memory_map(); strlcpy(command_line, arcs_cmdline, sizeof(command_line)); - strlcpy(saved_command_line, command_line, COMMAND_LINE_SIZE); + strlcpy(boot_command_line, command_line, COMMAND_LINE_SIZE); *cmdline_p = command_line; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 03/26] Dynamic kernel command-line - arm
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/arm/kernel/setup.c
linux-2.6.19/arch/arm/kernel/setup.c
--- linux-2.6.19.org/arch/arm/kernel/setup.c2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/arm/kernel/setup.c2006-12-02 11:31:32.0
+0200
@@ -106,7 +106,7 @@ unsigned long phys_initrd_size __initdat
static struct meminfo meminfo __initdata = { 0, };
static const char *cpu_name;
static const char *machine_name;
-static char command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE];
static char default_command_line[COMMAND_LINE_SIZE] __initdata =
CONFIG_CMDLINE;
static union { char c[4]; unsigned long l; } endian_test __initdata = { { 'l',
'?', '?', 'b' } };
@@ -806,8 +806,8 @@ void __init setup_arch(char **cmdline_p)
init_mm.end_data = (unsigned long) &_edata;
init_mm.brk= (unsigned long) &_end;
- memcpy(saved_command_line, from, COMMAND_LINE_SIZE);
- saved_command_line[COMMAND_LINE_SIZE-1] = '\0';
+ memcpy(boot_command_line, from, COMMAND_LINE_SIZE);
+ boot_command_line[COMMAND_LINE_SIZE-1] = '\0';
parse_cmdline(cmdline_p, from);
paging_init(&meminfo, mdesc);
request_standard_resources(&meminfo, mdesc);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 10/26] Dynamic kernel command-line - ia64
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/ia64/kernel/efi.c
linux-2.6.19/arch/ia64/kernel/efi.c
--- linux-2.6.19.org/arch/ia64/kernel/efi.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/ia64/kernel/efi.c 2006-12-02 11:31:32.0 +0200
@@ -412,11 +412,11 @@ efi_init (void)
efi_char16_t *c16;
u64 efi_desc_size;
char *cp, vendor[100] = "unknown";
- extern char saved_command_line[];
+ extern char __initdata boot_command_line[];
int i;
/* it's too early to be able to use the standard kernel command line
support... */
- for (cp = saved_command_line; *cp; ) {
+ for (cp = boot_command_line; *cp; ) {
if (memcmp(cp, "mem=", 4) == 0) {
mem_limit = memparse(cp + 4, &cp);
} else if (memcmp(cp, "max_addr=", 9) == 0) {
diff -urNp linux-2.6.19.org/arch/ia64/kernel/sal.c
linux-2.6.19/arch/ia64/kernel/sal.c
--- linux-2.6.19.org/arch/ia64/kernel/sal.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/ia64/kernel/sal.c 2006-12-02 11:31:32.0 +0200
@@ -194,9 +194,9 @@ static void __init
chk_nointroute_opt(void)
{
char *cp;
- extern char saved_command_line[];
+ extern char __initdata boot_command_line[];
- for (cp = saved_command_line; *cp; ) {
+ for (cp = boot_command_line; *cp; ) {
if (memcmp(cp, "nointroute", 10) == 0) {
no_int_routing = 1;
printk ("no_int_routing on\n");
diff -urNp linux-2.6.19.org/arch/ia64/kernel/setup.c
linux-2.6.19/arch/ia64/kernel/setup.c
--- linux-2.6.19.org/arch/ia64/kernel/setup.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/ia64/kernel/setup.c 2006-12-02 11:31:32.0
+0200
@@ -404,7 +404,7 @@ setup_arch (char **cmdline_p)
ia64_patch_vtop((u64) __start___vtop_patchlist, (u64)
__end___vtop_patchlist);
*cmdline_p = __va(ia64_boot_param->command_line);
- strlcpy(saved_command_line, *cmdline_p, COMMAND_LINE_SIZE);
+ strlcpy(boot_command_line, *cmdline_p, COMMAND_LINE_SIZE);
efi_init();
io_port_init();
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 18/26] Dynamic kernel command-line - s390
Rename saved_command_line into boot_command_line. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.19.org/arch/s390/kernel/setup.c linux-2.6.19/arch/s390/kernel/setup.c --- linux-2.6.19.org/arch/s390/kernel/setup.c 2006-11-29 23:57:37.0 +0200 +++ linux-2.6.19/arch/s390/kernel/setup.c 2006-12-02 11:31:33.0 +0200 @@ -633,7 +633,7 @@ setup_arch(char **cmdline_p) #endif /* CONFIG_64BIT */ /* Save unparsed command line copy for /proc/cmdline */ - strlcpy(saved_command_line, COMMAND_LINE, COMMAND_LINE_SIZE); + strlcpy(boot_command_line, COMMAND_LINE, COMMAND_LINE_SIZE); *cmdline_p = COMMAND_LINE; *(*cmdline_p + COMMAND_LINE_SIZE - 1) = '\0'; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 23/26] Dynamic kernel command-line - um
1. Rename saved_command_line into boot_command_line. 2. Set command_line as __initdata. Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.19.org/arch/um/include/user_util.h linux-2.6.19/arch/um/include/user_util.h --- linux-2.6.19.org/arch/um/include/user_util.h2006-11-29 23:57:37.0 +0200 +++ linux-2.6.19/arch/um/include/user_util.h2006-12-02 11:31:33.0 +0200 @@ -38,7 +38,7 @@ extern unsigned long long highmem; extern char host_info[]; -extern char saved_command_line[]; +extern char __initdata boot_command_line[]; extern unsigned long _stext, _etext, _sdata, _edata, __bss_start, _end; extern unsigned long _unprotected_end; diff -urNp linux-2.6.19.org/arch/um/kernel/um_arch.c linux-2.6.19/arch/um/kernel/um_arch.c --- linux-2.6.19.org/arch/um/kernel/um_arch.c 2006-11-29 23:57:37.0 +0200 +++ linux-2.6.19/arch/um/kernel/um_arch.c 2006-12-02 11:31:33.0 +0200 @@ -482,7 +482,7 @@ void __init setup_arch(char **cmdline_p) atomic_notifier_chain_register(&panic_notifier_list, &panic_exit_notifier); paging_init(); -strlcpy(saved_command_line, command_line, COMMAND_LINE_SIZE); + strlcpy(boot_command_line, command_line, COMMAND_LINE_SIZE); *cmdline_p = command_line; setup_hostinfo(); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 04/26] Dynamic kernel command-line - arm26
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/arm26/kernel/setup.c
linux-2.6.19/arch/arm26/kernel/setup.c
--- linux-2.6.19.org/arch/arm26/kernel/setup.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/arm26/kernel/setup.c 2006-12-02 11:31:32.0
+0200
@@ -80,7 +80,7 @@ unsigned long phys_initrd_size __initdat
static struct meminfo meminfo __initdata = { 0, };
static struct proc_info_item proc_info;
static const char *machine_name;
-static char command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE];
static char default_command_line[COMMAND_LINE_SIZE] __initdata =
CONFIG_CMDLINE;
@@ -492,8 +492,8 @@ void __init setup_arch(char **cmdline_p)
init_mm.end_data = (unsigned long) &_edata;
init_mm.brk= (unsigned long) &_end;
- memcpy(saved_command_line, from, COMMAND_LINE_SIZE);
- saved_command_line[COMMAND_LINE_SIZE-1] = '\0';
+ memcpy(boot_command_line, from, COMMAND_LINE_SIZE);
+ boot_command_line[COMMAND_LINE_SIZE-1] = '\0';
parse_cmdline(&meminfo, cmdline_p, from);
bootmem_init(&meminfo);
paging_init(&meminfo);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 15/26] Dynamic kernel command-line - parisc
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/parisc/kernel/setup.c
linux-2.6.19/arch/parisc/kernel/setup.c
--- linux-2.6.19.org/arch/parisc/kernel/setup.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/parisc/kernel/setup.c 2006-12-02 11:31:33.0
+0200
@@ -45,7 +45,7 @@
#include
#include
-char command_line[COMMAND_LINE_SIZE] __read_mostly;
+char __initdata command_line[COMMAND_LINE_SIZE] __read_mostly;
/* Intended for ccio/sba/cpu statistics under /proc/bus/{runway|gsc} */
struct proc_dir_entry * proc_runway_root __read_mostly = NULL;
@@ -71,9 +71,9 @@ void __init setup_cmdline(char **cmdline
/* boot_args[0] is free-mem start, boot_args[1] is ptr to command line
*/
if (boot_args[0] < 64) {
/* called from hpux boot loader */
- saved_command_line[0] = '\0';
+ boot_command_line[0] = '\0';
} else {
- strcpy(saved_command_line, (char *)__va(boot_args[1]));
+ strcpy(boot_command_line, (char *)__va(boot_args[1]));
#ifdef CONFIG_BLK_DEV_INITRD
if (boot_args[2] != 0) /* did palo pass us a ramdisk? */
@@ -84,7 +84,7 @@ void __init setup_cmdline(char **cmdline
#endif
}
- strcpy(command_line, saved_command_line);
+ strcpy(command_line, boot_command_line);
*cmdline_p = command_line;
}
diff -urNp linux-2.6.19.org/arch/parisc/mm/init.c
linux-2.6.19/arch/parisc/mm/init.c
--- linux-2.6.19.org/arch/parisc/mm/init.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/parisc/mm/init.c 2006-12-02 11:31:33.0 +0200
@@ -77,12 +77,12 @@ static void __init mem_limit_func(void)
{
char *cp, *end;
unsigned long limit;
- extern char saved_command_line[];
+ extern char __initdata boot_command_line[];
/* We need this before __setup() functions are called */
limit = MAX_MEM;
- for (cp = saved_command_line; *cp; ) {
+ for (cp = boot_command_line; *cp; ) {
if (memcmp(cp, "mem=", 4) == 0) {
cp += 4;
limit = memparse(cp, &end);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 11/26] Dynamic kernel command-line - m32r
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/m32r/kernel/setup.c
linux-2.6.19/arch/m32r/kernel/setup.c
--- linux-2.6.19.org/arch/m32r/kernel/setup.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/m32r/kernel/setup.c 2006-12-02 11:31:32.0
+0200
@@ -64,7 +64,7 @@ struct screen_info screen_info = {
extern int root_mountflags;
-static char command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE];
static struct resource data_resource = {
.name = "Kernel data",
@@ -95,8 +95,8 @@ static __inline__ void parse_mem_cmdline
int usermem = 0;
/* Save unparsed command line copy for /proc/cmdline */
- memcpy(saved_command_line, COMMAND_LINE, COMMAND_LINE_SIZE);
- saved_command_line[COMMAND_LINE_SIZE-1] = '\0';
+ memcpy(boot_command_line, COMMAND_LINE, COMMAND_LINE_SIZE);
+ boot_command_line[COMMAND_LINE_SIZE-1] = '\0';
memory_start = (unsigned long)CONFIG_MEMORY_START+PAGE_OFFSET;
memory_end = memory_start+(unsigned long)CONFIG_MEMORY_SIZE;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 16/26] Dynamic kernel command-line - powerpc
Rename saved_command_line into boot_command_line.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/powerpc/kernel/legacy_serial.c
linux-2.6.19/arch/powerpc/kernel/legacy_serial.c
--- linux-2.6.19.org/arch/powerpc/kernel/legacy_serial.c2006-11-29
23:57:37.0 +0200
+++ linux-2.6.19/arch/powerpc/kernel/legacy_serial.c2006-12-02
11:31:33.0 +0200
@@ -498,7 +498,7 @@ static int __init check_legacy_serial_co
DBG(" -> check_legacy_serial_console()\n");
/* The user has requested a console so this is already set up. */
- if (strstr(saved_command_line, "console=")) {
+ if (strstr(boot_command_line, "console=")) {
DBG(" console was specified !\n");
return -EBUSY;
}
diff -urNp linux-2.6.19.org/arch/powerpc/kernel/prom.c
linux-2.6.19/arch/powerpc/kernel/prom.c
--- linux-2.6.19.org/arch/powerpc/kernel/prom.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/powerpc/kernel/prom.c 2006-12-02 11:31:33.0
+0200
@@ -894,7 +894,7 @@ void __init early_init_devtree(void *par
of_scan_flat_dt(early_init_dt_scan_memory, NULL);
/* Save command line for /proc/cmdline and then parse parameters */
- strlcpy(saved_command_line, cmd_line, COMMAND_LINE_SIZE);
+ strlcpy(boot_command_line, cmd_line, COMMAND_LINE_SIZE);
parse_early_param();
/* Reserve LMB regions used by kernel, initrd, dt, etc... */
diff -urNp linux-2.6.19.org/arch/powerpc/kernel/udbg.c
linux-2.6.19/arch/powerpc/kernel/udbg.c
--- linux-2.6.19.org/arch/powerpc/kernel/udbg.c 2006-11-29 23:57:37.0
+0200
+++ linux-2.6.19/arch/powerpc/kernel/udbg.c 2006-12-02 11:31:33.0
+0200
@@ -146,7 +146,7 @@ void __init disable_early_printk(void)
{
if (!early_console_initialized)
return;
- if (strstr(saved_command_line, "udbg-immortal")) {
+ if (strstr(boot_command_line, "udbg-immortal")) {
printk(KERN_INFO "early console immortal !\n");
return;
}
diff -urNp linux-2.6.19.org/arch/powerpc/platforms/powermac/setup.c
linux-2.6.19/arch/powerpc/platforms/powermac/setup.c
--- linux-2.6.19.org/arch/powerpc/platforms/powermac/setup.c2006-11-29
23:57:37.0 +0200
+++ linux-2.6.19/arch/powerpc/platforms/powermac/setup.c2006-12-02
11:31:33.0 +0200
@@ -505,8 +505,8 @@ void note_bootable_part(dev_t dev, int p
if ((goodness <= current_root_goodness) &&
ROOT_DEV != DEFAULT_ROOT_DEVICE)
return;
- p = strstr(saved_command_line, "root=");
- if (p != NULL && (p == saved_command_line || p[-1] == ' '))
+ p = strstr(boot_command_line, "root=");
+ if (p != NULL && (p == boot_command_line || p[-1] == ' '))
return;
if (!found_boot) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
