RE: [PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE'

[Ballabio_Dario]

 Good to know that somebody still uses the Ultrastor 14f board :).
Yes, this typo was introduced by somebody doing massive editing to all
scsi drivers long ago.
Cheers,
--db
 

-Original Message-
From: Roel Kluin [mailto:[EMAIL PROTECTED] 
Sent: Monday, February 04, 2008 11:37 PM
To: Ballabio, Dario
Cc: [EMAIL PROTECTED]; lkml
Subject: [PATCH][drivers/scsi/u14-34f.c] duplicate test
'SCpnt->sc_data_direction == DMA_FROM_DEVICE'

It should be like this I guess? this patch was not yet tested, please
confirm.
--
Note the duplicate test 'SCpnt->sc_data_direction == DMA_FROM_DEVICE'

from Documentation/DMA-API.txt:
DMA_TO_DEVICE = PCI_DMA_TODEVICE  data is going from the
  memory to the device
DMA_FROM_DEVICE   = PCI_DMA_FROMDEVICEdata is coming from
  the device to the

Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c
index 662c004..1e704f9 100644
--- a/drivers/scsi/u14-34f.c
+++ b/drivers/scsi/u14-34f.c
@@ -1208,15 +1208,15 @@ static void scsi_to_dev_dir(unsigned int i,
unsigned int j) {
   };
 
struct mscp *cpp;
struct scsi_cmnd *SCpnt;
 
cpp = &HD(j)->cp[i]; SCpnt = cpp->SCpnt;
 
-   if (SCpnt->sc_data_direction == DMA_FROM_DEVICE) {
+   if (SCpnt->sc_data_direction == DMA_TO_DEVICE) {
   cpp->xdir = DTD_IN;
   return;
   }
else if (SCpnt->sc_data_direction == DMA_FROM_DEVICE) {
   cpp->xdir = DTD_OUT;
   return;
   }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: PATCH: Pcmcia/Cardbus/xircom_tulip in 2.4.0-test10.

[Ballabio_Dario]

I just tested test11-pre2 and there is no improvement. I still need to issue
the
ifconfig eth0 -multicast
and just after it the xircom_tulip card begins to work.
-db

-Original Message-
From: Jeff Garzik [mailto:[EMAIL PROTECTED]]
Sent: Friday, November 10, 2000 5:19 PM
To: [EMAIL PROTECTED]
Subject: Re: PATCH: Pcmcia/Cardbus/xircom_tulip in 2.4.0-test10.


[EMAIL PROTECTED] wrote:
> 
> I could not compile test11-pre2 so far because of the unresolved symbol
> bust_spinlocks,
> but I'll give it a try as soon as the compile problem get cleared.

edit linux/arch/i386/kernel/traps.c.  move the bust_spinlocks function,
AND the 'extern ...timer_list' line near it above the CONFIG_X86_IO_APIC
ifdef.

-- 
Jeff Garzik |
Building 1024   | Would you like a Twinkie?
MandrakeSoft|
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/

PATCH: Pcmcia/Cardbus/xircom_tulip in 2.4.0-test10.

[Ballabio_Dario]

In order to have the xircom_tulip pcmcia cardbus working again with 
recent kernels, it is necessary to specify:
 
ifconfig eth0 -multicast

Moreover if the card is configured by itself into the kernel 
(i.e. with the default ne2000 pcmcia support removed),
the enclosed patch is required as well.

Cheers,

***
Ph.D. Dario Ballabio
Regional Installation Manager Europe South
EMC Computer Systems Italia spa
Mobile phone +393487978851
Office phone +390244571315
Email [EMAIL PROTECTED]

diff -r -u linux-2.4.0-test10/drivers/net/pcmcia/Config.in
linux/drivers/net/pcmcia/Config.in
--- linux-2.4.0-test10/drivers/net/pcmcia/Config.in Sun Aug 13 19:21:20
2000
+++ linux/drivers/net/pcmcia/Config.in  Wed Nov  1 17:55:18 2000
@@ -36,7 +36,8 @@
  "$CONFIG_PCMCIA_FMVJ18X" = "y" -o "$CONFIG_PCMCIA_PCNET" = "y" -o \
  "$CONFIG_PCMCIA_NMCLAN" = "y" -o "$CONFIG_PCMCIA_SMC91C92" = "y" -o \
  "$CONFIG_PCMCIA_XIRC2PS" = "y" -o "$CONFIG_PCMCIA_RAYCS" = "y" -o \
- "$CONFIG_PCMCIA_NETWAVE" = "y" -o "$CONFIG_PCMCIA_WAVELAN" = "y" ];
then
+ "$CONFIG_PCMCIA_NETWAVE" = "y" -o "$CONFIG_PCMCIA_WAVELAN" = "y" -o \
+ "$CONFIG_PCMCIA_XIRTULIP" = "y" ]; then
define_bool CONFIG_PCMCIA_NETCARD y
 fi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/