[PATCH 4/8] Documentation: Replacing reference to broken perfect patch URL
Replacing ref to broken URL, in the "perfect patch" document. Signed-off-by: Ben Minerds --- Documentation/development-process/patches/The-Perfect-Patch.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/development-process/patches/The-Perfect-Patch.txt b/Documentation/development-process/patches/The-Perfect-Patch.txt index b07074e..217a303 100644 --- a/Documentation/development-process/patches/The-Perfect-Patch.txt +++ b/Documentation/development-process/patches/The-Perfect-Patch.txt @@ -20,8 +20,8 @@ I wrote a little guide this week: The perfect patch. [email blocked] -The latest version of this document may be found at -http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt +The latest version of this document may be found in: +- Documentation/development-process/patches/The-Perfect-Patch.txt Delivery -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 5/8] Documentation: Replacing reference to broken submission format URL
Replacing refs to broken URL with internal documentation reference, and a little whitespace shuffle to keep it under 80 chars wide. Signed-off-by: Ben Minerds --- Documentation/HOWTO | 10 +- Documentation/SubmittingPatches | 2 +- Documentation/ja_JP/HOWTO | 8 Documentation/ja_JP/SubmittingPatches | 2 +- Documentation/ko_KR/HOWTO | 2 +- Documentation/zh_CN/HOWTO | 2 +- Documentation/zh_CN/SubmittingPatches | 2 +- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/Documentation/HOWTO b/Documentation/HOWTO index 11e597e..fba34c0 100644 --- a/Documentation/HOWTO +++ b/Documentation/HOWTO @@ -110,11 +110,11 @@ required reading: subject to scrutiny for content and style), but not following them will almost always prevent it. -Other excellent descriptions of how to create patches properly are: - "The Perfect Patch" - Documentation/development-process/patches/The-Perfect-Patch.txt - "Linux kernel patch submission format" - http://linux.yyz.us/patch-format.html + Other excellent descriptions of how to create patches properly are: +"The Perfect Patch" + Documentation/development-process/patches/The-Perfect-Patch.txt +"Linux kernel patch submission format" + Documentation/development-process/patches/Patch-Submission-Format.txt Documentation/stable_api_nonsense.txt This file describes the rationale behind the conscious decision to diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index d59975f..8cd0e1e 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -718,7 +718,7 @@ Andrew Morton, "The perfect patch" (tpp). Documentation/development-process/patches/The-Perfect-Patch.txt Jeff Garzik, "Linux kernel patch submission format". - <http://linux.yyz.us/patch-format.html> + Documentation/development-process/patches/Patch-Submission-Format.txt Greg Kroah-Hartman, "How to piss off a kernel subsystem maintainer". <http://www.kroah.com/log/linux/maintainer.html> diff --git a/Documentation/ja_JP/HOWTO b/Documentation/ja_JP/HOWTO index 365262d..98a74a2 100644 --- a/Documentation/ja_JP/HOWTO +++ b/Documentation/ja_JP/HOWTO @@ -148,10 +148,10 @@ linux-...@ver.kernel.org に送ることを勧めます。 この他にパッチを作る方法についてのよくできた記述は- - "The Perfect Patch" - Documentation/development-process/patches/The-Perfect-Patch.txt - "Linux kernel patch submission format" - http://linux.yyz.us/patch-format.html +"The Perfect Patch" + Documentation/development-process/patches/The-Perfect-Patch.txt +"Linux kernel patch submission format" + Documentation/development-process/patches/Patch-Submission-Format.txt Documentation/stable_api_nonsense.txt このファイルはカーネルの中に不変のAPIを持たないことにした意識的な diff --git a/Documentation/ja_JP/SubmittingPatches b/Documentation/ja_JP/SubmittingPatches index b688892..e9b2cc5 100644 --- a/Documentation/ja_JP/SubmittingPatches +++ b/Documentation/ja_JP/SubmittingPatches @@ -698,7 +698,7 @@ Andrew Morton, "The perfect patch" (tpp). Documentation/development-process/patches/The-Perfect-Patch.txt Jeff Garzik, "Linux kernel patch submission format". - <http://linux.yyz.us/patch-format.html> + Documentation/development-process/patches/Patch-Submission-Format.txt Greg Kroah-Hartman, "How to piss off a kernel subsystem maintainer". <http://www.kroah.com/log/2005/03/31/> diff --git a/Documentation/ko_KR/HOWTO b/Documentation/ko_KR/HOWTO index 18a6e61..518497f 100644 --- a/Documentation/ko_KR/HOWTO +++ b/Documentation/ko_KR/HOWTO @@ -124,7 +124,7 @@ mtk.manpa...@gmail.com의 메인테이너에게 보낼 것을 권장한다. "The Perfect Patch" Documentation/development-process/patches/The-Perfect-Patch.txt "Linux kernel patch submission format" -http://linux.yyz.us/patch-format.html +Documentation/development-process/patches/Patch-Submission-Format.txt Documentation/stable_api_nonsense.txt 이 문서는 의도적으로 커널이 불변하는 API를 갖지 않도록 결정한 diff --git a/Documentation/zh_CN/HOWTO b/Documentation/zh_CN/HOWTO index a55c358..21860d1 100644 --- a/Documentation/zh_CN/HOWTO +++ b/Documentation/zh_CN/HOWTO @@ -114,7 +114,7 @@ Linux内核代码中包含有大量的文档。这些文档对于学习如何与 "The Perfect Patch" Documentation/development-process/patches/The-Perfect-Patch.txt "Linux kernel patch submission format" -http://linux.yyz.us/patch-format.html +Documentation/development-process/patches/Patch-Submission-Format.txt Documentation/stable_api_nonsense.txt 论证内核为什么特意不包括稳定的内核内部API，也就是说不包括像这样的特 diff --git a/Documentation/zh_CN/SubmittingPatches b/Documentation/zh_CN/SubmittingPatches index 779a065..37e93
[PATCH 7/8] Documentation: Reformatting "Linux Kernel Patch Submission Format"
Reformatted "Linux Kernel Patch Submission Format", to wrap at 80 chars and
underline headings.
Signed-off-by: Ben Minerds
---
.../patches/Patch-Submission-Format.txt| 86 --
1 file changed, 64 insertions(+), 22 deletions(-)
diff --git
a/Documentation/development-process/patches/Patch-Submission-Format.txt
b/Documentation/development-process/patches/Patch-Submission-Format.txt
index 44a1eb9..5c86ef5 100644
--- a/Documentation/development-process/patches/Patch-Submission-Format.txt
+++ b/Documentation/development-process/patches/Patch-Submission-Format.txt
@@ -1,39 +1,66 @@
Linux Kernel Patch Submission Format
-Most Linux kernel submissions are merged into the kernel source code
repository by script. These instructions describe the proper format for emailed
kernel patch submissions, to ensure that submittors and maintainers waste a
minimum amount of time on these details.
-1. Email subject format
+Most Linux kernel submissions are merged into the kernel source code repository
+by script. These instructions describe the proper format for emailed kernel
+patch submissions, to ensure that submittors and maintainers waste a minimum
+amount of time on these details.
-The email subject has a precise format, communicating several pieces of
information.
+1. Email subject format
+===
+The email subject has a precise format, communicating several pieces of
+information.
[PATCH $version $n/$total] $subsystem: one-line summary
"[PATCH": constant prefix
$version: kernel version against which this patch was generated
-$n/$total: when a change encompasses more than one patch, $n indicates the
order of this patch in the series, and $total indicates the total number of
patches in the series.
-$subsystem: area of the kernel, or device driver, to which this patch
applies.
-one-line summary: summarizes the change this patch makes. This summary is
copied directly into the SCM (i.e. git) changelog, so make sure that your
summary is descriptive. Ensure that $subsystem uniquely identifies the
subsystem or driver being modified. "update to latest CVS" or "fix bug in
probe" is not specific enough about what portion of the code is being modified.
+$n/$total: when a change encompasses more than one patch, $n indicates the
+ order of this patch in the series, and $total indicates the total number
+ of patches in the series.
+$subsystem: area of the kernel, or device driver, to which this
+ patch applies.
+one-line summary: summarizes the change this patch makes. This summary is
+ copied directly into the SCM (i.e. git) changelog, so make sure that your
+ summary is descriptive. Ensure that $subsystem uniquely identifies the
+ subsystem or driver being modified. "update to latest CVS" or "fix bug in
+ probe" is not specific enough about what portion of the code is
+ being modified.
Keep your overall subject line under 65 characters or so.
-The scripts will strip all the text inside the brackets ("[PATCH ...]"), and
replace it "[PATCH]".
+The scripts will strip all the text inside the brackets ("[PATCH ...]"), and
+replace it "[PATCH]".
Example:
[PATCH 2.6.9-rc1-mm2 1/2] 8139cp: fix PCI DAC mode
-The "$n/$total" may be omitted if there is only one patch in the series.
Writing "1/1" is not necessary.
+The "$n/$total" may be omitted if there is only one patch in the series.
+Writing "1/1" is not necessary.
+
2. Email body contents: description
+===
+At the beginning of your email, use as many lines as you wish to describe the
+patch. This text is copied directly into the SCM (i.e. git) changelog.
-At the beginning of your email, use as many lines as you wish to describe the
patch. This text is copied directly into the SCM (i.e. git) changelog.
+Include comments and other data (such as diffstat) you don't wish to be in the
+kernel changelog following a "---" terminator line. The terminator must be on a
+line by itself.
-Include comments and other data (such as diffstat) you don't wish to be in the
kernel changelog following a "---" terminator line. The terminator must be on a
line by itself.
3. Email body contents: patch
+=
+Sub-Rule Number One: Patches must be reviewable in a standard Linux email
+client. This means in particular, no compression and no base64 encoding.
+Attachments are discouraged, but some corporate mail systems provide no other
+way to send patches.
-Sub-Rule Number One: Patches must be reviewable in a standard Linux email
client. This means in particular, no compression and no base64 encoding.
Attachments are discouraged, but some corporate mail systems provide no o
[PATCH 6/8] Documentation: Updating a broken link in "the perfect patch"
The link to Andrews patches were out of date. Replacing with new links. Also slightly reformatted to allow easier selection of links. Signed-off-by: Ben Minerds --- Documentation/development-process/patches/The-Perfect-Patch.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/development-process/patches/The-Perfect-Patch.txt b/Documentation/development-process/patches/The-Perfect-Patch.txt index 217a303..63eccbb 100644 --- a/Documentation/development-process/patches/The-Perfect-Patch.txt +++ b/Documentation/development-process/patches/The-Perfect-Patch.txt @@ -160,8 +160,8 @@ Overall -The patch management scripts at http://www.zip.com.au/~akpm/linux/patches/ -implement all of the above. +The patch management scripts here implement all of the above: + https://www.kernel.org/pub/linux/kernel/people/akpm/patches/ -The patch management tools at https://savannah.nongnu.org/projects/quilt/ also -implement all of the above. \ No newline at end of file +The patch management tools here implement all of the above: + https://savannah.nongnu.org/projects/quilt/ -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3/8] Documentation: Replacing references to broken perfect patch URL
Replacing refs to broken URL with internal documentation reference. Signed-off-by: Ben Minerds --- Documentation/HOWTO | 4 ++-- Documentation/SubmittingPatches | 2 +- Documentation/ja_JP/HOWTO | 4 ++-- Documentation/ja_JP/SubmittingPatches | 2 +- Documentation/ko_KR/HOWTO | 4 ++-- Documentation/zh_CN/HOWTO | 4 ++-- Documentation/zh_CN/SubmittingPatches | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Documentation/HOWTO b/Documentation/HOWTO index a9f288f..11e597e 100644 --- a/Documentation/HOWTO +++ b/Documentation/HOWTO @@ -112,7 +112,7 @@ required reading: Other excellent descriptions of how to create patches properly are: "The Perfect Patch" - http://userweb.kernel.org/~akpm/stuff/tpp.txt + Documentation/development-process/patches/The-Perfect-Patch.txt "Linux kernel patch submission format" http://linux.yyz.us/patch-format.html @@ -579,7 +579,7 @@ all time. It should describe the patch completely, containing: For more details on what this should all look like, please see the ChangeLog section of the document: "The Perfect Patch" - http://userweb.kernel.org/~akpm/stuff/tpp.txt + Documentation/development-process/patches/The-Perfect-Patch.txt diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 6e97e73..d59975f 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -715,7 +715,7 @@ SECTION 3 - REFERENCES -- Andrew Morton, "The perfect patch" (tpp). - <http://userweb.kernel.org/~akpm/stuff/tpp.txt> + Documentation/development-process/patches/The-Perfect-Patch.txt Jeff Garzik, "Linux kernel patch submission format". <http://linux.yyz.us/patch-format.html> diff --git a/Documentation/ja_JP/HOWTO b/Documentation/ja_JP/HOWTO index 050d37f..365262d 100644 --- a/Documentation/ja_JP/HOWTO +++ b/Documentation/ja_JP/HOWTO @@ -149,7 +149,7 @@ linux-...@ver.kernel.org に送ることを勧めます。 この他にパッチを作る方法についてのよくできた記述は- "The Perfect Patch" - http://userweb.kernel.org/~akpm/stuff/tpp.txt + Documentation/development-process/patches/The-Perfect-Patch.txt "Linux kernel patch submission format" http://linux.yyz.us/patch-format.html @@ -622,7 +622,7 @@ Linux カーネルコミュニティは、一度に大量のコードの塊を これについて全てがどのようにあるべきかについての詳細は、以下のドキュメ ントの ChangeLog セクションを見てください- "The Perfect Patch" - http://userweb.kernel.org/~akpm/stuff/tpp.txt + Documentation/development-process/patches/The-Perfect-Patch.txt これらのどれもが、時にはとても困難です。これらの慣例を完璧に実施するに は数年かかるかもしれません。これは継続的な改善のプロセスであり、そのた diff --git a/Documentation/ja_JP/SubmittingPatches b/Documentation/ja_JP/SubmittingPatches index 97f78dd..b688892 100644 --- a/Documentation/ja_JP/SubmittingPatches +++ b/Documentation/ja_JP/SubmittingPatches @@ -695,7 +695,7 @@ gcc においては、マクロと同じくらい軽いです。 -- Andrew Morton, "The perfect patch" (tpp). - <http://userweb.kernel.org/~akpm/stuff/tpp.txt> + Documentation/development-process/patches/The-Perfect-Patch.txt Jeff Garzik, "Linux kernel patch submission format". <http://linux.yyz.us/patch-format.html> diff --git a/Documentation/ko_KR/HOWTO b/Documentation/ko_KR/HOWTO index 2f48f20..18a6e61 100644 --- a/Documentation/ko_KR/HOWTO +++ b/Documentation/ko_KR/HOWTO @@ -122,7 +122,7 @@ mtk.manpa...@gmail.com의 메인테이너에게 보낼 것을 권장한다. 올바른 패치들을 만드는 법에 관한 훌륭한 다른 문서들이 있다. "The Perfect Patch" -http://userweb.kernel.org/~akpm/stuff/tpp.txt +Documentation/development-process/patches/The-Perfect-Patch.txt "Linux kernel patch submission format" http://linux.yyz.us/patch-format.html @@ -596,7 +596,7 @@ Pat이라는 이름을 가진 여자가 있을 수도 있는 것이다. 리눅 이것이 무엇인지 더 자세한 것을 알고 싶다면 다음 문서의 ChageLog 항을 봐라. "The Perfect Patch" -http://userweb.kernel.org/~akpm/stuff/tpp.txt +Documentation/development-process/patches/The-Perfect-Patch.txt diff --git a/Documentation/zh_CN/HOWTO b/Documentation/zh_CN/HOWTO index 7fba5aa..a55c358 100644 --- a/Documentation/zh_CN/HOWTO +++ b/Documentation/zh_CN/HOWTO @@ -112,7 +112,7 @@ Linux内核代码中包含有大量的文档。这些文档对于学习如何与 其他关于如何正确地生成补丁的优秀文档包括： "The Perfect Patch" -http://userweb.kernel.org/~akpm/stuff/tpp.txt +Documentation/development-process/patches/The-Perfect-Patch.txt "Linux kernel patch submission format" http://linux.yyz.us/patch-format.html @@ -515,7 +515,7 @@ Linux内核社区并不喜欢一下接收大段的代码。修改需要被恰当 想了解它具体应该看起来像什么，请查阅以下文档中的“ChangeLog”章节： “The Perfect Patch” -http://userweb.kernel.org/~akpm/stuff/tpp.txt +Documentation/development-process/patches/The-Perfect-Patch.txt 这些事情有时候做起来很难。要在任何方面都做到完美可能需要好几年时间。
[PATCH 2/8] Documentation: Adding "Linux Kernel Patch Submission Format"
Adding "Linux Kernel Patch Submission Format" reference to remove external
dependancy.
Signed-off-by: Ben Minerds
---
.../patches/Patch-Submission-Format.txt| 89 ++
1 file changed, 89 insertions(+)
create mode 100644
Documentation/development-process/patches/Patch-Submission-Format.txt
diff --git
a/Documentation/development-process/patches/Patch-Submission-Format.txt
b/Documentation/development-process/patches/Patch-Submission-Format.txt
new file mode 100644
index 000..44a1eb9
--- /dev/null
+++ b/Documentation/development-process/patches/Patch-Submission-Format.txt
@@ -0,0 +1,89 @@
+Linux Kernel Patch Submission Format
+
+
+Most Linux kernel submissions are merged into the kernel source code
repository by script. These instructions describe the proper format for emailed
kernel patch submissions, to ensure that submittors and maintainers waste a
minimum amount of time on these details.
+1. Email subject format
+
+The email subject has a precise format, communicating several pieces of
information.
+
+[PATCH $version $n/$total] $subsystem: one-line summary
+
+"[PATCH": constant prefix
+$version: kernel version against which this patch was generated
+$n/$total: when a change encompasses more than one patch, $n indicates the
order of this patch in the series, and $total indicates the total number of
patches in the series.
+$subsystem: area of the kernel, or device driver, to which this patch
applies.
+one-line summary: summarizes the change this patch makes. This summary is
copied directly into the SCM (i.e. git) changelog, so make sure that your
summary is descriptive. Ensure that $subsystem uniquely identifies the
subsystem or driver being modified. "update to latest CVS" or "fix bug in
probe" is not specific enough about what portion of the code is being modified.
+Keep your overall subject line under 65 characters or so.
+
+The scripts will strip all the text inside the brackets ("[PATCH ...]"), and
replace it "[PATCH]".
+
+Example:
+
+ [PATCH 2.6.9-rc1-mm2 1/2] 8139cp: fix PCI DAC mode
+
+The "$n/$total" may be omitted if there is only one patch in the series.
Writing "1/1" is not necessary.
+2. Email body contents: description
+
+At the beginning of your email, use as many lines as you wish to describe the
patch. This text is copied directly into the SCM (i.e. git) changelog.
+
+Include comments and other data (such as diffstat) you don't wish to be in the
kernel changelog following a "---" terminator line. The terminator must be on a
line by itself.
+3. Email body contents: patch
+
+Sub-Rule Number One: Patches must be reviewable in a standard Linux email
client. This means in particular, no compression and no base64 encoding.
Attachments are discouraged, but some corporate mail systems provide no other
way to send patches.
+
+Sub-Rule Number Two: Patch must be apply-able by a script that has no
knowledge of [MIME] encoding. You must make sure your mailer does not escape
standard US-ASCII characters, wrap long lines, or encode plaintext patches in
base64 (or any other encoding).
+
+Sub-Rule Number Three: Patch must be rooted one level above a standard kernel
source tree. i.e.
+
+ --- a/drivers/scsi/megaraid/megaraid_mm.c 2004-08-31 04:05:10 -04:00
+ +++ b/drivers/scsi/megaraid/megaraid_mm.c 2004-08-31 04:05:10 -04:00
+
+or in other words, the patch must be apply-able using
+
+ patch -sp1 < foo.patch
+
+4. One patch per email
+
+This cannot be stressed enough. Even when you are resending a change for the
5th time, resist the urge to attach 20 patches to a single email. If you do
send multiple emails, make sure the second and subsequent emails are sent as
replies to the first, to keep them all together in a thread.
+5. Sign your work
+
+The sign-off is a simple line at the end of the explanation for the patch,
which certifies that you wrote it or otherwise have the right to pass it on as
a open-source patch. The rules are pretty simple: if you can certify the below:
+
+Developer's Certificate of Origin 1.1
+
+By making a contribution to this project, I certify that:
+
+(a) The contribution was created in whole or in part by me and I
+have the right to submit it under the open source license
+indicated in the file; or
+
+(b) The contribution is based upon previous work that, to the best
+of my knowledge, is covered under an appropriate open source
+license and I have the right under that license to submit that
+work with modifications, whether created in whole or in part
+by me, under the same open source license (unless I am
+permitted to submit under a different license), as indicated
+in the file; or
+
+
[PATCH 1/8] Documentation: Adding "The Perfect Patch" by Andrew Morton
Adding Andrews advice on patch submission and subdirectory for further patch
documentstion.
Signed-off-by: Ben Minerds
---
.../patches/The-Perfect-Patch.txt | 167 +
1 file changed, 167 insertions(+)
create mode 100644
Documentation/development-process/patches/The-Perfect-Patch.txt
diff --git a/Documentation/development-process/patches/The-Perfect-Patch.txt
b/Documentation/development-process/patches/The-Perfect-Patch.txt
new file mode 100644
index 000..b07074e
--- /dev/null
+++ b/Documentation/development-process/patches/The-Perfect-Patch.txt
@@ -0,0 +1,167 @@
+From: Andrew Morton [email blocked]
+To: Mukker, Atul [email blocked]
+Subject: Re: [patch] 2.6.9-rc1-mm1: megaraid_mbox.c compile error with gcc 3.4
+Date: Sat, 28 Aug 2004 13:04:19 -0700
+
+"Mukker, Atul" [email blocked] wrote:
+>
+> The driver and the patches with the re-ordered functions is available at
+> ftp://ftp.lsil.com/pub/linux-megaraid/drivers/version-2.20.3.1/
+
+I dunno about James, but I *really* dislike receiving patches by going and
+getting them from internet servers. It breaks our commonly-used tools. It
+loses authorship info. It loses Signed-off-by: info. There is no
+changelog. All this means that your patch is more likely to be ignored by
+busy people. Please, just email the diffs.
+
+I wrote a little guide this week:
+
+
+
+The perfect patch. [email blocked]
+
+The latest version of this document may be found at
+http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
+
+Delivery
+
+
+- Patches are delivered via email only. Downloading them from internet
+ servers is a pain.
+
+- One patch per email, with the changelog in the body of the email.
+
+Subject:
+
+
+- The email's Subject: should consisely describe the patch which that email
+ contains. The Subject: should not be a filename. Do not use the same
+ Subject: for every patch in a whole patch series.
+
+ Bear in mind that the Subject: of your email becomes a globally-unique
+ identifier for that patch. It propagates all the way into BitKeeper. The
+ Subject: may later be used in developer discussions which refer to the
+ patch. People will want to google for the patch's Subject: to read
+ discussion regarding that patch.
+
+- When sending a series of patches, the patches should be sequence-numbered
+ in the Subject:
+
+- It is nice if the Subject: includes mention of the subsystem which it
+ affects. See example below.
+
+- Example Subject:
+
+ [patch 2/5] ext2: improve scalability of bitmap searching
+
+- Note that various people's patch receiving scripts will strip away
+ Subject: text which is inside brackets []. So you should place information
+ which has no long-term relevance to the patch inside brackets. This
+ includes the word "patch" and any sequence numbering. The subsystem
+ identifier ("ext2:") should hence be outside brackets.
+
+
+Changelog
+=
+
+- Bear in mind that the Subject: and changelog which you provide will
+ propagate all the way into the permanent kernel record. Other developers
+ will want to read and understand your patch and changelog years in the
+ future.
+
+ So the changelog should describe the patch fully:
+
+ - why the kernel needed patching
+
+ - the overall design approach in the patch
+
+ - implementation details
+
+ - testing results
+
+- Don't bother mentioning what version of the kernel the patch applies to
+ ("applies to 2.6.8-rc1"). This is not interesting information - once the
+ patch is in bitkeeper, of _course_ it applied, and it'll probably be merged
+ into a later kernel than the one which you wrote it for.
+
+- Do not refer to earlier patches when changelogging a new version of a
+ patch. It's not very useful to have a bitkeeper changelog which says "OK,
+ this fixes the things you mentioned yesterday". Each iteration of the patch
+ should contain a standalone changelog. This implies that you need a patch
+ management system which maintains changelogs. See below.
+
+- Add a Signed-off-by: line.
+
+- Most people's patch receiving scripts will treat a ^--- string as the
+ separator between the changelog and the patch itself. You can use this to
+ ensure that any diffstat information is discarded when the patch is applied:
+
+
+
+ Another few #if/#ifdef cleanups, this time for the PPC architecture.
+
+ Signed-off-by:
+ Signed-off-by: Andrew Morton [email blocked]
+ ---
+
+25-akpm/arch/ppc/kernel/process.c|2 +-
+25-akpm/arch/ppc/platforms/85xx/mpc85xx_cds_common.c |2 +-
+25-akpm/arch/ppc/syslib/ppc85xx_setup.c |4 ++--
+3 files changed, 4 insertions(+), 4 deletions(-)
+
+ --- 25/arch/ppc/kernel/process.c
+ +++ 25/arch/ppc/kernel/process.c
+ @@ -667,7 +667,7 @@ void show_sta
[PATCH 0/8] Documentation: Updating docs and links relating to patches.
This patch series 1. adds "the perfect patch" doc 2. adds "submission format" doc 3. update refs to perfect-patch 4. fix link in perfect patch 5. update refs to sub-format 6. fix source ref in perfect patch 7. reformat submission format doc 8. move other documents into patch sub directory. Ben Minerds (8): Documentation: Adding "The Perfect Patch" by Andrew Morton Documentation: Adding "Linux Kernel Patch Submission Format" Documentation: Replacing references to broken perfect patch URL Documentation: Replacing reference to broken perfect patch URL Documentation: Replacing reference to broken submission format URL Documentation: Updating a broken link in "the perfect patch" Documentation: Reformatting "Linux Kernel Patch Submission Format" Documentation: Move other patch related document Documentation/HOWTO| 12 +- Documentation/SubmittingPatches| 743 - Documentation/applying-patches.txt | 454 - .../patches/Patch-Submission-Format.txt| 131 .../development-process/patches/SubmittingPatches | 743 + .../patches/The-Perfect-Patch.txt | 167 + .../patches/applying-patches.txt | 454 + Documentation/ja_JP/HOWTO | 10 +- Documentation/ja_JP/SubmittingPatches | 4 +- Documentation/ko_KR/HOWTO | 6 +- Documentation/zh_CN/HOWTO | 6 +- Documentation/zh_CN/SubmittingPatches | 4 +- 12 files changed, 1516 insertions(+), 1218 deletions(-) delete mode 100644 Documentation/SubmittingPatches delete mode 100644 Documentation/applying-patches.txt create mode 100644 Documentation/development-process/patches/Patch-Submission-Format.txt create mode 100644 Documentation/development-process/patches/SubmittingPatches create mode 100644 Documentation/development-process/patches/The-Perfect-Patch.txt create mode 100644 Documentation/development-process/patches/applying-patches.txt -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Documentation: Updated broken link in HOWTO
Updated broken "The Perfect Patch" link in HOWTO to a copy at kerneltrap.org. Signed-off-by: Ben Minerds --- Documentation/HOWTO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/HOWTO b/Documentation/HOWTO index a9f288f..27faae3 100644 --- a/Documentation/HOWTO +++ b/Documentation/HOWTO @@ -112,7 +112,7 @@ required reading: Other excellent descriptions of how to create patches properly are: "The Perfect Patch" - http://userweb.kernel.org/~akpm/stuff/tpp.txt + http://kerneltrap.org/node/3737 "Linux kernel patch submission format" http://linux.yyz.us/patch-format.html -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] usb: gadget: Conform with checkpatch -3 warnings, 1 error
Removed 3 checkpatch.sh warnings and 1 error in
drivers/usb/gadget/serial.c.
-sizeof brackets x2
-remove initialise to 0
-pr_warning to pr_warn
Signed-off-by: Ben Minerds
---
drivers/usb/gadget/serial.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/serial.c b/drivers/usb/gadget/serial.c
index 665c074..af69cd2 100644
--- a/drivers/usb/gadget/serial.c
+++ b/drivers/usb/gadget/serial.c
@@ -101,9 +101,8 @@ static struct usb_device_descriptor device_desc = {
};
static struct usb_otg_descriptor otg_descriptor = {
- .bLength = sizeof otg_descriptor,
+ .bLength = sizeof(otg_descriptor),
.bDescriptorType = USB_DT_OTG,
-
/* REVISIT SRP-only hardware is possible, although
* it would not be called "OTG" ...
*/
@@ -127,7 +126,7 @@ static bool use_acm = true;
module_param(use_acm, bool, 0);
MODULE_PARM_DESC(use_acm, "Use CDC ACM, default=yes");
-static bool use_obex = false;
+static bool use_obex;
module_param(use_obex, bool, 0);
MODULE_PARM_DESC(use_obex, "Use CDC OBEX, default=no");
@@ -175,7 +174,7 @@ static int __init gs_bind(struct usb_composite_dev *cdev)
*/
/* device description: manufacturer, product */
- snprintf(manufacturer, sizeof manufacturer, "%s %s with %s",
+ snprintf(manufacturer, sizeof(manufacturer), "%s %s with %s",
init_utsname()->sysname, init_utsname()->release,
gadget->name);
status = usb_string_id(cdev);
@@ -212,7 +211,7 @@ static int __init gs_bind(struct usb_composite_dev *cdev)
* things like configuration and altsetting numbering
* can need hardware-specific attention though.
*/
- pr_warning("gs_bind: controller '%s' not recognized\n",
+ pr_warn("gs_bind: controller '%s' not recognized\n",
gadget->name);
device_desc.bcdDevice =
cpu_to_le16(GS_VERSION_NUM | 0x0099);
--
1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 6/6] USB: serial: Removed unrequired parentheses.
Changes to conform with checkpatch.sh script. - return is not a
function, parentheses not required. Removed 1 checkpatch.sh error.
Signed-off-by: Ben Minerds
---
drivers/usb/serial/keyspan.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index f205e9b..ccb24e6 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -1240,7 +1240,7 @@ static int keyspan_fake_startup(struct usb_serial *serial)
if (request_ihex_firmware(&fw, fw_name, &serial->dev->dev)) {
dev_err(&serial->dev->dev, "Required keyspan firmware image
(%s) unavailable.\n", fw_name);
- return(1);
+ return 1;
}
dbg("Uploading Keyspan %s firmware.", fw_name);
--
1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 5/6] USB: serial: Removed trailing whitespace.
Changes to conform with checkpatch.sh script. - trailing whitespace.
Removed 1 checkpatch.sh error.
Signed-off-by: Ben Minerds
---
drivers/usb/serial/keyspan.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index 50494f4..f205e9b 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -559,7 +559,7 @@ static void usa28_instat_callback(struct urb *urb)
if (old_dcd_state != p_priv->dcd_state && old_dcd_state) {
tty = tty_port_tty_get(&port->port);
- if (tty && !C_CLOCAL(tty))
+ if (tty && !C_CLOCAL(tty))
tty_hangup(tty);
tty_kref_put(tty);
}
--
1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 4/6] USB: serial: Fixed space near open parenthesis.
Changes to conform with checkpatch.sh script. - space near open
parenthesis '('. Removed 2 checkpatch.sh errors.
Signed-off-by: Ben Minerds
---
drivers/usb/serial/keyspan.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index f980d7d..50494f4 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -557,7 +557,7 @@ static void usa28_instat_callback(struct urb *urb)
p_priv->dcd_state = ((msg->dcd) ? 1 : 0);
p_priv->ri_state = ((msg->ri) ? 1 : 0);
- if( old_dcd_state != p_priv->dcd_state && old_dcd_state) {
+ if (old_dcd_state != p_priv->dcd_state && old_dcd_state) {
tty = tty_port_tty_get(&port->port);
if (tty && !C_CLOCAL(tty))
tty_hangup(tty);
--
1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3/6] USB: serial: Fixed space around equals.
Changes to conform with checkpatch.sh script. - space around '='.
Removed 1 checkpatch.sh error.
Signed-off-by: Ben Minerds
---
drivers/usb/serial/keyspan.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index 4389736..f980d7d 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -474,7 +474,7 @@ static void usa28_indat_callback(struct urb *urb)
p_priv = usb_get_serial_port_data(port);
data = urb->transfer_buffer;
- tty =tty_port_tty_get(&port->port);
+ tty = tty_port_tty_get(&port->port);
if (tty && urb->actual_length) {
tty_insert_flip_string(tty, data, urb->actual_length);
tty_flip_buffer_push(tty);
--
1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/6] USB: serial: Fix spacing around conditional.
Changes to conform with checkpatch.sh script. - spaces around '?'
and ':'.Removed 14 checkpatch.sh errors.
Signed-off-by: Ben Minerds
---
drivers/usb/serial/keyspan.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index 23cc8ec..4389736 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -176,7 +176,7 @@ static void keyspan_set_termios(struct tty_struct *tty,
tty_encode_baud_rate(tty, baud_rate, baud_rate);
/* set CTS/RTS handshake etc. */
p_priv->cflag = cflag;
- p_priv->flow_control = (cflag & CRTSCTS)? flow_cts: flow_none;
+ p_priv->flow_control = (cflag & CRTSCTS) ? flow_cts : flow_none;
/* Mark/Space not supported */
tty->termios->c_cflag &= ~CMSPAR;
@@ -1102,7 +1102,7 @@ static int keyspan_open(struct tty_struct *tty, struct
usb_serial_port *port)
}
/* set CTS/RTS handshake etc. */
p_priv->cflag = cflag;
- p_priv->flow_control = (cflag & CRTSCTS)? flow_cts: flow_none;
+ p_priv->flow_control = (cflag & CRTSCTS) ? flow_cts : flow_none;
keyspan_send_setup(port, 1);
/* mdelay(100); */
@@ -1709,7 +1709,7 @@ static int keyspan_usa26_send_setup(struct usb_serial
*serial,
msg.setPrescaler = 0xff;
}
- msg.lcr = (p_priv->cflag & CSTOPB)? STOPBITS_678_2: STOPBITS_5678_1;
+ msg.lcr = (p_priv->cflag & CSTOPB) ? STOPBITS_678_2 : STOPBITS_5678_1;
switch (p_priv->cflag & CSIZE) {
case CS5:
msg.lcr |= USA_DATABITS_5;
@@ -1726,7 +1726,7 @@ static int keyspan_usa26_send_setup(struct usb_serial
*serial,
}
if (p_priv->cflag & PARENB) {
/* note USA_PARITY_NONE == 0 */
- msg.lcr |= (p_priv->cflag & PARODD)?
+ msg.lcr |= (p_priv->cflag & PARODD) ?
USA_PARITY_ODD : USA_PARITY_EVEN;
}
msg.setLcr = 0xff;
@@ -1994,7 +1994,7 @@ static int keyspan_usa49_send_setup(struct usb_serial
*serial,
/* msg.setPrescaler = 0xff; */
}
- msg.lcr = (p_priv->cflag & CSTOPB)? STOPBITS_678_2: STOPBITS_5678_1;
+ msg.lcr = (p_priv->cflag & CSTOPB) ? STOPBITS_678_2 : STOPBITS_5678_1;
switch (p_priv->cflag & CSIZE) {
case CS5:
msg.lcr |= USA_DATABITS_5;
@@ -2011,7 +2011,7 @@ static int keyspan_usa49_send_setup(struct usb_serial
*serial,
}
if (p_priv->cflag & PARENB) {
/* note USA_PARITY_NONE == 0 */
- msg.lcr |= (p_priv->cflag & PARODD)?
+ msg.lcr |= (p_priv->cflag & PARODD) ?
USA_PARITY_ODD : USA_PARITY_EVEN;
}
msg.setLcr = 0xff;
@@ -2178,7 +2178,7 @@ static int keyspan_usa90_send_setup(struct usb_serial
*serial,
msg.txMode = TXMODE_BYHAND;
}
- msg.lcr = (p_priv->cflag & CSTOPB)? STOPBITS_678_2: STOPBITS_5678_1;
+ msg.lcr = (p_priv->cflag & CSTOPB) ? STOPBITS_678_2 : STOPBITS_5678_1;
switch (p_priv->cflag & CSIZE) {
case CS5:
msg.lcr |= USA_DATABITS_5;
@@ -2195,7 +2195,7 @@ static int keyspan_usa90_send_setup(struct usb_serial
*serial,
}
if (p_priv->cflag & PARENB) {
/* note USA_PARITY_NONE == 0 */
- msg.lcr |= (p_priv->cflag & PARODD)?
+ msg.lcr |= (p_priv->cflag & PARODD) ?
USA_PARITY_ODD : USA_PARITY_EVEN;
}
if (p_priv->old_cflag != p_priv->cflag) {
@@ -2322,7 +2322,7 @@ static int keyspan_usa67_send_setup(struct usb_serial
*serial,
}
if (p_priv->cflag & PARENB) {
/* note USA_PARITY_NONE == 0 */
- msg.lcr |= (p_priv->cflag & PARODD)?
+ msg.lcr |= (p_priv->cflag & PARODD) ?
USA_PARITY_ODD : USA_PARITY_EVEN;
}
msg.setLcr = 0xff;
--
1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/6] USB: serial: Removed space before tabs.
Changes to conform with checkpatch.sh script. - no space before tabs.
Removed 52 checkpatch.sh warnings.
Signed-off-by: Ben Minerds
---
drivers/usb/serial/keyspan.c | 106 +-
1 files changed, 53 insertions(+), 53 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index a1b9924..23cc8ec 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -135,7 +135,7 @@ module_usb_serial_driver(serial_drivers,
keyspan_ids_combined);
static void keyspan_break_ctl(struct tty_struct *tty, int break_state)
{
struct usb_serial_port *port = tty->driver_data;
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
p_priv = usb_get_serial_port_data(port);
@@ -152,9 +152,9 @@ static void keyspan_set_termios(struct tty_struct *tty,
struct usb_serial_port *port, struct ktermios *old_termios)
{
int baud_rate, device_port;
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
const struct keyspan_device_details *d_details;
- unsigned intcflag;
+ unsigned intcflag;
p_priv = usb_get_serial_port_data(port);
d_details = p_priv->device_details;
@@ -223,12 +223,12 @@ static int keyspan_tiocmset(struct tty_struct *tty,
static int keyspan_write(struct tty_struct *tty,
struct usb_serial_port *port, const unsigned char *buf, int count)
{
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
const struct keyspan_device_details *d_details;
int flip;
- int left, todo;
+ int left, todo;
struct urb *this_urb;
- int err, maxDataLen, dataOffset;
+ int err, maxDataLen, dataOffset;
p_priv = usb_get_serial_port_data(port);
d_details = p_priv->device_details;
@@ -299,7 +299,7 @@ static void usa26_indat_callback(struct urb *urb)
int endpoint;
struct usb_serial_port *port;
struct tty_struct *tty;
- unsigned char *data = urb->transfer_buffer;
+ unsigned char *data = urb->transfer_buffer;
int status = urb->status;
endpoint = usb_pipeendpoint(urb->pipe);
@@ -382,11 +382,11 @@ static void usa26_outcont_callback(struct urb *urb)
static voidusa26_instat_callback(struct urb *urb)
{
- unsigned char *data = urb->transfer_buffer;
+ unsigned char *data = urb->transfer_buffer;
struct keyspan_usa26_portStatusMessage *msg;
struct usb_serial *serial;
struct usb_serial_port *port;
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
struct tty_struct *tty;
int old_dcd_state, err;
int status = urb->status;
@@ -514,11 +514,11 @@ static void usa28_outcont_callback(struct urb *urb)
static voidusa28_instat_callback(struct urb *urb)
{
int err;
- unsigned char *data = urb->transfer_buffer;
+ unsigned char *data = urb->transfer_buffer;
struct keyspan_usa28_portStatusMessage *msg;
struct usb_serial *serial;
struct usb_serial_port *port;
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
struct tty_struct *tty;
int old_dcd_state;
int status = urb->status;
@@ -602,11 +602,11 @@ static void usa49_glocont_callback(struct urb *urb)
static voidusa49_instat_callback(struct urb *urb)
{
int err;
- unsigned char *data = urb->transfer_buffer;
+ unsigned char *data = urb->transfer_buffer;
struct keyspan_usa49_portStatusMessage *msg;
struct usb_serial *serial;
struct usb_serial_port *port;
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
int old_dcd_state;
int status = urb->status;
@@ -670,7 +670,7 @@ static void usa49_indat_callback(struct urb *urb)
int endpoint;
struct usb_serial_port *port;
struct tty_struct *tty;
- unsigned char *data = urb->transfer_
[PATCH 0/6] USB: serial: Changes to conform with checkpatch.
Removed various checkpatch.sh warnings and errors.
Split patch by warning/error type.
Corrected line wraps in emails.
Signed-off-by: Ben Minerds
---
drivers/usb/serial/keyspan.c | 106 +-
1 files changed, 53 insertions(+), 53 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index a1b9924..23cc8ec 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -135,7 +135,7 @@ module_usb_serial_driver(serial_drivers,
keyspan_ids_combined);
static void keyspan_break_ctl(struct tty_struct *tty, int break_state)
{
struct usb_serial_port *port = tty->driver_data;
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
p_priv = usb_get_serial_port_data(port);
@@ -152,9 +152,9 @@ static void keyspan_set_termios(struct tty_struct *tty,
struct usb_serial_port *port, struct ktermios *old_termios)
{
int baud_rate, device_port;
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
const struct keyspan_device_details *d_details;
- unsigned intcflag;
+ unsigned intcflag;
p_priv = usb_get_serial_port_data(port);
d_details = p_priv->device_details;
@@ -223,12 +223,12 @@ static int keyspan_tiocmset(struct tty_struct *tty,
static int keyspan_write(struct tty_struct *tty,
struct usb_serial_port *port, const unsigned char *buf, int count)
{
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
const struct keyspan_device_details *d_details;
int flip;
- int left, todo;
+ int left, todo;
struct urb *this_urb;
- int err, maxDataLen, dataOffset;
+ int err, maxDataLen, dataOffset;
p_priv = usb_get_serial_port_data(port);
d_details = p_priv->device_details;
@@ -299,7 +299,7 @@ static void usa26_indat_callback(struct urb *urb)
int endpoint;
struct usb_serial_port *port;
struct tty_struct *tty;
- unsigned char *data = urb->transfer_buffer;
+ unsigned char *data = urb->transfer_buffer;
int status = urb->status;
endpoint = usb_pipeendpoint(urb->pipe);
@@ -382,11 +382,11 @@ static void usa26_outcont_callback(struct urb *urb)
static voidusa26_instat_callback(struct urb *urb)
{
- unsigned char *data = urb->transfer_buffer;
+ unsigned char *data = urb->transfer_buffer;
struct keyspan_usa26_portStatusMessage *msg;
struct usb_serial *serial;
struct usb_serial_port *port;
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
struct tty_struct *tty;
int old_dcd_state, err;
int status = urb->status;
@@ -514,11 +514,11 @@ static void usa28_outcont_callback(struct urb *urb)
static voidusa28_instat_callback(struct urb *urb)
{
int err;
- unsigned char *data = urb->transfer_buffer;
+ unsigned char *data = urb->transfer_buffer;
struct keyspan_usa28_portStatusMessage *msg;
struct usb_serial *serial;
struct usb_serial_port *port;
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
struct tty_struct *tty;
int old_dcd_state;
int status = urb->status;
@@ -602,11 +602,11 @@ static void usa49_glocont_callback(struct urb *urb)
static voidusa49_instat_callback(struct urb *urb)
{
int err;
- unsigned char *data = urb->transfer_buffer;
+ unsigned char *data = urb->transfer_buffer;
struct keyspan_usa49_portStatusMessage *msg;
struct usb_serial *serial;
struct usb_serial_port *port;
- struct keyspan_port_private *p_priv;
+ struct keyspan_port_private *p_priv;
int old_dcd_state;
int status = urb->status;
@@ -670,7 +670,7 @@ static void usa49_indat_callback(struct urb *urb)
int endpoint;
struct usb_serial_port *port;
struct tty_struct *tty;
- unsigned char *da
