usb: dwc3: gadget: Change runtime pm function for DWC3 runtime suspend

2021-02-14 Thread Daehwan Jung
It seems pm_runtime_put calls runtime_idle callback not runtime_suspend 
callback.
It's better to use pm_runtime_put_sync_suspend to allow DWC3 runtime suspend.

Signed-off-by: Daehwan Jung 
---
 drivers/usb/dwc3/gadget.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index aebcf8e..4a4b93b 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2229,7 +2229,7 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int 
is_on)
 */
ret = pm_runtime_get_sync(dwc->dev);
if (!ret || ret < 0) {
-   pm_runtime_put(dwc->dev);
+   pm_runtime_put_sync_suspend(dwc->dev);
return 0;
}
 
-- 
2.7.4



usb: dwc3: gadget: skip pullup and set_speed after suspend

2021-01-19 Thread Daehwan Jung
Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after
entering suspend. That's why it needs to check whether suspend

1. dwc3 sends disconnect uevent and turn off. (suspend)
2. Platform side causes pullup or set_speed(e.g., adbd closes ffs node)
3. It causes unexpected behavior like ITMON error.

Signed-off-by: Daehwan Jung 
---
 drivers/usb/dwc3/gadget.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index ee44321..d7d4202 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2093,6 +2093,9 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int 
is_on)
unsigned long   flags;
int ret;
 
+   if (pm_runtime_suspended(dwc->dev))
+   return 0;
+
is_on = !!is_on;
 
/*
@@ -2403,6 +2406,9 @@ static void dwc3_gadget_set_speed(struct usb_gadget *g,
unsigned long   flags;
u32 reg;
 
+   if (pm_runtime_suspended(dwc->dev))
+   return;
+
spin_lock_irqsave(&dwc->lock, flags);
reg = dwc3_readl(dwc->regs, DWC3_DCFG);
reg &= ~(DWC3_DCFG_SPEED_MASK);
-- 
2.7.4