Re: [PATCH v3 0/3] selftests: netfilter: introduce test cases for ipvs
On Thu, Oct 03, 2019 at 10:41:06PM +0800, Haishuang Yan wrote:
>
>
> > On 2019??10??2??, at 9:27, Duncan Roe
> > wrote:
> >
> > On Tue, Oct 01, 2019 at 09:34:13PM +0300, Julian Anastasov wrote:
> >>
> >>Hello,
> >>
> >> On Tue, 1 Oct 2019, Haishuang Yan wrote:
> >>
> >>> This series patch include test cases for ipvs.
> >>>
> >>> The test topology is who as below:
> >>> +--+
> >>> | | |
> >>> | ns0 | ns1 |
> >>> | --- | ------|
> >>> | | veth01 | - | veth10 || veth12 ||
> >>> | ---peer ------|
> >>> | | || |
> >>> | --- || |
> >>> | | br0| |- peer |--|
> >>> | --- || |
> >>> | | || |
> >>> | -- peer -- --- |
> >>> | | veth02 | - | veth20 | | veth12 | |
> >>> | -- | -- --- |
> >>> | | ns2 |
> >>> | | |
> >>> +--+
> >>>
> >>> Test results:
> >>> # selftests: netfilter: ipvs.sh
> >>> # Testing DR mode...
> >>> # Testing NAT mode...
> >>> # Testing Tunnel mode...
> >>> # ipvs.sh: PASS
> >>> ok 6 selftests: netfilter: ipvs.sh
> >>>
> >>> Haishuang Yan (3):
> >>> selftests: netfilter: add ipvs test script
> >>> selftests: netfilter: add ipvs nat test case
> >>> selftests: netfilter: add ipvs tunnel test case
> >>
> >> Acked-by: Julian Anastasov
> >>
> >>> tools/testing/selftests/netfilter/Makefile | 2 +-
> >>> tools/testing/selftests/netfilter/ipvs.sh | 234
> >>> +
> >>> 2 files changed, 235 insertions(+), 1 deletion(-)
> >>> create mode 100755 tools/testing/selftests/netfilter/ipvs.sh
> >>
> >> Regards
> >>
> >> --
> >> Julian Anastasov
> >
> > I still prefer #!/bin/sh in 1/3. You never know what's in someone's
> > environment
> >
> > Cheers ... Duncan.
> >
>
> It??s also my preference too. "_"
>
> I have tested both #!/bin/bash and #!/bin/sh script, they all works properly.
Enter these 2 lines:
> ip(){ return 0; }
> export -f ip
Now try the #!/bin/bash script. If that now fails, try again with #!/bin/bash
changed to #!/bin/bash -p
Any better now?
Cheers ... Duncan.
Re: [PATCH v3 0/3] selftests: netfilter: introduce test cases for ipvs
On Tue, Oct 01, 2019 at 09:34:13PM +0300, Julian Anastasov wrote: > > Hello, > > On Tue, 1 Oct 2019, Haishuang Yan wrote: > > > This series patch include test cases for ipvs. > > > > The test topology is who as below: > > +--+ > > | | | > > | ns0 | ns1 | > > | --- | ------| > > | | veth01 | - | veth10 || veth12 || > > | ---peer ------| > > | | || | > > | --- || | > > | | br0| |- peer |--| > > | --- || | > > | | || | > > | -- peer -- --- | > > | | veth02 | - | veth20 | | veth12 | | > > | -- | -- --- | > > | | ns2 | > > | | | > > +--+ > > > > Test results: > > # selftests: netfilter: ipvs.sh > > # Testing DR mode... > > # Testing NAT mode... > > # Testing Tunnel mode... > > # ipvs.sh: PASS > > ok 6 selftests: netfilter: ipvs.sh > > > > Haishuang Yan (3): > > selftests: netfilter: add ipvs test script > > selftests: netfilter: add ipvs nat test case > > selftests: netfilter: add ipvs tunnel test case > > Acked-by: Julian Anastasov > > > tools/testing/selftests/netfilter/Makefile | 2 +- > > tools/testing/selftests/netfilter/ipvs.sh | 234 > > + > > 2 files changed, 235 insertions(+), 1 deletion(-) > > create mode 100755 tools/testing/selftests/netfilter/ipvs.sh > > Regards > > -- > Julian Anastasov I still prefer #!/bin/sh in 1/3. You never know what's in someone's environment Cheers ... Duncan.
Re: [PATCH v2 1/3] selftests: netfilter: add ipvs test script
On Tue, Oct 01, 2019 at 11:50:33AM +0200, Simon Horman wrote:
> On Fri, Sep 27, 2019 at 02:21:04PM +0800, Haishuang Yan wrote:
> > Test virutal server via directing routing for IPv4.
> >
> > Tested:
> >
> > # selftests: netfilter: ipvs.sh
> > # Testing DR mode...
> > # ipvs.sh: PASS
> > ok 6 selftests: netfilter: ipvs.sh
> >
> > Signed-off-by: Haishuang Yan
> > ---
> > v2: optimize test script
> > ---
> > tools/testing/selftests/netfilter/Makefile | 2 +-
> > tools/testing/selftests/netfilter/ipvs.sh | 184
> > +
> > 2 files changed, 185 insertions(+), 1 deletion(-)
> > create mode 100755 tools/testing/selftests/netfilter/ipvs.sh
> >
> > diff --git a/tools/testing/selftests/netfilter/Makefile
> > b/tools/testing/selftests/netfilter/Makefile
> > index 4144984..de1032b 100644
> > --- a/tools/testing/selftests/netfilter/Makefile
> > +++ b/tools/testing/selftests/netfilter/Makefile
> > @@ -2,6 +2,6 @@
> > # Makefile for netfilter selftests
> >
> > TEST_PROGS := nft_trans_stress.sh nft_nat.sh bridge_brouter.sh \
> > - conntrack_icmp_related.sh nft_flowtable.sh
> > + conntrack_icmp_related.sh nft_flowtable.sh ipvs.sh
> >
> > include ../lib.mk
> > diff --git a/tools/testing/selftests/netfilter/ipvs.sh
> > b/tools/testing/selftests/netfilter/ipvs.sh
> > new file mode 100755
> > index 000..658c06b
> > --- /dev/null
> > +++ b/tools/testing/selftests/netfilter/ipvs.sh
> > @@ -0,0 +1,184 @@
> > +#!/bin/sh
> > +# SPDX-License-Identifier: GPL-2.0
> > +#
> > +# End-to-end ipvs test suite
> > +# Topology:
> > +#--+
> > +# | |
> > +# ns0 | ns1 |
> > +# --- | ------|
> > +# | veth01 | - | veth10 || veth12 ||
> > +# ---peer ------|
> > +# | || |
> > +# --- || |
> > +# | br0| |- peer |--|
> > +# --- || |
> > +# | || |
> > +# -- peer -- --- |
> > +# | veth02 | - | veth20 | | veth21 | |
> > +# -- | -- --- |
> > +# | ns2 |
> > +# | |
> > +#--+
> > +#
> > +# We assume that all network driver are loaded
> > +#
> > +
> > +# Kselftest framework requirement - SKIP code is 4.
> > +ksft_skip=4
> > +ret=0
> > +GREEN='\033[0;92m'
> > +RED='\033[0;31m'
> > +NC='\033[0m' # No Color
> > +
> > +readonly port=8080
> > +
> > +readonly vip_v4=207.175.44.110
> > +readonly cip_v4=10.0.0.2
> > +readonly gip_v4=10.0.0.1
> > +readonly dip_v4=172.16.0.1
> > +readonly rip_v4=172.16.0.2
> > +readonly sip_v4=10.0.0.3
> > +
> > +readonly infile="$(mktemp)"
> > +readonly outfile="$(mktemp)"
> > +
> > +sysipvsnet=/proc/sys/net/ipv4/vs/
> > +if [ ! -d /proc/sys/net/ipv4/vs/ ]; then
> > +modprobe -q ip_vs
> > +if [ $? -ne 0 ]; then
> > +echo "SKIP: Could not run test without ipvs module"
> > + exit $ksft_skip
> > +fi
> > +fi
> > +
> > +ip -Version > /dev/null 2>&1
> > +if [ $? -ne 0 ]; then
> > + echo "SKIP: Could not run test without ip tool"
> > + exit $ksft_skip
> > +fi
> > +
> > +ipvsadm -v > /dev/null 2>&1
> > +if [ $? -ne 0 ]; then
> > + echo "SKIP: Could not run test without ipvsadm"
> > + exit $ksft_skip
> > +fi
> > +
> > +nc --version > /dev/null 2>&1
> > +if [ $? -ne 0 ]; then
> > + echo "SKIP: Could not run test without ncat"
> > + exit $ksft_skip
> > +fi
> > +
> > +setup() {
> > +ip netns add ns0
> > +ip netns add ns1
> > +ip netns add ns2
> > +
> > +ip link add veth01 netns ns0 type veth peer name veth10 netns ns1
> > +ip link add veth02 netns ns0 type veth peer name veth20 netns ns2
> > +ip link add veth12 netns ns1 type veth peer name veth21 netns ns2
> > +
> > +ip netns exec ns0 ip link set veth01 up
> > +ip netns exec ns0 ip link set veth02 up
> > +ip netns exec ns0 ip link add br0 type bridge
> > +ip netns exec ns0 ip link set veth01 master br0
> > +ip netns exec ns0 ip link set veth02 master br0
> > +ip netns exec ns0 ip link set br0 up
> > +ip netns exec ns0 ip addr add ${cip_v4}/24 dev br0
> > +
> > +ip netns exec ns1 ip link set lo up
> > +ip netns exec ns1 ip link set veth10 up
> > +ip netns exec ns1 ip addr add ${gip_v4}/24 dev veth10
> > +ip netns exec ns1 ip link set veth12 up
> > +ip netns exec ns1 ip addr add ${dip_v4}/24 dev veth12
>
