Re: [ANNOUNCE] Git v2.31.0-rc1

[Eric Sunshine]

On Wed, Mar 3, 2021 at 7:23 PM Junio C Hamano  wrote:
> Pratyush Yadav (1):
>   git-gui: remove lines starting with the comment character

Is there some way that this can be removed from v2.31.0 before final
release? It badly breaks git-gui on macOS[1,2] to the point of making
it unusable (Tcl throws errors at launch time and when trying to
commit, and committing is 100% broken).

[1]: 
https://lore.kernel.org/git/capig+ct-sfgmdi9-6aekf85ntoixeqddjjk-pyuhdttvae-...@mail.gmail.com/
[2]: https://lore.kernel.org/git/20210228231110.24076-1-sunsh...@sunshineco.com/

Re: [ANNOUNCE] Git v2.31.0-rc1

[Eric Sunshine]

On Wed, Mar 3, 2021 at 7:23 PM Junio C Hamano  wrote:
> Eric Sunshine (3):
>   worktree: teach `repair` to fix multi-directional breakage

The merge message associated with this change is:

"git worktree repair" learned to deal with the case where both the
repository and the worktree moved.

which seems worth mentioning in the v2.31.0 release notes, so it's a
bit surprising that it is not mentioned anywhere. I haven't
investigated how the release notes are generated from the merge
messages, so it is unclear if this is a mere oversight, an intentional
omission, or a tooling error.

Re: [PATCH 2/2] send-email: supply a --send-delay=1 by default

[Eric Sunshine]

On Sun, Mar 25, 2018 at 2:28 PM, Ævar Arnfjörð Bjarmason
 wrote:
> The earlier change to add this option described the problem this
> option is trying to solve.
>
> This turns it on by default with a value of 1 second, which'll
> hopefully solve it, and if not user reports as well as the
> X-Mailer-Send-Delay header should help debug it.
> [...]
> Signed-off-by: Ævar Arnfjörð Bjarmason 
> ---
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> @@ -3070,7 +3070,18 @@ sendemail.smtpReloginDelay::
>  sendemail.smtpSendDelay::
> Seconds wait in between message sending before sending another
> -   message. Set it to 0 to impose no extra delay, defaults to 0.
> +   message. Set it to 0 to impose no extra delay, defaults to 1
> +   to wait 1 second.
> ++
> +The reason for imposing a default delay is because certain popular
> +E-Mail clients such as Google's GMail completely ignore the "Date"
> +header, which format-patch is careful to set such that the patches
> +will be displayed in order, and instead sort by the time the E-mail
> +was received.

A minor point: Are you sure that it's git-format-patch that's being
careful about arranging Date: to display in the desired order, and not
git-send-email? Looking at old patches I still have hanging around
which were created with git-format-patch, I see the Date: headers are
wildly out of order, presumably because the date is taken from
Author-Date: and the patches were heavily rebased.

Re: [PATCH 2/2] send-email: supply a --send-delay=1 by default

[Eric Sunshine]

On Sun, Mar 25, 2018 at 2:28 PM, Ævar Arnfjörð Bjarmason
 wrote:
> The earlier change to add this option described the problem this
> option is trying to solve.
>
> This turns it on by default with a value of 1 second, which'll
> hopefully solve it, and if not user reports as well as the
> X-Mailer-Send-Delay header should help debug it.
> [...]
> Signed-off-by: Ævar Arnfjörð Bjarmason 
> ---
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> @@ -3070,7 +3070,18 @@ sendemail.smtpReloginDelay::
>  sendemail.smtpSendDelay::
> Seconds wait in between message sending before sending another
> -   message. Set it to 0 to impose no extra delay, defaults to 0.
> +   message. Set it to 0 to impose no extra delay, defaults to 1
> +   to wait 1 second.
> ++
> +The reason for imposing a default delay is because certain popular
> +E-Mail clients such as Google's GMail completely ignore the "Date"
> +header, which format-patch is careful to set such that the patches
> +will be displayed in order, and instead sort by the time the E-mail
> +was received.

A minor point: Are you sure that it's git-format-patch that's being
careful about arranging Date: to display in the desired order, and not
git-send-email? Looking at old patches I still have hanging around
which were created with git-format-patch, I see the Date: headers are
wildly out of order, presumably because the date is taken from
Author-Date: and the patches were heavily rebased.