RE: [PATCH 2.6.25-rc1] i2c-i801: SMBus patch for Intel ICH10 DeviceID's
> >Patch applied. Please note that your e-mail client corrupted the patch >and I had to edit it manually before it would apply properly. Next time >please make sure that the patch is left unchanged so that it applies >directly. > >I left out this last part as it was already sent separately to the PCI >subsystem maintainer. I will wait for Greg to pick it before I send the >i2c-i801 update upstream. > >Thanks, >-- >Jean Delvare > Thank you very much. Sorry about the email client and wordwrap. I was just about to repost it using a different email client, thanks for cleaning it up for me. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6.25-rc1] i2c-i801: SMBus patch for Intel ICH10 DeviceID's
This patch adds the Intel ICH10 SMBus Controller DeviceID's and updates
Tolapai support.
Signed-off-by: Jason Gaston <[EMAIL PROTECTED]>
--- linux-2.6.25-rc1/Documentation/i2c/busses/i2c-i801.orig
2008-02-11 15:17:33.0 -0800
+++ linux-2.6.25-rc1/Documentation/i2c/busses/i2c-i801 2008-02-11
15:18:13.0 -0800
@@ -12,8 +12,9 @@
* Intel 82801G (ICH7)
* Intel 631xESB/632xESB (ESB2)
* Intel 82801H (ICH8)
- * Intel ICH9
+ * Intel 82801I (ICH9)
* Intel Tolapai
+ * Intel ICH10
Datasheets: Publicly available at the Intel website
Authors:
--- linux-2.6.25-rc1/drivers/i2c/busses/i2c-i801.c.orig 2008-02-11
15:10:52.0 -0800
+++ linux-2.6.25-rc1/drivers/i2c/busses/i2c-i801.c 2008-02-11
16:30:11.0 -0800
@@ -40,7 +40,9 @@
82801G (ICH7) 0x27da 32 hard yes yes yes
82801H (ICH8) 0x283e 32 hard yes yes yes
82801I (ICH9) 0x2930 32 hard yes yes yes
- Tolapai 0x5032 32 hard yes ? ?
+ Tolapai 0x5032 32 hard yes yes yes
+ ICH10 0x3a30 32 hard yes yes yes
+ ICH10 0x3a60 32 hard yes yes yes
Features supported by this driver:
Software PEC no
@@ -588,6 +590,8 @@
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_5) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_6) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TOLAPAI_1)
},
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_4)
},
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_5)
},
{ 0, }
};
@@ -608,10 +612,12 @@
case PCI_DEVICE_ID_INTEL_ESB2_17:
case PCI_DEVICE_ID_INTEL_ICH8_5:
case PCI_DEVICE_ID_INTEL_ICH9_6:
+ case PCI_DEVICE_ID_INTEL_TOLAPAI_1:
+ case PCI_DEVICE_ID_INTEL_ICH10_4:
+ case PCI_DEVICE_ID_INTEL_ICH10_5:
i801_features |= FEATURE_I2C_BLOCK_READ;
/* fall through */
case PCI_DEVICE_ID_INTEL_82801DB_3:
- case PCI_DEVICE_ID_INTEL_TOLAPAI_1:
i801_features |= FEATURE_SMBUS_PEC;
i801_features |= FEATURE_BLOCK_BUFFER;
break;
--- linux-2.6.25-rc1/drivers/i2c/busses/Kconfig.orig2008-02-11
15:10:18.0 -0800
+++ linux-2.6.25-rc1/drivers/i2c/busses/Kconfig 2008-02-11
16:32:10.0 -0800
@@ -177,6 +177,8 @@
ESB2
ICH8
ICH9
+ Tolapai
+ ICH10
This driver can also be built as a module. If so, the module
will be called i2c-i801.
--- linux-2.6.25-rc1/include/linux/pci_ids.h.orig 2008-02-11
15:18:58.0 -0800
+++ linux-2.6.25-rc1/include/linux/pci_ids.h2008-02-11
15:20:45.0 -0800
@@ -2373,6 +2373,12 @@
#define PCI_DEVICE_ID_INTEL_MCH_PC10x359a
#define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e
#define PCI_DEVICE_ID_INTEL_IOAT_CNB 0x360b
+#define PCI_DEVICE_ID_INTEL_ICH10_00x3a14
+#define PCI_DEVICE_ID_INTEL_ICH10_10x3a16
+#define PCI_DEVICE_ID_INTEL_ICH10_20x3a18
+#define PCI_DEVICE_ID_INTEL_ICH10_30x3a1a
+#define PCI_DEVICE_ID_INTEL_ICH10_40x3a30
+#define PCI_DEVICE_ID_INTEL_ICH10_50x3a60
#define PCI_DEVICE_ID_INTEL_IOAT_SNB 0x402f
#define PCI_DEVICE_ID_INTEL_IOAT_SCNB 0x65ff
#define PCI_DEVICE_ID_INTEL_TOLAPAI_0 0x5031
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.24] ata_piix: IDE mode SATA patch for Intel ICH10 DeviceID's
>-Original Message-
>From: Jeff Garzik [mailto:[EMAIL PROTECTED]
>Sent: Tuesday, January 29, 2008 9:14 AM
>To: Gaston, Jason D
>Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org;
>[EMAIL PROTECTED]
>Subject: Re: [PATCH 2.6.24] ata_piix: IDE mode SATA patch for Intel
ICH10
>DeviceID's
>
>Jason Gaston wrote:
>> This patch adds the Intel ICH10 IDE mode SATA Controller DeviceID's.
>>
>> Signed-off-by: Jason Gaston <[EMAIL PROTECTED]>
>>
>> --- linux-2.6.24/drivers/ata/ata_piix.c.orig 2008-01-24
>14:58:37.0 -0800
>> +++ linux-2.6.24/drivers/ata/ata_piix.c 2008-01-28
14:58:22.0 -
>0800
>> @@ -263,6 +263,14 @@
>> { 0x8086, 0x292e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci
},
>> /* SATA Controller IDE (Tolapai) */
>> { 0x8086, 0x5028, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
tolapai_sata_ahci },
>> +/* SATA Controller IDE (ICH10) */
>> +{ 0x8086, 0x3a00, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci
},
>> +/* SATA Controller IDE (ICH10) */
>> +{ 0x8086, 0x3a06, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata
},
>> +/* SATA Controller IDE (ICH10) */
>> +{ 0x8086, 0x3a20, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci
},
>> +/* SATA Controller IDE (ICH10) */
>> +{ 0x8086, 0x3a26, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata
},
>
>can these do AHCI mode without losing any PATA ports?
>
>if so, I would prefer to always drive the hardware in AHCI mode, if it
>is capable of doing so.
They do not have PATA.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.24] pci_ids: patch for Intel ICH10 DeviceID's
>-Original Message- >From: Grant Grundler [mailto:[EMAIL PROTECTED] >Sent: Monday, January 28, 2008 4:22 PM >To: Gaston, Jason D >Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; linux- >[EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] >Subject: Re: [PATCH 2.6.24] pci_ids: patch for Intel ICH10 DeviceID's > >On Mon, Jan 28, 2008 at 05:20:36PM -0800, Jason Gaston wrote: >> This patch adds the Intel ICH10 LPC and SMBus Controller DeviceID's. > >Jason, >two questions: >Have you submitted these to pciids.sf.net? >Where are these used in the kernel? > >thanks, >grant > >> >> Signed-off-by: Jason Gaston <[EMAIL PROTECTED]> >> >> --- linux-2.6.24/include/linux/pci_ids.h.orig2008-01-24 >14:58:37.0 -0800 >> +++ linux-2.6.24/include/linux/pci_ids.h 2008-01-28 >15:05:41.0 -0800 >> @@ -2339,6 +2339,12 @@ >> #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a >> #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e >> #define PCI_DEVICE_ID_INTEL_IOAT_CNB0x360b >> +#define PCI_DEVICE_ID_INTEL_ICH10_0 0x3a14 >> +#define PCI_DEVICE_ID_INTEL_ICH10_1 0x3a16 >> +#define PCI_DEVICE_ID_INTEL_ICH10_2 0x3a18 >> +#define PCI_DEVICE_ID_INTEL_ICH10_3 0x3a1a >> +#define PCI_DEVICE_ID_INTEL_ICH10_4 0x3a30 >> +#define PCI_DEVICE_ID_INTEL_ICH10_5 0x3a60 >> #define PCI_DEVICE_ID_INTEL_IOAT_SNB0x402f >> #define PCI_DEVICE_ID_INTEL_IOAT_SCNB 0x65ff >> #define PCI_DEVICE_ID_INTEL_TOLAPAI_0 0x5031 Yes, these have been submitted to pciids.sf.net. I am also in the process up updating the pci.ids strings by adding "ICH10" to them. These pci_ids.h entries are used in the drivers/i2c/busses/i2c-i801.c driver and the /arch/x86/pci/irq.c file. Thank you, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.23]ata_piix: SATA 2port controller port map fix
>this was full of spaces, and should be converted to tabs (I did this
>manually)
>
>In the future, make sure to run your patch through
>scripts/checkpatch.pl. Some of that script's complaints are a bit
>insane, but most are good.
>
>> static const struct piix_map_db *piix_map_db_table[] = {
>> [ich5_sata] = &ich5_map_db,
>> [ich6_sata] = &ich6_map_db,
>> @@ -463,6 +476,7 @@
>> [ich6m_sata_ahci] = &ich6m_map_db,
>> [ich8_sata_ahci]= &ich8_map_db,
>> [tolapai_sata_ahci] = &tolapai_map_db,
>> +[ich9_2port_sata] = &ich9_2port_map_db,
>> };
>>
>> static struct ata_port_info piix_port_info[] = {
>> @@ -587,6 +601,17 @@
>> .udma_mask = ATA_UDMA6,
>> .port_ops = &piix_sata_ops,
>> },
>> +
>> +/* ich9_2port_sata: 12: */
>
>changed this to
>
> [ich9_2port_sata] =
>
>since we have started using the (C99? gcc?) method of initializing
>piix_port_info[] array entries based on the given index, rather than
>simply noting the index in a comment and depending on the order of
other
>entries not to change.
>
> Jeff
Thank you Jeff! I guess it is time to switch email clients, as this one
keeps trashing my file import. I thought I had it worked out, guess
not.
Thanks again,
Jason
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.23-rc4][reRESEND] i2c-i801: SMBus patch for Intel Tolapai
>-Original Message-
>From: Jean Delvare [mailto:[EMAIL PROTECTED]
>Sent: Friday, August 31, 2007 8:51 AM
>To: Gaston, Jason D
>Cc: linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]
>Subject: Re: [PATCH 2.6.23-rc4][reRESEND] i2c-i801: SMBus patch for
Intel
>Tolapai
>
>Hi Jason,
>
>On Thu, 30 Aug 2007 20:42:58 -0700, Jason Gaston wrote:
>> Resend with uppercase define.
>>
>> This updated patch adds the Intel Tolapai SMBus Controller DID's.
>> This patch relies on the Tolapai patch to pci_ids.h
>>
>> Signed-off-by: Jason Gaston <[EMAIL PROTECTED]>
>>
>> --- linux-2.6.23-rc4/drivers/i2c/busses/i2c-i801.c.orig
2007-08-27
>18:32:35.0 -0700
>> +++ linux-2.6.23-rc4/drivers/i2c/busses/i2c-i801.c 2007-08-30
>20:25:10.0 -0700
>> @@ -34,6 +34,7 @@
>> ESB2269B
>> ICH8283E
>> ICH92930
>> +Tolapai 5032
>> This driver supports several versions of Intel's I/O Controller
Hubs
>(ICH).
>> For SMBus support, they are similar to the PIIX4 and are part
>> of Intel's '810' and other chipsets.
>> @@ -543,6 +544,7 @@
>> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_17)
},
>> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_5) },
>> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_6) },
>> +{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TOLAPAI_1)
},
>> { 0, }
>> };
>>
>> @@ -563,6 +565,7 @@
>> case PCI_DEVICE_ID_INTEL_ESB2_17:
>> case PCI_DEVICE_ID_INTEL_ICH8_5:
>> case PCI_DEVICE_ID_INTEL_ICH9_6:
>> +case PCI_DEVICE_ID_INTEL_TOLAPAI_1:
>> isich4 = 1;
>> break;
>> default:
>
>Applied together with the Documentation patch (no need for a separate
>patch). Note that I will have to wait for Greg to pick the pci_ids.h
>patch before I can push this one.
>
>--
>Jean Delvare
Jean,
The pci_ids.h file is updated in 2.6.23-rc8. Can you push this
i2c-i801.c patch?
Thanks,
Jason
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.23-rc4][reRESEND] ata_piix: IDE mode SATA patch for Intel Tolapai
>-Original Message-
>From: Jeff Garzik [mailto:[EMAIL PROTECTED]
>Sent: Friday, August 31, 2007 12:51 AM
>To: Gaston, Jason D
>Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org;
>[EMAIL PROTECTED]
>Subject: Re: [PATCH 2.6.23-rc4][reRESEND] ata_piix: IDE mode SATA patch
for
>Intel Tolapai
>
>Jason Gaston wrote:
>> Resend trying to remove 8-bit characters in the email.
>>
>> This patch adds the Intel Tolapai IDE mode SATA controller DID's.
>>
>> Signed-off-by: Jason Gaston <[EMAIL PROTECTED]>
>
>applied
Jeff,
I just noticed that the following section came through as spaces instead
of tabs. Do I need to resend a corrected version?
+static const struct piix_map_db tolapai_map_db = {
+.mask = 0x3,
+.port_enable = 0x3,
+.map = {
+/* PM PS SM SS MAP */
+{ P0, NA, P1, NA }, /* 00b */
+{ RV, RV, RV, RV }, /* 01b */
+{ RV, RV, RV, RV }, /* 10b */
+{ RV, RV, RV, RV },
+},
+};
+
Thanks,
Jason
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch for Intel Tolapai
>-Original Message-
>From: Jeff Garzik [mailto:[EMAIL PROTECTED]
>Sent: Friday, September 07, 2007 3:39 PM
>To: Gaston, Jason D
>Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org
>Subject: Re: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch
for
>Intel Tolapai
>
>Gaston, Jason D wrote:
>>> -Original Message-
>>> From: Gaston, Jason D
>>> Sent: Friday, August 31, 2007 10:10 AM
>>> To: 'Jeff Garzik'
>>> Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org
>>> Subject: RE: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch
>> for
>>> Intel Tolapai
>>>
>>> This device has both AHCI and RAID modes that use the ahci driver.
>> Only
>>> the RAID mode DID's are being added as the PCI class code support
will
>>> cover the AHCI mode. Looking at the Generic, PCI class code support
>>> section, it uses "board_ahci". I assumed that they should be the
same
>> as
>>> the generic class code support is working on this platform.
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>>
>>>> -Original Message-
>>>> From: Jeff Garzik [mailto:[EMAIL PROTECTED]
>>>> Sent: Friday, August 31, 2007 12:47 AM
>>>> To: Gaston, Jason D
>>>> Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org
>>>> Subject: Re: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA
patch
>> for
>>>> Intel Tolapai
>>>>
>>>> Jason Gaston wrote:
>>>>> Resend trying to remove 8-bit characters in the email.
>>>>>
>>>>> This patch adds the Intel Tolapai RAID controller DID's for SATA
>>> support.
>>>>> Signed-off-by: Jason Gaston <[EMAIL PROTECTED]>
>>>>>
>>>>> --- linux-2.6.23-rc4/drivers/ata/ahci.c.orig 2007-08-27
>>>> 18:32:35.0 -0700
>>>>> +++ linux-2.6.23-rc4/drivers/ata/ahci.c 2007-08-28
>>> 16:58:11.0 -
>>>> 0700
>>>>> @@ -411,6 +411,8 @@
>>>>> { PCI_VDEVICE(INTEL, 0x292f), board_ahci_pi }, /* ICH9M */
>>>>> { PCI_VDEVICE(INTEL, 0x294d), board_ahci_pi }, /* ICH9 */
>>>>> { PCI_VDEVICE(INTEL, 0x294e), board_ahci_pi }, /* ICH9M */
>>>>> + { PCI_VDEVICE(INTEL, 0x502a), board_ahci }, /* Tolapai */
>>>>> + { PCI_VDEVICE(INTEL, 0x502b), board_ahci }, /* Tolapai */
>>>> Why did you not use board_ahci_pi? Is the AHCI ports-implemented
>>>> register unreliable on this platform?
>>
>> Jeff,
>>
>> Do I need to change this to board_ahci_pi or is it ok to leave it at
>> board_ahci, which will be used by the AHCI class code devices?
>
>You are the one who needs to answer this question ;-)
>
>Most new Intel AHCI have a sane and reliable Ports-Implemented register
>value even across reset, unlike earlier ones or some clones. For
those,
>we use board_ahci_pi.
>
>If PI is not reliable across reset or if BIOS is absent (yes we care
>about that case, when we do our own PCI resume for example), then you
>should use board_ahci.
>
> Jeff
At this time, I don't have any way to test those particular DeviceID's
and I know that the AHCI mode DeviceID works by using the class code
support. So, I would like to just leave them at they are, if that is
ok.
Thanks,
Jason
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch for Intel Tolapai
>-Original Message-
>From: Gaston, Jason D
>Sent: Friday, August 31, 2007 10:10 AM
>To: 'Jeff Garzik'
>Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org
>Subject: RE: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch
for
>Intel Tolapai
>
>This device has both AHCI and RAID modes that use the ahci driver.
Only
>the RAID mode DID's are being added as the PCI class code support will
>cover the AHCI mode. Looking at the Generic, PCI class code support
>section, it uses "board_ahci". I assumed that they should be the same
as
>the generic class code support is working on this platform.
>
>Thanks,
>
>Jason
>
>
>>-Original Message-
>>From: Jeff Garzik [mailto:[EMAIL PROTECTED]
>>Sent: Friday, August 31, 2007 12:47 AM
>>To: Gaston, Jason D
>>Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org
>>Subject: Re: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch
for
>>Intel Tolapai
>>
>>Jason Gaston wrote:
>>> Resend trying to remove 8-bit characters in the email.
>>>
>>> This patch adds the Intel Tolapai RAID controller DID's for SATA
>support.
>>>
>>> Signed-off-by: Jason Gaston <[EMAIL PROTECTED]>
>>>
>>> --- linux-2.6.23-rc4/drivers/ata/ahci.c.orig2007-08-27
>>18:32:35.0 -0700
>>> +++ linux-2.6.23-rc4/drivers/ata/ahci.c 2007-08-28
>16:58:11.0 -
>>0700
>>> @@ -411,6 +411,8 @@
>>> { PCI_VDEVICE(INTEL, 0x292f), board_ahci_pi }, /* ICH9M */
>>> { PCI_VDEVICE(INTEL, 0x294d), board_ahci_pi }, /* ICH9 */
>>> { PCI_VDEVICE(INTEL, 0x294e), board_ahci_pi }, /* ICH9M */
>>> + { PCI_VDEVICE(INTEL, 0x502a), board_ahci }, /* Tolapai */
>>> + { PCI_VDEVICE(INTEL, 0x502b), board_ahci }, /* Tolapai */
>>
>>Why did you not use board_ahci_pi? Is the AHCI ports-implemented
>>register unreliable on this platform?
Jeff,
Do I need to change this to board_ahci_pi or is it ok to leave it at
board_ahci, which will be used by the AHCI class code devices?
Thanks,
Jason
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.23-rc4][reRESEND] irq: irq and pci_ids patch for Intel Tolapai
>-Original Message- >From: Gaston, Jason D >Sent: Thursday, August 30, 2007 8:34 PM >To: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; linux- >[EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; >Gaston, Jason D >Subject: [PATCH 2.6.23-rc4][reRESEND] irq: irq and pci_ids patch for Intel >Tolapai > >Resend with uppercase define. > >This updated patch adds the Intel Tolapai LPC and SMBus controller DID's. > >Signed-off-by: Jason Gaston <[EMAIL PROTECTED]> > >--- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 >18:32:35.0 -0700 >+++ linux-2.6.23-rc4/arch/i386/pci/irq.c 2007-08-30 20:23:49.0 - >0700 >@@ -550,6 +550,7 @@ > case PCI_DEVICE_ID_INTEL_ICH9_3: > case PCI_DEVICE_ID_INTEL_ICH9_4: > case PCI_DEVICE_ID_INTEL_ICH9_5: >+ case PCI_DEVICE_ID_INTEL_TOLAPAI_0: > r->name = "PIIX/ICH"; > r->get = pirq_piix_get; > r->set = pirq_piix_set; >--- linux-2.6.23-rc4/include/linux/pci_ids.h.orig 2007-08-27 >18:32:35.0 -0700 >+++ linux-2.6.23-rc4/include/linux/pci_ids.h 2007-08-30 >20:23:08.0 -0700 >@@ -2293,6 +2293,8 @@ > #define PCI_DEVICE_ID_INTEL_MCH_PC0x3599 > #define PCI_DEVICE_ID_INTEL_MCH_PC1 0x359a > #define PCI_DEVICE_ID_INTEL_E7525_MCH 0x359e >+#define PCI_DEVICE_ID_INTEL_TOLAPAI_0 0x5031 >+#define PCI_DEVICE_ID_INTEL_TOLAPAI_1 0x5032 > #define PCI_DEVICE_ID_INTEL_82371SB_0 0x7000 > #define PCI_DEVICE_ID_INTEL_82371SB_1 0x7010 > #define PCI_DEVICE_ID_INTEL_82371SB_2 0x7020 Greg, Is this patch acceptable? I need to get this in before the i2c-i801 patch will be accepted. Thanks, Jason - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai
>> Please do submit new PCI device IDs to pciids.sf.net project. > >Yep. FYI: I have already posted the Tolapai DID's and device strings to pciids.sf.net. Thanks, Jason - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch for Intel Tolapai
This device has both AHCI and RAID modes that use the ahci driver. Only
the RAID mode DID's are being added as the PCI class code support will
cover the AHCI mode. Looking at the Generic, PCI class code support
section, it uses "board_ahci". I assumed that they should be the same
as the generic class code support is working on this platform.
Thanks,
Jason
>-Original Message-
>From: Jeff Garzik [mailto:[EMAIL PROTECTED]
>Sent: Friday, August 31, 2007 12:47 AM
>To: Gaston, Jason D
>Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org
>Subject: Re: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch
for
>Intel Tolapai
>
>Jason Gaston wrote:
>> Resend trying to remove 8-bit characters in the email.
>>
>> This patch adds the Intel Tolapai RAID controller DID's for SATA
support.
>>
>> Signed-off-by: Jason Gaston <[EMAIL PROTECTED]>
>>
>> --- linux-2.6.23-rc4/drivers/ata/ahci.c.orig 2007-08-27
>18:32:35.0 -0700
>> +++ linux-2.6.23-rc4/drivers/ata/ahci.c 2007-08-28
16:58:11.0 -
>0700
>> @@ -411,6 +411,8 @@
>> { PCI_VDEVICE(INTEL, 0x292f), board_ahci_pi }, /* ICH9M */
>> { PCI_VDEVICE(INTEL, 0x294d), board_ahci_pi }, /* ICH9 */
>> { PCI_VDEVICE(INTEL, 0x294e), board_ahci_pi }, /* ICH9M */
>> +{ PCI_VDEVICE(INTEL, 0x502a), board_ahci }, /* Tolapai */
>> +{ PCI_VDEVICE(INTEL, 0x502b), board_ahci }, /* Tolapai */
>
>Why did you not use board_ahci_pi? Is the AHCI ports-implemented
>register unreliable on this platform?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.23-rc4][RESEND] ahci: RAID mode SATA patch for Intel Tolapai
>-Original Message-
>From: Gaston, Jason D
>Sent: Thursday, August 30, 2007 5:54 PM
>To: [EMAIL PROTECTED]; Gaston, Jason D
>Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org
>Subject: [PATCH 2.6.23-rc4][RESEND] ahci: RAID mode SATA patch for Intel
>Tolapai
>
>Resend without wordwrap.
>
>This patch adds the Intel Tolapai RAID controller DID's for SATA support.
>
>Signed-off-by: Jason Gaston <[EMAIL PROTECTED]>
>
>--- linux-2.6.23-rc4/drivers/ata/ahci.c.orig 2007-08-27
>18:32:35.0 -0700
>+++ linux-2.6.23-rc4/drivers/ata/ahci.c2007-08-28 16:58:11.0 -
>0700
>@@ -411,6 +411,8 @@
> { PCI_VDEVICE(INTEL, 0x292f), board_ahci_pi }, /* ICH9M */
> { PCI_VDEVICE(INTEL, 0x294d), board_ahci_pi }, /* ICH9 */
> { PCI_VDEVICE(INTEL, 0x294e), board_ahci_pi }, /* ICH9M */
>+ { PCI_VDEVICE(INTEL, 0x502a), board_ahci }, /* Tolapai */
>+ { PCI_VDEVICE(INTEL, 0x502b), board_ahci }, /* Tolapai */
>
> /* JMicron 360/1/3/5/6, match class to avoid IDE function */
> { PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
I am having trouble sending these patches. When I look in the LKML.org message
archive, I see "=A0" and "=20" in the messages. I am using KMail to send
these, I have wordwrap turned off and am inserting the patch file. Does anyone
know what I am doing wrong?
Thanks,
Jason
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller
>-Original Message- >From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] >Sent: Thursday, July 05, 2007 1:30 PM >To: Thorsten Leemhuis >Cc: Thorsten Leemhuis; Chuck Ebbert; Jeff Garzik; IDE/ATA >development list; Gaston, Jason D; Alan Cox; >linux-kernel@vger.kernel.org; [EMAIL PROTECTED] >Subject: Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel >Santa Rosa PATA controller > >On Wednesday, 4. July 2007, Thorsten Leemhuis wrote: >> >> Maybe Alan or someone from Intel can answer that and thus >tell us how to >> move forward; it would be really nice to get the patch that >started this >> thread (it got posted by Chuck again today) could go into >2.6.22, but I >> assume the time runs away... >> >Jeff is on holiday and Intel doesn't respond at all... > >So, if someone has a ICH5 or ICH7/7-R with a ATA133 captable >HDD... could >you please try the following patch? (Of course, I don't know >if it works,... >It may cause data loss, serve corruption, or damage your >controller/hdd/pc, >so make backups and keep a first-aid kit handy!) > >> > On the other hand, we can leave it, because of a >"off-by-one error" in ata_piix.c, >> > do_pata_set_dmamode, line ~770: >> > [...] >> > >Thanks, > Chr. > > I quickly tried this patch on an ICH7-R system with an ATA133 Maxtor HD and it did not seem to do anything bad. I see no difference in function or performance with the patch. Jason - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] Add new ICH9M pci id (8086:2850) to ata_piix id list
DID 2850 is not a SATA controller. This is an ICH8 PATA controller DID.
Jason
>-Original Message-
>From: [EMAIL PROTECTED] [mailto:linux-ide-
>[EMAIL PROTECTED] On Behalf Of Michal Piotrowski
>Sent: Sunday, June 17, 2007 2:36 PM
>To: Maurizio Monge
>Cc: linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; Alan Cox;
Jeff
>Garzik
>Subject: Re: [PATCH] Add new ICH9M pci id (8086:2850) to ata_piix id
list
>
>Hi,
>
>Maurizio Monge pisze:
>> To make ata_piix recognize my ich9m chip i had to apply the
>> modification that follows.
>>
>> Best regards
>> Maurizio Monge
>>
>>
>> diff -Nurb old/drivers/ata/ata_piix.c new/drivers/ata/ata_piix.c
>> --- old/drivers/ata/ata_piix.c 2007-06-17 23:06:12.0 +0200
>> +++ new/drivers/ata/ata_piix.c 2007-06-17 23:15:57.0 +0200
>> @@ -243,6 +243,8 @@
>>{ 0x8086, 0x292d, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci
},
>>/* SATA Controller IDE (ICH9M) */
>>{ 0x8086, 0x292e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci
},
>> + /* Mobile SATA Controller IDE (ICH9M) */
>> + { 0x8086, 0x2850, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
ich8_sata_ahci },
>
>http://pci-ids.ucw.cz/iii/?i=80862850
>
>Is this really a SATA controller?
>((ICH8M/ICH8M-E) IDE Controller)
>
>Regards,
>Michal
>
>--
>LOG
>http://www.stardust.webpages.pl/log/
>-
>To unsubscribe from this list: send the line "unsubscribe linux-ide" in
>the body of a message to [EMAIL PROTECTED]
>More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.22-rc2] pci_ids: update patch for Intel ICH9M
Yes, please change them in the 2.6.21.x kernel as well. Thank you, Jason >-Original Message- >From: Andrew Morton [mailto:[EMAIL PROTECTED] >Sent: Tuesday, May 29, 2007 3:26 PM >To: Gaston, Jason D >Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; linux- >[EMAIL PROTECTED]; [EMAIL PROTECTED] >Subject: Re: [PATCH 2.6.22-rc2] pci_ids: update patch for Intel ICH9M > >On Fri, 25 May 2007 12:03:31 -0700 >Jason Gaston <[EMAIL PROTECTED]> wrote: > >> This patch updates the Intel ICH9M LPC Controller DID's, due to a >> specification change. >> >> Signed-off-by: __Jason Gaston <[EMAIL PROTECTED]> >> >> --- linux-2.6.22-rc2/include/linux/pci_ids.h.orig2007-05-25 >> 11:42:11.0 -0700 >> +++ linux-2.6.22-rc2/include/linux/pci_ids.h 2007-05-25 >11:43:28.0 >> -0700 >> @@ -2266,11 +2266,11 @@ >> #define PCI_DEVICE_ID_INTEL_ICH8_5 0x283e >> #define PCI_DEVICE_ID_INTEL_ICH8_6 0x2850 >> #define PCI_DEVICE_ID_INTEL_ICH9_0 0x2910 >> -#define PCI_DEVICE_ID_INTEL_ICH9_1 0x2911 >> +#define PCI_DEVICE_ID_INTEL_ICH9_1 0x2917 >> #define PCI_DEVICE_ID_INTEL_ICH9_2 0x2912 >> #define PCI_DEVICE_ID_INTEL_ICH9_3 0x2913 >> #define PCI_DEVICE_ID_INTEL_ICH9_4 0x2914 >> -#define PCI_DEVICE_ID_INTEL_ICH9_5 0x2915 >> +#define PCI_DEVICE_ID_INTEL_ICH9_5 0x2919 >> #define PCI_DEVICE_ID_INTEL_ICH9_6 0x2930 >> #define PCI_DEVICE_ID_INTEL_82855PM_HB 0x3340 >> #define PCI_DEVICE_ID_INTEL_82830_HB0x3575 > >I assume we'll need this in 2.6.21.x as well, otherwise those devices just >won't work when someone tries to run this kernel on them? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.19-rc6][RESEND] ata_piix: IDE mode SATA patch for Intel ICH9
Yes, I sent an updated patch that uses the ICH8 structures. Do you need me to send this again. Jason >-Original Message- >From: Jeff Garzik [mailto:[EMAIL PROTECTED] >Sent: Tuesday, November 28, 2006 12:41 AM >To: Gaston, Jason D >Cc: linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org; >[EMAIL PROTECTED] >Subject: Re: [PATCH 2.6.19-rc6][RESEND] ata_piix: IDE mode SATA patch for >Intel ICH9 > >did I see a resend of this floating around? > >I can't apply this one... > >Looks OK though - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.19-rc6] i2c-i801: SMBus patch for Intel ICH9
Jean,
I send the patches you requested. Please let me know if you see anything that
needs to change.
Thanks,
Jason
>-Original Message-
>From: Jean Delvare [mailto:[EMAIL PROTECTED]
>Sent: Thursday, November 23, 2006 4:10 AM
>To: Gaston, Jason D
>Cc: linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]
>Subject: Re: [PATCH 2.6.19-rc6] i2c-i801: SMBus patch for Intel ICH9
>
>Hi Jason,
>
>On Wed, 22 Nov 2006 15:19:12 -0800, Jason Gaston wrote:
>> This updated patch adds the Intel ICH9 LPC and SMBus Controller DID's.
>> This patch relies on the irq ICH9 patch to pci_ids.h.
>
>Looks good. Care to also update Documentation/i2c/busses/i2c-i801? I
>see it misses at least the ICH8 and ESB2 as well.
>
>I would also appreciate an update to lm_sensors' sensors-detect script,
>if you could send a patch to the sensors list.
>
>> Signed-off-by: Jason Gaston <[EMAIL PROTECTED]>
>>
>> --- linux-2.6.19-rc6/drivers/i2c/busses/i2c-i801.c.orig 2006-11-22
>06:17:20.0 -0800
>> +++ linux-2.6.19-rc6/drivers/i2c/busses/i2c-i801.c 2006-11-22
>06:27:12.0 -0800
>> @@ -33,6 +33,7 @@
>> ICH727DA
>> ESB2269B
>> ICH8283E
>> +ICH92930
>> This driver supports several versions of Intel's I/O Controller Hubs
>(ICH).
>> For SMBus support, they are similar to the PIIX4 and are part
>> of Intel's '810' and other chipsets.
>> @@ -457,6 +458,7 @@
>> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_17) },
>> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_17) },
>> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_5) },
>> +{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_6) },
>> { 0, }
>> };
>>
>> --- linux-2.6.19-rc6/drivers/i2c/busses/Kconfig.orig 2006-11-22
>07:05:25.0 -0800
>> +++ linux-2.6.19-rc6/drivers/i2c/busses/Kconfig 2006-11-22
>07:05:36.0 -0800
>> @@ -125,6 +125,7 @@
>> ICH7
>> ESB2
>> ICH8
>> +ICH9
>>
>>This driver can also be built as a module. If so, the module
>>will be called i2c-i801.
>
>Thanks,
>--
>Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6.12.3] drivers/pci: recognize more ICH7 PCI/SATA chips
This is not right. 0x27b8 is the ICH7 LPC controller DID, not a SATA Controller DID. The ICH7 IDE mode SATA controller DID's are 0x27c0 and 0x27c4 and they are already in the quirks.c file. Jason Gaston >Message: 124 >Date: Tue, 2 Aug 2005 14:34:41 -0400 >From: Nash <[EMAIL PROTECTED]> >Subject: Re: [PATCH 2.6.12.3] drivers/pci: recognize more ICH7 > PCI/SATA chips >To: linux-kernel@vger.kernel.org >Message-ID: <[EMAIL PROTECTED]> >Content-Type: text/plain; charset=us-ascii > > >On Tue, Aug 02, 2005 at 02:28:42PM -0400, Nash wrote: >> >> Updated pci/quirks.c to recognize additional ICH7 PCI/SATA controller >> chips such as those integrated on the ASUS P5WD2 Premium motherboard. >> >> Signed-off-by: Nash E Foster <[EMAIL PROTECTED]> > >Blergh, this is the correct ratch. How embarrassing. > >Index: linux-2.6.12.3/drivers/pci/quirks.c >=== >--- linux-2.6.12.3/drivers/pci/quirks.c 2005-07-15 17:18:57.0 >-0400 >+++ linux/drivers/pci/quirks.c 2005-07-26 22:32:09.0 -0400 >@@ -1199,6 +1199,7 @@ >case 0x2680:/* ESB2 */ >ich = 6; >break; >+ case 0x27b8: >case 0x27c0: >case 0x27c4: >ich = 7; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R
This define is not actually used anywhere that I know of. I just wanted to be consistent and correct, following what was previously done. I have been wondering if I should be adding devices to the pci_ids.h file that are not being currently used. It seems like most drivers are not using these defines and are just using the DID's directly. In the future, should I only be add devices that are actually using the defines somewhere? Thanks, Jason >-Original Message- >From: Jeff Garzik [mailto:[EMAIL PROTECTED] >Sent: Friday, July 29, 2005 2:49 PM >To: Gaston, Jason D >Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org >Subject: Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R > >Jason Gaston wrote: >> Hello, >> >> This patch adds the Intel ICH7R SATA RAID DID to the pci_ids.h file. >This patch was built against the 2.6.13-rc4 kernel. >> If acceptable, please apply. >> >> Thanks, >> >> Jason Gaston >> >> Signed-off-by: Jason Gaston <[EMAIL PROTECTED]> >> >> --- linux-2.6.13-rc4/include/linux/pci_ids.h.orig2005-07-29 >09:06:03.841520568 -0700 >> +++ linux-2.6.13-rc4/include/linux/pci_ids.h 2005-07-29 >09:06:42.256680576 -0700 >> @@ -2454,6 +2454,7 @@ >> #define PCI_DEVICE_ID_INTEL_ICH7_3 0x27c1 >> #define PCI_DEVICE_ID_INTEL_ICH7_30 0x27b0 >> #define PCI_DEVICE_ID_INTEL_ICH7_31 0x27bd >> +#define PCI_DEVICE_ID_INTEL_ICH7_4 0x27c3 >> #define PCI_DEVICE_ID_INTEL_ICH7_5 0x27c4 >> #define PCI_DEVICE_ID_INTEL_ICH7_6 0x27c5 >> #define PCI_DEVICE_ID_INTEL_ICH7_7 0x27c8 > >Where is this actually used? > >I purposefully do not use PCI_DEVICE_ID_xxx in my drivers, because I >feel that linux/pci_ids.h is constantly patched for little value. > >Device ids, unlike vendor ids, are largely single-use constants. > > Jeff > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1
I have never had an opportunity to test AC'97 modems on ICH6 or ICH7. Sorry, Jason >-Original Message- >From: Takashi Iwai [mailto:[EMAIL PROTECTED] >Sent: Tuesday, January 18, 2005 1:12 AM >To: Gaston, Jason D >Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org >Subject: Re: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1 > >At Mon, 17 Jan 2005 09:37:17 -0800, >Gaston, Jason D wrote: >> >> ICH6 and ICH7 both have AC'97 modem DID's. >> >> ICH6 AC'97 modem DID = 266d >> ICH7 AC'97 modem DID = 27dd >> >> Would you like me to create a patch adding both? > >Not necessary, the patch would be easy to me, too :) > >But, I'd like to confirm that the driver really works on these >chipsets before adding the IDs. > > >thanks, > >Takashi > >> Thanks, >> >> Jason >> >> >> >> >-Original Message- >> >From: Takashi Iwai [mailto:[EMAIL PROTECTED] >> >Sent: Monday, January 17, 2005 3:31 AM >> >To: Gaston, Jason D >> >Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org >> >Subject: Re: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1 >> > >> >At Fri, 14 Jan 2005 11:21:34 -0800, >> >Jason Gaston wrote: >> >> >> >> This patch adds the ICH7 AC'97 DID the the intel8x0.c AC'97 audio >driver. >> > This patch was build against 2.6.11-rc1. >> >> If acceptable, please apply. >> >> >> >> Thanks, >> >> >> >> Jason Gaston >> >> >> >> Signed-off-by: Jason Gaston <[EMAIL PROTECTED]> >> > >> >Thanks, I applied the patch to ALSA tree. >> > >> >Does ICH7 have an ac97 modem, too? >> >If so, we miss the DID in the modem driver, too. >> >(Well, the entry for ICH6 is also missing. Anyone can confirm such a >> > device?) >> > >> > >> >Takashi >> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1
ICH6 and ICH7 both have AC'97 modem DID's. ICH6 AC'97 modem DID = 266d ICH7 AC'97 modem DID = 27dd Would you like me to create a patch adding both? Thanks, Jason >-Original Message- >From: Takashi Iwai [mailto:[EMAIL PROTECTED] >Sent: Monday, January 17, 2005 3:31 AM >To: Gaston, Jason D >Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org >Subject: Re: [PATCH] AC'97 Audio support for Intel ICH7 - 2.6.11-rc1 > >At Fri, 14 Jan 2005 11:21:34 -0800, >Jason Gaston wrote: >> >> This patch adds the ICH7 AC'97 DID the the intel8x0.c AC'97 audio driver. > This patch was build against 2.6.11-rc1. >> If acceptable, please apply. >> >> Thanks, >> >> Jason Gaston >> >> Signed-off-by: Jason Gaston <[EMAIL PROTECTED]> > >Thanks, I applied the patch to ALSA tree. > >Does ICH7 have an ac97 modem, too? >If so, we miss the DID in the modem driver, too. >(Well, the entry for ICH6 is also missing. Anyone can confirm such a > device?) > > >Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
