[PATCH] e100: free IRQ to remove warning when rebooting
Hi, When rebooting today I got Will now restart. ACPI: PCI interrupt for device :00:03.0 disabled GSI 20 (level, low) -> CPU 1 (0x0100) vector 53 unregistered Destroying IRQ53 without calling free_irq WARNING: at /home/insecure/ianw/programs/git-kernel/linux-2.6/kernel/irq/chip.c:76 dynamic_irq_cleanup() Call Trace: [] show_stack+0x40/0xa0 sp=e0407c927b40 bsp=e0407c920eb8 [] dump_stack+0x30/0x60 sp=e0407c927d10 bsp=e0407c920ea0 [] dynamic_irq_cleanup+0x160/0x1e0 sp=e0407c927d10 bsp=e0407c920e70 [] destroy_and_reserve_irq+0x30/0xc0 sp=e0407c927d10 bsp=e0407c920e40 [] iosapic_unregister_intr+0x5b0/0x5e0 sp=e0407c927d10 bsp=e0407c920dd8 [] acpi_unregister_gsi+0x30/0x60 sp=e0407c927d10 bsp=e0407c920db8 [] acpi_pci_irq_disable+0x140/0x160 sp=e0407c927d10 bsp=e0407c920d88 [] pcibios_disable_device+0xa0/0xc0 sp=e0407c927d20 bsp=e0407c920d68 [] pci_disable_device+0x130/0x160 sp=e0407c927d20 bsp=e0407c920d38 [] e100_shutdown+0x1c0/0x220 sp=e0407c927d30 bsp=e0407c920d08 [] pci_device_shutdown+0x80/0xc0 sp=e0407c927d30 bsp=e0407c920ce8 [] device_shutdown+0xf0/0x180 sp=e0407c927d30 bsp=e0407c920cc8 [] kernel_restart+0x60/0x120 sp=e0407c927d30 bsp=e0407c920ca8 [] sys_reboot+0x3b0/0x480 sp=e0407c927d30 bsp=e0407c920c30 [] ia64_ret_from_syscall+0x0/0x20 sp=e0407c927e30 bsp=e0407c920c30 [] ia64_ivt+0x00010620/0x400 sp=e0407c928000 bsp=e0407c920c30 Restarting system. I think the solution might be to free the IRQ before the pci_device_shutdown Signed-off-by: Ian Wienand <[EMAIL PROTECTED]> --- e100.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e100.c b/drivers/net/e100.c index 3dbaec6..8ae5ac3 100644 --- a/drivers/net/e100.c +++ b/drivers/net/e100.c @@ -2782,6 +2782,7 @@ static void e100_shutdown(struct pci_dev *pdev) pci_enable_wake(pdev, PCI_D3cold, 0); } + free_irq(pdev->irq, netdev); pci_disable_device(pdev); pci_set_power_state(pdev, PCI_D3hot); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Kernel SCM saga..
On Wed, Apr 06, 2005 at 08:42:08AM -0700, Linus Torvalds wrote: > If you must, start reading up on "monotone". One slightly annoying thing is that monotone doesn't appear to have a web interface. I used to use the bk one a lot when tracking down bugs, because it was really fast to have a web browser window open and click through the revisions of a file reading checkin comments, etc. Does anyone know if one is being worked on? bazaar-ng at least mention this is important in their design docs and arch has one in development too. -i [EMAIL PROTECTED] http://www.gelato.unsw.edu.au signature.asc Description: Digital signature
Typo in BUILD_LOCK_OPS in spinlock.c causes preempt build failure
Hi, Our auto kernel build (http://www.gelato.unsw.edu.au/kerncomp/) was dying with preempt turned on with latest BK; BUILD_LOCK_OPS is using a spinlock function for a rwlock. Thanks, -i [EMAIL PROTECTED] http://www.gelato.unsw.edu.au = kernel/spinlock.c 1.4 vs edited = --- 1.4/kernel/spinlock.c 2005-01-15 11:00:00 +11:00 +++ edited/kernel/spinlock.c2005-01-17 10:43:44 +11:00 @@ -248,7 +248,7 @@ */ BUILD_LOCK_OPS(spin, spinlock_t, spin_is_locked); BUILD_LOCK_OPS(read, rwlock_t, rwlock_is_locked); -BUILD_LOCK_OPS(write, rwlock_t, spin_is_locked); +BUILD_LOCK_OPS(write, rwlock_t, rwlock_is_locked); #endif /* CONFIG_PREEMPT */ signature.asc Description: Digital signature
