[PATCH] queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message
Hi all, commit 0cf4f2de0a0f4100795f38ef894d4910678c74f8 introduced a bug, which prevents sending an USB_CDC_GET_ENCAPSULATED_RESPONSE message. This breaks the RNDIS initialization (especially / only Windoze machines dislike this behavior...). Signed-off-by: Benedikt Spranger <[EMAIL PROTECTED]> Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> --- drivers/usb/gadget/ether.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.24/drivers/usb/gadget/ether.c === --- linux-2.6.24.orig/drivers/usb/gadget/ether.c +++ linux-2.6.24/drivers/usb/gadget/ether.c @@ -1568,6 +1568,7 @@ done_set_intf: memcpy(req->buf, buf, n); req->complete = rndis_response_complete; rndis_free_response(dev->rndis_config, buf); + value = n; } /* else stalls ... spec says to avoid that */ } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: kbuild: possible regression?
Hi Sam, sorry for the delayed feedback. Still suffering a bad stomach flu... > Please test and report back. Thanks - Your Patch seems to fix things for me! Cheers, Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH][AT91] Fix compile error for at91rm9200 in latest git
Hi all,
> > Your patch looks correct, and seems to be the only obvious chunk
> > that's missing. So, I'll ack it FWIW ... usual policy for these
> > patches is to go through Russell.
>
> You can add my Ack for what it's worth.
OK, CC'ed Russell and added your Acked-by.
Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]>
Acked-by: Andrew Victor <[EMAIL PROTECTED]>
---
diff --git a/arch/arm/mach-at91/board-ek.c b/arch/arm/mach-at91/board-ek.c
index d05b1b2..53a5ef9 100644
--- a/arch/arm/mach-at91/board-ek.c
+++ b/arch/arm/mach-at91/board-ek.c
@@ -109,6 +109,15 @@ static struct spi_board_info ek_spi_devices[] = {
#endif
};
+static struct i2c_board_info __initdata ek_i2c_devices[] = {
+ {
+ I2C_BOARD_INFO("ics1523", 0x26),
+ },
+ {
+ I2C_BOARD_INFO("dac3550", 0x4d),
+ }
+};
+
#define EK_FLASH_BASE AT91_CHIPSELECT_0
#define EK_FLASH_SIZE 0x20
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH][AT91] Fix compile error for at91rm9200 in latest git
Hi,
at91rm9200ek doesn't compile in latest git:
/here/workdir/linux-2.6/at91rm9200ek/src/arch/arm/mach-at91/board-ek.c: In
function `ek_board_init':
/here/workdir/linux-2.6/at91rm9200ek/src/arch/arm/mach-at91/board-ek.c:148:
error: `ek_i2c_devices' undeclared (first use in this function)
/here/workdir/linux-2.6/at91rm9200ek/src/arch/arm/mach-at91/board-ek.c:148:
error: (Each undeclared identifier is reported only once
/here/workdir/linux-2.6/at91rm9200ek/src/arch/arm/mach-at91/board-ek.c:148:
error: for each function it appears in.)
/here/workdir/linux-2.6/at91rm9200ek/src/arch/arm/mach-at91/board-ek.c:148:
warning: type defaults to `int' in declaration of `type name'
/here/workdir/linux-2.6/at91rm9200ek/src/arch/arm/mach-at91/board-ek.c:148:
warning: type defaults to `int' in declaration of `type name'
/here/workdir/linux-2.6/at91rm9200ek/src/arch/arm/mach-at91/board-ek.c:148:
error: size of array `type name' is negative
The offending commit is:
[EMAIL PROTECTED] linux-2.6]$ git-bisect good
f230d3f53d72d05bcb5666ab7e2eccd49c8b3a15 is first bad commit
commit f230d3f53d72d05bcb5666ab7e2eccd49c8b3a15
Author: Andrew Victor <[EMAIL PROTECTED]>
Date: Mon Nov 19 13:47:20 2007 +0100
[ARM] 4650/1: AT91: New-style init of I2C, support for i2c-gpio
The AT91 I2C driver is currently marked as "broken" due to hardware
issues. This patch enables AT91-based platforms to also use the
bitbanged GPIO for I2C.
This updates platform setup logic (setting up an i2c-gpio device
using the same pins as the i2c-at91 device, unless only the BROKEN
driver is enabled).
Also make use of the new-style initialization of I2C devices using
i2c_register_board_info().
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
Signed-off-by: Andrew Victor <[EMAIL PROTECTED]>
Signed-off-by: Russell King <[EMAIL PROTECTED]>
This patch adds the missing i2c_board_info struct (grabbed from Andrew
Victor's tree).
Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]>
---
diff --git a/arch/arm/mach-at91/board-ek.c b/arch/arm/mach-at91/board-ek.c
index d05b1b2..53a5ef9 100644
--- a/arch/arm/mach-at91/board-ek.c
+++ b/arch/arm/mach-at91/board-ek.c
@@ -109,6 +109,15 @@ static struct spi_board_info ek_spi_devices[] = {
#endif
};
+static struct i2c_board_info __initdata ek_i2c_devices[] = {
+ {
+ I2C_BOARD_INFO("ics1523", 0x26),
+ },
+ {
+ I2C_BOARD_INFO("dac3550", 0x4d),
+ }
+};
+
#define EK_FLASH_BASE AT91_CHIPSELECT_0
#define EK_FLASH_SIZE 0x20
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: kbuild: possible regression?
Hi Sam, > > commit 0b35786d77ba4037f181982cc8ca20a7a3bf0fd2 > > Author: Milton Miller <[EMAIL PROTECTED]> > > Date: Fri Sep 21 18:09:02 2007 -0500 > > > > kbuild: call make once for all targets when O=.. is used > > > > Change the invocations of make in the output directory Makefile and the > > main Makefile for separate object trees to pass all goals to one $(MAKE) > > via a new phony target "sub-make" and the existing target _all. > > > > When compiling with separate object directories, a separate make is > > called > > in the context of another directory (from the output directory the main > > Makefile is called, the Makefile is then restarted with current > > directory > > set to the object tree). Before this patch, when multiple make command > > goals are specified, each target results in a separate make invocation. > > With make -j, these invocations may run in parallel, resulting in > > multiple > > commands running in the same directory clobbering each others results. > > > > I did not try to address make -j for mixed dot-config and no-dot-config > > targets. Because the order does matter, a solution was not obvious. > > Perhaps a simple check for MAKEFLAGS having -j and refusing to run would > > be appropriate. > > > > Signed-off-by: Milton Miller <[EMAIL PROTECTED]> > > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> > > > > So, am I facing a kbuild regression? > > Yes - I will try to fix it during the weekend (if Milton does not beat me). > Thanks for reporting and bisecting! Have you made any progress on this? Let me know, if I can assist with testing. Cheers, Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
kbuild: possible regression?
Hi all,
I'm not quite sure if this might be a regression, but I recognized a
change to kbuild's behaviour, which causes some of my build scripts to
fail.
The build scripts do:
return system(('make -C %s O=%s ARCH=%s CROSS_COMPILE=%s '+
'oldconfig %s %s < /dev/null || exit %i') %
(srcdir,
builddir,
arch,
crosscompile,
target,
modules_target,
FAILED_RETCODE))
which results in something like:
make -C /here/workdir/linux-2.6/common/src
O=/here/workdir/linux-2.6/common/build/build \
ARCH=i386 CROSS_COMPILE=/opt/i686-linux/bin/i686-linux- \
oldconfig bzImage < /dev/null || exit 1
In the past, oldconfig was the first target, which has been handled.
Now, bzImage seems to get handled at first. That causes my build scripts
to fail, because the bzImage target does a silentoldconfig, which
doesn't allow console redirection.
[...]
Kernel log buffer size (16 => 64KB, 17 => 128KB) (LOG_BUF_SHIFT) [14] 14
Control Group support (CGROUPS) [N/y/?] (NEW) aborted!
Console input/output is redirected. Run 'make oldconfig' to update
configuration.
make[5]: *** [silentoldconfig] Error 1
make[4]: *** [silentoldconfig] Error 2
make[3]: *** [include/config/auto.conf] Error 2
make[2]: *** [sub-make] Error 2
make[1]: *** [/here/workdir/linux-2.6/common/src/scripts/Kbuild.include] Error 2
make: *** [sub-make] Error 2
make: Leaving directory `/here/workdir/linux-2.6/common/src'
[...]
After silentoldconfig has failed, oldconfig seems to get executed and
after that the bzImage build is starting. So far so good, BUT: My script
checks the return value and fails after the execution of
silentoldconfig. That's why I recognized the different behaviour.
I did a git bisect to identify the commit, which caused the change to
kbuild's behaviour. The offending commit is:
commit 0b35786d77ba4037f181982cc8ca20a7a3bf0fd2
Author: Milton Miller <[EMAIL PROTECTED]>
Date: Fri Sep 21 18:09:02 2007 -0500
kbuild: call make once for all targets when O=.. is used
Change the invocations of make in the output directory Makefile and the
main Makefile for separate object trees to pass all goals to one $(MAKE)
via a new phony target "sub-make" and the existing target _all.
When compiling with separate object directories, a separate make is called
in the context of another directory (from the output directory the main
Makefile is called, the Makefile is then restarted with current directory
set to the object tree). Before this patch, when multiple make command
goals are specified, each target results in a separate make invocation.
With make -j, these invocations may run in parallel, resulting in multiple
commands running in the same directory clobbering each others results.
I did not try to address make -j for mixed dot-config and no-dot-config
targets. Because the order does matter, a solution was not obvious.
Perhaps a simple check for MAKEFLAGS having -j and refusing to run would
be appropriate.
Signed-off-by: Milton Miller <[EMAIL PROTECTED]>
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
So, am I facing a kbuild regression?
Cheers,
Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] AT91: Remove at91_lcdc.h
include/asm-arm/arch-at91/at91_lcdc.h (which is still present in latest git) has been superseeded by include/video/atmel_lcdc.h, so let's remove it. Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> --- include/asm-arm/arch-at91/at91_lcdc.h | 148 -- 1 file changed, 148 deletions(-) Index: linux-2.6/include/asm-arm/arch-at91/at91_lcdc.h === --- linux-2.6.orig/include/asm-arm/arch-at91/at91_lcdc.h +++ /dev/null @@ -1,148 +0,0 @@ -/* - * include/asm-arm/arch-at91/at91_lcdc.h - * - * LCD Controller (LCDC). - * Based on AT91SAM9261 datasheet revision E. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - */ - -#ifndef AT91_LCDC_H -#define AT91_LCDC_H - -#define AT91_LCDC_DMABADDR10x00/* DMA Base Address Register 1 */ -#define AT91_LCDC_DMABADDR20x04/* DMA Base Address Register 2 */ -#define AT91_LCDC_DMAFRMPT10x08/* DMA Frame Pointer Register 1 */ -#define AT91_LCDC_DMAFRMPT20x0c/* DMA Frame Pointer Register 2 */ -#define AT91_LCDC_DMAFRMADD1 0x10/* DMA Frame Address Register 1 */ -#define AT91_LCDC_DMAFRMADD2 0x14/* DMA Frame Address Register 2 */ - -#define AT91_LCDC_DMAFRMCFG0x18/* DMA Frame Configuration Register */ -#defineAT91_LCDC_FRSIZE(0x7f << 0)/* Frame Size */ -#defineAT91_LCDC_BLENGTH (0x7f << 24)/* Burst Length */ - -#define AT91_LCDC_DMACON 0x1c/* DMA Control Register */ -#defineAT91_LCDC_DMAEN (0x1 << 0) /* DMA Enable */ -#defineAT91_LCDC_DMARST(0x1 << 1) /* DMA Reset */ -#defineAT91_LCDC_DMABUSY (0x1 << 2) /* DMA Busy */ - -#define AT91_LCDC_LCDCON1 0x0800 /* LCD Control Register 1 */ -#defineAT91_LCDC_BYPASS(1 << 0) /* Bypass lcd_dotck divider */ -#defineAT91_LCDC_CLKVAL(0x1ff << 12) /* Clock Divider */ -#defineAT91_LCDC_LINCNT(0x7ff << 21) /* Line Counter */ - -#define AT91_LCDC_LCDCON2 0x0804 /* LCD Control Register 2 */ -#defineAT91_LCDC_DISTYPE (3 << 0)/* Display Type */ -#defineAT91_LCDC_DISTYPE_STNMONO (0 << 0) -#defineAT91_LCDC_DISTYPE_STNCOLOR (1 << 0) -#defineAT91_LCDC_DISTYPE_TFT (2 << 0) -#defineAT91_LCDC_SCANMOD (1 << 2)/* Scan Mode */ -#defineAT91_LCDC_SCANMOD_SINGLE(0 << 2) -#defineAT91_LCDC_SCANMOD_DUAL (1 << 2) -#defineAT91_LCDC_IFWIDTH (3 << 3)/*Interface Width */ -#defineAT91_LCDC_IFWIDTH_4 (0 << 3) -#defineAT91_LCDC_IFWIDTH_8 (1 << 3) -#defineAT91_LCDC_IFWIDTH_16(2 << 3) -#defineAT91_LCDC_PIXELSIZE (7 << 5)/* Bits per pixel */ -#defineAT91_LCDC_PIXELSIZE_1 (0 << 5) -#defineAT91_LCDC_PIXELSIZE_2 (1 << 5) -#defineAT91_LCDC_PIXELSIZE_4 (2 << 5) -#defineAT91_LCDC_PIXELSIZE_8 (3 << 5) -#defineAT91_LCDC_PIXELSIZE_16 (4 << 5) -#defineAT91_LCDC_PIXELSIZE_24 (5 << 5) -#defineAT91_LCDC_INVVD (1 << 8)/* LCD Data polarity */ -#defineAT91_LCDC_INVVD_NORMAL (0 << 8) -#defineAT91_LCDC_INVVD_INVERTED(1 << 8) -#defineAT91_LCDC_INVFRAME (1 << 9 ) /* LCD VSync polarity */ -#defineAT91_LCDC_INVFRAME_NORMAL (0 << 9) -#defineAT91_LCDC_INVFRAME_INVERTED (1 << 9) -#defineAT91_LCDC_INVLINE (1 << 10) /* LCD HSync polarity */ -#defineAT91_LCDC_INVLINE_NORMAL(0 << 10) -#defineAT91_LCDC_INVLINE_INVERTED (1 << 10) -#defineAT91_LCDC_INVCLK(1 << 11) /* LCD dotclk polarity */ -#defineAT91_LCDC_INVCLK_NORMAL (0 << 11) -#define
[PATCH] remove get_perm_addr from ucc_geth_ethtool.c
Remove get_perm_addr from ucc_geth_ethtool.c This is needed because commit 313674afa8fdced2fe79f50f38e1c387b63d8790 inlines the generic function to the caller. Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> --- drivers/net/ucc_geth_ethtool.c |1 - 1 file changed, 1 deletion(-) Index: linux-2.6/drivers/net/ucc_geth_ethtool.c === --- linux-2.6.orig/drivers/net/ucc_geth_ethtool.c +++ linux-2.6/drivers/net/ucc_geth_ethtool.c @@ -379,7 +379,6 @@ static const struct ethtool_ops uec_etht .get_stats_count= uec_get_stats_count, .get_strings= uec_get_strings, .get_ethtool_stats = uec_get_ethtool_stats, - .get_perm_addr = ethtool_op_get_perm_addr, }; void uec_set_ethtool_ops(struct net_device *netdev) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] AT91: include atmel_lcdc.h in at91sam926{1,3}_devices.c
Hi all,
current git doesn't compile for CONFIG_ARCH_AT91SAM926{1,3} and
and CONFIG_FB_ATMEL enabled, due to a missing inclusion of atmel_lcdc.h:
/home/jan/kernel/git/linux-2.6/arch/arm/mach-at91/at91sam9263_devices.c: In
function ‘at91_add_device_lcdc’:
/home/jan/kernel/git/linux-2.6/arch/arm/mach-at91/at91sam9263_devices.c:688:
error: dereferencing pointer to incomplete type
/home/jan/kernel/git/linux-2.6/arch/arm/mach-at91/at91sam9263_devices.c:688:
error: ‘lcdc_data’ has an incomplete type
This error should also have occured in the past, because atmel_lcdc.h
has never been included.
Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]>
---
arch/arm/mach-at91/at91sam9261_devices.c |2 ++
arch/arm/mach-at91/at91sam9263_devices.c |2 ++
2 files changed, 4 insertions(+)
Index: linux-2.6/arch/arm/mach-at91/at91sam9261_devices.c
===
--- linux-2.6.orig/arch/arm/mach-at91/at91sam9261_devices.c
+++ linux-2.6/arch/arm/mach-at91/at91sam9261_devices.c
@@ -15,6 +15,8 @@
#include
+#include
+
#include
#include
#include
Index: linux-2.6/arch/arm/mach-at91/at91sam9263_devices.c
===
--- linux-2.6.orig/arch/arm/mach-at91/at91sam9263_devices.c
+++ linux-2.6/arch/arm/mach-at91/at91sam9263_devices.c
@@ -14,6 +14,8 @@
#include
+#include
+
#include
#include
#include
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Fix compile error for MMC_AT91
Hi Andrew, latest git doesn't compile for me with CONFIG_MMC_AT91 enabled: /home/jan/work/linutronix/linux-2.6/drivers/mmc/host/at91_mci.c: In function `at91_mci_enable': /home/jan/work/linutronix/linux-2.6/drivers/mmc/host/at91_mci.c:375: error: `AT91_MCI_RDPROOF' undeclared (first use in this function) /home/jan/work/linutronix/linux-2.6/drivers/mmc/host/at91_mci.c:375: error: (Each undeclared identifier is reported only once /home/jan/work/linutronix/linux-2.6/drivers/mmc/host/at91_mci.c:375: error: for each function it appears in.) /home/jan/work/linutronix/linux-2.6/drivers/mmc/host/at91_mci.c:375: error: `AT91_MCI_WRPROOF' undeclared (first use in this function) make[4]: *** [drivers/mmc/host/at91_mci.o] Error 1 This patch introduces the necessary defines (which are already present in your tree). Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> --- include/asm-arm/arch-at91/at91_mci.h |3 +++ 1 file changed, 3 insertions(+) Index: linux-2.6/include/asm-arm/arch-at91/at91_mci.h === --- linux-2.6.orig/include/asm-arm/arch-at91/at91_mci.h +++ linux-2.6/include/asm-arm/arch-at91/at91_mci.h @@ -26,6 +26,9 @@ #define AT91_MCI_MR0x04/* Mode Register */ #defineAT91_MCI_CLKDIV (0xff << 0) /* Clock Divider */ #defineAT91_MCI_PWSDIV (7 << 8) /* Power Saving Divider */ +#defineAT91_MCI_RDPROOF(1 << 11) /* Read Proof Enable [SAM926[03] only] */ +#defineAT91_MCI_WRPROOF(1 << 12) /* Write Proof Enable [SAM926[03] only] */ +#defineAT91_MCI_PDCFBYTE (1 << 13) /* PDC Force Byte Transfer [SAM926[03] only] */ #defineAT91_MCI_PDCPADV(1 << 14) /* PDC Padding Value */ #defineAT91_MCI_PDCMODE(1 << 15) /* PDC-orientated Mode */ #defineAT91_MCI_BLKLEN (0xfff << 18) /* Data Block Length */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] atmel_lcdfb: Fix STN LCD support
On Fri, 2007-06-15 at 10:50 +0200, Nicolas Ferre wrote: > From: Nicolas Ferre <[EMAIL PROTECTED]> > > Fixes STN LCD support for the atmel_lcdfb framebuffer driver. > > Signed-off-by: Nicolas Ferre <[EMAIL PROTECTED]> Acked-by: Jan Altenberg <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Add select PHYLIB to the UCC_GETH Kconfig option
ucc_geth has been migrated to use the common phylib code. So lets add a 'select PHYLIB' to the UCC_GETH Kconfig entry. Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> --- drivers/net/Kconfig |1 + 1 file changed, 1 insertion(+) Index: linux-2.6/drivers/net/Kconfig === --- linux-2.6.orig/drivers/net/Kconfig +++ linux-2.6/drivers/net/Kconfig @@ -2280,6 +2280,7 @@ config GFAR_NAPI config UCC_GETH tristate "Freescale QE Gigabit Ethernet" depends on QUICC_ENGINE + select PHYLIB select UCC_FAST help This driver supports the Gigabit Ethernet mode of the QUICC Engine, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Linux-fbdev-devel] [PATCH] atmel_lcdfb: AT91/AT32 LCD Controller framebuffer driver
Hi Nicolas, > + info->fix.line_length = info->var.xres_virtual * > (info->var.bits_per_pixel / 8); line_length will always be 0 for bits_per_pixel < 8. Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: preempt_rt bug or warn on arm v4t
Hi Manfred,
> I am using 2.6.21-rc7 with Preempt_rt Patch 2.6.20-rc6-rt0 on ep93xx.
Do you mean 2.6.21-rc6-rt0?
> This oops does not trigger in preempt_rt patch is applied.
It does only appear, when the preempt_rt patch is applied. Did I get you
right?
> On startup i get following oops when preemption is none.
>
> Mount-cache hash table entries: 512
> CPU: Testing write buffer coherency: ok
> BUG: at kernel/sched.c:4285 __schedule()
> [] (dump_stack+0x0/0x14) from [] (__schedule+0x844/0x8e0)
> [] (__schedule+0x0/0x8e0) from [] (schedule+0xd0/0x118)
> [] (schedule+0x0/0x118) from []
> (wait_for_completion+0x94/0xf0)
> r4 = C042DE88
> [] (wait_for_completion+0x0/0xf0) from []
> (keventd_create_kthread+0x3c/0x74)
> r7 = r6 = 0002 r5 = C042DED4 r4 = C042DF18
> [] (keventd_create_kthread+0x0/0x74) from []
> (kthread_create+0x80/0xc8)
> r6 = C001C320 r5 = C042DED4 r4 =
> [] (kthread_create+0x0/0xc8) from []
> (posix_cpu_thread_call+0x40/0xb8)
> r3 = r2 = C0352BD0
> r5 = r4 =
> [] (posix_cpu_thread_call+0x0/0xb8) from []
> (posix_cpu_thread_init+0x24/0x40)
> r5 = r4 = C03A7F74
> [] (posix_cpu_thread_init+0x0/0x40) from []
> (init+0x38/0x30c)
> r4 =
> [] (init+0x0/0x30c) from [] (do_exit+0x0/0x80c)
This WARN_ON in __schedule seems to be triggered:
if (!irqs_disabled()) {
static int once = 1;
if (once) {
once = 0;
print_irqtrace_events(current);
WARN_ON(1);
}
}
I've seen this on an Atmel AT91SAM9261EK board a few days ago, when I
was implementing GENERIC_TIME and GENERIC_CLOCKEVENTS. I've tested with
2.6.20-rt8 and 2.6.21-rc6-rt0.
(an early version of the patch can be found here:
http://www.tglx.de/private/jan/at91sam/at91sam9260-generic-time-2.6.21-rc6-rt0.diff)
Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Fix compile error in latest git
Hi, I recognized a compile error in latest git: /here/workdir/git/drivers/net/gianfar.c: In function `gfar_vlan_rx_kill_vid': /here/workdir/git/drivers/net/gianfar.c:1135: error: structure has no member named `vgrp' This error was introduced in commit: commit 6d04e3b04b6ab569cabeb5ca28ad1be11777e895 Merge: 4227003... 5c15bde... Author: Linus Torvalds <[EMAIL PROTECTED]> Date: Sun Mar 4 13:16:49 2007 -0800 Merge master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 * master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6: [VLAN]: Avoid a 4-order allocation. [HDLC] Fix dev->header_cache_update having a random value. [NetLabel]: Verify sensitivity level has a valid CIPSO mapping [PPPOE]: Key connections properly on local device. [AF_UNIX]: Test against sk_max_ack_backlog properly. [NET]: Fix bugs in "Whether sock accept queue is full" checking Patch is attached. Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> --- drivers/net/gianfar.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/drivers/net/gianfar.c === --- linux-2.6.orig/drivers/net/gianfar.c +++ linux-2.6/drivers/net/gianfar.c @@ -1132,7 +1132,7 @@ static void gfar_vlan_rx_kill_vid(struct spin_lock_irqsave(&priv->rxlock, flags); - vlan_group_set_device(priv->vgrp, vid, NULL); + vlan_group_set_device(priv->vlgrp, vid, NULL); spin_unlock_irqrestore(&priv->rxlock, flags); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6.21-rc2] AT91SAM9261: Enable second and third UART
On Thu, 2007-03-01 at 18:26 +, Ben Dooks wrote: > On Thu, Mar 01, 2007 at 04:24:53PM +0100, Jan Altenberg wrote: > > - Enable ttyS1 and ttyS2 for the AT91SAM9261EK > > > > Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> > > These should go to Russell King's patch queue at > http://www.arm.linux.org.uk/developer/patches Submitted to Russell's patch queue. Cheers, JAN - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6.21-rc2] AT91SAM9261: Enable second and third UART
- Enable ttyS1 and ttyS2 for the AT91SAM9261EK
Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]>
---
arch/arm/mach-at91/board-sam9261ek.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/arch/arm/mach-at91/board-sam9261ek.c
===
--- linux-2.6.orig/arch/arm/mach-at91/board-sam9261ek.c
+++ linux-2.6/arch/arm/mach-at91/board-sam9261ek.c
@@ -50,8 +50,8 @@
*/
static struct at91_uart_config __initdata ek_uart_config = {
.console_tty= 0,/* ttyS0 */
- .nr_tty = 1,
- .tty_map= { 3, -1, -1, -1 } /* ttyS0, ..., ttyS3 */
+ .nr_tty = 3,
+ .tty_map= { 3, 0, 1, -1 } /* ttyS0, ..., ttyS3 */
};
static void __init ek_map_io(void)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6.20-rc7] at91: correct value for AT91_RSTC_KEY
- Remove a duplicated define for AT91_RSTC_KEY
- Set AT91_RSTC_KEY to the correct value
- Replace the hardcoded keys in at91sam9620.c and at91sam9261.c
by AT91_RSTC_KEY
Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]>
---
arch/arm/mach-at91rm9200/at91sam9260.c |2 +-
arch/arm/mach-at91rm9200/at91sam9261.c |2 +-
include/asm-arm/arch-at91rm9200/at91_rstc.h |3 +--
3 files changed, 3 insertions(+), 4 deletions(-)
Index: linux-2.6/arch/arm/mach-at91rm9200/at91sam9260.c
===
--- linux-2.6.orig/arch/arm/mach-at91rm9200/at91sam9260.c
+++ linux-2.6/arch/arm/mach-at91rm9200/at91sam9260.c
@@ -213,7 +213,7 @@ static struct at91_gpio_bank at91sam9260
static void at91sam9260_reset(void)
{
- at91_sys_write(AT91_RSTC_CR, (0xA5 << 24) | AT91_RSTC_PROCRST |
AT91_RSTC_PERRST);
+ at91_sys_write(AT91_RSTC_CR, AT91_RSTC_KEY | AT91_RSTC_PROCRST |
AT91_RSTC_PERRST);
}
Index: linux-2.6/arch/arm/mach-at91rm9200/at91sam9261.c
===
--- linux-2.6.orig/arch/arm/mach-at91rm9200/at91sam9261.c
+++ linux-2.6/arch/arm/mach-at91rm9200/at91sam9261.c
@@ -208,7 +208,7 @@ static struct at91_gpio_bank at91sam9261
static void at91sam9261_reset(void)
{
- at91_sys_write(AT91_RSTC_CR, (0xA5 << 24) | AT91_RSTC_PROCRST |
AT91_RSTC_PERRST);
+ at91_sys_write(AT91_RSTC_CR, AT91_RSTC_KEY | AT91_RSTC_PROCRST |
AT91_RSTC_PERRST);
}
Index: linux-2.6/include/asm-arm/arch-at91rm9200/at91_rstc.h
===
--- linux-2.6.orig/include/asm-arm/arch-at91rm9200/at91_rstc.h
+++ linux-2.6/include/asm-arm/arch-at91rm9200/at91_rstc.h
@@ -17,7 +17,7 @@
#defineAT91_RSTC_PROCRST (1 << 0)/*
Processor Reset */
#defineAT91_RSTC_PERRST(1 << 2)/*
Peripheral Reset */
#defineAT91_RSTC_EXTRST(1 << 3)/*
External Reset */
-#defineAT91_RSTC_KEY (0xff << 24)/* KEY
Password */
+#defineAT91_RSTC_KEY (0xa5 << 24)/* KEY
Password */
#define AT91_RSTC_SR (AT91_RSTC + 0x04) /* Reset Controller
Status Register */
#defineAT91_RSTC_URSTS (1 << 0)/* User
Reset Status */
@@ -34,6 +34,5 @@
#defineAT91_RSTC_URSTEN(1 << 0)/* User
Reset Enable */
#defineAT91_RSTC_URSTIEN (1 << 4)/* User
Reset Interrupt Enable */
#defineAT91_RSTC_ERSTL (0xf << 8) /*
External Reset Length */
-#defineAT91_RSTC_KEY (0xff << 24)/* KEY
Password */
#endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6.20-rc6] MIPS: Fix some whitespace damage
Fix some whitespace damage in arch/mips/Kconfig.debug Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> --- arch/mips/Kconfig.debug |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6/arch/mips/Kconfig.debug === --- linux-2.6.orig/arch/mips/Kconfig.debug +++ linux-2.6/arch/mips/Kconfig.debug @@ -22,10 +22,10 @@ config CMDLINE string "Default kernel command string" default "" help - On some platforms, there is currently no way for the boot loader to - pass arguments to the kernel. For these platforms, you can supply - some command-line options at build time by entering them here. In - other cases you can specify kernel args so that you don't have + On some platforms, there is currently no way for the boot loader to + pass arguments to the kernel. For these platforms, you can supply + some command-line options at build time by entering them here. In + other cases you can specify kernel args so that you don't have to set them up in board prom initialization routines. config DEBUG_STACK_USAGE - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6.20-rc6][MIPS]Malta: trivial compile error fix
Hi Ralf, the following patch should fix a compile error for MIPS_MALTA, when CONFIG_MTD is disabled. regards, JAN --- - Fix a compile error for MIPS_MALTA, when CONFIG_MTD is disabled. Signed-off-by: Jan Altenberg <[EMAIL PROTECTED]> --- arch/mips/mips-boards/malta/Makefile |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-2.6/arch/mips/mips-boards/malta/Makefile === --- linux-2.6.orig/arch/mips/mips-boards/malta/Makefile +++ linux-2.6/arch/mips/mips-boards/malta/Makefile @@ -19,5 +19,6 @@ # under Linux. # -obj-y := malta_int.o malta_mtd.o malta_setup.o +obj-y := malta_int.o malta_setup.o +obj-$(CONFIG_MTD) += malta_mtd.o obj-$(CONFIG_SMP) += malta_smp.o - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
