Re: [PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

On Fri, 26 Feb 2016, Darren Hart wrote:

On Mon, Feb 22, 2016 at 10:29:48PM -0600, John Dahlstrom wrote:

[...]

Thank you for that information. One commit is sufficient to apply the patch
to all kernel versions without fuzz:

4fa9dab ideapad_laptop: Lenovo G50-30 fix rfkill reports wireless blocked


This does not yield correct results for me on 3.17 (or 3.17.8). Do you get
different results from the following?


[...]

Note that the DMI match blocks were stuffed in the middle of the
ideapad_acpi_add() function instead of the no_hw_rfkill.


The v3, v4, and v5 patch submissions had been corrupted by spurious
whitespace inserted by my email client. I have sent a corrected version,
[PATCH v6 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI 
list

After submission, I verified the successful application of the patch
as received by the mailing list.

I also ran git clone, "git checkout -b 3.17 v3.17", and
"git cherry-pick 4fa9dab", followed by patch with success.

Kind regards,

John

Re: [PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

On Fri, 26 Feb 2016, Darren Hart wrote:

On Mon, Feb 22, 2016 at 10:29:48PM -0600, John Dahlstrom wrote:

[...]

Thank you for that information. One commit is sufficient to apply the patch
to all kernel versions without fuzz:

4fa9dab ideapad_laptop: Lenovo G50-30 fix rfkill reports wireless blocked


This does not yield correct results for me on 3.17 (or 3.17.8). Do you get
different results from the following?


[...]

Note that the DMI match blocks were stuffed in the middle of the
ideapad_acpi_add() function instead of the no_hw_rfkill.


The v3, v4, and v5 patch submissions had been corrupted by spurious
whitespace inserted by my email client. I have sent a corrected version,
[PATCH v6 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI 
list

After submission, I verified the successful application of the patch
as received by the mailing list.

I also ran git clone, "git checkout -b 3.17 v3.17", and
"git cherry-pick 4fa9dab", followed by patch with success.

Kind regards,

John

[PATCH v6 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Signed-off-by: John Dahlstrom <joda...@sdf.org>
Cc: <sta...@vger.kernel.org> # 3.17.x-: 4fa9dab: ideapad_laptop: Lenovo G50-30 
fix rfkill reports wireless blocked
---
  Test configuration
   Hardware: Lenovo ideapad Y700 Touch-15ISK
   Kernel version: 4.4.2

  Patch changelog
   v2 split patch between Touch and non-Touch devices
   v3 undo patch split and limit summary to 72 characters
   v4 include comprehensive list of patchable kernels in Cc
   v5 include commit ID of the prerequisite patch in Cc
   v6 3.17.x- in Cc; fix whitespace corruption from email client

  drivers/platform/x86/ideapad-laptop.c |   14 ++
  1 file changed, 14 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

[PATCH v6 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Signed-off-by: John Dahlstrom 
Cc:  # 3.17.x-: 4fa9dab: ideapad_laptop: Lenovo G50-30 
fix rfkill reports wireless blocked
---
  Test configuration
   Hardware: Lenovo ideapad Y700 Touch-15ISK
   Kernel version: 4.4.2

  Patch changelog
   v2 split patch between Touch and non-Touch devices
   v3 undo patch split and limit summary to 72 characters
   v4 include comprehensive list of patchable kernels in Cc
   v5 include commit ID of the prerequisite patch in Cc
   v6 3.17.x- in Cc; fix whitespace corruption from email client

  drivers/platform/x86/ideapad-laptop.c |   14 ++
  1 file changed, 14 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

Re: [PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

On Mon, 22 Feb 2016, Darren Hart wrote:


Unfortunately, backporting this to stable is not quite so simple.

First, 3.16 doesn't really work as between 3.16 and 3.17 the following patch
landed:

ce363c2 ideapad-laptop: Change Lenovo Yoga 2 series rfkill handling

Which changes the name of the dmi_system_id struct from rfkill_blacklist to
no_hw_rfkill_list.

Following that, there were several additions to the list which should be applied
before this patch to each stable kernel for which they haven't been picked up in
order for this one to apply cleanly. Several of those are included below:



Despite the change in the no_hw_rfkill_list, GNU patch still yields the
correct output but with fuzz. I interpret apply cleanly to mean that
the patch must also apply with zero fuzz, such as with "patch -F 0".

In the case where the context has changed (including changes to an
enclosing struct or function), I gather that a patch exactly modified
for an older kernel is to be sent to sta...@vger.kernel.org after the 
unmodified patch is accepted upstream with a commit ID.



$ git l v3.17.. drivers/platform/x86/ideapad-laptop.c

[...]


If you are going to specify a kernel version, you should also include the
commits above necessary to make the patch apply cleanly. That would be a long
list as you would need many of these for each version.



Thank you for that information. One commit is sufficient to apply the 
patch to all kernel versions without fuzz:


4fa9dab ideapad_laptop: Lenovo G50-30 fix rfkill reports wireless blocked


What I'm going to do is include a single Cc to stable line without a kernel
version. The maintainers will pull that back as far as they can using their own
judgement. If you want this to go back earlier than they do on their own, you
should submit it to linux-stable directly and include the Cc lines for the
dependencies for each kernel you care to see this backported to. See the
stable-kernel-rules for the specific formatting to accomplish this.



I've submitted v5 of the patch with a single Cc line with the prerequisite
kernel(s) and commit ID specified exactly.

Kind regards,

John

Re: [PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

On Mon, 22 Feb 2016, Darren Hart wrote:


Unfortunately, backporting this to stable is not quite so simple.

First, 3.16 doesn't really work as between 3.16 and 3.17 the following patch
landed:

ce363c2 ideapad-laptop: Change Lenovo Yoga 2 series rfkill handling

Which changes the name of the dmi_system_id struct from rfkill_blacklist to
no_hw_rfkill_list.

Following that, there were several additions to the list which should be applied
before this patch to each stable kernel for which they haven't been picked up in
order for this one to apply cleanly. Several of those are included below:



Despite the change in the no_hw_rfkill_list, GNU patch still yields the
correct output but with fuzz. I interpret apply cleanly to mean that
the patch must also apply with zero fuzz, such as with "patch -F 0".

In the case where the context has changed (including changes to an
enclosing struct or function), I gather that a patch exactly modified
for an older kernel is to be sent to sta...@vger.kernel.org after the 
unmodified patch is accepted upstream with a commit ID.



$ git l v3.17.. drivers/platform/x86/ideapad-laptop.c

[...]


If you are going to specify a kernel version, you should also include the
commits above necessary to make the patch apply cleanly. That would be a long
list as you would need many of these for each version.



Thank you for that information. One commit is sufficient to apply the 
patch to all kernel versions without fuzz:


4fa9dab ideapad_laptop: Lenovo G50-30 fix rfkill reports wireless blocked


What I'm going to do is include a single Cc to stable line without a kernel
version. The maintainers will pull that back as far as they can using their own
judgement. If you want this to go back earlier than they do on their own, you
should submit it to linux-stable directly and include the Cc lines for the
dependencies for each kernel you care to see this backported to. See the
stable-kernel-rules for the specific formatting to accomplish this.



I've submitted v5 of the patch with a single Cc line with the prerequisite
kernel(s) and commit ID specified exactly.

Kind regards,

John

[PATCH v5 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Signed-off-by: John Dahlstrom <joda...@sdf.org>
Cc: <sta...@vger.kernel.org> # 3.18.x-: 4fa9dab: ideapad_laptop: Lenovo G50-30 
fix rfkill reports wireless blocked
---
  Test configuration
   Hardware: Lenovo ideapad Y700 Touch-15ISK
   Kernel version: 4.4.2

  Patch changelog
   v2 split patch between Touch and non-Touch devices
   v3 undo patch split and limit summary to 72 characters
   v4 include comprehensive list of patchable kernels in Cc
   v5 include commit ID of the prerequisite patch in Cc

  drivers/platform/x86/ideapad-laptop.c |   14 ++
  1 file changed, 14 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

[PATCH v5 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Signed-off-by: John Dahlstrom 
Cc:  # 3.18.x-: 4fa9dab: ideapad_laptop: Lenovo G50-30 
fix rfkill reports wireless blocked
---
  Test configuration
   Hardware: Lenovo ideapad Y700 Touch-15ISK
   Kernel version: 4.4.2

  Patch changelog
   v2 split patch between Touch and non-Touch devices
   v3 undo patch split and limit summary to 72 characters
   v4 include comprehensive list of patchable kernels in Cc
   v5 include commit ID of the prerequisite patch in Cc

  drivers/platform/x86/ideapad-laptop.c |   14 ++
  1 file changed, 14 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

Re: [PATCH v3 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

On Fri, 19 Feb 2016, Darren Hart wrote:


See stable_kernel_rules.txt for how to specify relevant versions. I'm curious
why there is a gap from 3.18 to 4.1.

What you probably meant was:

Cc:  # 3.18.x

If you are going to take this approach, you may wish to verify that this applies
back to 3.18, otherwise you may need to specify dependencies (also described in
the stable_kernel_rules).



Darren,

Thank you for your assistance.

The version gap in the earlier v3 comment reflected my earlier gap in 
verification. Today I stepped through the additional kernel versions to 
confirm the patch applies successfully to those versions, and have 
submitted the patch as v4.


Kernel version 3.18.27 already handles the 17" model of the ideapad Y700, 
so it would seem odd not to also handle the 15" model.


Kind regards,

John

Re: [PATCH v3 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

On Fri, 19 Feb 2016, Darren Hart wrote:


See stable_kernel_rules.txt for how to specify relevant versions. I'm curious
why there is a gap from 3.18 to 4.1.

What you probably meant was:

Cc:  # 3.18.x

If you are going to take this approach, you may wish to verify that this applies
back to 3.18, otherwise you may need to specify dependencies (also described in
the stable_kernel_rules).



Darren,

Thank you for your assistance.

The version gap in the earlier v3 comment reflected my earlier gap in 
verification. Today I stepped through the additional kernel versions to 
confirm the patch applies successfully to those versions, and have 
submitted the patch as v4.


Kernel version 3.18.27 already handles the 17" model of the ideapad Y700, 
so it would seem odd not to also handle the 15" model.


Kind regards,

John

[PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Signed-off-by: John Dahlstrom <joda...@sdf.org>
Cc: <sta...@vger.kernel.org> # 4.5.x
Cc: <sta...@vger.kernel.org> # 4.4.x
Cc: <sta...@vger.kernel.org> # 4.3.x
Cc: <sta...@vger.kernel.org> # 4.2.x
Cc: <sta...@vger.kernel.org> # 4.1.x
Cc: <sta...@vger.kernel.org> # 4.0.x
Cc: <sta...@vger.kernel.org> # 3.19.x
Cc: <sta...@vger.kernel.org> # 3.18.x
Cc: <sta...@vger.kernel.org> # 3.17.x
Cc: <sta...@vger.kernel.org> # 3.16.x
---
  Test configuration
   Hardware: Lenovo ideapad Y700 Touch-15ISK
   Kernel version: 4.4.2

  Patch changelog
   v2 split patch between Touch and non-Touch devices
   v3 undo patch split and limit summary to 72 characters
   v4 include comprehensive list of patchable kernels in Cc

  drivers/platform/x86/ideapad-laptop.c |   14 ++
  1 file changed, 14 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

[PATCH v4 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Signed-off-by: John Dahlstrom 
Cc:  # 4.5.x
Cc:  # 4.4.x
Cc:  # 4.3.x
Cc:  # 4.2.x
Cc:  # 4.1.x
Cc:  # 4.0.x
Cc:  # 3.19.x
Cc:  # 3.18.x
Cc:  # 3.17.x
Cc:  # 3.16.x
---
  Test configuration
   Hardware: Lenovo ideapad Y700 Touch-15ISK
   Kernel version: 4.4.2

  Patch changelog
   v2 split patch between Touch and non-Touch devices
   v3 undo patch split and limit summary to 72 characters
   v4 include comprehensive list of patchable kernels in Cc

  drivers/platform/x86/ideapad-laptop.c |   14 ++
  1 file changed, 14 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

Re: [PATCH][RESEND] ideapad-laptop: Add Lenovo ideapad Y700 Touch-15ISK and Lenovo ideapad Y700-15ISK to the no_hw_rfkill DMI list

[John Dahlstrom]

Darren,

Thank you for your guidance. I have abbreviated the commit summary to 
"ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list"

and submitted the patch as v3.

The initial patch submission had been corrupted by word wrap in my
email client.

Kind regards,

John

Re: [PATCH][RESEND] ideapad-laptop: Add Lenovo ideapad Y700 Touch-15ISK and Lenovo ideapad Y700-15ISK to the no_hw_rfkill DMI list

[John Dahlstrom]

Darren,

Thank you for your guidance. I have abbreviated the commit summary to 
"ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list"

and submitted the patch as v3.

The initial patch submission had been corrupted by word wrap in my
email client.

Kind regards,

John

[PATCH v3 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Signed-off-by: John Dahlstrom <joda...@sdf.org>
Cc: <sta...@vger.kernel.org>
---
 Relevant kernel versions: 4.5-rc4, 4.4.2, 4.3.5, 4.1.18, 3.18.27

 Test configuration
  Hardware: Lenovo ideapad Y700 Touch-15ISK
  Kernel version: 4.4.2

 Patch changelog
  v2 split patch between Touch and non-Touch devices
  v3 undo patch split and limit summary to 72 characters

 drivers/platform/x86/ideapad-laptop.c |   14 ++
 1 file changed, 14 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

[PATCH v3 1/1] ideapad-laptop: Add ideapad Y700 (15) to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Signed-off-by: John Dahlstrom 
Cc: 
---
 Relevant kernel versions: 4.5-rc4, 4.4.2, 4.3.5, 4.1.18, 3.18.27

 Test configuration
  Hardware: Lenovo ideapad Y700 Touch-15ISK
  Kernel version: 4.4.2

 Patch changelog
  v2 split patch between Touch and non-Touch devices
  v3 undo patch split and limit summary to 72 characters

 drivers/platform/x86/ideapad-laptop.c |   14 ++
 1 file changed, 14 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

[PATCH v2 2/2] ideapad-laptop: Add ideapad Y700 Touch-15ISK to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On a Lenovo ideapad Y700 Touch-15ISK, the ideapad-laptop module
would wrongly report all radios as blocked by hardware which
caused wireless network connections to fail.

Add this model without an rfkill switch to the no_hw_rfkill list.

Tested-by: John Dahlstrom <joda...@sdf.org>
Signed-off-by: John Dahlstrom <joda...@sdf.org>
---
 Relevant kernel versions: 4.5-rc4, 4.4.2, 4.3.5, 4.1.18, 3.18.27
 Patch changelog
  v2 split patch between Touch and non-Touch devices

 drivers/platform/x86/ideapad-laptop.c |7 +++
 1 file changed, 7 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -871,4 +871,11 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

[PATCH v2 2/2] ideapad-laptop: Add ideapad Y700 Touch-15ISK to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On a Lenovo ideapad Y700 Touch-15ISK, the ideapad-laptop module
would wrongly report all radios as blocked by hardware which
caused wireless network connections to fail.

Add this model without an rfkill switch to the no_hw_rfkill list.

Tested-by: John Dahlstrom 
Signed-off-by: John Dahlstrom 
---
 Relevant kernel versions: 4.5-rc4, 4.4.2, 4.3.5, 4.1.18, 3.18.27
 Patch changelog
  v2 split patch between Touch and non-Touch devices

 drivers/platform/x86/ideapad-laptop.c |7 +++
 1 file changed, 7 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -871,4 +871,11 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

[PATCH v2 1/2] ideapad-laptop: Add ideapad Y700-15ISK to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On a Lenovo ideapad Y700-15ISK, the ideapad-laptop module
would wrongly report all radios as blocked by hardware which
caused wireless network connections to fail.

Add this model without an rfkill switch to the no_hw_rfkill list.

Tested-by: John Dahlstrom <joda...@sdf.org>
Signed-off-by: John Dahlstrom <joda...@sdf.org>
---
 Relevant kernel versions: 4.5-rc4, 4.4.2, 4.3.5, 4.1.18, 3.18.27
 Patch changelog
  v2 split patch between Touch and non-Touch devices

 drivers/platform/x86/ideapad-laptop.c |7 +++
 1 file changed, 7 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.0 
-0600
@@ -864,4 +864,11 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
},
{

[PATCH v2 1/2] ideapad-laptop: Add ideapad Y700-15ISK to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On a Lenovo ideapad Y700-15ISK, the ideapad-laptop module
would wrongly report all radios as blocked by hardware which
caused wireless network connections to fail.

Add this model without an rfkill switch to the no_hw_rfkill list.

Tested-by: John Dahlstrom 
Signed-off-by: John Dahlstrom 
---
 Relevant kernel versions: 4.5-rc4, 4.4.2, 4.3.5, 4.1.18, 3.18.27
 Patch changelog
  v2 split patch between Touch and non-Touch devices

 drivers/platform/x86/ideapad-laptop.c |7 +++
 1 file changed, 7 insertions(+)

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.0 
-0600
@@ -864,4 +864,11 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
},
{

[PATCH][RESEND] ideapad-laptop: Add Lenovo ideapad Y700 Touch-15ISK and Lenovo ideapad Y700-15ISK to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Relevant kernel versions: 4.5-rc4, 4.4.1, 4.3.5, 4.1.18, 3.18.27

Tested-by: John Dahlstrom <joda...@sdf.org>
Signed-off-by: John Dahlstrom <joda...@sdf.org>
---

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

[PATCH][RESEND] ideapad-laptop: Add Lenovo ideapad Y700 Touch-15ISK and Lenovo ideapad Y700-15ISK to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Relevant kernel versions: 4.5-rc4, 4.4.1, 4.3.5, 4.1.18, 3.18.27

Tested-by: John Dahlstrom 
Signed-off-by: John Dahlstrom 
---

--- a/drivers/platform/x86/ideapad-laptop.c 2016-02-14 15:05:20.0 
-0600
+++ b/drivers/platform/x86/ideapad-laptop.c 2016-02-16 03:54:48.484423725 
-0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),
+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+   DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad Y700 
Touch-15ISK"),
+   },
},
{

[PATCH] ideapad-laptop: Add Lenovo ideapad Y700 Touch-15ISK and Lenovo ideapad Y700-15ISK to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Relevant kernel versions: 4.5-rc4, 4.4.1, 4.3.5, 4.1.18, 3.18.27

Tested-by: John Dahlstrom <joda...@sdf.org>
Signed-off-by: John Dahlstrom <joda...@sdf.org>

--- a/drivers/platform/x86/ideapad-laptop.c	2016-02-14 
15:05:20.0 -0600
+++ b/drivers/platform/x86/ideapad-laptop.c	2016-02-16 
03:54:48.484423725 -0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] 
= {

DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),

+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700 Touch-15ISK"),

+   },
},
{

[PATCH] ideapad-laptop: Add Lenovo ideapad Y700 Touch-15ISK and Lenovo ideapad Y700-15ISK to the no_hw_rfkill DMI list

[John Dahlstrom]

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models ideapad Y700 Touch-15ISK and ideapad Y700-15ISK,
ideapad-laptop would wrongly report all radios as blocked by
hardware which caused wireless network connections to fail.

Add these models without an rfkill switch to the no_hw_rfkill list.

Relevant kernel versions: 4.5-rc4, 4.4.1, 4.3.5, 4.1.18, 3.18.27

Tested-by: John Dahlstrom 
Signed-off-by: John Dahlstrom 

--- a/drivers/platform/x86/ideapad-laptop.c	2016-02-14 
15:05:20.0 -0600
+++ b/drivers/platform/x86/ideapad-laptop.c	2016-02-16 
03:54:48.484423725 -0600
@@ -864,4 +864,18 @@ static const struct dmi_system_id no_hw_rfkill_list[] 
= {

DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
},
+   },
+   {
+   .ident = "Lenovo ideapad Y700-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700-15ISK"),

+   },
+   },
+   {
+   .ident = "Lenovo ideapad Y700 Touch-15ISK",
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad 
Y700 Touch-15ISK"),

+   },
},
{

NETWORK: udp_port_rover reluctant to rove (unlike tcp_port_rover)

[John Dahlstrom]

Regarding udp_port_rover (of linux/net/ipv4/udp.c):
In Linux 2.4 or 2.6, I noticed that selected local port numbers for UDP
resist roaming, unlike TCP ports numbers (tcp_port_rover) that appear
to steadily increase irrespective of concurrent local port usage.
What is the advantage of this lack of parallel behavior?  (Other than
exacerbating broken behavior of certain firewalls that insist on fixed
UDP source port blocking?)
Aesthetically peculiar it seems, that the kernel reins in port roving
for the connectionless protocol unless a UDP stampede unleashes itself,
while allowing the TCP ports to range free across the local ports
regardless.
Kind regards,
- John
--
http://jodarom.sdf1.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

NETWORK: udp_port_rover reluctant to rove (unlike tcp_port_rover)

[John Dahlstrom]

Regarding udp_port_rover (of linux/net/ipv4/udp.c):
In Linux 2.4 or 2.6, I noticed that selected local port numbers for UDP
resist roaming, unlike TCP ports numbers (tcp_port_rover) that appear
to steadily increase irrespective of concurrent local port usage.
What is the advantage of this lack of parallel behavior?  (Other than
exacerbating broken behavior of certain firewalls that insist on fixed
UDP source port blocking?)
Aesthetically peculiar it seems, that the kernel reins in port roving
for the connectionless protocol unless a UDP stampede unleashes itself,
while allowing the TCP ports to range free across the local ports
regardless.
Kind regards,
- John
--
http://jodarom.sdf1.org/
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/