Re: [PATCH] Fix USB vendor and product IDs endianness for USB HID devices
Jiri Kosina <[EMAIL PROTECTED]> wrote: Hi, > this is obviously a bug, thanks for a fix, I queued it for upstream. Thanks. > Two nitpicks: > > - could you please submitpatches in standard conventions, so that they > could be applied directly using patch -p1 against toplevel of the kernel > tree (your patch was just against hid-core.c, but without any path) Gah, I did that again. Sorry. > - please inline patches in message and do not attach them, if possible Same here, got fooled again into doing an inline MIME part instead of inlining the patch for real. JB. -- Julien BLACHE <http://www.jblache.org> <[EMAIL PROTECTED]> GPG KeyID 0xF5D65169 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Fix USB vendor and product IDs endianness for USB HID devices
Hi, The generic HID layer changes introduced an endianness bug for USB HID devices. The USB vendor and product IDs are not byteswapped appropriately, and thus come out in the wrong endianness when fetched through the evdev using ioctl() on big endian platforms. This byteswapping used to be done in hidinput_connect() (by usb_to_input_id()) when filling up the hid device structure, and now needs to be done upstream. USB is the only user so far, and the hid_device structure is set up in usb_hid_configure(). Signed-off-by: Julien BLACHE <[EMAIL PROTECTED]> --- hid-core.c~ 2007-02-05 11:16:33.905278861 +0100 +++ hid-core.c 2007-02-10 21:53:52.366333019 +0100 @@ -1220,8 +1220,8 @@ le16_to_cpu(dev->descriptor.idProduct)); hid->bus = BUS_USB; - hid->vendor = dev->descriptor.idVendor; - hid->product = dev->descriptor.idProduct; + hid->vendor = le16_to_cpu(dev->descriptor.idVendor); + hid->product = le16_to_cpu(dev->descriptor.idProduct); usb_make_path(dev, hid->phys, sizeof(hid->phys)); strlcat(hid->phys, "/input", sizeof(hid->phys)); Please apply, and this is a candidate for -stable as it breaks a documented API/ABI in userspace. JB. -- Julien BLACHE <http://www.jblache.org> <[EMAIL PROTECTED]> GPG KeyID 0xF5D65169
Re: sky2 hangs
Thomas Glanzmann <[EMAIL PROTECTED]> wrote: Hi, >> I can reproduce the problem now (on mac mini). Interestingly it seems >> to whack the whole ethernet switch when it happens. I've observed that too, on a cheap DLink switch. Next time sky2 hangs on me I'll try to reset the PHY and see if that helps. I can usually trigger the hang by doing a couple of ifconfig up/down on the interface, though I'm not getting any error message from the driver when that happens. JB. -- Julien BLACHE <http://www.jblache.org> <[EMAIL PROTECTED]> GPG KeyID 0xF5D65169 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
