Re: PROBLEM: REGRESSION in drivers/platform/x86/dell-laptop.c
On 19/11/12 02:30, Arend van Spriel wrote: On 11/18/2012 11:47 AM, Mark Ellis wrote: 1. rfkill code removal causes hang 2. the rfkill code was removed from this driver in commit 53039f222c548bfc119eea6df4dca2b57550e271 this results in my computer hanging (dell n5050) if booting with the wireless (hardware) disabled. downgrading this module to the version prior to this commit fixes the issue. The commit you mention does not touch dell-laptop.c. The commit before that one doe, but it is only adding code. Digging the tree I found this one between kernel v3.4 and v3.5-rc1: commit a6c2390cd6d2083d27a2359658e08f2d3df375ac Author: Matthew Garrett Date: Fri Jun 1 12:46:56 2012 -0400 dell-laptop: Remove rfkill code The interface just doesn't work on some machines, and Dell haven't been able to tell us either which machines those are or what we should be doing instead. This would be fine, except it results in userspace ending up confused and general sadness. So let's just rip it out for now. Signed-off-by: Matthew Garrett You're right, I have no idea where I got that commit number from! Sorry about that. Actually, the behavior you describe and given you have a BCM4313 running with brcmsmac I may point out that this driver has an issue coming up with wireless disabled. This has been fixed in 3.7 kernel so you may want to try: commit 82d8eba358badb466a4e988ecabf0668a8d92e9c Author: Piotr Haber Date: Wed Sep 19 22:21:15 2012 +0200 brcmsmac: don't start device when RfKill is engaged This patch fixes a bug when device is being started while RfKill switch is engaged, leading to hang due to partial initialization of hardware. Tested-by: Reviewed-by: Arend van Spriel Reviewed-by: Hante Meuleman Signed-off-by: Piotr Haber Signed-off-by: Arend van Spriel Signed-off-by: John W. Linville Maybe I should resubmit it to stable. Now there is an idea. Yep that fixed it, thanks very much! Mark -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
PROBLEM: REGRESSION in drivers/platform/x86/dell-laptop.c
1. rfkill code removal causes hang 2. the rfkill code was removed from this driver in commit 53039f222c548bfc119eea6df4dca2b57550e271 this results in my computer hanging (dell n5050) if booting with the wireless (hardware) disabled. downgrading this module to the version prior to this commit fixes the issue. 3. modules, laptop, dell-laptop, rfkill 4. Linux version 3.6-trunk-rt-amd64 (debian-ker...@lists.debian.org) (gcc version 4.6.3 (Debian 4.6.3-1) ) #1 SMP PREEMPT RT Debian 3.6.6-1~experimental.1 5. n/a 6. n/a 7. dell laptop (n5050) with wireless disabled 7.1. Linux laptop 3.6-trunk-rt-amd64 #1 SMP PREEMPT RT Debian 3.6.6-1~experimental.1 x86_64 GNU/Linux Gnu C 4.7 Gnu make 3.81 binutils 2.22 util-linux scripts/ver_linux: 23: scripts/ver_linux: fdformat: not found mount support module-init-tools found Linux C Library2.13 Dynamic linker (ldd) 2.13 Procps 3.3.4 Kbd1.15.3 Sh-utils 8.20 Modules Loaded cpufreq_userspace cpufreq_conservative cpufreq_powersave cpufreq_stats xt_tcpudp xt_conntrack iptable_filter iptable_mangle ipt_MASQUERADE iptable_nat nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_conntrack iptable_raw ip_tables x_tables pci_stub vboxpci vboxnetadp vboxnetflt vboxdrv snd_hda_codec_hdmi snd_hda_codec_idt iTCO_wdt iTCO_vendor_support joydev arc4 dell_laptop dcdbas brcmsmac cordic brcmutil mac80211 cfg80211 rfkill dell_wmi sparse_keymap coretemp kvm_intel kvm crc32c_intel ghash_clmulni_intel aesni_intel aes_x86_64 aes_generic ablk_helper cryptd evdev microcode snd_hda_intel snd_hda_codec snd_hwdep snd_pcm_oss snd_mixer_oss snd_pcm psmouse snd_page_alloc serio_raw snd_seq_midi snd_seq_midi_event lpc_ich i2c_i801 mfd_core snd_rawmidi snd_seq snd_seq_device i915 snd_timer acpi_cpufreq drm_kms_helper bcma video wmi mperf snd battery drm ac i2c_algo_bit soundcore i2c_core button processor loop fuse autofs4 ext4 crc16 jbd2 mbcache sg sr_mod sd_mod crc_t10dif cdrom thermal ahci thermal_sys libahci ehci_hcd libata usbcore scsi_mod usb_common 7.2. processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 42 model name : Intel(R) Core(TM) i5-2430M CPU @ 2.40GHz stepping: 7 microcode : 0x1b cpu MHz : 800.000 cache size : 3072 KB physical id : 0 siblings: 4 core id : 0 cpu cores : 2 apicid : 0 initial apicid : 0 fpu : yes fpu_exception : yes cpuid level : 13 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic popcnt tsc_deadline_timer aes xsave avx lahf_lm ida arat epb xsaveopt pln pts dtherm tpr_shadow vnmi flexpriority ept vpid bogomips: 4789.50 clflush size: 64 cache_alignment : 64 address sizes : 36 bits physical, 48 bits virtual power management: processor : 1 vendor_id : GenuineIntel cpu family : 6 model : 42 model name : Intel(R) Core(TM) i5-2430M CPU @ 2.40GHz stepping: 7 microcode : 0x1b cpu MHz : 800.000 cache size : 3072 KB physical id : 0 siblings: 4 core id : 1 cpu cores : 2 apicid : 2 initial apicid : 2 fpu : yes fpu_exception : yes cpuid level : 13 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic popcnt tsc_deadline_timer aes xsave avx lahf_lm ida arat epb xsaveopt pln pts dtherm tpr_shadow vnmi flexpriority ept vpid bogomips: 4789.50 clflush size: 64 cache_alignment : 64 address sizes : 36 bits physical, 48 bits virtual power management: processor : 2 vendor_id : GenuineIntel cpu family : 6 model : 42 model name : Intel(R) Core(TM) i5-2430M CPU @ 2.40GHz stepping: 7 microcode : 0x1b cpu MHz : 800.000 cache size : 3072 KB physical id : 0 siblings: 4 core id : 0 cpu cores : 2 apicid : 1 initial apicid : 1 fpu : yes fpu_exception : yes cpuid level : 13 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2
Re: OOPS on bringing down ppp
Nope that didn't help. I'm using gcc 2.95.2, didn't think of it before
since it has never caused me any problems. I'll get around to trying
2.91.66 at some point.
A quick aside, anyone know of a problem with the list, I seem to be being
cut off at random intervals :)
Mark
On Fri, 24 Nov 2000 12:28:44 Andrew Morton wrote:
> Mark Ellis wrote:
> >
> > Hi all, consistently getting the following when pppd is terminated.
>
> When pppd downs the ppp0 device, unregister_netdevice() is
> trying to run /sbin/hotplug in a new kernel thread. That
> thread's `files' structure is copied from pppd, but it is
> NULL. Presumably pppd's files pointer was also NULL.
>
> Try this:
>
> --- linux-2.4.0-test11-ac2/kernel/kmod.c Tue Nov 21 20:11:21 2000
> +++ linux-akpm/kernel/kmod.c Fri Nov 24 23:03:34 2000
> @@ -99,8 +99,10 @@
> flush_signal_handlers(current);
> spin_unlock_irq(¤t->sigmask_lock);
>
> - for (i = 0; i < current->files->max_fds; i++ ) {
> - if (current->files->fd[i]) close(i);
> + if (current->files) {
> + for (i = 0; i < current->files->max_fds; i++ ) {
> + if (current->files->fd[i]) close(i);
> + }
> }
>
> /* Drop the "current user" thing */
>
>
> Not my area, but I don't think exec_usermodehelper() should assume
> that current->files is always valid.
>
> Al, is this correct? If so, does daemonize() also need this test?
> If not, then how did this thread get (current->files == NULL)?
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
OOPS on bringing down ppp
Hi all, consistently getting the following when pppd is terminated. Happens in 2.4.0-test11, fine in 2.4.0-test9, don't know about test10. Same happens for pppd 2.4.0b4 and 2.4.0, both recompiled for test11. Is this related to the modutils incompatability (modutils 2.3.19) ? CONFIG_PPP and CONFIG_PPP_ASYNC are built in, CONFIG_PPP_DEFLATE and CONFIG_PPP_BSDCOMP as modules, but oopses whether they are loaded or not. ksymoops 2.3.4 on i686 2.4.0-test11. Options used -V (default) -k /proc/ksyms (default) -l /proc/modules (default) -o /lib/modules/2.4.0-test11/ (default) -m /usr/src/linux/System.map (specified) Warning (compare_maps): snd symbol pm_register not found in /lib/modules/2.4.0-test11/sound/snd.o. Ignoring /lib/modules/2.4.0-test11/sound/snd.o entry Warning (compare_maps): snd symbol pm_send not found in /lib/modules/2.4.0-test11/sound/snd.o. Ignoring /lib/modules/2.4.0-test11/sound/snd.o entry Warning (compare_maps): snd symbol pm_unregister not found in /lib/modules/2.4.0-test11/sound/snd.o. Ignoring /lib/modules/2.4.0-test11/sound/snd.o entry c0114c6c *pde = Oops: CPU:0 EIP:0010:[] Using defaults from ksymoops -t elf32-i386 -a i386 EFLAGS: 00010246 eax: c4bb1544 ebx: c4e72000 ecx: c5fe83a0 edx: esi: 0006 edi: ebp: c5fe83a0 esp: c4e73fb8 ds: 0018 es: 0018 ss: 0018 Process pppd (pid: 1099, stackpage=c4e73000) Stack: 0100 c4e6delc c4e6de4c c5b27e20 c5fe83a0 c11c35c0 c11c35c0 c11c35c0 c11c35c0 c0114f60 c0225f60 c4e6dedc c4e6dec8 c0108914 c4e6de4c 0078 c4e6dedc Call Trace: [] [] Code: 8b 4f 08 39 ca 7d 22 8b 47 14 83 3c 90 00 74 14 89 f0 89 d3 >>EIP; c0114c6c<= Trace; c0114f60 Trace; c0108914 Code; c0114c6c <_EIP>: Code; c0114c6c<= 0: 8b 4f 08 mov0x8(%edi),%ecx <= Code; c0114c6f 3: 39 ca cmp%ecx,%edx Code; c0114c71 5: 7d 22 jge29 <_EIP+0x29> c0114c95 Code; c0114c73 7: 8b 47 14 mov0x14(%edi),%eax Code; c0114c76 a: 83 3c 90 00 cmpl $0x0,(%eax,%edx,4) Code; c0114c7a e: 74 14 je 24 <_EIP+0x24> c0114c90 Code; c0114c7c 10: 89 f0 mov%esi,%eax Code; c0114c7e 12: 89 d3 mov%edx,%ebx 3 warnings issued. Results may not be reliable. Any ideas ? Mark - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
