Re: [PATCH v2 0/2] scsi: ufs: Fix power drain and hci quirk for WriteBooster
On Tue, 22 Dec 2020 15:29:03 +0800, Stanley Chu wrote: > This series fixes two WriteBooster issues, > 1. Fix a corner case that device flush capability is not disabled during > system suspend > 2. Fix the checking of UFSHCI quirk UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL > > Stanley Chu (2): > scsi: ufs: Fix possible power drain during system suspend > scsi: ufs: Relax the condition of > UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL > > [...] Applied to 5.11/scsi-fixes, thanks! [1/2] scsi: ufs: Fix possible power drain during system suspend https://git.kernel.org/mkp/scsi/c/1d53864c3617 [2/2] scsi: ufs: Relax the condition of UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL https://git.kernel.org/mkp/scsi/c/21acf4601cc6 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] ibmvfc: fix missing cast of ibmvfc_event pointer to u64 handle
On Wed, 6 Jan 2021 14:37:21 -0600, Tyrel Datwyler wrote:
> Commit 2aa0102c6688 ("scsi: ibmvfc: Use correlation token to tag
> commands") sets the vfcFrame correlation token to the pointer handle of
> the associated ibmvfc_event. However, that commit failed to cast the
> pointer to an appropriate type which in this case is a u64. As such
> sparse warnings are generated for both correlation token assignments.
>
> ibmvfc.c:2375:36: sparse: incorrect type in argument 1 (different base types)
> ibmvfc.c:2375:36: sparse: expected unsigned long long [usertype] val
> ibmvfc.c:2375:36: sparse: got struct ibmvfc_event *[assigned] evt
>
> [...]
Applied to 5.11/scsi-fixes, thanks!
[1/1] ibmvfc: fix missing cast of ibmvfc_event pointer to u64 handle
https://git.kernel.org/mkp/scsi/c/901d01c8e50c
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v5 0/2] Two UFS fixes
On Thu, 7 Jan 2021 10:53:14 -0800, Jaegeuk Kim wrote: > Change log from v4: > - remove RESERVE tag for tm command > - remove waiting IOs and let full reset handle it > - avoid verbose error log which causes cpu lock up Applied to 5.11/scsi-fixes, thanks! [1/2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns https://git.kernel.org/mkp/scsi/c/4ee7ee530bc2 [2/2] scsi: ufs: fix tm request correctly when non-fatal error happens https://git.kernel.org/mkp/scsi/c/eeb1b55b6e25 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: ufs: ufshcd-pltfrm depends on HAS_IOMEM
On Tue, 5 Jan 2021 20:08:22 -0800, Randy Dunlap wrote: > Building ufshcd-pltfrm.c on arch/s390/ has a linker error since > S390 does not support IOMEM, so add a dependency on HAS_IOMEM. > > s390-linux-ld: drivers/scsi/ufs/ufshcd-pltfrm.o: in function > `ufshcd_pltfrm_init': > ufshcd-pltfrm.c:(.text+0x38e): undefined reference to > `devm_platform_ioremap_resource' > > where that devm_ function is inside an #ifdef CONFIG_HAS_IOMEM/#endif block. Applied to 5.11/scsi-fixes, thanks! [1/1] scsi: ufs: ufshcd-pltfrm depends on HAS_IOMEM https://git.kernel.org/mkp/scsi/c/5e6ddadf7637 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: megaraid_sas: Fix MEGASAS_IOC_FIRMWARE regression
On Tue, 5 Jan 2021 00:41:04 +0100, Arnd Bergmann wrote: > Phil Oester reported that a fix for a possible buffer overrun that I > sent caused a regression that manifests in this output: > > Event Message: A PCI parity error was detected on a component at bus 0 > device 5 function 0. > Severity: Critical > Message ID: PCI1308 > > [...] Applied to 5.11/scsi-fixes, thanks! [1/1] scsi: megaraid_sas: Fix MEGASAS_IOC_FIRMWARE regression https://git.kernel.org/mkp/scsi/c/b112036535ed -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: ufs: Correct the lun used in eh_device_reset_handler() callback
On Mon, 28 Dec 2020 04:04:36 -0800, Can Guo wrote: > Users can initiate resets to specific SCSI device/target/host through > IOCTL. When this happens, the SCSI cmd passed to eh_device/target/host > _reset_handler() callbacks is initialized with a request whose tag is -1. > So, in this case, it is not right for eh_device_reset_handler() callback > to count on the lun get from hba->lrb[-1]. Fix it by getting lun from the > SCSI device associated with the SCSI cmd. Applied to 5.11/scsi-fixes, thanks! [1/1] scsi: ufs: Correct the lun used in eh_device_reset_handler() callback https://git.kernel.org/mkp/scsi/c/35fc4cd34426 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2] scsi: sd: remove obsolete variable in sd_remove()
On Mon, 14 Dec 2020 10:54:24 +0100, Lukas Bulwahn wrote:
> Commit 140ea3bbf39a ("sd: use __register_blkdev to avoid a modprobe for an
> unregistered dev_t") removed blk_register_region(devt, ...) in sd_remove()
> and since then, devt is unused in sd_remove().
>
> Hence, make W=1 warns:
>
> drivers/scsi/sd.c:3516:8:
> warning: variable 'devt' set but not used [-Wunused-but-set-variable]
>
> [...]
Applied to 5.11/scsi-fixes, thanks!
[1/1] scsi: sd: remove obsolete variable in sd_remove()
https://git.kernel.org/mkp/scsi/c/be2553358cd4
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] [v2] scsi: scsi_debug: Fix memleak in scsi_debug_init
On Sat, 26 Dec 2020 14:15:03 +0800, Dinghao Liu wrote: > When sdeb_zbc_model does not match BLK_ZONED_NONE, > BLK_ZONED_HA or BLK_ZONED_HM, we should free sdebug_q_arr > to prevent memleak. Also there is no need to execute > sdebug_erase_store() on failure of sdeb_zbc_model_str(). Applied to 5.11/scsi-fixes, thanks! [1/1] scsi: scsi_debug: Fix memleak in scsi_debug_init https://git.kernel.org/mkp/scsi/c/3b01d7ea4dae -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 0/3] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback() -- Take 2
Andrea,
> This series is to address the problems mentioned in:
>
> 4da3a54f5a0258 ("Revert "scsi: storvsc: Validate length of incoming packet
> in storvsc_on_channel_callback()"")
>
> (cf., in particular, patch 2/3) and to re-introduce the validation in
> question (patch 3/3); patch 1/3 emerged from internal review of these
> two patches and is a related fix.
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH V4] scsi: ufs-debugfs: Add error counters
Adrian, > People testing have a need to know how many errors might be occurring > over time. Add error counters and expose them via debugfs. > > A module initcall is used to create a debugfs root directory for > ufshcd-related items. In the case that modules are built-in, then > initialization is done in link order, so move ufshcd-core to the top > of the Makefile. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v3] scsi: ufs: Replace sprintf and snprintf with sysfs_emit
Bean, > sprintf and snprintf may cause output defect in sysfs content, it is > better to use new added sysfs_emit function which knows the size of > the temporary buffer. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH -next] scsi: ufs: fix all Kconfig help text indentation
Randy, > Use consistent and expected indentation for all Kconfig text. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2 0/5] ibmvfc: MQ preparatory locking work
Tyrel, > The ibmvfc driver in its current form relies heavily on the > host_lock. This patchset introduces a genric queue with its own queue > lock and sent/free event list locks. This generic queue allows the > driver to decouple the primary queue and future subordinate queues > from the host lock reducing lock contention while also relaxing > locking for submissions and completions to simply the list lock of the > queue in question. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v4 0/6] Several changes for the UPIU trace
Bean, > Bean Huo (6): > scsi: ufs: Remove stringize operator '#' restriction > scsi: ufs: Use __print_symbolic() for UFS trace string print > scsi: ufs: Don't call trace_ufshcd_upiu() in case trace poit is > disabled > scsi: ufs: Distinguish between query REQ and query RSP in query trace > scsi: ufs: Distinguish between TM request UPIU and response UPIU in TM > UPIU trace > scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2 4/5] ibmvfc: complete commands outside the host/queue lock
Tyrel, > Drain the command queue and place all commands on a completion list. > Perform command completion on that list outside the host/queue locks. > Further, move purged command compeletions outside the host_lock as well. Please resubmit entire series instead of amending individual patches. thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 0/2] hisi_sas: Expose hw queues for v2 hw and remove unused code
John, > Patch "scsi: hisi_sas: Expose HW queues for v2 hw" was not merged for > v5.11, so resending for v5.12. Any changes to it? 5.11/postmerge is sitting in my fixes branch. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns
Jaegeuk,
> When gate_work/ungate_work gets an error during hibern8_enter or exit,
> ufshcd_err_handler()
>ufshcd_scsi_block_requests()
>ufshcd_reset_and_restore()
> ufshcd_clear_ua_wluns() -> stuck
>ufshcd_scsi_unblock_requests()
>
> In order to avoid it, ufshcd_clear_ua_wluns() can be called per recovery flows
> such as suspend/resume, link_recovery, and error_handler.
>
> Fixes: 1918651f2d7e ("scsi: ufs: Clear UAC for RPMB after ufshcd resets")
> Signed-off-by: Jaegeuk Kim
Please resubmit instead of replying to an existing patch. Both b4 and
patchwork get confused.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2 0/4] scsi: ufs: Cleanup and refactor clock scaling
Stanley, > However this series may not be required to be merged to 5.10. The > choice of base branch is simply making these patches easy to be > reviewed because this series is based on clk-scaling fixes by Can. Please redo your series on top of 5.12/scsi-queue + Can's changes. Thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v5 5/5] scsi: hisi_sas: Expose HW queues for v2 hw
John, > Is there some way in this patch can be merged for 5.11 via the SCSI > tree? It has a dependency on the earlier patches in the series, now > picked up via irqchip tree. I've seen multiple rounds of SCSI pull > requests before, but not sure when we have that or if the tree is > rebased for those. I'll do a postmerge branch for a few things, including your patch and the megaraid patch. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] Revert "scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()"
Wei, > Sorry for the last minute patch. We would very like this goes into > 5.10 if possible; otherwise Linux 5.10 is going to be broken on > Hyper-V. :-( Applied to 5.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v3] scsi: ufs: Remove pre-defined initial voltage values of device powers
On Wed, 2 Dec 2020 17:18:19 +0800, Stanley Chu wrote: > UFS specficication allows different VCC configurations for UFS devices, > for example, > (1). 2.70V - 3.60V (Activated by default in UFS core driver) > (2). 1.70V - 1.95V (Activated if "vcc-supply-1p8" is declared in > device tree) > (3). 2.40V - 2.70V (Supported since UFS 3.x) > > [...] Applied to 5.11/scsi-queue, thanks! [1/1] scsi: ufs: Remove pre-defined initial voltage values of device powers https://git.kernel.org/mkp/scsi/c/5b44a07b6bb2 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v3] scsi: NCR5380: Remove context check
On Sun, 6 Dec 2020 08:51:57 +0100, Ahmed S. Darwish wrote: > NCR5380_poll_politely2() uses in_interrupt() and irqs_disabled() to > check if it is safe to sleep. > > Such usage in drivers is phased out and Linus clearly requested that > code which changes behaviour depending on context should either be > separated, or the context be explicitly conveyed in an argument passed > by the caller. > > [...] Applied to 5.11/scsi-queue, thanks! [1/1] scsi: NCR5380: Remove context check https://git.kernel.org/mkp/scsi/c/e7734ef14ead -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: fix error return code in fnic_probe()
On Fri, 4 Dec 2020 15:47:39 +0800, Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: fnic: fix error return code in fnic_probe() https://git.kernel.org/mkp/scsi/c/d4fc94fe6557 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval
On Fri, 4 Dec 2020 19:18:10 +, Colin King wrote: > The variable rval is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: qla4xxx: remove redundant assignment to variable rval https://git.kernel.org/mkp/scsi/c/3a5b9fa2cc5f -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2] scsi: qla2xxx: remove trailing semicolon in macro definition
On Mon, 30 Nov 2020 12:55:09 -0800, t...@redhat.com wrote: > The macro use will already have a semicolon. > Remove unneeded escaped newline. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: qla2xxx: remove trailing semicolon in macro definition https://git.kernel.org/mkp/scsi/c/8f525bc2a7b2 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: iscsi: fix inappropriate use of put_device
On Fri, 20 Nov 2020 15:48:52 +0800, Qinglang Miao wrote: > kfree(conn) is called inside put_device(>dev) so that > another one would cause use-after-free. Besides, device_unregister > should be used here rather than put_device. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: iscsi: fix inappropriate use of put_device https://git.kernel.org/mkp/scsi/c/6dc1c7ab6f04 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: qedi: fix missing destroy_workqueue() on error in __qedi_probe
On Mon, 9 Nov 2020 17:15:18 +0800, Qinglang Miao wrote: > Add the missing destroy_workqueue() before return from > __qedi_probe in the error handling case when fails to > create workqueue qedi->offload_thread. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: qedi: fix missing destroy_workqueue() on error in __qedi_probe https://git.kernel.org/mkp/scsi/c/62eebd5247c4 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v5 0/4] scsi: ufs: Refine error history and introduce event_notify vop
On Sat, 5 Dec 2020 19:58:57 +0800, Stanley Chu wrote: > This series refines error history functions and introduces a new event_notify > vop to allow vendor to get notification of important events. > > Changes since v4: > - Seperate patch sets according to Avri's suggestion > > Changes since v3: > - Fix build warning in patch [8/8] > > [...] Applied to 5.11/scsi-queue, thanks! [1/4] scsi: ufs: Add error history for abort event in UFS Device W-LUN https://git.kernel.org/mkp/scsi/c/eb3d2611df2e [2/4] scsi: ufs: Refine error history functions https://git.kernel.org/mkp/scsi/c/e965e5e00b23 [3/4] scsi: ufs: Introduce event_notify variant function https://git.kernel.org/mkp/scsi/c/172614a9d0e8 [4/4] scsi: ufs-mediatek: Introduce event_notify implementation https://git.kernel.org/mkp/scsi/c/ca1bb061d644 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v1 0/4] scsi: ufs: Cleanup phy_initialization vop
On Sat, 5 Dec 2020 20:00:37 +0800, Stanley Chu wrote: > This series simply cleans up UFS vops and shall not change any functionality. > > Stanley Chu (4): > scsi: ufs: Remove unused setup_regulators variant function > scsi: ufs: Introduce phy_initialization helper > scsi: ufs-cdns: Use phy_initialization helper > scsi: ufs-dwc: Use phy_initialization helper > > [...] Applied to 5.11/scsi-queue, thanks! [1/4] scsi: ufs: Remove unused setup_regulators variant function https://git.kernel.org/mkp/scsi/c/ade921a891de [2/4] scsi: ufs: Introduce phy_initialization helper https://git.kernel.org/mkp/scsi/c/92bcebe4b6d6 [3/4] scsi: ufs-cdns: Use phy_initialization helper https://git.kernel.org/mkp/scsi/c/885445736bc0 [4/4] scsi: ufs-dwc: Use phy_initialization helper https://git.kernel.org/mkp/scsi/c/ab98105484fc -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] ufshcd: fix Wsometimes-uninitialized warning
On Thu, 3 Dec 2020 23:31:26 +0100, Arnd Bergmann wrote:
> clang complains about a possible code path in which a variable is
> used without an initialization:
>
> drivers/scsi/ufs/ufshcd.c:7690:3: error: variable 'sdp' is used uninitialized
> whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> BUG_ON(1);
> ^
> include/asm-generic/bug.h:63:36: note: expanded from macro 'BUG_ON'
> #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
>^~~
>
> [...]
Applied to 5.11/scsi-queue, thanks!
[1/1] ufshcd: fix Wsometimes-uninitialized warning
https://git.kernel.org/mkp/scsi/c/4c60244dc372
--
Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] SCSI: cxgb4i: fix TLS dependency
Randy, > SCSI_CXGB4_ISCSI selects CHELSIO_T4. The latter depends on > TLS || TLS=n, so since 'select' does not check dependencies of > the selected symbol, SCSI_CXGB4_ISCSI should also depend on > TLS || TLS=n. > > This prevents the following kconfig warning and restricts > SCSI_CXGB4_ISCSI to 'm' whenever TLS=m. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2 0/2] scsi: ufs: Re-enable WB after device reset
Stanley, > This series fixes up an issue that WB is not re-enabled after device > reset. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 1/1] scsi: ufs-mediatek: use correct path to fix compiling error
Zhen, > So without "CFLAGS_ufs-mediatek.o := -I$(src)", the current directory "." > is "include/trace/", the relative path of ufs-mediatek-trace.h is > "../../drivers/scsi/ufs/". Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: problem booting 5.10
Julia, > 5.10-rc7 plus these three commits boots fine. Great! Thanks for confirming. -- Martin K. Petersen Oracle Linux Engineering
Re: [dm-devel] [RFC PATCH v2 1/2] block: add simple copy support
SelvaKumar, > Add new BLKCOPY ioctl that offloads copying of multiple sources > to a destination to the device. Your patches are limited in scope to what is currently possible with NVMe. I.e. multiple source ranges to a single destination within the same device. That's fine, I think the garbage collection use case is valid and worth pursuing. I just wanted to go over what the pain points were for the various attempts in SCSI over the years. The main headache was due the stacking situation with DM and MD. Restricting offload to raw SCSI disks would have been simple but not really a good fit for most real world developments that often use DM or MD to provision the storage. Things are simple for DM/MD with reads and writes because you have one bio as parent that may get split into many clones that complete individually prior to the parent being marked as completed. In the copy offload scenario things quickly become complex once both source and destination ranges have to be split into multiple commands for potentially multiple devices. And these clones then need to be correctly paired at the bottom of the stack. There's also no guarantee that a 1MB source range maps to a single 1MB destination range. So you could end up with an M:N relationship to resolve. After a few failed attempts we focused on single source range/single destination range. Just to simplify the slicing and dicing. That worked reasonably well. However, then came along the token-based commands in SCSI and those threw a wrench in the gears. Now the block layer plumbing had to support two completely different semantic approaches. Inspired by a combination of Mikulas' efforts with pointer matching and the token-based approach in SCSI I switched the block layer implementation from a single operation (REQ_COPY) to something similar to the SCSI token approach with a REQ_COPY_IN and a REQ_COPY_OUT. The premise being that you would send a command to the source device and "get" the data. In the EXTENDED COPY scenario, the data wasn't really anything but a confirmation from the SCSI disk driver that the I/O had reached the bottom of the stack without being split by DM/MD. And once completion of the REQ_COPY_IN reached blk-lib, a REQ_COPY_OUT would be issued and, if that arrived unchanged in the disk driver, get turned into an EXTENDED COPY sent to the destination. In the token-based scenario the same thing happened except POPULATE TOKEN was sent all the way out to the device to receive a cookie representing the source block ranges. Upon completion, that cookie was used by blk-lib to issue a REQ_COPY_OUT command which was then sent to the destination device. Again only if the REQ_COPY_OUT I/O hadn't been split traversing the stack. The idea was to subsequently leverage the separation of REQ_COPY_IN and REQ_COPY_OUT to permit a DM/MD iterative approach to both stages of the operation. That seemed to me like the only reasonable way to approach the M:N splitting problem (if at all)... -- Martin K. Petersen Oracle Linux Engineering
Re: [RFC PATCH v2 0/2] add simple copy support
Hannes, [Sorry I'm late to the discussion here, had a few fires going in addition to the end of the kernel cycle] > And we shouldn't forget that the main issue which killed all previous > implementations was a missing QoS guarantee. That and the fact that our arbitrary stacking situation was hard to resolve. The QoS guarantee was somewhat addressed by Fred in T10. But I agree we need some sort of toggle. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v1 0/2] scsi: ufs: Allow regulators being always on
Stanley, > This series allow vendors to keep the regulator always-on, and provide > an implementation on MediaTek UFS platforms. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 0/4] scsi: ufs-pci: Fixes for Intel controllers
Adrian, > Here are some small fixes / amendments. > > Adrian Hunter (4): > scsi: ufs-pci: Fix restore from S4 for Intel controllers > scsi: ufs-pci: Ensure UFS device is in PowerDown mode for > suspend-to-disk ->poweroff() > scsi: ufs-pci: Fix recovery from hibernate exit errors for Intel > controllers > scsi: ufs-pci: Enable UFSHCD_CAP_RPM_AUTOSUSPEND for Intel controllers Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2] scsi: ufs: clear uac for RPMB after ufshcd resets
Jaegeuk, > If RPMB is not provisioned, we may see RPMB failure after UFS suspend/resume. > Inject request_sense to clear uac in ufshcd reset flow. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 0/2] two UFS changes
Bean, > Bean Huo (2): > scsi: ufs: Remove an unused macro definition POWER_DESC_MAX_SIZE > scsi: ufs: Fix wrong print message in dev_err() Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: problem booting 5.10
Linus, > I'll take this as an "ack" for the revert, though ;) Indeed! -- Martin K. Petersen Oracle Linux Engineering
Re: problem booting 5.10
Jens, > Thanks for testing! Linus, do you just want to revert this, or do you > want me to queue it up? Oh, I just realized the megaraid patch went in through block. -- Martin K. Petersen Oracle Linux Engineering
Re: problem booting 5.10
Julia, > This solves the problem. Starting from 5.10-rc7 and doing this revert, I > get a kernel that boots. Thanks for testing! I'll go ahead and revert 103fbf8e4020 in 5.10/scsi-fixes. We can revisit this change in 5.11 when Ming's fixes are in place. -- Martin K. Petersen Oracle Linux Engineering
Re: problem booting 5.10
Linus, > So I'm adding SCSI people to the cc, just in case they go "Hmm..". Only change in this department was: 831e3405c2a3 scsi: core: Don't start concurrent async scan on same host which went into -rc2. I can't think of anything in -rc1 which would affect scanning. I'll take a look this afternoon. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: hisi_sas: Select a suitable queue for internal IOs
On Mon, 7 Dec 2020 21:30:55 +0800, John Garry wrote: > For when managed interrupts are used (and shost->nr_hw_queues is set), a > fixed queue - set per-device - is still used for internal IOs. > > If all the CPUs mapped to that queue are offlined, then the completions > for that queue are not serviced and any internal IOs will timeout. > > Fix by selecting a queue for internal IOs from the queue mapped from > the current CPU in this scenario. > > [...] Applied to 5.10/scsi-fixes, thanks! [1/1] scsi: hisi_sas: Select a suitable queue for internal IOs https://git.kernel.org/mkp/scsi/c/359db63378ed -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: pm8001: remove space in a debug message
On Tue, 24 Nov 2020 09:38:28 +, Colin King wrote: > There are two words that need separating with a space in a > pm8001_dbg message. Fix it. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: pm8001: remove space in a debug message https://git.kernel.org/mkp/scsi/c/c6131854e28a -- Martin K. Petersen Oracle Linux Engineering
Re: (subset) [PATCH 000/141] Fix fall-through warnings for Clang
On Fri, 20 Nov 2020 12:21:39 -0600, Gustavo A. R. Silva wrote: > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. > > In preparation to enable -Wimplicit-fallthrough for Clang, explicitly > add multiple break/goto/return/fallthrough statements instead of just > letting the code fall through to the next case. > > [...] Applied to 5.11/scsi-queue, thanks! [054/141] target: Fix fall-through warnings for Clang https://git.kernel.org/mkp/scsi/c/492096ecfa39 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 1/1] scsi: ufs: Remove scale down gear hard code
On Thu, 26 Nov 2020 17:58:48 -0800, Can Guo wrote: > Instead of making the scale down gear a hard code, make it a member of > ufs_clk_scaling struct. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: ufs: Remove scale down gear hard code https://git.kernel.org/mkp/scsi/c/29b87e92a216 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: qla4xxx: remove redundant assignment to variable rval
Colin, > The variable rval is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2] scsi: qla2xxx: remove trailing semicolon in macro definition
Tom, > The macro use will already have a semicolon. Remove unneeded escaped > newline. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: fix error return code in fnic_probe()
Zhang, > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] ufshcd: fix Wsometimes-uninitialized warning
Arnd, > clang complains about a possible code path in which a variable is > used without an initialization: > > drivers/scsi/ufs/ufshcd.c:7690:3: error: variable 'sdp' is used uninitialized > whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > BUG_ON(1); > ^ Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v3] scsi: NCR5380: Remove context check
Ahmed, > NCR5380_poll_politely2() uses in_interrupt() and irqs_disabled() to > check if it is safe to sleep. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v3] scsi: ufs: Remove pre-defined initial voltage values of device powers
Stanley, > UFS specficication allows different VCC configurations for UFS devices, > for example, Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v1 0/4] scsi: ufs: Cleanup phy_initialization vop
Stanley, > This series simply cleans up UFS vops and shall not change any > functionality. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v5 0/4] scsi: ufs: Refine error history and introduce event_notify vop
Stanley, > This series refines error history functions and introduces a new > event_notify vop to allow vendor to get notification of important > events. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] SCSI: bnx2i: requires MMU
On Sat, 28 Nov 2020 23:09:16 -0800, Randy Dunlap wrote: > The SCSI_BNX2_ISCSI kconfig symbol selects CNIC and CNIC selects UIO, > which depends on MMU. > Since 'select' does not follow dependency chains, add the same MMU > dependency to SCSI_BNX2_ISCSI. > > Quietens this kconfig warning: > > [...] Applied to 5.10/scsi-fixes, thanks! [1/1] SCSI: bnx2i: requires MMU https://git.kernel.org/mkp/scsi/c/2d586494c4a0 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: be2iscsi: revert "Fix a theoretical leak in beiscsi_create_eqs()"
On Thu, 3 Dec 2020 15:18:26 +0300, Dan Carpenter wrote: > My patch caused kernel Oopses and delays in boot. Revert it. > > The problem was that I moved the "mem->dma = paddr;" before the call to > be_fill_queue(). But the first thing that the be_fill_queue() function > does is memset the whole struct to zero which overwrites the assignment. Added Cc: stable and applied to 5.10/scsi-fixes, thanks! [1/1] scsi: be2iscsi: revert "Fix a theoretical leak in beiscsi_create_eqs()" https://git.kernel.org/mkp/scsi/c/eeaf06af6f87 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: storvsc: Fix error return in storvsc_probe()
On Fri, 27 Nov 2020 11:02:06 +0800, Jing Xiangfeng wrote: > Fix to return a error code "-ENOMEM" from the error handling case > instead of 0. Applied to 5.10/scsi-fixes, thanks! [1/1] scsi: storvsc: Fix error return in storvsc_probe() https://git.kernel.org/mkp/scsi/c/6112ff4e8f39 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()
On Wed, 18 Nov 2020 15:53:48 +0100, Andrea Parri (Microsoft) wrote: > Check that the packet is of the expected size at least, don't copy > data past the packet. Applied to 5.10/scsi-fixes, thanks! [1/1] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback() https://git.kernel.org/mkp/scsi/c/3b8c72d076c4 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 000/141] Fix fall-through warnings for Clang
Gustavo, > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] SCSI: bnx2i: requires MMU
Randy, > The SCSI_BNX2_ISCSI kconfig symbol selects CNIC and CNIC selects UIO, > which depends on MMU. Since 'select' does not follow dependency > chains, add the same MMU dependency to SCSI_BNX2_ISCSI. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 1/1] scsi: ufs: Remove scale down gear hard code
Can, > Instead of making the scale down gear a hard code, make it a member of > ufs_clk_scaling struct. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG
On Fri, 20 Nov 2020 14:07:12 -0800, Karan Tilak Kumar wrote: > Replacing shost_printk with FNIC_FCS_DBG so that > these log messages are controlled by fnic_log_level > flag in fnic_fip_handler_timer. > > Bumping up version number from 47 to 49 to > maintain same level as internal version. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: fnic: Change shost_printk() to FNIC_FCS_DBG() https://git.kernel.org/mkp/scsi/c/90b3a938031f -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v4 00/29] scsi: use generic power management
On Mon, 2 Nov 2020 22:17:01 +0530, Vaibhav Gupta wrote: > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to upgrade power management in > drivers. This has been done by upgrading .suspend() and .resume() callbacks. > > The upgrade makes sure that the involvement of PCI Core does not change the > order of operations executed in a driver. Thus, does not change its behavior. > > [...] Applied to 5.11/scsi-queue, thanks! [01/29] scsi: megaraid_sas: Drop PCI wakeup calls from .resume https://git.kernel.org/mkp/scsi/c/8ed9d987c6d9 [02/29] scsi: megaraid_sas: Use generic power management https://git.kernel.org/mkp/scsi/c/977001df0368 [03/29] scsi: megaraid_sas: Update function description https://git.kernel.org/mkp/scsi/c/498854102c1c [04/29] scsi: aacraid: Drop pci_enable_wake() from .resume https://git.kernel.org/mkp/scsi/c/7dd18076 [05/29] scsi: aacraid: Use generic power management https://git.kernel.org/mkp/scsi/c/7e380b5c27ea [06/29] scsi: aic7xxx: Use generic power management https://git.kernel.org/mkp/scsi/c/6897b9a177df [07/29] scsi: aic79xx: Use generic power management https://git.kernel.org/mkp/scsi/c/ec199a8df698 [08/29] scsi: arcmsr: Drop PCI wakeup calls from .resume https://git.kernel.org/mkp/scsi/c/b7b862d75b49 [09/29] scsi: arcmsr: Use generic power management https://git.kernel.org/mkp/scsi/c/756ebbe73fc4 [10/29] scsi: esas2r: Drop PCI Wakeup calls from .resume https://git.kernel.org/mkp/scsi/c/996360c141a6 [11/29] scsi: esas2r: Use generic power management https://git.kernel.org/mkp/scsi/c/5f2d8c365050 [12/29] scsi: hisi_sas_v3_hw: Drop PCI Wakeup calls from .resume https://git.kernel.org/mkp/scsi/c/17b5e4d14837 [13/29] scsi: hisi_sas_v3_hw: Don't use PCI helper functions https://git.kernel.org/mkp/scsi/c/027e508aea45 [14/29] scsi: hisi_sas_v3_hw: Remove extra function calls for runtime pm https://git.kernel.org/mkp/scsi/c/71c8f15e1dbc [15/29] scsi: mpt3sas_scsih: Drop PCI Wakeup calls from .resume https://git.kernel.org/mkp/scsi/c/eaf148359d00 [16/29] scsi: mpt3sas_scsih: Use generic power management https://git.kernel.org/mkp/scsi/c/17287305a526 [17/29] scsi: lpfc: Use generic power management https://git.kernel.org/mkp/scsi/c/ef6fa16b5d4a [18/29] scsi: pm_8001: Drop PCI Wakeup calls from .resume https://git.kernel.org/mkp/scsi/c/66aea31a2d26 [19/29] scsi: pm_8001: Use generic power management https://git.kernel.org/mkp/scsi/c/47c37c4dbf93 [20/29] scsi: hpsa: Use generic power management https://git.kernel.org/mkp/scsi/c/e5b79ebfb854 [21/29] scsi: 3w-9xxx: Drop PCI Wakeup calls from .resume https://git.kernel.org/mkp/scsi/c/3a09951ae366 [22/29] scsi: 3w-9xxx: Use generic power management https://git.kernel.org/mkp/scsi/c/d53ae6bbeb71 [23/29] scsi: 3w-sas: Drop PCI Wakeup calls from .resume https://git.kernel.org/mkp/scsi/c/7ea03ab79e00 [24/29] scsi: 3w-sas: Use generic power management https://git.kernel.org/mkp/scsi/c/99769d8d9109 [25/29] scsi: mvumi: Drop PCI Wakeup calls from .resume https://git.kernel.org/mkp/scsi/c/bd7463cdbe1a [26/29] scsi: mvumi: Use generic power management https://git.kernel.org/mkp/scsi/c/0572edbc32c5 [27/29] scsi: mvumi: Update function description https://git.kernel.org/mkp/scsi/c/53fdec73c14f [28/29] scsi: pmcraid: Drop PCI Wakeup calls from .resume https://git.kernel.org/mkp/scsi/c/0aea8a8f3a77 [29/29] scsi: pmcraid: Use generic power management https://git.kernel.org/mkp/scsi/c/ac85cca31637 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 0/2] scsi: pm8001: logging neatening
On Fri, 20 Nov 2020 15:16:08 -0800, Joe Perches wrote: > Reduce code duplication and generic neatening of logging macros > > Joe Perches (2): > scsi: pm8001: Neaten debug logging macros and uses > scsi: pm8001: Make implicit use of pm8001_ha in pm8001_printk explicit > > drivers/scsi/pm8001/pm8001_ctl.c |7 +- > drivers/scsi/pm8001/pm8001_hwi.c | 1370 ++--- > drivers/scsi/pm8001/pm8001_init.c | 102 +- > drivers/scsi/pm8001/pm8001_sas.c | 136 ++- > drivers/scsi/pm8001/pm8001_sas.h | 45 +- > drivers/scsi/pm8001/pm80xx_hwi.c | 1596 - > 6 files changed, 1361 insertions(+), 1895 deletions(-) Applied to 5.11/scsi-queue, thanks! [1/2] scsi: pm8001: Neaten debug logging macros and uses https://git.kernel.org/mkp/scsi/c/1b5d2793283d [2/2] scsi: pm8001: Make implicit use of pm8001_ha in pm8001_printk() explicit https://git.kernel.org/mkp/scsi/c/89eddb401080 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: Change shost_printk to FNIC_MAIN_DBG
On Fri, 20 Nov 2020 17:37:39 -0800, Karan Tilak Kumar wrote: > Replacing shost_printk with FNIC_MAIN_DBG so that > these log messages are controlled by fnic_log_level > flag in fnic_handle_link. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: fnic: Change shost_printk() to FNIC_MAIN_DBG() https://git.kernel.org/mkp/scsi/c/875d4eda3bd6 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi/atari_scsi: Fix race condition between .queuecommand and EH
On Fri, 20 Nov 2020 15:39:56 +1100, Finn Thain wrote: > It is possible that bus_reset_cleanup() or .eh_abort_handler could > be invoked during NCR5380_queuecommand(). If that takes place before > the new command is enqueued and after the ST-DMA "lock" has been > acquired, the ST-DMA "lock" will be released again. This will result > in a lost DMA interrupt and a command timeout. Fix this by excluding > EH and interrupt handlers while the new command is enqueued. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: atari_scsi: Fix race condition between .queuecommand and EH https://git.kernel.org/mkp/scsi/c/03fe6a640a05 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: pm8001: remove casting kcalloc
On Fri, 20 Nov 2020 08:36:48 +, Xu Wang wrote: > Remove casting the values returned by kcalloc. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: pm8001: Remove typecast for pointer returned by kcalloc() https://git.kernel.org/mkp/scsi/c/27a34943bd89 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: set scsi_set_resid only for underflow
On Fri, 20 Nov 2020 17:51:34 -0800, Karan Tilak Kumar wrote: > Fix to set scsi_set_resid() only if > FCPIO_ICMND_CMPL_RESID_UNDER is set. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: fnic: Set scsi_set_resid() only for underflow https://git.kernel.org/mkp/scsi/c/74ae6d6a6805 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: Validate io_req before others
On Fri, 20 Nov 2020 18:33:37 -0800, Karan Tilak Kumar wrote: > We need to check for a valid io_req before > we check other data. Also, removing > redundant checks. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: fnic: Validate io_req before others https://git.kernel.org/mkp/scsi/c/3256b4682386 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: ufs: Adjust logic in common ADAPT helper
On Fri, 20 Nov 2020 20:48:10 -0800, Bjorn Andersson wrote: > The introduction of ufshcd_dme_configure_adapt() refactored out > duplication from the Mediatek and Qualcomm drivers. > > Both these implementations had the logic of: > gear_tx == UFS_HS_G4 => PA_INITIAL_ADAPT > gear_tx != UFS_HS_G4 => PA_NO_ADAPT > > [...] Applied to 5.11/scsi-queue, thanks! [1/1] scsi: ufs: Adjust logic in common ADAPT helper https://git.kernel.org/mkp/scsi/c/66df79ccbc2f -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi/NCR5380: Reduce NCR5380_maybe_release_dma_irq() call sites
On Fri, 20 Nov 2020 15:39:56 +1100, Finn Thain wrote: > Refactor to avoid needless calls to NCR5380_maybe_release_dma_irq(). > This makes the machine code smaller and the source more readable. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: NCR5380: Reduce NCR5380_maybe_release_dma_irq() call sites https://git.kernel.org/mkp/scsi/c/bdd1cc0377d3 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: Avoid looping in TRANS ETH on unload
On Fri, 20 Nov 2020 17:21:45 -0800, Karan Tilak Kumar wrote: > This change is to avoid looping in > fnic_scsi_abort_io before sending fw reset when > fnic is in TRANS ETH state and when we have not > received any link events. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: fnic: Avoid looping in TRANS ETH on unload https://git.kernel.org/mkp/scsi/c/f9e2beb990f0 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: ufs: Remove unnecessary if condition in ufshcd_suspend()
Bean, > In the case that auto_bkops_enable is false, which means auto bkops > has been disabled, so no need to call ufshcd_disable_auto_bkops(). Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v2 0/3] hisi_sas: A small bunch of misc patches
John, > This series contains a small bunch of patches for the driver, including: > - Fix-up on error paths for v3 hw driver > - Relocate as much debugfs code as possible to v3 hw driver since > no other hw drivers support it > - A small tidy-up patch Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: pm8001: remove space in a debug message
Colin, > There are two words that need separating with a space in a > pm8001_dbg message. Fix it. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 0/2] scsi: pm8001: Further neatening and whitespace
Joe, > Make the logging macro uses clearer and fix a whitespace defect. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: ufs: Adjust logic in common ADAPT helper
Bjorn, > The introduction of ufshcd_dme_configure_adapt() refactored out > duplication from the Mediatek and Qualcomm drivers. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: lpfc: Fix memory leak on lcb_context
On Wed, 18 Nov 2020 14:13:14 +, Colin King wrote: > Currently there is an error return path that neglects to free the > allocation for lcb_context. Fix this by adding a new error free > exit path that kfree's lcb_context before returning. Use this new > kfree exit path in another exit error path that also kfree's the same > object, allowing a line of code to be removed. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: lpfc: Fix memory leak on lcb_context https://git.kernel.org/mkp/scsi/c/14c1dd950411 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v3 0/6] ibmvfc: Protocol definition updates and new targetWWPN Support
On Tue, 17 Nov 2020 19:10:58 -0600, Tyrel Datwyler wrote: > Several Management Datagrams (MADs) have been reversioned to add a targetWWPN > field that is intended to better identify a target over in place of the > scsi_id. > This patchset adds the new protocol definitions and implements support for > using > the new targetWWPN field and exposing the capability to the VIOS. This > targetWWPN support is a prerequisuite for upcoming channelization/MQ support. > > changes in v3: > * addressed field naming consistency in Patches 2 & 5 in response to [brking] > * fixed commit log typos > * fixed bad rebase of Patch 4 such that it now compiles > > [...] Applied to 5.11/scsi-queue, thanks! [1/6] scsi: ibmvfc: Deduplicate common ibmvfc_cmd init code https://git.kernel.org/mkp/scsi/c/fad74a1be2db [2/6] scsi: ibmvfc: Add new fields for version 2 of several MADs https://git.kernel.org/mkp/scsi/c/c16b8a6d8af1 [3/6] scsi: ibmvfc: Add helper for testing capability flags https://git.kernel.org/mkp/scsi/c/a318c2b71cce [4/6] scsi: ibmvfc: Add FC payload retrieval routines for versioned vfcFrames https://git.kernel.org/mkp/scsi/c/5a9d16f71c26 [5/6] scsi: ibmvfc: Add support for target_wwpn field in v2 MADs and vfcFrame https://git.kernel.org/mkp/scsi/c/ebc7c74bd2dc [6/6] scsi: ibmvfc: Advertise client support for targetWWPN using v2 commands https://git.kernel.org/mkp/scsi/c/e4af87b7079e -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 1/3] ibmvfc: byte swap login_buf.resp values in attribute show functions
On Tue, 17 Nov 2020 12:50:29 -0600, Tyrel Datwyler wrote: > Both ibmvfc_show_host_(capabilities|npiv_version) functions retrieve > values from vhost->login_buf.resp buffer. This is the MAD response > buffer from the VIOS and as such any multi-byte non-string values are in > big endian format. > > Byte swap these values to host cpu endian format for better human > readability. Applied to 5.11/scsi-queue, thanks! [1/3] scsi: ibmvfc: Byte swap login_buf.resp values in attribute show functions https://git.kernel.org/mkp/scsi/c/61bdb4eec8d1 [2/3] scsi: ibmvfc: Remove trailing semicolon https://git.kernel.org/mkp/scsi/c/4e0716199ab6 [3/3] scsi: ibmvfc: Use correlation token to tag commands https://git.kernel.org/mkp/scsi/c/2aa0102c6688 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v5 0/5] scsi: ufs: add some fixes
On Tue, 17 Nov 2020 08:58:32 -0800, Jaegeuk Kim wrote: > Change log from v4: > - add more fixes > > Change log from v3: > - use __ufshcd_release with a fix in __ufshcd_release > > Change log from v2: > - use active_req-- instead of __ufshcd_release to avoid UFS timeout > > [...] Applied to 5.11/scsi-queue, thanks! [1/7] scsi: ufs: Avoid to call REQ_CLKS_OFF to CLKS_OFF https://git.kernel.org/mkp/scsi/c/fd62de114f8c [2/7] scsi: ufs: Atomic update for clkgating_enable https://git.kernel.org/mkp/scsi/c/b66451129764 [3/7] scsi: ufs: Clear UAC for FFU and RPMB LUNs https://git.kernel.org/mkp/scsi/c/4f3e900b6282 [4/7] scsi: ufs: Use WQ_HIGHPRI for gating work https://git.kernel.org/mkp/scsi/c/e93e6e49fa31 [5/7] scsi: ufs: Add more contexts in the ufs tracepoints https://git.kernel.org/mkp/scsi/c/69a314d6a155 [6/7] scsi: ufs: Fix clkgating on/off https://git.kernel.org/mkp/scsi/c/8eb456be75af [7/7] scsi: ufs: Show LBA and length for UNMAP commands https://git.kernel.org/mkp/scsi/c/3754cde8df91 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: lpfc: remove dead code on second !ndlp check
On Wed, 18 Nov 2020 13:37:44 +, Colin King wrote: > Currently there is a null check on the pointer ndlp that exits via > error path issue_ct_rsp_exit followed by another null check on the > same pointer that is almost identical to the previous null check > stanza and yet can never can be reached because the previous check > exited via issue_ct_rsp_exit. This is deadcode and can be removed. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: lpfc: Remove dead code on second !ndlp check https://git.kernel.org/mkp/scsi/c/61795a5316ad -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH][next] scsi: lpfc: fix pointer defereference before it is null checked issue
On Wed, 18 Nov 2020 13:13:45 +, Colin King wrote: > There is a null check on pointer lpfc_cmd after the pointer has been > dereferenced when pointers rdata and ndlp are initialized at the start > of the function. Fix this by only assigning rdata and ndlp after the > pointer lpfc_cmd has been null checked. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: lpfc: Fix pointer defereference before it is null checked issue https://git.kernel.org/mkp/scsi/c/1e7dddb2e76a -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG
Karan, > Replacing shost_printk with FNIC_FCS_DBG so that these log messages > are controlled by fnic_log_level flag in fnic_fip_handler_timer. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: Validate io_req before others
Karan, > We need to check for a valid io_req before we check other data. Also, > removing redundant checks. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: set scsi_set_resid only for underflow
Karan, > Fix to set scsi_set_resid() only if FCPIO_ICMND_CMPL_RESID_UNDER is > set. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: Avoid looping in TRANS ETH on unload
Karan, > This change is to avoid looping in fnic_scsi_abort_io before sending > fw reset when fnic is in TRANS ETH state and when we have not received > any link events. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: fnic: Change shost_printk to FNIC_MAIN_DBG
Karan, > Replacing shost_printk with FNIC_MAIN_DBG so that these log messages > are controlled by fnic_log_level flag in fnic_handle_link. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 0/2] scsi: pm8001: logging neatening
Joe, > Reduce code duplication and generic neatening of logging macros Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi/NCR5380: Reduce NCR5380_maybe_release_dma_irq() call sites
Finn, > Refactor to avoid needless calls to NCR5380_maybe_release_dma_irq(). > This makes the machine code smaller and the source more readable. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi/atari_scsi: Fix race condition between .queuecommand and EH
Finn, > It is possible that bus_reset_cleanup() or .eh_abort_handler could be > invoked during NCR5380_queuecommand(). If that takes place before the > new command is enqueued and after the ST-DMA "lock" has been acquired, > the ST-DMA "lock" will be released again. This will result in a lost > DMA interrupt and a command timeout. Fix this by excluding EH and > interrupt handlers while the new command is enqueued. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: pm8001: remove casting kcalloc
Xu, > Remove casting the values returned by kcalloc. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value'
On Mon, 16 Nov 2020 10:41:19 +, Lee Jones wrote: > Hasn't been used since 2009. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_hwi.c: In function ‘mpi_set_phys_g3_with_ssc’: > drivers/scsi/pm8001/pm8001_hwi.c:415:6: warning: variable ‘value’ set but > not used [-Wunused-but-set-variable] Applied to 5.11/scsi-queue, thanks! [1/1] scsi: pm8001: Remove unused variable 'value' https://git.kernel.org/mkp/scsi/c/a364a3ea32da -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH -next] scsi: be2iscsi: Mark beiscsi_attrs with static keyword
On Sat, 14 Nov 2020 15:37:54 +0800, Zou Wei wrote: > Fix the following sparse warning: > > ./be_main.c:167:25: warning: symbol 'beiscsi_attrs' was not declared. Should > it be static? Applied to 5.11/scsi-queue, thanks! [1/1] scsi: be2iscsi: Mark beiscsi_attrs with static keyword https://git.kernel.org/mkp/scsi/c/4ab2990a5ce1 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH v1 0/9] scsi: ufs: Refactoring and cleanups
On Mon, 16 Nov 2020 14:50:45 +0800, Stanley Chu wrote: > This series simply do some refactoring and cleanups in UFS drivers. > > Stanley Chu (9): > scsi: ufs-mediatek: Refactor performance scaling functions > scsi: ufs: Introduce device parameter initialization function > scsi: ufs-mediatek: Use device parameter initialization function > scsi: ufs-qcom: Use device parameter initialization function > scsi: ufs-exynos: Use device parameter initialization function > scsi: ufs-hisi: Use device parameter initialization function > scsi: ufs: Refactor ADAPT configuration function > scsi: ufs-mediatek: Use common ADAPT configuration function > scsi: ufs-qcom: Use common ADAPT configuration function > > [...] Applied to 5.11/scsi-queue, thanks! [1/9] scsi: ufs: ufs-mediatek: Refactor performance scaling functions https://git.kernel.org/mkp/scsi/c/54770cbebe2c [2/9] scsi: ufs: Introduce device parameter initialization function https://git.kernel.org/mkp/scsi/c/65858014ee20 [3/9] scsi: ufs: ufs-mediatek: Use device parameter initialization function https://git.kernel.org/mkp/scsi/c/a4b537ea656e [4/9] scsi: ufs: ufs-qcom: Use device parameter initialization function https://git.kernel.org/mkp/scsi/c/8beef54716e6 [5/9] scsi: ufs: ufs-exynos: Use device parameter initialization function https://git.kernel.org/mkp/scsi/c/5b3573d68d9a [6/9] scsi: ufs: ufs-hisi: Use device parameter initialization function https://git.kernel.org/mkp/scsi/c/85d6d3c18953 [7/9] scsi: ufs: Refactor ADAPT configuration function https://git.kernel.org/mkp/scsi/c/fc85a74e28fe [8/9] scsi: ufs: ufs-mediatek: Use common ADAPT configuration function https://git.kernel.org/mkp/scsi/c/e1e25d1b8996 [9/9] scsi: ufs: ufs-qcom: Use common ADAPT configuration function https://git.kernel.org/mkp/scsi/c/d9fa1e731e24 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: ufs: Add retry flow for failed hba enabling
On Thu, 12 Nov 2020 13:45:37 +0800, Stanley Chu wrote: > Once hba enabling is failed, add retry mechanism and in the > meanwhile allow vendors to apply specific handlings before > the next retry. For example, vendors can do vendor-specific > host reset flow in variant function "ufshcd_vops_hce_enable_notify()". Applied to 5.11/scsi-queue, thanks! [1/1] scsi: ufs: Add retry flow for failed HBA enabling https://git.kernel.org/mkp/scsi/c/6081b12ceb7d -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: qla4xxx: Remove redundant assignment to variable rval
On Tue, 3 Nov 2020 20:01:37 +0800, Jing Xiangfeng wrote: > The variable rval has been initialized with 'QLA_ERROR'. The assignment > is redundant in an error path. So remove it. Applied to 5.11/scsi-queue, thanks! [1/1] scsi: qla4xxx: Remove redundant assignment to variable rval https://git.kernel.org/mkp/scsi/c/cf4d4d8ebdb8 -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH] scsi: core: fix -Wformat
On Sat, 7 Nov 2020 00:11:32 -0800, Nick Desaulniers wrote: > Clang is more aggressive about -Wformat warnings when the format flag > specifies a type smaller than the parameter. Turns out, struct > Scsi_Host's member can_queue is actually an int. Fixes: > > [-Wformat] > shost_rd_attr(can_queue, "%hd\n"); > ^ > %d Applied to 5.11/scsi-queue, thanks! [1/1] scsi: core: Fix -Wformat for scsi_host https://git.kernel.org/mkp/scsi/c/883928201b00 -- Martin K. Petersen Oracle Linux Engineering
