Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use
Hi, >> Mon, 15 Oct 2007 11:45:10 +0900 >> [Subject: Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use] >> Masahide NAKAMURA <[EMAIL PROTECTED]> wrote... > > On Sun, 14 Oct 2007 19:52:12 +0200 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > The Coverity checker spotted that we have already oops'ed if "dst" > > was NULL. > > > > Since "dst" being NULL doesn't seem to be possible at this point this > > patch removes the NULL check. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Agreed. > > Acked-by: Masahide NAKAMURA <[EMAIL PROTECTED]> I also agreed. Acked-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]> -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use
Hi, Mon, 15 Oct 2007 11:45:10 +0900 [Subject: Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use] Masahide NAKAMURA [EMAIL PROTECTED] wrote... On Sun, 14 Oct 2007 19:52:12 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: The Coverity checker spotted that we have already oops'ed if dst was NULL. Since dst being NULL doesn't seem to be possible at this point this patch removes the NULL check. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Agreed. Acked-by: Masahide NAKAMURA [EMAIL PROTECTED] I also agreed. Acked-by: Noriaki TAKAMIYA [EMAIL PROTECTED] -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: net-26.24 broken with XFRM off
Hi, >> Thu, 6 Sep 2007 10:13:26 +0200 >> [Subject: Re: net-26.24 broken with XFRM off] >> Eric Dumazet <[EMAIL PROTECTED]> wrote... > Hi Divy > > I believe this problem is known. > > Please check http://marc.info/?l=linux-netdev=118881627028135=2 I'm sorry not to check more precisely. As Eric said, this issue should be fixed by the patch attached in the following mail. Regards, >> Mon, 03 Sep 2007 19:43:51 +0900 >> [Subject: Re: [-mm patch] IPV6 must select XFRM] >> Masahide NAKAMURA <[EMAIL PROTECTED]> wrote... > Thank you for catching this. the issue is caused with patch > "[IPV6] XFRM: Fix connected socket to use transformation." > which I sent to netdev. > (a85d5450ddeb959bdf9e4603f9c06e9d79217cfa on net-2.6.24). > > I'd prefer to modify the original patch to use "ifdef CONFIG_XFRM" > than changing kernel config depends. Does it make sense? > > Please review the attached patch. > > -- > Masahide NAKAMURA -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: net-26.24 broken with XFRM off
Hi, Thu, 6 Sep 2007 10:13:26 +0200 [Subject: Re: net-26.24 broken with XFRM off] Eric Dumazet [EMAIL PROTECTED] wrote... Hi Divy I believe this problem is known. Please check http://marc.info/?l=linux-netdevm=118881627028135w=2 I'm sorry not to check more precisely. As Eric said, this issue should be fixed by the patch attached in the following mail. Regards, Mon, 03 Sep 2007 19:43:51 +0900 [Subject: Re: [-mm patch] IPV6 must select XFRM] Masahide NAKAMURA [EMAIL PROTECTED] wrote... Thank you for catching this. the issue is caused with patch [IPV6] XFRM: Fix connected socket to use transformation. which I sent to netdev. (a85d5450ddeb959bdf9e4603f9c06e9d79217cfa on net-2.6.24). I'd prefer to modify the original patch to use ifdef CONFIG_XFRM than changing kernel config depends. Does it make sense? Please review the attached patch. -- Masahide NAKAMURA -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32652) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
>> Tue, 27 Mar 2007 15:51:39 -0700 >> [Subject: (usagi-core 32652) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] >> [USB] fixed to skip NULL entry in struct serial usb_serial_port.] >> Greg KH <[EMAIL PROTECTED]> wrote... > > I think so. But I wonder if usb_get_serial_port_data() should check > > the argument for the other drivers. > > I don't think it is really necessary, do you? I see. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32652) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Tue, 27 Mar 2007 15:51:39 -0700 [Subject: (usagi-core 32652) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.] Greg KH [EMAIL PROTECTED] wrote... I think so. But I wonder if usb_get_serial_port_data() should check the argument for the other drivers. I don't think it is really necessary, do you? I see. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32640) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, >> Sun, 25 Mar 2007 08:55:21 -0700 >> [Subject: (usagi-core 32640) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] >> [USB] fixed to skip NULL entry in struct serial usb_serial_port.] >> Greg KH <[EMAIL PROTECTED]> wrote... > > Yes, this problem was already fixed. > > Great, thanks for testing. So I guess both of these patches are no > longer necessary, right? I think so. But I wonder if usb_get_serial_port_data() should check the argument for the other drivers. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32640) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, Sun, 25 Mar 2007 08:55:21 -0700 [Subject: (usagi-core 32640) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.] Greg KH [EMAIL PROTECTED] wrote... Yes, this problem was already fixed. Great, thanks for testing. So I guess both of these patches are no longer necessary, right? I think so. But I wonder if usb_get_serial_port_data() should check the argument for the other drivers. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32638) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, >> Sat, 24 Mar 2007 14:22:53 -0700 >> [Subject: (usagi-core 32638) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] >> [USB] fixed to skip NULL entry in struct serial usb_serial_port.] >> Greg KH <[EMAIL PROTECTED]> wrote... > This should already be fixed in the -git snapshots that have come out > after 2.6.21-rc4. Can you test them to verify this? Yes, this problem was already fixed. Thanks. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Hi,
While booting, this entry is set to NULL in destroy_serial(),
but serial->port is referred again in pl2303_shutdown() via
serial->type->shutdown.
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg("%s", __FUNCTION__);
for (i = 0; i < serial->num_ports; ++i) {
+ if (!serial->port[i])
+ continue;
priv = usb_get_serial_port_data(serial->port[i]);
if (priv) {
pl2303_buf_free(priv->buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Sorry for resending.
While booting, this entry is set to NULL in destroy_serial(),
but serial->port is referred again in pl2303_shutdown() via
serial->type->shutdown.
Signed-off-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]>
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg("%s", __FUNCTION__);
for (i = 0; i < serial->num_ports; ++i) {
+ if (!serial->port[i])
+ continue;
priv = usb_get_serial_port_data(serial->port[i]);
if (priv) {
pl2303_buf_free(priv->buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.
Hi,
This patch fixes to skip serial->port[i] if it is set NULL.
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
index 32acbae..85ed5ef 100644
--- a/include/linux/usb/serial.h
+++ b/include/linux/usb/serial.h
@@ -99,7 +99,10 @@ struct usb_serial_port {
/* get and set the port private data pointer helper functions */
static inline void *usb_get_serial_port_data (struct usb_serial_port *port)
{
- return dev_get_drvdata(>dev);
+ if (port)
+ return dev_get_drvdata(>dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Sorry for resending
Hi,
While booting, this entry is set to NULL in destroy_serial(),
but serial->port is referred again in pl2303_shutdown() via
serial->type->shutdown.
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg("%s", __FUNCTION__);
for (i = 0; i < serial->num_ports; ++i) {
+ if (!serial->port[i])
+ continue;
priv = usb_get_serial_port_data(serial->port[i]);
if (priv) {
pl2303_buf_free(priv->buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, When I boot using linux-2.6.21-rc4 on ThinkPad T41 with pl2303 USB serial device plugged in, the kernel crashes. The reason is struct usb_serial_port is referenced without checking whether it is NULL or not. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32634) [PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.
Sorry for resending.
Hi,
This patch fixes to skip serial->port[i] if it is set NULL.
Signed-off-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]>
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
index 32acbae..85ed5ef 100644
--- a/include/linux/usb/serial.h
+++ b/include/linux/usb/serial.h
@@ -99,7 +99,10 @@ struct usb_serial_port {
/* get and set the port private data pointer helper functions */
static inline void *usb_get_serial_port_data (struct usb_serial_port *port)
{
- return dev_get_drvdata(>dev);
+ if (port)
+ return dev_get_drvdata(>dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32634) [PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.
Sorry for resending.
Hi,
This patch fixes to skip serial-port[i] if it is set NULL.
Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED]
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
index 32acbae..85ed5ef 100644
--- a/include/linux/usb/serial.h
+++ b/include/linux/usb/serial.h
@@ -99,7 +99,10 @@ struct usb_serial_port {
/* get and set the port private data pointer helper functions */
static inline void *usb_get_serial_port_data (struct usb_serial_port *port)
{
- return dev_get_drvdata(port-dev);
+ if (port)
+ return dev_get_drvdata(port-dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, When I boot using linux-2.6.21-rc4 on ThinkPad T41 with pl2303 USB serial device plugged in, the kernel crashes. The reason is struct usb_serial_port is referenced without checking whether it is NULL or not. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Hi,
While booting, this entry is set to NULL in destroy_serial(),
but serial-port is referred again in pl2303_shutdown() via
serial-type-shutdown.
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg(%s, __FUNCTION__);
for (i = 0; i serial-num_ports; ++i) {
+ if (!serial-port[i])
+ continue;
priv = usb_get_serial_port_data(serial-port[i]);
if (priv) {
pl2303_buf_free(priv-buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Sorry for resending.
While booting, this entry is set to NULL in destroy_serial(),
but serial-port is referred again in pl2303_shutdown() via
serial-type-shutdown.
Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED]
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg(%s, __FUNCTION__);
for (i = 0; i serial-num_ports; ++i) {
+ if (!serial-port[i])
+ continue;
priv = usb_get_serial_port_data(serial-port[i]);
if (priv) {
pl2303_buf_free(priv-buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.
Hi,
This patch fixes to skip serial-port[i] if it is set NULL.
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
index 32acbae..85ed5ef 100644
--- a/include/linux/usb/serial.h
+++ b/include/linux/usb/serial.h
@@ -99,7 +99,10 @@ struct usb_serial_port {
/* get and set the port private data pointer helper functions */
static inline void *usb_get_serial_port_data (struct usb_serial_port *port)
{
- return dev_get_drvdata(port-dev);
+ if (port)
+ return dev_get_drvdata(port-dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Sorry for resending
Hi,
While booting, this entry is set to NULL in destroy_serial(),
but serial-port is referred again in pl2303_shutdown() via
serial-type-shutdown.
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg(%s, __FUNCTION__);
for (i = 0; i serial-num_ports; ++i) {
+ if (!serial-port[i])
+ continue;
priv = usb_get_serial_port_data(serial-port[i]);
if (priv) {
pl2303_buf_free(priv-buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32638) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, Sat, 24 Mar 2007 14:22:53 -0700 [Subject: (usagi-core 32638) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.] Greg KH [EMAIL PROTECTED] wrote... This should already be fixed in the -git snapshots that have come out after 2.6.21-rc4. Can you test them to verify this? Yes, this problem was already fixed. Thanks. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
