Re: [PATCH] LICENSES: Replace HTTP links with HTTPS ones

[Philippe Ombredanne]

Hi Alexander:

On Tue, Jul 21, 2020 at 4:50 PM Greg KH  wrote:
>
> On Mon, Jul 13, 2020 at 10:42:31AM +0200, Alexander A. Klimov wrote:
> > Rationale:
> > Reduces attack surface on kernel devs opening the links for MITM
> > as HTTPS traffic is much harder to manipulate.
> >
> > Deterministic algorithm:
> > For each file:
> >   If not .svg:
> > For each line:
> >   If doesn't contain `\bxmlns\b`:
> > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> > If both the HTTP and HTTPS versions
> > return 200 OK and serve the same content:
> >   Replace HTTP with HTTPS.
> >
> > Signed-off-by: Alexander A. Klimov 
> > ---
> >  Continuing my work started at 93431e0607e5.
> >  See also: git log --oneline '--author=Alexander A. Klimov 
> > ' v5.7..master
> >  (Actually letting a shell for loop submit all this stuff for me.)
> >
> >  If there are any URLs to be removed completely or at least not just 
> > HTTPSified:
> >  Just clearly say so and I'll *undo my change*.
> >  See also: https://lkml.org/lkml/2020/6/27/64
> >
> >  If there are any valid, but yet not changed URLs:
> >  See: https://lkml.org/lkml/2020/6/26/837
> >
> >  If you apply the patch, please let me know.
> >
> >  Sorry again to all maintainers who complained about subject lines.
> >  Now I realized that you want an actually perfect prefixes,
> >  not just subsystem ones.
> >  I tried my best...
> >  And yes, *I could* (at least half-)automate it.
> >  Impossible is nothing! :)
> >
> >
> >  LICENSES/dual/Apache-2.0 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/LICENSES/dual/Apache-2.0 b/LICENSES/dual/Apache-2.0
> > index 6e89ddeab187..fd71308fd2c3 100644
> > --- a/LICENSES/dual/Apache-2.0
> > +++ b/LICENSES/dual/Apache-2.0
> > @@ -15,7 +15,7 @@ Apache License
> >
> >  Version 2.0, January 2004
> >
> > -http://www.apache.org/licenses/
> > +https://www.apache.org/licenses/
> >
> >  TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
> >
> > --
> > 2.27.0
> >
>
> You can't change the text of a license that comes from elsewhere.  This
> file is fine as-is.

It is so fine that -FWIW- even the Apache folks toyed with the idea of
updating their license text to switch to HTTPS there and decided not
to [1] which is IMHO a sane thing.

[1] https://issues.apache.org/jira/browse/LEGAL-457
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2] module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity

[Philippe Ombredanne]

o clean up the
> license mess of the kernel.
>
> Therefore remove the well meant, but ill defined, distinction between "GPL"
> and "GPL v2" and document that:
>
>   - "GPL" and "GPL v2" both express that the module is licensed under GPLv2
> (without a distinction of 'only' and 'or later') and is therefore kernel
> license compliant.
>
>   - None of the MODULE_LICENSE strings can be used for expressing or
> determining the exact license
>
>   - Their sole purpose is to decide whether the module is free software or
> not.
>
> Add a MODULE_LICENSE subsection to the license rule documentation as well.
>
> Signed-off-by: Thomas Gleixner 
> Reviewed-by: Greg Kroah-Hartman 
> Acked-by: Philippe Ombredanne 
> Acked-by: Joe Perches 
>
> ---
>
> V2: Fixed the "GPL v2" hickup and the typo spotted by Jessica.
>
>  Documentation/process/license-rules.rst |   62 
> 
>  include/linux/module.h  |   18 -
>  2 files changed, 79 insertions(+), 1 deletion(-)
>
> --- a/Documentation/process/license-rules.rst
> +++ b/Documentation/process/license-rules.rst
> @@ -372,3 +372,65 @@ in the LICENSE subdirectories. This is r
>  verification (e.g. checkpatch.pl) and to have the licenses ready to read
>  and extract right from the source, which is recommended by various FOSS
>  organizations, e.g. the `FSFE REUSE initiative <https://reuse.software/>`_.
> +
> +_`MODULE_LICENSE`
> +-
> +
> +   Loadable kernel modules also require a MODULE_LICENSE() tag. This tag is
> +   neither a replacement for proper source code license information
> +   (SPDX-License-Identifier) nor in any way relevant for expressing or
> +   determining the exact license under which the source code of the module
> +   is provided.
> +
> +   The sole purpose of this tag is to provide sufficient information
> +   whether the module is free software or proprietary for the kernel
> +   module loader and for user space tools.
> +
> +   The valid license strings for MODULE_LICENSE() are:
> +
> += 
> =
> +"GPL"Module is licensed under GPL version 2. This
> + does not express any distinction between
> + GPL-2.0-only or GPL-2.0-or-later. The exact
> + license information can only be determined
> + via the license information in the
> + corresponding source files.
> +
> +"GPL v2" Same as "GPL". It exists for historic
> + reasons.
> +
> +"GPL and additional rights"   Historical variant of expressing that the
> + module source is dual licensed under a
> + GPL v2 variant and MIT license. Please do
> + not use in new code.
> +
> +"Dual MIT/GPL"   The correct way of expressing that the
> + module is dual licensed under a GPL v2
> + variant or MIT license choice.
> +
> +"Dual BSD/GPL"   The module is dual licensed under a GPL v2
> + variant or BSD license choice. The exact
> + variant of the BSD license can only be
> + determined via the license information
> + in the corresponding source files.
> +
> +"Dual MPL/GPL"   The module is dual licensed under a GPL v2
> + variant or Mozilla Public License (MPL)
> + choice. The exact variant of the MPL
> + license can only be determined via the
> + license information in the corresponding
> + source files.
> +
> +"Proprietary"The module is under a proprietary license.
> + This string is solely for proprietary third
> + party modules and cannot be used for modules
> + which have their source code in the kernel
> + tree. Modules tagged that way are tainting
> + the kernel with the 'P' flag when loaded and
> + the kernel module loader re

Re: [PATCH][RFC] module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity

[Philippe Ombredanne]

Thomas:
On Mon, Jan 28, 2019 at 11:39 PM Thomas Gleixner  wrote:
[...]
> As an unintended side effect this distinction causes a major headache for
> license compliance, license scanners and the ongoing effort to clean up the
> license mess of the kernel.

Glad to be of service and sorry for having helped a bit surface these!

>
> Therefore remove the well meant, but ill defined, distinction between "GPL"
> and "GPL v2" and document that:
>
>   - "GPL" and "GPL v2" both express that the module is licensed under GPLv2
> (without a distinction of 'only' and 'or later') and is therefore kernel
> license compliant.
>
>   - None of the MODULE_LICENSE strings can be used for expressing or
> determining the exact license
>
>   - Their sole purpose is to decide whether the module is free software or
> not.
>
> Add a MODULE_LICENSE subsection to the license rule documentation as well.
>
> Signed-off-by: Thomas Gleixner 


Thank you ++ for documenting all this : this is a small change but a big
step towards licensing clarity! Great that you found the commit that
introduced this too.

Feel free to add this if you want:
Acked-by: Philippe Ombredanne 

--
Cordially

Philippe Ombredanne

Re: [PATCH 2/3] ARM: tegra: apalis-tk1: Add SPDX license (GPL-2.0 OR X11) identifiers

[Philippe Ombredanne]

Hi Krzysztof,

On Wed, Jul 18, 2018 at 9:48 PM, Krzysztof Kozlowski  wrote:
> Three files dual-licensed were missing the SPDX license identifiers.
>
> Signed-off-by: Krzysztof Kozlowski 
> ---
>  arch/arm/boot/dts/tegra124-apalis-emc.dtsi | 38 
> +-
>  arch/arm/boot/dts/tegra124-apalis-eval.dts | 38 
> +-
>  arch/arm/boot/dts/tegra124-apalis.dtsi | 38 
> +-
>  3 files changed, 3 insertions(+), 111 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra124-apalis-emc.dtsi 
> b/arch/arm/boot/dts/tegra124-apalis-emc.dtsi
> index ca2c3a557895..cdbbb3562fb9 100644
> --- a/arch/arm/boot/dts/tegra124-apalis-emc.dtsi
> +++ b/arch/arm/boot/dts/tegra124-apalis-emc.dtsi
> @@ -1,42 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0 OR X11
>  /*
>   * Copyright 2016 Toradex AG
> - *
> - * This file is dual-licensed: you can use it either under the terms
> - * of the GPL or the X11 license, at your option. Note that this dual
> - * licensing only applies to this file, and not this project as a
> - * whole.

This is weirdly enough not what is called an X11 license [1] even
though it is named this way here... but this is an  MIT license [2]
with a small variation. (See below)

> - *
> - *  a) This file is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License
> - * version 2 as published by the Free Software Foundation.
> - *
> - * This file is distributed in the hope that it will be useful
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * Or, alternatively
> - *
> - *  b) Permission is hereby granted, free of charge, to any person
> - * obtaining a copy of this software and associated documentation
> - * files (the "Software"), to deal in the Software without
> - * restriction, including without limitation the rights to use
> - * copy, modify, merge, publish, distribute, sublicense, and/or
> - * sell copies of the Software, and to permit persons to whom the
> - * Software is furnished to do so, subject to the following
> - * conditions:
> - *
> - * The above copyright notice and this permission notice shall be
> - * included in all copies or substantial portions of the Software.
> - *
> - * THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND

The MIT standard text [2] has a few extra commas and states instead:

THE SOFTWARE IS PROVIDED "AS IS",

Here "AS IS" is omitted. I am not sure this is material but IMHO it
would be good to get Toradex signoff on this.

> - * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> - * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> - * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> - * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
> - * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> - * OTHER DEALINGS IN THE SOFTWARE.
>   */




With all this said, I think that your expression should be this
instead (and this applies to other places too):

SPDX-License-Identifier: GPL-2.0 OR MIT

[1]  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/other/X11?h=v4.18-rc5
[2]  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred/MIT?h=v4.18-rc5

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/3] ARM: tegra: apalis-tk1: Add SPDX license (GPL-2.0 OR X11) identifiers

[Philippe Ombredanne]

Hi Krzysztof,

On Wed, Jul 18, 2018 at 9:48 PM, Krzysztof Kozlowski  wrote:
> Three files dual-licensed were missing the SPDX license identifiers.
>
> Signed-off-by: Krzysztof Kozlowski 
> ---
>  arch/arm/boot/dts/tegra124-apalis-emc.dtsi | 38 
> +-
>  arch/arm/boot/dts/tegra124-apalis-eval.dts | 38 
> +-
>  arch/arm/boot/dts/tegra124-apalis.dtsi | 38 
> +-
>  3 files changed, 3 insertions(+), 111 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra124-apalis-emc.dtsi 
> b/arch/arm/boot/dts/tegra124-apalis-emc.dtsi
> index ca2c3a557895..cdbbb3562fb9 100644
> --- a/arch/arm/boot/dts/tegra124-apalis-emc.dtsi
> +++ b/arch/arm/boot/dts/tegra124-apalis-emc.dtsi
> @@ -1,42 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0 OR X11
>  /*
>   * Copyright 2016 Toradex AG
> - *
> - * This file is dual-licensed: you can use it either under the terms
> - * of the GPL or the X11 license, at your option. Note that this dual
> - * licensing only applies to this file, and not this project as a
> - * whole.

This is weirdly enough not what is called an X11 license [1] even
though it is named this way here... but this is an  MIT license [2]
with a small variation. (See below)

> - *
> - *  a) This file is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License
> - * version 2 as published by the Free Software Foundation.
> - *
> - * This file is distributed in the hope that it will be useful
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * Or, alternatively
> - *
> - *  b) Permission is hereby granted, free of charge, to any person
> - * obtaining a copy of this software and associated documentation
> - * files (the "Software"), to deal in the Software without
> - * restriction, including without limitation the rights to use
> - * copy, modify, merge, publish, distribute, sublicense, and/or
> - * sell copies of the Software, and to permit persons to whom the
> - * Software is furnished to do so, subject to the following
> - * conditions:
> - *
> - * The above copyright notice and this permission notice shall be
> - * included in all copies or substantial portions of the Software.
> - *
> - * THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND

The MIT standard text [2] has a few extra commas and states instead:

THE SOFTWARE IS PROVIDED "AS IS",

Here "AS IS" is omitted. I am not sure this is material but IMHO it
would be good to get Toradex signoff on this.

> - * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> - * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> - * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> - * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
> - * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> - * OTHER DEALINGS IN THE SOFTWARE.
>   */




With all this said, I think that your expression should be this
instead (and this applies to other places too):

SPDX-License-Identifier: GPL-2.0 OR MIT

[1]  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/other/X11?h=v4.18-rc5
[2]  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred/MIT?h=v4.18-rc5

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/4] clocksource: timer-imx-gpt: Switch to SPDX identifier

[Philippe Ombredanne]

Hi Daniel,

On Wed, May 23, 2018 at 10:06 AM, Daniel Lezcano
 wrote:
> On 23/05/2018 01:05, Fabio Estevam wrote:
>> From: Fabio Estevam 
>>
>> Adopt the SPDX license identifier headers to ease license compliance
>> management.
>>
>> Signed-off-by: Fabio Estevam 
>> ---
>>  drivers/clocksource/timer-imx-gpt.c | 26 ++
>>  1 file changed, 6 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/clocksource/timer-imx-gpt.c 
>> b/drivers/clocksource/timer-imx-gpt.c
>> index b63b834..165fbbb 100644
>> --- a/drivers/clocksource/timer-imx-gpt.c
>> +++ b/drivers/clocksource/timer-imx-gpt.c
>> @@ -1,23 +1,9 @@
>> -/*
>> - *  Copyright (C) 2000-2001 Deep Blue Solutions
>> - *  Copyright (C) 2002 Shane Nay (sh...@minirl.com)
>> - *  Copyright (C) 2006-2007 Pavel Pisa (pp...@pikron.com)
>> - *  Copyright (C) 2008 Juergen Beisert (ker...@pengutronix.de)
>> - *
>> - * This program is free software; you can redistribute it and/or
>> - * modify it under the terms of the GNU General Public License
>> - * as published by the Free Software Foundation; either version 2
>> - * of the License, or (at your option) any later version.
>> - * This program is distributed in the hope that it will be useful,
>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> - * GNU General Public License for more details.
>> - *
>> - * You should have received a copy of the GNU General Public License
>> - * along with this program; if not, write to the Free Software
>> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
>> - * MA 02110-1301, USA.
>> - */
>> +// SPDX-License-Identifier: GPL-2.0+
>> +//
>> +//  Copyright (C) 2000-2001 Deep Blue Solutions
>> +//  Copyright (C) 2002 Shane Nay (sh...@minirl.com)
>> +//  Copyright (C) 2006-2007 Pavel Pisa (pp...@pikron.com)
>> +//  Copyright (C) 2008 Juergen Beisert (ker...@pengutronix.de)
>
> Hi Philippe,
>
> I went through the code and didn't find any information about the format
> of the lines following the SPDX, it seems it is relatively free.
>
> Can you confirm the above changes are ok ?

This looks fine to me especially if this all you have in terms of top
level comment. (e.g. license then copyrights)
Some may not agree with me on using C++ style comments beyond the SPDX
license line though ;)
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/4] clocksource: timer-imx-gpt: Switch to SPDX identifier

[Philippe Ombredanne]

Hi Daniel,

On Wed, May 23, 2018 at 10:06 AM, Daniel Lezcano
 wrote:
> On 23/05/2018 01:05, Fabio Estevam wrote:
>> From: Fabio Estevam 
>>
>> Adopt the SPDX license identifier headers to ease license compliance
>> management.
>>
>> Signed-off-by: Fabio Estevam 
>> ---
>>  drivers/clocksource/timer-imx-gpt.c | 26 ++
>>  1 file changed, 6 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/clocksource/timer-imx-gpt.c 
>> b/drivers/clocksource/timer-imx-gpt.c
>> index b63b834..165fbbb 100644
>> --- a/drivers/clocksource/timer-imx-gpt.c
>> +++ b/drivers/clocksource/timer-imx-gpt.c
>> @@ -1,23 +1,9 @@
>> -/*
>> - *  Copyright (C) 2000-2001 Deep Blue Solutions
>> - *  Copyright (C) 2002 Shane Nay (sh...@minirl.com)
>> - *  Copyright (C) 2006-2007 Pavel Pisa (pp...@pikron.com)
>> - *  Copyright (C) 2008 Juergen Beisert (ker...@pengutronix.de)
>> - *
>> - * This program is free software; you can redistribute it and/or
>> - * modify it under the terms of the GNU General Public License
>> - * as published by the Free Software Foundation; either version 2
>> - * of the License, or (at your option) any later version.
>> - * This program is distributed in the hope that it will be useful,
>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> - * GNU General Public License for more details.
>> - *
>> - * You should have received a copy of the GNU General Public License
>> - * along with this program; if not, write to the Free Software
>> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
>> - * MA 02110-1301, USA.
>> - */
>> +// SPDX-License-Identifier: GPL-2.0+
>> +//
>> +//  Copyright (C) 2000-2001 Deep Blue Solutions
>> +//  Copyright (C) 2002 Shane Nay (sh...@minirl.com)
>> +//  Copyright (C) 2006-2007 Pavel Pisa (pp...@pikron.com)
>> +//  Copyright (C) 2008 Juergen Beisert (ker...@pengutronix.de)
>
> Hi Philippe,
>
> I went through the code and didn't find any information about the format
> of the lines following the SPDX, it seems it is relatively free.
>
> Can you confirm the above changes are ok ?

This looks fine to me especially if this all you have in terms of top
level comment. (e.g. license then copyrights)
Some may not agree with me on using C++ style comments beyond the SPDX
license line though ;)
-- 
Cordially
Philippe Ombredanne

Re: [patch V2 7/7] scripts: Add SPDX checker script

[Philippe Ombredanne]

Thomas,
Sorry for the very late reply!

On Wed, Apr 25, 2018 at 10:30 PM, Thomas Gleixner <t...@linutronix.de> wrote:
> The SPDX-License-Identifiers are growing in the kernel and so grow
> expression failures and license IDs are used which have no corresponding
> license text file in the LICENSES directory.
>
> Add a script which gathers information from the LICENSES directory,
> i.e. the various tags in the licenses and exception files and then scans
> either input from stdin, which it treats as a single file or if started
> without arguments it scans the full kernel tree.
>
> It checks whether the license expression syntax is correct and also
> validates whether the license identifiers used in the expressions are
> available in the LICENSES files.

Looking good to me! And the use of ply is sleek.
-- 
Cordially
Philippe Ombredanne

Re: [patch V2 7/7] scripts: Add SPDX checker script

[Philippe Ombredanne]

Thomas,
Sorry for the very late reply!

On Wed, Apr 25, 2018 at 10:30 PM, Thomas Gleixner  wrote:
> The SPDX-License-Identifiers are growing in the kernel and so grow
> expression failures and license IDs are used which have no corresponding
> license text file in the LICENSES directory.
>
> Add a script which gathers information from the LICENSES directory,
> i.e. the various tags in the licenses and exception files and then scans
> either input from stdin, which it treats as a single file or if started
> without arguments it scans the full kernel tree.
>
> It checks whether the license expression syntax is correct and also
> validates whether the license identifiers used in the expressions are
> available in the LICENSES files.

Looking good to me! And the use of ply is sleek.
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

[Philippe Ombredanne]

Tejun,

On Mon, Mar 19, 2018 at 7:41 AM, Tejun Heo <t...@kernel.org> wrote:
> Hello,
>
> On Sat, Mar 17, 2018 at 10:24:18PM -0700, Philippe Ombredanne wrote:
>> > v2:
>> > - clarify license version (it should be GPL 2.0)
>> > - use SPDX header
>>
>> For the use of SPDX ids, you have my ack: (I am not qualified for the rest)
>>
>> Acked-by: Philippe Ombredanne <pombreda...@nexb.com>
>
> I don't think it's a good idea to add this acked-by when it's purely
> based on a single liner license tag.  I understand that you want to
> encourage use of the new tags but this can be misleading and it'd be
> great if you reconsider sending out acks like this.
>
> Thanks.


You have a good point. I find it confusing myself.
Please, remove this ack!

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

[Philippe Ombredanne]

Tejun,

On Mon, Mar 19, 2018 at 7:41 AM, Tejun Heo  wrote:
> Hello,
>
> On Sat, Mar 17, 2018 at 10:24:18PM -0700, Philippe Ombredanne wrote:
>> > v2:
>> > - clarify license version (it should be GPL 2.0)
>> > - use SPDX header
>>
>> For the use of SPDX ids, you have my ack: (I am not qualified for the rest)
>>
>> Acked-by: Philippe Ombredanne 
>
> I don't think it's a good idea to add this acked-by when it's purely
> based on a single liner license tag.  I understand that you want to
> encourage use of the new tags but this can be misleading and it'd be
> great if you reconsider sending out acks like this.
>
> Thanks.


You have a good point. I find it confusing myself.
Please, remove this ack!

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

[Philippe Ombredanne]

Benjamin,

On Wed, Mar 21, 2018 at 12:32 AM, Benjamin Warnke
<4bwar...@informatik.uni-hamburg.de> wrote:
> Ok, I will use
>
> /* SPDX-License-Identifier: GPL-2.0 */
> /*
>  * Copyright (c) 2018 Benjamin Warnke <4bwar...@informatik.uni-hamburg.de>
> ...
>
> at the top of my files instead of that boilerplate text. And
>
> MODULE_LICENSE("GPL");
>
> at the bottom of the module-files.


>
> I used the file "crypto/lz4.c" - since it is a compression algorithm too - as 
> an example of how to format the licensing text.
> Unfortunately there is the same 'error'.
> I fixed this error in all of my files in all patches.

Actually to be consistent if you want to use GPL-2-0 (and not "or
later") you should use:

1. at the top, for a c. file:
// SPDX-License-Identifier: GPL-2.0

or for a .h file:
/* SPDX-License-Identifier: GPL-2.0 */

The doc explains it all. Including the comment style (a topic that has
been discussed also on list quite bit: Linus had the final word there)

2. and in your MODULE_LICENSE macro:

MODULE_LICENSE("GPL v2");

 because a MODULE_LICENSE("GPL"); would mean GPL-2.0+ (e.g. or any
later version) and this would not match your top level license tag.

I know this may seem confusing, but there is little hope we can change
the MODULE_LICENSE tags that are used by many external module loaders.
Comments in module.h explain it all.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

[Philippe Ombredanne]

Benjamin,

On Wed, Mar 21, 2018 at 12:32 AM, Benjamin Warnke
<4bwar...@informatik.uni-hamburg.de> wrote:
> Ok, I will use
>
> /* SPDX-License-Identifier: GPL-2.0 */
> /*
>  * Copyright (c) 2018 Benjamin Warnke <4bwar...@informatik.uni-hamburg.de>
> ...
>
> at the top of my files instead of that boilerplate text. And
>
> MODULE_LICENSE("GPL");
>
> at the bottom of the module-files.


>
> I used the file "crypto/lz4.c" - since it is a compression algorithm too - as 
> an example of how to format the licensing text.
> Unfortunately there is the same 'error'.
> I fixed this error in all of my files in all patches.

Actually to be consistent if you want to use GPL-2-0 (and not "or
later") you should use:

1. at the top, for a c. file:
// SPDX-License-Identifier: GPL-2.0

or for a .h file:
/* SPDX-License-Identifier: GPL-2.0 */

The doc explains it all. Including the comment style (a topic that has
been discussed also on list quite bit: Linus had the final word there)

2. and in your MODULE_LICENSE macro:

MODULE_LICENSE("GPL v2");

 because a MODULE_LICENSE("GPL"); would mean GPL-2.0+ (e.g. or any
later version) and this would not match your top level license tag.

I know this may seem confusing, but there is little hope we can change
the MODULE_LICENSE tags that are used by many external module loaders.
Comments in module.h explain it all.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

[Philippe Ombredanne]

Hi Benjamin,

On Tue, Mar 20, 2018 at 7:04 AM, Benjamin Warnke
<4bwar...@informatik.uni-hamburg.de> wrote:
> zBeWalgo is a completely new algorithm - Currently it is not published
> somewhere else right now, googleing it would not show up any results. The
> following section describes how the algorithm works.



> diff --git a/lib/zbewalgo/zbewalgo.c b/lib/zbewalgo/zbewalgo.c
> new file mode 100644
> index 0..ef922bc27
> --- /dev/null
> +++ b/lib/zbewalgo/zbewalgo.c
> @@ -0,0 +1,723 @@
> +/*
> + * Copyright (c) 2018 Benjamin Warnke <4bwar...@informatik.uni-hamburg.de>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published 
> by
> + * the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but 
> WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along 
> with
> + * this program.
> + *

Would you mind using SPDX ids [1] instead of this fine boilerplate
here and throughout your patches?



> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("zBeWalgo Compression Algorithm");

Here your MODULE_LICENSE does not match your top level license. See
module.h [2] for a description of values: GPL would mean "GNU Public
License v2 or later" whereas your top level license (best expressed
with SPDX) would mean GPL-2.0 and no other version. To avoid
confusion, you would need to state the same thing in the
MODULE_LICENSE and your SPDX tags.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

[Philippe Ombredanne]

Hi Benjamin,

On Tue, Mar 20, 2018 at 7:04 AM, Benjamin Warnke
<4bwar...@informatik.uni-hamburg.de> wrote:
> zBeWalgo is a completely new algorithm - Currently it is not published
> somewhere else right now, googleing it would not show up any results. The
> following section describes how the algorithm works.



> diff --git a/lib/zbewalgo/zbewalgo.c b/lib/zbewalgo/zbewalgo.c
> new file mode 100644
> index 0..ef922bc27
> --- /dev/null
> +++ b/lib/zbewalgo/zbewalgo.c
> @@ -0,0 +1,723 @@
> +/*
> + * Copyright (c) 2018 Benjamin Warnke <4bwar...@informatik.uni-hamburg.de>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published 
> by
> + * the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but 
> WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along 
> with
> + * this program.
> + *

Would you mind using SPDX ids [1] instead of this fine boilerplate
here and throughout your patches?



> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("zBeWalgo Compression Algorithm");

Here your MODULE_LICENSE does not match your top level license. See
module.h [2] for a description of values: GPL would mean "GNU Public
License v2 or later" whereas your top level license (best expressed
with SPDX) would mean GPL-2.0 and no other version. To avoid
confusion, you would need to state the same thing in the
MODULE_LICENSE and your SPDX tags.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

[Philippe Ombredanne]

On Fri, Mar 16, 2018 at 9:15 AM, Bartlomiej Zolnierkiewicz
<b.zolnier...@samsung.com> wrote:
> Add Amiga Gayle PATA controller driver. It enables libata support
> for the on-board IDE interfaces on some Amiga models (A600, A1200,
> A4000 and A4000T) and also for IDE interfaces on the Zorro expansion
> bus (M-Tech E-Matrix 530 expansion card).
>
> Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help
> with testing the driver.
>
> Tested-by: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de>
> Cc: Michael Schmitz <schmitz...@gmail.com>
> Cc: Geert Uytterhoeven <ge...@linux-m68k.org>
> Cc: Philippe Ombredanne <pombreda...@nexb.com>
> Cc: Andy Shevchenko <andy.shevche...@gmail.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
> ---
> v3:
> - fix minor issues reported by Andy
>
> v2:
> - clarify license version (it should be GPL 2.0)
> - use SPDX header

For the use of SPDX ids, you have my ack: (I am not qualified for the rest)

Acked-by: Philippe Ombredanne <pombreda...@nexb.com>

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

[Philippe Ombredanne]

On Fri, Mar 16, 2018 at 9:15 AM, Bartlomiej Zolnierkiewicz
 wrote:
> Add Amiga Gayle PATA controller driver. It enables libata support
> for the on-board IDE interfaces on some Amiga models (A600, A1200,
> A4000 and A4000T) and also for IDE interfaces on the Zorro expansion
> bus (M-Tech E-Matrix 530 expansion card).
>
> Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help
> with testing the driver.
>
> Tested-by: John Paul Adrian Glaubitz 
> Cc: Michael Schmitz 
> Cc: Geert Uytterhoeven 
> Cc: Philippe Ombredanne 
> Cc: Andy Shevchenko 
> Signed-off-by: Bartlomiej Zolnierkiewicz 
> ---
> v3:
> - fix minor issues reported by Andy
>
> v2:
> - clarify license version (it should be GPL 2.0)
> - use SPDX header

For the use of SPDX ids, you have my ack: (I am not qualified for the rest)

Acked-by: Philippe Ombredanne 

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

[Philippe Ombredanne]

Miroslav,

On Tue, Feb 27, 2018 at 3:54 AM, Miroslav Benes <mbe...@suse.cz> wrote:
> On Sat, 24 Feb 2018, Philippe Ombredanne wrote:
>
>> Joe,
>>
>> On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence <joe.lawre...@redhat.com> 
>> wrote:
>> > Add a simple atomic replace / cumulative livepatch example.
>> >
>> > Signed-off-by: Joe Lawrence <joe.lawre...@redhat.com>
>> > ---
>> >  samples/livepatch/Makefile   |   1 +
>> >  samples/livepatch/livepatch-cumulative.c | 216 
>> > +++
>> >  2 files changed, 217 insertions(+)
>> >  create mode 100644 samples/livepatch/livepatch-cumulative.c
>> >
>> > diff --git a/samples/livepatch/Makefile b/samples/livepatch/Makefile
>> > index 2472ce39a18d..dd0e2a8af1af 100644
>> > --- a/samples/livepatch/Makefile
>> > +++ b/samples/livepatch/Makefile
>> > @@ -5,3 +5,4 @@ obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-fix2.o
>> >  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-demo.o
>> >  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-mod.o
>> >  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-busymod.o
>> > +obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-cumulative.o
>> > diff --git a/samples/livepatch/livepatch-cumulative.c 
>> > b/samples/livepatch/livepatch-cumulative.c
>> > new file mode 100644
>> > index ..ab036439e08c
>> > --- /dev/null
>> > +++ b/samples/livepatch/livepatch-cumulative.c
>> > @@ -0,0 +1,216 @@
>> > +/*
>> > + * Copyright (C) 2018 Joe Lawrence <joe.lawre...@redhat.com>
>> > + *
>> > + * This program is free software; you can redistribute it and/or
>> > + * modify it under the terms of the GNU General Public License
>> > + * as published by the Free Software Foundation; either version 2
>> > + * of the License, or (at your option) any later version.
>> > + *
>> > + * This program is distributed in the hope that it will be useful,
>> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> > + * GNU General Public License for more details.
>> > + *
>> > + * You should have received a copy of the GNU General Public License
>> > + * along with this program; if not, see <http://www.gnu.org/licenses/>.
>> > + */
>>
>> May be you could use the new SPDX tags instead of this fine but long
>> legalese? [1]
>> This would replace ~12 lines of comment by a single line with the same 
>> effect.
>> Thanks!
>
> I don't know about that. How come it is perceived as equivalent? I mean,
> we have a well-established way how to say that a particular source
> code/file is distributed with GPL license. Well-established means that
> it's been tested in court AFAIK many times. Even the license itself (found
> in COPYING file) mentions this as way how to attach the license to a file.
>
> Now you want it to be replaced with a tag. Does it say the same? It might.
> It might not. Do we know? Have you got a court ruling which would say that
> this is also a way how to attach a license to a file? I doubt it. It may
> seem trivially clear, but there are no such things in the legal world.
>
> Don't make me wrong. I don't like that copyright thingie much. I don't
> like that you can find even different versions of the text in the kernel
> source code (and not only there).
>
> However I'd prefer to leave at least a note there that the file is still
> distributed under the terms of GPL found in COPYING file. The tag can be
> there too, if it makes someone happy.
>
> Regards,
> Miroslav
>
>> [1]  
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
>> --
>> Philippe
>>
>

To the best of my knowledge, this has been debated in person and on
list among maintainers and agreed to.
This has also been reviewed by the LF lawyers. The result of is the
documentation in [1]
You are welcomed not to agree of course, but this would make your
contributions stand out with its legalese boilerplate when we are
trying to get of it.

Greg, anything else to add?

CC: Greg Kroah-Hartman <gre...@linuxfoundation.org>
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

[Philippe Ombredanne]

Miroslav,

On Tue, Feb 27, 2018 at 3:54 AM, Miroslav Benes  wrote:
> On Sat, 24 Feb 2018, Philippe Ombredanne wrote:
>
>> Joe,
>>
>> On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence  
>> wrote:
>> > Add a simple atomic replace / cumulative livepatch example.
>> >
>> > Signed-off-by: Joe Lawrence 
>> > ---
>> >  samples/livepatch/Makefile   |   1 +
>> >  samples/livepatch/livepatch-cumulative.c | 216 
>> > +++
>> >  2 files changed, 217 insertions(+)
>> >  create mode 100644 samples/livepatch/livepatch-cumulative.c
>> >
>> > diff --git a/samples/livepatch/Makefile b/samples/livepatch/Makefile
>> > index 2472ce39a18d..dd0e2a8af1af 100644
>> > --- a/samples/livepatch/Makefile
>> > +++ b/samples/livepatch/Makefile
>> > @@ -5,3 +5,4 @@ obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-fix2.o
>> >  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-demo.o
>> >  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-mod.o
>> >  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-busymod.o
>> > +obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-cumulative.o
>> > diff --git a/samples/livepatch/livepatch-cumulative.c 
>> > b/samples/livepatch/livepatch-cumulative.c
>> > new file mode 100644
>> > index ..ab036439e08c
>> > --- /dev/null
>> > +++ b/samples/livepatch/livepatch-cumulative.c
>> > @@ -0,0 +1,216 @@
>> > +/*
>> > + * Copyright (C) 2018 Joe Lawrence 
>> > + *
>> > + * This program is free software; you can redistribute it and/or
>> > + * modify it under the terms of the GNU General Public License
>> > + * as published by the Free Software Foundation; either version 2
>> > + * of the License, or (at your option) any later version.
>> > + *
>> > + * This program is distributed in the hope that it will be useful,
>> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> > + * GNU General Public License for more details.
>> > + *
>> > + * You should have received a copy of the GNU General Public License
>> > + * along with this program; if not, see <http://www.gnu.org/licenses/>.
>> > + */
>>
>> May be you could use the new SPDX tags instead of this fine but long
>> legalese? [1]
>> This would replace ~12 lines of comment by a single line with the same 
>> effect.
>> Thanks!
>
> I don't know about that. How come it is perceived as equivalent? I mean,
> we have a well-established way how to say that a particular source
> code/file is distributed with GPL license. Well-established means that
> it's been tested in court AFAIK many times. Even the license itself (found
> in COPYING file) mentions this as way how to attach the license to a file.
>
> Now you want it to be replaced with a tag. Does it say the same? It might.
> It might not. Do we know? Have you got a court ruling which would say that
> this is also a way how to attach a license to a file? I doubt it. It may
> seem trivially clear, but there are no such things in the legal world.
>
> Don't make me wrong. I don't like that copyright thingie much. I don't
> like that you can find even different versions of the text in the kernel
> source code (and not only there).
>
> However I'd prefer to leave at least a note there that the file is still
> distributed under the terms of GPL found in COPYING file. The tag can be
> there too, if it makes someone happy.
>
> Regards,
> Miroslav
>
>> [1]  
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
>> --
>> Philippe
>>
>

To the best of my knowledge, this has been debated in person and on
list among maintainers and agreed to.
This has also been reviewed by the LF lawyers. The result of is the
documentation in [1]
You are welcomed not to agree of course, but this would make your
contributions stand out with its legalese boilerplate when we are
trying to get of it.

Greg, anything else to add?

CC: Greg Kroah-Hartman 
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v6 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI

[Philippe Ombredanne]

Sudeep,

On Fri, Feb 23, 2018 at 8:23 AM, Sudeep Holla <sudeep.ho...@arm.com> wrote:
> The SCMI is intended to allow OSPM to manage various functions that are
> provided by the hardware platform it is running on, including power and
> performance functions. SCMI provides two levels of abstraction, protocols
> and transports. Protocols define individual groups of system control and
> management messages. A protocol specification describes the messages
> that it supports. Transports describe the method by which protocol
> messages are communicated between agents and the platform.
>
> This patch adds basic infrastructure to manage the message allocation,
> initialisation, packing/unpacking and shared memory management.
>
> Cc: Arnd Bergmann <a...@arndb.de>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Signed-off-by: Sudeep Holla <sudeep.ho...@arm.com>




> --- /dev/null
> +++ b/drivers/firmware/arm_scmi/common.h
> @@ -0,0 +1,77 @@
> +/*
> + * System Control and Management Interface (SCMI) Message Protocol
> + * driver common header file containing some definitions, structures
> + * and function prototypes used in all the different SCMI protocols.
> + *
> + * Copyright (C) 2017 ARM Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program. If not, see <http://www.gnu.org/licenses/>.
> + */

Would you consider using the SPDX tags [1] instead of this legalese?
Thanks!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v6 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI

[Philippe Ombredanne]

Sudeep,

On Fri, Feb 23, 2018 at 8:23 AM, Sudeep Holla  wrote:
> The SCMI is intended to allow OSPM to manage various functions that are
> provided by the hardware platform it is running on, including power and
> performance functions. SCMI provides two levels of abstraction, protocols
> and transports. Protocols define individual groups of system control and
> management messages. A protocol specification describes the messages
> that it supports. Transports describe the method by which protocol
> messages are communicated between agents and the platform.
>
> This patch adds basic infrastructure to manage the message allocation,
> initialisation, packing/unpacking and shared memory management.
>
> Cc: Arnd Bergmann 
> Cc: Greg Kroah-Hartman 
> Signed-off-by: Sudeep Holla 




> --- /dev/null
> +++ b/drivers/firmware/arm_scmi/common.h
> @@ -0,0 +1,77 @@
> +/*
> + * System Control and Management Interface (SCMI) Message Protocol
> + * driver common header file containing some definitions, structures
> + * and function prototypes used in all the different SCMI protocols.
> + *
> + * Copyright (C) 2017 ARM Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program. If not, see <http://www.gnu.org/licenses/>.
> + */

Would you consider using the SPDX tags [1] instead of this legalese?
Thanks!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

[Philippe Ombredanne]

Joe,

On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence  wrote:
> Add a simple atomic replace / cumulative livepatch example.
>
> Signed-off-by: Joe Lawrence 
> ---
>  samples/livepatch/Makefile   |   1 +
>  samples/livepatch/livepatch-cumulative.c | 216 
> +++
>  2 files changed, 217 insertions(+)
>  create mode 100644 samples/livepatch/livepatch-cumulative.c
>
> diff --git a/samples/livepatch/Makefile b/samples/livepatch/Makefile
> index 2472ce39a18d..dd0e2a8af1af 100644
> --- a/samples/livepatch/Makefile
> +++ b/samples/livepatch/Makefile
> @@ -5,3 +5,4 @@ obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-fix2.o
>  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-demo.o
>  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-mod.o
>  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-busymod.o
> +obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-cumulative.o
> diff --git a/samples/livepatch/livepatch-cumulative.c 
> b/samples/livepatch/livepatch-cumulative.c
> new file mode 100644
> index ..ab036439e08c
> --- /dev/null
> +++ b/samples/livepatch/livepatch-cumulative.c
> @@ -0,0 +1,216 @@
> +/*
> + * Copyright (C) 2018 Joe Lawrence 
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version 2
> + * of the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, see .
> + */

May be you could use the new SPDX tags instead of this fine but long
legalese? [1]
This would replace ~12 lines of comment by a single line with the same effect.
Thanks!

[1]  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
--
Philippe

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

[Philippe Ombredanne]

Joe,

On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence  wrote:
> Add a simple atomic replace / cumulative livepatch example.
>
> Signed-off-by: Joe Lawrence 
> ---
>  samples/livepatch/Makefile   |   1 +
>  samples/livepatch/livepatch-cumulative.c | 216 
> +++
>  2 files changed, 217 insertions(+)
>  create mode 100644 samples/livepatch/livepatch-cumulative.c
>
> diff --git a/samples/livepatch/Makefile b/samples/livepatch/Makefile
> index 2472ce39a18d..dd0e2a8af1af 100644
> --- a/samples/livepatch/Makefile
> +++ b/samples/livepatch/Makefile
> @@ -5,3 +5,4 @@ obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-fix2.o
>  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-demo.o
>  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-mod.o
>  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-busymod.o
> +obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-cumulative.o
> diff --git a/samples/livepatch/livepatch-cumulative.c 
> b/samples/livepatch/livepatch-cumulative.c
> new file mode 100644
> index ..ab036439e08c
> --- /dev/null
> +++ b/samples/livepatch/livepatch-cumulative.c
> @@ -0,0 +1,216 @@
> +/*
> + * Copyright (C) 2018 Joe Lawrence 
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version 2
> + * of the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, see .
> + */

May be you could use the new SPDX tags instead of this fine but long
legalese? [1]
This would replace ~12 lines of comment by a single line with the same effect.
Thanks!

[1]  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
--
Philippe

Re: [PATCH 08/10] gpio: Add gpio driver for Actions OWL S900 SoC

[Philippe Ombredanne]

Manivannan,

On Sat, Feb 17, 2018 at 9:44 PM, Manivannan Sadhasivam
<manivannan.sadhasi...@linaro.org> wrote:
> Add gpio driver for Actions Semi OWL family S900 SoC. Set of registers
> controlling the gpio shares the same register range with pinctrl block.
>
> GPIO registers are organized as 6 banks and each bank controls the
> maximum of 32 gpios.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org>



> --- /dev/null
> +++ b/drivers/gpio/gpio-owl.c
> @@ -0,0 +1,258 @@
> +// SPDX-License-Identifier: GPL-2.0+



> +MODULE_LICENSE("GPL v2");

Please sync this with your SPDX id above. nodule.h has the doc on the
meaning of MODULE_LICENSE macros.
Here you have stated a combo of GPL-2.0 and GPL-2.0 or later

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 08/10] gpio: Add gpio driver for Actions OWL S900 SoC

[Philippe Ombredanne]

Manivannan,

On Sat, Feb 17, 2018 at 9:44 PM, Manivannan Sadhasivam
 wrote:
> Add gpio driver for Actions Semi OWL family S900 SoC. Set of registers
> controlling the gpio shares the same register range with pinctrl block.
>
> GPIO registers are organized as 6 banks and each bank controls the
> maximum of 32 gpios.
>
> Signed-off-by: Manivannan Sadhasivam 



> --- /dev/null
> +++ b/drivers/gpio/gpio-owl.c
> @@ -0,0 +1,258 @@
> +// SPDX-License-Identifier: GPL-2.0+



> +MODULE_LICENSE("GPL v2");

Please sync this with your SPDX id above. nodule.h has the doc on the
meaning of MODULE_LICENSE macros.
Here you have stated a combo of GPL-2.0 and GPL-2.0 or later

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 04/10] pinctrl: actions: Add Actions S900 pinctrl driver

[Philippe Ombredanne]

Dear Manivannan,

On Sat, Feb 17, 2018 at 9:44 PM, Manivannan Sadhasivam
<manivannan.sadhasi...@linaro.org> wrote:
> Add pinctrl driver for Actions Semi S900 SoC. The driver supports
> pinctrl, pinmux and pinconf functionalities through a range of registers
> common to both gpio driver and pinctrl driver.
>
> Pinmux functionality is available only for the pin groups while the
> pinconf functionality is available for both pin groups and individual
> pins.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org>





> --- /dev/null
> +++ b/drivers/pinctrl/actions/pinctrl-s900.c
> @@ -0,0 +1,2536 @@
> +// SPDX-License-Identifier: GPL-2.0+



> +MODULE_LICENSE("GPL v2");

This does not match your license above. Per module.h "GPL v2" means
GPL-2.0 where you license above GPL-2.0+ means or later

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 04/10] pinctrl: actions: Add Actions S900 pinctrl driver

[Philippe Ombredanne]

Dear Manivannan,

On Sat, Feb 17, 2018 at 9:44 PM, Manivannan Sadhasivam
 wrote:
> Add pinctrl driver for Actions Semi S900 SoC. The driver supports
> pinctrl, pinmux and pinconf functionalities through a range of registers
> common to both gpio driver and pinctrl driver.
>
> Pinmux functionality is available only for the pin groups while the
> pinconf functionality is available for both pin groups and individual
> pins.
>
> Signed-off-by: Manivannan Sadhasivam 





> --- /dev/null
> +++ b/drivers/pinctrl/actions/pinctrl-s900.c
> @@ -0,0 +1,2536 @@
> +// SPDX-License-Identifier: GPL-2.0+



> +MODULE_LICENSE("GPL v2");

This does not match your license above. Per module.h "GPL v2" means
GPL-2.0 where you license above GPL-2.0+ means or later

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

[Philippe Ombredanne]

Hi Moritz,

On Fri, Feb 16, 2018 at 6:00 PM, Moritz Fischer <m...@kernel.org> wrote:
> Add support for the National Instruments XGE 1/10G network device.
>
> It uses the EEPROM on the board via NVMEM.
>
> Signed-off-by: Moritz Fischer <m...@kernel.org>



> --- /dev/null
> +++ b/drivers/net/ethernet/ni/nixge.c
> @@ -0,0 +1,1352 @@
> +// SPDX-License-Identifier: GPL-2.0



> +MODULE_LICENSE("GPL");

This does not match your license above. Per module.h "GPL" would mean "GPL-2.0+"
Can you use one or the other an\d ensure both of these are in sync?

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

[Philippe Ombredanne]

Hi Moritz,

On Fri, Feb 16, 2018 at 6:00 PM, Moritz Fischer  wrote:
> Add support for the National Instruments XGE 1/10G network device.
>
> It uses the EEPROM on the board via NVMEM.
>
> Signed-off-by: Moritz Fischer 



> --- /dev/null
> +++ b/drivers/net/ethernet/ni/nixge.c
> @@ -0,0 +1,1352 @@
> +// SPDX-License-Identifier: GPL-2.0



> +MODULE_LICENSE("GPL");

This does not match your license above. Per module.h "GPL" would mean "GPL-2.0+"
Can you use one or the other an\d ensure both of these are in sync?

-- 
Cordially
Philippe Ombredanne

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

[Philippe Ombredanne]

On Sun, Feb 18, 2018 at 9:18 PM, Joe Perches <j...@perches.com> wrote:
> On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote:
>> Hi Philippe,
>>
>> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne
>> <pombreda...@nexb.com> wrote:
>> > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
>> > <miguel.ojeda.sando...@gmail.com> wrote:
>> > > Cc: Willy Tarreau <w...@1wt.eu>
>> > > Cc: Geert Uytterhoeven <ge...@linux-m68k.org>
>> > > Cc: Linus Walleij <tr...@df.lth.se>
>> > > Cc: Robin van der Gracht <ro...@protonic.nl>
>> > > Cc: Paul Burton <paul.bur...@mips.com>
>> > > Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com>
>> > > ---
>> >
>> > 
>> >
>> > > diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h
>> > > index b454dfce60d9..aa960efc32f6 100644
>> > > --- a/include/linux/cfag12864b.h
>> > > +++ b/include/linux/cfag12864b.h
>> > > @@ -1,25 +1,11 @@
>> > > +// SPDX-License-Identifier: GPL-2.0
>> >
>> > Per the doc [1] you should be using instead this in a .h:
>> > /* SPDX-License-Identifier: GPL-2.0 */
>> >
>> > I know this can be surprising. This has been discussed on list quite
>> > lot and the doc has some rationale.
>> >
>> > 
>> >
>> > > diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h
>> > > index cb311798e0bc..2a1c985fedea 100644
>> > > --- a/include/linux/ks0108.h
>> > > +++ b/include/linux/ks0108.h
>> > > @@ -1,25 +1,11 @@
>> > > +// SPDX-License-Identifier: GPL-2.0
>> >
>> > Same comment as above.
>> >
>> > [1] 
>> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
>> >
>>
>> Obviously we need a check in scripts/checkpatch.pl, to catch this
>> before submission...
>>
>> Care to send a patch?
>
> There's one already in progress.
> https://lkml.org/lkml/2018/2/8/712
>


And I will try to help there as much as I can. Time to dust off my Perl!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

[Philippe Ombredanne]

On Sun, Feb 18, 2018 at 9:18 PM, Joe Perches  wrote:
> On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote:
>> Hi Philippe,
>>
>> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne
>>  wrote:
>> > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
>> >  wrote:
>> > > Cc: Willy Tarreau 
>> > > Cc: Geert Uytterhoeven 
>> > > Cc: Linus Walleij 
>> > > Cc: Robin van der Gracht 
>> > > Cc: Paul Burton 
>> > > Signed-off-by: Miguel Ojeda 
>> > > ---
>> >
>> > 
>> >
>> > > diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h
>> > > index b454dfce60d9..aa960efc32f6 100644
>> > > --- a/include/linux/cfag12864b.h
>> > > +++ b/include/linux/cfag12864b.h
>> > > @@ -1,25 +1,11 @@
>> > > +// SPDX-License-Identifier: GPL-2.0
>> >
>> > Per the doc [1] you should be using instead this in a .h:
>> > /* SPDX-License-Identifier: GPL-2.0 */
>> >
>> > I know this can be surprising. This has been discussed on list quite
>> > lot and the doc has some rationale.
>> >
>> > 
>> >
>> > > diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h
>> > > index cb311798e0bc..2a1c985fedea 100644
>> > > --- a/include/linux/ks0108.h
>> > > +++ b/include/linux/ks0108.h
>> > > @@ -1,25 +1,11 @@
>> > > +// SPDX-License-Identifier: GPL-2.0
>> >
>> > Same comment as above.
>> >
>> > [1] 
>> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
>> >
>>
>> Obviously we need a check in scripts/checkpatch.pl, to catch this
>> before submission...
>>
>> Care to send a patch?
>
> There's one already in progress.
> https://lkml.org/lkml/2018/2/8/712
>


And I will try to help there as much as I can. Time to dust off my Perl!
-- 
Cordially
Philippe Ombredanne

Re: [RFCv4 09/21] v4l2: add request API support

[Philippe Ombredanne]

On Tue, Feb 20, 2018 at 5:44 AM, Alexandre Courbot
<acour...@chromium.org> wrote:
> Add a v4l2 request entity data structure that takes care of storing the
> request-related state of a V4L2 device ; in this case, its controls.
>
> Signed-off-by: Alexandre Courbot <acour...@chromium.org>



> --- /dev/null
> +++ b/drivers/media/v4l2-core/v4l2-request.c
> @@ -0,0 +1,178 @@
> +/*
> + * Media requests support for V4L2
> + *
> + * Copyright (C) 2018, The Chromium OS Authors.  All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

Do you mind using SPDX tags per [1] rather that this fine but long
legalese. (Here and in the whole patch series)

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [RFCv4 09/21] v4l2: add request API support

[Philippe Ombredanne]

On Tue, Feb 20, 2018 at 5:44 AM, Alexandre Courbot
 wrote:
> Add a v4l2 request entity data structure that takes care of storing the
> request-related state of a V4L2 device ; in this case, its controls.
>
> Signed-off-by: Alexandre Courbot 



> --- /dev/null
> +++ b/drivers/media/v4l2-core/v4l2-request.c
> @@ -0,0 +1,178 @@
> +/*
> + * Media requests support for V4L2
> + *
> + * Copyright (C) 2018, The Chromium OS Authors.  All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

Do you mind using SPDX tags per [1] rather that this fine but long
legalese. (Here and in the whole patch series)

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v7 15/61] xarray: Add xa_load

[Philippe Ombredanne]

Matthew,

On Mon, Feb 19, 2018 at 8:45 PM, Matthew Wilcox <wi...@infradead.org> wrote:
> From: Matthew Wilcox <mawil...@microsoft.com>
>
> This first function in the XArray API brings with it a lot of support
> infrastructure.  The advanced API is based around the xa_state which is
> a more capable version of the radix_tree_iter.
>
> As the test-suite demonstrates, it is possible to use the xarray and
> radix tree APIs on the same data structure.
>
> Signed-off-by: Matthew Wilcox <mawil...@microsoft.com>




> --- /dev/null
> +++ b/tools/testing/radix-tree/xarray-test.c
> @@ -0,0 +1,56 @@
> +/*
> + * xarray-test.c: Test the XArray API
> + * Copyright (c) 2017 Microsoft Corporation <mawil...@microsoft.com>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + */

Do you mind using SPDX tags per [1] rather that this fine but long legalese?
Unless you are a legalese lover of course.

You will also get bonus karma points if you can spread the word within
your group!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v7 15/61] xarray: Add xa_load

[Philippe Ombredanne]

Matthew,

On Mon, Feb 19, 2018 at 8:45 PM, Matthew Wilcox  wrote:
> From: Matthew Wilcox 
>
> This first function in the XArray API brings with it a lot of support
> infrastructure.  The advanced API is based around the xa_state which is
> a more capable version of the radix_tree_iter.
>
> As the test-suite demonstrates, it is possible to use the xarray and
> radix tree APIs on the same data structure.
>
> Signed-off-by: Matthew Wilcox 




> --- /dev/null
> +++ b/tools/testing/radix-tree/xarray-test.c
> @@ -0,0 +1,56 @@
> +/*
> + * xarray-test.c: Test the XArray API
> + * Copyright (c) 2017 Microsoft Corporation 
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + */

Do you mind using SPDX tags per [1] rather that this fine but long legalese?
Unless you are a legalese lover of course.

You will also get bonus karma points if you can spread the word within
your group!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [v3,04/11] watchdog/hpwdt: white space changes

[Philippe Ombredanne]

Jerry,

On Sat, Feb 17, 2018 at 5:17 PM, Guenter Roeck <li...@roeck-us.net> wrote:
> On Thu, Feb 15, 2018 at 04:43:53PM -0700, Jerry Hoemann wrote:
>> Minor white space changes and some name clean up.
>>
>> Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com>
>> ---
>>  drivers/watchdog/hpwdt.c | 49 
>> +++-
>>  1 file changed, 23 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
>> index 07810caabf74..d5989acf3e37 100644
>> --- a/drivers/watchdog/hpwdt.c
>> +++ b/drivers/watchdog/hpwdt.c
>> @@ -1,11 +1,9 @@
>>  /*
>>   *   HPE WatchDog Driver
>> - *   based on
>>   *
>> - *   SoftDog 0.05:   A Software Watchdog Device
>> - *
>> - *   (c) Copyright 2015 Hewlett Packard Enterprise Development LP
>> + *   (c) Copyright 2018 Hewlett Packard Enterprise Development LP
>>   *   Thomas Mingarelli <thomas.mingare...@hpe.com>
>> + *   Jerry Hoemann <jerry.hoem...@hpe.com>
>>   *
>>   *   This program is free software; you can redistribute it and/or
>>   *   modify it under the terms of the GNU General Public License

It would be awesome if you could adopt SPDX ids here and in all HPE
existing and future contributions [1] rather than this fine legalese.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [v3,04/11] watchdog/hpwdt: white space changes

[Philippe Ombredanne]

Jerry,

On Sat, Feb 17, 2018 at 5:17 PM, Guenter Roeck  wrote:
> On Thu, Feb 15, 2018 at 04:43:53PM -0700, Jerry Hoemann wrote:
>> Minor white space changes and some name clean up.
>>
>> Signed-off-by: Jerry Hoemann 
>> ---
>>  drivers/watchdog/hpwdt.c | 49 
>> +++-
>>  1 file changed, 23 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
>> index 07810caabf74..d5989acf3e37 100644
>> --- a/drivers/watchdog/hpwdt.c
>> +++ b/drivers/watchdog/hpwdt.c
>> @@ -1,11 +1,9 @@
>>  /*
>>   *   HPE WatchDog Driver
>> - *   based on
>>   *
>> - *   SoftDog 0.05:   A Software Watchdog Device
>> - *
>> - *   (c) Copyright 2015 Hewlett Packard Enterprise Development LP
>> + *   (c) Copyright 2018 Hewlett Packard Enterprise Development LP
>>   *   Thomas Mingarelli 
>> + *   Jerry Hoemann 
>>   *
>>   *   This program is free software; you can redistribute it and/or
>>   *   modify it under the terms of the GNU General Public License

It would be awesome if you could adopt SPDX ids here and in all HPE
existing and future contributions [1] rather than this fine legalese.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 05/17] trace doc: convert trace/ftrace.txt to rst format

[Philippe Ombredanne]

Changbin, Steven,

On Sat, Feb 17, 2018 at 6:39 AM,  <changbin...@intel.com> wrote:
> From: Changbin Du <changbin...@intel.com>
>
> This converts the plain text documentation to reStructuredText format and
> add it into Sphinx TOC tree. No essential content change.
>
> Cc: Steven Rostedt <rost...@goodmis.org>
> Signed-off-by: Changbin Du <changbin...@intel.com>
> ---
>  Documentation/trace/ftrace.rst | 3332 
> 
>  Documentation/trace/ftrace.txt | 3220 --
>  Documentation/trace/index.rst  |1 +
>  3 files changed,  insertions(+), 3220 deletions(-)
>  create mode 100644 Documentation/trace/ftrace.rst
>  delete mode 100644 Documentation/trace/ftrace.txt
>
> diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
> new file mode 100644
> index 000..636aa9bf
> --- /dev/null
> +++ b/Documentation/trace/ftrace.rst
> @@ -0,0 +1,3332 @@
> +
> +ftrace - Function Tracer
> +
> +
> +Copyright 2008 Red Hat Inc.
> +
> +:Author:   Steven Rostedt <srost...@redhat.com>
> +:License:  The GNU Free Documentation License, Version 1.2
> +  (dual licensed under the GPL v2)


Do you mind using an SPDX id per [1] rather that this?

Steven, are you OK with this? Can you ack?

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 05/17] trace doc: convert trace/ftrace.txt to rst format

[Philippe Ombredanne]

Changbin, Steven,

On Sat, Feb 17, 2018 at 6:39 AM,   wrote:
> From: Changbin Du 
>
> This converts the plain text documentation to reStructuredText format and
> add it into Sphinx TOC tree. No essential content change.
>
> Cc: Steven Rostedt 
> Signed-off-by: Changbin Du 
> ---
>  Documentation/trace/ftrace.rst | 3332 
> 
>  Documentation/trace/ftrace.txt | 3220 --
>  Documentation/trace/index.rst  |1 +
>  3 files changed,  insertions(+), 3220 deletions(-)
>  create mode 100644 Documentation/trace/ftrace.rst
>  delete mode 100644 Documentation/trace/ftrace.txt
>
> diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
> new file mode 100644
> index 000..636aa9bf
> --- /dev/null
> +++ b/Documentation/trace/ftrace.rst
> @@ -0,0 +1,3332 @@
> +
> +ftrace - Function Tracer
> +
> +
> +Copyright 2008 Red Hat Inc.
> +
> +:Author:   Steven Rostedt 
> +:License:  The GNU Free Documentation License, Version 1.2
> +  (dual licensed under the GPL v2)


Do you mind using an SPDX id per [1] rather that this?

Steven, are you OK with this? Can you ack?

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/4] ARM: OMAP2+: Introduce low-level suspend code for AM43XX

[Philippe Ombredanne]

Dave,

On Fri, Feb 16, 2018 at 10:40 PM, Dave Gerlach <d-gerl...@ti.com> wrote:
> Although similar to AM33XX, introduce a new low-level asm file for
> suspend containing new context save and restore paths for EMIF and l2
> cache disabling and enabling.
>
> Signed-off-by: Dave Gerlach <d-gerl...@ti.com>
> ---
>  arch/arm/mach-omap2/sleep43xx.S | 393 
> 
>  1 file changed, 393 insertions(+)
>  create mode 100644 arch/arm/mach-omap2/sleep43xx.S
>
> diff --git a/arch/arm/mach-omap2/sleep43xx.S b/arch/arm/mach-omap2/sleep43xx.S
> new file mode 100644
> index ..3a8bfd62a33c
> --- /dev/null
> +++ b/arch/arm/mach-omap2/sleep43xx.S
> @@ -0,0 +1,393 @@
> +/*
> + * Low level suspend code for AM43XX SoCs
> + *
> + * Copyright (C) 2013-2018 Texas Instruments Incorporated - 
> http://www.ti.com/
> + * Dave Gerlach, Vaibhav Bedia
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

Do you mind using SPDX tags per [1] rather that this fine but long
legalese here and in the whole patch set? Unless you are a legalese
lover of course!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/4] ARM: OMAP2+: Introduce low-level suspend code for AM43XX

[Philippe Ombredanne]

Dave,

On Fri, Feb 16, 2018 at 10:40 PM, Dave Gerlach  wrote:
> Although similar to AM33XX, introduce a new low-level asm file for
> suspend containing new context save and restore paths for EMIF and l2
> cache disabling and enabling.
>
> Signed-off-by: Dave Gerlach 
> ---
>  arch/arm/mach-omap2/sleep43xx.S | 393 
> 
>  1 file changed, 393 insertions(+)
>  create mode 100644 arch/arm/mach-omap2/sleep43xx.S
>
> diff --git a/arch/arm/mach-omap2/sleep43xx.S b/arch/arm/mach-omap2/sleep43xx.S
> new file mode 100644
> index ..3a8bfd62a33c
> --- /dev/null
> +++ b/arch/arm/mach-omap2/sleep43xx.S
> @@ -0,0 +1,393 @@
> +/*
> + * Low level suspend code for AM43XX SoCs
> + *
> + * Copyright (C) 2013-2018 Texas Instruments Incorporated - 
> http://www.ti.com/
> + * Dave Gerlach, Vaibhav Bedia
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

Do you mind using SPDX tags per [1] rather that this fine but long
legalese here and in the whole patch set? Unless you are a legalese
lover of course!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

[Philippe Ombredanne]

Miguel,

On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
<miguel.ojeda.sando...@gmail.com> wrote:
> Cc: Willy Tarreau <w...@1wt.eu>
> Cc: Geert Uytterhoeven <ge...@linux-m68k.org>
> Cc: Linus Walleij <tr...@df.lth.se>
> Cc: Robin van der Gracht <ro...@protonic.nl>
> Cc: Paul Burton <paul.bur...@mips.com>
> Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com>
> ---



> diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h
> index b454dfce60d9..aa960efc32f6 100644
> --- a/include/linux/cfag12864b.h
> +++ b/include/linux/cfag12864b.h
> @@ -1,25 +1,11 @@
> +// SPDX-License-Identifier: GPL-2.0

Per the doc [1] you should be using instead this in a .h:
/* SPDX-License-Identifier: GPL-2.0 */

I know this can be surprising. This has been discussed on list quite
lot and the doc has some rationale.



> diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h
> index cb311798e0bc..2a1c985fedea 100644
> --- a/include/linux/ks0108.h
> +++ b/include/linux/ks0108.h
> @@ -1,25 +1,11 @@
> +// SPDX-License-Identifier: GPL-2.0

Same comment as above.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

[Philippe Ombredanne]

Miguel,

On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
 wrote:
> Cc: Willy Tarreau 
> Cc: Geert Uytterhoeven 
> Cc: Linus Walleij 
> Cc: Robin van der Gracht 
> Cc: Paul Burton 
> Signed-off-by: Miguel Ojeda 
> ---



> diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h
> index b454dfce60d9..aa960efc32f6 100644
> --- a/include/linux/cfag12864b.h
> +++ b/include/linux/cfag12864b.h
> @@ -1,25 +1,11 @@
> +// SPDX-License-Identifier: GPL-2.0

Per the doc [1] you should be using instead this in a .h:
/* SPDX-License-Identifier: GPL-2.0 */

I know this can be surprising. This has been discussed on list quite
lot and the doc has some rationale.



> diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h
> index cb311798e0bc..2a1c985fedea 100644
> --- a/include/linux/ks0108.h
> +++ b/include/linux/ks0108.h
> @@ -1,25 +1,11 @@
> +// SPDX-License-Identifier: GPL-2.0

Same comment as above.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v4] rtc: isl12026: Add driver.

[Philippe Ombredanne]

Hi David,

On Fri, Feb 16, 2018 at 8:44 PM, David Daney <david.da...@cavium.com> wrote:
> The ISL12026 is a combination RTC and EEPROM device with I2C
> interface.  The standard RTC driver interface is provided.  The EEPROM
> is accessed via the NVMEM interface via the "eeprom0" directory in the
> sysfs entry for the device.
>
> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com>
> Signed-off-by: David Daney <david.da...@cavium.com>



> --- /dev/null
> +++ b/drivers/rtc/rtc-isl12026.c
> @@ -0,0 +1,529 @@
> +// SPDX-License-Identifier: GPL-2.0



> +MODULE_LICENSE("GPL");

Your MODULE_LICENSE does not match your SPDX tag.
Per module.h, GPL would mean GPL-2.0+ not GPL-2.0
It would be best if you can sync the two.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v4] rtc: isl12026: Add driver.

[Philippe Ombredanne]

Hi David,

On Fri, Feb 16, 2018 at 8:44 PM, David Daney  wrote:
> The ISL12026 is a combination RTC and EEPROM device with I2C
> interface.  The standard RTC driver interface is provided.  The EEPROM
> is accessed via the NVMEM interface via the "eeprom0" directory in the
> sysfs entry for the device.
>
> Reviewed-by: Andy Shevchenko 
> Signed-off-by: David Daney 



> --- /dev/null
> +++ b/drivers/rtc/rtc-isl12026.c
> @@ -0,0 +1,529 @@
> +// SPDX-License-Identifier: GPL-2.0



> +MODULE_LICENSE("GPL");

Your MODULE_LICENSE does not match your SPDX tag.
Per module.h, GPL would mean GPL-2.0+ not GPL-2.0
It would be best if you can sync the two.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 6/7] arm64: tegra: Add Tegra194 chip device tree

[Philippe Ombredanne]

Mikko,

On Thu, Feb 15, 2018 at 3:52 PM, Mikko Perttunen <mperttu...@nvidia.com> wrote:
> Add the chip-level device tree, including binding headers, for the
> NVIDIA Tegra194 "Xavier" system-on-chip. Only a small subset of devices
> are initially available, enough to boot to UART console.
>
> Signed-off-by: Mikko Perttunen <mperttu...@nvidia.com>
> ---
>
> Notes:
> v3:
> - added hypervisor-related apertures to GIC node
> - removed GPL boilerplate in favor of SPDX and harmonized
>   copyright headers

Thanks for this boilerplate removal! but see a few nits below.



> --- /dev/null
> +++ b/include/dt-bindings/clock/tegra194-clock.h
> @@ -0,0 +1,653 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */

The proper style should be this for a .h header on the first line per [1]

> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + */

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst



> --- /dev/null
> +++ b/include/dt-bindings/gpio/tegra194-gpio.h
> @@ -0,0 +1,64 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */
> +



Same as above

> --- /dev/null
> +++ b/include/dt-bindings/power/tegra194-powergate.h
> @@ -0,0 +1,38 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */



Same as above

> --- /dev/null
> +++ b/include/dt-bindings/reset/tegra194-reset.h
> @@ -0,0 +1,155 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */



Same as above
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 6/7] arm64: tegra: Add Tegra194 chip device tree

[Philippe Ombredanne]

Mikko,

On Thu, Feb 15, 2018 at 3:52 PM, Mikko Perttunen  wrote:
> Add the chip-level device tree, including binding headers, for the
> NVIDIA Tegra194 "Xavier" system-on-chip. Only a small subset of devices
> are initially available, enough to boot to UART console.
>
> Signed-off-by: Mikko Perttunen 
> ---
>
> Notes:
> v3:
> - added hypervisor-related apertures to GIC node
> - removed GPL boilerplate in favor of SPDX and harmonized
>   copyright headers

Thanks for this boilerplate removal! but see a few nits below.



> --- /dev/null
> +++ b/include/dt-bindings/clock/tegra194-clock.h
> @@ -0,0 +1,653 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */

The proper style should be this for a .h header on the first line per [1]

> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + */

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst



> --- /dev/null
> +++ b/include/dt-bindings/gpio/tegra194-gpio.h
> @@ -0,0 +1,64 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */
> +



Same as above

> --- /dev/null
> +++ b/include/dt-bindings/power/tegra194-powergate.h
> @@ -0,0 +1,38 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */



Same as above

> --- /dev/null
> +++ b/include/dt-bindings/reset/tegra194-reset.h
> @@ -0,0 +1,155 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */



Same as above
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2 1/1] clk: npcm7xx: add clock controler. fixed clock at DT

[Philippe Ombredanne]

Tali,

On Thu, Feb 15, 2018 at 2:30 PM, Tali Perry <tali.per...@gmail.com> wrote:
> --- /dev/null
> +++ b/drivers/clk/clk-npcm7xx.c
> @@ -0,0 +1,759 @@
> +/*
> + * Nuvoton NPCM7xx Clock Generator
> + * All the clocks are initialized by the bootloader, so this driver allow 
> only
> + * reading of current settings directly from the hardware.
> + *
> + * Copyright (C) 2018 Nuvoton Technologies tali.pe...@nuvoton.com
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + * Released under the GPLv2 only.
> + */

Thank you for using the SPDX tags! but this can be streamlined a bit per [1]

The correct way would come out as this: (note the tag placement and
comment style and the removal of the now redundant unstructured
notice)

> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Nuvoton NPCM7xx Clock Generator
> + * All the clocks are initialized by the bootloader, so this driver allow 
> only
> + * reading of current settings directly from the hardware.
> + *
> + * Copyright (C) 2018 Nuvoton Technologies tali.pe...@nuvoton.com
> + */

And yes you may be surprised by the use of C++ style comment for
this... This has been discussed on list and is what Linus prefers.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2 1/1] clk: npcm7xx: add clock controler. fixed clock at DT

[Philippe Ombredanne]

Tali,

On Thu, Feb 15, 2018 at 2:30 PM, Tali Perry  wrote:
> --- /dev/null
> +++ b/drivers/clk/clk-npcm7xx.c
> @@ -0,0 +1,759 @@
> +/*
> + * Nuvoton NPCM7xx Clock Generator
> + * All the clocks are initialized by the bootloader, so this driver allow 
> only
> + * reading of current settings directly from the hardware.
> + *
> + * Copyright (C) 2018 Nuvoton Technologies tali.pe...@nuvoton.com
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + * Released under the GPLv2 only.
> + */

Thank you for using the SPDX tags! but this can be streamlined a bit per [1]

The correct way would come out as this: (note the tag placement and
comment style and the removal of the now redundant unstructured
notice)

> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Nuvoton NPCM7xx Clock Generator
> + * All the clocks are initialized by the bootloader, so this driver allow 
> only
> + * reading of current settings directly from the hardware.
> + *
> + * Copyright (C) 2018 Nuvoton Technologies tali.pe...@nuvoton.com
> + */

And yes you may be surprised by the use of C++ style comment for
this... This has been discussed on list and is what Linus prefers.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

[Philippe Ombredanne]

Dear Sebastian,

On Wed, Feb 14, 2018 at 11:07 PM, Sebastian Reichel
<sebastian.reic...@collabora.co.uk> wrote:
> Motorola CPCAP is a PMIC with audio functionality, that can be
> found on Motorola Droid 4 and probably a few other phones from
> Motorola's Droid series.
>
> The driver has been written from scratch using Motorola's Android
> driver, register dumps from running Android and datasheet for NXP
> MC13783UG (which is similar to Motorola CPCAP, but not the same).
>
> The chip provides two audio interfaces, that can be muxed to two
> different audio codecs. One provides support for stereo output
> (named StDAC or HiFi), while the other only provides mono output
> (named Voice). Only the Voice codec provides a Capture interface.
>
> Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>



> --- /dev/null
> +++ b/sound/soc/codecs/cpcap.c
> @@ -0,0 +1,1588 @@
> +/*
> + * ALSA SoC CPCAP codec driver
> + *
> + * Copyright (C) 2017 - 2018 Sebastian Reichel <s...@kernel.org>
> + *
> + * Very loosely based on original driver from Motorola:
> + * Copyright (C) 2007 - 2009 Motorola, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + */

Could you consider using the new SPDX tags instead of this fine but
long legalese? [1]



> +MODULE_ALIAS("platform:cpcap-codec");
> +MODULE_DESCRIPTION("ASoC CPCAP codec driver");
> +MODULE_AUTHOR("Sebastian Reichel");
> +MODULE_LICENSE("GPL");

This does not match your license: per module.h, GPL means GPL-2.0 or
later. You notice above is GPL-2.0, not "or later"

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

[Philippe Ombredanne]

Dear Sebastian,

On Wed, Feb 14, 2018 at 11:07 PM, Sebastian Reichel
 wrote:
> Motorola CPCAP is a PMIC with audio functionality, that can be
> found on Motorola Droid 4 and probably a few other phones from
> Motorola's Droid series.
>
> The driver has been written from scratch using Motorola's Android
> driver, register dumps from running Android and datasheet for NXP
> MC13783UG (which is similar to Motorola CPCAP, but not the same).
>
> The chip provides two audio interfaces, that can be muxed to two
> different audio codecs. One provides support for stereo output
> (named StDAC or HiFi), while the other only provides mono output
> (named Voice). Only the Voice codec provides a Capture interface.
>
> Signed-off-by: Sebastian Reichel 



> --- /dev/null
> +++ b/sound/soc/codecs/cpcap.c
> @@ -0,0 +1,1588 @@
> +/*
> + * ALSA SoC CPCAP codec driver
> + *
> + * Copyright (C) 2017 - 2018 Sebastian Reichel 
> + *
> + * Very loosely based on original driver from Motorola:
> + * Copyright (C) 2007 - 2009 Motorola, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + */

Could you consider using the new SPDX tags instead of this fine but
long legalese? [1]



> +MODULE_ALIAS("platform:cpcap-codec");
> +MODULE_DESCRIPTION("ASoC CPCAP codec driver");
> +MODULE_AUTHOR("Sebastian Reichel");
> +MODULE_LICENSE("GPL");

This does not match your license: per module.h, GPL means GPL-2.0 or
later. You notice above is GPL-2.0, not "or later"

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v5 10/12] drm/sun4i: Implement A83T HDMI driver

[Philippe Ombredanne]

On Wed, Feb 14, 2018 at 9:09 PM, Jernej Skrabec <jernej.skra...@siol.net> wrote:
> A83T has DW HDMI IP block with a custom PHY similar to Synopsys gen2
> HDMI PHY.
>
> Only video output was tested, while HW also supports audio and CEC.
> Support for them will be added later.
>
> Signed-off-by: Jernej Skrabec <jernej.skra...@siol.net>

...

> --- /dev/null
> +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: GPL-2.0+

This should be

/* SPDX-License-Identifier: GPL-2.0+ /* in a .h per [1]

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v5 10/12] drm/sun4i: Implement A83T HDMI driver

[Philippe Ombredanne]

On Wed, Feb 14, 2018 at 9:09 PM, Jernej Skrabec  wrote:
> A83T has DW HDMI IP block with a custom PHY similar to Synopsys gen2
> HDMI PHY.
>
> Only video output was tested, while HW also supports audio and CEC.
> Support for them will be added later.
>
> Signed-off-by: Jernej Skrabec 

...

> --- /dev/null
> +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: GPL-2.0+

This should be

/* SPDX-License-Identifier: GPL-2.0+ /* in a .h per [1]

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 4/8] MIPS: mscc: Add initial support for Microsemi MIPS SoCs

[Philippe Ombredanne]

Alexandre,

On Wed, Feb 14, 2018 at 5:51 PM, James Hogan <jho...@kernel.org> wrote:
> On Tue, Jan 16, 2018 at 11:12:36AM +0100, Alexandre Belloni wrote:

...

>> diff --git a/arch/mips/mscc/Platform b/arch/mips/mscc/Platform
>> new file mode 100644
>> index ..9ae874c8f136
>> --- /dev/null
>> +++ b/arch/mips/mscc/Platform
>> @@ -0,0 +1,12 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR MIT)
>> +#
>> +# Microsemi MIPS SoC support
>> +#
>> +# License: Dual MIT/GPL

IMHO you should remove this line as it exactly repeats the
SPDX-License-Identifier: (GPL-2.0 OR MIT) line in a less clear and
precise way.
The whole purpose of the SPDX things is to make licensing eventually
as clear ass possible
Thanks!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 4/8] MIPS: mscc: Add initial support for Microsemi MIPS SoCs

[Philippe Ombredanne]

Alexandre,

On Wed, Feb 14, 2018 at 5:51 PM, James Hogan  wrote:
> On Tue, Jan 16, 2018 at 11:12:36AM +0100, Alexandre Belloni wrote:

...

>> diff --git a/arch/mips/mscc/Platform b/arch/mips/mscc/Platform
>> new file mode 100644
>> index ..9ae874c8f136
>> --- /dev/null
>> +++ b/arch/mips/mscc/Platform
>> @@ -0,0 +1,12 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR MIT)
>> +#
>> +# Microsemi MIPS SoC support
>> +#
>> +# License: Dual MIT/GPL

IMHO you should remove this line as it exactly repeats the
SPDX-License-Identifier: (GPL-2.0 OR MIT) line in a less clear and
precise way.
The whole purpose of the SPDX things is to make licensing eventually
as clear ass possible
Thanks!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

[Philippe Ombredanne]

On Wed, Feb 14, 2018 at 2:21 PM, Cosmin-Gabriel Samoila
<cosmin.samo...@nxp.com> wrote:
> The AK4458 is a 32-bit 8ch Premium DAC that corresponds
> to a 768kHz PCM input and an 11.2MHz DSD input at maximum.
> It supports I2S, DSD and TDM modes with 24 or 32 bit MSB
> or 16, 24, 32 LSB formats. Its datasheet is available here:
> https://www.akm.com/akm/en/file/datasheet/AK4458VN.pdf
>
> Signed-off-by: Junichi Wakasugi <wakasugi...@om.asahi-kasei.co.jp>
> Signed-off-by: Mihai Serban <mihai.ser...@nxp.com>
> Signed-off-by: Shengjiu Wang <shengjiu.w...@nxp.com>
> Signed-off-by: Cosmin-Gabriel Samoila <cosmin.samo...@nxp.com>
> ---

> --- /dev/null
> +++ b/sound/soc/codecs/ak4458.c
> @@ -0,0 +1,659 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Audio driver for AK4458 DAC
> + *
> + * Copyright (C) 2016 Asahi Kasei Microdevices Corporation
> + * Copyright 2018 NXP

Thanks for using the proper SPDX tag here yet see my comments below.



> +MODULE_AUTHOR("Junichi Wakasugi <wakasugi...@om.asahi-kasei.co.jp>");
> +MODULE_AUTHOR("Mihai Serban <mihai.ser...@nxp.com>");
> +MODULE_DESCRIPTION("ASoC AK4458 DAC driver");
> +MODULE_LICENSE("GPL");

This means GPL-2.0+ per module.h and therefore does not match your
GPL-2.0 SPDX tag above.
Go one way or the other, but not both way please.

> diff --git a/sound/soc/codecs/ak4458.h b/sound/soc/codecs/ak4458.h
> new file mode 100644
> index 000..16d9d22
> --- /dev/null
> +++ b/sound/soc/codecs/ak4458.h
> @@ -0,0 +1,86 @@
> +// SPDX-License-Identifier: GPL-2.0

As weird as it sounds the style should be plain /*
SPDX-License-Identifier: GPL-2.0 /* here per [1]

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

[Philippe Ombredanne]

On Wed, Feb 14, 2018 at 2:21 PM, Cosmin-Gabriel Samoila
 wrote:
> The AK4458 is a 32-bit 8ch Premium DAC that corresponds
> to a 768kHz PCM input and an 11.2MHz DSD input at maximum.
> It supports I2S, DSD and TDM modes with 24 or 32 bit MSB
> or 16, 24, 32 LSB formats. Its datasheet is available here:
> https://www.akm.com/akm/en/file/datasheet/AK4458VN.pdf
>
> Signed-off-by: Junichi Wakasugi 
> Signed-off-by: Mihai Serban 
> Signed-off-by: Shengjiu Wang 
> Signed-off-by: Cosmin-Gabriel Samoila 
> ---

> --- /dev/null
> +++ b/sound/soc/codecs/ak4458.c
> @@ -0,0 +1,659 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Audio driver for AK4458 DAC
> + *
> + * Copyright (C) 2016 Asahi Kasei Microdevices Corporation
> + * Copyright 2018 NXP

Thanks for using the proper SPDX tag here yet see my comments below.



> +MODULE_AUTHOR("Junichi Wakasugi ");
> +MODULE_AUTHOR("Mihai Serban ");
> +MODULE_DESCRIPTION("ASoC AK4458 DAC driver");
> +MODULE_LICENSE("GPL");

This means GPL-2.0+ per module.h and therefore does not match your
GPL-2.0 SPDX tag above.
Go one way or the other, but not both way please.

> diff --git a/sound/soc/codecs/ak4458.h b/sound/soc/codecs/ak4458.h
> new file mode 100644
> index 000..16d9d22
> --- /dev/null
> +++ b/sound/soc/codecs/ak4458.h
> @@ -0,0 +1,86 @@
> +// SPDX-License-Identifier: GPL-2.0

As weird as it sounds the style should be plain /*
SPDX-License-Identifier: GPL-2.0 /* here per [1]

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/3] HID: add driver for Valve Steam Controller

[Philippe Ombredanne]

Benjamin, Rodrigo,

On Wed, Feb 14, 2018 at 3:45 PM, Benjamin Tissoires
<benjamin.tissoi...@redhat.com> wrote:
> On Tue, Feb 13, 2018 at 1:03 PM, Rodrigo Rivas Costa 
> <rodrigorivasco...@gmail.com> wrote:


>> --- /dev/null
>> +++ b/drivers/hid/hid-steam.c
>> @@ -0,0 +1,480 @@
>> +// SPDX-License-Identifier: GPL-2.0
>
> Non standard header

Benjamin:
What do you mean by this?
This is following the proper style for this line as documented (and
discussed on list at great length) [1]

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst


>> +/*
>> + * HID driver for Valve Steam Controller
>> + *
>> + * Supports both the wired and wireless interfaces.
>> + *
>> + * Copyright (c) 2018 Rodrigo Rivas Costa <rodrigorivasco...@gmail.com>
>> + */
>> +
>> +/*
>> + * This program is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU General Public License as published by the 
>> Free
>> + * Software Foundation; either version 2 of the License, or (at your option)
>> + * any later version.
>> + */

Rodrigo,
Since you used the proper SPDX tag (in the proper style as explained
in the doc), you can remove this boilerplate alright as it does double
duty with the tag.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/3] HID: add driver for Valve Steam Controller

[Philippe Ombredanne]

Benjamin, Rodrigo,

On Wed, Feb 14, 2018 at 3:45 PM, Benjamin Tissoires
 wrote:
> On Tue, Feb 13, 2018 at 1:03 PM, Rodrigo Rivas Costa 
>  wrote:


>> --- /dev/null
>> +++ b/drivers/hid/hid-steam.c
>> @@ -0,0 +1,480 @@
>> +// SPDX-License-Identifier: GPL-2.0
>
> Non standard header

Benjamin:
What do you mean by this?
This is following the proper style for this line as documented (and
discussed on list at great length) [1]

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst


>> +/*
>> + * HID driver for Valve Steam Controller
>> + *
>> + * Supports both the wired and wireless interfaces.
>> + *
>> + * Copyright (c) 2018 Rodrigo Rivas Costa 
>> + */
>> +
>> +/*
>> + * This program is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU General Public License as published by the 
>> Free
>> + * Software Foundation; either version 2 of the License, or (at your option)
>> + * any later version.
>> + */

Rodrigo,
Since you used the proper SPDX tag (in the proper style as explained
in the doc), you can remove this boilerplate alright as it does double
duty with the tag.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support

[Philippe Ombredanne]

Jacopo,

On Wed, Feb 14, 2018 at 2:58 PM, Geert Uytterhoeven
<ge...@linux-m68k.org> wrote:

>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> @@ -0,0 +1,30 @@
>> +// SPDX-License-Identifier: GPL-2.

This should be GPL-2.0



>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -0,0 +1,495 @@
>> +// SPDX-License-Identifier: GPL-2.

This should be GPL-2.0 too.
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support

[Philippe Ombredanne]

Jacopo,

On Wed, Feb 14, 2018 at 2:58 PM, Geert Uytterhoeven
 wrote:

>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> @@ -0,0 +1,30 @@
>> +// SPDX-License-Identifier: GPL-2.

This should be GPL-2.0



>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -0,0 +1,495 @@
>> +// SPDX-License-Identifier: GPL-2.

This should be GPL-2.0 too.
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 3:37 PM, Himanshu Jha
<himanshujha199...@gmail.com> wrote:
> On Mon, Feb 12, 2018 at 03:10:56PM +0100, Philippe Ombredanne wrote:
>> On Mon, Feb 12, 2018 at 12:54 PM, Himanshu Jha
>> <himanshujha199...@gmail.com> wrote:
>> > Move the adis16201 driver out of staging directory and merge to the
>> > mainline IIO directory.
>> >
>> > Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com>
>>
>> 
>> > --- /dev/null
>> > +++ b/drivers/iio/accel/adis16201.c
>> > @@ -0,0 +1,315 @@
>> > +// SPDX-License-Identifier: GPL-2.0+
>>
>> 
>>
>> > +MODULE_AUTHOR("Barry Song <21cn...@gmail.com>");
>> > +MODULE_DESCRIPTION("Analog Devices ADIS16201 Dual-Axis Digital 
>> > Inclinometer and Accelerometer");
>> > +MODULE_LICENSE("GPL v2");
>> > +MODULE_ALIAS("spi:adis16201");
>>
>> Your MODULE_LICENSE does not match your SPDX license id.
>> MODULE_LICENSE("GPL v2"); means SPDX GPL-2.0
>> MODULE_LICENSE("GPL"); means SPDX GPL-2.0+
>>
>
> I didn't knew about that! Thanks for pointing.

Sure thing. I reckon this can be a tad surprising.
FWIW, the reference for the SPDX tag is in
Documentation/process/license-rules.rst and for the MODULE_LICENSE
macro this is in module.h
It is unlikely module.h will ever evolve there as this would break all
third-party module loaders/tools that rely on the documented data
values and conventions

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 3:37 PM, Himanshu Jha
 wrote:
> On Mon, Feb 12, 2018 at 03:10:56PM +0100, Philippe Ombredanne wrote:
>> On Mon, Feb 12, 2018 at 12:54 PM, Himanshu Jha
>>  wrote:
>> > Move the adis16201 driver out of staging directory and merge to the
>> > mainline IIO directory.
>> >
>> > Signed-off-by: Himanshu Jha 
>>
>> 
>> > --- /dev/null
>> > +++ b/drivers/iio/accel/adis16201.c
>> > @@ -0,0 +1,315 @@
>> > +// SPDX-License-Identifier: GPL-2.0+
>>
>> 
>>
>> > +MODULE_AUTHOR("Barry Song <21cn...@gmail.com>");
>> > +MODULE_DESCRIPTION("Analog Devices ADIS16201 Dual-Axis Digital 
>> > Inclinometer and Accelerometer");
>> > +MODULE_LICENSE("GPL v2");
>> > +MODULE_ALIAS("spi:adis16201");
>>
>> Your MODULE_LICENSE does not match your SPDX license id.
>> MODULE_LICENSE("GPL v2"); means SPDX GPL-2.0
>> MODULE_LICENSE("GPL"); means SPDX GPL-2.0+
>>
>
> I didn't knew about that! Thanks for pointing.

Sure thing. I reckon this can be a tad surprising.
FWIW, the reference for the SPDX tag is in
Documentation/process/license-rules.rst and for the MODULE_LICENSE
macro this is in module.h
It is unlikely module.h will ever evolve there as this would break all
third-party module loaders/tools that rely on the documented data
values and conventions

-- 
Cordially
Philippe Ombredanne

Re: [PATCH] ata: add Amiga Gayle PATA controller driver

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 2:49 PM, Bartlomiej Zolnierkiewicz
<b.zolnier...@samsung.com> wrote:
> Add Amiga Gayle PATA controller driver. It enables libata support
> for the on-board IDE interfaces on some Amiga models (A600, A1200,
> A4000 and A4000T) and also for IDE interfaces on the Zorro expansion
> bus (M-Tech E-Matrix 530 expansion card).
>
> Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help
> with testing the driver.
>
> Tested-by: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de>
> Cc: Michael Schmitz <schmitz...@gmail.com>
> Cc: Geert Uytterhoeven <ge...@linux-m68k.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>


> + *
> + * This file is subject to the terms and conditions of the GNU General Public
> + * License.  See the file "COPYING" in the main directory of this archive
> + * for more details.
> + */

Do you mind using the new SDPX ids? (well not so new anymore). [1]


> +
> +MODULE_AUTHOR("Bartlomiej Zolnierkiewicz");
> +MODULE_DESCRIPTION("low-level driver for Amiga Gayle PATA");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:amiga-gayle-ide");
> +MODULE_VERSION(DRV_VERSION);
>

 and while doing it please make sure your MODULE_LICENSE matches
the license.
Here for instance it is not clear to me if this a GPL-2.0 or a GPL-2.0+


Thanks!
[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

+1 650 799 0949 | pombreda...@nexb.com
DejaCode - What's in your code?! - http://www.dejacode.com
AboutCode - Open source for open source - https://www.aboutcode.org
nexB Inc. - http://www.nexb.com

CONFIDENTIALITY NOTICE:  This e-mail (including attachments) may
contain information that is proprietary or confidential. If you are
not the intended recipient or a person responsible for its delivery to
the intended recipient, do not copy or distribute it. Please
permanently delete the e-mail and any attachments, and notify us
immediately at (650) 799 0949.

Re: [PATCH] ata: add Amiga Gayle PATA controller driver

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 2:49 PM, Bartlomiej Zolnierkiewicz
 wrote:
> Add Amiga Gayle PATA controller driver. It enables libata support
> for the on-board IDE interfaces on some Amiga models (A600, A1200,
> A4000 and A4000T) and also for IDE interfaces on the Zorro expansion
> bus (M-Tech E-Matrix 530 expansion card).
>
> Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help
> with testing the driver.
>
> Tested-by: John Paul Adrian Glaubitz 
> Cc: Michael Schmitz 
> Cc: Geert Uytterhoeven 
> Signed-off-by: Bartlomiej Zolnierkiewicz 


> + *
> + * This file is subject to the terms and conditions of the GNU General Public
> + * License.  See the file "COPYING" in the main directory of this archive
> + * for more details.
> + */

Do you mind using the new SDPX ids? (well not so new anymore). [1]


> +
> +MODULE_AUTHOR("Bartlomiej Zolnierkiewicz");
> +MODULE_DESCRIPTION("low-level driver for Amiga Gayle PATA");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:amiga-gayle-ide");
> +MODULE_VERSION(DRV_VERSION);
>

 and while doing it please make sure your MODULE_LICENSE matches
the license.
Here for instance it is not clear to me if this a GPL-2.0 or a GPL-2.0+


Thanks!
[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

+1 650 799 0949 | pombreda...@nexb.com
DejaCode - What's in your code?! - http://www.dejacode.com
AboutCode - Open source for open source - https://www.aboutcode.org
nexB Inc. - http://www.nexb.com

CONFIDENTIALITY NOTICE:  This e-mail (including attachments) may
contain information that is proprietary or confidential. If you are
not the intended recipient or a person responsible for its delivery to
the intended recipient, do not copy or distribute it. Please
permanently delete the e-mail and any attachments, and notify us
immediately at (650) 799 0949.

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

[Philippe Ombredanne]

Amelie,

On Mon, Feb 12, 2018 at 1:06 PM, Lee Jones <lee.jo...@linaro.org> wrote:
> On Thu, 08 Feb 2018, Amelie Delaunay wrote:
>
>> ST Multi-Function eXpander (MFX) is a slave controller using I2C
>> for communication with the main MCU. Main features are:
>> - 16 fast GPIOs individually configurable in input/output
>> - 8 alternate GPIOs individually configurable in input/output
>> - Main MCU IDD measurement
>> - Resistive touchscreen controller
>>
>> Only GPIO expander (16 fast GPIOs + 8 alternate) feature is
>> supported for the moment.
>>
>> Signed-off-by: Amelie Delaunay <amelie.delau...@st.com>



>> --- /dev/null
>> +++ b/drivers/mfd/st-mfx.c
>> @@ -0,0 +1,526 @@
>> +/*
>> + * STMicroelectronics Multi-Function eXpander (ST-MFX) Core Driver
>> + *
>> + * Copyright (C) 2017, STMicroelectronics - All Rights Reserved
>> + * Author(s): Amelie Delaunay <amelie.delau...@st.com> for 
>> STMicroelectronics.
>
> You don't need to put "for STMicroelectronics".  This was something we
> made up when submitting from a different (!st.com) email address.
>
>> + * License terms: GPL V2.0.
>> + *
>> + * st-mfx Core Driver is free software; you can redistribute it and/or 
>> modify it
>> + * under the terms of the GNU General Public License version 2 as published 
>> by
>> + * the Free Software Foundation.
>> + *
>> + * st-mfx Core Driver is distributed in the hope that it will be useful, but
>> + * WITHOUT ANY WARRANTY; without even the implied warranty of 
>> MERCHANTABILITY or
>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for 
>> more
>> + * details.
>> + *
>> + * You should have received a copy of the GNU General Public License along 
>> with
>> + * st-mfx Core Driver. If not, see <http://www.gnu.org/licenses/>.
>
> You should be able to use the short version of the licensing
> agreement.  Also, please grep for "SPDX".

You can check the doc for the (fairly new) way to remove legalese
boilerplate at Documentation/process/license-rules.rst or [1]
It helps keep the focus on the code and less on licensing!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

[Philippe Ombredanne]

Amelie,

On Mon, Feb 12, 2018 at 1:06 PM, Lee Jones  wrote:
> On Thu, 08 Feb 2018, Amelie Delaunay wrote:
>
>> ST Multi-Function eXpander (MFX) is a slave controller using I2C
>> for communication with the main MCU. Main features are:
>> - 16 fast GPIOs individually configurable in input/output
>> - 8 alternate GPIOs individually configurable in input/output
>> - Main MCU IDD measurement
>> - Resistive touchscreen controller
>>
>> Only GPIO expander (16 fast GPIOs + 8 alternate) feature is
>> supported for the moment.
>>
>> Signed-off-by: Amelie Delaunay 



>> --- /dev/null
>> +++ b/drivers/mfd/st-mfx.c
>> @@ -0,0 +1,526 @@
>> +/*
>> + * STMicroelectronics Multi-Function eXpander (ST-MFX) Core Driver
>> + *
>> + * Copyright (C) 2017, STMicroelectronics - All Rights Reserved
>> + * Author(s): Amelie Delaunay  for 
>> STMicroelectronics.
>
> You don't need to put "for STMicroelectronics".  This was something we
> made up when submitting from a different (!st.com) email address.
>
>> + * License terms: GPL V2.0.
>> + *
>> + * st-mfx Core Driver is free software; you can redistribute it and/or 
>> modify it
>> + * under the terms of the GNU General Public License version 2 as published 
>> by
>> + * the Free Software Foundation.
>> + *
>> + * st-mfx Core Driver is distributed in the hope that it will be useful, but
>> + * WITHOUT ANY WARRANTY; without even the implied warranty of 
>> MERCHANTABILITY or
>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for 
>> more
>> + * details.
>> + *
>> + * You should have received a copy of the GNU General Public License along 
>> with
>> + * st-mfx Core Driver. If not, see <http://www.gnu.org/licenses/>.
>
> You should be able to use the short version of the licensing
> agreement.  Also, please grep for "SPDX".

You can check the doc for the (fairly new) way to remove legalese
boilerplate at Documentation/process/license-rules.rst or [1]
It helps keep the focus on the code and less on licensing!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 12:54 PM, Himanshu Jha
<himanshujha199...@gmail.com> wrote:
> Move the adis16201 driver out of staging directory and merge to the
> mainline IIO directory.
>
> Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com>


> --- /dev/null
> +++ b/drivers/iio/accel/adis16201.c
> @@ -0,0 +1,315 @@
> +// SPDX-License-Identifier: GPL-2.0+



> +MODULE_AUTHOR("Barry Song <21cn...@gmail.com>");
> +MODULE_DESCRIPTION("Analog Devices ADIS16201 Dual-Axis Digital Inclinometer 
> and Accelerometer");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("spi:adis16201");

Your MODULE_LICENSE does not match your SPDX license id.
MODULE_LICENSE("GPL v2"); means SPDX GPL-2.0
MODULE_LICENSE("GPL"); means SPDX GPL-2.0+


-- 
Cordially
Philippe Ombredanne

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 12:54 PM, Himanshu Jha
 wrote:
> Move the adis16201 driver out of staging directory and merge to the
> mainline IIO directory.
>
> Signed-off-by: Himanshu Jha 


> --- /dev/null
> +++ b/drivers/iio/accel/adis16201.c
> @@ -0,0 +1,315 @@
> +// SPDX-License-Identifier: GPL-2.0+



> +MODULE_AUTHOR("Barry Song <21cn...@gmail.com>");
> +MODULE_DESCRIPTION("Analog Devices ADIS16201 Dual-Axis Digital Inclinometer 
> and Accelerometer");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("spi:adis16201");

Your MODULE_LICENSE does not match your SPDX license id.
MODULE_LICENSE("GPL v2"); means SPDX GPL-2.0
MODULE_LICENSE("GPL"); means SPDX GPL-2.0+


-- 
Cordially
Philippe Ombredanne

Re: [RFC PATCH] soc: zynqmp: Add support for tap delay settings

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 11:35 AM, Manish Narani
<manish.nar...@xilinx.com> wrote:
> This patch add support for tep delays programming for zynqmp platform.
> This also adds dll reset support.
>
> Signed-off-by: Manish Narani <mnar...@xilinx.com>



> --- /dev/null
> +++ b/drivers/soc/xilinx/zynqmp/tap_delays.c
> @@ -0,0 +1,270 @@
> +/*
> + * Xilinx Zynq MPSoC Tap Delay Programming
> + *
> + *  Copyright (C) 2016 Xilinx, Inc.
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */

Dear Manish,
Why not using the SPDX ids there too and elsewhere? You are using them
alright in many other places in this patch. See
Documentation/process/license-rules.rst for details
-- 
Cordially
Philippe Ombredanne

Re: [RFC PATCH] soc: zynqmp: Add support for tap delay settings

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 11:35 AM, Manish Narani
 wrote:
> This patch add support for tep delays programming for zynqmp platform.
> This also adds dll reset support.
>
> Signed-off-by: Manish Narani 



> --- /dev/null
> +++ b/drivers/soc/xilinx/zynqmp/tap_delays.c
> @@ -0,0 +1,270 @@
> +/*
> + * Xilinx Zynq MPSoC Tap Delay Programming
> + *
> + *  Copyright (C) 2016 Xilinx, Inc.
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */

Dear Manish,
Why not using the SPDX ids there too and elsewhere? You are using them
alright in many other places in this patch. See
Documentation/process/license-rules.rst for details
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 14/17] s390/kexec_file: Add kexec_file_load system call

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 11:07 AM, Philipp Rudo <pr...@linux.vnet.ibm.com> wrote:
> This patch adds the kexec_file_load system call to s390 as well as the arch
> specific functions common code requires to work. Loaders for the different
> file types will be added later.
>
> Signed-off-by: Philipp Rudo <pr...@linux.vnet.ibm.com>



> --- /dev/null
> +++ b/arch/s390/kernel/machine_kexec_file.c
> @@ -0,0 +1,174 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

I know this may sound weird but in .c files this should be instead:

// SPDX-License-Identifier: GPL-2.0

See Documentation/process/license-rules.rst for why.
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 14/17] s390/kexec_file: Add kexec_file_load system call

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 11:07 AM, Philipp Rudo  wrote:
> This patch adds the kexec_file_load system call to s390 as well as the arch
> specific functions common code requires to work. Loaders for the different
> file types will be added later.
>
> Signed-off-by: Philipp Rudo 



> --- /dev/null
> +++ b/arch/s390/kernel/machine_kexec_file.c
> @@ -0,0 +1,174 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

I know this may sound weird but in .c files this should be instead:

// SPDX-License-Identifier: GPL-2.0

See Documentation/process/license-rules.rst for why.
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 2/3] arm64: dts: sdm845: Add minimal dts files for sdm845 SoC/MTP

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 7:28 AM, Rajendra Nayak <rna...@codeaurora.org> wrote:
> Add a skeletal sdm845 SoC dtsi and MTP board dts/dtsi files
>
> Signed-off-by: Rajendra Nayak <rna...@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/Makefile   |   1 +
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts |  13 ++
>  arch/arm64/boot/dts/qcom/sdm845.dtsi| 275 
> 
>  3 files changed, 289 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sdm845-mtp.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/sdm845.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile 
> b/arch/arm64/boot/dts/qcom/Makefile
> index 55ec5ee7f7e8..9319e74b8906 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -6,3 +6,4 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)+= msm8992-bullhead-rev-101.dtb
>  dtb-$(CONFIG_ARCH_QCOM)+= msm8994-angler-rev-101.dtb
>  dtb-$(CONFIG_ARCH_QCOM)+= msm8996-mtp.dtb
> +dtb-$(CONFIG_ARCH_QCOM)+= sdm845-mtp.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts 
> b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> new file mode 100644
> index ..617c7bb25fb1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -0,0 +1,13 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> + */

This is more cosmetic, but since there is only a single line of
copyright statement and no other comments, it would make sense to use
C++ style // for that line too IMHO (and other similar cases)
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 2/3] arm64: dts: sdm845: Add minimal dts files for sdm845 SoC/MTP

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 7:28 AM, Rajendra Nayak  wrote:
> Add a skeletal sdm845 SoC dtsi and MTP board dts/dtsi files
>
> Signed-off-by: Rajendra Nayak 
> ---
>  arch/arm64/boot/dts/qcom/Makefile   |   1 +
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts |  13 ++
>  arch/arm64/boot/dts/qcom/sdm845.dtsi| 275 
> 
>  3 files changed, 289 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sdm845-mtp.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/sdm845.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile 
> b/arch/arm64/boot/dts/qcom/Makefile
> index 55ec5ee7f7e8..9319e74b8906 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -6,3 +6,4 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)+= msm8992-bullhead-rev-101.dtb
>  dtb-$(CONFIG_ARCH_QCOM)+= msm8994-angler-rev-101.dtb
>  dtb-$(CONFIG_ARCH_QCOM)+= msm8996-mtp.dtb
> +dtb-$(CONFIG_ARCH_QCOM)+= sdm845-mtp.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts 
> b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> new file mode 100644
> index ..617c7bb25fb1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -0,0 +1,13 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> + */

This is more cosmetic, but since there is only a single line of
copyright statement and no other comments, it would make sense to use
C++ style // for that line too IMHO (and other similar cases)
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes

[Philippe Ombredanne]

Jerry,

On Mon, Feb 12, 2018 at 6:21 AM, Jerry Hoemann <jerry.hoem...@hpe.com> wrote:
> Minor white space changes and some name clean up.
>
> Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com>
> ---
>  drivers/watchdog/hpwdt.c | 49 
> +++-
>  1 file changed, 23 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index 6f7949ef9a23..ee9a92220ece 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -1,11 +1,9 @@
>  /*
>   * HPE WatchDog Driver
> - * based on
>   *
> - * SoftDog 0.05:   A Software Watchdog Device
> - *
> - * (c) Copyright 2015 Hewlett Packard Enterprise Development LP
> + * (c) Copyright 2018 Hewlett Packard Enterprise Development LP
>   * Thomas Mingarelli <thomas.mingare...@hpe.com>
> + * Jerry Hoemann <jerry.hoem...@hpe.com>
>   *
>   * This program is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU General Public License

Since you are updating the copyright, why not updating the licensing
to use the new concise SPDX ids instead? [1]
And you get a big good karma bonus if you can also do the same for all
HPE-copyrighted files, tree-wide ;) and/or spread the word inside your
team.

Thank you for your kind consideration!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

Cordially
Philippe Ombredanne

Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes

[Philippe Ombredanne]

Jerry,

On Mon, Feb 12, 2018 at 6:21 AM, Jerry Hoemann  wrote:
> Minor white space changes and some name clean up.
>
> Signed-off-by: Jerry Hoemann 
> ---
>  drivers/watchdog/hpwdt.c | 49 
> +++-
>  1 file changed, 23 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index 6f7949ef9a23..ee9a92220ece 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -1,11 +1,9 @@
>  /*
>   * HPE WatchDog Driver
> - * based on
>   *
> - * SoftDog 0.05:   A Software Watchdog Device
> - *
> - * (c) Copyright 2015 Hewlett Packard Enterprise Development LP
> + * (c) Copyright 2018 Hewlett Packard Enterprise Development LP
>   * Thomas Mingarelli 
> + * Jerry Hoemann 
>   *
>   * This program is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU General Public License

Since you are updating the copyright, why not updating the licensing
to use the new concise SPDX ids instead? [1]
And you get a big good karma bonus if you can also do the same for all
HPE-copyrighted files, tree-wide ;) and/or spread the word inside your
team.

Thank you for your kind consideration!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

Cordially
Philippe Ombredanne

Re: [PATCH v5 01/11] scsi: ufs: sysfs: attribute group for existing sysfs entries.

[Philippe Ombredanne]

Dear Stanislav,

On Mon, Feb 12, 2018 at 2:06 AM, Jaegeuk Kim <jaeg...@kernel.org> wrote:
> On 02/06, Stanislav Nijnikov wrote:
>> This patch introduces attribute group to show existing sysfs entries.
>>
>> Signed-off-by: Stanislav Nijnikov <stanislav.nijni...@wdc.com>



>> --- /dev/null
>> +++ b/drivers/scsi/ufs/ufs-sysfs.c
>> @@ -0,0 +1,156 @@
>> +// SPDX-License-Identifier: GPL-2.0-only

I commend you for using license ids here. But there is an issue with
your attempt to use the latest and greatest license ids from SPDX:
GPL-2.0-only is not a documented license id in our doc [1]
Until this is updated (help welcomed including patching a few 10K+
files) , this should be GPL-2.0 instead to avoid confusion and keep
things homogeneous and tidy.

FYI, using only the doc as the reference was brought forward by
Russell King and Christoph Hellwig and in particular with this:

On Thu, Nov 9, 2017 at 5:44 PM, Russell King <r...@armlinux.org.uk> wrote:

> I'd be more comfortable if we could have something in the kernel tree
> that identifies the SPDX tags and their meaning, maybe with the
> _standard_ file header for that license included, so there is no
> argument about what any particular SPDX tag means.

Based on this, Thomas Gleixner updated the doc alright following this
important point. So, in case of doubt the doc should be the reference
for this and nothing else. And if there are issue with the doc, then
we can fix it with a patch ;)

CC: Russell King <r...@armlinux.org.uk>
CC: Christoph Hellwig <h...@infradead.org>
CC: Thomas Gleixner <t...@linutronix.de>

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v5 01/11] scsi: ufs: sysfs: attribute group for existing sysfs entries.

[Philippe Ombredanne]

Dear Stanislav,

On Mon, Feb 12, 2018 at 2:06 AM, Jaegeuk Kim  wrote:
> On 02/06, Stanislav Nijnikov wrote:
>> This patch introduces attribute group to show existing sysfs entries.
>>
>> Signed-off-by: Stanislav Nijnikov 



>> --- /dev/null
>> +++ b/drivers/scsi/ufs/ufs-sysfs.c
>> @@ -0,0 +1,156 @@
>> +// SPDX-License-Identifier: GPL-2.0-only

I commend you for using license ids here. But there is an issue with
your attempt to use the latest and greatest license ids from SPDX:
GPL-2.0-only is not a documented license id in our doc [1]
Until this is updated (help welcomed including patching a few 10K+
files) , this should be GPL-2.0 instead to avoid confusion and keep
things homogeneous and tidy.

FYI, using only the doc as the reference was brought forward by
Russell King and Christoph Hellwig and in particular with this:

On Thu, Nov 9, 2017 at 5:44 PM, Russell King  wrote:

> I'd be more comfortable if we could have something in the kernel tree
> that identifies the SPDX tags and their meaning, maybe with the
> _standard_ file header for that license included, so there is no
> argument about what any particular SPDX tag means.

Based on this, Thomas Gleixner updated the doc alright following this
important point. So, in case of doubt the doc should be the reference
for this and nothing else. And if there are issue with the doc, then
we can fix it with a patch ;)

CC: Russell King 
CC: Christoph Hellwig 
CC: Thomas Gleixner 

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [linux-sunxi] [PATCH v2 5/6] arm64: allwinner: h6: add the basical Allwinner H6 DTSI file

[Philippe Ombredanne]

Icenowy,

On Mon, Feb 12, 2018 at 12:26 AM, André Przywara <andre.przyw...@arm.com> wrote:
> Hi,
>
> On 03/02/18 15:49, Icenowy Zheng wrote:
>> Allwinner H6 is a new SoC with Cortex-A53 cores from Allwinner, with its
>> memory map fully reworked and some high-speed peripherals (PCIe, USB
>> 3.0) introduced.
>>
>> This commit adds the basical DTSI file of it, including the clock
>> support and UART support.
>
> Checked the MMIO addresses and the interrupt numbers against the manual.
>
>> Signed-off-by: Icenowy Zheng <icen...@aosc.io>
>
> Reviewed-by: Andre Przywara <andre.przyw...@arm.com>
>
> Thanks!
> Andre.
>
>> ---
>> Changes in v2:
>> - Add APB1 clock as PIO's APB clock.
>> - Switched to SPDX license identifier.
>>
>>  arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 178 
>> +++
>>  1 file changed, 178 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi 
>> b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
>> new file mode 100644
>> index ..d4697bb42496
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
>> @@ -0,0 +1,178 @@
>> +/*
>> + * Copyright (C) 2017 Icenowy Zheng <icen...@aosc.io>
>> + *
>> + * SPDX-License-Identifier: (GPL-2.0+ or MIT)
>> + */

Thank you for using SPDX ids: this needs to be on the first line
though! [1] and eventually some special comments style.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [linux-sunxi] [PATCH v2 5/6] arm64: allwinner: h6: add the basical Allwinner H6 DTSI file

[Philippe Ombredanne]

Icenowy,

On Mon, Feb 12, 2018 at 12:26 AM, André Przywara  wrote:
> Hi,
>
> On 03/02/18 15:49, Icenowy Zheng wrote:
>> Allwinner H6 is a new SoC with Cortex-A53 cores from Allwinner, with its
>> memory map fully reworked and some high-speed peripherals (PCIe, USB
>> 3.0) introduced.
>>
>> This commit adds the basical DTSI file of it, including the clock
>> support and UART support.
>
> Checked the MMIO addresses and the interrupt numbers against the manual.
>
>> Signed-off-by: Icenowy Zheng 
>
> Reviewed-by: Andre Przywara 
>
> Thanks!
> Andre.
>
>> ---
>> Changes in v2:
>> - Add APB1 clock as PIO's APB clock.
>> - Switched to SPDX license identifier.
>>
>>  arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 178 
>> +++
>>  1 file changed, 178 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi 
>> b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
>> new file mode 100644
>> index ..d4697bb42496
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
>> @@ -0,0 +1,178 @@
>> +/*
>> + * Copyright (C) 2017 Icenowy Zheng 
>> + *
>> + * SPDX-License-Identifier: (GPL-2.0+ or MIT)
>> + */

Thank you for using SPDX ids: this needs to be on the first line
though! [1] and eventually some special comments style.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/6] genalloc: selftest

[Philippe Ombredanne]

On Sun, Feb 11, 2018 at 4:19 AM, Igor Stoppa <igor.sto...@huawei.com> wrote:
> Introduce a set of macros for writing concise test cases for genalloc.
>
> The test cases are meant to provide regression testing, when working on
> new functionality for genalloc.
>
> Primarily they are meant to confirm that the various allocation strategy
> will continue to work as expected.
>
> The execution of the self testing is controlled through a Kconfig option.
>
> Signed-off-by: Igor Stoppa <igor.sto...@huawei.com>



> --- /dev/null
> +++ b/include/linux/genalloc-selftest.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: GPL-2.0

nit... For a comment in .h this line should be instead its own comment
as the first line:
> +/* SPDX-License-Identifier: GPL-2.0 */



> --- /dev/null
> +++ b/lib/genalloc-selftest.c
> @@ -0,0 +1,400 @@
> +/* SPDX-License-Identifier: GPL-2.0

And for a comment in .c this line should use C++ style as the first line:

> +// SPDX-License-Identifier: GPL-2.0

Please check the docs for this (I know this can feel surprising but
this has been debated at great length on list)

Thank you!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/6] genalloc: selftest

[Philippe Ombredanne]

On Sun, Feb 11, 2018 at 4:19 AM, Igor Stoppa  wrote:
> Introduce a set of macros for writing concise test cases for genalloc.
>
> The test cases are meant to provide regression testing, when working on
> new functionality for genalloc.
>
> Primarily they are meant to confirm that the various allocation strategy
> will continue to work as expected.
>
> The execution of the self testing is controlled through a Kconfig option.
>
> Signed-off-by: Igor Stoppa 



> --- /dev/null
> +++ b/include/linux/genalloc-selftest.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: GPL-2.0

nit... For a comment in .h this line should be instead its own comment
as the first line:
> +/* SPDX-License-Identifier: GPL-2.0 */



> --- /dev/null
> +++ b/lib/genalloc-selftest.c
> @@ -0,0 +1,400 @@
> +/* SPDX-License-Identifier: GPL-2.0

And for a comment in .c this line should use C++ style as the first line:

> +// SPDX-License-Identifier: GPL-2.0

Please check the docs for this (I know this can feel surprising but
this has been debated at great length on list)

Thank you!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH] watchdog: coh901327: make license text and module licence match

[Philippe Ombredanne]

On Sat, Feb 10, 2018 at 10:27 AM, Marcus Folkesson
<marcus.folkes...@gmail.com> wrote:
> Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2
> or later".
>
> See include/linux/module.h:
> "GPL"   [GNU Public License v2 or later]
> "GPL v2"[GNU Public License v2]
>
> When on it, add SPDX identifier tag.
>
> Signed-off-by: Marcus Folkesson <marcus.folkes...@gmail.com>
> ---
>  drivers/watchdog/coh901327_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/coh901327_wdt.c 
> b/drivers/watchdog/coh901327_wdt.c
> index 5d8eb9a30879..7b71e0a3e6cc 100644
> --- a/drivers/watchdog/coh901327_wdt.c
> +++ b/drivers/watchdog/coh901327_wdt.c
> @@ -1,8 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /*
>   * coh901327_wdt.c
>   *
>   * Copyright (C) 2008-2009 ST-Ericsson AB
> - * License terms: GNU General Public License (GPL) version 2
>   * Watchdog driver for the ST-Ericsson AB COH 901 327 IP core
>   * Author: Linus Walleij <linus.wall...@stericsson.com>
>   */
> @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog");
>  module_param(margin, uint, 0);
>  MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)");
>
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS("platform:coh901327-watchdog");

Thank you!

Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>

-- 
Cordially
Philippe Ombredanne

Re: [PATCH] watchdog: coh901327: make license text and module licence match

[Philippe Ombredanne]

On Sat, Feb 10, 2018 at 10:27 AM, Marcus Folkesson
 wrote:
> Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2
> or later".
>
> See include/linux/module.h:
> "GPL"   [GNU Public License v2 or later]
> "GPL v2"[GNU Public License v2]
>
> When on it, add SPDX identifier tag.
>
> Signed-off-by: Marcus Folkesson 
> ---
>  drivers/watchdog/coh901327_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/coh901327_wdt.c 
> b/drivers/watchdog/coh901327_wdt.c
> index 5d8eb9a30879..7b71e0a3e6cc 100644
> --- a/drivers/watchdog/coh901327_wdt.c
> +++ b/drivers/watchdog/coh901327_wdt.c
> @@ -1,8 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /*
>   * coh901327_wdt.c
>   *
>   * Copyright (C) 2008-2009 ST-Ericsson AB
> - * License terms: GNU General Public License (GPL) version 2
>   * Watchdog driver for the ST-Ericsson AB COH 901 327 IP core
>   * Author: Linus Walleij 
>   */
> @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog");
>  module_param(margin, uint, 0);
>  MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)");
>
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS("platform:coh901327-watchdog");

Thank you!

Reviewed-by: Philippe Ombredanne 

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

[Philippe Ombredanne]

On Sat, Feb 10, 2018 at 9:40 AM, Marcel Ziswiler <mar...@ziswiler.com> wrote:

> Yes, I'm already in the process of preparing a separate patch set fixing this
> across all Toradex files. However I'm running this through our legal as well
> first to make absolutely sure it's all proper.

That's the way to go and thank you for this.
Do not hesitate to ping here or privately if there is any legal
concern that comes up.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

[Philippe Ombredanne]

On Sat, Feb 10, 2018 at 9:40 AM, Marcel Ziswiler  wrote:

> Yes, I'm already in the process of preparing a separate patch set fixing this
> across all Toradex files. However I'm running this through our legal as well
> first to make absolutely sure it's all proper.

That's the way to go and thank you for this.
Do not hesitate to ping here or privately if there is any legal
concern that comes up.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 01/11] dt-bindings: clock: Add Actions S900 clock bindings

[Philippe Ombredanne]

Dear Manivannan,

On Sat, Feb 10, 2018 at 3:41 AM, Manivannan Sadhasivam
<manivannan.sadhasi...@linaro.org> wrote:
> Add Actions Semi S900 clock bindings.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org>
> Acked-by: Rob Herring <r...@kernel.org>



> diff --git a/include/dt-bindings/clock/actions,s900-cmu.h 
> b/include/dt-bindings/clock/actions,s900-cmu.h
> new file mode 100644
> index ..2fa94e19922b
> --- /dev/null
> +++ b/include/dt-bindings/clock/actions,s900-cmu.h
> @@ -0,0 +1,139 @@
> +/*
> + * Device Tree binding constants for Actions S900 Clock Management Unit
> + *
> + * Copyright (c) 2014 Actions Semi Inc.
> + * Copyright (c) 2017 Linaro Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */

Would you consider using the new SPDX license ids rather that this
time-tested but rather boring legalese?

The (still new and fresh) license documentation contributed by tglx
--the only maintainer that I know that understands both the innards of
Spectre and Meltdown and the beauty of reStructuredText -- is in:
Documentation/process/license-rules.rst

Practically this means replacing the above by a simple single line and
getting rid of a whopping 8 comment lines!

SPDX-License-Identifier: GPL-2.0+

You get to save a few tree as a bonus if you also do the same for all
Linaro-copyrighted files. Yes this is saving trees because I will use
less paper each time I print a listing of the kernel source code.
Which is something that I rarely if ever do: but somebody must do it
somewhere for sure.

If I do the math: we have ~60K files in the kernel, and say we can
remove roughly 5 lines of legalese per file on average. Each printed
source code page is roughly 60 lines : this will mean a saving of
about 6000 paper sheets saved on each printout! A letter-size paper
ream is 500 pages, about 2.5 Kg and costs about ~$8.  You can extract
about 10K to 20k sheets of paper per tree [1].
Therefore my Fermi estimate is that using shorter legalese in the
kernel will eventually save roughly ONE FULL smaller tree (6K pages)
each time someone prints the kernel code: incredible, right?

Thank  you for helping make the kernel a mostly legalese-free codebase
and saving trees at the same time!

[1] 
https://www.sierraclub.org/sierra/2014-4-july-august/green-life/how-much-paper-does-one-tree-produce
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 01/11] dt-bindings: clock: Add Actions S900 clock bindings

[Philippe Ombredanne]

Dear Manivannan,

On Sat, Feb 10, 2018 at 3:41 AM, Manivannan Sadhasivam
 wrote:
> Add Actions Semi S900 clock bindings.
>
> Signed-off-by: Manivannan Sadhasivam 
> Acked-by: Rob Herring 



> diff --git a/include/dt-bindings/clock/actions,s900-cmu.h 
> b/include/dt-bindings/clock/actions,s900-cmu.h
> new file mode 100644
> index ..2fa94e19922b
> --- /dev/null
> +++ b/include/dt-bindings/clock/actions,s900-cmu.h
> @@ -0,0 +1,139 @@
> +/*
> + * Device Tree binding constants for Actions S900 Clock Management Unit
> + *
> + * Copyright (c) 2014 Actions Semi Inc.
> + * Copyright (c) 2017 Linaro Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */

Would you consider using the new SPDX license ids rather that this
time-tested but rather boring legalese?

The (still new and fresh) license documentation contributed by tglx
--the only maintainer that I know that understands both the innards of
Spectre and Meltdown and the beauty of reStructuredText -- is in:
Documentation/process/license-rules.rst

Practically this means replacing the above by a simple single line and
getting rid of a whopping 8 comment lines!

SPDX-License-Identifier: GPL-2.0+

You get to save a few tree as a bonus if you also do the same for all
Linaro-copyrighted files. Yes this is saving trees because I will use
less paper each time I print a listing of the kernel source code.
Which is something that I rarely if ever do: but somebody must do it
somewhere for sure.

If I do the math: we have ~60K files in the kernel, and say we can
remove roughly 5 lines of legalese per file on average. Each printed
source code page is roughly 60 lines : this will mean a saving of
about 6000 paper sheets saved on each printout! A letter-size paper
ream is 500 pages, about 2.5 Kg and costs about ~$8.  You can extract
about 10K to 20k sheets of paper per tree [1].
Therefore my Fermi estimate is that using shorter legalese in the
kernel will eventually save roughly ONE FULL smaller tree (6K pages)
each time someone prints the kernel code: incredible, right?

Thank  you for helping make the kernel a mostly legalese-free codebase
and saving trees at the same time!

[1] 
https://www.sierraclub.org/sierra/2014-4-july-august/green-life/how-much-paper-does-one-tree-produce
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

[Philippe Ombredanne]

Marcel,

On Sat, Feb 10, 2018 at 2:38 AM, Marcel Ziswiler <mar...@ziswiler.com> wrote:
> From: Marcel Ziswiler <marcel.ziswi...@toradex.com>
>
> Update the copyright period and get rid of some spurious newlines.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswi...@toradex.com>
>
> ---
>
>  arch/arm/boot/dts/tegra124-apalis-eval.dts |  6 ++
>  arch/arm/boot/dts/tegra124-apalis.dtsi | 11 +--
>  2 files changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra124-apalis-eval.dts 
> b/arch/arm/boot/dts/tegra124-apalis-eval.dts
> index f1010cefb993..a6ad759dddb4 100644
> --- a/arch/arm/boot/dts/tegra124-apalis-eval.dts
> +++ b/arch/arm/boot/dts/tegra124-apalis-eval.dts
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright 2016 Toradex AG
> + * Copyright 2016-2018 Toradex AG
>   *
>   * This file is dual-licensed: you can use it either under the terms
>   * of the GPL or the X11 license, at your option. Note that this dual

Since you are fixing copyrights, would you consider also fixing the
license to use a proper SPDX Id instead?

It would be super gentle of you!

And you will get extra good karma point if you feel like doing the
same for every Toradex-copyrighted files ;)

The (still new and fresh) license documentation contributed by tglx
--the only real-time docu-mentalist-- is in:
Documentation/process/license-rules.rst

Thanks!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

[Philippe Ombredanne]

Marcel,

On Sat, Feb 10, 2018 at 2:38 AM, Marcel Ziswiler  wrote:
> From: Marcel Ziswiler 
>
> Update the copyright period and get rid of some spurious newlines.
>
> Signed-off-by: Marcel Ziswiler 
>
> ---
>
>  arch/arm/boot/dts/tegra124-apalis-eval.dts |  6 ++
>  arch/arm/boot/dts/tegra124-apalis.dtsi | 11 +--
>  2 files changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra124-apalis-eval.dts 
> b/arch/arm/boot/dts/tegra124-apalis-eval.dts
> index f1010cefb993..a6ad759dddb4 100644
> --- a/arch/arm/boot/dts/tegra124-apalis-eval.dts
> +++ b/arch/arm/boot/dts/tegra124-apalis-eval.dts
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright 2016 Toradex AG
> + * Copyright 2016-2018 Toradex AG
>   *
>   * This file is dual-licensed: you can use it either under the terms
>   * of the GPL or the X11 license, at your option. Note that this dual

Since you are fixing copyrights, would you consider also fixing the
license to use a proper SPDX Id instead?

It would be super gentle of you!

And you will get extra good karma point if you feel like doing the
same for every Toradex-copyrighted files ;)

The (still new and fresh) license documentation contributed by tglx
--the only real-time docu-mentalist-- is in:
Documentation/process/license-rules.rst

Thanks!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings

[Philippe Ombredanne]

On Fri, Feb 9, 2018 at 8:00 AM, Yixun Lan <yixun@amlogic.com> wrote:
> Add dt-bindings headers for the Meson-AXG's AO clock and
> reset controller.
>
> CC: <devicet...@vger.kernel.org>
> Signed-off-by: Yixun Lan <yixun@amlogic.com>
> ---
>  include/dt-bindings/clock/axg-aoclkc.h | 26 ++
>  include/dt-bindings/reset/axg-aoclkc.h | 20 
>  2 files changed, 46 insertions(+)
>  create mode 100644 include/dt-bindings/clock/axg-aoclkc.h
>  create mode 100644 include/dt-bindings/reset/axg-aoclkc.h
>
> diff --git a/include/dt-bindings/clock/axg-aoclkc.h 
> b/include/dt-bindings/clock/axg-aoclkc.h
> new file mode 100644
> index ..78683abb4247
> --- /dev/null
> +++ b/include/dt-bindings/clock/axg-aoclkc.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */

nit... BSD is not a valid license id as documented in LICENSES [1] :
please use one of these:
BSD-2-Clause or BSD-3-Clause

Thank you!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings

[Philippe Ombredanne]

On Fri, Feb 9, 2018 at 8:00 AM, Yixun Lan  wrote:
> Add dt-bindings headers for the Meson-AXG's AO clock and
> reset controller.
>
> CC: 
> Signed-off-by: Yixun Lan 
> ---
>  include/dt-bindings/clock/axg-aoclkc.h | 26 ++
>  include/dt-bindings/reset/axg-aoclkc.h | 20 
>  2 files changed, 46 insertions(+)
>  create mode 100644 include/dt-bindings/clock/axg-aoclkc.h
>  create mode 100644 include/dt-bindings/reset/axg-aoclkc.h
>
> diff --git a/include/dt-bindings/clock/axg-aoclkc.h 
> b/include/dt-bindings/clock/axg-aoclkc.h
> new file mode 100644
> index ..78683abb4247
> --- /dev/null
> +++ b/include/dt-bindings/clock/axg-aoclkc.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */

nit... BSD is not a valid license id as documented in LICENSES [1] :
please use one of these:
BSD-2-Clause or BSD-3-Clause

Thank you!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

[Philippe Ombredanne]

On Fri, Feb 9, 2018 at 1:35 AM, Joe Perches <j...@perches.com> wrote:
> On Fri, 2018-02-02 at 13:18 -0800, Joe Perches wrote:
>> On Fri, 2018-02-02 at 09:40 -0600, Rob Herring wrote:
>> > Add SPDX license tag check based on the rules defined in
>> > Documentation/process/license-rules.rst. To summarize, SPDX license tags
>> > should be on the 1st line (or 2nd line in scripts) using the appropriate
>> > comment style for the file type.
>> >
>> > Cc: Andy Whitcroft <a...@canonical.com>
>> > Cc: Joe Perches <j...@perches.com>
>> > Cc: Thomas Gleixner <t...@linutronix.de>
>> > Cc: Philippe Ombredanne <pombreda...@nexb.com>
>> > Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
>> > Signed-off-by: Rob Herring <r...@kernel.org>
>>
>> Signed-off-by: Joe Perches <j...@perches.com>
>
> Andrew, would you pick this up please?
>
>> > ---
>> > v6:
>> > - Dropped script extension check and only look for #!/... on 1st line. A
>> >   text executable file was not reliable either.
>> > - Support .awk and .tc which may or may not have a #!/.
>> > - Fixed a typo in script "#!" regex and also match on first /.
>> > - Add Greg's ack.
>> >
>> >  scripts/checkpatch.pl | 27 +++
>> >  1 file changed, 27 insertions(+)
>> >
>> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> > index ba03f17ff662..6db245e5f93b 100755
>> > --- a/scripts/checkpatch.pl
>> > +++ b/scripts/checkpatch.pl
>> > @@ -2225,6 +2225,8 @@ sub process {
>> >
>> > my $camelcase_file_seeded = 0;
>> >
>> > +   my $checklicenseline = 1;
>> > +
>> > sanitise_line_reset();
>> > my $line;
>> > foreach my $rawline (@rawlines) {
>> > @@ -2416,6 +2418,7 @@ sub process {
>> > } else {
>> > $check = $check_orig;
>> > }
>> > +   $checklicenseline = 1;
>> > next;
>> > }
>> >
>> > @@ -2866,6 +2869,30 @@ sub process {
>> > }
>> > }
>> >
>> > +# check for using SPDX license tag at beginning of files
>> > +   if ($realline == $checklicenseline) {
>> > +   if ($rawline =~ /^[ \+]\s*\#\!\s*\//) {
>> > +   $checklicenseline = 2;
>> > +   } elsif ($rawline =~ /^\+/) {
>> > +   my $comment = "";
>> > +   if ($realfile =~ /\.(h|s|S)$/) {
>> > +   $comment = '/*';
>> > +   } elsif ($realfile =~ /\.(c|dts|dtsi)$/) {
>> > +   $comment = '//';
>> > +   } elsif (($checklicenseline == 2) || $realfile 
>> > =~ /\.(sh|pl|py|awk|tc)$/) {
>> > +   $comment = '#';
>> > +   } elsif ($realfile =~ /\.rst$/) {
>> > +   $comment = '..';
>> > +   }
>> > +
>> > +   if ($comment !~ /^$/ &&
>> > +   $rawline !~ /^\+\Q$comment\E 
>> > SPDX-License-Identifier: /) {
>> > +   WARN("SPDX_LICENSE_TAG",
>> > +"Missing or malformed 
>> > SPDX-License-Identifier tag in line $checklicenseline\n" . $herecurr);
>> > +   }
>> > +   }
>> > +   }
>> > +
>> >  # check we are in a valid source file if not then ignore this hunk
>> > next if ($realfile !~ /\.(h|c|s|S|sh|dtsi|dts)$/);
>> >

BTW I forgot this if you like to add it:

Acked-by: Philippe Ombredanne <pombreda...@nexb.com>

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

[Philippe Ombredanne]

On Fri, Feb 9, 2018 at 1:35 AM, Joe Perches  wrote:
> On Fri, 2018-02-02 at 13:18 -0800, Joe Perches wrote:
>> On Fri, 2018-02-02 at 09:40 -0600, Rob Herring wrote:
>> > Add SPDX license tag check based on the rules defined in
>> > Documentation/process/license-rules.rst. To summarize, SPDX license tags
>> > should be on the 1st line (or 2nd line in scripts) using the appropriate
>> > comment style for the file type.
>> >
>> > Cc: Andy Whitcroft 
>> > Cc: Joe Perches 
>> > Cc: Thomas Gleixner 
>> > Cc: Philippe Ombredanne 
>> > Acked-by: Greg Kroah-Hartman 
>> > Signed-off-by: Rob Herring 
>>
>> Signed-off-by: Joe Perches 
>
> Andrew, would you pick this up please?
>
>> > ---
>> > v6:
>> > - Dropped script extension check and only look for #!/... on 1st line. A
>> >   text executable file was not reliable either.
>> > - Support .awk and .tc which may or may not have a #!/.
>> > - Fixed a typo in script "#!" regex and also match on first /.
>> > - Add Greg's ack.
>> >
>> >  scripts/checkpatch.pl | 27 +++
>> >  1 file changed, 27 insertions(+)
>> >
>> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> > index ba03f17ff662..6db245e5f93b 100755
>> > --- a/scripts/checkpatch.pl
>> > +++ b/scripts/checkpatch.pl
>> > @@ -2225,6 +2225,8 @@ sub process {
>> >
>> > my $camelcase_file_seeded = 0;
>> >
>> > +   my $checklicenseline = 1;
>> > +
>> > sanitise_line_reset();
>> > my $line;
>> > foreach my $rawline (@rawlines) {
>> > @@ -2416,6 +2418,7 @@ sub process {
>> > } else {
>> > $check = $check_orig;
>> > }
>> > +   $checklicenseline = 1;
>> > next;
>> > }
>> >
>> > @@ -2866,6 +2869,30 @@ sub process {
>> > }
>> > }
>> >
>> > +# check for using SPDX license tag at beginning of files
>> > +   if ($realline == $checklicenseline) {
>> > +   if ($rawline =~ /^[ \+]\s*\#\!\s*\//) {
>> > +   $checklicenseline = 2;
>> > +   } elsif ($rawline =~ /^\+/) {
>> > +   my $comment = "";
>> > +   if ($realfile =~ /\.(h|s|S)$/) {
>> > +   $comment = '/*';
>> > +   } elsif ($realfile =~ /\.(c|dts|dtsi)$/) {
>> > +   $comment = '//';
>> > +   } elsif (($checklicenseline == 2) || $realfile 
>> > =~ /\.(sh|pl|py|awk|tc)$/) {
>> > +   $comment = '#';
>> > +   } elsif ($realfile =~ /\.rst$/) {
>> > +   $comment = '..';
>> > +   }
>> > +
>> > +   if ($comment !~ /^$/ &&
>> > +   $rawline !~ /^\+\Q$comment\E 
>> > SPDX-License-Identifier: /) {
>> > +   WARN("SPDX_LICENSE_TAG",
>> > +"Missing or malformed 
>> > SPDX-License-Identifier tag in line $checklicenseline\n" . $herecurr);
>> > +   }
>> > +   }
>> > +   }
>> > +
>> >  # check we are in a valid source file if not then ignore this hunk
>> > next if ($realfile !~ /\.(h|c|s|S|sh|dtsi|dts)$/);
>> >

BTW I forgot this if you like to add it:

Acked-by: Philippe Ombredanne 

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

[Philippe Ombredanne]

Joe,

On Thu, Feb 8, 2018 at 6:24 PM, Joe Perches <j...@perches.com> wrote:
> On Thu, 2018-02-08 at 15:35 +0100, Philippe Ombredanne wrote:
>> However checking that licenses ids are known and listed in the kernel
>> doc is essential IMHO to avoid drift and insulate the kernel from SPDX
>> updates. Case in point  the new SPDX "GPL-2.0-only" is NOT what was
>> documented by tglx and therefore should not be used and banned until
>> we update the doc accordingly. and until we update ALL the GPL-2.0 to
>> GPL-2.0-only eventually which is best done at once.
>
> Agree and I've attached what I believe to be a
> reasonable script for that conversion only after
> LICENSE directories are updated with the
> appropriate and license files and after
> Documentation/process/license-rules.rst is modified.

Excellent and clean!

>> Otherwise, this is
>> going to be a total mess on top of a complicated topic that requires
>> quite a bit of maintainer energy!
>
> There will always be some energy requirement and
> no doubt some legal advice involvement too.
>
> In another vein:
>
> The existing license files in spdx.org seem
> somewhat sloppily edited and perhaps have less
> clarity and precision than desired.
>
> For instance:
>
> If the newer SPDX descriptor "GPL-2.0-only" is to
> be used, why does this license URL:
>
> https://spdx.org/licenses/GPL-2.0-only.html
>
> still contain the phrase ", or (at your option) any later version".
>
> The current diff between GPL-2.0-only and GPL-2.0-or-later:
>
> $ wget -q https://spdx.org/licenses/GPL-2.0-only.html
> $ wget -q https://spdx.org/licenses/GPL-2.0-or-later.html
> $ diff -U0 GPL-2.0-only.html GPL-2.0-or-later.html
> --- GPL-2.0-only.html   2017-12-28 12:17:20.0 -0800
> +++ GPL-2.0-or-later.html   2017-12-28 12:17:22.0 -0800
> @@ -15 +15 @@
> -GNU General Public License v2.0 only | Software Package Data 
> Exchange (SPDX)
> +GNU General Public License v2.0 or later | Software Package Data 
> Exchange (SPDX)
> @@ -141 +141 @@
> -  GNU General Public License v2.0 only
> +  GNU General Public License v2.0 or later
> @@ -144 +144 @@
> -  GNU 
> General Public License v2.0 only
> +  GNU 
> General Public License v2.0 or later
> @@ -147 +147 @@
> -   property="spdx:licenseId">GPL-2.0-only
> +   property="spdx:licenseId">GPL-2.0-or-later
> @@ -160 +160 @@
> -  This license was released: June 1991 
> This refers to when this GPL 2.0 only is being used (as opposed to GPLv2 or 
> later).
> +  This license was released: June 
> 1991
> @@ -679 +679,2 @@
> -as published by the Free Software Foundation; version 2.
> +   as published by the Free Software Foundation; version 2
> +   or any later version.
>
>
> I am not a lawyer, this is not legal advice, etc... but:
>
> The "1991 This" use in the -only file seems be missing
> a period.
>
> In any case it is awkwardly phrased as "or later" perhaps
> should not be referenced at all.
>
> The GPL 2.0 license as published by the Free Software
> Foundation includes the option for using later versions.
>
> Perhaps the SPDX -only licenses should be more specific
> when it uses the phrase "as published by the Free
> Software Foundation; version ." to specifically
> exclude the option of any later version.

Good points and this is why we have and need to use the kernel doc as
the stable reference IMHO.

FWIW, I have raised a ticket with SPDX [2] so that the issue you have
found can be properly fixed there.  Also, I think this  (the new -only
license ids that I think we should not yet use) has been reviewed in
details by the SPDX legal group and by the FSF. At least rms posted an
article about it last December [2] ?

[1] https://github.com/spdx/license-list-XML/issues/610
[2] 
https://web.archive.org/web/20171221220428/https://www.gnu.org/licenses/identify-licenses-clearly.html

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

[Philippe Ombredanne]

Joe,

On Thu, Feb 8, 2018 at 6:24 PM, Joe Perches  wrote:
> On Thu, 2018-02-08 at 15:35 +0100, Philippe Ombredanne wrote:
>> However checking that licenses ids are known and listed in the kernel
>> doc is essential IMHO to avoid drift and insulate the kernel from SPDX
>> updates. Case in point  the new SPDX "GPL-2.0-only" is NOT what was
>> documented by tglx and therefore should not be used and banned until
>> we update the doc accordingly. and until we update ALL the GPL-2.0 to
>> GPL-2.0-only eventually which is best done at once.
>
> Agree and I've attached what I believe to be a
> reasonable script for that conversion only after
> LICENSE directories are updated with the
> appropriate and license files and after
> Documentation/process/license-rules.rst is modified.

Excellent and clean!

>> Otherwise, this is
>> going to be a total mess on top of a complicated topic that requires
>> quite a bit of maintainer energy!
>
> There will always be some energy requirement and
> no doubt some legal advice involvement too.
>
> In another vein:
>
> The existing license files in spdx.org seem
> somewhat sloppily edited and perhaps have less
> clarity and precision than desired.
>
> For instance:
>
> If the newer SPDX descriptor "GPL-2.0-only" is to
> be used, why does this license URL:
>
> https://spdx.org/licenses/GPL-2.0-only.html
>
> still contain the phrase ", or (at your option) any later version".
>
> The current diff between GPL-2.0-only and GPL-2.0-or-later:
>
> $ wget -q https://spdx.org/licenses/GPL-2.0-only.html
> $ wget -q https://spdx.org/licenses/GPL-2.0-or-later.html
> $ diff -U0 GPL-2.0-only.html GPL-2.0-or-later.html
> --- GPL-2.0-only.html   2017-12-28 12:17:20.0 -0800
> +++ GPL-2.0-or-later.html   2017-12-28 12:17:22.0 -0800
> @@ -15 +15 @@
> -GNU General Public License v2.0 only | Software Package Data 
> Exchange (SPDX)
> +GNU General Public License v2.0 or later | Software Package Data 
> Exchange (SPDX)
> @@ -141 +141 @@
> -  GNU General Public License v2.0 only
> +  GNU General Public License v2.0 or later
> @@ -144 +144 @@
> -  GNU 
> General Public License v2.0 only
> +  GNU 
> General Public License v2.0 or later
> @@ -147 +147 @@
> -   property="spdx:licenseId">GPL-2.0-only
> +   property="spdx:licenseId">GPL-2.0-or-later
> @@ -160 +160 @@
> -  This license was released: June 1991 
> This refers to when this GPL 2.0 only is being used (as opposed to GPLv2 or 
> later).
> +  This license was released: June 
> 1991
> @@ -679 +679,2 @@
> -as published by the Free Software Foundation; version 2.
> +   as published by the Free Software Foundation; version 2
> +   or any later version.
>
>
> I am not a lawyer, this is not legal advice, etc... but:
>
> The "1991 This" use in the -only file seems be missing
> a period.
>
> In any case it is awkwardly phrased as "or later" perhaps
> should not be referenced at all.
>
> The GPL 2.0 license as published by the Free Software
> Foundation includes the option for using later versions.
>
> Perhaps the SPDX -only licenses should be more specific
> when it uses the phrase "as published by the Free
> Software Foundation; version ." to specifically
> exclude the option of any later version.

Good points and this is why we have and need to use the kernel doc as
the stable reference IMHO.

FWIW, I have raised a ticket with SPDX [2] so that the issue you have
found can be properly fixed there.  Also, I think this  (the new -only
license ids that I think we should not yet use) has been reviewed in
details by the SPDX legal group and by the FSF. At least rms posted an
article about it last December [2] ?

[1] https://github.com/spdx/license-list-XML/issues/610
[2] 
https://web.archive.org/web/20171221220428/https://www.gnu.org/licenses/identify-licenses-clearly.html

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

[Philippe Ombredanne]

On Thu, Feb 8, 2018 at 3:58 PM, Philippe Cornu <philippe.co...@st.com> wrote:
> Add SPDX identifiers to the Synopsys DesignWare MIPI DSI
> host controller driver.
>
> Signed-off-by: Philippe Cornu <philippe.co...@st.com>
> ---
> Changes in v2: Update to "GPL-2.0+" following comments from Laurent
> Pinchart, Benjamin Gaignard & Philippe Ombredanne.
>
>  drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +-
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c 
> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 7bac101c285c..99f0e4f51716 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -1,12 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0+
>  /*
>   * Copyright (c) 2016, Fuzhou Rockchip Electronics Co., Ltd
>   * Copyright (C) STMicroelectronics SA 2017
>   *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
>   * Modified by Philippe Cornu <philippe.co...@st.com>
>   * This generic Synopsys DesignWare MIPI DSI host driver is based on the
>   * Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs.
> --
> 2.15.1
>

Thank you.

Acked-by: Philippe Ombredanne <pombreda...@nexb.com>

Re: [PATCH v2] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

[Philippe Ombredanne]

On Thu, Feb 8, 2018 at 3:58 PM, Philippe Cornu  wrote:
> Add SPDX identifiers to the Synopsys DesignWare MIPI DSI
> host controller driver.
>
> Signed-off-by: Philippe Cornu 
> ---
> Changes in v2: Update to "GPL-2.0+" following comments from Laurent
> Pinchart, Benjamin Gaignard & Philippe Ombredanne.
>
>  drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +-
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c 
> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 7bac101c285c..99f0e4f51716 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -1,12 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0+
>  /*
>   * Copyright (c) 2016, Fuzhou Rockchip Electronics Co., Ltd
>   * Copyright (C) STMicroelectronics SA 2017
>   *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
>   * Modified by Philippe Cornu 
>   * This generic Synopsys DesignWare MIPI DSI host driver is based on the
>   * Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs.
> --
> 2.15.1
>

Thank you.

Acked-by: Philippe Ombredanne 

Re: [PATCH v2 05/16] arm64: dts: mt7622: add PMIC MT6380 related nodes

[Philippe Ombredanne]

Sean,

On Tue, Feb 6, 2018 at 10:52 AM,  <sean.w...@mediatek.com> wrote:
> From: Sean Wang <sean.w...@mediatek.com>
>
> Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380
> regulator nodes in an alone file to allow similar boards using MT6380
> able to resue the configuration.
>
> Signed-off-by: Sean Wang <sean.w...@mediatek.com>
> Cc: Mark Brown <broo...@kernel.org>
> Cc: Matthias Brugger <matthias@gmail.com>
> Cc: Philippe Ombredanne <pombreda...@nexb.com>

Thank you for the use of SPDX licenses ids!

Acked-by: Philippe Ombredanne <pombreda...@nexb.com>