Re: [PATCH 5.4 00/73] 5.4.114-rc1 review
On 2021/4/19 21:05, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.114 release. There are 73 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 21 Apr 2021 13:05:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.114-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.4.114-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.114-rc1 Commit: c509b45704fd663fc59405e98d29d7f06eaae4b5 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 5764 passed: 5764 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 5764 passed: 5764 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH -next] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static
Hi Santosh,
Thanks for your review, and sorry for my mistake. I will send the v2 soon.
On 2021/4/20 14:35, Santosh Sivaraj wrote:
Hi Zou,
Zou Wei writes:
The sparse tool complains as follows:
tools/testing/nvdimm/test/iomap.c:65:14: warning:
symbol '__nfit_test_ioremap' was not declared. Should it be static?
This symbol is not used outside of security.c, so this
s/security.c/iomap.c/
Thanks,
Santosh
commit marks it static.
Reported-by: Hulk Robot
Signed-off-by: Zou Wei
---
tools/testing/nvdimm/test/iomap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/nvdimm/test/iomap.c
b/tools/testing/nvdimm/test/iomap.c
index c62d372..ed563bd 100644
--- a/tools/testing/nvdimm/test/iomap.c
+++ b/tools/testing/nvdimm/test/iomap.c
@@ -62,7 +62,7 @@ struct nfit_test_resource *get_nfit_res(resource_size_t
resource)
}
EXPORT_SYMBOL(get_nfit_res);
-void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
+static void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long
size,
void __iomem *(*fallback_fn)(resource_size_t, unsigned long))
{
struct nfit_test_resource *nfit_res = get_nfit_res(offset);
--
2.6.2
___
Linux-nvdimm mailing list -- linux-nvd...@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
.
Re: [PATCH 5.10 00/25] 5.10.31-rc1 review
On 2021/4/15 22:47, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.31 release. There are 25 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 17 Apr 2021 14:44:01 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.31-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.10.31-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.31-rc1 Commit: 32f5704a0a4f7dcc8aa74a49dbcce359d758f6d5 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 5764 passed: 5764 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 5764 passed: 5764 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 4.14 00/68] 4.14.231-rc1 review
On 2021/4/15 22:46, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.231 release. There are 68 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 17 Apr 2021 14:44:01 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.231-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Tested on x86 for 4.14.231-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.14.y Version: 4.14.231-rc1 Commit: 520c87617485a8885f18d5cb9d70076199e37b43 Compiler: gcc version 7.3.0 (GCC) x86: Testcase Result Summary: total: 5711 passed: 5711 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 4.19 00/13] 4.19.188-rc1 review
On 2021/4/15 22:47, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.188 release. There are 13 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 17 Apr 2021 14:44:01 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.188-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 4.19.188-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.188-rc1 Commit: 9f5de887b160253cf03d6ae91e72ba7dbd4a2317 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 5723 passed: 5723 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 5723 passed: 5723 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.4 00/18] 5.4.113-rc1 review
On 2021/4/15 22:47, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.113 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 17 Apr 2021 14:44:01 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.113-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.4.113-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.113-rc1 Commit: 0d80f6c61d6ba21b3cb64eae72b8485dd96b5a94 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 5764 passed: 5764 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 5764 passed: 5764 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: Linux 5.4.112
On 2021/4/14 14:48, Greg Kroah-Hartman wrote: I'm announcing the release of the 5.4.112 kernel. All users of the 5.4 kernel series must upgrade. The updated 5.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h Tested on arm64 and x86 for 5.4.112, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.112 Commit: 8f55ad4daf001b6ee8ddf672e14475a35403b258 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 5764 passed: 5764 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 5764 passed: 5764 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: Linux 4.19.187
On 2021/4/14 14:40, Greg Kroah-Hartman wrote: I'm announcing the release of the 4.19.187 kernel. All users of the 4.19 kernel series must upgrade. The updated 4.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h Tested on arm64 and x86 for 4.19.187, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.187 Commit: 0f1b4cb77d7f5a442b03f8ad597768b422e8ec58 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 5723 passed: 5723 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 5723 passed: 5723 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: Linux 5.10.30
On 2021/4/14 14:54, Greg Kroah-Hartman wrote: I'm announcing the release of the 5.10.30 kernel. All users of the 5.10 kernel series must upgrade. The updated 5.10.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.10.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h Tested on arm64 and x86 for 5.10.30, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.30 Commit: 1e798745fa8ef91ffe4fd38d443f9d44b59e3cb3 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 5764 passed: 5764 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 5764 passed: 5764 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 4.19 00/66] 4.19.187-rc1 review
On 2021/4/12 16:40, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.187 release. There are 66 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 14 Apr 2021 08:39:44 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.187-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 4.19.187-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.187-rc1 Commit: 85bc28045cdbb9576907965c761445aaece4f5ad Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 5223 passed: 5223 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 5223 passed: 5223 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.4 000/111] 5.4.112-rc1 review
On 2021/4/12 16:39, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.112 release. There are 111 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 14 Apr 2021 08:39:44 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.112-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.4.112-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.112-rc1 Commit: f9b2de2cddd4601c5d2f2947fc5cebb7dbecd266 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 5264 passed: 5264 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 5264 passed: 5264 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 000/188] 5.10.30-rc1 review
On 2021/4/12 16:38, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.30 release. There are 188 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 14 Apr 2021 08:39:44 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.30-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.10.30-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.30-rc1 Commit: 8ac4b1deedaa507b5d0f46316e7f32004dd99cd1 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 5264 passed: 5264 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 5264 passed: 5264 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 00/41] 5.10.29-rc1 review
On 2021/4/9 17:53, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.29 release. There are 41 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 11 Apr 2021 09:52:52 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.29-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.10.29-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.29-rc1 Commit: 18f507c37f338c5d30f58839060d3af0d8504162 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.4 00/23] 5.4.111-rc1 review
On 2021/4/9 17:53, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.111 release. There are 23 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 11 Apr 2021 09:52:52 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.111-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.4.111-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.111-rc1 Commit: 9b00696cdc423c6b92ee4d7cea65858137f8456f Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: Linux 5.10.28
On 2021/4/7 21:17, Greg Kroah-Hartman wrote: I'm announcing the release of the 5.10.28 kernel. All users of the 5.10 kernel series must upgrade. The updated 5.10.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.10.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h Tested on arm64 and x86 for 5.10.28, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.28 Commit: ecdfb9d70fb8c4d7dd9a5fa28c675b4ebe705f85 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: Linux 4.19.185
On 2021/4/7 19:16, Greg Kroah-Hartman wrote: I'm announcing the release of the 4.19.185 kernel. All users of the 4.19 kernel series must upgrade. The updated 4.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h Tested on arm64 and x86 for 4.19.185, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.185 Commit: b4454811f122c6a0a330ced6b854e6ef32c37857 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4679 passed: 4679 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4679 passed: 4679 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: Linux 4.14.229
On 2021/4/7 19:16, Greg Kroah-Hartman wrote: I'm announcing the release of the 4.14.229 kernel. All users of the 4.14 kernel series must upgrade. The updated 4.14.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.14.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h Tested on x86 for 4.14.229, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.14.y Version: 4.14.229 Commit: 0cc244011f40280b78fc344d5c2aac5a0c659f77 Compiler: gcc version 7.3.0 (GCC) x86: Testcase Result Summary: total: 4667 passed: 4667 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: Linux 5.4.110
On 2021/4/7 21:02, Greg Kroah-Hartman wrote: I'm announcing the release of the 5.4.110 kernel. All users of the 5.4 kernel series must upgrade. The updated 5.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h Tested on arm64 and x86 for 5.4.110, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.110 Commit: 59c8e332926875d337f426fde14fec986faab414 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 4.19 00/56] 4.19.185-rc1 review
On 2021/4/5 16:53, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.185 release. There are 56 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 07 Apr 2021 08:50:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.185-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 4.19.185-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.185-rc1 Commit: e80ef2122d5c0531670cb281f5beea2cb469aee1 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4679 passed: 4679 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4679 passed: 4679 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 000/126] 5.10.28-rc1 review
On 2021/4/5 16:52, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.28 release. There are 126 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 07 Apr 2021 08:50:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.28-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.10.28-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.28-rc1 Commit: 17879c574df0acdfddd69065b191a3c1b1f00d48 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 4.14 00/52] 4.14.229-rc1 review
On 2021/4/5 16:53, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.229 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 07 Apr 2021 08:50:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.229-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Tested on x86 for 4.14.229-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.14.y Version: 4.14.229-rc1 Commit: 9d1c6513551e6928da195e22c6b32ed0adf42593 Compiler: gcc version 7.3.0 (GCC) x86: Testcase Result Summary: total: 4667 passed: 4667 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.4 00/74] 5.4.110-rc1 review
On 2021/4/5 16:53, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.110 release. There are 74 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 07 Apr 2021 08:50:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.110-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.4.110-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.110-rc1 Commit: c6f7c5a01d5a9e0d0cfb721249d5378de5f00310 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.4 000/111] 5.4.109-rc1 review
On 2021/3/29 15:57, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.109 release. There are 111 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 31 Mar 2021 07:55:56 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.109-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.4.109-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.109-rc1 Commit: 7b78fa4bf15f02997c4dba22fe2bf2ca8aa9906f Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 000/219] 5.10.27-rc2 review
On 2021/3/29 18:14, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.27 release. There are 219 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 31 Mar 2021 10:13:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.27-rc2.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.10.27-rc2, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.27-rc2 Commit: 8c8bcec351223764ccc3ab7551540172989b5194 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: Linux 4.19.183
On 2021/3/24 18:23, Greg Kroah-Hartman wrote: I'm announcing the release of the 4.19.183 kernel. All users of the 4.19 kernel series must upgrade. The updated 4.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, Tested on arm64 and x86 for 4.19.183, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.183 Commit: 78fec1611cbf7b0bdaddfdbf174a3a2463663bff Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4679 passed: 4679 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4679 passed: 4679 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: Linux 4.14.227
On 2021/3/24 18:23, Greg Kroah-Hartman wrote: I'm announcing the release of the 4.14.227 kernel. All users of the 4.14 kernel series must upgrade. The updated 4.14.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.14.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h Tested on x86 for 4.14.227, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.14.y Version: 4.14.227 Commit: 670d6552eda8ff0c5f396d3d6f0174237917c66c Compiler: gcc version 7.3.0 (GCC) x86: Testcase Result Summary: total: 4667 passed: 4667 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: Linux 5.4.108
On 2021/3/24 18:42, Greg Kroah-Hartman wrote: I'm announcing the release of the 5.4.108 kernel. All users of the 5.4 kernel series must upgrade. The updated 5.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h Tested on arm64 and x86 for 5.4.108, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.108 Commit: b90344f7d6000deba0709d75225f30cbf79ec2f0 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: Linux 5.10.26
On 2021/3/25 16:28, Greg Kroah-Hartman wrote: I'm announcing the release of the 5.10.26 kernel. All users of the 5.10 kernel series must upgrade. The updated 5.10.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.10.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h Tested on arm64 and x86 for 5.10.26, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.26 Commit: 856cd02bbdd412bf91ce327a3c97c52066f11c79 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 000/150] 5.10.26-rc3 review
On 2021/3/24 17:40, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.26 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri, 26 Mar 2021 09:33:54 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.26-rc3.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.10.26-rc3, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.26-rc3 Commit: f6bd595b6fdae1933a752242cfb77a1a0bc3117d Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4720 passed: 4720 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 4.14 00/43] 4.14.227-rc1 review
On 2021/3/22 20:28, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.227 release. There are 43 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 24 Mar 2021 12:19:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.227-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Tested on x86 for 4.14.227-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.14.y Version: 4.14.227-rc1 Commit: dbfdb55a0970570a02a8d7bb6abc2e4db71218c8 Compiler: gcc version 7.3.0 (GCC) x86: Testcase Result Summary: total: 4667 passed: 4667 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 4.19 00/43] 4.19.183-rc1 review
On 2021/3/22 20:28, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.183 release. There are 43 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 24 Mar 2021 12:19:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.183-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 4.19.183-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.183-rc1 Commit: 155590e98805144ae9800805ca98d3edcd2228de Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4688 passed: 4688 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4688 passed: 4688 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 000/156] 5.10.26-rc2 review
On 2021/3/22 23:19, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.26 release. There are 156 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 24 Mar 2021 15:18:19 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.26-rc2.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on x86 for 5.10.26-rc2, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.26-rc2 Commit: deabac90f919203307e6eee2606366bdb19bbe93 Compiler: gcc version 7.3.0 (GCC) x86: Testcase Result Summary: total: 4721 passed: 4721 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.4 00/60] 5.4.108-rc1 review
On 2021/3/22 20:27, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.108 release. There are 60 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 24 Mar 2021 12:19:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.108-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.4.107-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.107-rc1 Commit: 5094cb203da71ac5da8f1715dec97fe69fbfb326 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4729 passed: 4729 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4729 passed: 4729 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 000/156] 5.10.26-rc2 review
On 2021/3/22 23:19, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.26 release. There are 156 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 24 Mar 2021 15:18:19 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.26-rc2.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Arch: arm64 Version: 5.10.26-rc2 Commit: deabac90f919203307e6eee2606366bdb19bbe93 Compiler: gcc version 7.3.0 (GCC) Kernel build failed, error log: kernel/rcu/tree.c:683:2: error: implicit declaration of function ‘IRQ_WORK_INIT’; did you mean ‘QSTR_INIT’? [-Werror=implicit-function-declaration] IRQ_WORK_INIT(late_wakeup_func); ^ QSTR_INIT kernel/rcu/tree.c:683:2: error: invalid initializer Tested-by: Hulk Robot
Re: [PATCH 5.4 00/18] 5.4.107-rc1 review
On 2021/3/19 20:18, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.107 release. There are 18 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 21 Mar 2021 12:17:37 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.107-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.4.107-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.107-rc1 Commit: 8a800acdf26f05d289c05e416591b6b18917b044 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4729 passed: 4729 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4729 passed: 4729 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 4.19 0/8] 4.19.182-rc1 review
On 2021/3/19 20:18, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.182 release. There are 8 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 21 Mar 2021 12:17:37 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.182-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 4.19.182-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.182-rc1 Commit: 7281e11121f6fb47ea1e757b7781c5c15e3781fe Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4688 passed: 4688 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4688 passed: 4688 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 00/13] 5.10.25-rc1 review
On 2021/3/19 20:18, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.25 release. There are 13 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 21 Mar 2021 12:17:37 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.25-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.10.25, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.25 Commit: 3ba56f490c7ab26974806f8c2f14fc49652efe10 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4721 passed: 4721 failed: 0 timeout: 0 x86: Testcase Result Summary: total: 4721 passed: 4721 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 000/290] 5.10.24-rc1 review
On 2021/3/15 21:51, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 5.10.24 release. There are 290 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 17 Mar 2021 13:55:02 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.24-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.10.24, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.24 Commit: 05d125f7524e9ad200375c52799575184755d340 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4721 passed: 4720 failed: 0 timeout: 1 Timeout cases : ltp dio29 The only one timeout case is caused by the test machine was very busy and timed out, no kernel failures x86: Testcase Result Summary: total: 4721 passed: 4721 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 4.19 000/120] 4.19.181-rc1 review
On 2021/3/15 21:55, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 4.19.181 release. There are 120 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 17 Mar 2021 13:57:02 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.181-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Tested on x86 for 4.19.181, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.181 Commit: ac3af4beac439ebccd17746c9f2fd227e88107aa Compiler: gcc version 7.3.0 (GCC) x86: Testcase Result Summary: total: 4688 passed: 4688 failed: 0 timeout: 0 Tested-by: Hulk Robot
Re: [PATCH 4.14 00/95] 4.14.226-rc1 review
On 2021/3/15 21:56, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 4.14.226 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 17 Mar 2021 13:57:24 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.226-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Tested on x86 for 4.14.226, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.14.y Version: 4.14.226 Commit: cb83ddcd5332fcc3efd52ba994976efc4dd6061e Compiler: gcc version 7.3.0 (GCC) x86: Testcase Result Summary: total: 4714 passed: 4710 failed: 4 Failed cases: ltp test_robind07 ltp test_robind13 ltp test_robind14 ltp test_robind15 The 4 failed cases are caused by insufficient disk space in the test environment, no kernel failures Tested-by: Hulk Robot
Re: [PATCH 4.19 000/120] 4.19.181-rc1 review
On 2021/3/15 21:55, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 4.19.181 release. There are 120 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 17 Mar 2021 13:57:02 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.181-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 for 4.19.181, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.181 Commit: ac3af4beac439ebccd17746c9f2fd227e88107aa Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total: 4726 passed: 4721 failed: 5 Failed cases: ltp test_robind24 ltp test_robind25 ltp test_robind26 ltp test_robind27 ltp test_robind28 The 5 failed cases are caused by insufficient disk space in the test environment, no kernel failures Tested-by: Hulk Robot
Re: [PATCH 4.14 00/95] 4.14.226-rc1 review
On 2021/3/17 23:36, Greg KH wrote: On Tue, Mar 16, 2021 at 02:35:36PM +0800, Samuel Zou wrote: On 2021/3/15 21:56, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 4.14.226 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 17 Mar 2021 13:57:24 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.226-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Tested on x86 for 4.14.226-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.14.y Version: 4.14.226-rc1 Commit: 57cc62fb2d2b8e81c02cb9197e303c7782dee4cd Compiler: gcc version 7.3.0 (GCC) x86 (No kernel failures) Testcase Result Summary: total_num: 4728 succeed_num: 4727 failed_num: 1 What does this "failed_num" mean? thanks, greg k-h total_num: The number of total testcases succeed_num: The number of succeed testcases failed_num: The number of failed testcases Maybe I can revise the description in the next email.
Re: [PATCH 4.19 000/120] 4.19.181-rc1 review
On 2021/3/15 21:55, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 4.19.181 release. There are 120 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 17 Mar 2021 13:57:02 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.181-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 4.19.181-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.181-rc1 Commit: a636947af93f0a20fdba2c08ae38b7825ebf9c56 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total_num: 4740 succeed_num: 4740 failed_num: 0 timeout_num: 0 x86 (No kernel failures) Testcase Result Summary: total_num: 4740 succeed_num: 4739 failed_num: 1 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 5.4 000/168] 5.4.106-rc1 review
On 2021/3/15 21:53, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 5.4.106 release. There are 168 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 17 Mar 2021 13:55:26 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.106-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 for 5.4.106-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.106-rc1 Commit: 26ba2df2641dff3b9583fc4d1fbdc668bd346f00 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total_num: 4781 succeed_num: 4781 failed_num: 0 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 000/290] 5.10.24-rc1 review
On 2021/3/15 21:51, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 5.10.24 release. There are 290 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 17 Mar 2021 13:55:02 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.24-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 for 5.10.24-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.24-rc1 Commit: c6b3724e56923191dc567ceb626ba15daa49313c Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total_num: 4735 succeed_num: 4735 failed_num: 0 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 4.14 00/95] 4.14.226-rc1 review
On 2021/3/15 21:56, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 4.14.226 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 17 Mar 2021 13:57:24 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.226-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h Tested on x86 for 4.14.226-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.14.y Version: 4.14.226-rc1 Commit: 57cc62fb2d2b8e81c02cb9197e303c7782dee4cd Compiler: gcc version 7.3.0 (GCC) x86 (No kernel failures) Testcase Result Summary: total_num: 4728 succeed_num: 4727 failed_num: 1 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 5.4 00/24] 5.4.105-rc1 review
On 2021/3/10 21:24, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 5.4.105 release. There are 24 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri, 12 Mar 2021 13:23:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.105-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.4.105-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.105-rc1+ Commit: 62f8f08c9d2fbc6c5692d90f64dd70e3a8edd986 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total_num: 4703 succeed_num: 4703 failed_num: 0 timeout_num: 0 x86: Testcase Result Summary: total_num: 4703 succeed_num: 4703 failed_num: 0 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 4.19 00/39] 4.19.180-rc1 review
On 2021/3/10 21:24, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 4.19.180 release. There are 39 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri, 12 Mar 2021 13:23:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.180-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 4.19.180-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.180-rc1+ Commit: fffeea4063954b09866c112dad21a991ba52a914 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total_num: 4662 succeed_num: 4762 failed_num: 0 timeout_num: 0 x86: Testcase Result Summary: total_num: 4661 succeed_num: 4661 failed_num: 0 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 00/49] 5.10.23-rc1 review
On 2021/3/10 21:23, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 5.10.23 release. There are 49 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri, 12 Mar 2021 13:23:09 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.23-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.10.23-rc2, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.23-rc2+ Commit: 93276f11b3afe08c3f213a3648483b1a8789673b Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total_num: 4703 succeed_num: 4703 failed_num: 0 timeout_num: 0 x86: Testcase Result Summary: total_num: 4703 succeed_num: 4703 failed_num: 0 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 5.4 00/22] 5.4.104-rc1 review
On 2021/3/8 20:30, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.104 release. There are 22 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 10 Mar 2021 12:27:05 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.104-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.4.104-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.104-rc1 Commit: 1d493929c06100abd14b955538afa461dc2c8b69 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total_num: 4710 succeed_num: 4710 failed_num: 0 timeout_num: 0 x86 (No kernel failures) Testcase Result Summary: total_num: 4710 succeed_num: 4704 failed_num: 6 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 00/42] 5.10.22-rc1 review
On 2021/3/8 20:30, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.22 release. There are 42 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 10 Mar 2021 12:27:05 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.22-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.10.22-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.22-rc1+ Commit: 9226165b6cc7667b147e1de52090d1b6a17af336 Compiler: gcc version 7.3.0 (GCC) arm64 (No kernel failures) Testcase Result Summary: total_num: 4710 succeed_num: 4709 failed_num: 1 timeout_num: 0 x86 (No kernel failures) Testcase Result Summary: total_num: 4710 succeed_num: 4709 failed_num: 1 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 000/102] 5.10.21-rc1 review
On 2021/3/5 20:20, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.21 release. There are 102 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 07 Mar 2021 12:08:39 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.21-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Our test CI monitored the 5.10.21-rc1, and compile failure on arm64: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Arch: arm64/x86 Version: 5.10.21-rc1+ Commit: 80aaabbaf433294d1f075981fa3785d7f4b55159 Compiler: gcc version 7.3.0 (GCC) arm64 (compile failure) Kernel build failed, error log: kernel/rcu/tree.c:683:2: error: implicit declaration of function ‘IRQ_WORK_INIT’; did you mean ‘QSTR_INIT’? [-Werror=implicit-function-declaration] IRQ_WORK_INIT(late_wakeup_func); ^ QSTR_INIT kernel/rcu/tree.c:683:2: error: invalid initializer x86 (No kernel failures) Testcase Result Summary: total_num: 4716 succeed_num: 4714 failed_num: 2 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 4.19 00/52] 4.19.179-rc1 review
On 2021/3/5 20:21, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.179 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 07 Mar 2021 12:08:39 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.179-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 4.19.179-rc1, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.179-rc1+ Commit: 1112456421caf2562801d760aef4da53915246c0 Compiler: gcc version 7.3.0 (GCC) arm64 (No kernel failures) Testcase Result Summary: total_num: 4674 succeed_num: 4715 failed_num: 1 timeout_num: 0 x86 (No kernel failures) Testcase Result Summary: total_num: 4674 succeed_num: 4670 failed_num: 4 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 5.4 00/72] 5.4.103-rc1 review
On 2021/3/5 20:21, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.103 release. There are 72 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 07 Mar 2021 12:08:39 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.103-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Our test CI monitored the 5.4.103-rc1, and compile failure on arm64 and x86: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Arch: arm64/x86 Version: Commit: 2e10dba9fe0e67740146f3b3be42ed9403a7636e Compiler: gcc version 7.3.0 (GCC) Kernel build failed, error log: kernel/rcu/tree.c:617:2: error: implicit declaration of function ‘IRQ_WORK_INIT’; did you mean ‘IRQ_WORK_BUSY’? [-Werror=implicit-function-declaration] IRQ_WORK_INIT(late_wakeup_func); ^ IRQ_WORK_BUSY kernel/rcu/tree.c:617:2: error: invalid initializer Tested-by: Hulk Robot
Re: [PATCH 4.19 000/246] 4.19.178-rc4 review
On Tue, 02 Mar 2021 20:28:20 +0100, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.178 release. There are 246 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 04 Mar 2021 19:25:07 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.178-rc4.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 4.19.178, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-4.19.y Version: 4.19.178 Commit: dfb571610ba392179348c8472bfb131d4173d585 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total_num: 4674 succeed_num: 4674 failed_num: 0 timeout_num: 0 x86 (No kernel failures) Testcase Result Summary: total_num: 4674 succeed_num: 4769 failed_num: 5 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 5.10 000/657] 5.10.20-rc4 review
On Tue, 02 Mar 2021 20:28:49 +0100, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.20 release. There are 657 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 04 Mar 2021 19:25:07 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.20-rc4.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.10.20, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.10.y Version: 5.10.20 Commit: 83be32b6c9e55d5b04181fc9788591d5611d4a96 Compiler: gcc version 7.3.0 (GCC) arm64 (No kernel failures) Testcase Result Summary: total_num: 4716 succeed_num: 4713 failed_num: 3 timeout_num: 0 x86 (No kernel failures) Testcase Result Summary: total_num: 4716 succeed_num: 4713 failed_num: 3 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH 5.4 000/337] 5.4.102-rc5 review
On Tue, 02 Mar 2021 20:28:34 +0100, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.102 release. There are 337 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 04 Mar 2021 19:25:07 +. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.102-rc5.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h Tested on arm64 and x86 for 5.4.102, Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Branch: linux-5.4.y Version: 5.4.102 Commit: 7f324ea75baa059ea126cddd4141198895880a69 Compiler: gcc version 7.3.0 (GCC) arm64: Testcase Result Summary: total_num: 4716 succeed_num: 4716 failed_num: 0 timeout_num: 0 x86 (No kernel failures) Testcase Result Summary: total_num: 4716 succeed_num: 4715 failed_num: 1 timeout_num: 0 Tested-by: Hulk Robot
Re: [PATCH -next] dmaengine: ti: k3-udma: Use PTR_ERR_OR_ZERO() to simplify code
Hi Peter, I'm sorry for my mistake. Thanks for your comments and suggestions. On 2020/5/14 16:33, Peter Ujfalusi wrote: Hi Samuel, On 06/05/2020 12.25, Samuel Zou wrote: Fixes coccicheck warnings: drivers/dma/ti/k3-udma.c:1294:1-3: WARNING: PTR_ERR_OR_ZERO can be used drivers/dma/ti/k3-udma.c:1311:1-3: WARNING: PTR_ERR_OR_ZERO can be used drivers/dma/ti/k3-udma.c:1376:1-3: WARNING: PTR_ERR_OR_ZERO can be used Thanks for the patch, I have missed it as I was not in CC for it. scripts/get_maintainer.pl would have tipped for a wider recipient list.. Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/dma/ti/k3-udma.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c index 0a04174..f5775ca 100644 --- a/drivers/dma/ti/k3-udma.c +++ b/drivers/dma/ti/k3-udma.c @@ -1291,10 +1291,8 @@ static int udma_get_tchan(struct udma_chan *uc) } uc->tchan = __udma_reserve_tchan(ud, uc->config.channel_tpl, -1); - if (IS_ERR(uc->tchan)) - return PTR_ERR(uc->tchan); - return 0; + return PTR_ERR_OR_ZERO(uc->tchan); } static int udma_get_rchan(struct udma_chan *uc) @@ -1308,10 +1306,8 @@ static int udma_get_rchan(struct udma_chan *uc) } uc->rchan = __udma_reserve_rchan(ud, uc->config.channel_tpl, -1); - if (IS_ERR(uc->rchan)) - return PTR_ERR(uc->rchan); - return 0; + return PTR_ERR_OR_ZERO(uc->rchan); } static int udma_get_chan_pair(struct udma_chan *uc) @@ -1373,10 +1369,8 @@ static int udma_get_rflow(struct udma_chan *uc, int flow_id) } uc->rflow = __udma_get_rflow(ud, flow_id); - if (IS_ERR(uc->rflow)) - return PTR_ERR(uc->rflow); - return 0; + return PTR_ERR_OR_ZERO(uc->rflow); } static void udma_put_rchan(struct udma_chan *uc) - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
[PATCH -next] ARM: OMAP2+: pm33xx-core: Make am43xx_get_rtc_base_addr static
Fix the following sparse warning:
arch/arm/mach-omap2/pm33xx-core.c:270:14: warning: symbol
'am43xx_get_rtc_base_addr' was not declared.
The am43xx_get_rtc_base_addr has only call site within pm33xx-core.c
It should be static
Fixes: 8c5a916f4c88 ("ARM: OMAP2+: sleep33/43xx: Add RTC-Mode support")
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
arch/arm/mach-omap2/pm33xx-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/pm33xx-core.c
b/arch/arm/mach-omap2/pm33xx-core.c
index 5455fc9..58236c7 100644
--- a/arch/arm/mach-omap2/pm33xx-core.c
+++ b/arch/arm/mach-omap2/pm33xx-core.c
@@ -267,7 +267,7 @@ static struct am33xx_pm_sram_addr *amx3_get_sram_addrs(void)
return NULL;
}
-void __iomem *am43xx_get_rtc_base_addr(void)
+static void __iomem *am43xx_get_rtc_base_addr(void)
{
rtc_oh = omap_hwmod_lookup("rtc");
--
2.6.2
[PATCH -next] ARM: zx: Make zx_smp_prepare_cpus static
Fix the following sparse warning:
arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not
declared.
The zx_smp_prepare_cpus has only call site within platsmp.c
It should be static
Fixes: 71bc724300e6 ("ARM: zx: enable SMP and hotplug for zx296702")
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
arch/arm/mach-zx/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c
index d4e1d37..43a33ea 100644
--- a/arch/arm/mach-zx/platsmp.c
+++ b/arch/arm/mach-zx/platsmp.c
@@ -38,7 +38,7 @@ static void __iomem *pcu_base;
static void __iomem *matrix_base;
static void __iomem *scu_base;
-void __init zx_smp_prepare_cpus(unsigned int max_cpus)
+static void __init zx_smp_prepare_cpus(unsigned int max_cpus)
{
struct device_node *np;
unsigned long base = 0;
--
2.6.2
[PATCH -next] iommu/msm: Make msm_iommu_lock static
Fix the following sparse warning:
drivers/iommu/msm_iommu.c:37:1: warning: symbol 'msm_iommu_lock' was not
declared.
The msm_iommu_lock has only call site within msm_iommu.c
It should be static
Fixes: 0720d1f052dc ("msm: Add MSM IOMMU support")
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/iommu/msm_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
index 10cd4db..3d8a635 100644
--- a/drivers/iommu/msm_iommu.c
+++ b/drivers/iommu/msm_iommu.c
@@ -34,7 +34,7 @@ __asm__ __volatile__ (
\
/* bitmap of the page sizes currently supported */
#define MSM_IOMMU_PGSIZES (SZ_4K | SZ_64K | SZ_1M | SZ_16M)
-DEFINE_SPINLOCK(msm_iommu_lock);
+static DEFINE_SPINLOCK(msm_iommu_lock);
static LIST_HEAD(qcom_iommu_devices);
static struct iommu_ops msm_iommu_ops;
--
2.6.2
[PATCH -next] drivers: soc: ti: knav_qmss_queue: Make knav_gp_range_ops static
Fix the following sparse warning:
drivers/soc/ti/knav_qmss_queue.c:412:23: warning: symbol 'knav_gp_range_ops'
was not declared.
The knav_acc_firmwares has only call site within knav_qmss_queue.c
It should be static
Fixes: 41f93af900a2 ("soc: ti: add Keystone Navigator QMSS driver")
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/soc/ti/knav_qmss_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index 37f3db6..aa071d9 100644
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -409,7 +409,7 @@ static int knav_gp_close_queue(struct knav_range_info
*range,
return 0;
}
-struct knav_range_ops knav_gp_range_ops = {
+static struct knav_range_ops knav_gp_range_ops = {
.set_notify = knav_gp_set_notify,
.open_queue = knav_gp_open_queue,
.close_queue= knav_gp_close_queue,
--
2.6.2
[PATCH -next] usb: gadget: udc: atmel: Make some symbols static
Fix the following sparse warnings:
drivers/usb/gadget/udc/atmel_usba_udc.c:188:30: warning: symbol
'queue_dbg_fops' was not declared.
drivers/usb/gadget/udc/atmel_usba_udc.c:196:30: warning: symbol 'regs_dbg_fops'
was not declared.
queue_dbg_fops and regs_dbg_fops have only call within atmel_usba_udc.c
They should be static
Fixes: 914a3f3b3754 ("USB: add atmel_usba_udc driver")
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c
b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 2220034..b771a85 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -185,7 +185,7 @@ static int regs_dbg_release(struct inode *inode, struct
file *file)
return 0;
}
-const struct file_operations queue_dbg_fops = {
+static const struct file_operations queue_dbg_fops = {
.owner = THIS_MODULE,
.open = queue_dbg_open,
.llseek = no_llseek,
@@ -193,7 +193,7 @@ const struct file_operations queue_dbg_fops = {
.release= queue_dbg_release,
};
-const struct file_operations regs_dbg_fops = {
+static const struct file_operations regs_dbg_fops = {
.owner = THIS_MODULE,
.open = regs_dbg_open,
.llseek = generic_file_llseek,
--
2.6.2
[PATCH -next] media: tegra: Make tegra210_video_formats static
Fix the following sparse warning:
drivers/staging/media/tegra-video/tegra210.c:589:33: warning: symbol
'tegra210_video_formats' was not declared.
The tegra210_video_formats has only call site within tegra210.c
It should be static
Fixes: 423d10a99b30 ("media: tegra: Add Tegra210 Video input driver")
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/staging/media/tegra-video/tegra210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/tegra-video/tegra210.c
b/drivers/staging/media/tegra-video/tegra210.c
index 2045609..3baa4e3 100644
--- a/drivers/staging/media/tegra-video/tegra210.c
+++ b/drivers/staging/media/tegra-video/tegra210.c
@@ -586,7 +586,7 @@ enum tegra210_image_format {
}
/* Tegra210 supported video formats */
-const struct tegra_video_format tegra210_video_formats[] = {
+static const struct tegra_video_format tegra210_video_formats[] = {
/* RAW 8 */
TEGRA210_VIDEO_FMT(RAW8, 8, SRGGB8_1X8, 1, T_L8, SRGGB8),
TEGRA210_VIDEO_FMT(RAW8, 8, SGRBG8_1X8, 1, T_L8, SGRBG8),
--
2.6.2
[PATCH -next] power: supply: Make bd9995x_chip_reset static
Fix the following sparse warning:
drivers/power/supply/bd99954-charger.c:1028:6: warning: symbol
'bd9995x_chip_reset' was not declared.
The bd9995x_chip_reset() has only one call site within bd99954-charger.c
It should be static
Fixes: 0902f8366491 ("power: supply: Support ROHM bd99954 charger")
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/power/supply/bd99954-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/bd99954-charger.c
b/drivers/power/supply/bd99954-charger.c
index 3da39c7..ffd8bfa 100644
--- a/drivers/power/supply/bd99954-charger.c
+++ b/drivers/power/supply/bd99954-charger.c
@@ -1025,7 +1025,7 @@ static int bd9995x_fw_probe(struct bd9995x_device *bd)
return 0;
}
-void bd9995x_chip_reset(void *bd)
+static void bd9995x_chip_reset(void *bd)
{
__bd9995x_chip_reset(bd);
}
--
2.6.2
[PATCH -next] vdpasim: Fix some coccinelle warnings
Fix below warnings reported by coccicheck:
drivers/vdpa/vdpa_sim/vdpa_sim.c:104:1-10: WARNING: Assignment of 0/1 to bool
variable
drivers/vdpa/vdpa_sim/vdpa_sim.c:164:7-11: WARNING: Unsigned expression
compared with zero: read <= 0
drivers/vdpa/vdpa_sim/vdpa_sim.c:169:7-12: WARNING: Unsigned expression
compared with zero: write <= 0
1. The 'ready' variable in vdpasim_virtqueue struct is bool type.
It is better to initialize vq->ready to false
2. Modify 'read' and 'write' variables type from size_t to ssize_t.
And preserve the reverse christmas tree ordering of local variables.
Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator")
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
index 01c456f..c7334cc 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
@@ -101,7 +101,7 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim,
unsigned int idx)
static void vdpasim_vq_reset(struct vdpasim_virtqueue *vq)
{
- vq->ready = 0;
+ vq->ready = false;
vq->desc_addr = 0;
vq->driver_addr = 0;
vq->device_addr = 0;
@@ -131,9 +131,10 @@ static void vdpasim_work(struct work_struct *work)
vdpasim, work);
struct vdpasim_virtqueue *txq = &vdpasim->vqs[1];
struct vdpasim_virtqueue *rxq = &vdpasim->vqs[0];
- size_t read, write, total_write;
- int err;
+ ssize_t read, write;
+ size_t total_write;
int pkts = 0;
+ int err;
spin_lock(&vdpasim->lock);
--
2.6.2
[PATCH -next v2] livepatch: Make klp_apply_object_relocs static
Fix the following sparse warning:
kernel/livepatch/core.c:748:5: warning: symbol 'klp_apply_object_relocs' was
not declared.
The klp_apply_object_relocs() has only one call site within core.c
It should be static
Fixes: 7c8e2bdd5f0d ("livepatch: Apply vmlinux-specific KLP relocations early")
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
kernel/livepatch/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 96d2da1..f76fdb9 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -745,7 +745,8 @@ static int klp_init_func(struct klp_object *obj, struct
klp_func *func)
func->old_sympos ? func->old_sympos : 1);
}
-int klp_apply_object_relocs(struct klp_patch *patch, struct klp_object *obj)
+static int klp_apply_object_relocs(struct klp_patch *patch,
+ struct klp_object *obj)
{
int i, ret;
struct klp_modinfo *info = patch->mod->klp_info;
--
2.6.2
Re: [PATCH -next] livepatch: Make klp_apply_object_relocs static
Hi Josh, Thanks for your review and reply. Yes, I just copied and pasted the warning message, so I brought a question mark. I will modify the description and add the fixes tag which introduced the issue, then will send the v2 soon. On 2020/5/8 23:55, Josh Poimboeuf wrote: On Fri, May 08, 2020 at 10:53:41AM -0500, Josh Poimboeuf wrote: On Fri, May 08, 2020 at 08:06:34PM +0800, Samuel Zou wrote: Fix the following sparse warning: kernel/livepatch/core.c:748:5: warning: symbol 'klp_apply_object_relocs' was not declared. Should it be static? Yes, it should :-) So instead of the question, the patch description should probably state that it should be static because its only caller is in the file. ... and it probably should also have a Fixes tag which references the commit which introduced this issue. With that change: Acked-by: Josh Poimboeuf
[PATCH -next] livepatch: Make klp_apply_object_relocs static
Fix the following sparse warning:
kernel/livepatch/core.c:748:5: warning: symbol 'klp_apply_object_relocs'
was not declared. Should it be static?
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
kernel/livepatch/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 96d2da1..f76fdb9 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -745,7 +745,8 @@ static int klp_init_func(struct klp_object *obj, struct
klp_func *func)
func->old_sympos ? func->old_sympos : 1);
}
-int klp_apply_object_relocs(struct klp_patch *patch, struct klp_object *obj)
+static int klp_apply_object_relocs(struct klp_patch *patch,
+ struct klp_object *obj)
{
int i, ret;
struct klp_modinfo *info = patch->mod->klp_info;
--
2.6.2
[PATCH -next] net: dsa: sja1105: remove set but not used variable 'prev_time'
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/dsa/sja1105/sja1105_vl.c:468:6: warning: variable ‘prev_time’ set
but not used [-Wunused-but-set-variable]
u32 prev_time = 0;
^
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/net/dsa/sja1105/sja1105_vl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/dsa/sja1105/sja1105_vl.c
b/drivers/net/dsa/sja1105/sja1105_vl.c
index b52f1af..aa9b0b9 100644
--- a/drivers/net/dsa/sja1105/sja1105_vl.c
+++ b/drivers/net/dsa/sja1105/sja1105_vl.c
@@ -465,7 +465,6 @@ sja1105_gating_cfg_time_to_interval(struct
sja1105_gating_config *gating_cfg,
struct sja1105_gate_entry *last_e;
struct sja1105_gate_entry *e;
struct list_head *prev;
- u32 prev_time = 0;
list_for_each_entry(e, &gating_cfg->entries, list) {
struct sja1105_gate_entry *p;
@@ -476,7 +475,6 @@ sja1105_gating_cfg_time_to_interval(struct
sja1105_gating_config *gating_cfg,
continue;
p = list_entry(prev, struct sja1105_gate_entry, list);
- prev_time = e->interval;
p->interval = e->interval - p->interval;
}
last_e = list_last_entry(&gating_cfg->entries,
--
2.6.2
[PATCH -next] scsi: mpt3sas: Remove unused including
Fix the following versioncheck warning: drivers/scsi/mpt3sas/mpt3sas_debugfs.c:16:1: unused including Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/scsi/mpt3sas/mpt3sas_debugfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_debugfs.c b/drivers/scsi/mpt3sas/mpt3sas_debugfs.c index 48095d8..a6ab1db 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_debugfs.c +++ b/drivers/scsi/mpt3sas/mpt3sas_debugfs.c @@ -13,7 +13,6 @@ * **/ -#include #include #include #include -- 2.6.2
Re: [PATCH -next] dm mpath: Remove unused variable ret
Hi Mike, You are right. I did not notice that the macro DMEMIT uses the sz variable. Thanks. On 2020/5/7 22:29, Mike Snitzer wrote: On Thu, May 07 2020 at 8:26am -0400, Samuel Zou wrote: This patch fixes below warning reported by coccicheck: drivers/md/dm-historical-service-time.c:240:14-16: Unneeded variable: "sz". Return "0" on line 261 Reported-by: Hulk Robot Signed-off-by: Samuel Zou Nack. DMEMIT() uses the local sz variable.
[PATCH -next] dm mpath: Remove unused variable ret
This patch fixes below warning reported by coccicheck:
drivers/md/dm-historical-service-time.c:240:14-16: Unneeded variable: "sz".
Return "0" on line 261
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/md/dm-historical-service-time.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/dm-historical-service-time.c
b/drivers/md/dm-historical-service-time.c
index 186f91e..3c8acb9 100644
--- a/drivers/md/dm-historical-service-time.c
+++ b/drivers/md/dm-historical-service-time.c
@@ -237,7 +237,6 @@ static void hst_destroy(struct path_selector *ps)
static int hst_status(struct path_selector *ps, struct dm_path *path,
status_type_t type, char *result, unsigned int maxlen)
{
- unsigned int sz = 0;
struct path_info *pi;
if (!path) {
@@ -258,7 +257,7 @@ static int hst_status(struct path_selector *ps, struct
dm_path *path,
}
}
- return sz;
+ return 0;
}
static int hst_add_path(struct path_selector *ps, struct dm_path *path,
--
2.6.2
[PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli_resume static
Fix the following sparse warning:
drivers/mmc/host/sdhci-pci-gli.c:343:5: warning:
symbol 'sdhci_pci_gli_resume' was not declared. Should it be static?
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/mmc/host/sdhci-pci-gli.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
index bdb6336..fd76aa6 100644
--- a/drivers/mmc/host/sdhci-pci-gli.c
+++ b/drivers/mmc/host/sdhci-pci-gli.c
@@ -340,7 +340,7 @@ static u32 sdhci_gl9750_readl(struct sdhci_host *host, int
reg)
}
#ifdef CONFIG_PM_SLEEP
-int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
+static int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
{
struct sdhci_pci_slot *slot = chip->slots[0];
--
2.6.2
[PATCH -next] ALSA: portman2x4: Use bitwise instead of arithmetic operator for flags
Fix the following coccinelle warning: sound/drivers/portman2x4.c:460:34-35: WARNING: sum of probable bitmasks, consider | Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- sound/drivers/portman2x4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c index ecefa7c..38603cb 100644 --- a/sound/drivers/portman2x4.c +++ b/sound/drivers/portman2x4.c @@ -457,7 +457,7 @@ static int portman_probe(struct parport *p) /* Set for RXDATA0 where no damage will be done. */ /* 5 */ - parport_write_control(p, RXDATA0 + STROBE); /* Write Strobe=1 to command reg. */ + parport_write_control(p, RXDATA0 | STROBE); /* Write Strobe=1 to command reg. */ /* 6 */ if ((parport_read_status(p) & ESTB) != ESTB) -- 2.6.2
[PATCH -next] ASoC: amd: acp3x-pcm-dma: Use bitwise instead of arithmetic operator for flags
Fix the following coccinelle warnings:
sound/soc/amd/raven/acp3x-pcm-dma.c:161:39-40: WARNING: sum of probable
bitmasks, consider |
sound/soc/amd/raven/acp3x-pcm-dma.c:172:39-40: WARNING: sum of probable
bitmasks, consider |
sound/soc/amd/raven/acp3x-pcm-dma.c:183:39-40: WARNING: sum of probable
bitmasks, consider |
sound/soc/amd/raven/acp3x-pcm-dma.c:194:39-40: WARNING: sum of probable
bitmasks, consider |
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c
b/sound/soc/amd/raven/acp3x-pcm-dma.c
index e362f0b..b0cc0fe 100644
--- a/sound/soc/amd/raven/acp3x-pcm-dma.c
+++ b/sound/soc/amd/raven/acp3x-pcm-dma.c
@@ -158,7 +158,7 @@ static void config_acp3x_dma(struct i2s_stream_instance
*rtd, int direction)
switch (rtd->i2s_instance) {
case I2S_BT_INSTANCE:
reg_dma_size = mmACP_BT_TX_DMA_SIZE;
- acp_fifo_addr = ACP_SRAM_PTE_OFFSET +
+ acp_fifo_addr = ACP_SRAM_PTE_OFFSET |
BT_PB_FIFO_ADDR_OFFSET;
reg_fifo_addr = mmACP_BT_TX_FIFOADDR;
reg_fifo_size = mmACP_BT_TX_FIFOSIZE;
@@ -169,7 +169,7 @@ static void config_acp3x_dma(struct i2s_stream_instance
*rtd, int direction)
case I2S_SP_INSTANCE:
default:
reg_dma_size = mmACP_I2S_TX_DMA_SIZE;
- acp_fifo_addr = ACP_SRAM_PTE_OFFSET +
+ acp_fifo_addr = ACP_SRAM_PTE_OFFSET |
SP_PB_FIFO_ADDR_OFFSET;
reg_fifo_addr = mmACP_I2S_TX_FIFOADDR;
reg_fifo_size = mmACP_I2S_TX_FIFOSIZE;
@@ -180,7 +180,7 @@ static void config_acp3x_dma(struct i2s_stream_instance
*rtd, int direction)
switch (rtd->i2s_instance) {
case I2S_BT_INSTANCE:
reg_dma_size = mmACP_BT_RX_DMA_SIZE;
- acp_fifo_addr = ACP_SRAM_PTE_OFFSET +
+ acp_fifo_addr = ACP_SRAM_PTE_OFFSET |
BT_CAPT_FIFO_ADDR_OFFSET;
reg_fifo_addr = mmACP_BT_RX_FIFOADDR;
reg_fifo_size = mmACP_BT_RX_FIFOSIZE;
@@ -191,7 +191,7 @@ static void config_acp3x_dma(struct i2s_stream_instance
*rtd, int direction)
case I2S_SP_INSTANCE:
default:
reg_dma_size = mmACP_I2S_RX_DMA_SIZE;
- acp_fifo_addr = ACP_SRAM_PTE_OFFSET +
+ acp_fifo_addr = ACP_SRAM_PTE_OFFSET |
SP_CAPT_FIFO_ADDR_OFFSET;
reg_fifo_addr = mmACP_I2S_RX_FIFOADDR;
reg_fifo_size = mmACP_I2S_RX_FIFOSIZE;
--
2.6.2
Re: [PATCH -next] iwlwifi: pcie: Use bitwise instead of arithmetic operator for flags
Both of you are right. I neglected, and this patch is wrong. Thanks. On 2020/5/6 23:15, Joe Perches wrote: On Wed, 2020-05-06 at 16:51 +0300, Luciano Coelho wrote: On Tue, 2020-05-05 at 20:19 -0700, Joe Perches wrote: On Wed, 2020-05-06 at 11:07 +0800, Samuel Zou wrote: This silences the following coccinelle warning: "WARNING: sum of probable bitmasks, consider |" I suggest instead ignoring bad and irrelevant warnings. PREFIX_LEN is 32 not 0x20 or BIT(5) PCI_DUMP_SIZE is 352 diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c [] @@ -109,9 +109,9 @@ void iwl_trans_pcie_dump_regs(struct iwl_trans *trans) /* Alloc a max size buffer */ alloc_size = PCI_ERR_ROOT_ERR_SRC + 4 + PREFIX_LEN; - alloc_size = max_t(u32, alloc_size, PCI_DUMP_SIZE + PREFIX_LEN); - alloc_size = max_t(u32, alloc_size, PCI_MEM_DUMP_SIZE + PREFIX_LEN); - alloc_size = max_t(u32, alloc_size, PCI_PARENT_DUMP_SIZE + PREFIX_LEN); + alloc_size = max_t(u32, alloc_size, PCI_DUMP_SIZE | PREFIX_LEN); + alloc_size = max_t(u32, alloc_size, PCI_MEM_DUMP_SIZE | PREFIX_LEN); + alloc_size = max_t(u32, alloc_size, PCI_PARENT_DUMP_SIZE | PREFIX_LEN); buf = kmalloc(alloc_size, GFP_ATOMIC); if (!buf) Yeah, those macros are clearly not bitmasks. I'm dropping this patch. Can the cocci script that generated this warning scripts/coccinelle/misc/orplus.cocci be dropped or improved to validate the likelihood that the defines or constants used are more likely than not are bit values? Maybe these should be defined as hex or BIT or BIT_ULL or GENMASK or the like? Right now it seems it just tests for two constants. .
[PATCH -next] ALSA: sound/ppc: Use bitwise instead of arithmetic operator for flags
Fix the following coccinelle warnings: sound/ppc/pmac.c:729:57-58: WARNING: sum of probable bitmasks, consider | sound/ppc/pmac.c:229:37-38: WARNING: sum of probable bitmasks, consider | Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- sound/ppc/pmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c index 592532c..2e750b3 100644 --- a/sound/ppc/pmac.c +++ b/sound/ppc/pmac.c @@ -226,7 +226,7 @@ static int snd_pmac_pcm_prepare(struct snd_pmac *chip, struct pmac_stream *rec, offset += rec->period_size; } /* make loop */ - cp->command = cpu_to_le16(DBDMA_NOP + BR_ALWAYS); + cp->command = cpu_to_le16(DBDMA_NOP | BR_ALWAYS); cp->cmd_dep = cpu_to_le32(rec->cmd.addr); snd_pmac_dma_stop(rec); @@ -726,7 +726,7 @@ void snd_pmac_beep_dma_start(struct snd_pmac *chip, int bytes, unsigned long add chip->extra_dma.cmds->xfer_status = cpu_to_le16(0); chip->extra_dma.cmds->cmd_dep = cpu_to_le32(chip->extra_dma.addr); chip->extra_dma.cmds->phy_addr = cpu_to_le32(addr); - chip->extra_dma.cmds->command = cpu_to_le16(OUTPUT_MORE + BR_ALWAYS); + chip->extra_dma.cmds->command = cpu_to_le16(OUTPUT_MORE | BR_ALWAYS); out_le32(&chip->awacs->control, (in_le32(&chip->awacs->control) & ~0x1f00) | (speed << 8)); -- 2.6.2
[PATCH -next] drm/i2c/tda998x: Make tda998x_audio_digital_mute static
Fix the following sparse warning:
drivers/gpu/drm/i2c/tda998x_drv.c:1136:5: warning:
symbol 'tda998x_audio_digital_mute' was not declared. Should it be static?
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/gpu/drm/i2c/tda998x_drv.c
index 3c90d7a..9517f52 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1133,7 +1133,8 @@ static void tda998x_audio_shutdown(struct device *dev,
void *data)
mutex_unlock(&priv->audio_mutex);
}
-int tda998x_audio_digital_mute(struct device *dev, void *data, bool enable)
+static int tda998x_audio_digital_mute(struct device *dev, void *data,
+ bool enable)
{
struct tda998x_priv *priv = dev_get_drvdata(dev);
--
2.6.2
[PATCH -next] drm/ast: Make ast_primary_plane_helper_atomic_update static
Fix the following sparse warning:
drivers/gpu/drm/ast/ast_mode.c:564:6: warning:
symbol 'ast_primary_plane_helper_atomic_update'
was not declared. Should it be static?
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/gpu/drm/ast/ast_mode.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 7062bcd..4ddf770 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -561,8 +561,9 @@ static int ast_primary_plane_helper_atomic_check(struct
drm_plane *plane,
return 0;
}
-void ast_primary_plane_helper_atomic_update(struct drm_plane *plane,
- struct drm_plane_state *old_state)
+static void
+ast_primary_plane_helper_atomic_update(struct drm_plane *plane,
+ struct drm_plane_state *old_state)
{
struct ast_private *ast = plane->dev->dev_private;
struct drm_plane_state *state = plane->state;
--
2.6.2
[PATCH -next] rtc: pcf8523: Use PTR_ERR_OR_ZERO() to simplify code
Fixes coccicheck warning:
drivers/rtc/rtc-pcf8523.c:361:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/rtc/rtc-pcf8523.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c
index 47e0f41..da8889a 100644
--- a/drivers/rtc/rtc-pcf8523.c
+++ b/drivers/rtc/rtc-pcf8523.c
@@ -358,10 +358,8 @@ static int pcf8523_probe(struct i2c_client *client,
rtc = devm_rtc_device_register(&client->dev, DRIVER_NAME,
&pcf8523_rtc_ops, THIS_MODULE);
- if (IS_ERR(rtc))
- return PTR_ERR(rtc);
- return 0;
+ return PTR_ERR_OR_ZERO(rtc);
}
static const struct i2c_device_id pcf8523_id[] = {
--
2.6.2
[PATCH -next] dmaengine: ti: k3-udma: Use PTR_ERR_OR_ZERO() to simplify code
Fixes coccicheck warnings: drivers/dma/ti/k3-udma.c:1294:1-3: WARNING: PTR_ERR_OR_ZERO can be used drivers/dma/ti/k3-udma.c:1311:1-3: WARNING: PTR_ERR_OR_ZERO can be used drivers/dma/ti/k3-udma.c:1376:1-3: WARNING: PTR_ERR_OR_ZERO can be used Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/dma/ti/k3-udma.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c index 0a04174..f5775ca 100644 --- a/drivers/dma/ti/k3-udma.c +++ b/drivers/dma/ti/k3-udma.c @@ -1291,10 +1291,8 @@ static int udma_get_tchan(struct udma_chan *uc) } uc->tchan = __udma_reserve_tchan(ud, uc->config.channel_tpl, -1); - if (IS_ERR(uc->tchan)) - return PTR_ERR(uc->tchan); - return 0; + return PTR_ERR_OR_ZERO(uc->tchan); } static int udma_get_rchan(struct udma_chan *uc) @@ -1308,10 +1306,8 @@ static int udma_get_rchan(struct udma_chan *uc) } uc->rchan = __udma_reserve_rchan(ud, uc->config.channel_tpl, -1); - if (IS_ERR(uc->rchan)) - return PTR_ERR(uc->rchan); - return 0; + return PTR_ERR_OR_ZERO(uc->rchan); } static int udma_get_chan_pair(struct udma_chan *uc) @@ -1373,10 +1369,8 @@ static int udma_get_rflow(struct udma_chan *uc, int flow_id) } uc->rflow = __udma_get_rflow(ud, flow_id); - if (IS_ERR(uc->rflow)) - return PTR_ERR(uc->rflow); - return 0; + return PTR_ERR_OR_ZERO(uc->rflow); } static void udma_put_rchan(struct udma_chan *uc) -- 2.6.2
[PATCH -next] i2c: nvidia-gpu: Use PTR_ERR_OR_ZERO() to simplify code
Fixes coccicheck warning: drivers/i2c/busses/i2c-nvidia-gpu.c:280:1-3: WARNING: PTR_ERR_OR_ZERO can be used Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/i2c/busses/i2c-nvidia-gpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c index f5d25ce..dba5d11 100644 --- a/drivers/i2c/busses/i2c-nvidia-gpu.c +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c @@ -277,10 +277,8 @@ static int gpu_populate_client(struct gpu_i2c_dev *i2cd, int irq) i2cd->gpu_ccgx_ucsi->irq = irq; i2cd->gpu_ccgx_ucsi->properties = ccgx_props; i2cd->ccgx_client = i2c_new_client_device(&i2cd->adapter, i2cd->gpu_ccgx_ucsi); - if (IS_ERR(i2cd->ccgx_client)) - return PTR_ERR(i2cd->ccgx_client); - return 0; + return PTR_ERR_OR_ZERO(i2cd->ccgx_client); } static int gpu_i2c_probe(struct pci_dev *pdev, const struct pci_device_id *id) -- 2.6.2
[PATCH -next] nvmem: jz4780-efuse: Use PTR_ERR_OR_ZERO() to simplify code
Fixes coccicheck warning:
drivers/nvmem/jz4780-efuse.c:214:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/nvmem/jz4780-efuse.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nvmem/jz4780-efuse.c b/drivers/nvmem/jz4780-efuse.c
index 512e187..0b01b84 100644
--- a/drivers/nvmem/jz4780-efuse.c
+++ b/drivers/nvmem/jz4780-efuse.c
@@ -211,10 +211,8 @@ static int jz4780_efuse_probe(struct platform_device *pdev)
cfg.priv = efuse;
nvmem = devm_nvmem_register(dev, &cfg);
- if (IS_ERR(nvmem))
- return PTR_ERR(nvmem);
- return 0;
+ return PTR_ERR_OR_ZERO(nvmem);
}
static const struct of_device_id jz4780_efuse_match[] = {
--
2.6.2
[PATCH -next] ASoC: sun4i-i2s: Use PTR_ERR_OR_ZERO() to simplify code
Fixes coccicheck warning: sound/soc/sunxi/sun4i-i2s.c:1177:1-3: WARNING: PTR_ERR_OR_ZERO can be used Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- sound/soc/sunxi/sun4i-i2s.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c index d0a8d58..72012a6 100644 --- a/sound/soc/sunxi/sun4i-i2s.c +++ b/sound/soc/sunxi/sun4i-i2s.c @@ -1174,10 +1174,8 @@ static int sun4i_i2s_init_regmap_fields(struct device *dev, i2s->field_fmt_sr = devm_regmap_field_alloc(dev, i2s->regmap, i2s->variant->field_fmt_sr); - if (IS_ERR(i2s->field_fmt_sr)) - return PTR_ERR(i2s->field_fmt_sr); - return 0; + return PTR_ERR_OR_ZERO(i2s->field_fmt_sr); } static int sun4i_i2s_probe(struct platform_device *pdev) -- 2.6.2
[PATCH -next] scsi: qla2xxx: Use PTR_ERR_OR_ZERO() to simplify code
Fixes coccicheck warning: drivers/scsi/qla2xxx/tcm_qla2xxx.c:1488:1-3: WARNING: PTR_ERR_OR_ZERO can be used Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index 1f0a185..7c4157e 100644 --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c @@ -1485,10 +1485,8 @@ static int tcm_qla2xxx_check_initiator_node_acl( sizeof(struct qla_tgt_cmd), TARGET_PROT_ALL, port_name, qlat_sess, tcm_qla2xxx_session_cb); - if (IS_ERR(se_sess)) - return PTR_ERR(se_sess); - return 0; + return PTR_ERR_OR_ZERO(se_sess); } static void tcm_qla2xxx_update_sess(struct fc_port *sess, port_id_t s_id, -- 2.6.2
[PATCH -next] x86/platform/uv: Use false for return type bool
Fix the following coccicheck warning:
arch/x86/include/asm/uv/uv.h:45:53-54: WARNING: return of 0/1
in function 'is_early_uv_system' with return type bool
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
arch/x86/include/asm/uv/uv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
index 91e088a..334da92 100644
--- a/arch/x86/include/asm/uv/uv.h
+++ b/arch/x86/include/asm/uv/uv.h
@@ -42,7 +42,7 @@ extern const struct cpumask *uv_flush_tlb_others(const struct
cpumask *cpumask,
#else /* X86_UV */
static inline enum uv_system_type get_uv_system_type(void) { return UV_NONE; }
-static inline bool is_early_uv_system(void){ return 0; }
+static inline bool is_early_uv_system(void){ return false; }
static inline int is_uv_system(void) { return 0; }
static inline int is_uv_hubbed(int uv) { return 0; }
static inline int is_uv_hubless(int uv) { return 0; }
--
2.6.2
[PATCH -next] net: ethernet: mediatek: Make mtk_m32 static
Fix the following sparse warning:
drivers/net/ethernet/mediatek/mtk_eth_soc.c:68:5: warning:
symbol 'mtk_m32' was not declared. Should it be static?
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 0904710..2822268 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -65,7 +65,7 @@ u32 mtk_r32(struct mtk_eth *eth, unsigned reg)
return __raw_readl(eth->base + reg);
}
-u32 mtk_m32(struct mtk_eth *eth, u32 mask, u32 set, unsigned reg)
+static u32 mtk_m32(struct mtk_eth *eth, u32 mask, u32 set, unsigned reg)
{
u32 val;
--
2.6.2
[PATCH -next] soundwire: qcom: Use IRQF_ONESHOT
Fixes coccicheck error:
drivers/soundwire/qcom.c:815:7-32: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/soundwire/qcom.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index e08a17c..a2a35f7 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -814,7 +814,8 @@ static int qcom_swrm_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, ctrl->irq, NULL,
qcom_swrm_irq_handler,
- IRQF_TRIGGER_RISING,
+ IRQF_TRIGGER_RISING |
+ IRQF_ONESHOT,
"soundwire", ctrl);
if (ret) {
dev_err(dev, "Failed to request soundwire irq\n");
--
2.6.2
[PATCH -next] iwlwifi: pcie: Use bitwise instead of arithmetic operator for flags
This silences the following coccinelle warning: "WARNING: sum of probable bitmasks, consider |" Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c index a0daae0..6d9bf9f 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c @@ -109,9 +109,9 @@ void iwl_trans_pcie_dump_regs(struct iwl_trans *trans) /* Alloc a max size buffer */ alloc_size = PCI_ERR_ROOT_ERR_SRC + 4 + PREFIX_LEN; - alloc_size = max_t(u32, alloc_size, PCI_DUMP_SIZE + PREFIX_LEN); - alloc_size = max_t(u32, alloc_size, PCI_MEM_DUMP_SIZE + PREFIX_LEN); - alloc_size = max_t(u32, alloc_size, PCI_PARENT_DUMP_SIZE + PREFIX_LEN); + alloc_size = max_t(u32, alloc_size, PCI_DUMP_SIZE | PREFIX_LEN); + alloc_size = max_t(u32, alloc_size, PCI_MEM_DUMP_SIZE | PREFIX_LEN); + alloc_size = max_t(u32, alloc_size, PCI_PARENT_DUMP_SIZE | PREFIX_LEN); buf = kmalloc(alloc_size, GFP_ATOMIC); if (!buf) -- 2.6.2
[PATCH -next] net: ethernet: ti: Use PTR_ERR_OR_ZERO() to simplify code
Fixes coccicheck warning:
drivers/net/ethernet/ti/am65-cpts.c:1017:1-3: WARNING: PTR_ERR_OR_ZERO can be
used
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/net/ethernet/ti/am65-cpts.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/ti/am65-cpts.c
b/drivers/net/ethernet/ti/am65-cpts.c
index 370162c..51c94b2 100644
--- a/drivers/net/ethernet/ti/am65-cpts.c
+++ b/drivers/net/ethernet/ti/am65-cpts.c
@@ -1014,10 +1014,7 @@ static int am65_cpts_probe(struct platform_device *pdev)
return PTR_ERR(base);
cpts = am65_cpts_create(dev, base, node);
- if (IS_ERR(cpts))
- return PTR_ERR(cpts);
-
- return 0;
+ return PTR_ERR_OR_ZERO(cpts);
}
static const struct of_device_id am65_cpts_of_match[] = {
--
2.6.2
[PATCH -next] powerpc/kernel/sysfs: Use ARRAY_SIZE instead of calculating the array size
fix coccinelle warning, use ARRAY_SIZE arch/powerpc/kernel/sysfs.c:853:34-35: WARNING: Use ARRAY_SIZE arch/powerpc/kernel/sysfs.c:860:33-34: WARNING: Use ARRAY_SIZE arch/powerpc/kernel/sysfs.c:868:28-29: WARNING: Use ARRAY_SIZE arch/powerpc/kernel/sysfs.c:947:34-35: WARNING: Use ARRAY_SIZE arch/powerpc/kernel/sysfs.c:954:33-34: WARNING: Use ARRAY_SIZE arch/powerpc/kernel/sysfs.c:962:28-29: WARNING: Use ARRAY_SIZE Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- arch/powerpc/kernel/sysfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kernel/sysfs.c b/arch/powerpc/kernel/sysfs.c index 571b325..13d2423 100644 --- a/arch/powerpc/kernel/sysfs.c +++ b/arch/powerpc/kernel/sysfs.c @@ -850,14 +850,14 @@ static int register_cpu_online(unsigned int cpu) #ifdef HAS_PPC_PMC_IBM case PPC_PMC_IBM: attrs = ibm_common_attrs; - nattrs = sizeof(ibm_common_attrs) / sizeof(struct device_attribute); + nattrs = ARRAY_SIZE(ibm_common_attrs); pmc_attrs = classic_pmc_attrs; break; #endif /* HAS_PPC_PMC_IBM */ #ifdef HAS_PPC_PMC_G4 case PPC_PMC_G4: attrs = g4_common_attrs; - nattrs = sizeof(g4_common_attrs) / sizeof(struct device_attribute); + nattrs = ARRAY_SIZE(g4_common_attrs); pmc_attrs = classic_pmc_attrs; break; #endif /* HAS_PPC_PMC_G4 */ @@ -865,7 +865,7 @@ static int register_cpu_online(unsigned int cpu) case PPC_PMC_PA6T: /* PA Semi starts counting at PMC0 */ attrs = pa6t_attrs; - nattrs = sizeof(pa6t_attrs) / sizeof(struct device_attribute); + nattrs = ARRAY_SIZE(pa6t_attrs); pmc_attrs = NULL; break; #endif @@ -944,14 +944,14 @@ static int unregister_cpu_online(unsigned int cpu) #ifdef HAS_PPC_PMC_IBM case PPC_PMC_IBM: attrs = ibm_common_attrs; - nattrs = sizeof(ibm_common_attrs) / sizeof(struct device_attribute); + nattrs = ARRAY_SIZE(ibm_common_attrs); pmc_attrs = classic_pmc_attrs; break; #endif /* HAS_PPC_PMC_IBM */ #ifdef HAS_PPC_PMC_G4 case PPC_PMC_G4: attrs = g4_common_attrs; - nattrs = sizeof(g4_common_attrs) / sizeof(struct device_attribute); + nattrs = ARRAY_SIZE(g4_common_attrs); pmc_attrs = classic_pmc_attrs; break; #endif /* HAS_PPC_PMC_G4 */ @@ -959,7 +959,7 @@ static int unregister_cpu_online(unsigned int cpu) case PPC_PMC_PA6T: /* PA Semi starts counting at PMC0 */ attrs = pa6t_attrs; - nattrs = sizeof(pa6t_attrs) / sizeof(struct device_attribute); + nattrs = ARRAY_SIZE(pa6t_attrs); pmc_attrs = NULL; break; #endif -- 2.6.2
Re: [PATCH -next] cpupower: Remove unneeded semicolon
Hi Shuah, I run with the below command, and get the output report. [local-host linux-next]# make coccicheck MODE=report M=tools/power/cpupower/utils Please check for false positives in the output before submitting a patch. When using "patch" mode, carefully review the patch before submitting it. tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:175:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:56:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:75:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/snb_idle.c:80:2-3: Unneeded semicolon tools/power/cpupower/utils/cpupower-set.c:75:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c:82:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/amd_fam14h_idle.c:120:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/nhm_idle.c:94:2-3: Unneeded semicolon tools/power/cpupower/utils/cpupower-info.c:65:2-3: Unneeded semicolon On 2020/5/2 1:07, shuah wrote: Hi Zou Wei, On 4/28/20 3:43 AM, Zou Wei wrote: Fixes coccicheck warnings: I am not finding these in my coccicheck run. Can you send me the options you are using? tools/power/cpupower/utils/cpupower-info.c:65:2-3: Unneeded semicolon tools/power/cpupower/utils/cpupower-set.c:75:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/amd_fam14h_idle.c:120:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:175:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:56:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:75:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c:82:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/nhm_idle.c:94:2-3: Unneeded semicolon tools/power/cpupower/utils/idle_monitor/snb_idle.c:80:2-3: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: Zou Wei --- tools/power/cpupower/utils/cpupower-info.c | 2 +- tools/power/cpupower/utils/cpupower-set.c | 2 +- tools/power/cpupower/utils/idle_monitor/amd_fam14h_idle.c | 2 +- tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c | 6 +++--- tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c | 2 +- tools/power/cpupower/utils/idle_monitor/nhm_idle.c | 2 +- tools/power/cpupower/utils/idle_monitor/snb_idle.c | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/power/cpupower/utils/cpupower-info.c b/tools/power/cpupower/utils/cpupower-info.c index d3755ea..0ba61a2 100644 --- a/tools/power/cpupower/utils/cpupower-info.c +++ b/tools/power/cpupower/utils/cpupower-info.c @@ -62,7 +62,7 @@ int cmd_info(int argc, char **argv) default: print_wrong_arg_exit(); } - }; + } The patch itself is fine. thanks, -- Shuah .
Re: [PATCH -next v2] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg_handler
On 2020/4/30 2:43, David Miller wrote: From: Zou Wei Date: Wed, 29 Apr 2020 12:17:40 +0800 fix coccinelle warning, use ARRAY_SIZE drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use ARRAY_SIZE -- Please don't put this "---" here. diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c index b24788e..af70cca 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c @@ -704,17 +704,15 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in, struct hinic_hwdev *dev = hwdev; struct hinic_func_to_io *nic_io; struct hinic_pfhwdev *pfhwdev; - u32 i, cmd_number; + u32 i; int err = 0; Please preserve the reverse christmas tree ordering of local variables. . Thanks，I will modify and send v3 patch
Re: [PATCH -next] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg_handler
Hi Joe,
Thanks for your comments, I will modify and send the v2
On 2020/4/29 11:23, Joe Perches wrote:
On Wed, 2020-04-29 at 11:15 +0800, Zou Wei wrote:
fix coccinelle warning, use ARRAY_SIZE
drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use
ARRAY_SIZE
Reported-by: Hulk Robot
Signed-off-by: Zou Wei
---
drivers/net/ethernet/huawei/hinic/hinic_sriov.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
index b24788e..ac12725 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
@@ -710,8 +710,7 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd,
void *buf_in,
if (!hwdev)
return -EFAULT;
- cmd_number = sizeof(nic_vf_cmd_msg_handler) /
- sizeof(struct vf_cmd_msg_handle);
+ cmd_number = ARRAY_SIZE(nic_vf_cmd_msg_handler);
pfhwdev = container_of(dev, struct hinic_pfhwdev, hwdev);
nic_io = &dev->func_to_io;
for (i = 0; i < cmd_number; i++) {
Probably better to remove cmd_number altogether
---
drivers/net/ethernet/huawei/hinic/hinic_sriov.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
index b24788..af70cc 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
@@ -704,17 +704,15 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd,
void *buf_in,
struct hinic_hwdev *dev = hwdev;
struct hinic_func_to_io *nic_io;
struct hinic_pfhwdev *pfhwdev;
- u32 i, cmd_number;
+ u32 i;
int err = 0;
if (!hwdev)
return -EFAULT;
- cmd_number = sizeof(nic_vf_cmd_msg_handler) /
- sizeof(struct vf_cmd_msg_handle);
pfhwdev = container_of(dev, struct hinic_pfhwdev, hwdev);
nic_io = &dev->func_to_io;
- for (i = 0; i < cmd_number; i++) {
+ for (i = 0; i < ARRAY_SIZE(nic_vf_cmd_msg_handler); i++) {
vf_msg_handle = &nic_vf_cmd_msg_handler[i];
if (cmd == vf_msg_handle->cmd &&
vf_msg_handle->cmd_msg_handler) {
@@ -725,7 +723,7 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd,
void *buf_in,
break;
}
}
- if (i == cmd_number)
+ if (i == ARRAY_SIZE(nic_vf_cmd_msg_handler))
err = hinic_msg_to_mgmt(&pfhwdev->pf_to_mgmt, HINIC_MOD_L2NIC,
cmd, buf_in, in_size, buf_out,
out_size, HINIC_MGMT_MSG_SYNC);
.
