[PATCH v6 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART
This was not enabled in the matisse-wifi tree. Without this, it is not
possible to use the USB port for serial debugging via a "Carkit debug
cable".
Signed-off-by: Stefan Hansson
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Konrad Dybcio
---
.../boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi| 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
index 24ed2ba85d62..a15a44fc0181 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
@@ -219,6 +219,10 @@ muic: usb-switch@25 {
};
};
+&blsp1_uart3 {
+ status = "okay";
+};
+
&rpm_requests {
regulators {
compatible = "qcom,rpm-pm8226-regulators";
--
2.43.0
[PATCH v6 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
based on the MSM8926 platform.
The common dtsi is also modified to describe the widest constraints,
which required modifications to the matisse-wifi dts.
Signed-off-by: Stefan Hansson
Reviewed-by: Krzysztof Kozlowski
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom-apq8026-samsung-matisse-wifi.dts | 8
.../qcom-msm8226-samsung-matisse-common.dtsi | 4 +-
.../qcom/qcom-msm8926-samsung-matisselte.dts | 37 +++
4 files changed, 48 insertions(+), 2 deletions(-)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index 9cc1e14e6cd0..6478a39b3be5 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -36,6 +36,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-msm8926-microsoft-superman-lte.dtb \
qcom-msm8926-microsoft-tesla.dtb \
qcom-msm8926-motorola-peregrine.dtb \
+ qcom-msm8926-samsung-matisselte.dtb \
qcom-msm8960-cdp.dtb \
qcom-msm8960-samsung-expressatt.dtb \
qcom-msm8974-lge-nexus5-hammerhead.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
index ac8aef5f9d09..da3be658e822 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -73,6 +73,14 @@ touchscreen@4a {
};
};
+&pm8226_l3 {
+ regulator-max-microvolt = <1337500>;
+};
+
+&pm8226_s4 {
+ regulator-max-microvolt = <180>;
+};
+
&tlmm {
tsp_en1_default_state: tsp-en1-default-state {
pins = "gpio73";
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
index 6d116f9b443b..24ed2ba85d62 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
@@ -230,7 +230,7 @@ pm8226_s3: s3 {
pm8226_s4: s4 {
regulator-min-microvolt = <180>;
- regulator-max-microvolt = <180>;
+ regulator-max-microvolt = <220>;
};
pm8226_s5: s5 {
@@ -250,7 +250,7 @@ pm8226_l2: l2 {
pm8226_l3: l3 {
regulator-min-microvolt = <75>;
- regulator-max-microvolt = <1337500>;
+ regulator-max-microvolt = <135>;
regulator-always-on;
};
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
new file mode 100644
index ..d0e1bc39f8ef
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
@@ -0,0 +1,37 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2022, Matti Lehtimäki
+ * Copyright (c) 2023, Stefan Hansson
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-samsung-matisse-common.dtsi"
+
+/ {
+ model = "Samsung Galaxy Tab 4 10.1 LTE";
+ compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
+ chassis-type = "tablet";
+
+ reg_tsp_3p3v: regulator-tsp-3p3v {
+ compatible = "regulator-fixed";
+ regulator-name = "tsp_3p3v";
+ regulator-min-microvolt = <330>;
+ regulator-max-microvolt = <330>;
+
+ gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&tsp_en1_default_state>;
+ };
+};
+
+&tlmm {
+ tsp_en1_default_state: tsp-en1-default-state {
+ pins = "gpio32";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+};
--
2.43.0
[PATCH v6 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE
This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 2b993b4c51dc..66beaac60e1d 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -146,6 +146,7 @@ properties: - microsoft,superman-lte - microsoft,tesla - motorola,peregrine + - samsung,matisselte - const: qcom,msm8926 - const: qcom,msm8226 -- 2.43.0
[PATCH v6 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree
According to the dts from the kernel source code released by Samsung,
matissewifi and matisselte only have minor differences in hardware, so
use a shared dtsi to reduce duplicated code. Additionally, this should
make adding support for matisse3g easier should someone want to do that
at a later point.
As such, add a common device tree for all matisse devices by Samsung
based on the matissewifi dts. Support for matisselte will be introduced
in a later patch in this series and will use the common dtsi as well.
Signed-off-by: Stefan Hansson
Reviewed-by: Krzysztof Kozlowski
---
.../qcom-apq8026-samsung-matisse-wifi.dts | 609 +++---
... qcom-msm8226-samsung-matisse-common.dtsi} | 73 ---
2 files changed, 83 insertions(+), 599 deletions(-)
rewrite arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts (84%)
copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts =>
qcom-msm8226-samsung-matisse-common.dtsi} (85%)
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
dissimilarity index 84%
index 0c28309c6cc5..ac8aef5f9d09 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -1,526 +1,83 @@
-// SPDX-License-Identifier: BSD-3-Clause
-/*
- * Copyright (c) 2022, Matti Lehtimäki
- */
-
-/dts-v1/;
-
-#include
-#include "qcom-msm8226.dtsi"
-#include "pm8226.dtsi"
-
-/delete-node/ &adsp_region;
-/delete-node/ &smem_region;
-
-/ {
- model = "Samsung Galaxy Tab 4 10.1";
- compatible = "samsung,matisse-wifi", "qcom,apq8026";
- chassis-type = "tablet";
-
- aliases {
- mmc0 = &sdhc_1; /* SDC1 eMMC slot */
- mmc1 = &sdhc_2; /* SDC2 SD card slot */
- display0 = &framebuffer0;
- };
-
- chosen {
- #address-cells = <1>;
- #size-cells = <1>;
- ranges;
-
- stdout-path = "display0";
-
- framebuffer0: framebuffer@320 {
- compatible = "simple-framebuffer";
- reg = <0x0320 0x80>;
- width = <1280>;
- height = <800>;
- stride = <(1280 * 3)>;
- format = "r8g8b8";
- };
- };
-
- gpio-hall-sensor {
- compatible = "gpio-keys";
-
- event-hall-sensor {
- label = "Hall Effect Sensor";
- gpios = <&tlmm 110 GPIO_ACTIVE_LOW>;
- linux,input-type = ;
- linux,code = ;
- debounce-interval = <15>;
- linux,can-disable;
- wakeup-source;
- };
- };
-
- gpio-keys {
- compatible = "gpio-keys";
- autorepeat;
-
- key-home {
- label = "Home";
- gpios = <&tlmm 108 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
-
- key-volume-down {
- label = "Volume Down";
- gpios = <&tlmm 107 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
-
- key-volume-up {
- label = "Volume Up";
- gpios = <&tlmm 106 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
- };
-
- i2c-backlight {
- compatible = "i2c-gpio";
- sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
- scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
-
- pinctrl-0 = <&backlight_i2c_default_state>;
- pinctrl-names = "default";
-
- i2c-gpio,delay-us = <4>;
-
- #address-cells = <1>;
- #size-cells = <0>;
-
- backlight@2c {
- compatible = "ti,lp8556";
- reg = <0x2c>;
-
- dev-ctrl = /bits/ 8 <0x80>;
- init-brt = /bits/ 8 <0x3f>;
-
- pwms = <&backlight_pwm 0 10>;
- pwm-names = "lp8556";
-
- rom-a0h {
- rom-addr = /bits/ 8 <0xa0>;
-
[PATCH v6 0/4] Add samsung-matisselte and common matisse dtsi
This series adds a common samsung-matisse dtsi and reworks
samsung-matisse-wifi to use it, and introduces samsung-matisselte. I
choose matisselte over matisse-lte as this is how most other devices
(klte, s3ve3g) do it and it is the codename that Samsung gave the
device. See individual commits for more information.
---
Changes since v1:
- Rebased on latest linux-next
- Added qcom,msm8226 compatible to matisselte inspired by recent Lumia
830 patch. This is done as in v1, the patch was rejected because I
included the msm8226 dtsi despite not marking matisselte as
compatible with msm8226, and I was not sure how to resolve that. As
such, I'm copying what was done in the Lumia 830 (microsoft-tesla)
patch given that it was accepted.
Changes since v2:
- Updated commit message for UART patch to explain why it was added.
- Gave more flags to git to provide a hopefully more readable patch.
Changes since v3:
- Collect tags.
- Remove spurious copyright notice.
- Miscellaneous fixes following review feedback.
Changes since v4:
- Collect tags.
- Enable SD card support on matisselte.
Changes since v5:
- Rebased on latest linux-next.
Stefan Hansson (4):
ARM: dts: qcom: samsung-matisse-common: Add initial common device tree
dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE
ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE
(SM-T535)
ARM: dts: qcom: samsung-matisse-common: Add UART
.../devicetree/bindings/arm/qcom.yaml | 1 +
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom-apq8026-samsung-matisse-wifi.dts | 617 +++---
... qcom-msm8226-samsung-matisse-common.dtsi} | 75 +--
.../qcom/qcom-msm8926-samsung-matisselte.dts | 37 ++
5 files changed, 133 insertions(+), 598 deletions(-)
rewrite arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts (84%)
copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts =>
qcom-msm8226-samsung-matisse-common.dtsi} (85%)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
--
2.43.0
[PATCH v5 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree
According to the dts from the kernel source code released by Samsung,
matissewifi and matisselte only have minor differences in hardware, so
use a shared dtsi to reduce duplicated code. Additionally, this should
make adding support for matisse3g easier should someone want to do that
at a later point.
As such, add a common device tree for all matisse devices by Samsung
based on the matissewifi dts. Support for matisselte will be introduced
in a later patch in this series and will use the common dtsi as well.
Signed-off-by: Stefan Hansson
Reviewed-by: Krzysztof Kozlowski
---
.../qcom-apq8026-samsung-matisse-wifi.dts | 595 +++---
... qcom-msm8226-samsung-matisse-common.dtsi} | 66 --
2 files changed, 76 insertions(+), 585 deletions(-)
rewrite arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts (85%)
copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts =>
qcom-msm8226-samsung-matisse-common.dtsi} (86%)
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
dissimilarity index 85%
index f516e0426bb9..b0da51f67539 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -1,519 +1,76 @@
-// SPDX-License-Identifier: BSD-3-Clause
-/*
- * Copyright (c) 2022, Matti Lehtimäki
- */
-
-/dts-v1/;
-
-#include
-#include "qcom-msm8226.dtsi"
-#include "qcom-pm8226.dtsi"
-
-/delete-node/ &adsp_region;
-/delete-node/ &smem_region;
-
-/ {
- model = "Samsung Galaxy Tab 4 10.1";
- compatible = "samsung,matisse-wifi", "qcom,apq8026";
- chassis-type = "tablet";
-
- aliases {
- mmc0 = &sdhc_1; /* SDC1 eMMC slot */
- mmc1 = &sdhc_2; /* SDC2 SD card slot */
- display0 = &framebuffer0;
- };
-
- chosen {
- #address-cells = <1>;
- #size-cells = <1>;
- ranges;
-
- stdout-path = "display0";
-
- framebuffer0: framebuffer@320 {
- compatible = "simple-framebuffer";
- reg = <0x0320 0x80>;
- width = <1280>;
- height = <800>;
- stride = <(1280 * 3)>;
- format = "r8g8b8";
- };
- };
-
- gpio-hall-sensor {
- compatible = "gpio-keys";
-
- event-hall-sensor {
- label = "Hall Effect Sensor";
- gpios = <&tlmm 110 GPIO_ACTIVE_LOW>;
- linux,input-type = ;
- linux,code = ;
- debounce-interval = <15>;
- linux,can-disable;
- wakeup-source;
- };
- };
-
- gpio-keys {
- compatible = "gpio-keys";
- autorepeat;
-
- key-home {
- label = "Home";
- gpios = <&tlmm 108 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
-
- key-volume-down {
- label = "Volume Down";
- gpios = <&tlmm 107 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
-
- key-volume-up {
- label = "Volume Up";
- gpios = <&tlmm 106 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
- };
-
- i2c-backlight {
- compatible = "i2c-gpio";
- sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
- scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
-
- pinctrl-0 = <&backlight_i2c_default_state>;
- pinctrl-names = "default";
-
- i2c-gpio,delay-us = <4>;
-
- #address-cells = <1>;
- #size-cells = <0>;
-
- backlight@2c {
- compatible = "ti,lp8556";
- reg = <0x2c>;
-
- dev-ctrl = /bits/ 8 <0x80>;
- init-brt = /bits/ 8 <0x3f>;
-
- pwms = <&backlight_pwm 0 10>;
- pwm-names = "lp8556";
-
- rom-a0h {
- rom-addr = /bits/ 8 <0xa0>;
-
[PATCH v5 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
based on the MSM8926 platform.
The common dtsi is also modified to describe the widest constraints,
which required modifications to the matisse-wifi dts.
Signed-off-by: Stefan Hansson
Reviewed-by: Krzysztof Kozlowski
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom-apq8026-samsung-matisse-wifi.dts | 8
.../qcom-msm8226-samsung-matisse-common.dtsi | 4 +-
.../qcom/qcom-msm8926-samsung-matisselte.dts | 37 +++
4 files changed, 48 insertions(+), 2 deletions(-)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index a3d293e40820..cab35eeb30f6 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-msm8916-samsung-serranove.dtb \
qcom-msm8926-microsoft-superman-lte.dtb \
qcom-msm8926-microsoft-tesla.dtb \
+ qcom-msm8926-samsung-matisselte.dtb \
qcom-msm8960-cdp.dtb \
qcom-msm8960-samsung-expressatt.dtb \
qcom-msm8974-lge-nexus5-hammerhead.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
index b0da51f67539..3be02bdbb919 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -66,6 +66,14 @@ touchscreen@4a {
};
};
+&pm8226_l3 {
+ regulator-max-microvolt = <1337500>;
+};
+
+&pm8226_s4 {
+ regulator-max-microvolt = <180>;
+};
+
&tlmm {
tsp_en1_default_state: tsp-en1-default-state {
pins = "gpio73";
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
index ef98d88927ca..28317ce79e97 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
@@ -230,7 +230,7 @@ pm8226_s3: s3 {
pm8226_s4: s4 {
regulator-min-microvolt = <180>;
- regulator-max-microvolt = <180>;
+ regulator-max-microvolt = <220>;
};
pm8226_s5: s5 {
@@ -250,7 +250,7 @@ pm8226_l2: l2 {
pm8226_l3: l3 {
regulator-min-microvolt = <75>;
- regulator-max-microvolt = <1337500>;
+ regulator-max-microvolt = <135>;
regulator-always-on;
};
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
new file mode 100644
index ..d0e1bc39f8ef
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
@@ -0,0 +1,37 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2022, Matti Lehtimäki
+ * Copyright (c) 2023, Stefan Hansson
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-samsung-matisse-common.dtsi"
+
+/ {
+ model = "Samsung Galaxy Tab 4 10.1 LTE";
+ compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
+ chassis-type = "tablet";
+
+ reg_tsp_3p3v: regulator-tsp-3p3v {
+ compatible = "regulator-fixed";
+ regulator-name = "tsp_3p3v";
+ regulator-min-microvolt = <330>;
+ regulator-max-microvolt = <330>;
+
+ gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&tsp_en1_default_state>;
+ };
+};
+
+&tlmm {
+ tsp_en1_default_state: tsp-en1-default-state {
+ pins = "gpio32";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+};
--
2.41.0
[PATCH v5 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE
This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 88b84035e7b1..242ffe89c6c6 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -196,6 +196,7 @@ properties: - enum: - microsoft,superman-lte - microsoft,tesla + - samsung,matisselte - const: qcom,msm8926 - const: qcom,msm8226 -- 2.41.0
[PATCH v5 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART
This was not enabled in the matisse-wifi tree. Without this, it is not
possible to use the USB port for serial debugging via a "Carkit debug
cable".
Signed-off-by: Stefan Hansson
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Konrad Dybcio
---
.../boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi| 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
index 28317ce79e97..dc63b91f94bc 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
@@ -219,6 +219,10 @@ muic: usb-switch@25 {
};
};
+&blsp1_uart3 {
+ status = "okay";
+};
+
&rpm_requests {
regulators {
compatible = "qcom,rpm-pm8226-regulators";
--
2.41.0
[PATCH v5 0/4] Add samsung-matisselte and common matisse dtsi
This series adds a common samsung-matisse dtsi and reworks
samsung-matisse-wifi to use it, and introduces samsung-matisselte. I
choose matisselte over matisse-lte as this is how most other devices
(klte, s3ve3g) do it and it is the codename that Samsung gave the
device. See individual commits for more information.
---
Changes since v1:
- Rebased on latest linux-next
- Added qcom,msm8226 compatible to matisselte inspired by recent Lumia
830 patch. This is done as in v1, the patch was rejected because I
included the msm8226 dtsi despite not marking matisselte as
compatible with msm8226, and I was not sure how to resolve that. As
such, I'm copying what was done in the Lumia 830 (microsoft-tesla)
patch given that it was accepted.
Changes since v2:
- Updated commit message for UART patch to explain why it was added.
- Gave more flags to git to provide a hopefully more readable patch.
Changes since v3:
- Collect tags.
- Remove spurious copyright notice.
- Miscellaneous fixes following review feedback.
Changes since v4:
- Collect tags.
- Enable SD card support on matisselte.
Stefan Hansson (4):
ARM: dts: qcom: samsung-matisse-common: Add initial common device tree
dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE
ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE
(SM-T535)
ARM: dts: qcom: samsung-matisse-common: Add UART
.../devicetree/bindings/arm/qcom.yaml | 1 +
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom-apq8026-samsung-matisse-wifi.dts | 603 +++---
... qcom-msm8226-samsung-matisse-common.dtsi} | 68 +-
.../qcom/qcom-msm8926-samsung-matisselte.dts | 37 ++
5 files changed, 126 insertions(+), 584 deletions(-)
rewrite arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts (85%)
copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts =>
qcom-msm8226-samsung-matisse-common.dtsi} (86%)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
--
2.41.0
Re: [PATCH v3 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)
On 2023-10-31 12:08, Konrad Dybcio wrote:
On 25.10.2023 10:37, Stefan Hansson wrote:
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
based on the MSM8926 platform.
Signed-off-by: Stefan Hansson
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom/qcom-msm8926-samsung-matisselte.dts | 36 +++
2 files changed, 37 insertions(+)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index a3d293e40820..cab35eeb30f6 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-msm8916-samsung-serranove.dtb \
qcom-msm8926-microsoft-superman-lte.dtb \
qcom-msm8926-microsoft-tesla.dtb \
+ qcom-msm8926-samsung-matisselte.dtb \
qcom-msm8960-cdp.dtb \
qcom-msm8960-samsung-expressatt.dtb \
qcom-msm8974-lge-nexus5-hammerhead.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
new file mode 100644
index ..6e25b1a74ce5
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2022, Matti Lehtimäki
+ * Copyright (c) 2023, Stefan Hansson
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-samsung-matisse-common.dtsi"
+
+/ {
+ model = "Samsung Galaxy Tab 4 10.1 LTE";
+ compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
+ chassis-type = "tablet";
+};
+
+&pm8226_l3 {
+ regulator-max-microvolt = <135>;
+};
+
+&pm8226_s4 {
+ regulator-max-microvolt = <220>;
+};
+
+®_tsp_3p3v {
+ gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
+};
+
+&sdhc_2 {
+ /* SD card fails to probe with error -110 */
+ status = "disabled";
Can you give us some logs?
I tested it again just now, and it worked without issues. Maybe I used a
defective SD card to test it or hadn't inserted it properly. I'll send
another revision fixing this.
Konrad
Stefan
[PATCH v4 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
based on the MSM8926 platform.
The common dtsi is also modified to describe the widest constraints,
which required modifications to the matisse-wifi dts.
Signed-off-by: Stefan Hansson
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom-apq8026-samsung-matisse-wifi.dts | 8
.../qcom-msm8226-samsung-matisse-common.dtsi | 4 +-
.../qcom/qcom-msm8926-samsung-matisselte.dts | 42 +++
4 files changed, 53 insertions(+), 2 deletions(-)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index a3d293e40820..cab35eeb30f6 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-msm8916-samsung-serranove.dtb \
qcom-msm8926-microsoft-superman-lte.dtb \
qcom-msm8926-microsoft-tesla.dtb \
+ qcom-msm8926-samsung-matisselte.dtb \
qcom-msm8960-cdp.dtb \
qcom-msm8960-samsung-expressatt.dtb \
qcom-msm8974-lge-nexus5-hammerhead.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
index b0da51f67539..3be02bdbb919 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -66,6 +66,14 @@ touchscreen@4a {
};
};
+&pm8226_l3 {
+ regulator-max-microvolt = <1337500>;
+};
+
+&pm8226_s4 {
+ regulator-max-microvolt = <180>;
+};
+
&tlmm {
tsp_en1_default_state: tsp-en1-default-state {
pins = "gpio73";
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
index ef98d88927ca..28317ce79e97 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
@@ -230,7 +230,7 @@ pm8226_s3: s3 {
pm8226_s4: s4 {
regulator-min-microvolt = <180>;
- regulator-max-microvolt = <180>;
+ regulator-max-microvolt = <220>;
};
pm8226_s5: s5 {
@@ -250,7 +250,7 @@ pm8226_l2: l2 {
pm8226_l3: l3 {
regulator-min-microvolt = <75>;
- regulator-max-microvolt = <1337500>;
+ regulator-max-microvolt = <135>;
regulator-always-on;
};
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
new file mode 100644
index ..3e312f95c1fe
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
@@ -0,0 +1,42 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2022, Matti Lehtimäki
+ * Copyright (c) 2023, Stefan Hansson
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-samsung-matisse-common.dtsi"
+
+/ {
+ model = "Samsung Galaxy Tab 4 10.1 LTE";
+ compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
+ chassis-type = "tablet";
+
+ reg_tsp_3p3v: regulator-tsp-3p3v {
+ compatible = "regulator-fixed";
+ regulator-name = "tsp_3p3v";
+ regulator-min-microvolt = <330>;
+ regulator-max-microvolt = <330>;
+
+ gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&tsp_en1_default_state>;
+ };
+};
+
+&sdhc_2 {
+ /* SD card fails to probe with error -110 */
+ status = "disabled";
+};
+
+&tlmm {
+ tsp_en1_default_state: tsp-en1-default-state {
+ pins = "gpio32";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+};
--
2.41.0
[PATCH v4 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART
This was not enabled in the matisse-wifi tree. Without this, it is not
possible to use the USB port for serial debugging via a "Carkit debug
cable".
Signed-off-by: Stefan Hansson
---
.../boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi| 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
index 28317ce79e97..dc63b91f94bc 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
@@ -219,6 +219,10 @@ muic: usb-switch@25 {
};
};
+&blsp1_uart3 {
+ status = "okay";
+};
+
&rpm_requests {
regulators {
compatible = "qcom,rpm-pm8226-regulators";
--
2.41.0
[PATCH v4 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE
This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 88b84035e7b1..242ffe89c6c6 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -196,6 +196,7 @@ properties: - enum: - microsoft,superman-lte - microsoft,tesla + - samsung,matisselte - const: qcom,msm8926 - const: qcom,msm8226 -- 2.41.0
[PATCH v4 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree
According to the dts from the kernel source code released by Samsung,
matissewifi and matisselte only have minor differences in hardware, so
use a shared dtsi to reduce duplicated code. Additionally, this should
make adding support for matisse3g easier should someone want to do that
at a later point.
As such, add a common device tree for all matisse devices by Samsung
based on the matissewifi dts. Support for matisselte will be introduced
in a later patch in this series and will use the common dtsi as well.
Signed-off-by: Stefan Hansson
---
.../qcom-apq8026-samsung-matisse-wifi.dts | 595 +++---
... qcom-msm8226-samsung-matisse-common.dtsi} | 66 --
2 files changed, 76 insertions(+), 585 deletions(-)
rewrite arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts (85%)
copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts =>
qcom-msm8226-samsung-matisse-common.dtsi} (86%)
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
dissimilarity index 85%
index f516e0426bb9..b0da51f67539 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -1,519 +1,76 @@
-// SPDX-License-Identifier: BSD-3-Clause
-/*
- * Copyright (c) 2022, Matti Lehtimäki
- */
-
-/dts-v1/;
-
-#include
-#include "qcom-msm8226.dtsi"
-#include "qcom-pm8226.dtsi"
-
-/delete-node/ &adsp_region;
-/delete-node/ &smem_region;
-
-/ {
- model = "Samsung Galaxy Tab 4 10.1";
- compatible = "samsung,matisse-wifi", "qcom,apq8026";
- chassis-type = "tablet";
-
- aliases {
- mmc0 = &sdhc_1; /* SDC1 eMMC slot */
- mmc1 = &sdhc_2; /* SDC2 SD card slot */
- display0 = &framebuffer0;
- };
-
- chosen {
- #address-cells = <1>;
- #size-cells = <1>;
- ranges;
-
- stdout-path = "display0";
-
- framebuffer0: framebuffer@320 {
- compatible = "simple-framebuffer";
- reg = <0x0320 0x80>;
- width = <1280>;
- height = <800>;
- stride = <(1280 * 3)>;
- format = "r8g8b8";
- };
- };
-
- gpio-hall-sensor {
- compatible = "gpio-keys";
-
- event-hall-sensor {
- label = "Hall Effect Sensor";
- gpios = <&tlmm 110 GPIO_ACTIVE_LOW>;
- linux,input-type = ;
- linux,code = ;
- debounce-interval = <15>;
- linux,can-disable;
- wakeup-source;
- };
- };
-
- gpio-keys {
- compatible = "gpio-keys";
- autorepeat;
-
- key-home {
- label = "Home";
- gpios = <&tlmm 108 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
-
- key-volume-down {
- label = "Volume Down";
- gpios = <&tlmm 107 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
-
- key-volume-up {
- label = "Volume Up";
- gpios = <&tlmm 106 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
- };
-
- i2c-backlight {
- compatible = "i2c-gpio";
- sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
- scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
-
- pinctrl-0 = <&backlight_i2c_default_state>;
- pinctrl-names = "default";
-
- i2c-gpio,delay-us = <4>;
-
- #address-cells = <1>;
- #size-cells = <0>;
-
- backlight@2c {
- compatible = "ti,lp8556";
- reg = <0x2c>;
-
- dev-ctrl = /bits/ 8 <0x80>;
- init-brt = /bits/ 8 <0x3f>;
-
- pwms = <&backlight_pwm 0 10>;
- pwm-names = "lp8556";
-
- rom-a0h {
- rom-addr = /bits/ 8 <0xa0>;
-
[PATCH v4 0/4] Add samsung-matisselte and common matisse dtsi
This series adds a common samsung-matisse dtsi and reworks
samsung-matisse-wifi to use it, and introduces samsung-matisselte. I
choose matisselte over matisse-lte as this is how most other devices
(klte, s3ve3g) do it and it is the codename that Samsung gave the
device. See individual commits for more information.
---
Changes since v1:
- Rebased on latest linux-next
- Added qcom,msm8226 compatible to matisselte inspired by recent Lumia
830 patch. This is done as in v1, the patch was rejected because I
included the msm8226 dtsi despite not marking matisselte as
compatible with msm8226, and I was not sure how to resolve that. As
such, I'm copying what was done in the Lumia 830 (microsoft-tesla)
patch given that it was accepted.
Changes since v2:
- Updated commit message for UART patch to explain why it was added.
- Gave more flags to git to provide a hopefully more readable patch.
Changes since v3:
- Collect tags.
- Remove spurious copyright notice.
- Miscellaneous fixes following review feedback.
Stefan Hansson (4):
ARM: dts: qcom: samsung-matisse-common: Add initial common device tree
dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE
ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE
(SM-T535)
ARM: dts: qcom: samsung-matisse-common: Add UART
.../devicetree/bindings/arm/qcom.yaml | 1 +
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom-apq8026-samsung-matisse-wifi.dts | 603 +++---
... qcom-msm8226-samsung-matisse-common.dtsi} | 68 +-
.../qcom/qcom-msm8926-samsung-matisselte.dts | 42 ++
5 files changed, 131 insertions(+), 584 deletions(-)
rewrite arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts (85%)
copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts =>
qcom-msm8226-samsung-matisse-common.dtsi} (86%)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
--
2.41.0
Re: [PATCH v3 0/4] Add samsung-matisselte and common matisse dtsi
On 2023-10-25 10:48, Krzysztof Kozlowski wrote: On 25/10/2023 10:37, Stefan Hansson wrote: This series adds a common samsung-matisse dtsi and reworks samsung-matisse-wifi to use it, and introduces samsung-matisselte. I choose matisselte over matisse-lte as this is how most other devices (klte, s3ve3g) do it and it is the codename that Samsung gave the device. See individual commits for more information. --- Changes since v1: - Rebased on latest linux-next - Added qcom,msm8226 compatible to matisselte inspired by recent Lumia 830 patch. This is done as in v1, the patch was rejected because I included the msm8226 dtsi despite not marking matisselte as compatible with msm8226, and I was not sure how to resolve that. As such, I'm copying what was done in the Lumia 830 (microsoft-tesla) patch given that it was accepted. One version per day, so you won't ignore tags. Sorry, I don't understand. Could you clarify what you mean? Thanks in advance. Best regards, Krzysztof
Re: [PATCH v3 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE
On 2023-10-25 10:48, Krzysztof Kozlowski wrote: On 25/10/2023 10:37, Stefan Hansson wrote: This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson --- This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. Yes, sorry, I just forgot about it. Thanks for the reminder. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
[PATCH v3 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
based on the MSM8926 platform.
Signed-off-by: Stefan Hansson
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom/qcom-msm8926-samsung-matisselte.dts | 36 +++
2 files changed, 37 insertions(+)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index a3d293e40820..cab35eeb30f6 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-msm8916-samsung-serranove.dtb \
qcom-msm8926-microsoft-superman-lte.dtb \
qcom-msm8926-microsoft-tesla.dtb \
+ qcom-msm8926-samsung-matisselte.dtb \
qcom-msm8960-cdp.dtb \
qcom-msm8960-samsung-expressatt.dtb \
qcom-msm8974-lge-nexus5-hammerhead.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
new file mode 100644
index ..6e25b1a74ce5
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2022, Matti Lehtimäki
+ * Copyright (c) 2023, Stefan Hansson
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-samsung-matisse-common.dtsi"
+
+/ {
+ model = "Samsung Galaxy Tab 4 10.1 LTE";
+ compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
+ chassis-type = "tablet";
+};
+
+&pm8226_l3 {
+ regulator-max-microvolt = <135>;
+};
+
+&pm8226_s4 {
+ regulator-max-microvolt = <220>;
+};
+
+®_tsp_3p3v {
+ gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
+};
+
+&sdhc_2 {
+ /* SD card fails to probe with error -110 */
+ status = "disabled";
+};
+
+&tsp_en1_default_state {
+ pins = "gpio32";
+};
--
2.41.0
[PATCH v3 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART
This was not enabled in the matisse-wifi tree. Without this, it is not
possible to use the USB port for serial debugging via a "Carkit debug
cable".
Signed-off-by: Stefan Hansson
---
.../boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi| 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
index 11fec4e963b7..35290ce63b40 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
@@ -233,6 +233,10 @@ muic: usb-switch@25 {
};
};
+&blsp1_uart3 {
+ status = "okay";
+};
+
&rpm_requests {
regulators {
compatible = "qcom,rpm-pm8226-regulators";
--
2.41.0
[PATCH v3 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree
According to the dts from the kernel source code released by Samsung,
matissewifi and matisselte only have minor differences in hardware, so
use a shared dtsi to reduce duplicated code. Additionally, this should
make adding support for matisse3g easier should someone want to do that
at a later point.
As such, add a common device tree for all matisse devices by Samsung
based on the matissewifi dts. Support for matisselte will be introduced
in a later patch in this series and will use the common dtsi as well.
Signed-off-by: Stefan Hansson
---
.../qcom-apq8026-samsung-matisse-wifi.dts | 589 +++---
... qcom-msm8226-samsung-matisse-common.dtsi} | 59 +-
2 files changed, 77 insertions(+), 571 deletions(-)
rewrite arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts (89%)
copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts =>
qcom-msm8226-samsung-matisse-common.dtsi} (90%)
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
dissimilarity index 89%
index f516e0426bb9..98d4bb797617 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -1,519 +1,70 @@
-// SPDX-License-Identifier: BSD-3-Clause
-/*
- * Copyright (c) 2022, Matti Lehtimäki
- */
-
-/dts-v1/;
-
-#include
-#include "qcom-msm8226.dtsi"
-#include "qcom-pm8226.dtsi"
-
-/delete-node/ &adsp_region;
-/delete-node/ &smem_region;
-
-/ {
- model = "Samsung Galaxy Tab 4 10.1";
- compatible = "samsung,matisse-wifi", "qcom,apq8026";
- chassis-type = "tablet";
-
- aliases {
- mmc0 = &sdhc_1; /* SDC1 eMMC slot */
- mmc1 = &sdhc_2; /* SDC2 SD card slot */
- display0 = &framebuffer0;
- };
-
- chosen {
- #address-cells = <1>;
- #size-cells = <1>;
- ranges;
-
- stdout-path = "display0";
-
- framebuffer0: framebuffer@320 {
- compatible = "simple-framebuffer";
- reg = <0x0320 0x80>;
- width = <1280>;
- height = <800>;
- stride = <(1280 * 3)>;
- format = "r8g8b8";
- };
- };
-
- gpio-hall-sensor {
- compatible = "gpio-keys";
-
- event-hall-sensor {
- label = "Hall Effect Sensor";
- gpios = <&tlmm 110 GPIO_ACTIVE_LOW>;
- linux,input-type = ;
- linux,code = ;
- debounce-interval = <15>;
- linux,can-disable;
- wakeup-source;
- };
- };
-
- gpio-keys {
- compatible = "gpio-keys";
- autorepeat;
-
- key-home {
- label = "Home";
- gpios = <&tlmm 108 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
-
- key-volume-down {
- label = "Volume Down";
- gpios = <&tlmm 107 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
-
- key-volume-up {
- label = "Volume Up";
- gpios = <&tlmm 106 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
- };
-
- i2c-backlight {
- compatible = "i2c-gpio";
- sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
- scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
-
- pinctrl-0 = <&backlight_i2c_default_state>;
- pinctrl-names = "default";
-
- i2c-gpio,delay-us = <4>;
-
- #address-cells = <1>;
- #size-cells = <0>;
-
- backlight@2c {
- compatible = "ti,lp8556";
- reg = <0x2c>;
-
- dev-ctrl = /bits/ 8 <0x80>;
- init-brt = /bits/ 8 <0x3f>;
-
- pwms = <&backlight_pwm 0 10>;
- pwm-names = "lp8556";
-
- rom-a0h {
- rom-addr = /bits/ 8 <0xa0>;
-
[PATCH v3 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE
This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 88b84035e7b1..242ffe89c6c6 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -196,6 +196,7 @@ properties: - enum: - microsoft,superman-lte - microsoft,tesla + - samsung,matisselte - const: qcom,msm8926 - const: qcom,msm8226 -- 2.41.0
[PATCH v3 0/4] Add samsung-matisselte and common matisse dtsi
This series adds a common samsung-matisse dtsi and reworks
samsung-matisse-wifi to use it, and introduces samsung-matisselte. I
choose matisselte over matisse-lte as this is how most other devices
(klte, s3ve3g) do it and it is the codename that Samsung gave the
device. See individual commits for more information.
---
Changes since v1:
- Rebased on latest linux-next
- Added qcom,msm8226 compatible to matisselte inspired by recent Lumia
830 patch. This is done as in v1, the patch was rejected because I
included the msm8226 dtsi despite not marking matisselte as
compatible with msm8226, and I was not sure how to resolve that. As
such, I'm copying what was done in the Lumia 830 (microsoft-tesla)
patch given that it was accepted.
Changes since v2:
- Updated commit message for UART patch to explain why it was added.
- Gave more flags to git to provide a hopefully more readable patch.
Stefan Hansson (4):
ARM: dts: qcom: samsung-matisse-common: Add initial common device tree
dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE
ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE
(SM-T535)
ARM: dts: qcom: samsung-matisse-common: Add UART
.../devicetree/bindings/arm/qcom.yaml | 1 +
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom-apq8026-samsung-matisse-wifi.dts | 589 +++---
... qcom-msm8226-samsung-matisse-common.dtsi} | 59 +-
.../qcom/qcom-msm8926-samsung-matisselte.dts | 36 ++
5 files changed, 117 insertions(+), 569 deletions(-)
rewrite arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts (89%)
copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts =>
qcom-msm8226-samsung-matisse-common.dtsi} (90%)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
--
2.41.0
[PATCH v2 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE
This documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) which is a tablet by Samsung based on the MSM8926 SoC. Signed-off-by: Stefan Hansson --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 88b84035e7b1..242ffe89c6c6 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -196,6 +196,7 @@ properties: - enum: - microsoft,superman-lte - microsoft,tesla + - samsung,matisselte - const: qcom,msm8926 - const: qcom,msm8226 -- 2.41.0
[PATCH v2 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART
This was not enabled in the matisse-wifi tree.
Signed-off-by: Stefan Hansson
---
.../boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi| 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
index 11fec4e963b7..35290ce63b40 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
@@ -233,6 +233,10 @@ muic: usb-switch@25 {
};
};
+&blsp1_uart3 {
+ status = "okay";
+};
+
&rpm_requests {
regulators {
compatible = "qcom,rpm-pm8226-regulators";
--
2.41.0
[PATCH v2 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree
According to the dts from the kernel source code released by Samsung,
matissewifi and matisselte only have minor differences in hardware, so
use a shared dtsi to reduce duplicated code. Additionally, this should
make adding support for matisse3g easier should someone want to do that
at a later point.
As such, add a common device tree for all matisse devices by Samsung
based on the matissewifi dts. Support for matisselte will be introduced
in a later patch in this series and will use the common dtsi as well.
Signed-off-by: Stefan Hansson
---
.../qcom-apq8026-samsung-matisse-wifi.dts | 467 +
.../qcom-msm8226-samsung-matisse-common.dtsi | 474 ++
2 files changed, 483 insertions(+), 458 deletions(-)
create mode 100644
arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
index f516e0426bb9..98d4bb797617 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -5,222 +5,12 @@
/dts-v1/;
-#include
-#include "qcom-msm8226.dtsi"
-#include "qcom-pm8226.dtsi"
-
-/delete-node/ &adsp_region;
-/delete-node/ &smem_region;
+#include "qcom-msm8226-samsung-matisse-common.dtsi"
/ {
model = "Samsung Galaxy Tab 4 10.1";
compatible = "samsung,matisse-wifi", "qcom,apq8026";
chassis-type = "tablet";
-
- aliases {
- mmc0 = &sdhc_1; /* SDC1 eMMC slot */
- mmc1 = &sdhc_2; /* SDC2 SD card slot */
- display0 = &framebuffer0;
- };
-
- chosen {
- #address-cells = <1>;
- #size-cells = <1>;
- ranges;
-
- stdout-path = "display0";
-
- framebuffer0: framebuffer@320 {
- compatible = "simple-framebuffer";
- reg = <0x0320 0x80>;
- width = <1280>;
- height = <800>;
- stride = <(1280 * 3)>;
- format = "r8g8b8";
- };
- };
-
- gpio-hall-sensor {
- compatible = "gpio-keys";
-
- event-hall-sensor {
- label = "Hall Effect Sensor";
- gpios = <&tlmm 110 GPIO_ACTIVE_LOW>;
- linux,input-type = ;
- linux,code = ;
- debounce-interval = <15>;
- linux,can-disable;
- wakeup-source;
- };
- };
-
- gpio-keys {
- compatible = "gpio-keys";
- autorepeat;
-
- key-home {
- label = "Home";
- gpios = <&tlmm 108 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
-
- key-volume-down {
- label = "Volume Down";
- gpios = <&tlmm 107 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
-
- key-volume-up {
- label = "Volume Up";
- gpios = <&tlmm 106 GPIO_ACTIVE_LOW>;
- linux,code = ;
- debounce-interval = <15>;
- };
- };
-
- i2c-backlight {
- compatible = "i2c-gpio";
- sda-gpios = <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
- scl-gpios = <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
-
- pinctrl-0 = <&backlight_i2c_default_state>;
- pinctrl-names = "default";
-
- i2c-gpio,delay-us = <4>;
-
- #address-cells = <1>;
- #size-cells = <0>;
-
- backlight@2c {
- compatible = "ti,lp8556";
- reg = <0x2c>;
-
- dev-ctrl = /bits/ 8 <0x80>;
- init-brt = /bits/ 8 <0x3f>;
-
- pwms = <&backlight_pwm 0 10>;
- pwm-names = "lp8556";
-
- rom-a0h {
- rom-addr = /bits/ 8 <0xa0>;
- rom-val = /bits/ 8 <0x44>;
- };
-
- rom-a1h {
- rom-addr = /bits/ 8
[PATCH v2 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
based on the MSM8926 platform.
Signed-off-by: Stefan Hansson
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom/qcom-msm8926-samsung-matisselte.dts | 36 +++
2 files changed, 37 insertions(+)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index a3d293e40820..cab35eeb30f6 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-msm8916-samsung-serranove.dtb \
qcom-msm8926-microsoft-superman-lte.dtb \
qcom-msm8926-microsoft-tesla.dtb \
+ qcom-msm8926-samsung-matisselte.dtb \
qcom-msm8960-cdp.dtb \
qcom-msm8960-samsung-expressatt.dtb \
qcom-msm8974-lge-nexus5-hammerhead.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
new file mode 100644
index ..6e25b1a74ce5
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2022, Matti Lehtimäki
+ * Copyright (c) 2023, Stefan Hansson
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-samsung-matisse-common.dtsi"
+
+/ {
+ model = "Samsung Galaxy Tab 4 10.1 LTE";
+ compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
+ chassis-type = "tablet";
+};
+
+&pm8226_l3 {
+ regulator-max-microvolt = <135>;
+};
+
+&pm8226_s4 {
+ regulator-max-microvolt = <220>;
+};
+
+®_tsp_3p3v {
+ gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
+};
+
+&sdhc_2 {
+ /* SD card fails to probe with error -110 */
+ status = "disabled";
+};
+
+&tsp_en1_default_state {
+ pins = "gpio32";
+};
--
2.41.0
[PATCH v2 0/4] Add samsung-matisselte and common matisse dtsi
This series adds a common samsung-matisse dtsi and reworks samsung-matisse-wifi to use it, and introduces samsung-matisselte. I choose matisselte over matisse-lte as this is how most other devices (klte, s3ve3g) do it and it is the codename that Samsung gave the device. See individual commits for more information. --- Changes since v1: - Rebased on latest linux-next - Added qcom,msm8226 compatible to matisselte inspired by recent Lumia 830 patch. This is done as in v1, the patch was rejected because I included the msm8226 dtsi despite not marking matisselte as compatible with msm8226, and I was not sure how to resolve that. As such, I'm copying what was done in the Lumia 830 (microsoft-tesla) patch given that it was accepted. Stefan Hansson (4): ARM: dts: qcom: samsung-matisse-common: Add initial common device tree dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535) ARM: dts: qcom: samsung-matisse-common: Add UART .../devicetree/bindings/arm/qcom.yaml | 1 + arch/arm/boot/dts/qcom/Makefile | 1 + .../qcom-apq8026-samsung-matisse-wifi.dts | 467 + .../qcom-msm8226-samsung-matisse-common.dtsi | 478 ++ .../qcom/qcom-msm8926-samsung-matisselte.dts | 36 ++ 5 files changed, 525 insertions(+), 458 deletions(-) create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts -- 2.41.0
