[PATCH 1/1] Input: synaptics - enable SMBus for HP 15-ay000 (SYN3221).
SMBus works fine for the touchpad with id SYN3221, used in the HP 15-ay000
series,
This device has been reported in these messages in the "linux-input" mailing
list:
* https://marc.info/?l=linux-input=152016683003369=2
* https://www.spinics.net/lists/linux-input/msg52525.html
Reported-by: Nitesh Debnath
Reported-by: Teika Kazura
Signed-off-by: Teika Kazura
---
drivers/input/mouse/synaptics.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 55d33500d5..591b776f22 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[] = {
"LEN0096", /* X280 */
"LEN0097", /* X280 -> ALPS trackpoint */
"LEN200f", /* T450s */
+ "SYN3221", /* HP 15-ay000 */
NULL
};
--
2.18.1
[PATCH 1/1] Input: synaptics - enable SMBus for HP 15-ay000 (SYN3221).
SMBus works fine for the touchpad with id SYN3221, used in the HP 15-ay000
series,
This device has been reported in these messages in the "linux-input" mailing
list:
* https://marc.info/?l=linux-input=152016683003369=2
* https://www.spinics.net/lists/linux-input/msg52525.html
Reported-by: Nitesh Debnath
Reported-by: Teika Kazura
Signed-off-by: Teika Kazura
---
drivers/input/mouse/synaptics.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 55d33500d5..591b776f22 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[] = {
"LEN0096", /* X280 */
"LEN0097", /* X280 -> ALPS trackpoint */
"LEN200f", /* T450s */
+ "SYN3221", /* HP 15-ay000 */
NULL
};
--
2.18.1
[PATCH v2] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should use RMI
The touchpads on both T25 and T480 are accessible over SMBUS/RMI.
---
v2
Only a tag change.
The original author wants to use a pseudonym, and agrees with the usurpation of
the signed-off-by tag. See https://patchwork.kernel.org/patch/10512751/
Reported-by: kitsunyan
Signed-off-by: Teika Kazura
---
drivers/input/mouse/synaptics.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 55d33500d55e..be934a082424 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -175,7 +175,9 @@ static const char * const smbus_pnp_ids[] = {
"LEN0071", /* T480 */
"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
"LEN0073", /* X1 Carbon G5 (Elantech) */
+ "LEN008e", /* T25 */
"LEN0092", /* X1 Carbon 6 */
+ "LEN0093", /* T480 */
"LEN0096", /* X280 */
"LEN0097", /* X280 -> ALPS trackpoint */
"LEN200f", /* T450s */
--
2.18.0
[PATCH v2] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should use RMI
The touchpads on both T25 and T480 are accessible over SMBUS/RMI.
---
v2
Only a tag change.
The original author wants to use a pseudonym, and agrees with the usurpation of
the signed-off-by tag. See https://patchwork.kernel.org/patch/10512751/
Reported-by: kitsunyan
Signed-off-by: Teika Kazura
---
drivers/input/mouse/synaptics.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 55d33500d55e..be934a082424 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -175,7 +175,9 @@ static const char * const smbus_pnp_ids[] = {
"LEN0071", /* T480 */
"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
"LEN0073", /* X1 Carbon G5 (Elantech) */
+ "LEN008e", /* T25 */
"LEN0092", /* X1 Carbon 6 */
+ "LEN0093", /* T480 */
"LEN0096", /* X280 */
"LEN0097", /* X280 -> ALPS trackpoint */
"LEN200f", /* T450s */
--
2.18.0
Re: [PATCH] PCI / ACPI / PM: Resume all bridges on suspend-to-RAM
For the record, about the exactness of the patch description. The patch mentions the regression by the commit c62ec4610c40, but it is not the cause of the bug (https://bugzilla.kernel.org/show_bug.cgi?id=20067) reported by me; I reverted c62ec4610c40 on linux-4.17.13, and the bug remained. # Some details: my bug was introduced by the commit (i) 877b3729ca0 on Jan 3. The commit (ii) c62ec4610c40 was on May 22. The commit (iii) 26112ddc254c on Jun 30 fixes one problem caused by c62ec4610c40. The present patch modifies the code of the commit (iii), so it can be said as the completion of the commit (iii). It at the same time fixes my bug, too. This suggests the present patch possibly fixes other unknown PM problems; former kernels had some loose end(s). Now this patch puts the kernel in a better position. I'm a lay Linux user, and don't know if this post helps. If it does, it may be worth mentioning it in the above bugzilla entry. Dziękuję (thanks), kernel developers. Best regards, Teika (Teika kazura) From: "Rafael J. Wysocki" Subject: [PATCH] PCI / ACPI / PM: Resume all bridges on suspend-to-RAM Date: Thu, 16 Aug 2018 12:56:46 +0200 > From: Rafael J. Wysocki > > Commit 26112ddc254c (PCI / ACPI / PM: Resume bridges w/o drivers on > suspend-to-RAM) attempted to fix a functional regression resulting > from commit c62ec4610c40 (PM / core: Fix direct_complete handling > for devices with no callbacks) by resuming PCI bridges without > drivers (that is, "parallel PCI" ones) during system-wide suspend if > the target system state is not ACPI S0 (working state). > > That turns out insufficient, however, as it is reported that, at > least in one case, the platform firmware gets confused if a PCIe > root port is suspended before entering the ACPI S3 sleep state. > > For this reason, drop the driver check from acpi_pci_need_resume() > and resume all bridges (including PCIe ports with drivers) during > system-wide suspend if the target system state is not ACPI S0. > > [If the target system state is ACPI S0, it means suspend-to-idle > and the platform firmware is not going to be invoked to actually > suspend the system, so there is no need to resume the bridges in > that case.] > > Fixes: c62ec4610c40 (PM / core: Fix direct_complete handling for devices with > no callbacks) > Reported-by: teika kazura > Tested-by: teika kazura > Link: https://bugzilla.kernel.org/show_bug.cgi?id=200675 > Cc: 4.15+ # 4.15+: 26112ddc254c (PCI / ACPI / PM: > Resume bridges ...) > Signed-off-by: Rafael J. Wysocki > --- > drivers/pci/pci-acpi.c |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > Index: linux-pm/drivers/pci/pci-acpi.c > === > --- linux-pm.orig/drivers/pci/pci-acpi.c > +++ linux-pm/drivers/pci/pci-acpi.c > @@ -632,13 +632,11 @@ static bool acpi_pci_need_resume(struct > /* >* In some cases (eg. Samsung 305V4A) leaving a bridge in suspend over >* system-wide suspend/resume confuses the platform firmware, so avoid > - * doing that, unless the bridge has a driver that should take care of > - * the PM handling. According to Section 16.1.6 of ACPI 6.2, endpoint > + * doing that. According to Section 16.1.6 of ACPI 6.2, endpoint >* devices are expected to be in D3 before invoking the S3 entry path >* from the firmware, so they should not be affected by this issue. >*/ > - if (pci_is_bridge(dev) && !dev->driver && > - acpi_target_system_state() != ACPI_STATE_S0) > + if (pci_is_bridge(dev) && acpi_target_system_state() != ACPI_STATE_S0) > return true; > > if (!adev || !acpi_device_power_manageable(adev)) >
Re: [PATCH] PCI / ACPI / PM: Resume all bridges on suspend-to-RAM
For the record, about the exactness of the patch description. The patch mentions the regression by the commit c62ec4610c40, but it is not the cause of the bug (https://bugzilla.kernel.org/show_bug.cgi?id=20067) reported by me; I reverted c62ec4610c40 on linux-4.17.13, and the bug remained. # Some details: my bug was introduced by the commit (i) 877b3729ca0 on Jan 3. The commit (ii) c62ec4610c40 was on May 22. The commit (iii) 26112ddc254c on Jun 30 fixes one problem caused by c62ec4610c40. The present patch modifies the code of the commit (iii), so it can be said as the completion of the commit (iii). It at the same time fixes my bug, too. This suggests the present patch possibly fixes other unknown PM problems; former kernels had some loose end(s). Now this patch puts the kernel in a better position. I'm a lay Linux user, and don't know if this post helps. If it does, it may be worth mentioning it in the above bugzilla entry. Dziękuję (thanks), kernel developers. Best regards, Teika (Teika kazura) From: "Rafael J. Wysocki" Subject: [PATCH] PCI / ACPI / PM: Resume all bridges on suspend-to-RAM Date: Thu, 16 Aug 2018 12:56:46 +0200 > From: Rafael J. Wysocki > > Commit 26112ddc254c (PCI / ACPI / PM: Resume bridges w/o drivers on > suspend-to-RAM) attempted to fix a functional regression resulting > from commit c62ec4610c40 (PM / core: Fix direct_complete handling > for devices with no callbacks) by resuming PCI bridges without > drivers (that is, "parallel PCI" ones) during system-wide suspend if > the target system state is not ACPI S0 (working state). > > That turns out insufficient, however, as it is reported that, at > least in one case, the platform firmware gets confused if a PCIe > root port is suspended before entering the ACPI S3 sleep state. > > For this reason, drop the driver check from acpi_pci_need_resume() > and resume all bridges (including PCIe ports with drivers) during > system-wide suspend if the target system state is not ACPI S0. > > [If the target system state is ACPI S0, it means suspend-to-idle > and the platform firmware is not going to be invoked to actually > suspend the system, so there is no need to resume the bridges in > that case.] > > Fixes: c62ec4610c40 (PM / core: Fix direct_complete handling for devices with > no callbacks) > Reported-by: teika kazura > Tested-by: teika kazura > Link: https://bugzilla.kernel.org/show_bug.cgi?id=200675 > Cc: 4.15+ # 4.15+: 26112ddc254c (PCI / ACPI / PM: > Resume bridges ...) > Signed-off-by: Rafael J. Wysocki > --- > drivers/pci/pci-acpi.c |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > Index: linux-pm/drivers/pci/pci-acpi.c > === > --- linux-pm.orig/drivers/pci/pci-acpi.c > +++ linux-pm/drivers/pci/pci-acpi.c > @@ -632,13 +632,11 @@ static bool acpi_pci_need_resume(struct > /* >* In some cases (eg. Samsung 305V4A) leaving a bridge in suspend over >* system-wide suspend/resume confuses the platform firmware, so avoid > - * doing that, unless the bridge has a driver that should take care of > - * the PM handling. According to Section 16.1.6 of ACPI 6.2, endpoint > + * doing that. According to Section 16.1.6 of ACPI 6.2, endpoint >* devices are expected to be in D3 before invoking the S3 entry path >* from the firmware, so they should not be affected by this issue. >*/ > - if (pci_is_bridge(dev) && !dev->driver && > - acpi_target_system_state() != ACPI_STATE_S0) > + if (pci_is_bridge(dev) && acpi_target_system_state() != ACPI_STATE_S0) > return true; > > if (!adev || !acpi_device_power_manageable(adev)) >
[PATCH v2 0/1] Input: synaptics - Enable RMI4 for Clevo P870DM laptops.
@Rosen Penev: Could you please test this patch for kernel >= 4.17, for a week or so? At least suspend/resume should not cause any problem. This patch enables SMBus/RMI4 for PCs with SYN1219, e.g. Clevo P870DM etc. Three users have reported SYN1219 supports SMBus, in Jul and Aug 2017: https://marc.info/?l=linux-input=150049625613055=2 https://marc.info/?l=linux-input=150284057602358=2 https://marc.info/?l=linux-input=15009456026=2 No problem has been reported since then. --- v2 This patch was originally submitted by Rosen Penev in Jun 2018 [1], which modified the list forcepad_pnp_ids[]. The current version instead changes smbus_pnp_ids[]. This version is yet to be tested. [1] https://www.spinics.net/lists/linux-input/msg56884.html Teika Kazura (1): Input: synaptics - Enable RMI4 for Clevo P870DM laptops. Signed-off-by: Rosen Penev Co-Developed-by: Teika Kazura Signed-off-by: Teika Kazura drivers/input/mouse/synaptics.c | 1 + 1 file changed, 1 insertion(+) -- 2.16.1
[PATCH v2 0/1] Input: synaptics - Enable RMI4 for Clevo P870DM laptops.
@Rosen Penev: Could you please test this patch for kernel >= 4.17, for a week or so? At least suspend/resume should not cause any problem. This patch enables SMBus/RMI4 for PCs with SYN1219, e.g. Clevo P870DM etc. Three users have reported SYN1219 supports SMBus, in Jul and Aug 2017: https://marc.info/?l=linux-input=150049625613055=2 https://marc.info/?l=linux-input=150284057602358=2 https://marc.info/?l=linux-input=15009456026=2 No problem has been reported since then. --- v2 This patch was originally submitted by Rosen Penev in Jun 2018 [1], which modified the list forcepad_pnp_ids[]. The current version instead changes smbus_pnp_ids[]. This version is yet to be tested. [1] https://www.spinics.net/lists/linux-input/msg56884.html Teika Kazura (1): Input: synaptics - Enable RMI4 for Clevo P870DM laptops. Signed-off-by: Rosen Penev Co-Developed-by: Teika Kazura Signed-off-by: Teika Kazura drivers/input/mouse/synaptics.c | 1 + 1 file changed, 1 insertion(+) -- 2.16.1
[PATCH v2 1/1] Input: synaptics - Enable RMI4 for Clevo P870DM laptops.
This patch enables SMBus/RMI4 for PCs with SYN1219, e.g. Clevo P870DM etc.
Signed-off-by: Rosen Penev
Co-Developed-by: Teika Kazura
Signed-off-by: Teika Kazura
---
drivers/input/mouse/synaptics.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index a9591d2..0669770 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -179,7 +179,7 @@ static const char * const smbus_pnp_ids[] = {
"LEN0096", /* X280 */
"LEN0097", /* X280 -> ALPS trackpoint */
"LEN200f", /* T450s */
+ "SYN1219", /* Schenker H506 (rebrand of Clevo P651RG), Clevo P870DM */
NULL
};
--
2.16.1
[PATCH v2 1/1] Input: synaptics - Enable RMI4 for Clevo P870DM laptops.
This patch enables SMBus/RMI4 for PCs with SYN1219, e.g. Clevo P870DM etc.
Signed-off-by: Rosen Penev
Co-Developed-by: Teika Kazura
Signed-off-by: Teika Kazura
---
drivers/input/mouse/synaptics.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index a9591d2..0669770 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -179,7 +179,7 @@ static const char * const smbus_pnp_ids[] = {
"LEN0096", /* X280 */
"LEN0097", /* X280 -> ALPS trackpoint */
"LEN200f", /* T450s */
+ "SYN1219", /* Schenker H506 (rebrand of Clevo P651RG), Clevo P870DM */
NULL
};
--
2.16.1
Re: [PATCH] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should use RMI
Hi, kitsunyan. (Привет, perhaps?) Thanks for you patch, but the "signed-off"
tag needs your real name. You can re-submit your patch conforming to that rule.
Or if you're ok, the kernel maintainer can instead sign it off, adding
"reported-by: kitsunyan ". (I'm not sure about the latter
case. Sorry if I'm wrong.)
You can find the instruction in /Documentation/process/submitting-patches.rst .
Best regards / Пока,
Teika (Teika kazura)
From: kitsunyan
Subject: [PATCH] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should
use RMI
Date: Sat, 7 Jul 2018 08:19:12 +0300
> The touchpads on both T25 and T480 are accessible over SMBUS/RMI.
>
> Signed-off-by: kitsunyan
> ---
> drivers/input/mouse/synaptics.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 55d33500d55e..be934a082424 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -175,7 +175,9 @@ static const char * const smbus_pnp_ids[] = {
> "LEN0071", /* T480 */
> "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
> "LEN0073", /* X1 Carbon G5 (Elantech) */
> + "LEN008e", /* T25 */
> "LEN0092", /* X1 Carbon 6 */
> + "LEN0093", /* T480 */
> "LEN0096", /* X280 */
> "LEN0097", /* X280 -> ALPS trackpoint */
> "LEN200f", /* T450s */
> --
> 2.18.0
Re: [PATCH] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should use RMI
Hi, kitsunyan. (Привет, perhaps?) Thanks for you patch, but the "signed-off"
tag needs your real name. You can re-submit your patch conforming to that rule.
Or if you're ok, the kernel maintainer can instead sign it off, adding
"reported-by: kitsunyan ". (I'm not sure about the latter
case. Sorry if I'm wrong.)
You can find the instruction in /Documentation/process/submitting-patches.rst .
Best regards / Пока,
Teika (Teika kazura)
From: kitsunyan
Subject: [PATCH] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should
use RMI
Date: Sat, 7 Jul 2018 08:19:12 +0300
> The touchpads on both T25 and T480 are accessible over SMBUS/RMI.
>
> Signed-off-by: kitsunyan
> ---
> drivers/input/mouse/synaptics.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 55d33500d55e..be934a082424 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -175,7 +175,9 @@ static const char * const smbus_pnp_ids[] = {
> "LEN0071", /* T480 */
> "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
> "LEN0073", /* X1 Carbon G5 (Elantech) */
> + "LEN008e", /* T25 */
> "LEN0092", /* X1 Carbon 6 */
> + "LEN0093", /* T480 */
> "LEN0096", /* X280 */
> "LEN0097", /* X280 -> ALPS trackpoint */
> "LEN200f", /* T450s */
> --
> 2.18.0
Re: [PATCH] synaptics: Enable RMI4 for Clevo P870DM laptops
@Rosen: Ok, then I'll make a patch, and will ask you to test it. Wait for a moment. Thanks for your reply. (It's a burden for me, too. ;-) From: Rosen Penev Subject: Re: [PATCH] synaptics: Enable RMI4 for Clevo P870DM laptops Date: Sat, 30 Jun 2018 11:57:32 -0700 >> Hi, Rosen. Thank you for your patch. (@Jan Steffens and @Pablo Cholaky: >> Thanks for your reports.) But I'm afraid some more work is necessary. Let me >> propose some points. > Too much work for me. I'll just use the kernel pareameter. Teika (Teika kazura)
Re: [PATCH] synaptics: Enable RMI4 for Clevo P870DM laptops
@Rosen: Ok, then I'll make a patch, and will ask you to test it. Wait for a moment. Thanks for your reply. (It's a burden for me, too. ;-) From: Rosen Penev Subject: Re: [PATCH] synaptics: Enable RMI4 for Clevo P870DM laptops Date: Sat, 30 Jun 2018 11:57:32 -0700 >> Hi, Rosen. Thank you for your patch. (@Jan Steffens and @Pablo Cholaky: >> Thanks for your reports.) But I'm afraid some more work is necessary. Let me >> propose some points. > Too much work for me. I'll just use the kernel pareameter. Teika (Teika kazura)
Re: [PATCH] synaptics: Enable RMI4 for Clevo P870DM laptops
Hi, Rosen. Thank you for your patch. (@Jan Steffens and @Pablo Cholaky: Thanks
for your reports.) But I'm afraid some more work is necessary. Let me propose
some points.
I'm not a kernel developer, but have been working on this issue to help them.
(See https://www.spinics.net/lists/linux-input/msg55950.html )
0.
Could you resend it, cc-ing to the relevant developers. (Use the one of my
reply here. You can use /scripts/get_maintainer.pl next time.)
Otherwise, it is unlikely to be noticed by them.
1.
You added your device to forcepad_pnp_ids[], but I guess it should be
smbus_pnp_ids[].
When making the patch again, please use the kernel 4.17 or newer, because
smbus_pnp_ids was changed recently.
If it works by using smbus_pnp_ids, please test it for a week or so, especially
making sure that suspend/resume works without any problem.
2.
Though it's my personal impression, the change description looked somewhat
personal. At the same time, it's important, guaranteeing the stability of the
patch.- I know you originally reported it last August [1]. Furthermore, there
have been two other users [2] who reported SMBus worked for the same device,
namely SYN1219. (They two are cc-ed to in this reply.)
You can use "$ git format-patch --cover-letter"; it will generate a
"cover-letter", the introductory part of the patch, explaining the
acceptability of the patch to kernel developers. (For an example, see
https://www.spinics.net/lists/linux-input/msg57041.html)
So the full description can be given in the cover letter, and the real patch
description can be something like "This enables SMBus for xxx", being almost
identical to the email subject.
3. This is not essential, but the style of the email subject that the device
maintainer prefers might be:
[PATCH v2] Input: synaptics - Enable RMI4 for Clevo P870DM laptops
after looking at this tree [3]. ("v2" meaning version 2, due to the above
change.) You can feed "--subject-prefix='PATCH v2'" to "$ git format-patch".
4. If you want to give the credit for my reply, you can add
--------
Suggested-by: Teika Kazura
after Signed-off-by. It's completely ok without it. :-)
[1] https://marc.info/?l=linux-input=150284057602358=2
[2] https://marc.info/?l=linux-input=150049625613055=2
https://marc.info/?l=linux-input=15009456026=2
[3] https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/log/
Best regards,
Teika (Teika kazura)
From: Rosen Penev
Subject: [PATCH] synaptics: Enable RMI4 for Clevo P870DM laptops
Date: Sat, 16 Jun 2018 18:42:16 -0700
> I have been testing this for half a year with no issues to report.
>
> Signed-off-by: Rosen Penev
> ---
> drivers/input/mouse/synaptics.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 55d33500d55e..23f5bb2cf9da 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -183,6 +183,7 @@ static const char * const smbus_pnp_ids[] = {
> };
>
> static const char * const forcepad_pnp_ids[] = {
> + "SYN1219",
> "SYN300D",
> "SYN3014",
> NULL
> --
> 2.17.1
>
Re: [PATCH] synaptics: Enable RMI4 for Clevo P870DM laptops
Hi, Rosen. Thank you for your patch. (@Jan Steffens and @Pablo Cholaky: Thanks
for your reports.) But I'm afraid some more work is necessary. Let me propose
some points.
I'm not a kernel developer, but have been working on this issue to help them.
(See https://www.spinics.net/lists/linux-input/msg55950.html )
0.
Could you resend it, cc-ing to the relevant developers. (Use the one of my
reply here. You can use /scripts/get_maintainer.pl next time.)
Otherwise, it is unlikely to be noticed by them.
1.
You added your device to forcepad_pnp_ids[], but I guess it should be
smbus_pnp_ids[].
When making the patch again, please use the kernel 4.17 or newer, because
smbus_pnp_ids was changed recently.
If it works by using smbus_pnp_ids, please test it for a week or so, especially
making sure that suspend/resume works without any problem.
2.
Though it's my personal impression, the change description looked somewhat
personal. At the same time, it's important, guaranteeing the stability of the
patch.- I know you originally reported it last August [1]. Furthermore, there
have been two other users [2] who reported SMBus worked for the same device,
namely SYN1219. (They two are cc-ed to in this reply.)
You can use "$ git format-patch --cover-letter"; it will generate a
"cover-letter", the introductory part of the patch, explaining the
acceptability of the patch to kernel developers. (For an example, see
https://www.spinics.net/lists/linux-input/msg57041.html)
So the full description can be given in the cover letter, and the real patch
description can be something like "This enables SMBus for xxx", being almost
identical to the email subject.
3. This is not essential, but the style of the email subject that the device
maintainer prefers might be:
[PATCH v2] Input: synaptics - Enable RMI4 for Clevo P870DM laptops
after looking at this tree [3]. ("v2" meaning version 2, due to the above
change.) You can feed "--subject-prefix='PATCH v2'" to "$ git format-patch".
4. If you want to give the credit for my reply, you can add
--------
Suggested-by: Teika Kazura
after Signed-off-by. It's completely ok without it. :-)
[1] https://marc.info/?l=linux-input=150284057602358=2
[2] https://marc.info/?l=linux-input=150049625613055=2
https://marc.info/?l=linux-input=15009456026=2
[3] https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/log/
Best regards,
Teika (Teika kazura)
From: Rosen Penev
Subject: [PATCH] synaptics: Enable RMI4 for Clevo P870DM laptops
Date: Sat, 16 Jun 2018 18:42:16 -0700
> I have been testing this for half a year with no issues to report.
>
> Signed-off-by: Rosen Penev
> ---
> drivers/input/mouse/synaptics.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 55d33500d55e..23f5bb2cf9da 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -183,6 +183,7 @@ static const char * const smbus_pnp_ids[] = {
> };
>
> static const char * const forcepad_pnp_ids[] = {
> + "SYN1219",
> "SYN300D",
> "SYN3014",
> NULL
> --
> 2.17.1
>
Re: [PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)
From: Aaron Ma <aaron...@canonical.com> Date: Tue, 17 Apr 2018 19:42:27 +0800 > Could you apply my patch too? > > It add LEN0096 that Benjamin's patch doesn't include. > > + "LEN0096", /* X280 */ Aaron, in your original patch in last Oct [1], both *LEN0092 and* LEN0096 were aded. Which should be the case, both two, or only LEN0096? [1] https://www.spinics.net/lists/kernel/msg2625450.html Teika (Teika kazura)
Re: [PATCH v2 0/9] Input: support for latest Lenovo thinkpads (series 80)
From: Aaron Ma Date: Tue, 17 Apr 2018 19:42:27 +0800 > Could you apply my patch too? > > It add LEN0096 that Benjamin's patch doesn't include. > > + "LEN0096", /* X280 */ Aaron, in your original patch in last Oct [1], both *LEN0092 and* LEN0096 were aded. Which should be the case, both two, or only LEN0096? [1] https://www.spinics.net/lists/kernel/msg2625450.html Teika (Teika kazura)
