Re: [PATCH 1/1] block: fix trivial typos in comments
On Fri, Mar 26, 2021 at 09:46:36AM -0600, Jens Axboe wrote: > On 3/26/21 9:45 AM, Tom Saeger wrote: > > On Fri, Mar 26, 2021 at 09:41:49AM -0600, Jens Axboe wrote: > >> On 3/25/21 9:04 PM, Tom Saeger wrote: > >>> > >>> s/Additonal/Additional/ > >>> s/assocaited/associated/ > >>> s/assocaited/associated/ > >>> s/assocating/associating/ > >>> s/becasue/because/ > >>> s/configred/configured/ > >>> s/deactive/deactivate/ > >>> s/followings/following/ > >>> s/funtion/function/ > >>> s/heirarchy/hierarchy/ > >>> s/intiailized/initialized/ > >>> s/prefered/preferred/ > >>> s/readded/read/ > >>> s/Secion/Section/ > >>> s/soley/solely/ > >> > >> While I'm generally happy to accept any patch that makes sense, the > >> recent influx of speling fixes have me less than excited. They just > >> add complications to backports and stable patches, for example, and > >> I'd prefer not to take them for that reason alone. > > > > Nod. > > > > In that case - perhaps adding these entries to scripts/spelling.txt > > would at least catch some going forward? > > > > I can send that. > > That seems like a good idea. > > -- > Jens Axboe > What would be the process - which avoids the backport complications? Perhaps a few of these could be fixed when other changes are made to these files? Granted these are trivial fixes, just trying to understand the process. Example work-flow based on recent block merge upstream: $ git log -n1 abed516ecd02ceb30fbd091e9b26205ea3192c65 --oneline abed516ecd02 Merge tag 'block-5.12-2021-03-27' of git://git.kernel.dk/linux-block # get files changed by recent merge (or use commit range of interest) $ HID=abed516ecd02 ; git diff --name-only "$(git merge-base "${HID}^2" "${HID}^1")".."${HID}^2" block/bio.c block/blk-merge.c block/partitions/core.c fs/block_dev.c # foreach file in recent merge, run checkpatch in typo fix mode $ HID=abed516ecd02 ; git diff --name-only "$(git merge-base "${HID}^2" "${HID}^1")".."${HID}^2" \ | xargs ./scripts/checkpatch.pl --strict --fix --fix-inplace --types TYPO_SPELLING -f | grep -A4 -F "CHECK:" CHECK: 'splitted' may be misspelled - perhaps 'split'? #344: FILE: block/blk-merge.c:344: + /* there isn't chance to merge the splitted bio */ -- CHECK: 'beeing' may be misspelled - perhaps 'being'? #934: FILE: fs/block_dev.c:934: + * or NULL if the inode is already beeing freed. ^^ # what changed? $ git status -su M block/blk-merge.c M fs/block_dev.c Something similar could be done for other checkpatch modes or other linters. Just an idea - thoughts? Regards, --Tom
[PATCH v2] scripts/spelling.txt: add entries for recent discoveries
Add a few entries for recent spelling fixes found. Opportunistically de-dupe: exeeds||exceeds Link: https://lore.kernel.org/lkml/31acb3239b7ab8989db0c9951e8740050aef0205.1616727528.git.tom.sae...@oracle.com/ Link: https://lore.kernel.org/lkml/fa193b3c9e346ff3fc157b54802c29b25f79c402.1615597995.git.tom.sae...@oracle.com/ Signed-off-by: Tom Saeger --- Changes in v2: * drop entry `readded||read`, "readded" is in fact "readded" * Link to v1: https://lore.kernel.org/lkml/14c54ee47bf0e9aebfe71e97cefd11b2b8f0332f.1616784384.git.tom.sae...@oracle.com/ --- scripts/spelling.txt | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/scripts/spelling.txt b/scripts/spelling.txt index 2e3ba91a5072..7beb4262f719 100644 --- a/scripts/spelling.txt +++ b/scripts/spelling.txt @@ -84,6 +84,7 @@ againt||against agaist||against aggreataon||aggregation aggreation||aggregation +ajust||adjust albumns||albums alegorical||allegorical algined||aligned @@ -161,10 +162,13 @@ asign||assign asser||assert assertation||assertion assertting||asserting +assgined||assigned assiged||assigned assigment||assignment assigments||assignments assistent||assistant +assocaited||associated +assocating||associating assocation||association associcated||associated assotiated||associated @@ -177,9 +181,11 @@ asynchnous||asynchronous asynchromous||asynchronous asymetric||asymmetric asymmeric||asymmetric +atleast||at least atomatically||automatically atomicly||atomically atempt||attempt +atrributes||attributes attachement||attachment attatch||attach attched||attached @@ -315,6 +321,7 @@ comminucation||communication commited||committed commiting||committing committ||commit +commnunication||communication commoditiy||commodity comsume||consume comsumer||consumer @@ -349,6 +356,7 @@ condtion||condition conected||connected conector||connector configration||configuration +configred||configured configuartion||configuration configuation||configuration configued||configured @@ -402,6 +410,7 @@ cunter||counter curently||currently cylic||cyclic dafault||default +deactive||deactivate deafult||default deamon||daemon debouce||debounce @@ -417,6 +426,7 @@ deffered||deferred defferred||deferred definate||definite definately||definitely +definiation||definition defintion||definition defintions||definitions defualt||default @@ -571,8 +581,9 @@ errror||error estbalishment||establishment etsablishment||establishment etsbalishment||establishment +evalute||evaluate +evalutes||evaluates evalution||evaluation -exeeds||exceeds excecutable||executable exceded||exceeded exceds||exceeds @@ -696,6 +707,7 @@ hardare||hardware harware||hardware havind||having heirarchically||hierarchically +heirarchy||hierarchy helpfull||helpful heterogenous||heterogeneous hexdecimal||hexadecimal @@ -796,6 +808,7 @@ interanl||internal interchangable||interchangeable interferring||interfering interger||integer +intergrated||integrated intermittant||intermittent internel||internal interoprability||interoperability @@ -808,6 +821,7 @@ interrup||interrupt interrups||interrupts interruptted||interrupted interupted||interrupted +intiailized||initialized intial||initial intialisation||initialisation intialised||initialised @@ -1091,11 +1105,14 @@ preemptable||preemptible prefered||preferred prefferably||preferably prefitler||prefilter +preform||perform premption||preemption prepaired||prepared preperation||preparation preprare||prepare pressre||pressure +presuambly||presumably +previosuly||previously primative||primitive princliple||principle priorty||priority @@ -1265,6 +1282,7 @@ scarch||search schdule||schedule seach||search searchs||searches +secion||section secquence||sequence secund||second segement||segment @@ -1312,6 +1330,8 @@ singed||signed sleeped||slept sliped||slipped softwares||software +soley||solely +souce||source speach||speech specfic||specific specfield||specified @@ -1320,7 +1340,9 @@ specifc||specific specifed||specified specificatin||specification specificaton||specification +specificed||specified specifing||specifying +specifiy||specify specifiying||specifying speficied||specified speicify||specify @@ -1436,6 +1458,7 @@ timout||timeout tmis||this toogle||toggle torerable||tolerable +traget||target traking||tracking tramsmitted||transmitted tramsmit||transmit @@ -1558,6 +1581,7 @@ wiil||will wirte||write withing||within wnat||want +wont||won't workarould||workaround writeing||writing writting||writing base-commit: db24726bfefa68c606947a86132591568a06bfb4 -- 2.31.0
Re: [PATCH 1/1] scripts/spelling.txt: add entries for recent discoveries
On Fri, Mar 26, 2021 at 04:36:01PM -0600, Jens Axboe wrote: > On 3/26/21 1:22 PM, Tom Saeger wrote: > > @@ -1153,6 +1170,7 @@ quering||querying > > queus||queues > > randomally||randomly > > raoming||roaming > > +readded||read > > reasearcher||researcher > > reasearchers||researchers > > reasearch||research > > davej brought up a good point that this one was actually re-added, which > does make sense. So don't think that one should be added to the list. Ah! Good catch. I'll drop that entry and send V2. Thanks > > -- > Jens Axboe >
Re: [PATCH] scripts: stable: add script to validate backports
On Wed, Mar 24, 2021 at 10:55:27AM +0100, Greg Kroah-Hartman wrote: > On Tue, Mar 23, 2021 at 01:28:38PM -0700, Nick Desaulniers wrote: > > On Tue, Mar 23, 2021 at 12:05 PM Greg Kroah-Hartman > > wrote: > > > > > > The only time git gets involved is when we do a -rc release or when we > > > do a "real" release, and then we use 'git quiltimport' on the whole > > > stack. > > > > > > Here's a script that I use (much too slow, I know), for checking this > > > type of thing and I try to remember to run it before every cycle of -rc > > > releases: > > > > > > https://github.com/gregkh/commit_tree/blob/master/find_fixes_in_queue > > > > > > It's a hack, and picks up more things than is really needed, but I would > > > rather it error on that side than the other. > > > > Yes, my script is similar. Looks like yours also runs on a git tree. > > > > I noticed that id_fixed_in runs `git grep -l --threads=3 ` to > > find fixes; that's neat, I didn't know about `--threads=`. I tried it > > with ae46578b963f manually: > > > > $ git grep -l --threads=3 ae46578b963f > > $ > > > > Should it have found a7889c6320b9 and 773e0c402534? Perhaps `git log > > --grep=` should be used instead? I thought `git grep` only greps > > files in the archive, not commit history? > > Yes, it does only grep the files in the archive. > > But look closer at the archive that this script lives in :) > > This archive is a "blown up" copy of the Linux kernel tree, with one > file per commit. The name of the file is the commit id, and the content > of the file is the changelog of the commit itself. > > So it's a hack that I use to be able to simply search the changelogs of > all commits to find out if they have a "Fixes:" tag with a specific > commit id in it. > > So in your example above, in the repo I run it and get: > > ~/linux/stable/commit_tree $ git grep -l --threads=3 ae46578b963f > changes/5.2/773e0c40253443e0ce5491cb0e414b62f7cc45ed > ids/5.2 > > Which shows me that in commit 773e0c402534 ("afs: Fix > afs_xattr_get_yfs() to not try freeing an error value") in the kernel > tree, it has a "Fixes:" tag that references "ae46578b963f". > > It also shows me that commit ae46578b963f was contained in the 5.2 > kernel release, as I use the "ids/" subdirectory here for other fast > lookups (it's a tiny bit faster than 'git describe --contains'). > > I don't know how your script is walking through all possible commits to > see if they are fixing a specific one, maybe I should look and see if > it's doing it better than my "git tree/directory as a database hack" > does :) FWIW, I had a need for something similar and found `git rev-list --grep` provided fastest results. Does not provide for the "ids/" hack though... ??? N="ae46578b963f"; git rev-list --grep="${N}" "${N}..upstream/master" | while read -r hid ; do git log -n1 "${hid}" | grep -F "${N}" | sed "s#^#${hid} #"; done a7889c6320b9200e3fe415238f546db677310fa9 Fixes: ae46578b963f ("afs: Get YFS ACLs and information through xattrs") 773e0c40253443e0ce5491cb0e414b62f7cc45ed Fixes: ae46578b963f ("afs: Get YFS ACLs and information through xattrs") ??? N="a7889c6320b9"; git rev-list --grep="${N}" "${N}..stable/linux-5.4.y" | while read -r hid ; do git log -n1 "${hid}" | grep -F "${N}" | sed "s#^#${hid} #"; done 6712b7fcef9d1092e99733645cf52cfb3d482555 commit a7889c6320b9200e3fe415238f546db677310fa9 upstream. ??? N="ae46578b963f"; git rev-list --grep="${N}" "${N}..stable/linux-5.4.y" | while read -r hid ; do git log -n1 "${hid}" | grep -F "${N}" | sed "s#^#${hid} #"; done 6712b7fcef9d1092e99733645cf52cfb3d482555 Fixes: ae46578b963f ("afs: Get YFS ACLs and information through xattrs") 773e0c40253443e0ce5491cb0e414b62f7cc45ed Fixes: ae46578b963f ("afs: Get YFS ACLs and information through xattrs") > > thanks, > > greg k-h
[PATCH 1/1] scripts/spelling.txt: add entries for recent discoveries
Add a few entries for recent spelling fixes found. Opportunistically de-dupe: exeeds||exceeds Link: https://lore.kernel.org/lkml/31acb3239b7ab8989db0c9951e8740050aef0205.1616727528.git.tom.sae...@oracle.com/ Link: https://lore.kernel.org/lkml/fa193b3c9e346ff3fc157b54802c29b25f79c402.1615597995.git.tom.sae...@oracle.com/ Signed-off-by: Tom Saeger --- scripts/spelling.txt | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/scripts/spelling.txt b/scripts/spelling.txt index 2e3ba91a5072..f7a3bfd75787 100644 --- a/scripts/spelling.txt +++ b/scripts/spelling.txt @@ -84,6 +84,7 @@ againt||against agaist||against aggreataon||aggregation aggreation||aggregation +ajust||adjust albumns||albums alegorical||allegorical algined||aligned @@ -161,10 +162,13 @@ asign||assign asser||assert assertation||assertion assertting||asserting +assgined||assigned assiged||assigned assigment||assignment assigments||assignments assistent||assistant +assocaited||associated +assocating||associating assocation||association associcated||associated assotiated||associated @@ -177,9 +181,11 @@ asynchnous||asynchronous asynchromous||asynchronous asymetric||asymmetric asymmeric||asymmetric +atleast||at least atomatically||automatically atomicly||atomically atempt||attempt +atrributes||attributes attachement||attachment attatch||attach attched||attached @@ -315,6 +321,7 @@ comminucation||communication commited||committed commiting||committing committ||commit +commnunication||communication commoditiy||commodity comsume||consume comsumer||consumer @@ -349,6 +356,7 @@ condtion||condition conected||connected conector||connector configration||configuration +configred||configured configuartion||configuration configuation||configuration configued||configured @@ -402,6 +410,7 @@ cunter||counter curently||currently cylic||cyclic dafault||default +deactive||deactivate deafult||default deamon||daemon debouce||debounce @@ -417,6 +426,7 @@ deffered||deferred defferred||deferred definate||definite definately||definitely +definiation||definition defintion||definition defintions||definitions defualt||default @@ -571,8 +581,9 @@ errror||error estbalishment||establishment etsablishment||establishment etsbalishment||establishment +evalute||evaluate +evalutes||evaluates evalution||evaluation -exeeds||exceeds excecutable||executable exceded||exceeded exceds||exceeds @@ -696,6 +707,7 @@ hardare||hardware harware||hardware havind||having heirarchically||hierarchically +heirarchy||hierarchy helpfull||helpful heterogenous||heterogeneous hexdecimal||hexadecimal @@ -796,6 +808,7 @@ interanl||internal interchangable||interchangeable interferring||interfering interger||integer +intergrated||integrated intermittant||intermittent internel||internal interoprability||interoperability @@ -808,6 +821,7 @@ interrup||interrupt interrups||interrupts interruptted||interrupted interupted||interrupted +intiailized||initialized intial||initial intialisation||initialisation intialised||initialised @@ -1091,11 +1105,14 @@ preemptable||preemptible prefered||preferred prefferably||preferably prefitler||prefilter +preform||perform premption||preemption prepaired||prepared preperation||preparation preprare||prepare pressre||pressure +presuambly||presumably +previosuly||previously primative||primitive princliple||principle priorty||priority @@ -1153,6 +1170,7 @@ quering||querying queus||queues randomally||randomly raoming||roaming +readded||read reasearcher||researcher reasearchers||researchers reasearch||research @@ -1265,6 +1283,7 @@ scarch||search schdule||schedule seach||search searchs||searches +secion||section secquence||sequence secund||second segement||segment @@ -1312,6 +1331,8 @@ singed||signed sleeped||slept sliped||slipped softwares||software +soley||solely +souce||source speach||speech specfic||specific specfield||specified @@ -1320,7 +1341,9 @@ specifc||specific specifed||specified specificatin||specification specificaton||specification +specificed||specified specifing||specifying +specifiy||specify specifiying||specifying speficied||specified speicify||specify @@ -1436,6 +1459,7 @@ timout||timeout tmis||this toogle||toggle torerable||tolerable +traget||target traking||tracking tramsmitted||transmitted tramsmit||transmit @@ -1558,6 +1582,7 @@ wiil||will wirte||write withing||within wnat||want +wont||won't workarould||workaround writeing||writing writting||writing base-commit: db24726bfefa68c606947a86132591568a06bfb4 -- 2.31.0
Re: [PATCH 1/1] block: fix trivial typos in comments
On Fri, Mar 26, 2021 at 09:41:49AM -0600, Jens Axboe wrote: > On 3/25/21 9:04 PM, Tom Saeger wrote: > > > > s/Additonal/Additional/ > > s/assocaited/associated/ > > s/assocaited/associated/ > > s/assocating/associating/ > > s/becasue/because/ > > s/configred/configured/ > > s/deactive/deactivate/ > > s/followings/following/ > > s/funtion/function/ > > s/heirarchy/hierarchy/ > > s/intiailized/initialized/ > > s/prefered/preferred/ > > s/readded/read/ > > s/Secion/Section/ > > s/soley/solely/ > > While I'm generally happy to accept any patch that makes sense, the > recent influx of speling fixes have me less than excited. They just > add complications to backports and stable patches, for example, and > I'd prefer not to take them for that reason alone. Nod. In that case - perhaps adding these entries to scripts/spelling.txt would at least catch some going forward? I can send that. > > -- > Jens Axboe >
[PATCH 1/1] block: fix trivial typos in comments
s/Additonal/Additional/ s/assocaited/associated/ s/assocaited/associated/ s/assocating/associating/ s/becasue/because/ s/configred/configured/ s/deactive/deactivate/ s/followings/following/ s/funtion/function/ s/heirarchy/hierarchy/ s/intiailized/initialized/ s/prefered/preferred/ s/readded/read/ s/Secion/Section/ s/soley/solely/ Cc: triv...@kernel.org Signed-off-by: Tom Saeger --- block/bfq-iosched.c | 4 ++-- block/blk-cgroup-rwstat.c | 2 +- block/blk-cgroup.c| 6 +++--- block/blk-core.c | 2 +- block/blk-iocost.c| 12 ++-- block/blk-iolatency.c | 4 ++-- block/blk-merge.c | 6 +++--- block/blk-mq.c| 4 ++-- block/blk-settings.c | 2 +- block/blk-stat.h | 2 +- block/blk.h | 2 +- block/kyber-iosched.c | 2 +- block/opal_proto.h| 4 ++-- block/partitions/ibm.c| 2 +- block/partitions/sun.c| 2 +- block/scsi_ioctl.c| 2 +- 16 files changed, 29 insertions(+), 29 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 9b7678ad5830..936e48bdecaf 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -1798,7 +1798,7 @@ static void bfq_bfqq_handle_idle_busy_switch(struct bfq_data *bfqd, * As for throughput, we ask bfq_better_to_idle() whether we * still need to plug I/O dispatching. If bfq_better_to_idle() * says no, then plugging is not needed any longer, either to -* boost throughput or to perserve service guarantees. Then +* boost throughput or to preserve service guarantees. Then * the best option is to stop plugging I/O, as not doing so * would certainly lower throughput. We may end up in this * case if: (1) upon a dispatch attempt, we detected that it @@ -5050,7 +5050,7 @@ void bfq_put_queue(struct bfq_queue *bfqq) * by the fact that bfqq has just been merged. * 2) burst_size is greater than 0, to handle * unbalanced decrements. Unbalanced decrements may -* happen in te following case: bfqq is inserted into +* happen in the following case: bfqq is inserted into * the current burst list--without incrementing * bust_size--because of a split, but the current * burst list is not the burst list bfqq belonged to diff --git a/block/blk-cgroup-rwstat.c b/block/blk-cgroup-rwstat.c index 3304e841df7c..0039e4756fc3 100644 --- a/block/blk-cgroup-rwstat.c +++ b/block/blk-cgroup-rwstat.c @@ -37,7 +37,7 @@ EXPORT_SYMBOL_GPL(blkg_rwstat_exit); * @pd: policy private data of interest * @rwstat: rwstat to print * - * Print @rwstat to @sf for the device assocaited with @pd. + * Print @rwstat to @sf for the device associated with @pd. */ u64 __blkg_prfill_rwstat(struct seq_file *sf, struct blkg_policy_data *pd, const struct blkg_rwstat_sample *rwstat) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index a317c03d40f6..e5dc2e13487f 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -143,7 +143,7 @@ static void blkg_async_bio_workfn(struct work_struct *work) * @q: request_queue the new blkg is associated with * @gfp_mask: allocation mask to use * - * Allocate a new blkg assocating @blkcg and @q. + * Allocate a new blkg associating @blkcg and @q. */ static struct blkcg_gq *blkg_alloc(struct blkcg *blkcg, struct request_queue *q, gfp_t gfp_mask) @@ -526,7 +526,7 @@ EXPORT_SYMBOL_GPL(blkcg_print_blkgs); * @pd: policy private data of interest * @v: value to print * - * Print @v to @sf for the device assocaited with @pd. + * Print @v to @sf for the device associated with @pd. */ u64 __blkg_prfill_u64(struct seq_file *sf, struct blkg_policy_data *pd, u64 v) { @@ -715,7 +715,7 @@ EXPORT_SYMBOL_GPL(blkg_conf_prep); /** * blkg_conf_finish - finish up per-blkg config update - * @ctx: blkg_conf_ctx intiailized by blkg_conf_prep() + * @ctx: blkg_conf_ctx initialized by blkg_conf_prep() * * Finish up after per-blkg config update. This function must be paired * with blkg_conf_prep(). diff --git a/block/blk-core.c b/block/blk-core.c index fc60ff208497..e866e58214e2 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1035,7 +1035,7 @@ blk_qc_t submit_bio_noacct(struct bio *bio) /* * We only want one ->submit_bio to be active at a time, else stack * usage with stacked devices could be a problem. Use current->bio_list -* to collect a list of requests submited by a ->submit_bio method while +* to collect a list of requests submitted by a ->submit_bio method while * it is active, and then process them after it returned. */ if (current->bio_list) { diff --git a/block/blk-iocost.c b/block/blk-iocost.c index 98d656bdb42b..282903250530 100644 --- a/block/blk-iocost.c +++ b/blo
Re: [PATCH V2] Trivial typo fix and sentence construction for better readability
On Fri, Mar 19, 2021 at 01:03:02PM -0700, Randy Dunlap wrote: > > Hm, needs some spacing fixes IMO. See below. > > > On Sat, 20 Mar 2021, Bhaskar Chowdhury wrote: > > > > > s/funtion/functions/ > > > > Plus the sentence reconstructed for better readability. > > > > Signed-off-by: Bhaskar Chowdhury > > --- > > Changes from V1: > > Randy's suggestions incorporated. > > > > block/blk-mq-tag.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c > > index 9c92053e704d..c2bef283db63 100644 > > --- a/block/blk-mq-tag.c > > +++ b/block/blk-mq-tag.c > > @@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct > > request *rq, > > } > > > > /** > > - * blk_mq_tagset_wait_completed_request - wait until all completed req's > > - * complete funtion is run completion function That's my read of it. --Tom > > + * blk_mq_tagset_wait_completed_request - wait until all the req's > > the req's > > > + * functions completed their run > > and more indentation + wording on that line above: > *functions have completed their run > > > * @tagset: Tag set to drain completed request > > * > > * Note: This function has to be run after all IO queues are shutdown > > -- > > Thanks.
[PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT
In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI instead of ISCSI_IBFT_FIND") Kconfig was disentangled to make ISCSI_IBFT selection not depend on x86. Update arm64 acpi documentation, changing IBFT support status from "Not Supported" to "Optional". Opportunistically re-flow paragraph for changed lines. Link: https://lore.kernel.org/lkml/1563475054-10680-1-git-send-email-thomas....@oracle.com/ Signed-off-by: Tom Saeger --- Documentation/arm64/acpi_object_usage.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/arm64/acpi_object_usage.rst b/Documentation/arm64/acpi_object_usage.rst index 377e9d224db0..0609da73970b 100644 --- a/Documentation/arm64/acpi_object_usage.rst +++ b/Documentation/arm64/acpi_object_usage.rst @@ -17,12 +17,12 @@ For ACPI on arm64, tables also fall into the following categories: - Recommended: BERT, EINJ, ERST, HEST, PCCT, SSDT - - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IORT, - MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT, STAO, - TCPA, TPM2, UEFI, XENV + - Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, IBFT, + IORT, MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, SPMI, SRAT, + STAO, TCPA, TPM2, UEFI, XENV - - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IBFT, IVRS, LPIT, - MSDM, OEMx, PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT + - Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IVRS, LPIT, MSDM, OEMx, + PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT == Table Usage for ARMv8 Linux -- 2.31.0
Re: [PATCH] include: linux: Fix a typo in the file fs.h
On Sat, Mar 13, 2021 at 10:49:55AM +0530, Bhaskar Chowdhury wrote: > s/varous/various/ > > Signed-off-by: Bhaskar Chowdhury > --- > include/linux/fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index ec8f3ddf4a6a..c37a17c32d74 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1051,7 +1051,7 @@ bool opens_in_grace(struct net *); > * FIXME: should we create a separate "struct lock_request" to help > distinguish > * these two uses? > * > - * The varous i_flctx lists are ordered by: > + * The various i_flctx lists are ordered by: > * > * 1) lock owner > * 2) lock range start > -- > 2.26.2 > How about a few more? found by running: codespell -w -i 3 include/linux/fs.h 'specialy' could be 'special' or 'specialty' it can be dropped altogether IMO, so I did. --Tom diff --git a/include/linux/fs.h b/include/linux/fs.h index c37a17c32d74..9ffea695a059 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -126,7 +126,7 @@ typedef int (dio_iodone_t)(struct kiocb *iocb, loff_t offset, /* File is opened with O_EXCL (only set for block devices) */ #define FMODE_EXCL ((__force fmode_t)0x80) /* File is opened using open(.., 3, ..) and is writeable only for ioctls - (specialy hack for floppy.c) */ + (hack for floppy.c) */ #define FMODE_WRITE_IOCTL ((__force fmode_t)0x100) /* 32bit hashes as llseek() offset (for directories) */ #define FMODE_32BITHASH ((__force fmode_t)0x200) @@ -819,7 +819,7 @@ void lock_two_nondirectories(struct inode *, struct inode*); void unlock_two_nondirectories(struct inode *, struct inode*); /* - * NOTE: in a 32bit arch with a preemptable kernel and + * NOTE: in a 32bit arch with a preemptible kernel and * an UP compile the i_size_read/write must be atomic * with respect to the local cpu (unlike with preempt disabled), * but they don't need to be atomic with respect to other cpus like in
Re: [PATCH V3] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c
On Sat, Mar 13, 2021 at 09:19:51AM +0530, Bhaskar Chowdhury wrote: > > Trivial spelling fixes throughout the file. > LGTM Reviewed-by: Tom Saeger > Signed-off-by: Bhaskar Chowdhury > --- > Changes from V2: > Incoporated the findings of Tom Saeger > > drivers/cpufreq/s5pv210-cpufreq.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/cpufreq/s5pv210-cpufreq.c > b/drivers/cpufreq/s5pv210-cpufreq.c > index 69786e5bbf05..73110b005716 100644 > --- a/drivers/cpufreq/s5pv210-cpufreq.c > +++ b/drivers/cpufreq/s5pv210-cpufreq.c > @@ -91,7 +91,7 @@ static DEFINE_MUTEX(set_freq_lock); > /* Use 800MHz when entering sleep mode */ > #define SLEEP_FREQ (800 * 1000) > > -/* Tracks if cpu freqency can be updated anymore */ > +/* Tracks if cpu frequency can be updated anymore */ > static bool no_cpufreq_access; > > /* > @@ -190,7 +190,7 @@ static u32 clkdiv_val[5][11] = { > > /* > * This function set DRAM refresh counter > - * accoriding to operating frequency of DRAM > + * according to operating frequency of DRAM > * ch: DMC port number 0 or 1 > * freq: Operating frequency of DRAM(KHz) > */ > @@ -320,7 +320,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, > unsigned int index) > > /* >* 3. DMC1 refresh count for 133Mhz if (index == L4) is > - * true refresh counter is already programed in upper > + * true refresh counter is already programmed in upper >* code. 0x287@83Mhz >*/ > if (!bus_speed_changing) > @@ -378,7 +378,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, > unsigned int index) > /* >* 6. Turn on APLL >* 6-1. Set PMS values > - * 6-2. Wait untile the PLL is locked > + * 6-2. Wait until the PLL is locked >*/ > if (index == L0) > writel_relaxed(APLL_VAL_1000, S5P_APLL_CON); > @@ -390,7 +390,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, > unsigned int index) > } while (!(reg & (0x1 << 29))); > > /* > - * 7. Change souce clock from SCLKMPLL(667Mhz) > + * 7. Change source clock from SCLKMPLL(667Mhz) >* to SCLKA2M(200Mhz) in MFC_MUX and G3D MUX >* (667/4=166)->(200/4=50)Mhz >*/ > @@ -439,7 +439,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, > unsigned int index) > } > > /* > - * L4 level need to change memory bus speed, hence onedram clock divier > + * L4 level needs to change memory bus speed, hence onedram clock > divider >* and memory refresh parameter should be changed >*/ > if (bus_speed_changing) { > -- > 2.26.2 > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH V2] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c
On Fri, Mar 12, 2021 at 04:57:07PM -0800, Randy Dunlap wrote: > On 3/12/21 4:50 PM, Bhaskar Chowdhury wrote: > > On 17:16 Fri 12 Mar 2021, Tom Saeger wrote: > >> On Sat, Mar 13, 2021 at 04:56:21AM +0530, Bhaskar Chowdhury wrote: > >> > >> sent a few additional typo fixes to your V1, can you add those to your > >> patch? > >> > >> Regards, > >> > >> --Tom > > > > Thanks, I have already sent out a V2 in public...I might make a V3 with your > > changes too...did you sent it to ??? > > It was just a reply to your v1 patch. > > -- > ~Randy > Bhaskar, Here you go... V2 additions: diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c index af1ac3f6e4b8..73110b005716 100644 --- a/drivers/cpufreq/s5pv210-cpufreq.c +++ b/drivers/cpufreq/s5pv210-cpufreq.c @@ -91,7 +91,7 @@ static DEFINE_MUTEX(set_freq_lock); /* Use 800MHz when entering sleep mode */ #define SLEEP_FREQ (800 * 1000) -/* Tracks if cpu freqency can be updated anymore */ +/* Tracks if cpu frequency can be updated anymore */ static bool no_cpufreq_access; /* @@ -190,7 +190,7 @@ static u32 clkdiv_val[5][11] = { /* * This function set DRAM refresh counter - * accoriding to operating frequency of DRAM + * according to operating frequency of DRAM * ch: DMC port number 0 or 1 * freq: Operating frequency of DRAM(KHz) */ @@ -320,7 +320,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index) /* * 3. DMC1 refresh count for 133Mhz if (index == L4) is -* true refresh counter is already programed in upper +* true refresh counter is already programmed in upper * code. 0x287@83Mhz */ if (!bus_speed_changing)
[PATCH] cpufreq: cppc: simplify default delay_us setting
Simplify case when setting default in cppc_cpufreq_get_transition_delay_us. Signed-off-by: Tom Saeger --- drivers/cpufreq/cppc_cpufreq.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c index 8a482c434ea6..2f769b1630c5 100644 --- a/drivers/cpufreq/cppc_cpufreq.c +++ b/drivers/cpufreq/cppc_cpufreq.c @@ -216,26 +216,16 @@ static unsigned int cppc_cpufreq_get_transition_delay_us(unsigned int cpu) { unsigned long implementor = read_cpuid_implementor(); unsigned long part_num = read_cpuid_part_number(); - unsigned int delay_us = 0; switch (implementor) { case ARM_CPU_IMP_QCOM: switch (part_num) { case QCOM_CPU_PART_FALKOR_V1: case QCOM_CPU_PART_FALKOR: - delay_us = 1; - break; - default: - delay_us = cppc_get_transition_latency(cpu) / NSEC_PER_USEC; - break; + return 1; } - break; - default: - delay_us = cppc_get_transition_latency(cpu) / NSEC_PER_USEC; - break; } - - return delay_us; + return cppc_get_transition_latency(cpu) / NSEC_PER_USEC; } #else -- 2.30.1
[PATCH] mailbox: fix various typos in comments
Fix trivial typos in mailbox driver comments. s/Intergrated/Integrated/ s/extenstion/extension/ s/atleast/at least/ s/commnunication/communication/ s/assgined/assigned/ s/commnunication/communication/ s/recevied/received/ s/succeded/succeeded/ s/implmentation/implementation/ s/definiation/definition/ s/traget/target/ s/wont/won't/ Cc: triv...@kernel.org Signed-off-by: Tom Saeger --- drivers/mailbox/Kconfig | 2 +- drivers/mailbox/bcm-flexrm-mailbox.c| 4 ++-- drivers/mailbox/mailbox-xgene-slimpro.c | 6 +++--- drivers/mailbox/mailbox.h | 2 +- drivers/mailbox/pcc.c | 2 +- drivers/mailbox/pl320-ipc.c | 2 +- drivers/mailbox/sprd-mailbox.c | 12 ++-- drivers/mailbox/ti-msgmgr.c | 2 +- 8 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig index f4abe3529acd..68de2c6af727 100644 --- a/drivers/mailbox/Kconfig +++ b/drivers/mailbox/Kconfig @@ -78,7 +78,7 @@ config OMAP_MBOX_KFIFO_SIZE module parameter). config ROCKCHIP_MBOX - bool "Rockchip Soc Intergrated Mailbox Support" + bool "Rockchip Soc Integrated Mailbox Support" depends on ARCH_ROCKCHIP || COMPILE_TEST help This driver provides support for inter-processor communication diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c index bee33abb5308..b4f33dc399a0 100644 --- a/drivers/mailbox/bcm-flexrm-mailbox.c +++ b/drivers/mailbox/bcm-flexrm-mailbox.c @@ -423,7 +423,7 @@ static void flexrm_enqueue_desc(u32 nhpos, u32 nhcnt, u32 reqid, * * In general use, number of non-HEADER descriptors can easily go * beyond 31. To tackle this situation, we have packet (or request) -* extenstion bits (STARTPKT and ENDPKT) in the HEADER descriptor. +* extension bits (STARTPKT and ENDPKT) in the HEADER descriptor. * * To use packet extension, the first HEADER descriptor of request * (or packet) will have STARTPKT=1 and ENDPKT=0. The intermediate @@ -1095,7 +1095,7 @@ static int flexrm_process_completions(struct flexrm_ring *ring) /* * Get current completion read and write offset * -* Note: We should read completion write pointer atleast once +* Note: We should read completion write pointer at least once * after we get a MSI interrupt because HW maintains internal * MSI status which will allow next MSI interrupt only after * completion write pointer is read. diff --git a/drivers/mailbox/mailbox-xgene-slimpro.c b/drivers/mailbox/mailbox-xgene-slimpro.c index de260799f1b9..5b3a2dcd5955 100644 --- a/drivers/mailbox/mailbox-xgene-slimpro.c +++ b/drivers/mailbox/mailbox-xgene-slimpro.c @@ -51,10 +51,10 @@ struct slimpro_mbox_chan { /** * X-Gene SlimPRO Mailbox controller data * - * X-Gene SlimPRO Mailbox controller has 8 commnunication channels. - * Each channel has a separate IRQ number assgined to it. + * X-Gene SlimPRO Mailbox controller has 8 communication channels. + * Each channel has a separate IRQ number assigned to it. * - * @mb_ctrl: Representation of the commnunication channel controller + * @mb_ctrl: Representation of the communication channel controller * @mc:Array of SlimPRO mailbox channels of the controller * @chans: Array of mailbox communication channels * diff --git a/drivers/mailbox/mailbox.h b/drivers/mailbox/mailbox.h index 4e3cc4426513..046d6d258b32 100644 --- a/drivers/mailbox/mailbox.h +++ b/drivers/mailbox/mailbox.h @@ -5,6 +5,6 @@ #define TXDONE_BY_IRQ BIT(0) /* controller has remote RTR irq */ #define TXDONE_BY_POLL BIT(1) /* controller can read status of last TX */ -#define TXDONE_BY_ACK BIT(2) /* S/W ACK recevied by Client ticks the TX */ +#define TXDONE_BY_ACK BIT(2) /* S/W ACK received by Client ticks the TX */ #endif /* __MAILBOX_H */ diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index ef9ecd1f5958..9cb1dcf47661 100644 --- a/drivers/mailbox/pcc.c +++ b/drivers/mailbox/pcc.c @@ -32,7 +32,7 @@ * * Client writes WRITE cmd in communication region cmd address. * * Client issues mbox_send_message() which rings the PCC doorbell * for its PCC channel. - * * If command completes, then writes have succeded and it can release + * * If command completes, then writes have succeeded and it can release * the channel lock. * * There is a Nominal latency defined for each channel which indicates diff --git a/drivers/mailbox/pl320-ipc.c b/drivers/mailbox/pl320-ipc.c index 25e0b6f7a10f..fbcf07930390 100644 --- a/drivers/mailbox/pl320-ipc.c +++ b/drivers/mailbox/pl320-ipc.c @@ -73,7 +73,7 @@ static u32 __ipc_rcv(int mbox, u32 *data) return data[1]; } -/* blocking implmentation from the A9 side, not usuable in interrupts! */ +/* blocking implem
[PATCH] ACPI: fix various typos in comments
Fix trivial ACPI driver comment typos. s/notifcations/notifications/ s/Ajust/Adjust/ s/preform/perform/ s/atrributes/attributes/ s/Souce/Source/ s/Evalutes/Evaluates/ s/Evalutes/Evaluates/ s/specifiy/specify/ s/promixity/proximity/ s/presuambly/presumably/ s/Evalute/Evaluate/ s/specificed/specified/ s/rountine/routine/ s/previosuly/previously/ Change comment referencing pcc_send_cmd to send_pcc_cmd. Cc: triv...@kernel.org Signed-off-by: Tom Saeger --- drivers/acpi/ac.c | 2 +- drivers/acpi/acpi_video.c | 4 ++-- drivers/acpi/apei/erst.c | 2 +- drivers/acpi/apei/hest.c | 2 +- drivers/acpi/cppc_acpi.c | 10 +- drivers/acpi/numa/hmat.c | 2 +- drivers/acpi/pmic/intel_pmic_chtcrc.c | 2 +- drivers/acpi/power.c | 2 +- drivers/acpi/processor_perflib.c | 2 +- drivers/acpi/resource.c | 2 +- drivers/acpi/scan.c | 2 +- 11 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c index b41180330cc1..b86ee6e3baa7 100644 --- a/drivers/acpi/ac.c +++ b/drivers/acpi/ac.c @@ -187,7 +187,7 @@ static int acpi_ac_battery_notify(struct notifier_block *nb, /* * On HP Pavilion dv6-6179er AC status notifications aren't triggered * when adapter is plugged/unplugged. However, battery status -* notifcations are triggered when battery starts charging or +* notifications are triggered when battery starts charging or * discharging. Re-reading AC status triggers lost AC notifications, * if AC status has changed. */ diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index 2ea1781290cc..698c67f06e90 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -1392,7 +1392,7 @@ acpi_video_get_next_level(struct acpi_video_device *device, break; } } - /* Ajust level_current to closest available level */ + /* Adjust level_current to closest available level */ level_current += delta; for (i = ACPI_VIDEO_FIRST_LEVEL; i < device->brightness->count; i++) { l = device->brightness->levels[i]; @@ -1555,7 +1555,7 @@ acpi_video_bus_get_devices(struct acpi_video_bus *video, /* * Win8 requires setting bit2 of _DOS to let firmware know it shouldn't - * preform any automatic brightness change on receiving a notification. + * perform any automatic brightness change on receiving a notification. */ static int acpi_video_bus_start_devices(struct acpi_video_bus *video) { diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c index b9597216d021..242f3c2d5533 100644 --- a/drivers/acpi/apei/erst.c +++ b/drivers/acpi/apei/erst.c @@ -54,7 +54,7 @@ EXPORT_SYMBOL_GPL(erst_disable); static struct acpi_table_erst *erst_tab; -/* ERST Error Log Address Range atrributes */ +/* ERST Error Log Address Range attributes */ #define ERST_RANGE_RESERVED0x0001 #define ERST_RANGE_NVRAM 0x0002 #define ERST_RANGE_SLOW0x0004 diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c index f220bb00e91b..277f00b288d1 100644 --- a/drivers/acpi/apei/hest.c +++ b/drivers/acpi/apei/hest.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * APEI Hardware Error Souce Table support + * APEI Hardware Error Source Table support * * HEST describes error sources in detail; communicates operational * parameters (i.e. severity levels, masking bits, and threshold diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index 69057fcd2c04..12478e62d8d1 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -101,14 +101,14 @@ static DEFINE_PER_CPU(struct cpc_desc *, cpc_desc_ptr); (cpc)->cpc_entry.reg.space_id ==\ ACPI_ADR_SPACE_PLATFORM_COMM) -/* Evalutes to True if reg is a NULL register descriptor */ +/* Evaluates to True if reg is a NULL register descriptor */ #define IS_NULL_REG(reg) ((reg)->space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY && \ (reg)->address == 0 && \ (reg)->bit_width == 0 &&\ (reg)->bit_offset == 0 && \ (reg)->access_width == 0) -/* Evalutes to True if an optional cpc field is supported */ +/* Evaluates to True if an optional cpc field is supported */ #define CPC_SUPPORTED(cpc) ((cpc)->type == ACPI_TYPE_INTEGER ? \ !!(cpc)->cpc_entry.int_value : \ !IS_NULL_REG(&(cpc)->cpc_entry.reg)) @@ -1330,7 +1330,7 @@ int cppc_set_perf(int cpu, struct cppc_perf_ctrls *perf_ctrl
Re: [PATCH V2] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c
On Sat, Mar 13, 2021 at 04:56:21AM +0530, Bhaskar Chowdhury wrote: sent a few additional typo fixes to your V1, can you add those to your patch? Regards, --Tom
Re: [PATCH] cpufreq: Rudimentary typos fix in the file s5pv210-cpufreq.c
On Sat, Mar 13, 2021 at 04:46:20AM +0530, Bhaskar Chowdhury wrote: > On 15:01 Fri 12 Mar 2021, Krzysztof Kozlowski wrote: > > On 12/03/2021 13:08, Bhaskar Chowdhury wrote: > > > > > > s/untile/until/ > > > s/souce/source/ > > > s/divier/divider/ > > > > > > Signed-off-by: Bhaskar Chowdhury > > > --- > > > drivers/cpufreq/s5pv210-cpufreq.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/cpufreq/s5pv210-cpufreq.c > > > b/drivers/cpufreq/s5pv210-cpufreq.c > > > index bed496cf8d24..1cfea5339beb 100644 > > > --- a/drivers/cpufreq/s5pv210-cpufreq.c > > > +++ b/drivers/cpufreq/s5pv210-cpufreq.c > > > @@ -378,7 +378,7 @@ static int s5pv210_target(struct cpufreq_policy > > > *policy, unsigned int index) > > > /* > > >* 6. Turn on APLL > > >* 6-1. Set PMS values > > > - * 6-2. Wait untile the PLL is locked > > > + * 6-2. Wait until the PLL is locked > > >*/ > > > if (index == L0) > > > writel_relaxed(APLL_VAL_1000, S5P_APLL_CON); > > > @@ -390,7 +390,7 @@ static int s5pv210_target(struct cpufreq_policy > > > *policy, unsigned int index) > > > } while (!(reg & (0x1 << 29))); > > > > > > /* > > > - * 7. Change souce clock from SCLKMPLL(667Mhz) > > > + * 7. Change source clock from SCLKMPLL(667Mhz) > > >* to SCLKA2M(200Mhz) in MFC_MUX and G3D MUX > > >* (667/4=166)->(200/4=50)Mhz > > >*/ > > > @@ -439,7 +439,7 @@ static int s5pv210_target(struct cpufreq_policy > > > *policy, unsigned int index) > > > } > > > > > > /* > > > - * L4 level need to change memory bus speed, hence onedram clock divier > > > + * L4 level need to change memory bus speed, hence onedram clock divider > > > > Also grammar fix: need/needs. > > > Hmmm ...good catch...V2 on the way... > > > Best regards, > > Krzysztof May as well roll in few more? Regards, --Tom diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c index a186c0d8a290..6ecef301bd40 100644 --- a/drivers/cpufreq/s5pv210-cpufreq.c +++ b/drivers/cpufreq/s5pv210-cpufreq.c @@ -91,7 +91,7 @@ static DEFINE_MUTEX(set_freq_lock); /* Use 800MHz when entering sleep mode */ #define SLEEP_FREQ (800 * 1000) -/* Tracks if cpu freqency can be updated anymore */ +/* Tracks if cpu frequency can be updated anymore */ static bool no_cpufreq_access; /* @@ -190,7 +190,7 @@ static u32 clkdiv_val[5][11] = { /* * This function set DRAM refresh counter - * accoriding to operating frequency of DRAM + * according to operating frequency of DRAM * ch: DMC port number 0 or 1 * freq: Operating frequency of DRAM(KHz) */ @@ -320,7 +320,7 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index) /* * 3. DMC1 refresh count for 133Mhz if (index == L4) is -* true refresh counter is already programed in upper +* true refresh counter is already programmed in upper * code. 0x287@83Mhz */ if (!bus_speed_changing)
Re: [PATCH V2] get_maintainer: Add more --self-test options
Looks good, spits out ~200 issues in current MAINTAINERS file. On Tue, Nov 07, 2017 at 09:26:41AM -0800, Joe Perches wrote: > Add tests for duplicate section headers, missing section content, > link and scm reachability. > > Miscellanea: > > o Add --self-test= options > (a comma separated list of any of sections, patterns, links or scm) > where the default without options is all tests > o Rename check_maintainers_patterns to self_test > o Rename self_test_pattern_info to self_test_info > > Signed-off-by: Joe Perches > Improved-by: Tom Saeger Reviewed-by: Tom Saeger > --- > > V2: > > o Add scm tests > o Move $is_bad test out one level (Tom) > o Improve git test for specific branches (Tom) > > scripts/get_maintainer.pl | 149 > -- > 1 file changed, 132 insertions(+), 17 deletions(-)
Re: [PATCH] get_maintainer: Add a couple more --self-test options
Hi Joe, This is good! I had something similar cooking - specifically for SCM validation. My SCM attempt caught a few more issues: - check git branch if specified - check validitiy of "T:" entry, otherwise warn of malformed entry. Example malformed (current next has two instances): 9740 T: git://git.infradead.org/nvme.git Should be: 9740 T: git git://git.infradead.org/nvme.git Also - I believe you intended on warning on all bad SCM entries, not just newly discovered ones? Your change correctly finds a previously $isbad, however the print is enclosed in an else preventing output. I was going to inline these, but in my haste to understand in incorporate changes I sanitized whitespace (BTW - I see both tabs and spaces, which is preferred in this file?) The below git branch special-casing is for these: 567:T: git git://people.freedesktop.org/~airlied/linux (part of drm maint) 3671:T: git git://git.linaro.org/people/vireshk/linux.git (For ARM Updates) See bottom for my suggestions. --Tom On Mon, Nov 06, 2017 at 09:27:25AM -0800, Joe Perches wrote: > Check for duplicate section headers and link reachability. > > Miscellanea: > > o Add --self-test= options (sections, patterns and scm for now) > where the default without options is all tests > o Rename check_maintainers_patterns to self_test > o Rename self_test_pattern_info to self_test_info > > Signed-off-by: Joe Perches > cc: Tom Saeger > --- > scripts/get_maintainer.pl | 114 > +++--- > 1 file changed, 97 insertions(+), 17 deletions(-) > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > index c68a5d1ba709..748bff0790a8 100755 > --- a/scripts/get_maintainer.pl > +++ b/scripts/get_maintainer.pl > @@ -57,7 +57,7 @@ my $sections = 0; > my $file_emails = 0; > my $from_filename = 0; > my $pattern_depth = 0; > -my $self_test = 0; > +my $self_test = undef; > my $version = 0; > my $help = 0; > my $find_maintainer_files = 0; > @@ -221,7 +221,7 @@ if (-f $ignore_file) { > > if ($#ARGV > 0) { > foreach (@ARGV) { > -if ($_ eq "-self-test" || $_ eq "--self-test") { > +if ($_ =~ /^-{1,2}self-test(?:=|$)/) { > die "$P: using --self-test does not allow any other option or > argument\n"; > } > } > @@ -263,7 +263,7 @@ if (!GetOptions( > 'fe|file-emails!' => \$file_emails, > 'f|file' => \$from_filename, > 'find-maintainer-files' => \$find_maintainer_files, > - 'self-test' => \$self_test, > + 'self-test:s' => \$self_test, > 'v|version' => \$version, > 'h|help|usage' => \$help, > )) { > @@ -280,9 +280,9 @@ if ($version != 0) { > exit 0; > } > > -if ($self_test) { > +if (defined $self_test) { > read_all_maintainer_files(); > -check_maintainers_patterns(); > +self_test(); > exit 0; > } > > @@ -329,7 +329,7 @@ if (!top_of_kernel_tree($lk_path)) { > my @typevalue = (); > my %keyword_hash; > my @mfiles = (); > -my @self_test_pattern_info = (); > +my @self_test_info = (); > > sub read_maintainer_file { > my ($file) = @_; > @@ -339,6 +339,7 @@ sub read_maintainer_file { > my $i = 1; > while (<$maint>) { > my $line = $_; > + chomp $line; > > if ($line =~ m/^([A-Z]):\s*(.*)/) { > my $type = $1; > @@ -353,17 +354,16 @@ sub read_maintainer_file { > if ((-d $value)) { > $value =~ s@([^/])$@$1/@; > } > - if ($self_test) { > - push(@self_test_pattern_info, {file=>$file, > line=>$line, linenr=>$i, pat=>$value}); > - } > } elsif ($type eq "K") { > $keyword_hash{@typevalue} = $value; > } > push(@typevalue, "$type:$value"); > } elsif (!(/^\s*$/ || /^\s*\#/)) { > - $line =~ s/\n$//g; > push(@typevalue, $line); > } > + if (defined $self_test) { > + push(@self_test_info, {file=>$file, linenr=>$i, line=>$line}); > + } > $i++; > } > close($maint); > @@ -614,17 +614,97 @@ if ($web) { > > exit($exit); > > -sub check_maintainers_patterns { > +sub self_test { > my @lsfiles = (); > +my @good_links = (); > +my @bad_links = (); > +my @section_headers = (); > > @lsfiles = vcs_list_files($lk_path); > > -for my $x (@self
[PATCH v2 1/1] scripts: warn about invalid MAINTAINERS patterns
Add "--self-test" option to get_maintainer.pl to show potential issues in MAINTAINERS file(s) content. Pattern check warnings are shown for "F" and "X" patterns found in MAINTAINERS file(s) which do not match any files known by git. Signed-off-by: Tom Saeger Cc: Joe Perches --- v2: Incorporated suggestions from Joe Perches: - changed "--pattern-checks" to "--self-test" to allow for future work. - fixed vcs command "list_files_cmd" for mercurial. - "--self-test" option is all or nothing. - output to STDOUT - output format in emacs-style "filename:line: message" - changed self-test help to: --self-test => show potential issues with MAINTAINERS file content (Joe, I slightly reworded in hopes this rendition is clear and future proof). - Moved execution of $self_test to just after $help and $version. This prompted encapsulating main content code to read MAINTAINERS files into a function (read_all_maintainer_files) callable from $self_test. This has the side benefit of not having to special case for "$self_test" in other parts of main program flow. scripts/get_maintainer.pl | 94 ++- 1 file changed, 77 insertions(+), 17 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index bc443201d3ef..c68a5d1ba709 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -57,6 +57,7 @@ my $sections = 0; my $file_emails = 0; my $from_filename = 0; my $pattern_depth = 0; +my $self_test = 0; my $version = 0; my $help = 0; my $find_maintainer_files = 0; @@ -138,6 +139,7 @@ my %VCS_cmds_git = ( "subject_pattern" => "^GitSubject: (.*)", "stat_pattern" => "^(\\d+)\\t(\\d+)\\t\$file\$", "file_exists_cmd" => "git ls-files \$file", +"list_files_cmd" => "git ls-files \$file", ); my %VCS_cmds_hg = ( @@ -167,6 +169,7 @@ my %VCS_cmds_hg = ( "subject_pattern" => "^HgSubject: (.*)", "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$", "file_exists_cmd" => "hg files \$file", +"list_files_cmd" => "hg manifest -R \$file", ); my $conf = which_conf(".get_maintainer.conf"); @@ -216,6 +219,14 @@ if (-f $ignore_file) { close($ignore); } +if ($#ARGV > 0) { +foreach (@ARGV) { +if ($_ eq "-self-test" || $_ eq "--self-test") { +die "$P: using --self-test does not allow any other option or argument\n"; +} +} +} + if (!GetOptions( 'email!' => \$email, 'git!' => \$email_git, @@ -252,6 +263,7 @@ if (!GetOptions( 'fe|file-emails!' => \$file_emails, 'f|file' => \$from_filename, 'find-maintainer-files' => \$find_maintainer_files, + 'self-test' => \$self_test, 'v|version' => \$version, 'h|help|usage' => \$help, )) { @@ -268,6 +280,12 @@ if ($version != 0) { exit 0; } +if ($self_test) { +read_all_maintainer_files(); +check_maintainers_patterns(); +exit 0; +} + if (-t STDIN && !@ARGV) { # We're talking to a terminal, but have no command line arguments. die "$P: missing patchfile or -f file - use --help if necessary\n"; @@ -311,12 +329,14 @@ if (!top_of_kernel_tree($lk_path)) { my @typevalue = (); my %keyword_hash; my @mfiles = (); +my @self_test_pattern_info = (); sub read_maintainer_file { my ($file) = @_; open (my $maint, '<', "$file") or die "$P: Can't open MAINTAINERS file '$file': $!\n"; +my $i = 1; while (<$maint>) { my $line = $_; @@ -333,6 +353,9 @@ sub read_maintainer_file { if ((-d $value)) { $value =~ s@([^/])$@$1/@; } + if ($self_test) { + push(@self_test_pattern_info, {file=>$file, line=>$line, linenr=>$i, pat=>$value}); + } } elsif ($type eq "K") { $keyword_hash{@typevalue} = $value; } @@ -341,6 +364,7 @@ sub read_maintainer_file { $line =~ s/\n$//g; push(@typevalue, $line); } + $i++; } close($maint); } @@ -357,26 +381,30 @@ sub find_ignore_git { return grep { $_ !~ /^\.git$/; } @_; } -if (-d "${lk_path}MAINTAINERS") { -opendir(DIR, "${lk_path}MAINTAINERS") or die $!; -my @files = readdir(DIR); -closedir(DIR); -foreach my $file (@files) { - push(@mfiles, "${lk_path}MAIN
Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns
On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote: > (add mercurial-devel and xen-devel to cc's) > > On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote: > > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid > > "F" and "X" patterns found in MAINTAINERS file(s). > > Hey again Tom. > > About mercurial/hg. > > While as far as I know there hasn't been a mercurial tree > for the linux kernel sources in many years, I believe the > mercurial command to list files should be different. > > > my %VCS_cmds_hg = ( > > @@ -167,6 +169,7 @@ my %VCS_cmds_hg = ( > > "subject_pattern" => "^HgSubject: (.*)", > > "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$", > > "file_exists_cmd" => "hg files \$file", > > +"list_files_cmd" => "hg files \$file", > > I think this should be > > "list_files_cmd" => "hg manifest -R \$file", Ok - I'll add to v2.
Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns
On Wed, Nov 01, 2017 at 08:32:51AM -0700, Joe Perches wrote: > On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote: > > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid > > "F" and "X" patterns found in MAINTAINERS file(s). > > Hey Tom. > > I've come around to this addition, but I think a few > changes are useful. > > o Change --pattern-checks to --self-test so future checks > can be added (valid email address, .mailmap uses, existence > of git trees, etc...) Ok. Had similar thoughts. Was just looking at git trees. > o Do not require an unnecessary argument with --self-test Ok. > o Validate --self-test if it is the only command line argument Ok. > o Use emacs filename:line: style output for easier linking Ok. > o --self-test emits to STDOUT not STDERR Ok - I debated this one, I'll change it back. Thanks for your input Joe, I'll send a v2. --Tom
[PATCH] scripts: warn about invalid MAINTAINERS patterns
Add "--pattern-checks" option to get_maintainer.pl to warn about invalid "F" and "X" patterns found in MAINTAINERS file(s). Signed-off-by: Tom Saeger Cc: Joe Perches --- scripts/get_maintainer.pl | 47 +++ 1 file changed, 47 insertions(+) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index bc443201d3ef..ab741b022405 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -57,6 +57,7 @@ my $sections = 0; my $file_emails = 0; my $from_filename = 0; my $pattern_depth = 0; +my $pattern_checks = 0; my $version = 0; my $help = 0; my $find_maintainer_files = 0; @@ -138,6 +139,7 @@ my %VCS_cmds_git = ( "subject_pattern" => "^GitSubject: (.*)", "stat_pattern" => "^(\\d+)\\t(\\d+)\\t\$file\$", "file_exists_cmd" => "git ls-files \$file", +"list_files_cmd" => "git ls-files \$file", ); my %VCS_cmds_hg = ( @@ -167,6 +169,7 @@ my %VCS_cmds_hg = ( "subject_pattern" => "^HgSubject: (.*)", "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$", "file_exists_cmd" => "hg files \$file", +"list_files_cmd" => "hg files \$file", ); my $conf = which_conf(".get_maintainer.conf"); @@ -252,6 +255,7 @@ if (!GetOptions( 'fe|file-emails!' => \$file_emails, 'f|file' => \$from_filename, 'find-maintainer-files' => \$find_maintainer_files, + 'pattern-checks' => \$pattern_checks, 'v|version' => \$version, 'h|help|usage' => \$help, )) { @@ -311,12 +315,14 @@ if (!top_of_kernel_tree($lk_path)) { my @typevalue = (); my %keyword_hash; my @mfiles = (); +my @pattern_checks_info = (); sub read_maintainer_file { my ($file) = @_; open (my $maint, '<', "$file") or die "$P: Can't open MAINTAINERS file '$file': $!\n"; +my $i = 1; while (<$maint>) { my $line = $_; @@ -333,6 +339,9 @@ sub read_maintainer_file { if ((-d $value)) { $value =~ s@([^/])$@$1/@; } + if ($pattern_checks) { + push(@pattern_checks_info, {file=>$file, line=>$line, linenr=>$i, pat=>$value}); + } } elsif ($type eq "K") { $keyword_hash{@typevalue} = $value; } @@ -341,6 +350,7 @@ sub read_maintainer_file { $line =~ s/\n$//g; push(@typevalue, $line); } + $i++; } close($maint); } @@ -543,6 +553,11 @@ foreach my $file (@ARGV) { } } +if ($pattern_checks) { +check_maintainers_patterns(); +exit 0; +} + @file_emails = uniq(@file_emails); my %email_hash_name; @@ -586,6 +601,20 @@ if ($web) { exit($exit); +sub check_maintainers_patterns { +my @lsfiles = (); + +@lsfiles = vcs_list_files($lk_path); + +for my $x (@pattern_checks_info) { +if (!grep(m@^$x->{pat}@, @lsfiles)) { +my $line = $x->{line}; +chomp($line); +print(STDERR "$x->{file}:$x->{linenr}\twarning: no matches\t$line\n"); +} +} +} + sub ignore_email_address { my ($address) = @_; @@ -863,6 +892,7 @@ Other options: --sections => print all of the subsystem sections with pattern matches --letters => print all matching 'letter' types from all matching sections --mailmap => use .mailmap file (default: $email_use_mailmap) + --pattern-checks => warn about invalid "F" and "X" patterns in MAINTAINERS file --version => show version --help => show this help information @@ -2192,6 +,23 @@ sub vcs_file_exists { return $exists; } +sub vcs_list_files { +my ($file) = @_; + +my @lsfiles = (); + +my $vcs_used = vcs_exists(); +return 0 if (!$vcs_used); + +my $cmd = $VCS_cmds{"list_files_cmd"}; +$cmd =~ s/(\$\w+)/$1/eeg; # interpolate $cmd +@lsfiles = &{$VCS_cmds{"execute_cmd"}}($cmd); + +return () if ($? != 0); + +return @lsfiles; +} + sub uniq { my (@parms) = @_; -- 2.14.3
Re: [RFC PATCH 1/2] scripts: warn about invalid MAINTAINER patterns
On Tue, Oct 31, 2017 at 08:47:58AM -0700, Joe Perches wrote: > On Tue, 2017-10-31 at 09:46 -0500, Tom Saeger wrote: > > Add get_maintainer.pl option to warn about invalid > > "F" and "X" patterns found in MAINTAINERS file(s). > > Hi Tom. > > I've had a similar script for many years. > > This implementation is very inefficient as it runs > git ls-files once for each file pattern. > > It's much more efficient to do a global git ls-files > once and store the result and then do a local grep > for pattern matches. OH! that was my intention. Thanks - I'll fix it. > > cheers, Joe
[PATCH v2 1/1] staging: Fix incorrect unisys MAINTAINERS pattern
Fix stale path to documentation in MAINTAINERS file. Signed-off-by: Tom Saeger Cc: David Kershner Cc: Greg Kroah-Hartman --- drivers/staging/unisys/MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/MAINTAINERS b/drivers/staging/unisys/MAINTAINERS index 1f0425bf3583..aaddc619c329 100644 --- a/drivers/staging/unisys/MAINTAINERS +++ b/drivers/staging/unisys/MAINTAINERS @@ -1,5 +1,5 @@ Unisys s-Par drivers M: David Kershner S: Maintained -F: Documentation/s-Par/overview.txt +F: drivers/staging/unisys/Documentation/overview.txt F: drivers/staging/unisys/ -- 2.14.3
Re: [PATCH] staging: Fix incorrect unisys MAINTAINERS pattern
On Tue, Oct 31, 2017 at 04:10:42PM +0100, Greg Kroah-Hartman wrote: > On Tue, Oct 31, 2017 at 09:55:54AM -0500, Tom Saeger wrote: > > Signed-off-by: Tom Saeger > > Cc: David Kershner > > Cc: Greg Kroah-Hartman > > --- > > drivers/staging/unisys/MAINTAINERS | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I don't take patches without any changelog text, and you shouldn't ever > generate such a thing :) My bad, tried to get fancy and skip a step in my own process. > > thanks, > > greg k-h
[PATCH] staging: Fix incorrect unisys MAINTAINERS pattern
Signed-off-by: Tom Saeger Cc: David Kershner Cc: Greg Kroah-Hartman --- drivers/staging/unisys/MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/MAINTAINERS b/drivers/staging/unisys/MAINTAINERS index 1f0425bf3583..aaddc619c329 100644 --- a/drivers/staging/unisys/MAINTAINERS +++ b/drivers/staging/unisys/MAINTAINERS @@ -1,5 +1,5 @@ Unisys s-Par drivers M: David Kershner S: Maintained -F: Documentation/s-Par/overview.txt +F: drivers/staging/unisys/Documentation/overview.txt F: drivers/staging/unisys/ -- 2.14.3
[RFC PATCH 2/2] MAINTAINERS: various pattern fixes for mv/rm/typos
Several stale or typo'd "F" "X" patterns fixed. Signed-off-by: Tom Saeger --- MAINTAINERS | 107 1 file changed, 42 insertions(+), 65 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index af0cb69f6a3e..8ba5ec8584dc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -885,7 +885,6 @@ L: de...@driverdev.osuosl.org S: Supported F: drivers/staging/android/ion F: drivers/staging/android/uapi/ion.h -F: drivers/staging/android/uapi/ion_test.h AOA (Apple Onboard Audio) ALSA DRIVER M: Johannes Berg @@ -1279,7 +1278,6 @@ M:Russell King L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) S: Maintained T: git git://git.armlinux.org.uk/~rmk/linux-arm.git clkdev -F: arch/arm/include/asm/clkdev.h F: drivers/clk/clkdev.c ARM/COMPULAB CM-X270/EM-X270 and CM-X300 MACHINE SUPPORT @@ -1687,7 +1685,7 @@ M:Tomas Cech L: linux-arm-ker...@lists.infradead.org W: http://hackndev.com S: Maintained -F: arch/arm/mach-pxa/include/mach/palmtreo.h +F: arch/arm/mach-pxa/palmtreo.h F: arch/arm/mach-pxa/palmtreo.c ARM/PALMTX,PALMT5,PALMLD,PALMTE2,PALMTC SUPPORT @@ -1697,11 +1695,11 @@ W: http://hackndev.com S: Maintained F: arch/arm/mach-pxa/include/mach/palmtx.h F: arch/arm/mach-pxa/palmtx.c -F: arch/arm/mach-pxa/include/mach/palmt5.h +F: arch/arm/mach-pxa/palmt5.h F: arch/arm/mach-pxa/palmt5.c F: arch/arm/mach-pxa/include/mach/palmld.h F: arch/arm/mach-pxa/palmld.c -F: arch/arm/mach-pxa/include/mach/palmte2.h +F: arch/arm/mach-pxa/palmte2.h F: arch/arm/mach-pxa/palmte2.c F: arch/arm/mach-pxa/include/mach/palmtc.h F: arch/arm/mach-pxa/palmtc.c @@ -1711,7 +1709,7 @@ M:Sergey Lapin L: linux-arm-ker...@lists.infradead.org W: http://hackndev.com S: Maintained -F: arch/arm/mach-pxa/include/mach/palmz72.h +F: arch/arm/mach-pxa/palmz72.h F: arch/arm/mach-pxa/palmz72.c ARM/PLEB SUPPORT @@ -1741,7 +1739,6 @@ F:drivers/clk/qcom/ F: drivers/dma/qcom/ F: drivers/soc/qcom/ F: drivers/spi/spi-qup.c -F: drivers/tty/serial/msm_serial.h F: drivers/tty/serial/msm_serial.c F: drivers/*/pm8???-* F: drivers/mfd/ssbi.c @@ -1870,7 +1867,6 @@ M:Andrzej Hajda L: linux-arm-ker...@lists.infradead.org L: linux-me...@vger.kernel.org S: Maintained -F: arch/arm/plat-samsung/s5p-dev-mfc.c F: drivers/media/platform/s5p-mfc/ ARM/SHMOBILE ARM ARCHITECTURE @@ -1908,7 +1904,7 @@ F:drivers/clk/socfpga/ ARM/SOCFPGA EDAC SUPPORT M: Thor Thayer S: Maintained -F: drivers/edac/altera_edac. +F: drivers/edac/altera_edac.* ARM/STI ARCHITECTURE M: Patrice Chotard @@ -2348,7 +2344,7 @@ M:Ludovic Desroches L: linux-me...@vger.kernel.org S: Supported F: drivers/media/platform/atmel/atmel-isi.c -F: include/media/atmel-isi.h +F: drivers/media/platform/atmel/atmel-isi.h ATMEL LCDFB DRIVER M: Nicolas Ferre @@ -2923,7 +2919,7 @@ N:bcm583* N: bcm585* N: bcm586* N: bcm88312 -F: arch/arm64/boot/dts/broadcom/ns2* +F: arch/arm64/boot/dts/broadcom/northstar2/* F: drivers/clk/bcm/clk-ns* F: drivers/pinctrl/bcm/pinctrl-ns* @@ -3016,7 +3012,7 @@ M:Clemens Ladisch L: alsa-de...@alsa-project.org (moderated for non-subscribers) T: git git://git.alsa-project.org/alsa-kernel.git S: Maintained -F: Documentation/sound/alsa/Bt87x.txt +F: Documentation/sound/cards/bt87x.rst F: sound/pci/bt87x.c BT8XXGPIO DRIVER @@ -3298,7 +3294,7 @@ M:David Howells M: David Woodhouse L: keyri...@vger.kernel.org S: Maintained -F: Documentation/module-signing.txt +F: Documentation/admin-guide/module-signing.rst F: certs/ F: scripts/sign-file.c F: scripts/extract-cert.c @@ -3579,7 +3575,7 @@ T:git git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git S: Maintained F: Documentation/cgroup-v1/cpusets.txt F: include/linux/cpuset.h -F: kernel/cpuset.c +F: kernel/cgroup/cpuset.c CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG) M: Johannes Weiner @@ -3720,7 +3716,6 @@ T:git git://linuxtv.org/media_tree.git W: http://linuxtv.org S: Odd Fixes F: drivers/media/i2c/cs3308.c -F: drivers/media/i2c/cs3308.h CS5535 Audio ALSA driver M: Jaya Kumar @@ -3751,7 +3746,7 @@ T:git git://linuxtv.org/media_tree.git W: https://linuxtv.org S: Maintained F: drivers/media/common/cx2341x* -F: include/media/cx2341x* +F: include/media/drv-intf/cx2341x* CX24120 MEDIA DRIVER M: Jemma Denson @@ -3859,7 +3854,7 @@ M:Uma Krishnan L: linux-s...@vger.kernel.org S: Supported F: drivers/scsi/cxlflash/ -F: include/uapi/
[RFC PATCH 0/2] scripts: warn about invalid MAINTAINER patterns
This series attempts to fix all stale MAINTAINER file "F" and "X" patterns. First patch adds an option "checks" to get_maintainer.pl which outputs warnings for any "F" or "X" pattern found in MAINTAINER file which does not register any file/directory matches known by git in current worktree. Originally, I wrote a standalone script "check_maintainer", but as this duplicated some of the functions found in get_maintainer.pl it seemed to make more sense to change get_maintainer.pl directly. The "-x|--checks" option is intended to be used as follows: ./scripts/get_maintainer.pl -x ./ | tee out.txt ./MAINTAINERS:1743 warning: no matches drivers/.*/pm8...-.*F: drivers/*/pm8???-* ./MAINTAINERS:8721 warning: no matches drivers/net/ethernet/mellanox/mlx5/core/en_ipsec/.* F: drivers/net/ethernet/mellanox/mlx5/core/en_ipsec/* ./MAINTAINERS:8722 warning: no matches drivers/net/ethernet/mellanox/mlx5/core/ipsec.* F: drivers/net/ethernet/mellanox/mlx5/core/ipsec* ./MAINTAINERS:9431 warning: no matches net/core/flow\.cF: net/core/flow.c The output format lends itself to the following in vim (note tab character): set errorformat=%f:%l\ %m cfile out.txt copen Second patch fixes all MAINTAINER warnings but four (those listed above), which were not obvious to me how to fix. Most fixes were obvious, requiring only "ls ./**/*pat*" or "git log --follow -- xyz.c" or "git blame MAINTAINERS" to figure out what needed to be changed. Patches are independent, however I did employ the first in figuring out the second. Looking for input on how best to get these merged. Some of these have been broken for a long time - so stable kernels might benefit from backporting. Future enhancements could sanity check all the other entry types found in MAINTAINER file. --Tom Tom Saeger (2): scripts: warn about invalid MAINTAINER patterns MAINTAINERS: various pattern fixes for mv/rm/typos MAINTAINERS | 107 ++ scripts/get_maintainer.pl | 65 2 files changed, 107 insertions(+), 65 deletions(-) -- 2.14.3
[RFC PATCH 1/2] scripts: warn about invalid MAINTAINER patterns
Add get_maintainer.pl option to warn about invalid "F" and "X" patterns found in MAINTAINERS file(s). Signed-off-by: Tom Saeger --- scripts/get_maintainer.pl | 65 +++ 1 file changed, 65 insertions(+) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index bc443201d3ef..e01041325ea0 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -19,6 +19,7 @@ my $V = '0.26'; use Getopt::Long qw(:config no_auto_abbrev); use Cwd; use File::Find; +use File::Basename; my $cur_path = fastgetcwd() . '/'; my $lk_path = "./"; @@ -57,6 +58,7 @@ my $sections = 0; my $file_emails = 0; my $from_filename = 0; my $pattern_depth = 0; +my $xchecks = 0; my $version = 0; my $help = 0; my $find_maintainer_files = 0; @@ -138,6 +140,7 @@ my %VCS_cmds_git = ( "subject_pattern" => "^GitSubject: (.*)", "stat_pattern" => "^(\\d+)\\t(\\d+)\\t\$file\$", "file_exists_cmd" => "git ls-files \$file", +"list_files_cmd" => "git ls-files \$file", ); my %VCS_cmds_hg = ( @@ -167,6 +170,7 @@ my %VCS_cmds_hg = ( "subject_pattern" => "^HgSubject: (.*)", "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$", "file_exists_cmd" => "hg files \$file", +"list_files_cmd" => "hg files \$file", ); my $conf = which_conf(".get_maintainer.conf"); @@ -252,6 +256,7 @@ if (!GetOptions( 'fe|file-emails!' => \$file_emails, 'f|file' => \$from_filename, 'find-maintainer-files' => \$find_maintainer_files, + 'x|checks' => \$xchecks, 'v|version' => \$version, 'h|help|usage' => \$help, )) { @@ -311,12 +316,14 @@ if (!top_of_kernel_tree($lk_path)) { my @typevalue = (); my %keyword_hash; my @mfiles = (); +my @patternchecks = (); sub read_maintainer_file { my ($file) = @_; open (my $maint, '<', "$file") or die "$P: Can't open MAINTAINERS file '$file': $!\n"; +my $i = 1; while (<$maint>) { my $line = $_; @@ -333,6 +340,9 @@ sub read_maintainer_file { if ((-d $value)) { $value =~ s@([^/])$@$1/@; } + if ($xchecks) { + push(@patternchecks, {file=>$file, line=>$line, linenr=>$i, pat=>$value}); + } } elsif ($type eq "K") { $keyword_hash{@typevalue} = $value; } @@ -341,6 +351,7 @@ sub read_maintainer_file { $line =~ s/\n$//g; push(@typevalue, $line); } + $i++; } close($maint); } @@ -543,6 +554,11 @@ foreach my $file (@ARGV) { } } +if ($xchecks) { +check_maintainer_patterns(); +exit 0; +} + @file_emails = uniq(@file_emails); my %email_hash_name; @@ -584,6 +600,37 @@ if ($web) { output(@web); } +sub has_valid_matches { +my ($value, $files) = @_; +foreach my $file (@{$files}) { +if (file_match_pattern($file, $value)) { +return 1; +} +} +return 0; +} + +sub check_maintainer_patterns { +my @lsfiles = (); + +@lsfiles = vcs_list_files($lk_path); + +# add directories too +my @dirs = (); +foreach my $f (@lsfiles) { +push(@dirs, dirname($f)); +} +push(@lsfiles, uniq(@dirs)); + +for my $x (@patternchecks) { +if (!has_valid_matches($x->{pat}, \@lsfiles)) { +my $line = $x->{line}; +chomp($line); +print("$x->{file}:$x->{linenr}\twarning: no matches\t$x->{pat}\t$line\n"); +} +} +} + exit($exit); sub ignore_email_address { @@ -863,6 +910,7 @@ Other options: --sections => print all of the subsystem sections with pattern matches --letters => print all matching 'letter' types from all matching sections --mailmap => use .mailmap file (default: $email_use_mailmap) + --checks => check for "F" and "X" pattern warnings --version => show version --help => show this help information @@ -2192,6 +2240,23 @@ sub vcs_file_exists { return $exists; } +sub vcs_list_files { +my ($file) = @_; + +my @lsfiles = (); + +my $vcs_used = vcs_exists(); +return 0 if (!$vcs_used); + +my $cmd = $VCS_cmds{"list_files_cmd"}; +$cmd =~ s/(\$\w+)/$1/eeg; # interpolate $cmd +@lsfiles = &{$VCS_cmds{"execute_cmd"}}($cmd); + +return () if ($? != 0); + +return @lsfiles; +} + sub uniq { my (@parms) = @_; -- 2.14.3
[PATCH 7/8] Documentation: fix selftests related file refs
Make refs to selftests files valid including: - watchdog-test.c - dnotify_test.c Signed-off-by: Tom Saeger --- Documentation/filesystems/dnotify.txt| 2 +- Documentation/watchdog/hpwdt.txt | 2 +- Documentation/watchdog/pcwd-watchdog.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/filesystems/dnotify.txt b/Documentation/filesystems/dnotify.txt index 6baf88f46859..15156883d321 100644 --- a/Documentation/filesystems/dnotify.txt +++ b/Documentation/filesystems/dnotify.txt @@ -62,7 +62,7 @@ disabled, fcntl(fd, F_NOTIFY, ...) will return -EINVAL. Example --- -See Documentation/filesystems/dnotify_test.c for an example. +See tools/testing/selftests/filesystems/dnotify_test.c for an example. NOTE diff --git a/Documentation/watchdog/hpwdt.txt b/Documentation/watchdog/hpwdt.txt index 7a9f635d0258..6d866c537127 100644 --- a/Documentation/watchdog/hpwdt.txt +++ b/Documentation/watchdog/hpwdt.txt @@ -15,7 +15,7 @@ Last reviewed: 05/20/2016 Watchdog functionality is enabled like any other common watchdog driver. That is, an application needs to be started that kicks off the watchdog timer. A - basic application exists in the Documentation/watchdog/src directory called + basic application exists in tools/testing/selftests/watchdog/ named watchdog-test.c. Simply compile the C file and kick it off. If the system gets into a bad state and hangs, the HPE ProLiant iLO timer register will not be updated in a timely fashion and a hardware system reset (also known as diff --git a/Documentation/watchdog/pcwd-watchdog.txt b/Documentation/watchdog/pcwd-watchdog.txt index 4f68052395c0..b8e60a441a43 100644 --- a/Documentation/watchdog/pcwd-watchdog.txt +++ b/Documentation/watchdog/pcwd-watchdog.txt @@ -25,7 +25,7 @@ Last reviewed: 10/05/2007 If you want to write a program to be compatible with the PC Watchdog driver, simply use of modify the watchdog test program: - Documentation/watchdog/src/watchdog-test.c + tools/testing/selftests/watchdog/watchdog-test.c Other IOCTL functions include: -- 2.14.2
[PATCH 1/8] Documentation: fix locking rt-mutex doc refs
Signed-off-by: Tom Saeger --- Documentation/locking/rt-mutex-design.txt | 2 +- Documentation/pi-futex.txt| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/locking/rt-mutex-design.txt b/Documentation/locking/rt-mutex-design.txt index 6c6e8c2410de..3d7b865539cc 100644 --- a/Documentation/locking/rt-mutex-design.txt +++ b/Documentation/locking/rt-mutex-design.txt @@ -8,7 +8,7 @@ RT-mutex implementation design This document tries to describe the design of the rtmutex.c implementation. It doesn't describe the reasons why rtmutex.c exists. For that please see -Documentation/rt-mutex.txt. Although this document does explain problems +Documentation/locking/rt-mutex.txt. Although this document does explain problems that happen without this code, but that is in the concept to understand what the code actually is doing. diff --git a/Documentation/pi-futex.txt b/Documentation/pi-futex.txt index aafddbee7377..b154f6c0c36e 100644 --- a/Documentation/pi-futex.txt +++ b/Documentation/pi-futex.txt @@ -119,4 +119,4 @@ properties of futexes, and all four combinations are possible: futex, robust-futex, PI-futex, robust+PI-futex. More details about priority inheritance can be found in -Documentation/rt-mutex.txt. +Documentation/locking/rt-mutex.txt. -- 2.14.2
[PATCH 6/8] Documentation: fix ref to power basic-pm-debugging
Signed-off-by: Tom Saeger --- Documentation/power/interface.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/power/interface.txt b/Documentation/power/interface.txt index 7dc75f48e8bd..27df7f98668a 100644 --- a/Documentation/power/interface.txt +++ b/Documentation/power/interface.txt @@ -43,7 +43,7 @@ The currently selected option is printed in square brackets. The 'platform' option is only available if the platform provides a special mechanism to put the system to sleep after creating a hibernation image (ACPI does that, for example). The 'suspend' option is available if Suspend-to-RAM -is supported. Refer to Documentation/power/basic_pm_debugging.txt for the +is supported. Refer to Documentation/power/basic-pm-debugging.txt for the description of the 'test_resume' option. To select an option, write the string representing it to /sys/power/disk. -- 2.14.2
[PATCH 8/8] Documentation: fix ref to gpio.txt
Signed-off-by: Tom Saeger --- Documentation/ABI/obsolete/sysfs-gpio | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/ABI/obsolete/sysfs-gpio b/Documentation/ABI/obsolete/sysfs-gpio index 867c1fab20e2..32513dc2eec9 100644 --- a/Documentation/ABI/obsolete/sysfs-gpio +++ b/Documentation/ABI/obsolete/sysfs-gpio @@ -11,7 +11,7 @@ Description: Kernel code may export it for complete or partial access. GPIOs are identified as they are inside the kernel, using integers in - the range 0..INT_MAX. See Documentation/gpio.txt for more information. + the range 0..INT_MAX. See Documentation/gpio/gpio.txt for more information. /sys/class/gpio /export ... asks the kernel to export a GPIO to userspace -- 2.14.2
[PATCH 2/8] Documentation: fix ref to sphinx/kerneldoc.py
Signed-off-by: Tom Saeger --- Documentation/doc-guide/kernel-doc.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/doc-guide/kernel-doc.rst b/Documentation/doc-guide/kernel-doc.rst index b24854b5d6be..0268335414ce 100644 --- a/Documentation/doc-guide/kernel-doc.rst +++ b/Documentation/doc-guide/kernel-doc.rst @@ -65,7 +65,7 @@ Without options, the kernel-doc directive includes all documentation comments from the source file. The kernel-doc extension is included in the kernel source tree, at -``Documentation/sphinx/kernel-doc.py``. Internally, it uses the +``Documentation/sphinx/kerneldoc.py``. Internally, it uses the ``scripts/kernel-doc`` script to extract the documentation comments from the source. -- 2.14.2
[PATCH 5/8] Documentation: fix ref to trace stm content
Signed-off-by: Tom Saeger --- Documentation/trace/intel_th.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/trace/intel_th.txt b/Documentation/trace/intel_th.txt index f92070e7dde0..7a57165c2492 100644 --- a/Documentation/trace/intel_th.txt +++ b/Documentation/trace/intel_th.txt @@ -37,7 +37,7 @@ description is at Documentation/ABI/testing/sysfs-bus-intel_th-devices-gth. STH registers an stm class device, through which it provides interface to userspace and kernelspace software trace sources. See -Documentation/tracing/stm.txt for more information on that. +Documentation/trace/stm.txt for more information on that. MSU can be configured to collect trace data into a system memory buffer, which can later on be read from its device nodes via read() or -- 2.14.2
[PATCH 4/8] Documentation: fix ref to coccinelle content
Signed-off-by: Tom Saeger --- Documentation/process/4.Coding.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/process/4.Coding.rst b/Documentation/process/4.Coding.rst index 6df19943dd4d..26b106071364 100644 --- a/Documentation/process/4.Coding.rst +++ b/Documentation/process/4.Coding.rst @@ -307,7 +307,7 @@ variety of potential coding problems; it can also propose fixes for those problems. Quite a few "semantic patches" for the kernel have been packaged under the scripts/coccinelle directory; running "make coccicheck" will run through those semantic patches and report on any problems found. See -Documentation/coccinelle.txt for more information. +Documentation/dev-tools/coccinelle.rst for more information. Other kinds of portability errors are best found by compiling your code for other architectures. If you do not happen to have an S/390 system or a -- 2.14.2
[PATCH 3/8] Documentation: fix ref to workqueue content
Signed-off-by: Tom Saeger --- .../RCU/Design/Expedited-Grace-Periods/Expedited-Grace-Periods.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/RCU/Design/Expedited-Grace-Periods/Expedited-Grace-Periods.html b/Documentation/RCU/Design/Expedited-Grace-Periods/Expedited-Grace-Periods.html index e5d0bbd0230b..7394f034be65 100644 --- a/Documentation/RCU/Design/Expedited-Grace-Periods/Expedited-Grace-Periods.html +++ b/Documentation/RCU/Design/Expedited-Grace-Periods/Expedited-Grace-Periods.html @@ -527,7 +527,7 @@ grace period also drove it to completion. This straightforward approach had the disadvantage of needing to account for POSIX signals sent to user tasks, so more recent implemementations use the Linux kernel's -https://www.kernel.org/doc/Documentation/workqueue.txt";>workqueues. +https://www.kernel.org/doc/Documentation/core-api/workqueue.rst";>workqueues. The requesting task still does counter snapshotting and funnel-lock -- 2.14.2
[PATCH 0/8] Documentation: fix invalid Documentation refs (2)
Batch (2) set of simple document ref fixes. Tom Saeger (8): Documentation: fix locking rt-mutex doc refs Documentation: fix ref to sphinx/kerneldoc.py Documentation: fix ref to workqueue content Documentation: fix ref to coccinelle content Documentation: fix ref to trace stm content Documentation: fix ref to power basic-pm-debugging Documentation: fix selftests related file refs Documentation: fix ref to gpio.txt Documentation/ABI/obsolete/sysfs-gpio | 2 +- .../RCU/Design/Expedited-Grace-Periods/Expedited-Grace-Periods.html | 2 +- Documentation/doc-guide/kernel-doc.rst | 2 +- Documentation/filesystems/dnotify.txt | 2 +- Documentation/locking/rt-mutex-design.txt | 2 +- Documentation/pi-futex.txt | 2 +- Documentation/power/interface.txt | 2 +- Documentation/process/4.Coding.rst | 2 +- Documentation/trace/intel_th.txt| 2 +- Documentation/watchdog/hpwdt.txt| 2 +- Documentation/watchdog/pcwd-watchdog.txt| 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) -- 2.14.2
Re: [PATCH 0/8] Documentation: fix invalid Documentation refs (1)
On Thu, Oct 12, 2017 at 05:24:25PM +, Jonathan Corbet wrote: > On Tue, 10 Oct 2017 12:35:58 -0500 > Tom Saeger wrote: > > > Recently, while reading up on binfmt I attempted to open a document ref > > only to find it was invalid. I did a quick grep, found all the > > binfmt_misc related broken refs and sent a patch. > > > > Fine. Easy. > > > > Then I wondered, "how many broken doc refs are there?". > > > > Turns out with all the recent doc moves, quite a few. > > > > I went about fixing just those found in Documentation/, > > except those in Documentation/translations/ and > > Documentation/devicetree/ for now. > > > > Most of these changes were s/txt/rst/ or fixing up a path to an obvious > > new location. Some required going back to v4.10 v4.4 or some other > > version to sleuth-out what content was actually being referenced and > > then fixing the reference to point to the new file with that content. > > > > This is batch 1. > > I've applied the set to the docs tree, thanks. > > jon Thanks Jon. I'll send another batch soon. --Tom
[PATCH 3/8] Documentation: fix input related doc refs
Make `input` document refs valid including: - joystick - joystick-parport Signed-off-by: Tom Saeger --- Documentation/admin-guide/kernel-parameters.txt | 10 +- Documentation/hid/hiddev.txt| 2 +- Documentation/input/devices/xpad.rst| 3 ++- Documentation/sound/cards/joystick.rst | 2 +- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index e857bbbc8575..411b41127eee 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -314,7 +314,7 @@ amijoy.map= [HW,JOY] Amiga joystick support Map of devices attached to JOY0DAT and JOY1DAT Format: , - See also Documentation/input/joystick.txt + See also Documentation/input/joydev/joystick.rst analog.map= [HW,JOY] Analog joystick and gamepad support Specifies type or capabilities of an analog joystick @@ -724,7 +724,7 @@ db9.dev[2|3]= [HW,JOY] Multisystem joystick support via parallel port (one device per port) Format: , - See also Documentation/input/joystick-parport.txt + See also Documentation/input/devices/joystick-parport.rst ddebug_query= [KNL,DYNAMIC_DEBUG] Enable debug messages at early boot time. See @@ -1220,7 +1220,7 @@ [HW,JOY] Multisystem joystick and NES/SNES/PSX pad support via parallel port (up to 5 devices per port) Format: , - See also Documentation/input/joystick-parport.txt + See also Documentation/input/devices/joystick-parport.rst gamma= [HW,DRM] @@ -1766,7 +1766,7 @@ ivrs_acpihid[00:14.5]=AMD0020:0 js= [HW,JOY] Analog joystick - See Documentation/input/joystick.txt. + See Documentation/input/joydev/joystick.rst. nokaslr [KNL] When CONFIG_RANDOMIZE_BASE is set, this disables @@ -4199,7 +4199,7 @@ TurboGraFX parallel port interface Format: ,,, - See also Documentation/input/joystick-parport.txt + See also Documentation/input/devices/joystick-parport.rst udbg-immortal [PPC] When debugging early kernel crashes that happen after console_init() and before a proper diff --git a/Documentation/hid/hiddev.txt b/Documentation/hid/hiddev.txt index 6e8c9f1d2f22..638448707aa2 100644 --- a/Documentation/hid/hiddev.txt +++ b/Documentation/hid/hiddev.txt @@ -12,7 +12,7 @@ To support these disparate requirements, the Linux USB system provides HID events to two separate interfaces: * the input subsystem, which converts HID events into normal input device interfaces (such as keyboard, mouse and joystick) and a -normalised event interface - see Documentation/input/input.txt +normalised event interface - see Documentation/input/input.rst * the hiddev interface, which provides fairly raw HID events The data flow for a HID event produced by a device is something like diff --git a/Documentation/input/devices/xpad.rst b/Documentation/input/devices/xpad.rst index 5a709ab77c8d..b8bd65962dd8 100644 --- a/Documentation/input/devices/xpad.rst +++ b/Documentation/input/devices/xpad.rst @@ -230,4 +230,5 @@ Historic Edits 2005-03-19 - Dominic Cerquetti - added stuff for dance pads, new d-pad->axes mappings -Later changes may be viewed with 'git log Documentation/input/xpad.txt' +Later changes may be viewed with +'git log --follow Documentation/input/devices/xpad.rst' diff --git a/Documentation/sound/cards/joystick.rst b/Documentation/sound/cards/joystick.rst index a6e468c81d02..488946fc1079 100644 --- a/Documentation/sound/cards/joystick.rst +++ b/Documentation/sound/cards/joystick.rst @@ -11,7 +11,7 @@ General First of all, you need to enable GAMEPORT support on Linux kernel for using a joystick with the ALSA driver. For the details of gameport -support, refer to Documentation/input/joystick.txt. +support, refer to Documentation/input/joydev/joystick.rst. The joystick support of ALSA drivers is different between ISA and PCI cards. In the case of ISA (PnP) cards, it's usually handled by the -- 2.14.2
[PATCH 6/8] Documentation: fix sound related doc refs
Make sound doc refs valid. Signed-off-by: Tom Saeger --- Documentation/sound/hd-audio/notes.rst| 2 +- Documentation/sound/kernel-api/writing-an-alsa-driver.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/sound/hd-audio/notes.rst b/Documentation/sound/hd-audio/notes.rst index f59c3cdbfaf4..9f7347830ba4 100644 --- a/Documentation/sound/hd-audio/notes.rst +++ b/Documentation/sound/hd-audio/notes.rst @@ -192,7 +192,7 @@ preset model instead of PCI (and codec-) SSID look-up. What ``model`` option values are available depends on the codec chip. Check your codec chip from the codec proc file (see "Codec Proc-File" section below). It will show the vendor/product name of your codec -chip. Then, see Documentation/sound/HD-Audio-Models.rst file, +chip. Then, see Documentation/sound/hd-audio/models.rst file, the section of HD-audio driver. You can find a list of codecs and ``model`` options belonging to each codec. For example, for Realtek ALC262 codec chip, pass ``model=ultra`` for devices that are compatible diff --git a/Documentation/sound/kernel-api/writing-an-alsa-driver.rst b/Documentation/sound/kernel-api/writing-an-alsa-driver.rst index 58ffa3f5bda7..a0b268466cb1 100644 --- a/Documentation/sound/kernel-api/writing-an-alsa-driver.rst +++ b/Documentation/sound/kernel-api/writing-an-alsa-driver.rst @@ -2498,7 +2498,7 @@ Mic boost Mic-boost switch is set as “Mic Boost” or “Mic Boost (6dB)”. More precise information can be found in -``Documentation/sound/alsa/ControlNames.txt``. +``Documentation/sound/designs/control-names.rst``. Access Flags -- 2.14.2
[PATCH 8/8] Documentation: fix networking related doc refs.
Signed-off-by: Tom Saeger --- Documentation/networking/checksum-offloads.txt | 2 +- Documentation/networking/packet_mmap.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/checksum-offloads.txt b/Documentation/networking/checksum-offloads.txt index d52d191bbb0c..27bc09cfcf6d 100644 --- a/Documentation/networking/checksum-offloads.txt +++ b/Documentation/networking/checksum-offloads.txt @@ -47,7 +47,7 @@ The requirements for GSO are more complicated, because when segmenting an (section 'E') for more details. A driver declares its offload capabilities in netdev->hw_features; see - Documentation/networking/netdev-features for more. Note that a device + Documentation/networking/netdev-features.txt for more. Note that a device which only advertises NETIF_F_IP[V6]_CSUM must still obey the csum_start and csum_offset given in the SKB; if it tries to deduce these itself in hardware (as some NICs do) the driver should check that the values in the diff --git a/Documentation/networking/packet_mmap.txt b/Documentation/networking/packet_mmap.txt index f3b9e507ab05..bf654845556e 100644 --- a/Documentation/networking/packet_mmap.txt +++ b/Documentation/networking/packet_mmap.txt @@ -1055,7 +1055,7 @@ TX_RING part only TP_STATUS_AVAILABLE is set, then the tp_sec and tp_{n,u}sec members do not contain a valid value. For TX_RINGs, by default no timestamp is generated! -See include/linux/net_tstamp.h and Documentation/networking/timestamping +See include/linux/net_tstamp.h and Documentation/networking/timestamping.txt for more information on hardware timestamps. --- -- 2.14.2
[PATCH 7/8] Documentation: fix usb related doc refs
Update ref to usb proc_usb_info.txt. Signed-off-by: Tom Saeger --- Documentation/driver-api/usb/usb.rst | 4 +--- Documentation/networking/cdc_mbim.txt | 4 ++-- Documentation/usb/gadget-testing.txt | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/Documentation/driver-api/usb/usb.rst b/Documentation/driver-api/usb/usb.rst index dba0f876b36f..078e981e2b16 100644 --- a/Documentation/driver-api/usb/usb.rst +++ b/Documentation/driver-api/usb/usb.rst @@ -690,9 +690,7 @@ The USB devices are now exported via debugfs: This file is handy for status viewing tools in user mode, which can scan the text format and ignore most of it. More detailed device status (including class and vendor status) is available from device-specific -files. For information about the current format of this file, see the -``Documentation/usb/proc_usb_info.txt`` file in your Linux kernel -sources. +files. For information about the current format of this file, see below. This file, in combination with the poll() system call, can also be used to detect when devices are added or removed:: diff --git a/Documentation/networking/cdc_mbim.txt b/Documentation/networking/cdc_mbim.txt index e4c376abbdad..4e68f0bc5dba 100644 --- a/Documentation/networking/cdc_mbim.txt +++ b/Documentation/networking/cdc_mbim.txt @@ -332,8 +332,8 @@ References [5] "MBIM (Mobile Broadband Interface Model) Registry" - http://compliance.usb.org/mbim/ -[6] "/dev/bus/usb filesystem output" - - Documentation/usb/proc_usb_info.txt +[6] "/sys/kernel/debug/usb/devices output format" + - Documentation/driver-api/usb/usb.rst [7] "/sys/bus/usb/devices/.../descriptors" - Documentation/ABI/stable/sysfs-bus-usb diff --git a/Documentation/usb/gadget-testing.txt b/Documentation/usb/gadget-testing.txt index fbc397d17e98..441a4b9b666f 100644 --- a/Documentation/usb/gadget-testing.txt +++ b/Documentation/usb/gadget-testing.txt @@ -773,7 +773,7 @@ host: # cat /dev/usb/lp0 More advanced testing can be done with the prn_example -described in Documentation/usb/gadget-printer.txt. +described in Documentation/usb/gadget_printer.txt. 20. UAC1 function (virtual ALSA card, using u_audio API) -- 2.14.2
[PATCH 5/8] Documentation: fix media related doc refs
Make media doc refs valid. Signed-off-by: Tom Saeger --- Documentation/admin-guide/kernel-parameters.txt| 4 ++-- Documentation/media/dvb-drivers/bt8xx.rst | 8 Documentation/media/uapi/v4l/dev-sliced-vbi.rst| 2 +- Documentation/media/uapi/v4l/extended-controls.rst | 2 +- Documentation/media/uapi/v4l/pixfmt-reserved.rst | 2 +- Documentation/media/v4l-drivers/max2175.rst| 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 411b41127eee..cbfae6b1c644 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -439,7 +439,7 @@ bttv.card= [HW,V4L] bttv (bt848 + bt878 based grabber cards) bttv.radio= Most important insmod options are available as kernel args too. - bttv.pll= See Documentation/video4linux/bttv/Insmod-options + bttv.pll= See Documentation/media/v4l-drivers/bttv.rst bttv.tuner= bulk_remove=off [PPC] This parameter disables the use of the pSeries @@ -2251,7 +2251,7 @@ See Documentation/admin-guide/pm/sleep-states.rst. meye.*= [HW] Set MotionEye Camera parameters - See Documentation/video4linux/meye.txt. + See Documentation/media/v4l-drivers/meye.rst. mfgpt_irq= [IA-32] Specify the IRQ to use for the Multi-Function General Purpose Timers on AMD Geode diff --git a/Documentation/media/dvb-drivers/bt8xx.rst b/Documentation/media/dvb-drivers/bt8xx.rst index b43958b7340c..e3e387bdf498 100644 --- a/Documentation/media/dvb-drivers/bt8xx.rst +++ b/Documentation/media/dvb-drivers/bt8xx.rst @@ -18,7 +18,7 @@ General information This class of cards has a bt878a as the PCI interface, and require the bttv driver for accessing the i2c bus and the gpio pins of the bt8xx chipset. -Please see Documentation/dvb/cards.txt => o Cards based on the Conexant Bt8xx PCI bridge: +Please see Documentation/media/dvb-drivers/cards.rst => o Cards based on the Conexant Bt8xx PCI bridge: Compiling kernel please enable: @@ -45,7 +45,7 @@ Loading Modules Regular case: If the bttv driver detects a bt8xx-based DVB card, all frontend and backend modules will be loaded automatically. Exceptions are: - Old TwinHan DST cards or clones with or without CA slot and not containing an Eeprom. -People running udev please see Documentation/dvb/udev.txt. +People running udev please see Documentation/media/dvb-drivers/udev.rst. In the following cases overriding the PCI type detection for dvb-bt8xx might be necessary: @@ -72,7 +72,7 @@ Useful parameters for verbosity level and debugging the dst module: The autodetected values are determined by the cards' "response string". In your logs see f. ex.: dst_get_device_id: Recognize [DSTMCI]. For bug reports please send in a complete log with verbose=4 activated. -Please also see Documentation/dvb/ci.txt. +Please also see Documentation/media/dvb-drivers/ci.rst. Running multiple cards ~~ @@ -100,7 +100,7 @@ Examples of card ID's: $ modprobe bttv card=113 card=135 -For a full list of card ID's please see Documentation/video4linux/CARDLIST.bttv. +For a full list of card ID's please see Documentation/media/v4l-drivers/bttv-cardlist.rst. In case of further problems please subscribe and send questions to the mailing list: linux-...@linuxtv.org. Probing the cards with broken PCI subsystem ID diff --git a/Documentation/media/uapi/v4l/dev-sliced-vbi.rst b/Documentation/media/uapi/v4l/dev-sliced-vbi.rst index 9d6c860271cb..d311a6866b3b 100644 --- a/Documentation/media/uapi/v4l/dev-sliced-vbi.rst +++ b/Documentation/media/uapi/v4l/dev-sliced-vbi.rst @@ -431,7 +431,7 @@ MPEG stream. *Historical context*: This format specification originates from a custom, embedded, sliced VBI data format used by the ``ivtv`` driver. This format has already been informally specified in the kernel sources -in the file ``Documentation/video4linux/cx2341x/README.vbi`` . The +in the file ``Documentation/media/v4l-drivers/cx2341x.rst`` . The maximum size of the payload and other aspects of this format are driven by the CX23415 MPEG decoder's capabilities and limitations with respect to extracting, decoding, and displaying sliced VBI data embedded within diff --git a/Documentation/media/uapi/v4l/extended-controls.rst b/Documentation/media/uapi/v4l/extended-controls.rst index a3e81c1d276b..dfe49ae57e78 100644 --- a/Documentation/media/uapi/v4l/extended-controls.rst +++ b/Documentation/media/uapi/v4l/extended-controls.rst @@ -284,7 +284,7 @@ enum v4l2_mpeg_stream_vbi_fmt - * - ``V4L2_MPEG_STREAM_VBI_FMT_IVTV`` - VBI in private packets, IVTV format (documented
[PATCH 1/8] Documentation: fix driver-api doc refs
Make driver-api document refs valid. Signed-off-by: Tom Saeger --- Documentation/power/pci.txt | 10 +- Documentation/power/runtime_pm.txt | 2 +- Documentation/process/submitting-drivers.rst | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Documentation/power/pci.txt b/Documentation/power/pci.txt index a1b7f7158930..d17fdf8f45ef 100644 --- a/Documentation/power/pci.txt +++ b/Documentation/power/pci.txt @@ -8,7 +8,7 @@ management. Based on previous work by Patrick Mochel This document only covers the aspects of power management specific to PCI devices. For general description of the kernel's interfaces related to device -power management refer to Documentation/power/admin-guide/devices.rst and +power management refer to Documentation/driver-api/pm/devices.rst and Documentation/power/runtime_pm.txt. --- @@ -417,7 +417,7 @@ pm->runtime_idle() callback. 2.4. System-Wide Power Transitions -- There are a few different types of system-wide power transitions, described in -Documentation/power/admin-guide/devices.rst. Each of them requires devices to be handled +Documentation/driver-api/pm/devices.rst. Each of them requires devices to be handled in a specific way and the PM core executes subsystem-level power management callbacks for this purpose. They are executed in phases such that each phase involves executing the same subsystem-level callback for every device belonging @@ -623,7 +623,7 @@ System restore requires a hibernation image to be loaded into memory and the pre-hibernation memory contents to be restored before the pre-hibernation system activity can be resumed. -As described in Documentation/power/admin-guide/devices.rst, the hibernation image is loaded +As described in Documentation/driver-api/pm/devices.rst, the hibernation image is loaded into memory by a fresh instance of the kernel, called the boot kernel, which in turn is loaded and run by a boot loader in the usual way. After the boot kernel has loaded the image, it needs to replace its own code and data with the code @@ -677,7 +677,7 @@ controlling the runtime power management of their devices. At the time of this writing there are two ways to define power management callbacks for a PCI device driver, the recommended one, based on using a -dev_pm_ops structure described in Documentation/power/admin-guide/devices.rst, and the +dev_pm_ops structure described in Documentation/driver-api/pm/devices.rst, and the "legacy" one, in which the .suspend(), .suspend_late(), .resume_early(), and .resume() callbacks from struct pci_driver are used. The legacy approach, however, doesn't allow one to define runtime power management callbacks and is @@ -1046,5 +1046,5 @@ PCI Local Bus Specification, Rev. 3.0 PCI Bus Power Management Interface Specification, Rev. 1.2 Advanced Configuration and Power Interface (ACPI) Specification, Rev. 3.0b PCI Express Base Specification, Rev. 2.0 -Documentation/power/admin-guide/devices.rst +Documentation/driver-api/pm/devices.rst Documentation/power/runtime_pm.txt diff --git a/Documentation/power/runtime_pm.txt b/Documentation/power/runtime_pm.txt index 625549d4c74a..57af2f7963ee 100644 --- a/Documentation/power/runtime_pm.txt +++ b/Documentation/power/runtime_pm.txt @@ -680,7 +680,7 @@ left in runtime suspend. If that happens, the PM core will not execute any system suspend and resume callbacks for all of those devices, except for the complete callback, which is then entirely responsible for handling the device as appropriate. This only applies to system suspend transitions that are not -related to hibernation (see Documentation/power/admin-guide/devices.rst for more +related to hibernation (see Documentation/driver-api/pm/devices.rst for more information). The PM core does its best to reduce the probability of race conditions between diff --git a/Documentation/process/submitting-drivers.rst b/Documentation/process/submitting-drivers.rst index afb82ee0cbea..b38bf2054ce3 100644 --- a/Documentation/process/submitting-drivers.rst +++ b/Documentation/process/submitting-drivers.rst @@ -117,7 +117,7 @@ PM support: anything. For the driver testing instructions see Documentation/power/drivers-testing.txt and for a relatively complete overview of the power management issues related to - drivers see Documentation/power/admin-guide/devices.rst . + drivers see Documentation/driver-api/pm/devices.rst. Control: In general if there is active maintenance of a driver by -- 2.14.2
[PATCH 4/8] Documentation: fix security related doc refs
Make security document refs valid. Signed-off-by: Tom Saeger --- Documentation/ABI/testing/evm | 4 ++-- Documentation/security/LSM.rst | 2 +- Documentation/security/credentials.rst | 2 +- Documentation/security/keys/request-key.rst | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/ABI/testing/evm b/Documentation/ABI/testing/evm index 8374d4557e5d..ca622c9aa24c 100644 --- a/Documentation/ABI/testing/evm +++ b/Documentation/ABI/testing/evm @@ -18,6 +18,6 @@ Description: in the initramfs, which has already been measured as part of the trusted boot. For more information on creating and loading existing trusted/encrypted keys, refer to: - Documentation/keys-trusted-encrypted.txt. (A sample dracut - patch, which loads the trusted/encrypted key and enables + Documentation/security/keys/trusted-encrypted.rst. (A sample + dracut patch, which loads the trusted/encrypted key and enables EVM, is available from http://linux-ima.sourceforge.net/#EVM.) diff --git a/Documentation/security/LSM.rst b/Documentation/security/LSM.rst index d75778b0fa10..98522e0e1ee2 100644 --- a/Documentation/security/LSM.rst +++ b/Documentation/security/LSM.rst @@ -5,7 +5,7 @@ Linux Security Module Development Based on https://lkml.org/lkml/2007/10/26/215, a new LSM is accepted into the kernel when its intent (a description of what it tries to protect against and in what cases one would expect to -use it) has been appropriately documented in ``Documentation/security/LSM``. +use it) has been appropriately documented in ``Documentation/security/LSM.rst``. This allows an LSM's code to be easily compared to its goals, and so that end users and distros can make a more informed decision about which LSMs suit their requirements. diff --git a/Documentation/security/credentials.rst b/Documentation/security/credentials.rst index 038a7e19eff9..66a2e24939d8 100644 --- a/Documentation/security/credentials.rst +++ b/Documentation/security/credentials.rst @@ -196,7 +196,7 @@ The Linux kernel supports the following types of credentials: When a process accesses a key, if not already present, it will normally be cached on one of these keyrings for future accesses to find. - For more information on using keys, see Documentation/security/keys.txt. + For more information on using keys, see ``Documentation/security/keys/*``. 5. LSM diff --git a/Documentation/security/keys/request-key.rst b/Documentation/security/keys/request-key.rst index b2d16abaa9e9..21e27238cec6 100644 --- a/Documentation/security/keys/request-key.rst +++ b/Documentation/security/keys/request-key.rst @@ -3,7 +3,7 @@ Key Request Service === The key request service is part of the key retention service (refer to -Documentation/security/core.rst). This document explains more fully how +Documentation/security/keys/core.rst). This document explains more fully how the requesting algorithm works. The process starts by either the kernel requesting a service by calling -- 2.14.2
[PATCH 0/8] Documentation: fix invalid Documentation refs (1)
Recently, while reading up on binfmt I attempted to open a document ref only to find it was invalid. I did a quick grep, found all the binfmt_misc related broken refs and sent a patch. Fine. Easy. Then I wondered, "how many broken doc refs are there?". Turns out with all the recent doc moves, quite a few. I went about fixing just those found in Documentation/, except those in Documentation/translations/ and Documentation/devicetree/ for now. Most of these changes were s/txt/rst/ or fixing up a path to an obvious new location. Some required going back to v4.10 v4.4 or some other version to sleuth-out what content was actually being referenced and then fixing the reference to point to the new file with that content. This is batch 1. Tom Saeger (8): Documentation: fix driver-api doc refs Documentation: fix admin-guide doc refs Documentation: fix input related doc refs Documentation: fix security related doc refs Documentation: fix media related doc refs Documentation: fix sound related doc refs Documentation: fix usb related doc refs Documentation: fix networking related doc refs. Documentation/ABI/stable/sysfs-devices | 2 +- Documentation/ABI/testing/evm | 4 ++-- Documentation/ABI/testing/sysfs-devices-system-cpu | 6 -- Documentation/ABI/testing/sysfs-power | 6 -- Documentation/admin-guide/README.rst | 2 +- Documentation/admin-guide/kernel-parameters.txt| 18 +- Documentation/admin-guide/reporting-bugs.rst | 4 ++-- Documentation/driver-api/usb/usb.rst | 4 +--- Documentation/hid/hiddev.txt | 2 +- Documentation/input/devices/xpad.rst | 3 ++- Documentation/laptops/laptop-mode.txt | 6 +++--- Documentation/media/dvb-drivers/bt8xx.rst | 8 Documentation/media/uapi/v4l/dev-sliced-vbi.rst| 2 +- Documentation/media/uapi/v4l/extended-controls.rst | 2 +- Documentation/media/uapi/v4l/pixfmt-reserved.rst | 2 +- Documentation/media/v4l-drivers/bttv.rst | 2 +- Documentation/media/v4l-drivers/max2175.rst| 2 +- Documentation/networking/cdc_mbim.txt | 4 ++-- Documentation/networking/checksum-offloads.txt | 2 +- Documentation/networking/packet_mmap.txt | 2 +- Documentation/power/interface.txt | 3 ++- Documentation/power/pci.txt| 10 +- Documentation/power/runtime_pm.txt | 2 +- Documentation/process/submitting-drivers.rst | 2 +- Documentation/security/LSM.rst | 2 +- Documentation/security/credentials.rst | 2 +- Documentation/security/keys/request-key.rst| 2 +- Documentation/sound/cards/joystick.rst | 2 +- Documentation/sound/hd-audio/notes.rst | 2 +- .../sound/kernel-api/writing-an-alsa-driver.rst| 2 +- Documentation/usb/gadget-testing.txt | 2 +- 31 files changed, 59 insertions(+), 55 deletions(-) -- 2.14.2
[PATCH 2/8] Documentation: fix admin-guide doc refs
Make admin-guide document refs valid. Signed-off-by: Tom Saeger --- Documentation/ABI/stable/sysfs-devices | 2 +- Documentation/ABI/testing/sysfs-devices-system-cpu | 6 -- Documentation/ABI/testing/sysfs-power | 6 -- Documentation/admin-guide/README.rst | 2 +- Documentation/admin-guide/kernel-parameters.txt| 4 ++-- Documentation/admin-guide/reporting-bugs.rst | 4 ++-- Documentation/laptops/laptop-mode.txt | 6 +++--- Documentation/media/v4l-drivers/bttv.rst | 2 +- Documentation/power/interface.txt | 3 ++- 9 files changed, 20 insertions(+), 15 deletions(-) diff --git a/Documentation/ABI/stable/sysfs-devices b/Documentation/ABI/stable/sysfs-devices index 35c457f8ce73..4404bd9b96c1 100644 --- a/Documentation/ABI/stable/sysfs-devices +++ b/Documentation/ABI/stable/sysfs-devices @@ -1,5 +1,5 @@ # Note: This documents additional properties of any device beyond what -# is documented in Documentation/sysfs-rules.txt +# is documented in Documentation/admin-guide/sysfs-rules.rst What: /sys/devices/*/of_node Date: February 2015 diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu index f3d5817c4ef0..d6d862db3b5d 100644 --- a/Documentation/ABI/testing/sysfs-devices-system-cpu +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu @@ -187,7 +187,8 @@ Description:Processor frequency boosting control This switch controls the boost setting for the whole system. Boosting allows the CPU and the firmware to run at a frequency beyound it's nominal limit. - More details can be found in Documentation/cpu-freq/boost.txt + More details can be found in + Documentation/admin-guide/pm/cpufreq.rst What: /sys/devices/system/cpu/cpu#/crash_notes @@ -223,7 +224,8 @@ Description:Parameters for the Intel P-state driver no_turbo: limits the driver to selecting P states below the turbo frequency range. - More details can be found in Documentation/cpu-freq/intel-pstate.txt + More details can be found in + Documentation/admin-guide/pm/intel_pstate.rst What: /sys/devices/system/cpu/cpu*/cache/index*/ Date: July 2014(documented, existed before August 2008) diff --git a/Documentation/ABI/testing/sysfs-power b/Documentation/ABI/testing/sysfs-power index a1d1612f3651..1e0d1dac706b 100644 --- a/Documentation/ABI/testing/sysfs-power +++ b/Documentation/ABI/testing/sysfs-power @@ -18,7 +18,8 @@ Description: Writing one of the above strings to this file causes the system to transition into the corresponding state, if available. - See Documentation/power/states.txt for more information. + See Documentation/admin-guide/pm/sleep-states.rst for more + information. What: /sys/power/mem_sleep Date: November 2016 @@ -35,7 +36,8 @@ Description: represented by it to be used on subsequent attempts to suspend the system. - See Documentation/power/states.txt for more information. + See Documentation/admin-guide/pm/sleep-states.rst for more + information. What: /sys/power/disk Date: September 2006 diff --git a/Documentation/admin-guide/README.rst b/Documentation/admin-guide/README.rst index b5343c5aa224..63066db39910 100644 --- a/Documentation/admin-guide/README.rst +++ b/Documentation/admin-guide/README.rst @@ -350,7 +350,7 @@ If something goes wrong help debugging the problem. The text above the dump is also important: it tells something about why the kernel dumped code (in the above example, it's due to a bad kernel pointer). More information - on making sense of the dump is in Documentation/admin-guide/oops-tracing.rst + on making sense of the dump is in Documentation/admin-guide/bug-hunting.rst - If you compiled the kernel with CONFIG_KALLSYMS you can send the dump as is, otherwise you will have to use the ``ksymoops`` program to make diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 05496622b4ef..e857bbbc8575 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -2248,7 +2248,7 @@ s2idle - Suspend-To-Idle shallow - Power-On Suspend or equivalent (if supported) deep- Suspend-To-RAM or equivalent (if supported) - See Documentation/power/states.txt. + See Documentation/admin-guide/pm/sleep-states.rst. meye.*= [HW] Set MotionEye Camera
Re: [PATCH v3 1/2] docs: Update binfmt_misc links
On Tue, Oct 03, 2017 at 09:23:59PM +, Jonathan Corbet wrote: > On Tue, 3 Oct 2017 16:16:37 -0500 > Tom Saeger wrote: > > > Documentation/binfmt_misc.txt moved to > > Documentation/admin-guide/binfmt-misc.rst > > > > Signed-off-by: Tom Saeger > > --- > > Documentation/sysctl/README | 2 +- > > Documentation/sysctl/fs.txt | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/sysctl/README b/Documentation/sysctl/README > > index 91f54ffa0077..d5f24ab0ecc3 100644 > > --- a/Documentation/sysctl/README > > +++ b/Documentation/sysctl/README > > @@ -60,7 +60,7 @@ debug/ > > dev/ device specific information (eg dev/cdrom/info) > > fs/specific filesystems > > filehandle, inode, dentry and quota tuning > > - binfmt_misc > > + binfmt_misc > > I've applied this one, thanks. > > jon Thanks!
[PATCH v3 2/2] fs: Update binfmt_misc links
Documentation/binfmt_misc.txt was moved to Documentation/admin-guide/binfmt-misc.rst Signed-off-by: Tom Saeger --- fs/Kconfig.binfmt | 2 +- fs/binfmt_misc.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt index b2f82cf6bf86..cb35347e8216 100644 --- a/fs/Kconfig.binfmt +++ b/fs/Kconfig.binfmt @@ -169,7 +169,7 @@ config BINFMT_MISC will automatically feed it to the correct interpreter. You can do other nice things, too. Read the file - to learn how to use this + to learn how to use this feature, for information about how to include Java support. and for information about how to include Mono-based .NET support. diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c index ce7181ea60fa..b5f1ae5d3217 100644 --- a/fs/binfmt_misc.c +++ b/fs/binfmt_misc.c @@ -4,7 +4,8 @@ * Copyright (C) 1997 Richard Günther * * binfmt_misc detects binaries via a magic or filename extension and invokes - * a specified wrapper. See Documentation/binfmt_misc.txt for more details. + * a specified wrapper. See Documentation/admin-guide/binfmt-misc.rst for more + * details. */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt -- 2.14.1
[PATCH v3 1/2] docs: Update binfmt_misc links
Documentation/binfmt_misc.txt moved to Documentation/admin-guide/binfmt-misc.rst Signed-off-by: Tom Saeger --- Documentation/sysctl/README | 2 +- Documentation/sysctl/fs.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/sysctl/README b/Documentation/sysctl/README index 91f54ffa0077..d5f24ab0ecc3 100644 --- a/Documentation/sysctl/README +++ b/Documentation/sysctl/README @@ -60,7 +60,7 @@ debug/ dev/ device specific information (eg dev/cdrom/info) fs/specific filesystems filehandle, inode, dentry and quota tuning - binfmt_misc + binfmt_misc kernel/global kernel info / tuning miscellaneous stuff net/ networking stuff, for documentation look in: diff --git a/Documentation/sysctl/fs.txt b/Documentation/sysctl/fs.txt index 35e17f748ca7..6c00c1e2743f 100644 --- a/Documentation/sysctl/fs.txt +++ b/Documentation/sysctl/fs.txt @@ -277,7 +277,7 @@ in a mount namespace. -- Documentation for the files in /proc/sys/fs/binfmt_misc is -in Documentation/binfmt_misc.txt. +in Documentation/admin-guide/binfmt-misc.rst. 3. /proc/sys/fs/mqueue - POSIX message queues filesystem -- 2.14.1
[PATCH v3 0/2] docs: Update binfmt_misc links
v3: - Split into `docs` and `fs` patch as suggested by Jonathan Corbet -- Tom Saeger (2): docs: Update binfmt_misc links fs: Update binfmt_misc links Documentation/sysctl/README | 2 +- Documentation/sysctl/fs.txt | 2 +- fs/Kconfig.binfmt | 2 +- fs/binfmt_misc.c| 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) -- 2.14.1
[PATCH v2 0/1] docs: Update binfmt_misc links
v2: - replaced wrong binfmt_misc.rst with binfmt-misc.rst Tom Saeger (1): docs: Update binfmt_misc links Documentation/sysctl/README | 2 +- Documentation/sysctl/fs.txt | 2 +- fs/Kconfig.binfmt | 2 +- fs/binfmt_misc.c| 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) -- 2.14.1
[PATCH v2 1/1] docs: Update binfmt_misc links
Documentation/binfmt_misc.txt was moved to Documentation/admin-guide/binfmt_misc.rst Signed-off-by: Tom Saeger --- Documentation/sysctl/README | 2 +- Documentation/sysctl/fs.txt | 2 +- fs/Kconfig.binfmt | 2 +- fs/binfmt_misc.c| 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Documentation/sysctl/README b/Documentation/sysctl/README index 91f54ffa0077..d5f24ab0ecc3 100644 --- a/Documentation/sysctl/README +++ b/Documentation/sysctl/README @@ -60,7 +60,7 @@ debug/ dev/ device specific information (eg dev/cdrom/info) fs/specific filesystems filehandle, inode, dentry and quota tuning - binfmt_misc + binfmt_misc kernel/global kernel info / tuning miscellaneous stuff net/ networking stuff, for documentation look in: diff --git a/Documentation/sysctl/fs.txt b/Documentation/sysctl/fs.txt index 35e17f748ca7..6c00c1e2743f 100644 --- a/Documentation/sysctl/fs.txt +++ b/Documentation/sysctl/fs.txt @@ -277,7 +277,7 @@ in a mount namespace. -- Documentation for the files in /proc/sys/fs/binfmt_misc is -in Documentation/binfmt_misc.txt. +in Documentation/admin-guide/binfmt-misc.rst. 3. /proc/sys/fs/mqueue - POSIX message queues filesystem diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt index b2f82cf6bf86..cb35347e8216 100644 --- a/fs/Kconfig.binfmt +++ b/fs/Kconfig.binfmt @@ -169,7 +169,7 @@ config BINFMT_MISC will automatically feed it to the correct interpreter. You can do other nice things, too. Read the file - to learn how to use this + to learn how to use this feature, for information about how to include Java support. and for information about how to include Mono-based .NET support. diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c index ce7181ea60fa..b5f1ae5d3217 100644 --- a/fs/binfmt_misc.c +++ b/fs/binfmt_misc.c @@ -4,7 +4,8 @@ * Copyright (C) 1997 Richard Günther * * binfmt_misc detects binaries via a magic or filename extension and invokes - * a specified wrapper. See Documentation/binfmt_misc.txt for more details. + * a specified wrapper. See Documentation/admin-guide/binfmt-misc.rst for more + * details. */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt -- 2.14.1
[PATCH 1/1] docs: Update binfmt_misc links
Documentation/binfmt_misc.txt was moved to Documentation/admin-guide/binfmt_misc.rst Signed-off-by: Tom Saeger --- Documentation/sysctl/README | 2 +- Documentation/sysctl/fs.txt | 2 +- fs/Kconfig.binfmt | 2 +- fs/binfmt_misc.c| 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Documentation/sysctl/README b/Documentation/sysctl/README index 91f54ffa0077..d5f24ab0ecc3 100644 --- a/Documentation/sysctl/README +++ b/Documentation/sysctl/README @@ -60,7 +60,7 @@ debug/ dev/ device specific information (eg dev/cdrom/info) fs/specific filesystems filehandle, inode, dentry and quota tuning - binfmt_misc + binfmt_misc kernel/global kernel info / tuning miscellaneous stuff net/ networking stuff, for documentation look in: diff --git a/Documentation/sysctl/fs.txt b/Documentation/sysctl/fs.txt index 35e17f748ca7..6c00c1e2743f 100644 --- a/Documentation/sysctl/fs.txt +++ b/Documentation/sysctl/fs.txt @@ -277,7 +277,7 @@ in a mount namespace. -- Documentation for the files in /proc/sys/fs/binfmt_misc is -in Documentation/binfmt_misc.txt. +in Documentation/admin-guide/binfmt-misc.rst. 3. /proc/sys/fs/mqueue - POSIX message queues filesystem diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt index b2f82cf6bf86..27dfcb078fa8 100644 --- a/fs/Kconfig.binfmt +++ b/fs/Kconfig.binfmt @@ -169,7 +169,7 @@ config BINFMT_MISC will automatically feed it to the correct interpreter. You can do other nice things, too. Read the file - to learn how to use this + to learn how to use this feature, for information about how to include Java support. and for information about how to include Mono-based .NET support. diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c index ce7181ea60fa..b5f1ae5d3217 100644 --- a/fs/binfmt_misc.c +++ b/fs/binfmt_misc.c @@ -4,7 +4,8 @@ * Copyright (C) 1997 Richard Günther * * binfmt_misc detects binaries via a magic or filename extension and invokes - * a specified wrapper. See Documentation/binfmt_misc.txt for more details. + * a specified wrapper. See Documentation/admin-guide/binfmt-misc.rst for more + * details. */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt -- 2.14.1