Re: [-mm patch] include/net/ieee80211.h must #include
Jouni Malinen wrote: Wouldn't the proper fix be to just remove this backwards compatibility code since WIRELESS_EXT is actually 18 in this tree anyway.. Is there valid need to keep this header file compatible with older kernel versions? Nope. Ripping out such back-compat code would be quite acceptable. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [-mm patch] include/net/ieee80211.h must #include
On Wed, Jul 27, 2005 at 09:51:00PM +0200, Adrian Bunk wrote: > gcc found an (although perhaps harmless) bug: > > CC net/ieee80211/ieee80211_crypt.o > In file included from net/ieee80211/ieee80211_crypt.c:21: > include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined > +++ linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h 2005-07-22 > 18:38:10.0 +0200 > +#include > #if WIRELESS_EXT < 17 > #define IW_QUAL_QUAL_INVALID 0x10 Wouldn't the proper fix be to just remove this backwards compatibility code since WIRELESS_EXT is actually 18 in this tree anyway.. Is there valid need to keep this header file compatible with older kernel versions? -- Jouni MalinenPGP id EFC895FA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] include/net/ieee80211.h must #include
gcc found an (although perhaps harmless) bug: <-- snip --> ... CC net/ieee80211/ieee80211_crypt.o In file included from net/ieee80211/ieee80211_crypt.c:21: include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined CC net/ieee80211/ieee80211_crypt_wep.o In file included from net/ieee80211/ieee80211_crypt_wep.c:20: include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined CC net/ieee80211/ieee80211_crypt_ccmp.o CC net/ieee80211/ieee80211_crypt_tkip.o In file included from net/ieee80211/ieee80211_crypt_tkip.c:23: include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 22 Jul 2005 --- linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h.old 2005-07-22 18:37:57.0 +0200 +++ linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h 2005-07-22 18:38:10.0 +0200 @@ -22,6 +22,7 @@ #define IEEE80211_H #include /* ETH_ALEN */ #include/* ARRAY_SIZE */ +#include #if WIRELESS_EXT < 17 #define IW_QUAL_QUAL_INVALID 0x10 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[-mm patch] include/net/ieee80211.h must #include
-Wundef found an (although perhaps harmless) bug: <-- snip --> ... CC net/ieee80211/ieee80211_crypt.o In file included from net/ieee80211/ieee80211_crypt.c:21: include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined CC net/ieee80211/ieee80211_crypt_wep.o In file included from net/ieee80211/ieee80211_crypt_wep.c:20: include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined CC net/ieee80211/ieee80211_crypt_ccmp.o CC net/ieee80211/ieee80211_crypt_tkip.o In file included from net/ieee80211/ieee80211_crypt_tkip.c:23: include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h.old 2005-07-22 18:37:57.0 +0200 +++ linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h 2005-07-22 18:38:10.0 +0200 @@ -22,6 +22,7 @@ #define IEEE80211_H #include /* ETH_ALEN */ #include/* ARRAY_SIZE */ +#include #if WIRELESS_EXT < 17 #define IW_QUAL_QUAL_INVALID 0x10 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
