Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[Jason Gunthorpe]

On Sat, Jan 27, 2018 at 09:15:09PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sat, 27 Jan 2018 21:10:12 +0100
> 
> Two update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (2):
>   Delete two error messages for a failed memory allocation
>   Use common error handling code

Applied to for-next with Jonathan and Devesh's ack, thanks all

Jason

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[Jason Gunthorpe]

On Sat, Jan 27, 2018 at 09:15:09PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sat, 27 Jan 2018 21:10:12 +0100
> 
> Two update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (2):
>   Delete two error messages for a failed memory allocation
>   Use common error handling code

Applied to for-next with Jonathan and Devesh's ack, thanks all

Jason

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[Jonathan Toppins]

On 01/27/2018 03:15 PM, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sat, 27 Jan 2018 21:10:12 +0100
> 
> Two update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (2):
>   Delete two error messages for a failed memory allocation
>   Use common error handling code
> 
>  drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++---
>  1 file changed, 7 insertions(+), 11 deletions(-)
> 

I like it.

Acked-by: Jonathan Toppins 

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[Jonathan Toppins]

On 01/27/2018 03:15 PM, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sat, 27 Jan 2018 21:10:12 +0100
> 
> Two update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (2):
>   Delete two error messages for a failed memory allocation
>   Use common error handling code
> 
>  drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++---
>  1 file changed, 7 insertions(+), 11 deletions(-)
> 

I like it.

Acked-by: Jonathan Toppins 

Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[Devesh Sharma]

On Mon, Jan 29, 2018 at 3:01 PM, SF Markus Elfring
 wrote:
>> You don't need 2 patches when changing same lines of code.
>
> Are these really the same?
>
>
>> Could you squash both and send your changes in a single patch.
>
> I prefer to keep the deletion of questionable error messages separate
> from the refactoring for a bit of exception handling.
>

Okay fair enough
Series Acked-By: Devesh Sharma 

>
>> The patches look good to me otherwise.
>
> Thanks for your constructive feedback.
>
> Regards,
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[Devesh Sharma]

On Mon, Jan 29, 2018 at 3:01 PM, SF Markus Elfring
 wrote:
>> You don't need 2 patches when changing same lines of code.
>
> Are these really the same?
>
>
>> Could you squash both and send your changes in a single patch.
>
> I prefer to keep the deletion of questionable error messages separate
> from the refactoring for a bit of exception handling.
>

Okay fair enough
Series Acked-By: Devesh Sharma 

>
>> The patches look good to me otherwise.
>
> Thanks for your constructive feedback.
>
> Regards,
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[SF Markus Elfring]

> You don't need 2 patches when changing same lines of code.

Are these really the same?


> Could you squash both and send your changes in a single patch.

I prefer to keep the deletion of questionable error messages separate
from the refactoring for a bit of exception handling.


> The patches look good to me otherwise.

Thanks for your constructive feedback.

Regards,
Markus

Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[SF Markus Elfring]

> You don't need 2 patches when changing same lines of code.

Are these really the same?


> Could you squash both and send your changes in a single patch.

I prefer to keep the deletion of questionable error messages separate
from the refactoring for a bit of exception handling.


> The patches look good to me otherwise.

Thanks for your constructive feedback.

Regards,
Markus

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[Devesh Sharma]

On Sun, Jan 28, 2018 at 1:45 AM, SF Markus Elfring
 wrote:
> From: Markus Elfring 
> Date: Sat, 27 Jan 2018 21:10:12 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.

You don't need 2 patches when changing same lines of code. Could
you squash both and send your changes in a single patch.
The patches look good to me otherwise.
-Thanks

Reviewed-By: Devesh Sharma 

>
> Markus Elfring (2):
>   Delete two error messages for a failed memory allocation
>   Use common error handling code
>
>  drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++---
>  1 file changed, 7 insertions(+), 11 deletions(-)
>
> --
> 2.16.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[Devesh Sharma]

On Sun, Jan 28, 2018 at 1:45 AM, SF Markus Elfring
 wrote:
> From: Markus Elfring 
> Date: Sat, 27 Jan 2018 21:10:12 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.

You don't need 2 patches when changing same lines of code. Could
you squash both and send your changes in a single patch.
The patches look good to me otherwise.
-Thanks

Reviewed-By: Devesh Sharma 

>
> Markus Elfring (2):
>   Delete two error messages for a failed memory allocation
>   Use common error handling code
>
>  drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++---
>  1 file changed, 7 insertions(+), 11 deletions(-)
>
> --
> 2.16.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[SF Markus Elfring]

From: Markus Elfring 
Date: Sat, 27 Jan 2018 21:10:12 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Delete two error messages for a failed memory allocation
  Use common error handling code

 drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++---
 1 file changed, 7 insertions(+), 11 deletions(-)

-- 
2.16.1

[PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

[SF Markus Elfring]

From: Markus Elfring 
Date: Sat, 27 Jan 2018 21:10:12 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Delete two error messages for a failed memory allocation
  Use common error handling code

 drivers/infiniband/hw/bnxt_re/qplib_res.c | 18 +++---
 1 file changed, 7 insertions(+), 11 deletions(-)

-- 
2.16.1