Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
Adrian, Your patch is at my personal TODO list. We had lots of patches for 2.6.13, with some sigificative enhancements. Unfortunatelly, your patch from 19 Apr 2005 was not applied, maybe because you've sent during a period where V4L was Orphaned. We've decided to stop non-bug fixes just some days before your newer attempt (July, 7) to focus on more tests at a stable branch. Until July, 18, V4L are applying only bug fixes. After that, we'll collect more patches at V4L and, maybe at the end of the next week, we'll send the patchsets, including yours (It will be #1 :-) ). Cheers, Mauro. Adrian Bunk wrote: > This patch contains the following possible cleanups: > - make two needlessly global structs static > - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > > This patch was already sent on: > - 9 Jul 2005 > - 19 Apr 2005 > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch was already sent on:
- 9 Jul 2005
- 19 Apr 2005
drivers/media/video/tveeprom.c |6 --
include/media/tveeprom.h |1 -
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19
01:41:24.0 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19
01:41:28.0 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);
int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old
2005-04-19 01:40:39.0 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c2005-04-19
01:41:13.0 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);
+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */
/* --- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;
-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;
static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}
-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = "tveeprom",
.id = I2C_DRIVERID_TVEEPROM,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
This patch was already sent on:
- 9 Jul 2005
- 19 Apr 2005
drivers/media/video/tveeprom.c |6 --
include/media/tveeprom.h |1 -
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19
01:41:24.0 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19
01:41:28.0 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);
int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old
2005-04-19 01:40:39.0 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c2005-04-19
01:41:13.0 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);
+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */
/* --- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;
-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;
static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}
-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = tveeprom,
.id = I2C_DRIVERID_TVEEPROM,
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
Adrian, Your patch is at my personal TODO list. We had lots of patches for 2.6.13, with some sigificative enhancements. Unfortunatelly, your patch from 19 Apr 2005 was not applied, maybe because you've sent during a period where V4L was Orphaned. We've decided to stop non-bug fixes just some days before your newer attempt (July, 7) to focus on more tests at a stable branch. Until July, 18, V4L are applying only bug fixes. After that, we'll collect more patches at V4L and, maybe at the end of the next week, we'll send the patchsets, including yours (It will be #1 :-) ). Cheers, Mauro. Adrian Bunk wrote: This patch contains the following possible cleanups: - make two needlessly global structs static - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch was already sent on: - 9 Jul 2005 - 19 Apr 2005 - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch was already sent on:
- 19 Apr 2005
drivers/media/video/tveeprom.c |6 --
include/media/tveeprom.h |1 -
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19
01:41:24.0 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19
01:41:28.0 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);
int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old
2005-04-19 01:40:39.0 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c2005-04-19
01:41:13.0 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);
+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */
/* --- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;
-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;
static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}
-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = "tveeprom",
.id = I2C_DRIVERID_TVEEPROM,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
This patch was already sent on:
- 19 Apr 2005
drivers/media/video/tveeprom.c |6 --
include/media/tveeprom.h |1 -
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19
01:41:24.0 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19
01:41:28.0 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);
int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old
2005-04-19 01:40:39.0 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c2005-04-19
01:41:13.0 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);
+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */
/* --- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;
-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;
static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}
-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = tveeprom,
.id = I2C_DRIVERID_TVEEPROM,
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
> - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump That's a debug helper function, please don't drop it. #if 0 might be ok, not sure though, the tveeprom module is also used by a out-of-kernel driver (ivtv). Otherwise the patch looks fine to me. Gerd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump That's a debug helper function, please don't drop it. #if 0 might be ok, not sure though, the tveeprom module is also used by a out-of-kernel driver (ivtv). Otherwise the patch looks fine to me. Gerd - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/media/video/tveeprom.c |6 --
include/media/tveeprom.h |1 -
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19
01:41:24.0 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19
01:41:28.0 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);
int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old
2005-04-19 01:40:39.0 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c2005-04-19
01:41:13.0 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);
+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */
/* --- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;
-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;
static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}
-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = "tveeprom",
.id = I2C_DRIVERID_TVEEPROM,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
drivers/media/video/tveeprom.c |6 --
include/media/tveeprom.h |1 -
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19
01:41:24.0 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19
01:41:28.0 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);
int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old
2005-04-19 01:40:39.0 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c2005-04-19
01:41:13.0 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);
+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */
/* --- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;
-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;
static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}
-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = tveeprom,
.id = I2C_DRIVERID_TVEEPROM,
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
