[2.6 patch] drivers/net/ne3210.c: cleanups

2005-04-18 Thread Adrian Bunk
This patch contains the following cleanups:
- make two needlessly global functions static
- kill an ancient version variable

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

---

 drivers/net/ne3210.c |9 +++--
 1 files changed, 3 insertions(+), 6 deletions(-)

--- linux-2.6.11-rc3-mm2-full/drivers/net/ne3210.c.old  2005-02-16 
16:09:39.0 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/ne3210.c  2005-02-21 
15:10:02.0 +0100
@@ -26,9 +26,6 @@
Updated to EISA probing API 5/2003 by Marc Zyngier.
 */
 
-static const char *version =
-   "ne3210.c: Driver revision v0.03, 30/09/98\n";
-
 #include 
 #include 
 #include 
@@ -197,7 +194,7 @@
ei_status.priv = phys_mem;
 
if (ei_debug > 0)
-   printk(version);
+   printk("ne3210 loaded.\n");
 
ei_status.reset_8390 = &ne3210_reset_8390;
ei_status.block_input = &ne3210_block_input;
@@ -359,12 +356,12 @@
 MODULE_DESCRIPTION("NE3210 EISA Ethernet driver");
 MODULE_LICENSE("GPL");
 
-int ne3210_init(void)
+static int ne3210_init(void)
 {
return eisa_driver_register (&ne3210_eisa_driver);
 }
 
-void ne3210_cleanup(void)
+static void ne3210_cleanup(void)
 {
eisa_driver_unregister (&ne3210_eisa_driver);
 }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-24 Thread Adrian Bunk
On Mon, Feb 21, 2005 at 03:39:54PM -0500, Jeff Garzik wrote:
> Adrian Bunk wrote:
> >@@ -197,7 +194,7 @@
> > ei_status.priv = phys_mem;
> > 
> > if (ei_debug > 0)
> >-printk(version);
> >+printk("ne3210 driver");
> 
> 
> missing newline.  Do something like "ns3210 __DATE__ loaded.\n"
> 
> Ditto for seeq8002.

Sorry for the missing newline.

I have to admit I still don't see why these printk's have to stay:
In both files, there are other printk's nearby that print the name of 
the driver.

__DATE__ doesn't provide any information that wasn't already available 
in the first line of the dmesg output.

>   Jeff

cu
Adrian

--

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-21 Thread Jeff Garzik
Adrian Bunk wrote:
@@ -197,7 +194,7 @@
 	ei_status.priv = phys_mem;
 
 	if (ei_debug > 0)
-		printk(version);
+		printk("ne3210 driver");

missing newline.  Do something like "ns3210 __DATE__ loaded.\n"
Ditto for seeq8002.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-21 Thread Adrian Bunk
On Sun, Feb 20, 2005 at 08:40:13PM -0500, Jeff Garzik wrote:
> Adrian Bunk wrote:
> >-if (ei_debug > 0)
> >-printk(version);
> 
> 
> I agree the version variable is outdated, but I disagree that the driver 
> intro banner should be removed completely.

A few lines above, the driver already prints "ne3210.c: remapped...". 
So what exactly should be printed at this place?
The patch below only removes the version information, but the printk 
looks a bit silly.


<--  snip  -->


This patch contains the following cleanups:
- make two needlessly global functions static
- kill an ancient version variable

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

---

 drivers/net/ne3210.c |9 +++--
 1 files changed, 3 insertions(+), 6 deletions(-)

--- linux-2.6.11-rc3-mm2-full/drivers/net/ne3210.c.old  2005-02-16 
16:09:39.0 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/ne3210.c  2005-02-21 
15:10:02.0 +0100
@@ -26,9 +26,6 @@
Updated to EISA probing API 5/2003 by Marc Zyngier.
 */
 
-static const char *version =
-   "ne3210.c: Driver revision v0.03, 30/09/98\n";
-
 #include 
 #include 
 #include 
@@ -197,7 +194,7 @@
ei_status.priv = phys_mem;
 
if (ei_debug > 0)
-   printk(version);
+   printk("ne3210 driver");
 
ei_status.reset_8390 = &ne3210_reset_8390;
ei_status.block_input = &ne3210_block_input;
@@ -359,12 +356,12 @@
 MODULE_DESCRIPTION("NE3210 EISA Ethernet driver");
 MODULE_LICENSE("GPL");
 
-int ne3210_init(void)
+static int ne3210_init(void)
 {
return eisa_driver_register (&ne3210_eisa_driver);
 }
 
-void ne3210_cleanup(void)
+static void ne3210_cleanup(void)
 {
eisa_driver_unregister (&ne3210_eisa_driver);
 }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-20 Thread Jeff Garzik
Adrian Bunk wrote:
-   if (ei_debug > 0)
-   printk(version);

I agree the version variable is outdated, but I disagree that the driver 
intro banner should be removed completely.

Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-18 Thread Adrian Bunk
This patch contains the following cleanups:
- make two needlessly global functions static
- kill an ancient version variable

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

---

 drivers/net/ne3210.c |   10 ++
 1 files changed, 2 insertions(+), 8 deletions(-)

--- linux-2.6.11-rc3-mm2-full/drivers/net/ne3210.c.old  2005-02-16 
16:09:39.0 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/ne3210.c  2005-02-17 
21:55:37.0 +0100
@@ -26,9 +26,6 @@
Updated to EISA probing API 5/2003 by Marc Zyngier.
 */
 
-static const char *version =
-   "ne3210.c: Driver revision v0.03, 30/09/98\n";
-
 #include 
 #include 
 #include 
@@ -196,9 +193,6 @@
ei_status.word16 = 1;
ei_status.priv = phys_mem;
 
-   if (ei_debug > 0)
-   printk(version);
-
ei_status.reset_8390 = &ne3210_reset_8390;
ei_status.block_input = &ne3210_block_input;
ei_status.block_output = &ne3210_block_output;
@@ -359,12 +353,12 @@
 MODULE_DESCRIPTION("NE3210 EISA Ethernet driver");
 MODULE_LICENSE("GPL");
 
-int ne3210_init(void)
+static int ne3210_init(void)
 {
return eisa_driver_register (&ne3210_eisa_driver);
 }
 
-void ne3210_cleanup(void)
+static void ne3210_cleanup(void)
 {
eisa_driver_unregister (&ne3210_eisa_driver);
 }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/