[2.6 patch] fix devres_release_all() return value
Every file should include the headers containing the prototypes for it's global functions. Since the GNU C compiler is now able to detect that the function prototype of devres_release_all() in the header and the actual function disagree regarding the return value, this patch also fixes this bug. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/base/base.h |2 +- drivers/base/devres.c |2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) --- linux-2.6.22-rc4-mm2/drivers/base/base.h.old2007-06-17 15:37:21.0 +0200 +++ linux-2.6.22-rc4-mm2/drivers/base/base.h2007-06-17 15:37:34.0 +0200 @@ -44,6 +44,6 @@ extern char *make_class_name(const char *name, struct kobject *kobj); -extern void devres_release_all(struct device *dev); +extern int devres_release_all(struct device *dev); extern struct kset devices_subsys; --- linux-2.6.22-rc4-mm2/drivers/base/devres.c.old 2007-06-17 15:30:48.0 +0200 +++ linux-2.6.22-rc4-mm2/drivers/base/devres.c 2007-06-17 15:31:03.0 +0200 @@ -10,6 +10,8 @@ #include #include +#include "base.h" + struct devres_node { struct list_headentry; dr_release_trelease; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] fix devres_release_all() return value
Adrian Bunk wrote: > Every file should include the headers containing the prototypes for > it's global functions. > > Since the GNU C compiler is now able to detect that the function > prototype of devres_release_all() in the header and the actual function > disagree regarding the return value, this patch also fixes this bug. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Tejun Heo <[EMAIL PROTECTED]> This should go through Greg. http://article.gmane.org/gmane.linux.kernel/544290/raw -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] fix devres_release_all() return value
On Mon, Jun 18, 2007 at 02:55:30PM +0900, Tejun Heo wrote: > Adrian Bunk wrote: > > Every file should include the headers containing the prototypes for > > it's global functions. > > > > Since the GNU C compiler is now able to detect that the function > > prototype of devres_release_all() in the header and the actual function > > disagree regarding the return value, this patch also fixes this bug. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Acked-by: Tejun Heo <[EMAIL PROTECTED]> > > This should go through Greg. > > http://article.gmane.org/gmane.linux.kernel/544290/raw Thanks, I've picked it up now. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/