Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c
On Tue, Feb 20, 2007 at 10:59:46AM +, David Howells wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > } /* end rxrpc_create_call() */ > > +EXPORT_SYMBOL(rxrpc_create_call); > > A blank line between the end of the function and the EXPORT_SYMBOL please. Please discuss this with Andrew [1] and tell me what you agreed upon. > David cu Adrian [1] http://lkml.org/lkml/2006/11/27/293 -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c
Adrian Bunk <[EMAIL PROTECTED]> wrote: > } /* end rxrpc_create_call() */ > +EXPORT_SYMBOL(rxrpc_create_call); A blank line between the end of the function and the EXPORT_SYMBOL please. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] kill net/rxrpc/rxrpc_syms.c
This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the
files with the actual functions.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch was already sent on:
- 26 Nov 2006
net/rxrpc/Makefile |1 -
net/rxrpc/call.c |5 +
net/rxrpc/connection.c |2 ++
net/rxrpc/rxrpc_syms.c | 34 --
net/rxrpc/transport.c |4
5 files changed, 11 insertions(+), 35 deletions(-)
--- linux-2.6.19-rc6-mm1/net/rxrpc/Makefile.old 2006-11-26 04:49:25.0
+0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/Makefile 2006-11-26 04:50:08.0
+0100
@@ -12,7 +12,6 @@
krxtimod.o \
main.o \
peer.o \
- rxrpc_syms.o \
transport.o
ifeq ($(CONFIG_PROC_FS),y)
--- linux-2.6.19-rc6-mm1/net/rxrpc/call.c.old 2006-11-26 04:50:51.0
+0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/call.c 2006-11-26 04:51:58.0
+0100
@@ -314,6 +314,7 @@
_leave(" = %d", ret);
return ret;
} /* end rxrpc_create_call() */
+EXPORT_SYMBOL(rxrpc_create_call);
/*/
/*
@@ -465,6 +466,7 @@
_leave(" [destroyed]");
} /* end rxrpc_put_call() */
+EXPORT_SYMBOL(rxrpc_put_call);
/*/
/*
@@ -923,6 +925,7 @@
return __rxrpc_call_abort(call, error);
} /* end rxrpc_call_abort() */
+EXPORT_SYMBOL(rxrpc_call_abort);
/*/
/*
@@ -1910,6 +1913,7 @@
}
} /* end rxrpc_call_read_data() */
+EXPORT_SYMBOL(rxrpc_call_read_data);
/*/
/*
@@ -2076,6 +2080,7 @@
return ret;
} /* end rxrpc_call_write_data() */
+EXPORT_SYMBOL(rxrpc_call_write_data);
/*/
/*
--- linux-2.6.19-rc6-mm1/net/rxrpc/connection.c.old 2006-11-26
04:52:08.0 +0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/connection.c 2006-11-26 04:52:32.0
+0100
@@ -207,6 +207,7 @@
spin_unlock(&peer->conn_gylock);
goto make_active;
} /* end rxrpc_create_connection() */
+EXPORT_SYMBOL(rxrpc_create_connection);
/*/
/*
@@ -411,6 +412,7 @@
_leave(" [killed]");
} /* end rxrpc_put_connection() */
+EXPORT_SYMBOL(rxrpc_put_connection);
/*/
/*
--- linux-2.6.19-rc6-mm1/net/rxrpc/transport.c.old 2006-11-26
04:52:43.0 +0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/transport.c 2006-11-26 04:53:36.0
+0100
@@ -146,6 +146,7 @@
_leave(" = %d", ret);
return ret;
} /* end rxrpc_create_transport() */
+EXPORT_SYMBOL(rxrpc_create_transport);
/*/
/*
@@ -196,6 +197,7 @@
_leave("");
} /* end rxrpc_put_transport() */
+EXPORT_SYMBOL(rxrpc_put_transport);
/*/
/*
@@ -231,6 +233,7 @@
_leave("= %d", ret);
return ret;
} /* end rxrpc_add_service() */
+EXPORT_SYMBOL(rxrpc_add_service);
/*/
/*
@@ -248,6 +251,7 @@
_leave("");
} /* end rxrpc_del_service() */
+EXPORT_SYMBOL(rxrpc_del_service);
/*/
/*
--- linux-2.6.19-rc6-mm1/net/rxrpc/rxrpc_syms.c 2006-09-20 05:42:06.0
+0200
+++ /dev/null 2006-09-19 00:45:31.0 +0200
@@ -1,34 +0,0 @@
-/* rxrpc_syms.c: exported Rx RPC layer interface symbols
- *
- * Copyright (C) 2002 Red Hat, Inc. All Rights Reserved.
- * Written by David Howells ([EMAIL PROTECTED])
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- */
-
-#include
-
-#include
-#include
-#include
-#include
-
-/* call.c */
-EXPORT_SYMBOL(rxrpc_create_call);
-EXPORT_SYMBOL(rxrpc_put_call);
-EXPORT_SYMBOL(rxrpc_call_abort);
-EXPORT_SYMBOL(rxrpc_call_read_data);
-EXPORT_SYMBOL(rxrpc_call_write_data);
-
-/* connection.c */
-EXPORT_SYMBOL(rxrpc_create_connection);
-EXPORT_SYMBOL(rxrpc_put_connection);
-
-/* transport.c */
-EXPORT_SYMBOL(rxrpc_create_transport);
-EXPORT_SYMBOL(rxrpc_put_transport);
-EXPORT_SYMBOL(rxrpc_add_service);
-EXPORT_SYMBOL(rxrpc_del_service);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the
Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c
Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > > > files with the actual functions. > > > > You can if you like. Can you slap a blank line before each EXPORT_SYMBOL() > > though please? > > Updated patch below. Acked-By: David Howells <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c
On 11/28/06, Andrew Morton <[EMAIL PROTECTED]> wrote:
On Mon, 27 Nov 2006 11:21:25 +
David Howells <[EMAIL PROTECTED]> wrote:
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the
> > files with the actual functions.
>
> You can if you like. Can you slap a blank line before each EXPORT_SYMBOL()
> though please?
We have a mixture of both styles and given that they waste space in return
for no added value, people have been gradually removing these blank lines
in many places. Please don't add more.
Agreed, good thing would be if we could have something like
void foo(int bar) gpl_exported
{
}
I.e. some kind of __attribute__, nah, I should just get some sleep :-)
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c
On Mon, 27 Nov 2006 11:21:25 + David Howells <[EMAIL PROTECTED]> wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > > files with the actual functions. > > You can if you like. Can you slap a blank line before each EXPORT_SYMBOL() > though please? We have a mixture of both styles and given that they waste space in return for no added value, people have been gradually removing these blank lines in many places. Please don't add more. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] kill net/rxrpc/rxrpc_syms.c
On Mon, Nov 27, 2006 at 11:21:25AM +, David Howells wrote:
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the
> > files with the actual functions.
>
> You can if you like. Can you slap a blank line before each EXPORT_SYMBOL()
> though please?
Updated patch below.
> David
cu
Adrian
<-- snip -->
This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the
files with the actual functions.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
net/rxrpc/Makefile |1 -
net/rxrpc/call.c | 10 ++
net/rxrpc/connection.c |4
net/rxrpc/rxrpc_syms.c | 34 --
net/rxrpc/transport.c |8
5 files changed, 22 insertions(+), 35 deletions(-)
--- linux-2.6.19-rc6-mm1/net/rxrpc/Makefile.old 2006-11-26 04:49:25.0
+0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/Makefile 2006-11-26 04:50:08.0
+0100
@@ -12,7 +12,6 @@
krxtimod.o \
main.o \
peer.o \
- rxrpc_syms.o \
transport.o
ifeq ($(CONFIG_PROC_FS),y)
--- linux-2.6.19-rc6-mm1/net/rxrpc/call.c.old 2006-11-26 04:50:51.0
+0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/call.c 2006-11-27 22:15:05.0
+0100
@@ -315,6 +315,8 @@
return ret;
} /* end rxrpc_create_call() */
+EXPORT_SYMBOL(rxrpc_create_call);
+
/*/
/*
* create a new call record for incoming calls
@@ -466,6 +468,8 @@
_leave(" [destroyed]");
} /* end rxrpc_put_call() */
+EXPORT_SYMBOL(rxrpc_put_call);
+
/*/
/*
* actually generate a normal ACK
@@ -924,6 +928,8 @@
} /* end rxrpc_call_abort() */
+EXPORT_SYMBOL(rxrpc_call_abort);
+
/*/
/*
* process packets waiting for this call
@@ -1911,6 +1917,8 @@
} /* end rxrpc_call_read_data() */
+EXPORT_SYMBOL(rxrpc_call_read_data);
+
/*/
/*
* write data to a call
@@ -2077,6 +2085,8 @@
} /* end rxrpc_call_write_data() */
+EXPORT_SYMBOL(rxrpc_call_write_data);
+
/*/
/*
* flush outstanding packets to the network
--- linux-2.6.19-rc6-mm1/net/rxrpc/connection.c.old 2006-11-26
04:52:08.0 +0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/connection.c 2006-11-27 22:15:35.0
+0100
@@ -208,6 +208,8 @@
goto make_active;
} /* end rxrpc_create_connection() */
+EXPORT_SYMBOL(rxrpc_create_connection);
+
/*/
/*
* lookup the connection for an incoming packet
@@ -412,6 +414,8 @@
_leave(" [killed]");
} /* end rxrpc_put_connection() */
+EXPORT_SYMBOL(rxrpc_put_connection);
+
/*/
/*
* free a connection record
--- linux-2.6.19-rc6-mm1/net/rxrpc/transport.c.old 2006-11-26
04:52:43.0 +0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/transport.c 2006-11-27 22:15:57.0
+0100
@@ -147,6 +147,8 @@
return ret;
} /* end rxrpc_create_transport() */
+EXPORT_SYMBOL(rxrpc_create_transport);
+
/*/
/*
* destroy a transport endpoint
@@ -197,6 +199,8 @@
_leave("");
} /* end rxrpc_put_transport() */
+EXPORT_SYMBOL(rxrpc_put_transport);
+
/*/
/*
* add a service to a transport to be listened upon
@@ -232,6 +236,8 @@
return ret;
} /* end rxrpc_add_service() */
+EXPORT_SYMBOL(rxrpc_add_service);
+
/*/
/*
* remove a service from a transport
@@ -249,6 +255,8 @@
_leave("");
} /* end rxrpc_del_service() */
+EXPORT_SYMBOL(rxrpc_del_service);
+
/*/
/*
* INET callback when data has been received on the socket.
--- linux-2.6.19-rc6-mm1/net/rxrpc/rxrpc_syms.c 2006-09-20 05:42:06.0
+0200
+++ /dev/null 2006-09-19 00:45:31.0 +0200
@@ -1,34 +0,0 @@
-/* rxrpc_syms.c: exported Rx RPC layer interface symbols
- *
- * Copyright (C) 2002 Red Hat, Inc. All Rights Reserved.
- * Written by David Howells ([EMAIL PROTECTED])
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- */
-
-#include
-
-#include
-#include
-#include
-#include
-
-/* call.c */
-EXPORT_SYMBOL(rxrpc_create_call);
-EXPORT_SY
Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c
Adrian Bunk <[EMAIL PROTECTED]> wrote: > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > files with the actual functions. You can if you like. Can you slap a blank line before each EXPORT_SYMBOL() though please? David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] kill net/rxrpc/rxrpc_syms.c
This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the
files with the actual functions.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
net/rxrpc/Makefile |1 -
net/rxrpc/call.c |5 +
net/rxrpc/connection.c |2 ++
net/rxrpc/rxrpc_syms.c | 34 --
net/rxrpc/transport.c |4
5 files changed, 11 insertions(+), 35 deletions(-)
--- linux-2.6.19-rc6-mm1/net/rxrpc/Makefile.old 2006-11-26 04:49:25.0
+0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/Makefile 2006-11-26 04:50:08.0
+0100
@@ -12,7 +12,6 @@
krxtimod.o \
main.o \
peer.o \
- rxrpc_syms.o \
transport.o
ifeq ($(CONFIG_PROC_FS),y)
--- linux-2.6.19-rc6-mm1/net/rxrpc/call.c.old 2006-11-26 04:50:51.0
+0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/call.c 2006-11-26 04:51:58.0
+0100
@@ -314,6 +314,7 @@
_leave(" = %d", ret);
return ret;
} /* end rxrpc_create_call() */
+EXPORT_SYMBOL(rxrpc_create_call);
/*/
/*
@@ -465,6 +466,7 @@
_leave(" [destroyed]");
} /* end rxrpc_put_call() */
+EXPORT_SYMBOL(rxrpc_put_call);
/*/
/*
@@ -923,6 +925,7 @@
return __rxrpc_call_abort(call, error);
} /* end rxrpc_call_abort() */
+EXPORT_SYMBOL(rxrpc_call_abort);
/*/
/*
@@ -1910,6 +1913,7 @@
}
} /* end rxrpc_call_read_data() */
+EXPORT_SYMBOL(rxrpc_call_read_data);
/*/
/*
@@ -2076,6 +2080,7 @@
return ret;
} /* end rxrpc_call_write_data() */
+EXPORT_SYMBOL(rxrpc_call_write_data);
/*/
/*
--- linux-2.6.19-rc6-mm1/net/rxrpc/connection.c.old 2006-11-26
04:52:08.0 +0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/connection.c 2006-11-26 04:52:32.0
+0100
@@ -207,6 +207,7 @@
spin_unlock(&peer->conn_gylock);
goto make_active;
} /* end rxrpc_create_connection() */
+EXPORT_SYMBOL(rxrpc_create_connection);
/*/
/*
@@ -411,6 +412,7 @@
_leave(" [killed]");
} /* end rxrpc_put_connection() */
+EXPORT_SYMBOL(rxrpc_put_connection);
/*/
/*
--- linux-2.6.19-rc6-mm1/net/rxrpc/transport.c.old 2006-11-26
04:52:43.0 +0100
+++ linux-2.6.19-rc6-mm1/net/rxrpc/transport.c 2006-11-26 04:53:36.0
+0100
@@ -146,6 +146,7 @@
_leave(" = %d", ret);
return ret;
} /* end rxrpc_create_transport() */
+EXPORT_SYMBOL(rxrpc_create_transport);
/*/
/*
@@ -196,6 +197,7 @@
_leave("");
} /* end rxrpc_put_transport() */
+EXPORT_SYMBOL(rxrpc_put_transport);
/*/
/*
@@ -231,6 +233,7 @@
_leave("= %d", ret);
return ret;
} /* end rxrpc_add_service() */
+EXPORT_SYMBOL(rxrpc_add_service);
/*/
/*
@@ -248,6 +251,7 @@
_leave("");
} /* end rxrpc_del_service() */
+EXPORT_SYMBOL(rxrpc_del_service);
/*/
/*
--- linux-2.6.19-rc6-mm1/net/rxrpc/rxrpc_syms.c 2006-09-20 05:42:06.0
+0200
+++ /dev/null 2006-09-19 00:45:31.0 +0200
@@ -1,34 +0,0 @@
-/* rxrpc_syms.c: exported Rx RPC layer interface symbols
- *
- * Copyright (C) 2002 Red Hat, Inc. All Rights Reserved.
- * Written by David Howells ([EMAIL PROTECTED])
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- */
-
-#include
-
-#include
-#include
-#include
-#include
-
-/* call.c */
-EXPORT_SYMBOL(rxrpc_create_call);
-EXPORT_SYMBOL(rxrpc_put_call);
-EXPORT_SYMBOL(rxrpc_call_abort);
-EXPORT_SYMBOL(rxrpc_call_read_data);
-EXPORT_SYMBOL(rxrpc_call_write_data);
-
-/* connection.c */
-EXPORT_SYMBOL(rxrpc_create_connection);
-EXPORT_SYMBOL(rxrpc_put_connection);
-
-/* transport.c */
-EXPORT_SYMBOL(rxrpc_create_transport);
-EXPORT_SYMBOL(rxrpc_put_transport);
-EXPORT_SYMBOL(rxrpc_add_service);
-EXPORT_SYMBOL(rxrpc_del_service);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
