Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 04:52:18PM +0800, Jeff Chua wrote: > On Fri, Feb 15, 2008 at 2:59 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > I swear someone else sent this in, but my archives don't show it at all. > > I think the patch below should solve this, but I need someone to test it. > > I tested but it doesn't fix the problem for me. May be my problem is > different ... as my X60s just doesn't power-off on suspend-to-disk. > > My .config says ... > # CONFIG_CPU_FREQ is not set > # CONFIG_CPU_IDLE is not set > > > On Wed, Feb 13, 2008 at 3:54 PM, Andrew Morton > <[EMAIL PROTECTED]> wrote: > > due to softlockup changes, and setting CONFIG_DETECT_SOFTLOCKUP=n ... > > Also, I've tried CONFIG_DETECT_SOFTLOCKUP=n, but this doesn't fix it either. Ok, this looks to be something else. > Here's the last dmesg after suspend-to-disk and hang there... > > CPU 1 is now offline > SMP alternatives: switching to UP code > PM: Syncing filesystems ... done. > Freezing user space processes ... (elapsed 0.00 seconds) done. > Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. > PM: Shrinking memory... ^H-^Hdone (0 pages freed) > PM: Freed 0 kbytes in 0.10 seconds (0.00 MB/s) > ACPI: Preparing to enter system sleep state S4 > Suspending console(s) > > [ ... it just hangs here ... press power-switch does the job, and > system is able to resume upon powering on ] Wait, this is a suspend-to-disk issue. Totally different than the "will not power off" issue. Can you start a new thread on this, and add the suspend people to it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 11:38:59AM -0800, Yinghai Lu wrote:
> On Fri, Feb 15, 2008 at 2:19 AM, Frans Pop <[EMAIL PROTECTED]> wrote:
> > On Friday 15 February 2008, Greg KH wrote:
> > > I swear someone sent this patch in before. Can you try this one below,
> > > there seems to be an imbalance with kobject_get and _put.
> >
> > I did remember seeing this patch before [1] and can confirm that it does
> > indeed fix the issue: with this patch applied to 2.6.25 git head my system
> > powers off correctly.
> >
> > [1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960.
> >
> >
> >
> > > ---
> > > drivers/cpufreq/cpufreq.c |8
> > > 1 file changed, 8 deletions(-)
> > >
> > > --- a/drivers/cpufreq/cpufreq.c
> > > +++ b/drivers/cpufreq/cpufreq.c
> > > @@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
> > > }
> > > #endif
> > >
> > > -
> > > - if (!kobject_get(>kobj)) {
> > > - spin_unlock_irqrestore(_driver_lock, flags);
> > > - cpufreq_debug_enable_ratelimit();
> > > - unlock_policy_rwsem_write(cpu);
> > > - return -EFAULT;
> > > - }
> > > -
> > > #ifdef CONFIG_SMP
> > >
> > > #ifdef CONFIG_HOTPLUG_CPU
> >
> >
>
> confirmed, with this patch, i still need disable CONFIG_DETECT_SOFTLOCKUP
Great, thanks for testing and letting us know.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 12:41:43AM -0800, Yinghai Lu wrote: > On Thu, Feb 14, 2008 at 10:52 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > > > Ugh, sorry, I was mistaken, it's not a cpufreq issue, it's a > > CONFIG_DETECT_SOFTLOCKUP issue. Or that is what I was told before. > > > > could be two issues: > one in cpufreq, and one in detect softlockup... Looks like it's that way :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 11:19:20AM +0100, Frans Pop wrote: > On Friday 15 February 2008, Greg KH wrote: > > I swear someone sent this patch in before. Can you try this one below, > > there seems to be an imbalance with kobject_get and _put. > > I did remember seeing this patch before [1] and can confirm that it does > indeed fix the issue: with this patch applied to 2.6.25 git head my system > powers off correctly. > > [1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960. Ah, thanks, for some reason I couldn't find this in my archives. I'll add this to my queue to go to Linus. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 11:38 AM, Yinghai Lu <[EMAIL PROTECTED]> wrote:
>
> On Fri, Feb 15, 2008 at 2:19 AM, Frans Pop <[EMAIL PROTECTED]> wrote:
> > On Friday 15 February 2008, Greg KH wrote:
> > > I swear someone sent this patch in before. Can you try this one below,
> > > there seems to be an imbalance with kobject_get and _put.
> >
> > I did remember seeing this patch before [1] and can confirm that it does
> > indeed fix the issue: with this patch applied to 2.6.25 git head my system
> > powers off correctly.
> >
> > [1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960.
> >
> >
> >
> > > ---
> > > drivers/cpufreq/cpufreq.c |8
> > > 1 file changed, 8 deletions(-)
> > >
> > > --- a/drivers/cpufreq/cpufreq.c
> > > +++ b/drivers/cpufreq/cpufreq.c
> > > @@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
> > > }
> > > #endif
> > >
> > > -
> > > - if (!kobject_get(>kobj)) {
> > > - spin_unlock_irqrestore(_driver_lock, flags);
> > > - cpufreq_debug_enable_ratelimit();
> > > - unlock_policy_rwsem_write(cpu);
> > > - return -EFAULT;
> > > - }
> > > -
> > > #ifdef CONFIG_SMP
> > >
> > > #ifdef CONFIG_HOTPLUG_CPU
> >
> >
>
> confirmed, with this patch, i still need disable CONFIG_DETECT_SOFTLOCKUP
>
> assume watchdog thread for the dead cpu can not be stopped. hang somewhere.
Ingo,
with patch (http://lkml.org/lkml/2008/2/8/342) and following patch, it
could power off with CONFIG_DETECT_SOFTLOCKUP config
diff --git a/kernel/softlockup.c b/kernel/softlockup.c
index 7c2da88..c16a658 100644
--- a/kernel/softlockup.c
+++ b/kernel/softlockup.c
@@ -282,12 +282,12 @@ cpu_callback(struct notifier_block *nfb,
unsigned long action, void *hcpu)
case CPU_UP_CANCELED_FROZEN:
if (!per_cpu(watchdog_task, hotcpu))
break;
- /* Unbind so it can run. Fall thru. */
- kthread_bind(per_cpu(watchdog_task, hotcpu),
-any_online_cpu(cpu_online_map));
+ /* Fall thru. */
case CPU_DEAD:
case CPU_DEAD_FROZEN:
p = per_cpu(watchdog_task, hotcpu);
+ /* Unbind so it can run. */
+ kthread_bind(p, any_online_cpu(cpu_online_map));
per_cpu(watchdog_task, hotcpu) = NULL;
kthread_stop(p);
break;
but got WARN on every CPU.
ACPI: Preparing to enter system sleep state S5
Disabling non-boot CPUs ...
kvm: disabling virtualization on CPU1
CPU 1 is now offline
[ cut here ]
WARNING: at kernel/kthread.c:176 cpu_callback+0x14f/0x177()
Modules linked in:
Pid: 7224, comm: halt Not tainted 2.6.25-rc1-smp-00266-g4ee29f6-dirty #110
Call Trace:
[] warn_on_slowpath+0x51/0x63
[] ktime_get_ts+0x3d/0x48
[] hrtick_start_fair+0xe1/0x129
[] enqueue_task+0x4d/0x58
[] try_to_wake_up+0x1ae/0x1bf
[] cpu_callback+0x14f/0x177
[] writeback_set_ratelimit+0x17/0x5d
[] notifier_call_chain+0x29/0x4c
[] _cpu_down+0x18e/0x251
[] disable_nonboot_cpus+0x50/0xd7
[] kernel_power_off+0x21/0x3a
[] sys_reboot+0xee/0x187
[] group_send_sig_info+0x62/0x6f
[] kill_pid_info+0x4d/0x6b
[] sys_kill+0x70/0x13e
[] do_page_fault+0x3a9/0x768
[] __up_read+0x13/0x8a
[] error_exit+0x0/0x51
[] system_call_after_swapgs+0x7b/0x80
---[ end trace 7098a44b4633d8ed ]---
CPU1 is down
kvm: disabling virtualization on CPU2
CPU 2 is now offline
[ cut here ]
WARNING: at kernel/kthread.c:176 cpu_callback+0x14f/0x177()
Modules linked in:
Pid: 7224, comm: halt Not tainted 2.6.25-rc1-smp-00266-g4ee29f6-dirty #110
Call Trace:
[] warn_on_slowpath+0x51/0x63
[] ktime_get_ts+0x3d/0x48
[] hrtick_start_fair+0xe1/0x129
[] enqueue_task+0x4d/0x58
[] try_to_wake_up+0x1ae/0x1bf
[] cpu_callback+0x14f/0x177
[] writeback_set_ratelimit+0x17/0x5d
[] notifier_call_chain+0x29/0x4c
[] _cpu_down+0x18e/0x251
[] disable_nonboot_cpus+0x50/0xd7
[] kernel_power_off+0x21/0x3a
[] sys_reboot+0xee/0x187
[] group_send_sig_info+0x62/0x6f
[] kill_pid_info+0x4d/0x6b
[] sys_kill+0x70/0x13e
[] do_page_fault+0x3a9/0x768
[] __up_read+0x13/0x8a
[] error_exit+0x0/0x51
[] system_call_after_swapgs+0x7b/0x80
---[ end trace 7098a44b4633d8ed ]---
CPU2 is down
kvm: disabling virtualization on CPU3
CPU 3 is now offline
[ cut here ]
WARNING: at kernel/kthread.c:176 cpu_callback+0x14f/0x177()
Modules linked in:
Pid: 7224, comm: halt Not tainted 2.6.25-rc1-smp-00266-g4ee29f6-dirty #110
Call Trace:
[] warn_on_slowpath+0x51/0x63
[] ktime_get_ts+0x3d/0x48
[] hrtick_start_fair+0xe1/0x129
[] enqueue_task+0x4d/0x58
[] try_to_wake_up+0x1ae/0x1bf
[] cpu_callback+0x14f/0x177
[] writeback_set_ratelimit+0x17/0x5d
[] notifier_call_chain+0x29/0x4c
[] _cpu_down+0x18e/0x251
[] disable_nonboot_cpus+0x50/0xd7
[] kernel_power_off+0x21/0x3a
[] sys_reboot+0xee/0x187
[]
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 2:19 AM, Frans Pop <[EMAIL PROTECTED]> wrote:
> On Friday 15 February 2008, Greg KH wrote:
> > I swear someone sent this patch in before. Can you try this one below,
> > there seems to be an imbalance with kobject_get and _put.
>
> I did remember seeing this patch before [1] and can confirm that it does
> indeed fix the issue: with this patch applied to 2.6.25 git head my system
> powers off correctly.
>
> [1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960.
>
>
>
> > ---
> > drivers/cpufreq/cpufreq.c |8
> > 1 file changed, 8 deletions(-)
> >
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
> > }
> > #endif
> >
> > -
> > - if (!kobject_get(>kobj)) {
> > - spin_unlock_irqrestore(_driver_lock, flags);
> > - cpufreq_debug_enable_ratelimit();
> > - unlock_policy_rwsem_write(cpu);
> > - return -EFAULT;
> > - }
> > -
> > #ifdef CONFIG_SMP
> >
> > #ifdef CONFIG_HOTPLUG_CPU
>
>
confirmed, with this patch, i still need disable CONFIG_DETECT_SOFTLOCKUP
assume watchdog thread for the dead cpu can not be stopped. hang somewhere.
YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Friday 15 February 2008, Greg KH wrote:
> I swear someone sent this patch in before. Can you try this one below,
> there seems to be an imbalance with kobject_get and _put.
I did remember seeing this patch before [1] and can confirm that it does
indeed fix the issue: with this patch applied to 2.6.25 git head my system
powers off correctly.
[1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960.
> ---
> drivers/cpufreq/cpufreq.c |8
> 1 file changed, 8 deletions(-)
>
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
> }
> #endif
>
> -
> - if (!kobject_get(>kobj)) {
> - spin_unlock_irqrestore(_driver_lock, flags);
> - cpufreq_debug_enable_ratelimit();
> - unlock_policy_rwsem_write(cpu);
> - return -EFAULT;
> - }
> -
> #ifdef CONFIG_SMP
>
> #ifdef CONFIG_HOTPLUG_CPU
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 2:59 PM, Greg KH <[EMAIL PROTECTED]> wrote: > I swear someone else sent this in, but my archives don't show it at all. > I think the patch below should solve this, but I need someone to test it. I tested but it doesn't fix the problem for me. May be my problem is different ... as my X60s just doesn't power-off on suspend-to-disk. My .config says ... # CONFIG_CPU_FREQ is not set # CONFIG_CPU_IDLE is not set On Wed, Feb 13, 2008 at 3:54 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > due to softlockup changes, and setting CONFIG_DETECT_SOFTLOCKUP=n ... Also, I've tried CONFIG_DETECT_SOFTLOCKUP=n, but this doesn't fix it either. Here's the last dmesg after suspend-to-disk and hang there... CPU 1 is now offline SMP alternatives: switching to UP code PM: Syncing filesystems ... done. Freezing user space processes ... (elapsed 0.00 seconds) done. Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. PM: Shrinking memory... ^H-^Hdone (0 pages freed) PM: Freed 0 kbytes in 0.10 seconds (0.00 MB/s) ACPI: Preparing to enter system sleep state S4 Suspending console(s) [ ... it just hangs here ... press power-switch does the job, and system is able to resume upon powering on ] Thanks, Jeff. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Thu, Feb 14, 2008 at 10:52 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > Ugh, sorry, I was mistaken, it's not a cpufreq issue, it's a > CONFIG_DETECT_SOFTLOCKUP issue. Or that is what I was told before. > could be two issues: one in cpufreq, and one in detect softlockup... YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Thu, Feb 14, 2008 at 10:52 PM, Greg KH [EMAIL PROTECTED] wrote: Ugh, sorry, I was mistaken, it's not a cpufreq issue, it's a CONFIG_DETECT_SOFTLOCKUP issue. Or that is what I was told before. could be two issues: one in cpufreq, and one in detect softlockup... YH -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 2:59 PM, Greg KH [EMAIL PROTECTED] wrote: I swear someone else sent this in, but my archives don't show it at all. I think the patch below should solve this, but I need someone to test it. I tested but it doesn't fix the problem for me. May be my problem is different ... as my X60s just doesn't power-off on suspend-to-disk. My .config says ... # CONFIG_CPU_FREQ is not set # CONFIG_CPU_IDLE is not set On Wed, Feb 13, 2008 at 3:54 PM, Andrew Morton [EMAIL PROTECTED] wrote: due to softlockup changes, and setting CONFIG_DETECT_SOFTLOCKUP=n ... Also, I've tried CONFIG_DETECT_SOFTLOCKUP=n, but this doesn't fix it either. Here's the last dmesg after suspend-to-disk and hang there... CPU 1 is now offline SMP alternatives: switching to UP code PM: Syncing filesystems ... done. Freezing user space processes ... (elapsed 0.00 seconds) done. Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. PM: Shrinking memory... ^H-^Hdone (0 pages freed) PM: Freed 0 kbytes in 0.10 seconds (0.00 MB/s) ACPI: Preparing to enter system sleep state S4 Suspending console(s) [ ... it just hangs here ... press power-switch does the job, and system is able to resume upon powering on ] Thanks, Jeff. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Friday 15 February 2008, Greg KH wrote:
I swear someone sent this patch in before. Can you try this one below,
there seems to be an imbalance with kobject_get and _put.
I did remember seeing this patch before [1] and can confirm that it does
indeed fix the issue: with this patch applied to 2.6.25 git head my system
powers off correctly.
[1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960.
---
drivers/cpufreq/cpufreq.c |8
1 file changed, 8 deletions(-)
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
}
#endif
-
- if (!kobject_get(data-kobj)) {
- spin_unlock_irqrestore(cpufreq_driver_lock, flags);
- cpufreq_debug_enable_ratelimit();
- unlock_policy_rwsem_write(cpu);
- return -EFAULT;
- }
-
#ifdef CONFIG_SMP
#ifdef CONFIG_HOTPLUG_CPU
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 2:19 AM, Frans Pop [EMAIL PROTECTED] wrote:
On Friday 15 February 2008, Greg KH wrote:
I swear someone sent this patch in before. Can you try this one below,
there seems to be an imbalance with kobject_get and _put.
I did remember seeing this patch before [1] and can confirm that it does
indeed fix the issue: with this patch applied to 2.6.25 git head my system
powers off correctly.
[1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960.
---
drivers/cpufreq/cpufreq.c |8
1 file changed, 8 deletions(-)
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
}
#endif
-
- if (!kobject_get(data-kobj)) {
- spin_unlock_irqrestore(cpufreq_driver_lock, flags);
- cpufreq_debug_enable_ratelimit();
- unlock_policy_rwsem_write(cpu);
- return -EFAULT;
- }
-
#ifdef CONFIG_SMP
#ifdef CONFIG_HOTPLUG_CPU
confirmed, with this patch, i still need disable CONFIG_DETECT_SOFTLOCKUP
assume watchdog thread for the dead cpu can not be stopped. hang somewhere.
YH
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 11:38 AM, Yinghai Lu [EMAIL PROTECTED] wrote:
On Fri, Feb 15, 2008 at 2:19 AM, Frans Pop [EMAIL PROTECTED] wrote:
On Friday 15 February 2008, Greg KH wrote:
I swear someone sent this patch in before. Can you try this one below,
there seems to be an imbalance with kobject_get and _put.
I did remember seeing this patch before [1] and can confirm that it does
indeed fix the issue: with this patch applied to 2.6.25 git head my system
powers off correctly.
[1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960.
---
drivers/cpufreq/cpufreq.c |8
1 file changed, 8 deletions(-)
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
}
#endif
-
- if (!kobject_get(data-kobj)) {
- spin_unlock_irqrestore(cpufreq_driver_lock, flags);
- cpufreq_debug_enable_ratelimit();
- unlock_policy_rwsem_write(cpu);
- return -EFAULT;
- }
-
#ifdef CONFIG_SMP
#ifdef CONFIG_HOTPLUG_CPU
confirmed, with this patch, i still need disable CONFIG_DETECT_SOFTLOCKUP
assume watchdog thread for the dead cpu can not be stopped. hang somewhere.
Ingo,
with patch (http://lkml.org/lkml/2008/2/8/342) and following patch, it
could power off with CONFIG_DETECT_SOFTLOCKUP config
diff --git a/kernel/softlockup.c b/kernel/softlockup.c
index 7c2da88..c16a658 100644
--- a/kernel/softlockup.c
+++ b/kernel/softlockup.c
@@ -282,12 +282,12 @@ cpu_callback(struct notifier_block *nfb,
unsigned long action, void *hcpu)
case CPU_UP_CANCELED_FROZEN:
if (!per_cpu(watchdog_task, hotcpu))
break;
- /* Unbind so it can run. Fall thru. */
- kthread_bind(per_cpu(watchdog_task, hotcpu),
-any_online_cpu(cpu_online_map));
+ /* Fall thru. */
case CPU_DEAD:
case CPU_DEAD_FROZEN:
p = per_cpu(watchdog_task, hotcpu);
+ /* Unbind so it can run. */
+ kthread_bind(p, any_online_cpu(cpu_online_map));
per_cpu(watchdog_task, hotcpu) = NULL;
kthread_stop(p);
break;
but got WARN on every CPU.
ACPI: Preparing to enter system sleep state S5
Disabling non-boot CPUs ...
kvm: disabling virtualization on CPU1
CPU 1 is now offline
[ cut here ]
WARNING: at kernel/kthread.c:176 cpu_callback+0x14f/0x177()
Modules linked in:
Pid: 7224, comm: halt Not tainted 2.6.25-rc1-smp-00266-g4ee29f6-dirty #110
Call Trace:
[80243c61] warn_on_slowpath+0x51/0x63
[80257e00] ktime_get_ts+0x3d/0x48
[8023b160] hrtick_start_fair+0xe1/0x129
[8023a049] enqueue_task+0x4d/0x58
[8023ceda] try_to_wake_up+0x1ae/0x1bf
[80848796] cpu_callback+0x14f/0x177
[802747e4] writeback_set_ratelimit+0x17/0x5d
[8084dd78] notifier_call_chain+0x29/0x4c
[8026083c] _cpu_down+0x18e/0x251
[80260a3d] disable_nonboot_cpus+0x50/0xd7
[8024feb4] kernel_power_off+0x21/0x3a
[802500de] sys_reboot+0xee/0x187
[8024de0a] group_send_sig_info+0x62/0x6f
[8024de64] kill_pid_info+0x4d/0x6b
[8024e5e6] sys_kill+0x70/0x13e
[8084d990] do_page_fault+0x3a9/0x768
[80464205] __up_read+0x13/0x8a
[8084bc39] error_exit+0x0/0x51
[8021ee4b] system_call_after_swapgs+0x7b/0x80
---[ end trace 7098a44b4633d8ed ]---
CPU1 is down
kvm: disabling virtualization on CPU2
CPU 2 is now offline
[ cut here ]
WARNING: at kernel/kthread.c:176 cpu_callback+0x14f/0x177()
Modules linked in:
Pid: 7224, comm: halt Not tainted 2.6.25-rc1-smp-00266-g4ee29f6-dirty #110
Call Trace:
[80243c61] warn_on_slowpath+0x51/0x63
[80257e00] ktime_get_ts+0x3d/0x48
[8023b160] hrtick_start_fair+0xe1/0x129
[8023a049] enqueue_task+0x4d/0x58
[8023ceda] try_to_wake_up+0x1ae/0x1bf
[80848796] cpu_callback+0x14f/0x177
[802747e4] writeback_set_ratelimit+0x17/0x5d
[8084dd78] notifier_call_chain+0x29/0x4c
[8026083c] _cpu_down+0x18e/0x251
[80260a3d] disable_nonboot_cpus+0x50/0xd7
[8024feb4] kernel_power_off+0x21/0x3a
[802500de] sys_reboot+0xee/0x187
[8024de0a] group_send_sig_info+0x62/0x6f
[8024de64] kill_pid_info+0x4d/0x6b
[8024e5e6] sys_kill+0x70/0x13e
[8084d990] do_page_fault+0x3a9/0x768
[80464205] __up_read+0x13/0x8a
[8084bc39] error_exit+0x0/0x51
[8021ee4b] system_call_after_swapgs+0x7b/0x80
---[ end trace 7098a44b4633d8ed ]---
CPU2 is down
kvm: disabling virtualization on CPU3
CPU 3 is now offline
[ cut here ]
WARNING: at
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 11:38:59AM -0800, Yinghai Lu wrote:
On Fri, Feb 15, 2008 at 2:19 AM, Frans Pop [EMAIL PROTECTED] wrote:
On Friday 15 February 2008, Greg KH wrote:
I swear someone sent this patch in before. Can you try this one below,
there seems to be an imbalance with kobject_get and _put.
I did remember seeing this patch before [1] and can confirm that it does
indeed fix the issue: with this patch applied to 2.6.25 git head my system
powers off correctly.
[1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960.
---
drivers/cpufreq/cpufreq.c |8
1 file changed, 8 deletions(-)
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
}
#endif
-
- if (!kobject_get(data-kobj)) {
- spin_unlock_irqrestore(cpufreq_driver_lock, flags);
- cpufreq_debug_enable_ratelimit();
- unlock_policy_rwsem_write(cpu);
- return -EFAULT;
- }
-
#ifdef CONFIG_SMP
#ifdef CONFIG_HOTPLUG_CPU
confirmed, with this patch, i still need disable CONFIG_DETECT_SOFTLOCKUP
Great, thanks for testing and letting us know.
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 04:52:18PM +0800, Jeff Chua wrote: On Fri, Feb 15, 2008 at 2:59 PM, Greg KH [EMAIL PROTECTED] wrote: I swear someone else sent this in, but my archives don't show it at all. I think the patch below should solve this, but I need someone to test it. I tested but it doesn't fix the problem for me. May be my problem is different ... as my X60s just doesn't power-off on suspend-to-disk. My .config says ... # CONFIG_CPU_FREQ is not set # CONFIG_CPU_IDLE is not set On Wed, Feb 13, 2008 at 3:54 PM, Andrew Morton [EMAIL PROTECTED] wrote: due to softlockup changes, and setting CONFIG_DETECT_SOFTLOCKUP=n ... Also, I've tried CONFIG_DETECT_SOFTLOCKUP=n, but this doesn't fix it either. Ok, this looks to be something else. Here's the last dmesg after suspend-to-disk and hang there... CPU 1 is now offline SMP alternatives: switching to UP code PM: Syncing filesystems ... done. Freezing user space processes ... (elapsed 0.00 seconds) done. Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. PM: Shrinking memory... ^H-^Hdone (0 pages freed) PM: Freed 0 kbytes in 0.10 seconds (0.00 MB/s) ACPI: Preparing to enter system sleep state S4 Suspending console(s) [ ... it just hangs here ... press power-switch does the job, and system is able to resume upon powering on ] Wait, this is a suspend-to-disk issue. Totally different than the will not power off issue. Can you start a new thread on this, and add the suspend people to it? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 11:19:20AM +0100, Frans Pop wrote: On Friday 15 February 2008, Greg KH wrote: I swear someone sent this patch in before. Can you try this one below, there seems to be an imbalance with kobject_get and _put. I did remember seeing this patch before [1] and can confirm that it does indeed fix the issue: with this patch applied to 2.6.25 git head my system powers off correctly. [1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960. Ah, thanks, for some reason I couldn't find this in my archives. I'll add this to my queue to go to Linus. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Fri, Feb 15, 2008 at 12:41:43AM -0800, Yinghai Lu wrote: On Thu, Feb 14, 2008 at 10:52 PM, Greg KH [EMAIL PROTECTED] wrote: Ugh, sorry, I was mistaken, it's not a cpufreq issue, it's a CONFIG_DETECT_SOFTLOCKUP issue. Or that is what I was told before. could be two issues: one in cpufreq, and one in detect softlockup... Looks like it's that way :) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wed, Feb 13, 2008 at 07:55:53PM +0100, Rafael J. Wysocki wrote:
> On Wednesday, 13 of February 2008, Greg KH wrote:
> > On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote:
> > > On Tuesday 12 February 2008, Greg KH wrote:
> > > > On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote:
> > > > > On Monday 11 February 2008, Frans Pop wrote:
> > > > > > In general 2.6.25 if looking quite good on my desktop, but there's
> > > > > > one important issue: the system no longer powers off after shutdown.
> > > > > > This works fine with 2.6.24.
> > > > >
> > > > > Don't ask me why, but bisection shows this commit to be the cause of
> > > > > the failure to power off:
> > > > > commit c10997f6575f476ff38442fa18fd4a0d80345f9d
> > > > > Author: Greg Kroah-Hartman <[EMAIL PROTECTED]>
> > > > > Date: Thu Dec 20 08:13:05 2007 -0800
> > > > >
> > > > > Kobject: convert drivers/* from kobject_unregister() to
> > > > > kobject_put()
> > > > >
> > > > > Because it seemed somewhat unlikely, I have double checked this by
> > > > > doing an extra compilation for this commit and its predecessor.
> > > >
> > > > What is the symptom of not powering off?
> > >
> > > I already noticed yesterday that there's one hunk in that commit that's
> > > not
> > > a straight replacement:
> > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > > index 9e102af..5efd555 100644
> > > --- a/drivers/cpufreq/cpufreq.c
> > > +++ b/drivers/cpufreq/cpufreq.c
> > > @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device
> > > * sys_dev)
> > >
> > > unlock_policy_rwsem_write(cpu);
> > >
> > > - kobject_unregister(>kobj);
> > > -
> > > kobject_put(>kobj);
> > >
> > > /* we need to make sure that the underlying kobj is actually
> > >
> > >
> > > So, just on the off chance, I applied the patch below and bingo, the
> > > system
> > > powers off again. I doubt this will be the correct solution, but just in
> > > case it is, here's my signed off. A comment why the double put is needed
> > > would probably be good though.
> >
> > There is a bug in the cpufreq kref logic that makes this "double put"
> > necessary. A real fix has already been posted to solve this issue, and
> > I think it should be on it's way to Linus for -rc2 already.
> >
> > Please let me know if -rc2 comes out without this needed fix.
>
> Can you point me to the fix, please?
I swear someone else sent this in, but my archives don't show it at all.
I think the patch below should solve this, but I need someone to test
it.
thanks,
greg k-h
---
drivers/cpufreq/cpufreq.c |8
1 file changed, 8 deletions(-)
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
}
#endif
-
- if (!kobject_get(>kobj)) {
- spin_unlock_irqrestore(_driver_lock, flags);
- cpufreq_debug_enable_ratelimit();
- unlock_policy_rwsem_write(cpu);
- return -EFAULT;
- }
-
#ifdef CONFIG_SMP
#ifdef CONFIG_HOTPLUG_CPU
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Thu, Feb 14, 2008 at 03:38:13PM -0800, Yinghai Lu wrote:
> On Wed, Feb 13, 2008 at 8:58 AM, Greg KH <[EMAIL PROTECTED]> wrote:
> >
> > On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote:
> > > On Tuesday 12 February 2008, Greg KH wrote:
> > > > On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote:
> > > > > On Monday 11 February 2008, Frans Pop wrote:
> > > > > > In general 2.6.25 if looking quite good on my desktop, but there's
> > > > > > one important issue: the system no longer powers off after
> > shutdown.
> > > > > > This works fine with 2.6.24.
> > > > >
> > > > > Don't ask me why, but bisection shows this commit to be the cause of
> > > > > the failure to power off:
> > > > > commit c10997f6575f476ff38442fa18fd4a0d80345f9d
> > > > > Author: Greg Kroah-Hartman <[EMAIL PROTECTED]>
> > > > > Date: Thu Dec 20 08:13:05 2007 -0800
> > > > >
> > > > > Kobject: convert drivers/* from kobject_unregister() to
> > > > > kobject_put()
> > > > >
> > > > > Because it seemed somewhat unlikely, I have double checked this by
> > > > > doing an extra compilation for this commit and its predecessor.
> > > >
> > > > What is the symptom of not powering off?
> > >
> > > I already noticed yesterday that there's one hunk in that commit that's
> > not
> > > a straight replacement:
> > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > > index 9e102af..5efd555 100644
> > > --- a/drivers/cpufreq/cpufreq.c
> > > +++ b/drivers/cpufreq/cpufreq.c
> > > @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device
> > * sys_dev)
> > >
> > > unlock_policy_rwsem_write(cpu);
> > >
> > > - kobject_unregister(>kobj);
> > > -
> > > kobject_put(>kobj);
> > >
> > > /* we need to make sure that the underlying kobj is actually
> > >
> > >
> > > So, just on the off chance, I applied the patch below and bingo, the
> > system
> > > powers off again. I doubt this will be the correct solution, but just in
> > > case it is, here's my signed off. A comment why the double put is needed
> > > would probably be good though.
> >
> > There is a bug in the cpufreq kref logic that makes this "double put"
> > necessary. A real fix has already been posted to solve this issue, and
> > I think it should be on it's way to Linus for -rc2 already.
> >
> > Please let me know if -rc2 comes out without this needed fix.
>
> after disable cpufreq, i got
>
> ACPI: Preparing to enter system sleep state S5
> Disabling non-boot CPUs ...
> kvm: disabling virtualization on CPU1
> CPU 1 is now offline
> CPU1 is down
> kvm: disabling virtualization on CPU2
> CPU 2 is now offline
> > hang here.
>
> but x86.git/mm could go through down all the cpus
>
> interesting...
I swear someone sent this patch in before. Can you try this one below,
there seems to be an imbalance with kobject_get and _put.
thanks,
greg k-h
---
drivers/cpufreq/cpufreq.c |8
1 file changed, 8 deletions(-)
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
}
#endif
-
- if (!kobject_get(>kobj)) {
- spin_unlock_irqrestore(_driver_lock, flags);
- cpufreq_debug_enable_ratelimit();
- unlock_policy_rwsem_write(cpu);
- return -EFAULT;
- }
-
#ifdef CONFIG_SMP
#ifdef CONFIG_HOTPLUG_CPU
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Thu, Feb 14, 2008 at 03:38:13PM -0800, Yinghai Lu wrote: > On Wed, Feb 13, 2008 at 8:58 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > > > On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote: > > > On Tuesday 12 February 2008, Greg KH wrote: > > > > On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: > > > > > On Monday 11 February 2008, Frans Pop wrote: > > > > > > In general 2.6.25 if looking quite good on my desktop, but there's > > > > > > one important issue: the system no longer powers off after > > shutdown. > > > > > > This works fine with 2.6.24. > > > > > > > > > > Don't ask me why, but bisection shows this commit to be the cause of > > > > > the failure to power off: > > > > > commit c10997f6575f476ff38442fa18fd4a0d80345f9d > > > > > Author: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > > > > Date: Thu Dec 20 08:13:05 2007 -0800 > > > > > > > > > > Kobject: convert drivers/* from kobject_unregister() to > > > > > kobject_put() > > > > > > > > > > Because it seemed somewhat unlikely, I have double checked this by > > > > > doing an extra compilation for this commit and its predecessor. > > > > > > > > What is the symptom of not powering off? > > > > > > I already noticed yesterday that there's one hunk in that commit that's > > not > > > a straight replacement: > > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > > index 9e102af..5efd555 100644 > > > --- a/drivers/cpufreq/cpufreq.c > > > +++ b/drivers/cpufreq/cpufreq.c > > > @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device > > * sys_dev) > > > > > > unlock_policy_rwsem_write(cpu); > > > > > > - kobject_unregister(>kobj); > > > - > > > kobject_put(>kobj); > > > > > > /* we need to make sure that the underlying kobj is actually > > > > > > > > > So, just on the off chance, I applied the patch below and bingo, the > > system > > > powers off again. I doubt this will be the correct solution, but just in > > > case it is, here's my signed off. A comment why the double put is needed > > > would probably be good though. > > > > There is a bug in the cpufreq kref logic that makes this "double put" > > necessary. A real fix has already been posted to solve this issue, and > > I think it should be on it's way to Linus for -rc2 already. > > > > Please let me know if -rc2 comes out without this needed fix. > > after disable cpufreq, i got > > ACPI: Preparing to enter system sleep state S5 > Disabling non-boot CPUs ... > kvm: disabling virtualization on CPU1 > CPU 1 is now offline > CPU1 is down > kvm: disabling virtualization on CPU2 > CPU 2 is now offline > > hang here. > > but x86.git/mm could go through down all the cpus Ugh, sorry, I was mistaken, it's not a cpufreq issue, it's a CONFIG_DETECT_SOFTLOCKUP issue. Or that is what I was told before. But the fact that you fixed the problem with an extra kobject_put() makes me worry. There might be a reference issue still there. I'll look into it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Thu, Feb 14, 2008 at 6:14 PM, Yinghai Lu <[EMAIL PROTECTED]> wrote: > On Thu, Feb 14, 2008 at 3:48 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > * Yinghai Lu <[EMAIL PROTECTED]> wrote: > > > > > after disable cpufreq, i got > > > > > > ACPI: Preparing to enter system sleep state S5 > > > Disabling non-boot CPUs ... > > > kvm: disabling virtualization on CPU1 > > > CPU 1 is now offline > > > CPU1 is down > > > kvm: disabling virtualization on CPU2 > > > CPU 2 is now offline > > > > hang here. > > > > > > but x86.git/mm could go through down all the cpus > > > > > > interesting... > > > > i suspect some kobject related race, and i have the feeling this all is > > timing dependent. > > > > Andrew started seeing reboot hangs roughly around the time when the > > kobject changes went upstream. Given that x86.git had flux in that > > timeframe too i couldnt be sure what caused them. > > it seems only happen > 1. first hang with cpufreq enabled. > 2. reboot to kernel with cpufreq disable will have problem. > > wonder if different cpu freq out sync and next kernel with reboot > doesn't have cpufreq so it > -- with warm reset doesn't do the right job to sync freq again. ACPI: Preparing to enter system sleep state S5 Disabling non-boot CPUs ... kvm: disabling virtualization on CPU1 CPU 1 is now offline 1 2 3 4 5 CPU1 is down kvm: disabling virtualization on CPU2 CPU 2 is now offline 1 2 3 4 5 CPU2 is down kvm: disabling virtualization on CPU3 CPU 3 is now offline > some time later Clocksource tsc unstable (delta = 515397918052 ns) Time: hpet clocksource has been installed. it hangs in raw_notifier_call_chain(_chain, CPU_DEAD | mode, hcpu)== NOTIFY_BAD); there are several nb, not sure which one cause hang. 8 hrtimer.chrtimers_init1505 register_cpu_notifier(_nb); 9 rcuclassic.c __rcu_init570 register_cpu_notifier(_nb); a rcupreempt.c __rcu_init892 register_cpu_notifier(_nb); ===> not used b sched.c migration_init 5951 register_cpu_notifier(_notifier); c softirq.cspawn_ksoftirqd 645 register_cpu_notifier(_nfb); d softlockup.c spawn_softlockup_task 310 register_cpu_notifier(_nfb); e timer.c init_timers 1367 register_cpu_notifier(_nb); f page-writeback.c page_writeback_init 775 register_cpu_notifier(_nb); g page_alloc.c setup_per_cpu_pageset2744 register_cpu_notifier(_notifier); h slab.c kmem_cache_init 1638 register_cpu_notifier(_notifier); ==> not used i slub.c kmem_cache_init 3036 register_cpu_notifier(_notifier); j vmstat.c setup_vmstat 855 register_cpu_notifier(_notifier); k kvm_main.c kvm_init 1328 r = register_cpu_notifier(_cpu_notifier); maybe the one in softlockup.c? YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Thu, Feb 14, 2008 at 3:48 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Yinghai Lu <[EMAIL PROTECTED]> wrote: > > > after disable cpufreq, i got > > > > ACPI: Preparing to enter system sleep state S5 > > Disabling non-boot CPUs ... > > kvm: disabling virtualization on CPU1 > > CPU 1 is now offline > > CPU1 is down > > kvm: disabling virtualization on CPU2 > > CPU 2 is now offline > > > hang here. > > > > but x86.git/mm could go through down all the cpus > > > > interesting... > > i suspect some kobject related race, and i have the feeling this all is > timing dependent. > > Andrew started seeing reboot hangs roughly around the time when the > kobject changes went upstream. Given that x86.git had flux in that > timeframe too i couldnt be sure what caused them. it seems only happen 1. first hang with cpufreq enabled. 2. reboot to kernel with cpufreq disable will have problem. wonder if different cpu freq out sync and next kernel with reboot doesn't have cpufreq so it -- with warm reset doesn't do the right job to sync freq again. Greg, where is patch to fix cpufreq problem? YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Thu, Feb 14, 2008 at 3:48 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
> * Yinghai Lu <[EMAIL PROTECTED]> wrote:
>
> > after disable cpufreq, i got
> >
> > ACPI: Preparing to enter system sleep state S5
> > Disabling non-boot CPUs ...
> > kvm: disabling virtualization on CPU1
> > CPU 1 is now offline
> > CPU1 is down
> > kvm: disabling virtualization on CPU2
> > CPU 2 is now offline
> > > hang here.
> >
> > but x86.git/mm could go through down all the cpus
> >
> > interesting...
>
> i suspect some kobject related race, and i have the feeling this all is
> timing dependent.
>
> Andrew started seeing reboot hangs roughly around the time when the
> kobject changes went upstream. Given that x86.git had flux in that
> timeframe too i couldnt be sure what caused them.
>
> i have the fixlet below in x86.git but it didnt solve Andrew's problem
> so it's parking now at the end of the queue, with no clear purpose in
> life :-) If it would solve someone's problem it might be revitalized.
>
> Note: this does not fix any particular bug i know about, it's just a
> hack.
>
> Ingo
>
> -->
> Subject: x86: highprio shutdown hack
> From: Ingo Molnar <[EMAIL PROTECTED]>
>
> Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
> Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]>
> ---
> arch/x86/kernel/reboot.c | 16 ++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> Index: linux-x86.q/arch/x86/kernel/reboot.c
> ===
> --- linux-x86.q.orig/arch/x86/kernel/reboot.c
> +++ linux-x86.q/arch/x86/kernel/reboot.c
> @@ -396,8 +396,20 @@ static void native_machine_shutdown(void
> if (!cpu_isset(reboot_cpu_id, cpu_online_map))
> reboot_cpu_id = smp_processor_id();
>
> - /* Make certain I only run on the appropriate processor */
> - set_cpus_allowed(current, cpumask_of_cpu(reboot_cpu_id));
> + /*
> +* Make certain we only run on the appropriate processor,
> +* and with sufficient priority:
> +*/
> + {
> + struct sched_param schedparm;
> + int ret;
> +
> + schedparm.sched_priority = 99;
> + ret = sched_setscheduler(current, SCHED_RR, );
> + WARN_ON_ONCE(1);
so I got
[ cut here ]
WARNING: at arch/x86/kernel/reboot.c:409 native_machine_shutdown+0x5f/0xb4()
Modules linked in:
Pid: 7173, comm: reboot Not tainted 2.6.25-rc1-smp-00168-g458504f-dirty #33
Call Trace:
[] warn_on_slowpath+0x64/0x8e
[] enqueue_task+0x5c/0x7e
[] rt_mutex_adjust_pi+0x28/0x94
[] sched_setscheduler+0x304/0x33c
[] native_machine_shutdown+0x5f/0xb4
[] native_machine_restart+0x2e/0x4c
[] sys_reboot+0x140/0x1b2
[] handle_mm_fault+0x380/0x705
[] d_kill+0x50/0x7c
[] do_page_fault+0x3bd/0x7c9
[] __up_read+0x27/0xb5
[] system_call_after_swapgs+0x7b/0x80
---[ end trace eb0e49090acb42b5 ]---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
* Yinghai Lu <[EMAIL PROTECTED]> wrote:
> after disable cpufreq, i got
>
> ACPI: Preparing to enter system sleep state S5
> Disabling non-boot CPUs ...
> kvm: disabling virtualization on CPU1
> CPU 1 is now offline
> CPU1 is down
> kvm: disabling virtualization on CPU2
> CPU 2 is now offline
> > hang here.
>
> but x86.git/mm could go through down all the cpus
>
> interesting...
i suspect some kobject related race, and i have the feeling this all is
timing dependent.
Andrew started seeing reboot hangs roughly around the time when the
kobject changes went upstream. Given that x86.git had flux in that
timeframe too i couldnt be sure what caused them.
i have the fixlet below in x86.git but it didnt solve Andrew's problem
so it's parking now at the end of the queue, with no clear purpose in
life :-) If it would solve someone's problem it might be revitalized.
Note: this does not fix any particular bug i know about, it's just a
hack.
Ingo
-->
Subject: x86: highprio shutdown hack
From: Ingo Molnar <[EMAIL PROTECTED]>
Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]>
---
arch/x86/kernel/reboot.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
Index: linux-x86.q/arch/x86/kernel/reboot.c
===
--- linux-x86.q.orig/arch/x86/kernel/reboot.c
+++ linux-x86.q/arch/x86/kernel/reboot.c
@@ -396,8 +396,20 @@ static void native_machine_shutdown(void
if (!cpu_isset(reboot_cpu_id, cpu_online_map))
reboot_cpu_id = smp_processor_id();
- /* Make certain I only run on the appropriate processor */
- set_cpus_allowed(current, cpumask_of_cpu(reboot_cpu_id));
+ /*
+* Make certain we only run on the appropriate processor,
+* and with sufficient priority:
+*/
+ {
+ struct sched_param schedparm;
+ int ret;
+
+ schedparm.sched_priority = 99;
+ ret = sched_setscheduler(current, SCHED_RR, );
+ WARN_ON_ONCE(1);
+
+ set_cpus_allowed(current, cpumask_of_cpu(reboot_cpu_id));
+ }
/* O.K Now that I'm on the appropriate processor,
* stop all of the others.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wed, Feb 13, 2008 at 8:58 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote: > > On Tuesday 12 February 2008, Greg KH wrote: > > > On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: > > > > On Monday 11 February 2008, Frans Pop wrote: > > > > > In general 2.6.25 if looking quite good on my desktop, but there's > > > > > one important issue: the system no longer powers off after shutdown. > > > > > This works fine with 2.6.24. > > > > > > > > Don't ask me why, but bisection shows this commit to be the cause of > > > > the failure to power off: > > > > commit c10997f6575f476ff38442fa18fd4a0d80345f9d > > > > Author: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > > > Date: Thu Dec 20 08:13:05 2007 -0800 > > > > > > > > Kobject: convert drivers/* from kobject_unregister() to > > > > kobject_put() > > > > > > > > Because it seemed somewhat unlikely, I have double checked this by > > > > doing an extra compilation for this commit and its predecessor. > > > > > > What is the symptom of not powering off? > > > > I already noticed yesterday that there's one hunk in that commit that's not > > a straight replacement: > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > index 9e102af..5efd555 100644 > > --- a/drivers/cpufreq/cpufreq.c > > +++ b/drivers/cpufreq/cpufreq.c > > @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * > sys_dev) > > > > unlock_policy_rwsem_write(cpu); > > > > - kobject_unregister(>kobj); > > - > > kobject_put(>kobj); > > > > /* we need to make sure that the underlying kobj is actually > > > > > > So, just on the off chance, I applied the patch below and bingo, the system > > powers off again. I doubt this will be the correct solution, but just in > > case it is, here's my signed off. A comment why the double put is needed > > would probably be good though. > > There is a bug in the cpufreq kref logic that makes this "double put" > necessary. A real fix has already been posted to solve this issue, and > I think it should be on it's way to Linus for -rc2 already. > > Please let me know if -rc2 comes out without this needed fix. after disable cpufreq, i got ACPI: Preparing to enter system sleep state S5 Disabling non-boot CPUs ... kvm: disabling virtualization on CPU1 CPU 1 is now offline CPU1 is down kvm: disabling virtualization on CPU2 CPU 2 is now offline > hang here. but x86.git/mm could go through down all the cpus interesting... YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wed, Feb 13, 2008 at 8:58 AM, Greg KH [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote: On Tuesday 12 February 2008, Greg KH wrote: On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: On Monday 11 February 2008, Frans Pop wrote: In general 2.6.25 if looking quite good on my desktop, but there's one important issue: the system no longer powers off after shutdown. This works fine with 2.6.24. Don't ask me why, but bisection shows this commit to be the cause of the failure to power off: commit c10997f6575f476ff38442fa18fd4a0d80345f9d Author: Greg Kroah-Hartman [EMAIL PROTECTED] Date: Thu Dec 20 08:13:05 2007 -0800 Kobject: convert drivers/* from kobject_unregister() to kobject_put() Because it seemed somewhat unlikely, I have double checked this by doing an extra compilation for this commit and its predecessor. What is the symptom of not powering off? I already noticed yesterday that there's one hunk in that commit that's not a straight replacement: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 9e102af..5efd555 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev) unlock_policy_rwsem_write(cpu); - kobject_unregister(data-kobj); - kobject_put(data-kobj); /* we need to make sure that the underlying kobj is actually So, just on the off chance, I applied the patch below and bingo, the system powers off again. I doubt this will be the correct solution, but just in case it is, here's my signed off. A comment why the double put is needed would probably be good though. There is a bug in the cpufreq kref logic that makes this double put necessary. A real fix has already been posted to solve this issue, and I think it should be on it's way to Linus for -rc2 already. Please let me know if -rc2 comes out without this needed fix. after disable cpufreq, i got ACPI: Preparing to enter system sleep state S5 Disabling non-boot CPUs ... kvm: disabling virtualization on CPU1 CPU 1 is now offline CPU1 is down kvm: disabling virtualization on CPU2 CPU 2 is now offline hang here. but x86.git/mm could go through down all the cpus interesting... YH -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
* Yinghai Lu [EMAIL PROTECTED] wrote:
after disable cpufreq, i got
ACPI: Preparing to enter system sleep state S5
Disabling non-boot CPUs ...
kvm: disabling virtualization on CPU1
CPU 1 is now offline
CPU1 is down
kvm: disabling virtualization on CPU2
CPU 2 is now offline
hang here.
but x86.git/mm could go through down all the cpus
interesting...
i suspect some kobject related race, and i have the feeling this all is
timing dependent.
Andrew started seeing reboot hangs roughly around the time when the
kobject changes went upstream. Given that x86.git had flux in that
timeframe too i couldnt be sure what caused them.
i have the fixlet below in x86.git but it didnt solve Andrew's problem
so it's parking now at the end of the queue, with no clear purpose in
life :-) If it would solve someone's problem it might be revitalized.
Note: this does not fix any particular bug i know about, it's just a
hack.
Ingo
--
Subject: x86: highprio shutdown hack
From: Ingo Molnar [EMAIL PROTECTED]
Signed-off-by: Ingo Molnar [EMAIL PROTECTED]
Signed-off-by: Thomas Gleixner [EMAIL PROTECTED]
---
arch/x86/kernel/reboot.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
Index: linux-x86.q/arch/x86/kernel/reboot.c
===
--- linux-x86.q.orig/arch/x86/kernel/reboot.c
+++ linux-x86.q/arch/x86/kernel/reboot.c
@@ -396,8 +396,20 @@ static void native_machine_shutdown(void
if (!cpu_isset(reboot_cpu_id, cpu_online_map))
reboot_cpu_id = smp_processor_id();
- /* Make certain I only run on the appropriate processor */
- set_cpus_allowed(current, cpumask_of_cpu(reboot_cpu_id));
+ /*
+* Make certain we only run on the appropriate processor,
+* and with sufficient priority:
+*/
+ {
+ struct sched_param schedparm;
+ int ret;
+
+ schedparm.sched_priority = 99;
+ ret = sched_setscheduler(current, SCHED_RR, schedparm);
+ WARN_ON_ONCE(1);
+
+ set_cpus_allowed(current, cpumask_of_cpu(reboot_cpu_id));
+ }
/* O.K Now that I'm on the appropriate processor,
* stop all of the others.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Thu, Feb 14, 2008 at 3:48 PM, Ingo Molnar [EMAIL PROTECTED] wrote:
* Yinghai Lu [EMAIL PROTECTED] wrote:
after disable cpufreq, i got
ACPI: Preparing to enter system sleep state S5
Disabling non-boot CPUs ...
kvm: disabling virtualization on CPU1
CPU 1 is now offline
CPU1 is down
kvm: disabling virtualization on CPU2
CPU 2 is now offline
hang here.
but x86.git/mm could go through down all the cpus
interesting...
i suspect some kobject related race, and i have the feeling this all is
timing dependent.
Andrew started seeing reboot hangs roughly around the time when the
kobject changes went upstream. Given that x86.git had flux in that
timeframe too i couldnt be sure what caused them.
i have the fixlet below in x86.git but it didnt solve Andrew's problem
so it's parking now at the end of the queue, with no clear purpose in
life :-) If it would solve someone's problem it might be revitalized.
Note: this does not fix any particular bug i know about, it's just a
hack.
Ingo
--
Subject: x86: highprio shutdown hack
From: Ingo Molnar [EMAIL PROTECTED]
Signed-off-by: Ingo Molnar [EMAIL PROTECTED]
Signed-off-by: Thomas Gleixner [EMAIL PROTECTED]
---
arch/x86/kernel/reboot.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
Index: linux-x86.q/arch/x86/kernel/reboot.c
===
--- linux-x86.q.orig/arch/x86/kernel/reboot.c
+++ linux-x86.q/arch/x86/kernel/reboot.c
@@ -396,8 +396,20 @@ static void native_machine_shutdown(void
if (!cpu_isset(reboot_cpu_id, cpu_online_map))
reboot_cpu_id = smp_processor_id();
- /* Make certain I only run on the appropriate processor */
- set_cpus_allowed(current, cpumask_of_cpu(reboot_cpu_id));
+ /*
+* Make certain we only run on the appropriate processor,
+* and with sufficient priority:
+*/
+ {
+ struct sched_param schedparm;
+ int ret;
+
+ schedparm.sched_priority = 99;
+ ret = sched_setscheduler(current, SCHED_RR, schedparm);
+ WARN_ON_ONCE(1);
so I got
[ cut here ]
WARNING: at arch/x86/kernel/reboot.c:409 native_machine_shutdown+0x5f/0xb4()
Modules linked in:
Pid: 7173, comm: reboot Not tainted 2.6.25-rc1-smp-00168-g458504f-dirty #33
Call Trace:
[802521d8] warn_on_slowpath+0x64/0x8e
[802464c8] enqueue_task+0x5c/0x7e
[8027765c] rt_mutex_adjust_pi+0x28/0x94
[8024c075] sched_setscheduler+0x304/0x33c
[80237feb] native_machine_shutdown+0x5f/0xb4
[80237f6e] native_machine_restart+0x2e/0x4c
[8026234b] sys_reboot+0x140/0x1b2
[8029bbd2] handle_mm_fault+0x380/0x705
[802cc311] d_kill+0x50/0x7c
[8097d000] do_page_fault+0x3bd/0x7c9
[804d58ae] __up_read+0x27/0xb5
[8022432b] system_call_after_swapgs+0x7b/0x80
---[ end trace eb0e49090acb42b5 ]---
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Thu, Feb 14, 2008 at 6:14 PM, Yinghai Lu [EMAIL PROTECTED] wrote: On Thu, Feb 14, 2008 at 3:48 PM, Ingo Molnar [EMAIL PROTECTED] wrote: * Yinghai Lu [EMAIL PROTECTED] wrote: after disable cpufreq, i got ACPI: Preparing to enter system sleep state S5 Disabling non-boot CPUs ... kvm: disabling virtualization on CPU1 CPU 1 is now offline CPU1 is down kvm: disabling virtualization on CPU2 CPU 2 is now offline hang here. but x86.git/mm could go through down all the cpus interesting... i suspect some kobject related race, and i have the feeling this all is timing dependent. Andrew started seeing reboot hangs roughly around the time when the kobject changes went upstream. Given that x86.git had flux in that timeframe too i couldnt be sure what caused them. it seems only happen 1. first hang with cpufreq enabled. 2. reboot to kernel with cpufreq disable will have problem. wonder if different cpu freq out sync and next kernel with reboot doesn't have cpufreq so it -- with warm reset doesn't do the right job to sync freq again. ACPI: Preparing to enter system sleep state S5 Disabling non-boot CPUs ... kvm: disabling virtualization on CPU1 CPU 1 is now offline 1 2 3 4 5 CPU1 is down kvm: disabling virtualization on CPU2 CPU 2 is now offline 1 2 3 4 5 CPU2 is down kvm: disabling virtualization on CPU3 CPU 3 is now offline some time later Clocksource tsc unstable (delta = 515397918052 ns) Time: hpet clocksource has been installed. it hangs in raw_notifier_call_chain(cpu_chain, CPU_DEAD | mode, hcpu)== NOTIFY_BAD); there are several nb, not sure which one cause hang. 8 hrtimer.chrtimers_init1505 register_cpu_notifier(hrtimers_nb); 9 rcuclassic.c __rcu_init570 register_cpu_notifier(rcu_nb); a rcupreempt.c __rcu_init892 register_cpu_notifier(rcu_nb); === not used b sched.c migration_init 5951 register_cpu_notifier(migration_notifier); c softirq.cspawn_ksoftirqd 645 register_cpu_notifier(cpu_nfb); d softlockup.c spawn_softlockup_task 310 register_cpu_notifier(cpu_nfb); e timer.c init_timers 1367 register_cpu_notifier(timers_nb); f page-writeback.c page_writeback_init 775 register_cpu_notifier(ratelimit_nb); g page_alloc.c setup_per_cpu_pageset2744 register_cpu_notifier(pageset_notifier); h slab.c kmem_cache_init 1638 register_cpu_notifier(cpucache_notifier); == not used i slub.c kmem_cache_init 3036 register_cpu_notifier(slab_notifier); j vmstat.c setup_vmstat 855 register_cpu_notifier(vmstat_notifier); k kvm_main.c kvm_init 1328 r = register_cpu_notifier(kvm_cpu_notifier); maybe the one in softlockup.c? YH -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Thu, Feb 14, 2008 at 03:38:13PM -0800, Yinghai Lu wrote: On Wed, Feb 13, 2008 at 8:58 AM, Greg KH [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote: On Tuesday 12 February 2008, Greg KH wrote: On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: On Monday 11 February 2008, Frans Pop wrote: In general 2.6.25 if looking quite good on my desktop, but there's one important issue: the system no longer powers off after shutdown. This works fine with 2.6.24. Don't ask me why, but bisection shows this commit to be the cause of the failure to power off: commit c10997f6575f476ff38442fa18fd4a0d80345f9d Author: Greg Kroah-Hartman [EMAIL PROTECTED] Date: Thu Dec 20 08:13:05 2007 -0800 Kobject: convert drivers/* from kobject_unregister() to kobject_put() Because it seemed somewhat unlikely, I have double checked this by doing an extra compilation for this commit and its predecessor. What is the symptom of not powering off? I already noticed yesterday that there's one hunk in that commit that's not a straight replacement: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 9e102af..5efd555 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev) unlock_policy_rwsem_write(cpu); - kobject_unregister(data-kobj); - kobject_put(data-kobj); /* we need to make sure that the underlying kobj is actually So, just on the off chance, I applied the patch below and bingo, the system powers off again. I doubt this will be the correct solution, but just in case it is, here's my signed off. A comment why the double put is needed would probably be good though. There is a bug in the cpufreq kref logic that makes this double put necessary. A real fix has already been posted to solve this issue, and I think it should be on it's way to Linus for -rc2 already. Please let me know if -rc2 comes out without this needed fix. after disable cpufreq, i got ACPI: Preparing to enter system sleep state S5 Disabling non-boot CPUs ... kvm: disabling virtualization on CPU1 CPU 1 is now offline CPU1 is down kvm: disabling virtualization on CPU2 CPU 2 is now offline hang here. but x86.git/mm could go through down all the cpus Ugh, sorry, I was mistaken, it's not a cpufreq issue, it's a CONFIG_DETECT_SOFTLOCKUP issue. Or that is what I was told before. But the fact that you fixed the problem with an extra kobject_put() makes me worry. There might be a reference issue still there. I'll look into it. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Thu, Feb 14, 2008 at 03:38:13PM -0800, Yinghai Lu wrote:
On Wed, Feb 13, 2008 at 8:58 AM, Greg KH [EMAIL PROTECTED] wrote:
On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote:
On Tuesday 12 February 2008, Greg KH wrote:
On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote:
On Monday 11 February 2008, Frans Pop wrote:
In general 2.6.25 if looking quite good on my desktop, but there's
one important issue: the system no longer powers off after
shutdown.
This works fine with 2.6.24.
Don't ask me why, but bisection shows this commit to be the cause of
the failure to power off:
commit c10997f6575f476ff38442fa18fd4a0d80345f9d
Author: Greg Kroah-Hartman [EMAIL PROTECTED]
Date: Thu Dec 20 08:13:05 2007 -0800
Kobject: convert drivers/* from kobject_unregister() to
kobject_put()
Because it seemed somewhat unlikely, I have double checked this by
doing an extra compilation for this commit and its predecessor.
What is the symptom of not powering off?
I already noticed yesterday that there's one hunk in that commit that's
not
a straight replacement:
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 9e102af..5efd555 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device
* sys_dev)
unlock_policy_rwsem_write(cpu);
- kobject_unregister(data-kobj);
-
kobject_put(data-kobj);
/* we need to make sure that the underlying kobj is actually
So, just on the off chance, I applied the patch below and bingo, the
system
powers off again. I doubt this will be the correct solution, but just in
case it is, here's my signed off. A comment why the double put is needed
would probably be good though.
There is a bug in the cpufreq kref logic that makes this double put
necessary. A real fix has already been posted to solve this issue, and
I think it should be on it's way to Linus for -rc2 already.
Please let me know if -rc2 comes out without this needed fix.
after disable cpufreq, i got
ACPI: Preparing to enter system sleep state S5
Disabling non-boot CPUs ...
kvm: disabling virtualization on CPU1
CPU 1 is now offline
CPU1 is down
kvm: disabling virtualization on CPU2
CPU 2 is now offline
hang here.
but x86.git/mm could go through down all the cpus
interesting...
I swear someone sent this patch in before. Can you try this one below,
there seems to be an imbalance with kobject_get and _put.
thanks,
greg k-h
---
drivers/cpufreq/cpufreq.c |8
1 file changed, 8 deletions(-)
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
}
#endif
-
- if (!kobject_get(data-kobj)) {
- spin_unlock_irqrestore(cpufreq_driver_lock, flags);
- cpufreq_debug_enable_ratelimit();
- unlock_policy_rwsem_write(cpu);
- return -EFAULT;
- }
-
#ifdef CONFIG_SMP
#ifdef CONFIG_HOTPLUG_CPU
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wed, Feb 13, 2008 at 07:55:53PM +0100, Rafael J. Wysocki wrote:
On Wednesday, 13 of February 2008, Greg KH wrote:
On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote:
On Tuesday 12 February 2008, Greg KH wrote:
On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote:
On Monday 11 February 2008, Frans Pop wrote:
In general 2.6.25 if looking quite good on my desktop, but there's
one important issue: the system no longer powers off after shutdown.
This works fine with 2.6.24.
Don't ask me why, but bisection shows this commit to be the cause of
the failure to power off:
commit c10997f6575f476ff38442fa18fd4a0d80345f9d
Author: Greg Kroah-Hartman [EMAIL PROTECTED]
Date: Thu Dec 20 08:13:05 2007 -0800
Kobject: convert drivers/* from kobject_unregister() to
kobject_put()
Because it seemed somewhat unlikely, I have double checked this by
doing an extra compilation for this commit and its predecessor.
What is the symptom of not powering off?
I already noticed yesterday that there's one hunk in that commit that's
not
a straight replacement:
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 9e102af..5efd555 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device
* sys_dev)
unlock_policy_rwsem_write(cpu);
- kobject_unregister(data-kobj);
-
kobject_put(data-kobj);
/* we need to make sure that the underlying kobj is actually
So, just on the off chance, I applied the patch below and bingo, the
system
powers off again. I doubt this will be the correct solution, but just in
case it is, here's my signed off. A comment why the double put is needed
would probably be good though.
There is a bug in the cpufreq kref logic that makes this double put
necessary. A real fix has already been posted to solve this issue, and
I think it should be on it's way to Linus for -rc2 already.
Please let me know if -rc2 comes out without this needed fix.
Can you point me to the fix, please?
I swear someone else sent this in, but my archives don't show it at all.
I think the patch below should solve this, but I need someone to test
it.
thanks,
greg k-h
---
drivers/cpufreq/cpufreq.c |8
1 file changed, 8 deletions(-)
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
}
#endif
-
- if (!kobject_get(data-kobj)) {
- spin_unlock_irqrestore(cpufreq_driver_lock, flags);
- cpufreq_debug_enable_ratelimit();
- unlock_policy_rwsem_write(cpu);
- return -EFAULT;
- }
-
#ifdef CONFIG_SMP
#ifdef CONFIG_HOTPLUG_CPU
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wednesday 13 February 2008, Greg KH wrote: > > So, just on the off chance, I applied the patch below and bingo, the > > system powers off again. I doubt this will be the correct solution, but > > just in case it is, here's my signed off. A comment why the double put > > is needed would probably be good though. > > There is a bug in the cpufreq kref logic that makes this "double put" > necessary. A real fix has already been posted to solve this issue, and > I think it should be on it's way to Linus for -rc2 already. OK, great. Do you think that #6879 could be caused by a similar issue elsewhere in the tree? Can you give me some pointers on how I could find out (debugging to enable, instrumentation to add)? > Please let me know if -rc2 comes out without this needed fix. Will do. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wednesday, 13 of February 2008, Greg KH wrote: > On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote: > > On Tuesday 12 February 2008, Greg KH wrote: > > > On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: > > > > On Monday 11 February 2008, Frans Pop wrote: > > > > > In general 2.6.25 if looking quite good on my desktop, but there's > > > > > one important issue: the system no longer powers off after shutdown. > > > > > This works fine with 2.6.24. > > > > > > > > Don't ask me why, but bisection shows this commit to be the cause of > > > > the failure to power off: > > > > commit c10997f6575f476ff38442fa18fd4a0d80345f9d > > > > Author: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > > > Date: Thu Dec 20 08:13:05 2007 -0800 > > > > > > > > Kobject: convert drivers/* from kobject_unregister() to > > > > kobject_put() > > > > > > > > Because it seemed somewhat unlikely, I have double checked this by > > > > doing an extra compilation for this commit and its predecessor. > > > > > > What is the symptom of not powering off? > > > > I already noticed yesterday that there's one hunk in that commit that's not > > a straight replacement: > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > index 9e102af..5efd555 100644 > > --- a/drivers/cpufreq/cpufreq.c > > +++ b/drivers/cpufreq/cpufreq.c > > @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * > > sys_dev) > > > > unlock_policy_rwsem_write(cpu); > > > > - kobject_unregister(>kobj); > > - > > kobject_put(>kobj); > > > > /* we need to make sure that the underlying kobj is actually > > > > > > So, just on the off chance, I applied the patch below and bingo, the system > > powers off again. I doubt this will be the correct solution, but just in > > case it is, here's my signed off. A comment why the double put is needed > > would probably be good though. > > There is a bug in the cpufreq kref logic that makes this "double put" > necessary. A real fix has already been posted to solve this issue, and > I think it should be on it's way to Linus for -rc2 already. > > Please let me know if -rc2 comes out without this needed fix. Can you point me to the fix, please? Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote: > On Tuesday 12 February 2008, Greg KH wrote: > > On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: > > > On Monday 11 February 2008, Frans Pop wrote: > > > > In general 2.6.25 if looking quite good on my desktop, but there's > > > > one important issue: the system no longer powers off after shutdown. > > > > This works fine with 2.6.24. > > > > > > Don't ask me why, but bisection shows this commit to be the cause of > > > the failure to power off: > > > commit c10997f6575f476ff38442fa18fd4a0d80345f9d > > > Author: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > > Date: Thu Dec 20 08:13:05 2007 -0800 > > > > > > Kobject: convert drivers/* from kobject_unregister() to > > > kobject_put() > > > > > > Because it seemed somewhat unlikely, I have double checked this by > > > doing an extra compilation for this commit and its predecessor. > > > > What is the symptom of not powering off? > > I already noticed yesterday that there's one hunk in that commit that's not > a straight replacement: > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 9e102af..5efd555 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * > sys_dev) > > unlock_policy_rwsem_write(cpu); > > - kobject_unregister(>kobj); > - > kobject_put(>kobj); > > /* we need to make sure that the underlying kobj is actually > > > So, just on the off chance, I applied the patch below and bingo, the system > powers off again. I doubt this will be the correct solution, but just in > case it is, here's my signed off. A comment why the double put is needed > would probably be good though. There is a bug in the cpufreq kref logic that makes this "double put" necessary. A real fix has already been posted to solve this issue, and I think it should be on it's way to Linus for -rc2 already. Please let me know if -rc2 comes out without this needed fix. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Tuesday 12 February 2008, Greg KH wrote: > On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: > > On Monday 11 February 2008, Frans Pop wrote: > > > In general 2.6.25 if looking quite good on my desktop, but there's > > > one important issue: the system no longer powers off after shutdown. > > > This works fine with 2.6.24. > > > > Don't ask me why, but bisection shows this commit to be the cause of > > the failure to power off: > > commit c10997f6575f476ff38442fa18fd4a0d80345f9d > > Author: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > Date: Thu Dec 20 08:13:05 2007 -0800 > > > > Kobject: convert drivers/* from kobject_unregister() to > > kobject_put() > > > > Because it seemed somewhat unlikely, I have double checked this by > > doing an extra compilation for this commit and its predecessor. > > What is the symptom of not powering off? I already noticed yesterday that there's one hunk in that commit that's not a straight replacement: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 9e102af..5efd555 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev) unlock_policy_rwsem_write(cpu); - kobject_unregister(>kobj); - kobject_put(>kobj); /* we need to make sure that the underlying kobj is actually So, just on the off chance, I applied the patch below and bingo, the system powers off again. I doubt this will be the correct solution, but just in case it is, here's my signed off. A comment why the double put is needed would probably be good though. Signed-off-by: Frans Pop <[EMAIL PROTECTED]> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 64926aa..9dbaac6 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1058,6 +1058,7 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev) unlock_policy_rwsem_write(cpu); kobject_put(>kobj); + kobject_put(>kobj); /* we need to make sure that the underlying kobj is actually * not referenced anymore by anybody before we proceed with -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wednesday 13 February 2008, you wrote: > On Tue, 12 Feb 2008 22:45:09 +0100 Frans Pop <[EMAIL PROTECTED]> wrote: > > Symptom is that the system shuts down normally and completely, it just > > does not power off. > > I've been struggling with an identically-manifesting regression on one of > my test machines for a week. It's due to softlockup changes, and setting > CONFIG_DETECT_SOFTLOCKUP=n "fixes" it. > > It sounds unlikely, but I'd suggest that you see if it's the same on your > machine so we're not both chasing the same bug. Unsetting CONFIG_DETECT_SOFTLOCKUP does not help in my case, but thanks for the suggestion. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Feb 13, 2008 3:54 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Tue, 12 Feb 2008 22:45:09 +0100 Frans Pop <[EMAIL PROTECTED]> wrote: > > > Symptom is that the system shuts down normally and completely, it just does > > not power off. > > I've been struggling with an identically-manifesting regression on one of > my test machines for a week. It's due to softlockup changes, and setting > CONFIG_DETECT_SOFTLOCKUP=n "fixes" it. I don't have CONFIG_DETECT_SOFTLOCKUP defined in .config and there's not option using menuconfig to select this. I don't know whether my problem is related or not on Lenovo X60s. I can power-off on shutdown and suspend-to-ram, but screen turns green, and doesn't power-off on suspend-to-disk. I've to manually press and hold the power switch to switch off. System is able to resume later. It was working as recent as last week, but something changed past few days. Jeff. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Feb 13, 2008 3:54 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 12 Feb 2008 22:45:09 +0100 Frans Pop [EMAIL PROTECTED] wrote: Symptom is that the system shuts down normally and completely, it just does not power off. I've been struggling with an identically-manifesting regression on one of my test machines for a week. It's due to softlockup changes, and setting CONFIG_DETECT_SOFTLOCKUP=n fixes it. I don't have CONFIG_DETECT_SOFTLOCKUP defined in .config and there's not option using menuconfig to select this. I don't know whether my problem is related or not on Lenovo X60s. I can power-off on shutdown and suspend-to-ram, but screen turns green, and doesn't power-off on suspend-to-disk. I've to manually press and hold the power switch to switch off. System is able to resume later. It was working as recent as last week, but something changed past few days. Jeff. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wednesday 13 February 2008, you wrote: On Tue, 12 Feb 2008 22:45:09 +0100 Frans Pop [EMAIL PROTECTED] wrote: Symptom is that the system shuts down normally and completely, it just does not power off. I've been struggling with an identically-manifesting regression on one of my test machines for a week. It's due to softlockup changes, and setting CONFIG_DETECT_SOFTLOCKUP=n fixes it. It sounds unlikely, but I'd suggest that you see if it's the same on your machine so we're not both chasing the same bug. Unsetting CONFIG_DETECT_SOFTLOCKUP does not help in my case, but thanks for the suggestion. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Tuesday 12 February 2008, Greg KH wrote: On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: On Monday 11 February 2008, Frans Pop wrote: In general 2.6.25 if looking quite good on my desktop, but there's one important issue: the system no longer powers off after shutdown. This works fine with 2.6.24. Don't ask me why, but bisection shows this commit to be the cause of the failure to power off: commit c10997f6575f476ff38442fa18fd4a0d80345f9d Author: Greg Kroah-Hartman [EMAIL PROTECTED] Date: Thu Dec 20 08:13:05 2007 -0800 Kobject: convert drivers/* from kobject_unregister() to kobject_put() Because it seemed somewhat unlikely, I have double checked this by doing an extra compilation for this commit and its predecessor. What is the symptom of not powering off? I already noticed yesterday that there's one hunk in that commit that's not a straight replacement: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 9e102af..5efd555 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev) unlock_policy_rwsem_write(cpu); - kobject_unregister(data-kobj); - kobject_put(data-kobj); /* we need to make sure that the underlying kobj is actually So, just on the off chance, I applied the patch below and bingo, the system powers off again. I doubt this will be the correct solution, but just in case it is, here's my signed off. A comment why the double put is needed would probably be good though. Signed-off-by: Frans Pop [EMAIL PROTECTED] diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 64926aa..9dbaac6 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1058,6 +1058,7 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev) unlock_policy_rwsem_write(cpu); kobject_put(data-kobj); + kobject_put(data-kobj); /* we need to make sure that the underlying kobj is actually * not referenced anymore by anybody before we proceed with -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote: On Tuesday 12 February 2008, Greg KH wrote: On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: On Monday 11 February 2008, Frans Pop wrote: In general 2.6.25 if looking quite good on my desktop, but there's one important issue: the system no longer powers off after shutdown. This works fine with 2.6.24. Don't ask me why, but bisection shows this commit to be the cause of the failure to power off: commit c10997f6575f476ff38442fa18fd4a0d80345f9d Author: Greg Kroah-Hartman [EMAIL PROTECTED] Date: Thu Dec 20 08:13:05 2007 -0800 Kobject: convert drivers/* from kobject_unregister() to kobject_put() Because it seemed somewhat unlikely, I have double checked this by doing an extra compilation for this commit and its predecessor. What is the symptom of not powering off? I already noticed yesterday that there's one hunk in that commit that's not a straight replacement: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 9e102af..5efd555 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev) unlock_policy_rwsem_write(cpu); - kobject_unregister(data-kobj); - kobject_put(data-kobj); /* we need to make sure that the underlying kobj is actually So, just on the off chance, I applied the patch below and bingo, the system powers off again. I doubt this will be the correct solution, but just in case it is, here's my signed off. A comment why the double put is needed would probably be good though. There is a bug in the cpufreq kref logic that makes this double put necessary. A real fix has already been posted to solve this issue, and I think it should be on it's way to Linus for -rc2 already. Please let me know if -rc2 comes out without this needed fix. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wednesday, 13 of February 2008, Greg KH wrote: On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote: On Tuesday 12 February 2008, Greg KH wrote: On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: On Monday 11 February 2008, Frans Pop wrote: In general 2.6.25 if looking quite good on my desktop, but there's one important issue: the system no longer powers off after shutdown. This works fine with 2.6.24. Don't ask me why, but bisection shows this commit to be the cause of the failure to power off: commit c10997f6575f476ff38442fa18fd4a0d80345f9d Author: Greg Kroah-Hartman [EMAIL PROTECTED] Date: Thu Dec 20 08:13:05 2007 -0800 Kobject: convert drivers/* from kobject_unregister() to kobject_put() Because it seemed somewhat unlikely, I have double checked this by doing an extra compilation for this commit and its predecessor. What is the symptom of not powering off? I already noticed yesterday that there's one hunk in that commit that's not a straight replacement: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 9e102af..5efd555 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev) unlock_policy_rwsem_write(cpu); - kobject_unregister(data-kobj); - kobject_put(data-kobj); /* we need to make sure that the underlying kobj is actually So, just on the off chance, I applied the patch below and bingo, the system powers off again. I doubt this will be the correct solution, but just in case it is, here's my signed off. A comment why the double put is needed would probably be good though. There is a bug in the cpufreq kref logic that makes this double put necessary. A real fix has already been posted to solve this issue, and I think it should be on it's way to Linus for -rc2 already. Please let me know if -rc2 comes out without this needed fix. Can you point me to the fix, please? Thanks, Rafael -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Wednesday 13 February 2008, Greg KH wrote: So, just on the off chance, I applied the patch below and bingo, the system powers off again. I doubt this will be the correct solution, but just in case it is, here's my signed off. A comment why the double put is needed would probably be good though. There is a bug in the cpufreq kref logic that makes this double put necessary. A real fix has already been posted to solve this issue, and I think it should be on it's way to Linus for -rc2 already. OK, great. Do you think that #6879 could be caused by a similar issue elsewhere in the tree? Can you give me some pointers on how I could find out (debugging to enable, instrumentation to add)? Please let me know if -rc2 comes out without this needed fix. Will do. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Tue, 12 Feb 2008 22:45:09 +0100 Frans Pop <[EMAIL PROTECTED]> wrote: > Symptom is that the system shuts down normally and completely, it just does > not power off. I've been struggling with an identically-manifesting regression on one of my test machines for a week. It's due to softlockup changes, and setting CONFIG_DETECT_SOFTLOCKUP=n "fixes" it. It sounds unlikely, but I'd suggest that you see if it's the same on your machine so we're not both chasing the same bug. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Tuesday 12 February 2008, Greg KH wrote: > On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: > > On Monday 11 February 2008, Frans Pop wrote: > > > In general 2.6.25 if looking quite good on my desktop, but there's > > > one important issue: the system no longer powers off after shutdown. > > > This works fine with 2.6.24. > > > > Don't ask me why, but bisection shows this commit to be the cause of > > the failure to power off: > > commit c10997f6575f476ff38442fa18fd4a0d80345f9d > > Author: Greg Kroah-Hartman <[EMAIL PROTECTED]> > > Date: Thu Dec 20 08:13:05 2007 -0800 > > > > Kobject: convert drivers/* from kobject_unregister() to > > kobject_put() > > > > Because it seemed somewhat unlikely, I have double checked this by > > doing an extra compilation for this commit and its predecessor. > > What is the symptom of not powering off? Symptom is that the system shuts down normally and completely, it just does not power off. Here are the last messages on the console: Will now halt. sd 1:0:0:0: [sdb] Synchronizing SCSI cache sd 1:0:0:0: [sdb] Stopping disk sd 0:0:0:0: [sda] Synchronizing SCSI cache sd 0:0:0:0: [sda] Stopping disk ACPI: PCI interrupt for device :01:00.0 disabled Disabling non-boot CPUs ... > Can you press SysRq-T and see a task list running and waiting when > things should be shut down? The system does not respond to that anymore. > Do you happen to have a USB storage stick plugged into the system? Nothing. Only USB kbd/mouse. Note that I've had this issue before with this box: http://bugzilla.kernel.org/show_bug.cgi?id=6879 Somehow it disappeared when I pulled the extra video card that came with the system (no decent driver for it, so no loss). Since then the system has always powered off completely reliably. This time it is a clear and reproducible regression. If we can solve this one we might get a better handle on #6879 too. Cheers, FJP -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: > (Resending full details as I can't find my previous mail in the archives.) > > On Monday 11 February 2008, Frans Pop wrote: > > In general 2.6.25 if looking quite good on my desktop, but there's one > > important issue: the system no longer powers off after shutdown. > > This works fine with 2.6.24. > > Don't ask me why, but bisection shows this commit to be the cause of the > failure to power off: > commit c10997f6575f476ff38442fa18fd4a0d80345f9d > Author: Greg Kroah-Hartman <[EMAIL PROTECTED]> > Date: Thu Dec 20 08:13:05 2007 -0800 > > Kobject: convert drivers/* from kobject_unregister() to kobject_put() > > Because it seemed somewhat unlikely, I have double checked this by doing an > extra compilation for this commit and its predecessor. What is the symptom of not powering off? Can you press SysRq-T and see a task list running and waiting when things should be shut down? Do you happen to have a USB storage stick plugged into the system? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Tuesday 12 February 2008, Greg KH wrote: On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote: On Monday 11 February 2008, Frans Pop wrote: In general 2.6.25 if looking quite good on my desktop, but there's one important issue: the system no longer powers off after shutdown. This works fine with 2.6.24. Don't ask me why, but bisection shows this commit to be the cause of the failure to power off: commit c10997f6575f476ff38442fa18fd4a0d80345f9d Author: Greg Kroah-Hartman [EMAIL PROTECTED] Date: Thu Dec 20 08:13:05 2007 -0800 Kobject: convert drivers/* from kobject_unregister() to kobject_put() Because it seemed somewhat unlikely, I have double checked this by doing an extra compilation for this commit and its predecessor. What is the symptom of not powering off? Symptom is that the system shuts down normally and completely, it just does not power off. Here are the last messages on the console: Will now halt. sd 1:0:0:0: [sdb] Synchronizing SCSI cache sd 1:0:0:0: [sdb] Stopping disk sd 0:0:0:0: [sda] Synchronizing SCSI cache sd 0:0:0:0: [sda] Stopping disk ACPI: PCI interrupt for device :01:00.0 disabled Disabling non-boot CPUs ... Can you press SysRq-T and see a task list running and waiting when things should be shut down? The system does not respond to that anymore. Do you happen to have a USB storage stick plugged into the system? Nothing. Only USB kbd/mouse. Note that I've had this issue before with this box: http://bugzilla.kernel.org/show_bug.cgi?id=6879 Somehow it disappeared when I pulled the extra video card that came with the system (no decent driver for it, so no loss). Since then the system has always powered off completely reliably. This time it is a clear and reproducible regression. If we can solve this one we might get a better handle on #6879 too. Cheers, FJP -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6.25-rc1] System no longer powers off after shutdown
On Tue, 12 Feb 2008 22:45:09 +0100 Frans Pop [EMAIL PROTECTED] wrote: Symptom is that the system shuts down normally and completely, it just does not power off. I've been struggling with an identically-manifesting regression on one of my test machines for a week. It's due to softlockup changes, and setting CONFIG_DETECT_SOFTLOCKUP=n fixes it. It sounds unlikely, but I'd suggest that you see if it's the same on your machine so we're not both chasing the same bug. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
