Re: Fwd: [4/5] 2.6.21-rc5: known regressions
Hi! > Pavel, > fixed in -rc5? Yes, I did quick test and then some more testing, and it seems gone. > Subject: s2ram autowake regression (ACPI?) > References : http://lkml.org/lkml/2007/3/20/96 > Submitter : Pavel Machek <[EMAIL PROTECTED]> > Handled-By : Len Brown <[EMAIL PROTECTED]> > Status : submitter was asked to test a patch Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Fwd: [4/5] 2.6.21-rc5: known regressions
Hi! Pavel, fixed in -rc5? Yes, I did quick test and then some more testing, and it seems gone. Subject: s2ram autowake regression (ACPI?) References : http://lkml.org/lkml/2007/3/20/96 Submitter : Pavel Machek [EMAIL PROTECTED] Handled-By : Len Brown [EMAIL PROTECTED] Status : submitter was asked to test a patch Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > PM: Writing back config space on device :15:00.0 at offset 4 (was 0, > writing e430) > PM: Writing back config space on device :15:00.0 at offset 3 (was 2, > writing 2a820) > PM: Writing back config space on device :15:00.0 at offset 1 (was > 210, writing 217) > system 00:00: resuming <-- [ hard hang ] > pnp 00:01: resuming > system 00:02: resuming > pnp 00:03: resuming ok, this was a red herring: the hard hang was an effect of netconsole combined with CONFIG_DISABLE_CONSOLE_SUSPEND. Disabling netconsole solved it. I'll now re-test Eric's MSI patch. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > entry = get_irq_msi(dev->irq); > pos = entry->msi_attrib.pos; < crash on NULL dereference > > > i.e. 'entry' is NULL after get_irq_msi(). (i can see the crash only on > the VGA screen so no dump of it available. Can write down more info if > it's helpful.) > > I have tried Eric's patch above but now i always get a hang after > "system 00:00: resuming", already upon the first suspend-resume. Not > even the NMI watchdog can get the system out of that hang. find below the PM log of a successful suspend/resume cycle. (I've marked the place that hangs with '[hard hang]') Ingo > PM: Preparing system for mem sleep Stopping tasks ... done. psmouse serio2: suspend psmouse serio1: suspend atkbd serio0: suspend i8042 i8042: suspend sd 0:0:0:0: suspend ide 0.0: suspend serial8250 serial8250: suspend platform vesafb.0: suspend pci_express :00:1c.3:pcie03: suspend pci_express :00:1c.3:pcie02: suspend pci_express :00:1c.3:pcie00: suspend pci_express :00:1c.2:pcie03: suspend pci_express :00:1c.2:pcie02: suspend pci_express :00:1c.2:pcie00: suspend pci_express :00:1c.1:pcie03: suspend pci_express :00:1c.1:pcie02: suspend pci_express :00:1c.1:pcie00: suspend pci_express :00:1c.0:pcie03: suspend pci_express :00:1c.0:pcie02: suspend pci_express :00:1c.0:pcie00: suspend platform pcspkr: suspend pnp 00:0a: suspend i8042 aux 00:09: suspend i8042 kbd 00:08: suspend pnp 00:07: suspend pnp 00:06: suspend pnp 00:05: suspend pnp 00:04: suspend pnp 00:03: suspend system 00:02: suspend pnp 00:01: suspend system 00:00: suspend yenta_cardbus :15:00.0: suspend pci :03:00.0: suspend e1000 :02:00.0: suspend pci :03:00.0: resuming yenta_cardbus :15:00.0: resuming PM: Writing back config space on device :15:00.0 at offset f (was 34001ff, writing 5c0010b) PM: Writing back config space on device :15:00.0 at offset e (was 0, writing 94fc) PM: Writing back config space on device :15:00.0 at offset d (was 0, writing 9400) PM: Writing back config space on device :15:00.0 at offset c (was 0, writing 90fc) PM: Writing back config space on device :15:00.0 at offset b (was 0, writing 9000) PM: Writing back config space on device :15:00.0 at offset a (was 0, writing 8bfff000) PM: Writing back config space on device :15:00.0 at offset 9 (was 0, writing 8800) PM: Writing back config space on device :15:00.0 at offset 8 (was 0, writing e3fff000) PM: Writing back config space on device :15:00.0 at offset 7 (was 0, writing e000) PM: Writing back config space on device :15:00.0 at offset 6 (was 0, writing b0171615) PM: Writing back config space on device :15:00.0 at offset 4 (was 0, writing e430) PM: Writing back config space on device :15:00.0 at offset 3 (was 2, writing 2a820) PM: Writing back config space on device :15:00.0 at offset 1 (was 210, writing 217) system 00:00: resuming <-- [ hard hang ] pnp 00:01: resuming system 00:02: resuming pnp 00:03: resuming pnp 00:04: resuming pnp 00:05: resuming pnp 00:06: resuming pnp 00:07: resuming i8042 kbd 00:08: resuming i8042 aux 00:09: resuming pnp 00:0a: resuming platform pcspkr: resuming pci_express :00:1c.0:pcie00: resuming pci_express :00:1c.0:pcie02: resuming pci_express :00:1c.0:pcie03: resuming pci_express :00:1c.1:pcie00: resuming pci_express :00:1c.1:pcie02: resuming pci_express :00:1c.1:pcie03: resuming pci_express :00:1c.2:pcie00: resuming pci_express :00:1c.2:pcie02: resuming pci_express :00:1c.2:pcie03: resuming pci_express :00:1c.3:pcie00: resuming pci_express :00:1c.3:pcie02: resuming pci_express :00:1c.3:pcie03: resuming platform vesafb.0: resuming serial8250 serial8250: resuming ide 0.0: resuming sd 0:0:0:0: resuming i8042 i8042: resuming atkbd serio0: resuming psmouse serio1: resuming ata2: SATA link down (SStatus 0 SControl 0) ata3: SATA link down (SStatus 0 SControl 0) ata4: SATA link down (SStatus 0 SControl 0) psmouse serio2: resuming ata1: waiting for device to spin up (7 secs) Restarting tasks ... done. e1000: eth0: e1000_watchdog: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300) ata1.00: configured for UDMA/100 SCSI device sda: 156301488 512-byte hdwr sectors (80026 MB) sda: Write Protect is off sda: Mode Sense: 00 3a 00 00 SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA PM: Preparing system for mem sleep - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
* Adrian Bunk <[EMAIL PROTECTED]> wrote:
> Subject: second suspend to disk in a row results in an oops (MSI)
> References : http://lkml.org/lkml/2007/3/17/43
> http://lkml.org/lkml/2007/3/22/150
> http://lkml.org/lkml/2007/3/26/205
> http://lkml.org/lkml/2007/3/26/76
> Submitter : Thomas Meyer <[EMAIL PROTECTED]>
> Frédéric Riss <[EMAIL PROTECTED]>
> Marcus Better <[EMAIL PROTECTED]>
> Handled-By : Eric W. Biederman <[EMAIL PROTECTED]>
> Patch : http://lkml.org/lkml/2007/3/24/136
> Status : patch was suggested
i can reproduce a crash on the second suspend-to-ram, on a T60. I get a
crash here:
#ifdef CONFIG_PM
static void __pci_restore_msi_state(struct pci_dev *dev)
{
int pos;
u16 control;
struct msi_desc *entry;
if (!dev->msi_enabled)
return;
entry = get_irq_msi(dev->irq);
pos = entry->msi_attrib.pos; < crash on NULL dereference
i.e. 'entry' is NULL after get_irq_msi(). (i can see the crash only on
the VGA screen so no dump of it available. Can write down more info if
it's helpful.)
I have tried Eric's patch above but now i always get a hang after
"system 00:00: resuming", already upon the first suspend-resume. Not
even the NMI watchdog can get the system out of that hang.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
* Adrian Bunk [EMAIL PROTECTED] wrote:
Subject: second suspend to disk in a row results in an oops (MSI)
References : http://lkml.org/lkml/2007/3/17/43
http://lkml.org/lkml/2007/3/22/150
http://lkml.org/lkml/2007/3/26/205
http://lkml.org/lkml/2007/3/26/76
Submitter : Thomas Meyer [EMAIL PROTECTED]
Frédéric Riss [EMAIL PROTECTED]
Marcus Better [EMAIL PROTECTED]
Handled-By : Eric W. Biederman [EMAIL PROTECTED]
Patch : http://lkml.org/lkml/2007/3/24/136
Status : patch was suggested
i can reproduce a crash on the second suspend-to-ram, on a T60. I get a
crash here:
#ifdef CONFIG_PM
static void __pci_restore_msi_state(struct pci_dev *dev)
{
int pos;
u16 control;
struct msi_desc *entry;
if (!dev-msi_enabled)
return;
entry = get_irq_msi(dev-irq);
pos = entry-msi_attrib.pos; crash on NULL dereference
i.e. 'entry' is NULL after get_irq_msi(). (i can see the crash only on
the VGA screen so no dump of it available. Can write down more info if
it's helpful.)
I have tried Eric's patch above but now i always get a hang after
system 00:00: resuming, already upon the first suspend-resume. Not
even the NMI watchdog can get the system out of that hang.
Ingo
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
* Ingo Molnar [EMAIL PROTECTED] wrote: entry = get_irq_msi(dev-irq); pos = entry-msi_attrib.pos; crash on NULL dereference i.e. 'entry' is NULL after get_irq_msi(). (i can see the crash only on the VGA screen so no dump of it available. Can write down more info if it's helpful.) I have tried Eric's patch above but now i always get a hang after system 00:00: resuming, already upon the first suspend-resume. Not even the NMI watchdog can get the system out of that hang. find below the PM log of a successful suspend/resume cycle. (I've marked the place that hangs with '[hard hang]') Ingo PM: Preparing system for mem sleep Stopping tasks ... done. psmouse serio2: suspend psmouse serio1: suspend atkbd serio0: suspend i8042 i8042: suspend sd 0:0:0:0: suspend ide 0.0: suspend serial8250 serial8250: suspend platform vesafb.0: suspend pci_express :00:1c.3:pcie03: suspend pci_express :00:1c.3:pcie02: suspend pci_express :00:1c.3:pcie00: suspend pci_express :00:1c.2:pcie03: suspend pci_express :00:1c.2:pcie02: suspend pci_express :00:1c.2:pcie00: suspend pci_express :00:1c.1:pcie03: suspend pci_express :00:1c.1:pcie02: suspend pci_express :00:1c.1:pcie00: suspend pci_express :00:1c.0:pcie03: suspend pci_express :00:1c.0:pcie02: suspend pci_express :00:1c.0:pcie00: suspend platform pcspkr: suspend pnp 00:0a: suspend i8042 aux 00:09: suspend i8042 kbd 00:08: suspend pnp 00:07: suspend pnp 00:06: suspend pnp 00:05: suspend pnp 00:04: suspend pnp 00:03: suspend system 00:02: suspend pnp 00:01: suspend system 00:00: suspend yenta_cardbus :15:00.0: suspend pci :03:00.0: suspend e1000 :02:00.0: suspend pci :03:00.0: resuming yenta_cardbus :15:00.0: resuming PM: Writing back config space on device :15:00.0 at offset f (was 34001ff, writing 5c0010b) PM: Writing back config space on device :15:00.0 at offset e (was 0, writing 94fc) PM: Writing back config space on device :15:00.0 at offset d (was 0, writing 9400) PM: Writing back config space on device :15:00.0 at offset c (was 0, writing 90fc) PM: Writing back config space on device :15:00.0 at offset b (was 0, writing 9000) PM: Writing back config space on device :15:00.0 at offset a (was 0, writing 8bfff000) PM: Writing back config space on device :15:00.0 at offset 9 (was 0, writing 8800) PM: Writing back config space on device :15:00.0 at offset 8 (was 0, writing e3fff000) PM: Writing back config space on device :15:00.0 at offset 7 (was 0, writing e000) PM: Writing back config space on device :15:00.0 at offset 6 (was 0, writing b0171615) PM: Writing back config space on device :15:00.0 at offset 4 (was 0, writing e430) PM: Writing back config space on device :15:00.0 at offset 3 (was 2, writing 2a820) PM: Writing back config space on device :15:00.0 at offset 1 (was 210, writing 217) system 00:00: resuming -- [ hard hang ] pnp 00:01: resuming system 00:02: resuming pnp 00:03: resuming pnp 00:04: resuming pnp 00:05: resuming pnp 00:06: resuming pnp 00:07: resuming i8042 kbd 00:08: resuming i8042 aux 00:09: resuming pnp 00:0a: resuming platform pcspkr: resuming pci_express :00:1c.0:pcie00: resuming pci_express :00:1c.0:pcie02: resuming pci_express :00:1c.0:pcie03: resuming pci_express :00:1c.1:pcie00: resuming pci_express :00:1c.1:pcie02: resuming pci_express :00:1c.1:pcie03: resuming pci_express :00:1c.2:pcie00: resuming pci_express :00:1c.2:pcie02: resuming pci_express :00:1c.2:pcie03: resuming pci_express :00:1c.3:pcie00: resuming pci_express :00:1c.3:pcie02: resuming pci_express :00:1c.3:pcie03: resuming platform vesafb.0: resuming serial8250 serial8250: resuming ide 0.0: resuming sd 0:0:0:0: resuming i8042 i8042: resuming atkbd serio0: resuming psmouse serio1: resuming ata2: SATA link down (SStatus 0 SControl 0) ata3: SATA link down (SStatus 0 SControl 0) ata4: SATA link down (SStatus 0 SControl 0) psmouse serio2: resuming ata1: waiting for device to spin up (7 secs) Restarting tasks ... done. e1000: eth0: e1000_watchdog: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300) ata1.00: configured for UDMA/100 SCSI device sda: 156301488 512-byte hdwr sectors (80026 MB) sda: Write Protect is off sda: Mode Sense: 00 3a 00 00 SCSI device sda: write cache: enabled, read cache: enabled, doesn't support DPO or FUA PM: Preparing system for mem sleep - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
* Ingo Molnar [EMAIL PROTECTED] wrote: PM: Writing back config space on device :15:00.0 at offset 4 (was 0, writing e430) PM: Writing back config space on device :15:00.0 at offset 3 (was 2, writing 2a820) PM: Writing back config space on device :15:00.0 at offset 1 (was 210, writing 217) system 00:00: resuming -- [ hard hang ] pnp 00:01: resuming system 00:02: resuming pnp 00:03: resuming ok, this was a red herring: the hard hang was an effect of netconsole combined with CONFIG_DISABLE_CONSOLE_SUSPEND. Disabling netconsole solved it. I'll now re-test Eric's MSI patch. Ingo - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
Adrian Bunk schrieb: > It's now in Linus' tree. > > Thomas (Meyer), are there any regressions left with the latest -git tree > plus the MSI fix? > No, not for me. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
On Tue, Mar 27, 2007 at 12:09:13PM +0200, Rafael J. Wysocki wrote: > On Tuesday, 27 March 2007 03:59, Adrian Bunk wrote: > > This email lists some known regressions in Linus' tree compared to 2.6.20. > > > > If you find your name in the Cc header, you are either submitter of one > > of the bugs, maintainer of an affectected subsystem or driver, a patch > > of you caused a breakage or I'm considering you in any other way > > possibly involved with one or more of these issues. > > > > Due to the huge amount of recipients, please trim the Cc when answering. > > I think the following two: > > > Subject: suspend to disk: keypress required for power down > > References : http://lkml.org/lkml/2007/3/25/78 > > Submitter : Thomas Meyer <[EMAIL PROTECTED]> > > Status : unknown > > > Subject: suspend to disk: non-boot cpus are disabled again > > References : http://lkml.org/lkml/2007/3/25/78 > > Submitter : Thomas Meyer <[EMAIL PROTECTED]> > > Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> > > Eric W. Biederman <[EMAIL PROTECTED]> > > Status : problem is being debugged > > are related to the same issue. > > The problem is that we call disable_nonboot_cpus() in swsusp before > powering down the system in order to avoid triggering the WARN_ON() > in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() and this doesn't > work well on Thomas' system. > > Since the problem has been introduced by commit > 94985134b7b46848267ed6b734320db01c974e72 > (swsusp: disable nonboot CPUs before entering platform suspend), I think it's > better to revert this commit and remove the the WARN_ON() in > arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() (appended is a patch that > removes the WARN_ON()). It's now in Linus' tree. Thomas (Meyer), are there any regressions left with the latest -git tree plus the MSI fix? > Greetings, > Rafael >... cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
Marcus Better <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: > >> >> Patch : http://lkml.org/lkml/2007/3/24/136 > >> Marcus any chance I could see an oops? > > I didn't see anything, it froze with the yellow "Linux!" sign. Any idea how > to > get a oops? > >> Or you could try the patch I >> previously posted when debugging this with Thomas. > > Do you mean the one referenced above? I tried it [1] and it works. Yes. Sorry for being redundant. Having the bisect results after the confirmation that the patch worked threw me. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
Eric W. Biederman wrote: > >> Patch : http://lkml.org/lkml/2007/3/24/136 > Marcus any chance I could see an oops? I didn't see anything, it froze with the yellow "Linux!" sign. Any idea how to get a oops? > Or you could try the patch I > previously posted when debugging this with Thomas. Do you mean the one referenced above? I tried it [1] and it works. Marcus [1] http://permalink.gmane.org/gmane.linux.kernel/509299 pgpzgK4cEJIgD.pgp Description: PGP signature
Re: [4/5] 2.6.21-rc5: known regressions
Marcus Better <[EMAIL PROTECTED]> writes: >> Subject: second suspend to disk in a row results in an oops (MSI) >> References : http://lkml.org/lkml/2007/3/17/43 >> http://lkml.org/lkml/2007/3/22/150 >> http://lkml.org/lkml/2007/3/26/205 >> http://lkml.org/lkml/2007/3/26/76 >> Submitter : Thomas Meyer <[EMAIL PROTECTED]> >> Frédéric Riss <[EMAIL PROTECTED]> >> Marcus Better <[EMAIL PROTECTED]> >> Handled-By : Eric W. Biederman <[EMAIL PROTECTED]> >> Patch : http://lkml.org/lkml/2007/3/24/136 >> Status : patch was suggested > > For the sake of completeness, my bisection resulted in this: > > 392ee1e6dd901db6c4504617476f6442ed91f72d is first bad commit > commit 392ee1e6dd901db6c4504617476f6442ed91f72d > Author: Eric W. Biederman <[EMAIL PROTECTED]> > Date: Thu Mar 8 13:04:57 2007 -0700 > > [PATCH] msi: Safer state caching. Right. However if this is what Thomas was seeing the problem turned out to be an issue with pci_enable_device changing the irq number. It just happens that now the code cares, so the bug is found. Marcus any chance I could see an oops? Or you could try the patch I previously posted when debugging this with Thomas. I'm going to clean that patch up and send it along in hopes that it helps anyway and see where we land. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
On Tuesday, 27 March 2007 03:59, Adrian Bunk wrote:
> This email lists some known regressions in Linus' tree compared to 2.6.20.
>
> If you find your name in the Cc header, you are either submitter of one
> of the bugs, maintainer of an affectected subsystem or driver, a patch
> of you caused a breakage or I'm considering you in any other way
> possibly involved with one or more of these issues.
>
> Due to the huge amount of recipients, please trim the Cc when answering.
I think the following two:
> Subject: suspend to disk: keypress required for power down
> References : http://lkml.org/lkml/2007/3/25/78
> Submitter : Thomas Meyer <[EMAIL PROTECTED]>
> Status : unknown
> Subject: suspend to disk: non-boot cpus are disabled again
> References : http://lkml.org/lkml/2007/3/25/78
> Submitter : Thomas Meyer <[EMAIL PROTECTED]>
> Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]>
> Eric W. Biederman <[EMAIL PROTECTED]>
> Status : problem is being debugged
are related to the same issue.
The problem is that we call disable_nonboot_cpus() in swsusp before
powering down the system in order to avoid triggering the WARN_ON()
in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() and this doesn't
work well on Thomas' system.
Since the problem has been introduced by commit
94985134b7b46848267ed6b734320db01c974e72
(swsusp: disable nonboot CPUs before entering platform suspend), I think it's
better to revert this commit and remove the the WARN_ON() in
arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() (appended is a patch that
removes the WARN_ON()).
Greetings,
Rafael
---
Remove the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping(),
which triggers every time during the suspend to disk in the platform mode, as
the potential problem it is related to doesn't seem to occur in practice.
Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
---
arch/x86_64/kernel/acpi/sleep.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux-2.6.21-rc5/arch/x86_64/kernel/acpi/sleep.c
===
--- linux-2.6.21-rc5.orig/arch/x86_64/kernel/acpi/sleep.c
+++ linux-2.6.21-rc5/arch/x86_64/kernel/acpi/sleep.c
@@ -66,8 +66,10 @@ static void init_low_mapping(void)
{
pgd_t *slot0 = pgd_offset(current->mm, 0UL);
low_ptr = *slot0;
+ /* FIXME: We're playing with the current task's page tables here, which
+* is potentially dangerous on SMP systems.
+*/
set_pgd(slot0, *pgd_offset(current->mm, PAGE_OFFSET));
- WARN_ON(num_online_cpus() != 1);
local_flush_tlb();
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
> Subject: second suspend to disk in a row results in an oops (MSI) > References : http://lkml.org/lkml/2007/3/17/43 > http://lkml.org/lkml/2007/3/22/150 > http://lkml.org/lkml/2007/3/26/205 > http://lkml.org/lkml/2007/3/26/76 > Submitter : Thomas Meyer <[EMAIL PROTECTED]> > Frédéric Riss <[EMAIL PROTECTED]> > Marcus Better <[EMAIL PROTECTED]> > Handled-By : Eric W. Biederman <[EMAIL PROTECTED]> > Patch : http://lkml.org/lkml/2007/3/24/136 > Status : patch was suggested For the sake of completeness, my bisection resulted in this: 392ee1e6dd901db6c4504617476f6442ed91f72d is first bad commit commit 392ee1e6dd901db6c4504617476f6442ed91f72d Author: Eric W. Biederman <[EMAIL PROTECTED]> Date: Thu Mar 8 13:04:57 2007 -0700 [PATCH] msi: Safer state caching. Marcus pgpIDnLw3Cxby.pgp Description: PGP signature
Re: [4/5] 2.6.21-rc5: known regressions
Subject: second suspend to disk in a row results in an oops (MSI) References : http://lkml.org/lkml/2007/3/17/43 http://lkml.org/lkml/2007/3/22/150 http://lkml.org/lkml/2007/3/26/205 http://lkml.org/lkml/2007/3/26/76 Submitter : Thomas Meyer [EMAIL PROTECTED] Frédéric Riss [EMAIL PROTECTED] Marcus Better [EMAIL PROTECTED] Handled-By : Eric W. Biederman [EMAIL PROTECTED] Patch : http://lkml.org/lkml/2007/3/24/136 Status : patch was suggested For the sake of completeness, my bisection resulted in this: 392ee1e6dd901db6c4504617476f6442ed91f72d is first bad commit commit 392ee1e6dd901db6c4504617476f6442ed91f72d Author: Eric W. Biederman [EMAIL PROTECTED] Date: Thu Mar 8 13:04:57 2007 -0700 [PATCH] msi: Safer state caching. Marcus pgpIDnLw3Cxby.pgp Description: PGP signature
Re: [4/5] 2.6.21-rc5: known regressions
On Tuesday, 27 March 2007 03:59, Adrian Bunk wrote:
This email lists some known regressions in Linus' tree compared to 2.6.20.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any other way
possibly involved with one or more of these issues.
Due to the huge amount of recipients, please trim the Cc when answering.
I think the following two:
Subject: suspend to disk: keypress required for power down
References : http://lkml.org/lkml/2007/3/25/78
Submitter : Thomas Meyer [EMAIL PROTECTED]
Status : unknown
Subject: suspend to disk: non-boot cpus are disabled again
References : http://lkml.org/lkml/2007/3/25/78
Submitter : Thomas Meyer [EMAIL PROTECTED]
Handled-By : Rafael J. Wysocki [EMAIL PROTECTED]
Eric W. Biederman [EMAIL PROTECTED]
Status : problem is being debugged
are related to the same issue.
The problem is that we call disable_nonboot_cpus() in swsusp before
powering down the system in order to avoid triggering the WARN_ON()
in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() and this doesn't
work well on Thomas' system.
Since the problem has been introduced by commit
94985134b7b46848267ed6b734320db01c974e72
(swsusp: disable nonboot CPUs before entering platform suspend), I think it's
better to revert this commit and remove the the WARN_ON() in
arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() (appended is a patch that
removes the WARN_ON()).
Greetings,
Rafael
---
Remove the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping(),
which triggers every time during the suspend to disk in the platform mode, as
the potential problem it is related to doesn't seem to occur in practice.
Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED]
---
arch/x86_64/kernel/acpi/sleep.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux-2.6.21-rc5/arch/x86_64/kernel/acpi/sleep.c
===
--- linux-2.6.21-rc5.orig/arch/x86_64/kernel/acpi/sleep.c
+++ linux-2.6.21-rc5/arch/x86_64/kernel/acpi/sleep.c
@@ -66,8 +66,10 @@ static void init_low_mapping(void)
{
pgd_t *slot0 = pgd_offset(current-mm, 0UL);
low_ptr = *slot0;
+ /* FIXME: We're playing with the current task's page tables here, which
+* is potentially dangerous on SMP systems.
+*/
set_pgd(slot0, *pgd_offset(current-mm, PAGE_OFFSET));
- WARN_ON(num_online_cpus() != 1);
local_flush_tlb();
}
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
Marcus Better [EMAIL PROTECTED] writes: Subject: second suspend to disk in a row results in an oops (MSI) References : http://lkml.org/lkml/2007/3/17/43 http://lkml.org/lkml/2007/3/22/150 http://lkml.org/lkml/2007/3/26/205 http://lkml.org/lkml/2007/3/26/76 Submitter : Thomas Meyer [EMAIL PROTECTED] Frédéric Riss [EMAIL PROTECTED] Marcus Better [EMAIL PROTECTED] Handled-By : Eric W. Biederman [EMAIL PROTECTED] Patch : http://lkml.org/lkml/2007/3/24/136 Status : patch was suggested For the sake of completeness, my bisection resulted in this: 392ee1e6dd901db6c4504617476f6442ed91f72d is first bad commit commit 392ee1e6dd901db6c4504617476f6442ed91f72d Author: Eric W. Biederman [EMAIL PROTECTED] Date: Thu Mar 8 13:04:57 2007 -0700 [PATCH] msi: Safer state caching. Right. However if this is what Thomas was seeing the problem turned out to be an issue with pci_enable_device changing the irq number. It just happens that now the code cares, so the bug is found. Marcus any chance I could see an oops? Or you could try the patch I previously posted when debugging this with Thomas. I'm going to clean that patch up and send it along in hopes that it helps anyway and see where we land. Eric - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
Eric W. Biederman wrote: Patch : http://lkml.org/lkml/2007/3/24/136 Marcus any chance I could see an oops? I didn't see anything, it froze with the yellow Linux! sign. Any idea how to get a oops? Or you could try the patch I previously posted when debugging this with Thomas. Do you mean the one referenced above? I tried it [1] and it works. Marcus [1] http://permalink.gmane.org/gmane.linux.kernel/509299 pgpzgK4cEJIgD.pgp Description: PGP signature
Re: [4/5] 2.6.21-rc5: known regressions
Marcus Better [EMAIL PROTECTED] writes: Eric W. Biederman wrote: Patch : http://lkml.org/lkml/2007/3/24/136 Marcus any chance I could see an oops? I didn't see anything, it froze with the yellow Linux! sign. Any idea how to get a oops? Or you could try the patch I previously posted when debugging this with Thomas. Do you mean the one referenced above? I tried it [1] and it works. Yes. Sorry for being redundant. Having the bisect results after the confirmation that the patch worked threw me. Eric - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
On Tue, Mar 27, 2007 at 12:09:13PM +0200, Rafael J. Wysocki wrote: On Tuesday, 27 March 2007 03:59, Adrian Bunk wrote: This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly involved with one or more of these issues. Due to the huge amount of recipients, please trim the Cc when answering. I think the following two: Subject: suspend to disk: keypress required for power down References : http://lkml.org/lkml/2007/3/25/78 Submitter : Thomas Meyer [EMAIL PROTECTED] Status : unknown Subject: suspend to disk: non-boot cpus are disabled again References : http://lkml.org/lkml/2007/3/25/78 Submitter : Thomas Meyer [EMAIL PROTECTED] Handled-By : Rafael J. Wysocki [EMAIL PROTECTED] Eric W. Biederman [EMAIL PROTECTED] Status : problem is being debugged are related to the same issue. The problem is that we call disable_nonboot_cpus() in swsusp before powering down the system in order to avoid triggering the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() and this doesn't work well on Thomas' system. Since the problem has been introduced by commit 94985134b7b46848267ed6b734320db01c974e72 (swsusp: disable nonboot CPUs before entering platform suspend), I think it's better to revert this commit and remove the the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() (appended is a patch that removes the WARN_ON()). It's now in Linus' tree. Thomas (Meyer), are there any regressions left with the latest -git tree plus the MSI fix? Greetings, Rafael ... cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [4/5] 2.6.21-rc5: known regressions
Adrian Bunk schrieb: It's now in Linus' tree. Thomas (Meyer), are there any regressions left with the latest -git tree plus the MSI fix? No, not for me. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[4/5] 2.6.21-rc5: known regressions
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly involved with one or more of these issues. Due to the huge amount of recipients, please trim the Cc when answering. Subject: ThinkPad X60: resume no longer works (PCI related?) References : http://lkml.org/lkml/2007/3/13/3 Submitter : Dave Jones <[EMAIL PROTECTED]> Jeremy Fitzhardinge <[EMAIL PROTECTED]> Caused-By : PCI merge commit 78149df6d565c36675463352d0bfeb02b7a7 Handled-By : Eric W. Biederman <[EMAIL PROTECTED]> Rafael J. Wysocki <[EMAIL PROTECTED]> Status : problem is being debugged Subject: second suspend to disk in a row results in an oops (MSI) References : http://lkml.org/lkml/2007/3/17/43 http://lkml.org/lkml/2007/3/22/150 http://lkml.org/lkml/2007/3/26/205 http://lkml.org/lkml/2007/3/26/76 Submitter : Thomas Meyer <[EMAIL PROTECTED]> Frédéric Riss <[EMAIL PROTECTED]> Marcus Better <[EMAIL PROTECTED]> Handled-By : Eric W. Biederman <[EMAIL PROTECTED]> Patch : http://lkml.org/lkml/2007/3/24/136 Status : patch was suggested Subject: Suspend to RAM doesn't work anymore (ACPI?) References : http://lkml.org/lkml/2007/3/19/128 http://bugzilla.kernel.org/show_bug.cgi?id=8247 Submitter : Tobias Doerffel <[EMAIL PROTECTED]> Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> Len Brown <[EMAIL PROTECTED]> Status : problem is being debugged Subject: s2ram autowake regression (ACPI?) References : http://lkml.org/lkml/2007/3/20/96 Submitter : Pavel Machek <[EMAIL PROTECTED]> Handled-By : Len Brown <[EMAIL PROTECTED]> Status : submitter was asked to test a patch Subject: SATA breakage on resume References : http://lkml.org/lkml/2007/3/7/233 Submitter : Thomas Gleixner <[EMAIL PROTECTED]> Soeren Sonnenburg <[EMAIL PROTECTED]> Status : unknown Subject: suspend to disk: keypress required for power down References : http://lkml.org/lkml/2007/3/25/78 Submitter : Thomas Meyer <[EMAIL PROTECTED]> Status : unknown Subject: resume from RAM corrupts vesafb console References : http://lkml.org/lkml/2007/3/26/76 Submitter : Marcus Better <[EMAIL PROTECTED]> Handled-By : Pavel Machek <[EMAIL PROTECTED]> Status : problem is being debugged Subject: suspend to disk: non-boot cpus are disabled again References : http://lkml.org/lkml/2007/3/25/78 Submitter : Thomas Meyer <[EMAIL PROTECTED]> Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> Eric W. Biederman <[EMAIL PROTECTED]> Status : problem is being debugged Subject: ThinkPad doesn't resume from suspend to RAM References : http://lkml.org/lkml/2007/2/27/80 http://lkml.org/lkml/2007/2/28/348 Submitter : Jens Axboe <[EMAIL PROTECTED]> Jeff Chua <[EMAIL PROTECTED]> Status : unknown Subject: suspend to disk hangs (microcode driver) References : http://lkml.org/lkml/2007/3/16/126 Submitter : Maxim Levitsky <[EMAIL PROTECTED]> Caused-By : Rafael J. Wysocki <[EMAIL PROTECTED]> commit e3c7db621bed4afb8e231cb005057f2feb5db557 commit ed746e3b18f4df18afa3763155972c5835f284c5 commit 259130526c267550bc365d3015917d90667732f1 Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> Patch : http://lkml.org/lkml/2007/3/23/179 Status : patch available - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[4/5] 2.6.21-rc5: known regressions
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly involved with one or more of these issues. Due to the huge amount of recipients, please trim the Cc when answering. Subject: ThinkPad X60: resume no longer works (PCI related?) References : http://lkml.org/lkml/2007/3/13/3 Submitter : Dave Jones [EMAIL PROTECTED] Jeremy Fitzhardinge [EMAIL PROTECTED] Caused-By : PCI merge commit 78149df6d565c36675463352d0bfeb02b7a7 Handled-By : Eric W. Biederman [EMAIL PROTECTED] Rafael J. Wysocki [EMAIL PROTECTED] Status : problem is being debugged Subject: second suspend to disk in a row results in an oops (MSI) References : http://lkml.org/lkml/2007/3/17/43 http://lkml.org/lkml/2007/3/22/150 http://lkml.org/lkml/2007/3/26/205 http://lkml.org/lkml/2007/3/26/76 Submitter : Thomas Meyer [EMAIL PROTECTED] Frédéric Riss [EMAIL PROTECTED] Marcus Better [EMAIL PROTECTED] Handled-By : Eric W. Biederman [EMAIL PROTECTED] Patch : http://lkml.org/lkml/2007/3/24/136 Status : patch was suggested Subject: Suspend to RAM doesn't work anymore (ACPI?) References : http://lkml.org/lkml/2007/3/19/128 http://bugzilla.kernel.org/show_bug.cgi?id=8247 Submitter : Tobias Doerffel [EMAIL PROTECTED] Handled-By : Rafael J. Wysocki [EMAIL PROTECTED] Len Brown [EMAIL PROTECTED] Status : problem is being debugged Subject: s2ram autowake regression (ACPI?) References : http://lkml.org/lkml/2007/3/20/96 Submitter : Pavel Machek [EMAIL PROTECTED] Handled-By : Len Brown [EMAIL PROTECTED] Status : submitter was asked to test a patch Subject: SATA breakage on resume References : http://lkml.org/lkml/2007/3/7/233 Submitter : Thomas Gleixner [EMAIL PROTECTED] Soeren Sonnenburg [EMAIL PROTECTED] Status : unknown Subject: suspend to disk: keypress required for power down References : http://lkml.org/lkml/2007/3/25/78 Submitter : Thomas Meyer [EMAIL PROTECTED] Status : unknown Subject: resume from RAM corrupts vesafb console References : http://lkml.org/lkml/2007/3/26/76 Submitter : Marcus Better [EMAIL PROTECTED] Handled-By : Pavel Machek [EMAIL PROTECTED] Status : problem is being debugged Subject: suspend to disk: non-boot cpus are disabled again References : http://lkml.org/lkml/2007/3/25/78 Submitter : Thomas Meyer [EMAIL PROTECTED] Handled-By : Rafael J. Wysocki [EMAIL PROTECTED] Eric W. Biederman [EMAIL PROTECTED] Status : problem is being debugged Subject: ThinkPad doesn't resume from suspend to RAM References : http://lkml.org/lkml/2007/2/27/80 http://lkml.org/lkml/2007/2/28/348 Submitter : Jens Axboe [EMAIL PROTECTED] Jeff Chua [EMAIL PROTECTED] Status : unknown Subject: suspend to disk hangs (microcode driver) References : http://lkml.org/lkml/2007/3/16/126 Submitter : Maxim Levitsky [EMAIL PROTECTED] Caused-By : Rafael J. Wysocki [EMAIL PROTECTED] commit e3c7db621bed4afb8e231cb005057f2feb5db557 commit ed746e3b18f4df18afa3763155972c5835f284c5 commit 259130526c267550bc365d3015917d90667732f1 Handled-By : Rafael J. Wysocki [EMAIL PROTECTED] Patch : http://lkml.org/lkml/2007/3/23/179 Status : patch available - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
