Re: [ANNOUNCE] Git v2.27.0-rc2

2020-05-28 Thread Kaartic Sivaraam



On 27 May 2020 22:17:01 GMT+05:30, Junio C Hamano  wrote:
>Kaartic Sivaraam  writes:
>
>> Hi Junio,
>>
>> On 27-05-2020 00:17, Junio C Hamano wrote:
>>> Shourya Shukla (4):
>>>submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'
>>>gitfaq: files in .gitignore are tracked
>>>gitfaq: fetching and pulling a repository
>>>submodule: port subcommand 'set-url' from shell to C
>>
>> This is the only place where the `set-url` conversion from Shell to C
>> is mentioned. I wonder if it's enough or if it needs a little bit
>more
>> attention may be in the "Performance, Internal Implementation,
>> Development Support etc." as it is a conversion of a submodule
>> sub-command?
>
>I'm not sure if it is worth the bits.  It may matter _only_ if/when
>new implementaiton of set-url hurts the end-users by being buggy ;-)

OK. That makes sense. The converted version has gone through reviews and 
presumably it does pass our CI test cases. I think I was just trying to 
overcautious to ensure we're not bitten by a worst case scenario wherein a bug 
slipped through the reviews and the tests. I believe it's pretty unlikely, 
though :-)

-- 
Sivaraam

Sent from my Android device with K-9 Mail. Please excuse my brevity and 
possible "typso".


Re: [ANNOUNCE] Git v2.27.0-rc2

2020-05-27 Thread Junio C Hamano
Pratyush Yadav  writes:

> On 26/05/20 11:47AM, Junio C Hamano wrote:
>> A release candidate Git v2.27.0-rc2 is now available for testing
>> at the usual places.  It is comprised of 509 non-merge commits
>> since v2.26.0, contributed by 59 people, 17 of which are new faces.
>> 
>> Changes since v2.26.0 are as follows:
>> 
>> Ansgar Röber (1):
>>   Subject: git-gui: fix syntax error because of missing semicolon
>
> Looks like I messed up somewhere and left the "Subject: " in there. Its 
> too late to do anything about it now I guess...

Yup, indeed you did ;-)  But we all make mistakes and learn from the
ones we or others make, so...


Re: [ANNOUNCE] Git v2.27.0-rc2

2020-05-27 Thread Junio C Hamano
Kaartic Sivaraam  writes:

> Hi Junio,
>
> On 27-05-2020 00:17, Junio C Hamano wrote:
>> Shourya Shukla (4):
>>submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'
>>gitfaq: files in .gitignore are tracked
>>gitfaq: fetching and pulling a repository
>>submodule: port subcommand 'set-url' from shell to C
>
> This is the only place where the `set-url` conversion from Shell to C
> is mentioned. I wonder if it's enough or if it needs a little bit more
> attention may be in the "Performance, Internal Implementation,
> Development Support etc." as it is a conversion of a submodule
> sub-command?

I'm not sure if it is worth the bits.  It may matter _only_ if/when
new implementaiton of set-url hurts the end-users by being buggy ;-)


Re: [ANNOUNCE] Git v2.27.0-rc2

2020-05-27 Thread Pratyush Yadav
On 26/05/20 11:47AM, Junio C Hamano wrote:
> A release candidate Git v2.27.0-rc2 is now available for testing
> at the usual places.  It is comprised of 509 non-merge commits
> since v2.26.0, contributed by 59 people, 17 of which are new faces.
> 
> Changes since v2.26.0 are as follows:
> 
> Ansgar Röber (1):
>   Subject: git-gui: fix syntax error because of missing semicolon

Looks like I messed up somewhere and left the "Subject: " in there. Its 
too late to do anything about it now I guess...

-- 
Regards,
Pratyush Yadav


Re: [ANNOUNCE] Git v2.27.0-rc2

2020-05-26 Thread Kaartic Sivaraam

Hi Junio,

On 27-05-2020 00:17, Junio C Hamano wrote:

Shourya Shukla (4):
   submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'
   gitfaq: files in .gitignore are tracked
   gitfaq: fetching and pulling a repository
   submodule: port subcommand 'set-url' from shell to C


This is the only place where the `set-url` conversion from Shell to C is 
mentioned. I wonder if it's enough or if it needs a little bit more 
attention may be in the "Performance, Internal Implementation, 
Development Support etc." as it is a conversion of a submodule sub-command?


I'm not sure about the importance that these kinds of conversion 
require, thus the question :)


--
Sivaraam


[ANNOUNCE] Git v2.27.0-rc2

2020-05-26 Thread Junio C Hamano
A release candidate Git v2.27.0-rc2 is now available for testing
at the usual places.  It is comprised of 509 non-merge commits
since v2.26.0, contributed by 59 people, 17 of which are new faces.

The tarballs are found at:

https://www.kernel.org/pub/software/scm/git/testing/

The following public repositories all have a copy of the
'v2.27.0-rc2' tag and the 'master' branch that the tag points at:

  url = https://kernel.googlesource.com/pub/scm/git/git
  url = git://repo.or.cz/alt-git.git
  url = https://github.com/gitster/git

New contributors whose contributions weren't in v2.26.0 are as follows.
Welcome to the Git development community!

  Andras Kucsma, Ansgar Röber, Ash Holland, Christopher
  Warrington, Emma Brooks, Jessica Clarke, Jorge Lopez Silva,
  Julien Moutinho, Li Xuejiang, luciano.ro...@booking.com,
  Matthias Aßhauer, Michael F. Schönitzer, Nathan Sanders,
  Son Luong Ngoc, Terry Moschou, Vasil Dimov, and Yang Zhao.

Returning contributors who helped this release are as follows.
Thanks for your continued support.

  마누엘, Abhishek Kumar, Alban Gruin, Alexandr Miloslavskiy,
  Alex Henrie, Andrei Rybak, Andrew Oakley, Ben Keene, brian
  m. carlson, Carlo Marcelo Arenas Belón, Christian Couder,
  Damien Robert, Denton Liu, Derrick Stolee, Đoàn Trần Công
  Danh, Elijah Newren, Emily Shaffer, Eric Sunshine, Garima Singh,
  Greg Price, Hans Jerry Illikainen, Heba Waly, Ismael Luceno,
  Jeff King, Jiang Xin, Johannes Schindelin, Jonathan Nieder,
  Jonathan Tan, Josh Steadmon, Junio C Hamano, Martin Ågren,
  Matheus Tavares, Patrick Steinhardt, Philippe Blain, Phillip
  Wood, Pratyush Yadav, René Scharfe, Shourya Shukla, SZEDER
  Gábor, Taylor Blau, Thomas Gummerer, and Todd Zullinger.



Git 2.27 Release Notes (draft)
==

Updates since v2.26
---

Backward compatibility notes

 * When "git describe C" finds that commit C is pointed by a signed or
   annotated tag, which records T as its tagname in the object, the
   command gives T as its answer.  Even if the user renames or moves
   such a tag from its natural location in the "refs/tags/" hierarchy,
   "git describe C" would still give T as the answer, but in such a
   case "git show T^0" would no longer work as expected.  There may be
   nothing at "refs/tags/T" or even worse there may be a different tag
   instead.

   Starting from this version, "git describe" will always use the
   "long" version, as if the "--long" option were given, when giving
   its output based on such a misplaced tag to work around the problem.

 * "git pull" issues a warning message until the pull.rebase
   configuration variable is explicitly given, which some existing
   users may find annoying---those who prefer not to rebase need to
   set the variable to false to squelch the warning.

 * The transport protocol version 2, which was promoted to the default
   in Git 2.26 release, turned out to have some remaining rough edges,
   so it has been demoted from the default.


UI, Workflows & Features

 * A handful of options to configure SSL when talking to proxies have
   been added.

 * Smudge/clean conversion filters are now given more information
   (e.g. the object of the tree-ish in which the blob being converted
   appears, in addition to its path, which has already been given).

 * When "git describe C" finds an annotated tag with tagname A to be
   the best name to explain commit C, and the tag is stored in a
   "wrong" place in the refs/tags hierarchy, e.g. refs/tags/B, the
   command gave a warning message but used A (not B) to describe C.
   If C is exactly at the tag, the describe output would be "A", but
   "git rev-parse A^0" would not be equal as "git rev-parse C^0".  The
   behavior of the command has been changed to use the "long" form
   i.e. A-0-gOBJECTNAME, which is correctly interpreted by rev-parse.

 * "git pull" learned to warn when no pull.rebase configuration
   exists, and neither --[no-]rebase nor --ff-only is given (which
   would result a merge).

 * "git p4" learned four new hooks and also "--no-verify" option to
   bypass them (and the existing "p4-pre-submit" hook).

 * "git pull" shares many options with underlying "git fetch", but
   some of them were not documented and some of those that would make
   sense to pass down were not passed down.

 * "git rebase" learned the "--no-gpg-sign" option to countermand
   commit.gpgSign the user may have.

 * The output from "git format-patch" uses RFC 2047 encoding for
   non-ASCII letters on From: and Subject: headers, so that it can
   directly be fed to e-mail programs.  A new option has been added
   to produce these headers in raw.

 * "git log" learned "--show-pulls" that helps pathspec limited
   history views; a merge commit that takes the whole change from a
   side branch, which is normally omitted from the output, is shown
   in addition to the commits that introduce real