Re: [BUG/PATCH 0/4] gpiolib: fix issues with legacy spi-cs-high handling
On Mon, Apr 1, 2019 at 11:59 PM H. Nikolaus Schaller wrote: > I learned just some minutes ago that a new patch for gpiolib > came through 5.1-rc3 which does fix this in almost the same way > as I proposed. I am sorry for not being very attentive, I have been travelling. I collected the most urgent fixes and this was fixed as part of that quick patchup. > Except that it seems to check for "cs-gpios" and then disable the > legacy handling. Yups. > So we do not need to add a config option for this legacy > handling (although I'd prefer to have it anyways to remove > some dead code). > > Summary: this series can now be ignored. OK please verify that we are doing things right now, the big worry I have is some interrim DTBs that use the GPIO flag GPIO_ACTIVE_HIGH, which is zero and therefore often the default, and expect it to actually work, while the SPI bindings by definition will ignore that and make the line active low. I'm not very happy about this but it is a result of how we quickly implemented some bindings in the past while the GPIO flags were not yet standardized. Yours, Linus Walleij
Re: [BUG/PATCH 0/4] gpiolib: fix issues with legacy spi-cs-high handling
Hi all, > Am 31.03.2019 um 12:07 schrieb H. Nikolaus Schaller : > > 2018-07-25 07:55:28: > > H. Nikolaus Schaller (4): > DTS: GTA04: SPI / gpiolib: work around a regression that unhides a >broken legacy handler, which makes the gta04 display inoperable > REVERT: DTS: GTA04: SPI / gpiolib: no no no, we do not want to "fix" >our device tree file > gpiolib: make legacy handling for spi-cs-high optional > gpiolib: spi-cs-high is checking the wrong node (the controller and >not the SPI slave device) > > drivers/gpio/Kconfig | 8 > drivers/gpio/gpiolib-of.c | 8 +--- > 2 files changed, 13 insertions(+), 3 deletions(-) > > -- > 2.19.1 > I learned just some minutes ago that a new patch for gpiolib came through 5.1-rc3 which does fix this in almost the same way as I proposed. Except that it seems to check for "cs-gpios" and then disable the legacy handling. So we do not need to add a config option for this legacy handling (although I'd prefer to have it anyways to remove some dead code). Summary: this series can now be ignored. BR and thanks, Nikolaus
[BUG/PATCH 0/4] gpiolib: fix issues with legacy spi-cs-high handling
2018-07-25 07:55:28: H. Nikolaus Schaller (4): DTS: GTA04: SPI / gpiolib: work around a regression that unhides a broken legacy handler, which makes the gta04 display inoperable REVERT: DTS: GTA04: SPI / gpiolib: no no no, we do not want to "fix" our device tree file gpiolib: make legacy handling for spi-cs-high optional gpiolib: spi-cs-high is checking the wrong node (the controller and not the SPI slave device) drivers/gpio/Kconfig | 8 drivers/gpio/gpiolib-of.c | 8 +--- 2 files changed, 13 insertions(+), 3 deletions(-) -- 2.19.1
