Re: [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot
On Fri, 15 Jan 2021 09:50:25 +0200
Jani Nikula wrote:
> >> fe0f1e3bfdfeb53e18f1206aea4f40b9bd1f291c
> >> ("drm/i915: Shut down displays gracefully on reboot")
> >>
> >> Which makes sense, as it happens on shutdown.
>
> Please try this pull, heading to -rc4, which cointains "drm/i915:
> Disable RPM wakeref assertions during driver shutdown":
>
> http://lore.kernel.org/r/87sg73pz42@intel.com
Yep, Linus pulled in 057fe3535eb3 last night and it appears to fix the
issue in mainline.
Thanks!
-- Steve
Re: [Intel-gfx] [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot
On Thu, 14 Jan 2021 20:15:45 -0800 Linus Torvalds wrote: > On Thu, Jan 14, 2021 at 2:01 PM Steven Rostedt wrote: > > > > Thanks, I take it, it will be going into mainline soon. > > Just got merged - it might be a good idea to verify that your problem is > solved. > Yep, I just tested commit: 5ee88057889bbca5f5bb96031b62b3756b33e164 which was your master of this morning. The problem appears to be removed. Thanks! -- Steve
Re: [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot
On Thu, 14 Jan 2021, Steven Rostedt wrote:
> [ Forgot to add those on the commit itself ]
>
> -- Steve
>
>
> On Thu, 14 Jan 2021 16:32:06 -0500
> Steven Rostedt wrote:
>
>> On reboot, one of my test boxes now triggers the following warning:
>>
>> [ cut here ]
>> RPM raw-wakeref not held
>> WARNING: CPU: 4 PID: 1 at drivers/gpu/drm/i915/intel_runtime_pm.h:106
>> gen6_write32+0x1bc/0x2a0 [i915]
>> Modules linked in: ebtable_filter ebtables bridge stp llc ip6t_REJECT
>> nf_reject_ipv6 vsock vmw_vmci xt_state xt_conntrack nf_conntrack
>> nf_defrag_ipv6 nf_defrag_ipv4 ip6table_filter ip6_tables snd_hda_codec_hdmi
>> snd_hda_codec_realtek snd_hda_codec_generic le
>> 15 snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep i2c_algo_bit
>> snd_hda_core snd_seq intel_rapl_msr snd_seq_device intel_rapl_common snd_pcm
>> x86_pkg_temp_thermal intel_powerclamp snd_timer snd coretemp kvm_intel
>> soundcore kvm mei_wdt irqbypass joydev
>> _pmc_bxt hp_wmi wmi_bmof sparse_keymap rfkill iTCO_vendor_support
>> crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel
>> drm_kms_helper i2c_i801 cec drm rapl intel_cstate intel_uncore mei_me
>> i2c_smbus e1000e tpm_infineon wmi serio_raw mei video lpc_i
>>
>> CPU: 4 PID: 1 Comm: systemd-shutdow Not tainted 5.9.0-rc4-test+ #861
>> Hardware name: Hewlett-Packard HP Compaq Pro 6300 SFF/339A, BIOS K01 v03.03
>> 07/14/2016
>> RIP: 0010:gen6_write32+0x1bc/0x2a0 [i915]
>> Code: 5d 82 e0 0f 0b e9 b5 fe ff ff 80 3d 95 6b 22 00 00 0f 85 b2 fe ff ff
>> 48 c7 c7 04 d2 a4 c0 c6 05 81 6b 22 00 01 e8 f6 5c 82 e0 <0f> 0b e9 98 fe ff
>> ff 80 3d 6d 6b 22 00 00 0f 85 95 fe ff ff 48 c7
>> RSP: 0018:b9c1c002fd08 EFLAGS: 00010296
>> RAX: 0018 RBX: 99aec8881010 RCX: 99aeda40
>> RDX: RSI: a115d9ef RDI: a115d9ef
>> RBP: 00044004 R08: 0001 R09:
>> R10: 0001 R11: 0001 R12:
>> R13: 0001 R14: R15:
>> FS: 7f91257a9940() GS:99aeda40() knlGS:
>> CS: 0010 DS: ES: CR0: 80050033
>> CR2: 7f9126829400 CR3: 0001088f0006 CR4: 001706e0
>> Call Trace:
>> gen3_irq_reset+0x2e/0xd0 [i915]
>> intel_irq_reset+0x59/0x6a0 [i915]
>> intel_runtime_pm_disable_interrupts+0xe/0x30 [i915]
>> i915_driver_shutdown+0x2e/0x40 [i915]
>> pci_device_shutdown+0x34/0x60
>> device_shutdown+0x15d/0x1b3
>> kernel_restart+0xe/0x30
>> __do_sys_reboot+0x1d7/0x210
>> ? vfs_writev+0x9d/0xe0
>> ? syscall_enter_from_user_mode+0x1d/0x70
>> ? trace_hardirqs_on+0x2c/0xe0
>> do_syscall_64+0x33/0x40
>> entry_SYSCALL_64_after_hwframe+0x44/0xa9
>> RIP: 0033:0x7f912675f2d7
>> Code: 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa
>> 89 fa be 69 19 12 28 bf ad de e1 fe b8 a9 00 00 00 0f 05 <48> 3d 00 f0 ff ff
>> 77 01 c3 48 8b 15 81 8b 0c 00 f7 d8 64 89 02 b8
>> RSP: 002b:7ffeca28e148 EFLAGS: 0206 ORIG_RAX: 00a9
>> RAX: ffda RBX: RCX: 7f912675f2d7
>> RDX: 01234567 RSI: 28121969 RDI: fee1dead
>> RBP: 7ffeca28e3d0 R08: 000a R09:
>> R10: 0232 R11: 0206 R12: 0001
>> R13: R14: R15: 7ffeca28e4b8
>> ---[ end trace 2ed17eabd3ab6938 ]---
>> [ cut here ]
>>
>> The bisect came to this commit:
>>
>> fe0f1e3bfdfeb53e18f1206aea4f40b9bd1f291c
>> ("drm/i915: Shut down displays gracefully on reboot")
>>
>> Which makes sense, as it happens on shutdown.
Please try this pull, heading to -rc4, which cointains "drm/i915:
Disable RPM wakeref assertions during driver shutdown":
http://lore.kernel.org/r/87sg73pz42@intel.com
BR,
Jani.
>>
>> -- Steve
>
--
Jani Nikula, Intel Open Source Graphics Center
Re: [Intel-gfx] [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot
On Thu, Jan 14, 2021 at 2:01 PM Steven Rostedt wrote: > > Thanks, I take it, it will be going into mainline soon. Just got merged - it might be a good idea to verify that your problem is solved. Linus
Re: [Intel-gfx] [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot
On Thu, 14 Jan 2021 21:35:53 +
Chris Wilson wrote:
> Quoting Steven Rostedt (2021-01-14 21:32:06)
> > On reboot, one of my test boxes now triggers the following warning:
>
> 057fe3535eb3 ("drm/i915: Disable RPM wakeref assertions during driver
> shutdown")
> is included with the drm-intel-fixes PR.
Thanks, I take it, it will be going into mainline soon.
-- Steve
Re: [Intel-gfx] [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot
Quoting Steven Rostedt (2021-01-14 21:32:06)
> On reboot, one of my test boxes now triggers the following warning:
057fe3535eb3 ("drm/i915: Disable RPM wakeref assertions during driver shutdown")
is included with the drm-intel-fixes PR.
-Chris
Re: [BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot
[ Forgot to add those on the commit itself ]
-- Steve
On Thu, 14 Jan 2021 16:32:06 -0500
Steven Rostedt wrote:
> On reboot, one of my test boxes now triggers the following warning:
>
> [ cut here ]
> RPM raw-wakeref not held
> WARNING: CPU: 4 PID: 1 at drivers/gpu/drm/i915/intel_runtime_pm.h:106
> gen6_write32+0x1bc/0x2a0 [i915]
> Modules linked in: ebtable_filter ebtables bridge stp llc ip6t_REJECT
> nf_reject_ipv6 vsock vmw_vmci xt_state xt_conntrack nf_conntrack
> nf_defrag_ipv6 nf_defrag_ipv4 ip6table_filter ip6_tables snd_hda_codec_hdmi
> snd_hda_codec_realtek snd_hda_codec_generic le
> 15 snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep i2c_algo_bit
> snd_hda_core snd_seq intel_rapl_msr snd_seq_device intel_rapl_common snd_pcm
> x86_pkg_temp_thermal intel_powerclamp snd_timer snd coretemp kvm_intel
> soundcore kvm mei_wdt irqbypass joydev
> _pmc_bxt hp_wmi wmi_bmof sparse_keymap rfkill iTCO_vendor_support
> crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel drm_kms_helper
> i2c_i801 cec drm rapl intel_cstate intel_uncore mei_me i2c_smbus e1000e
> tpm_infineon wmi serio_raw mei video lpc_i
>
> CPU: 4 PID: 1 Comm: systemd-shutdow Not tainted 5.9.0-rc4-test+ #861
> Hardware name: Hewlett-Packard HP Compaq Pro 6300 SFF/339A, BIOS K01 v03.03
> 07/14/2016
> RIP: 0010:gen6_write32+0x1bc/0x2a0 [i915]
> Code: 5d 82 e0 0f 0b e9 b5 fe ff ff 80 3d 95 6b 22 00 00 0f 85 b2 fe ff ff
> 48 c7 c7 04 d2 a4 c0 c6 05 81 6b 22 00 01 e8 f6 5c 82 e0 <0f> 0b e9 98 fe ff
> ff 80 3d 6d 6b 22 00 00 0f 85 95 fe ff ff 48 c7
> RSP: 0018:b9c1c002fd08 EFLAGS: 00010296
> RAX: 0018 RBX: 99aec8881010 RCX: 99aeda40
> RDX: RSI: a115d9ef RDI: a115d9ef
> RBP: 00044004 R08: 0001 R09:
> R10: 0001 R11: 0001 R12:
> R13: 0001 R14: R15:
> FS: 7f91257a9940() GS:99aeda40() knlGS:
> CS: 0010 DS: ES: CR0: 80050033
> CR2: 7f9126829400 CR3: 0001088f0006 CR4: 001706e0
> Call Trace:
> gen3_irq_reset+0x2e/0xd0 [i915]
> intel_irq_reset+0x59/0x6a0 [i915]
> intel_runtime_pm_disable_interrupts+0xe/0x30 [i915]
> i915_driver_shutdown+0x2e/0x40 [i915]
> pci_device_shutdown+0x34/0x60
> device_shutdown+0x15d/0x1b3
> kernel_restart+0xe/0x30
> __do_sys_reboot+0x1d7/0x210
> ? vfs_writev+0x9d/0xe0
> ? syscall_enter_from_user_mode+0x1d/0x70
> ? trace_hardirqs_on+0x2c/0xe0
> do_syscall_64+0x33/0x40
> entry_SYSCALL_64_after_hwframe+0x44/0xa9
> RIP: 0033:0x7f912675f2d7
> Code: 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa
> 89 fa be 69 19 12 28 bf ad de e1 fe b8 a9 00 00 00 0f 05 <48> 3d 00 f0 ff ff
> 77 01 c3 48 8b 15 81 8b 0c 00 f7 d8 64 89 02 b8
> RSP: 002b:7ffeca28e148 EFLAGS: 0206 ORIG_RAX: 00a9
> RAX: ffda RBX: RCX: 7f912675f2d7
> RDX: 01234567 RSI: 28121969 RDI: fee1dead
> RBP: 7ffeca28e3d0 R08: 000a R09:
> R10: 0232 R11: 0206 R12: 0001
> R13: R14: R15: 7ffeca28e4b8
> ---[ end trace 2ed17eabd3ab6938 ]---
> [ cut here ]
>
> The bisect came to this commit:
>
> fe0f1e3bfdfeb53e18f1206aea4f40b9bd1f291c
> ("drm/i915: Shut down displays gracefully on reboot")
>
> Which makes sense, as it happens on shutdown.
>
> -- Steve
[BUG] on reboot: bisected to: drm/i915: Shut down displays gracefully on reboot
On reboot, one of my test boxes now triggers the following warning:
[ cut here ]
RPM raw-wakeref not held
WARNING: CPU: 4 PID: 1 at drivers/gpu/drm/i915/intel_runtime_pm.h:106
gen6_write32+0x1bc/0x2a0 [i915]
Modules linked in: ebtable_filter ebtables bridge stp llc ip6t_REJECT
nf_reject_ipv6 vsock vmw_vmci xt_state xt_conntrack nf_conntrack nf_defrag_ipv6
nf_defrag_ipv4 ip6table_filter ip6_tables snd_hda_codec_hdmi
snd_hda_codec_realtek snd_hda_codec_generic le
15 snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep i2c_algo_bit
snd_hda_core snd_seq intel_rapl_msr snd_seq_device intel_rapl_common snd_pcm
x86_pkg_temp_thermal intel_powerclamp snd_timer snd coretemp kvm_intel
soundcore kvm mei_wdt irqbypass joydev
_pmc_bxt hp_wmi wmi_bmof sparse_keymap rfkill iTCO_vendor_support
crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel drm_kms_helper
i2c_i801 cec drm rapl intel_cstate intel_uncore mei_me i2c_smbus e1000e
tpm_infineon wmi serio_raw mei video lpc_i
CPU: 4 PID: 1 Comm: systemd-shutdow Not tainted 5.9.0-rc4-test+ #861
Hardware name: Hewlett-Packard HP Compaq Pro 6300 SFF/339A, BIOS K01 v03.03
07/14/2016
RIP: 0010:gen6_write32+0x1bc/0x2a0 [i915]
Code: 5d 82 e0 0f 0b e9 b5 fe ff ff 80 3d 95 6b 22 00 00 0f 85 b2 fe ff ff 48
c7 c7 04 d2 a4 c0 c6 05 81 6b 22 00 01 e8 f6 5c 82 e0 <0f> 0b e9 98 fe ff ff 80
3d 6d 6b 22 00 00 0f 85 95 fe ff ff 48 c7
RSP: 0018:b9c1c002fd08 EFLAGS: 00010296
RAX: 0018 RBX: 99aec8881010 RCX: 99aeda40
RDX: RSI: a115d9ef RDI: a115d9ef
RBP: 00044004 R08: 0001 R09:
R10: 0001 R11: 0001 R12:
R13: 0001 R14: R15:
FS: 7f91257a9940() GS:99aeda40() knlGS:
CS: 0010 DS: ES: CR0: 80050033
CR2: 7f9126829400 CR3: 0001088f0006 CR4: 001706e0
Call Trace:
gen3_irq_reset+0x2e/0xd0 [i915]
intel_irq_reset+0x59/0x6a0 [i915]
intel_runtime_pm_disable_interrupts+0xe/0x30 [i915]
i915_driver_shutdown+0x2e/0x40 [i915]
pci_device_shutdown+0x34/0x60
device_shutdown+0x15d/0x1b3
kernel_restart+0xe/0x30
__do_sys_reboot+0x1d7/0x210
? vfs_writev+0x9d/0xe0
? syscall_enter_from_user_mode+0x1d/0x70
? trace_hardirqs_on+0x2c/0xe0
do_syscall_64+0x33/0x40
entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x7f912675f2d7
Code: 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 89
fa be 69 19 12 28 bf ad de e1 fe b8 a9 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01
c3 48 8b 15 81 8b 0c 00 f7 d8 64 89 02 b8
RSP: 002b:7ffeca28e148 EFLAGS: 0206 ORIG_RAX: 00a9
RAX: ffda RBX: RCX: 7f912675f2d7
RDX: 01234567 RSI: 28121969 RDI: fee1dead
RBP: 7ffeca28e3d0 R08: 000a R09:
R10: 0232 R11: 0206 R12: 0001
R13: R14: R15: 7ffeca28e4b8
---[ end trace 2ed17eabd3ab6938 ]---
[ cut here ]
The bisect came to this commit:
fe0f1e3bfdfeb53e18f1206aea4f40b9bd1f291c
("drm/i915: Shut down displays gracefully on reboot")
Which makes sense, as it happens on shutdown.
-- Steve
