Re: [PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On Fri, Feb 22, 2008 at 11:25:04AM -0800, Randy Dunlap wrote: > Let's see what the ACPI people think about this change. > > Thanks, Sam. > --- > From: Randy Dunlap <[EMAIL PROTECTED]> > > Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived > value, based on the value of ACPI_CUSTOM_DSDT_FILE (string). > Only the latter is presented to the user as a config option. > > This fixes problems with "make randconfig" setting ACPI_CUSTOM_DSDT > but leaving ACPI_CUSTOM_DSDT_FILE empty/blank. > Thanks, the patch solves the build failure. Tested-by: Kamalesh Babulal <[EMAIL PROTECTED]> Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/acpi/Kconfig | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) --- linux-2.6.25-rc2-git5.orig/drivers/acpi/Kconfig +++ linux-2.6.25-rc2-git5/drivers/acpi/Kconfig @@ -283,24 +283,23 @@ config ACPI_TOSHIBA If you have a legacy free Toshiba laptop (such as the Libretto L1 series), say Y. -config ACPI_CUSTOM_DSDT - bool "Include Custom DSDT" +config ACPI_CUSTOM_DSDT_FILE + string "Custom DSDT Table file to include" + default "" depends on !STANDALONE - default n help This option supports a custom DSDT by linking it into the kernel. See Documentation/acpi/dsdt-override.txt - If unsure, say N. - -config ACPI_CUSTOM_DSDT_FILE - string "Custom DSDT Table file to include" - depends on ACPI_CUSTOM_DSDT - default "" - help Enter the full path name to the file which includes the AmlCode declaration. + If unsure, don't enter a file name. + +config ACPI_CUSTOM_DSDT + bool + default ACPI_CUSTOM_DSDT_FILE != "" + config ACPI_CUSTOM_DSDT_INITRD bool "Read Custom DSDT from initramfs" depends on BLK_DEV_INITRD After applying the patch and continuing with the same randconfig reported earlier, the build fails with following error drivers/acpi/thermal.c: In function ‘acpi_thermal_init’: drivers/acpi/thermal.c:1792: error: ‘thermal_dmi_table’ undeclared (first use in this function) drivers/acpi/thermal.c:1792: error: (Each undeclared identifier is reported only once drivers/acpi/thermal.c:1792: error: for each function it appears in.) make[2]: *** [drivers/acpi/thermal.o] Error 1 make[1]: *** [drivers/acpi] Error 2 make: *** [drivers] Error 2 I have tested the patch for build failure only. Signed-off-by: Kamalesh Babulal <[EMAIL PROTECTED]> -- --- linux-2.6.25-rc2/drivers/acpi/Kconfig 2008-02-23 19:54:11.0 +0530 +++ linux-2.6.25-rc2/drivers/acpi/~Kconfig 2008-02-24 04:16:07.0 +0530 @@ -187,7 +187,7 @@ config ACPI_HOTPLUG_CPU config ACPI_THERMAL tristate "Thermal Zone" - depends on ACPI_PROCESSOR + depends on ACPI_PROCESSOR && DMI select THERMAL default y help -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On Fri, Feb 22, 2008 at 11:25:04AM -0800, Randy Dunlap wrote: Let's see what the ACPI people think about this change. Thanks, Sam. --- From: Randy Dunlap [EMAIL PROTECTED] Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived value, based on the value of ACPI_CUSTOM_DSDT_FILE (string). Only the latter is presented to the user as a config option. This fixes problems with make randconfig setting ACPI_CUSTOM_DSDT but leaving ACPI_CUSTOM_DSDT_FILE empty/blank. Thanks, the patch solves the build failure. Tested-by: Kamalesh Babulal [EMAIL PROTECTED] Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/acpi/Kconfig | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) --- linux-2.6.25-rc2-git5.orig/drivers/acpi/Kconfig +++ linux-2.6.25-rc2-git5/drivers/acpi/Kconfig @@ -283,24 +283,23 @@ config ACPI_TOSHIBA If you have a legacy free Toshiba laptop (such as the Libretto L1 series), say Y. -config ACPI_CUSTOM_DSDT - bool Include Custom DSDT +config ACPI_CUSTOM_DSDT_FILE + string Custom DSDT Table file to include + default depends on !STANDALONE - default n help This option supports a custom DSDT by linking it into the kernel. See Documentation/acpi/dsdt-override.txt - If unsure, say N. - -config ACPI_CUSTOM_DSDT_FILE - string Custom DSDT Table file to include - depends on ACPI_CUSTOM_DSDT - default - help Enter the full path name to the file which includes the AmlCode declaration. + If unsure, don't enter a file name. + +config ACPI_CUSTOM_DSDT + bool + default ACPI_CUSTOM_DSDT_FILE != + config ACPI_CUSTOM_DSDT_INITRD bool Read Custom DSDT from initramfs depends on BLK_DEV_INITRD After applying the patch and continuing with the same randconfig reported earlier, the build fails with following error drivers/acpi/thermal.c: In function ‘acpi_thermal_init’: drivers/acpi/thermal.c:1792: error: ‘thermal_dmi_table’ undeclared (first use in this function) drivers/acpi/thermal.c:1792: error: (Each undeclared identifier is reported only once drivers/acpi/thermal.c:1792: error: for each function it appears in.) make[2]: *** [drivers/acpi/thermal.o] Error 1 make[1]: *** [drivers/acpi] Error 2 make: *** [drivers] Error 2 I have tested the patch for build failure only. Signed-off-by: Kamalesh Babulal [EMAIL PROTECTED] -- --- linux-2.6.25-rc2/drivers/acpi/Kconfig 2008-02-23 19:54:11.0 +0530 +++ linux-2.6.25-rc2/drivers/acpi/~Kconfig 2008-02-24 04:16:07.0 +0530 @@ -187,7 +187,7 @@ config ACPI_HOTPLUG_CPU config ACPI_THERMAL tristate Thermal Zone - depends on ACPI_PROCESSOR + depends on ACPI_PROCESSOR DMI select THERMAL default y help -- Thanks Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
works for me! applied. thanks, -len ps. CONFIG_ACPI_CUSTOM_DSDT's only use is to guard the use of CONFIG_ACPI_CUSTOM_DSDT_FILE: #ifdef CONFIG_ACPI_CUSTOM_DSDT #include CONFIG_ACPI_CUSTOM_DSDT_FILE #endif we could get rid of it if cpp could so something like #if (CONFIG_ACPI_CUSTOM_DSDT_FILE != "") #include CONFIG_ACPI_CUSTOM_DSDT_FILE #endif but it doesn't look like cpp has a concept of strings in expressions. On Friday 22 February 2008 14:25, Randy Dunlap wrote: > Let's see what the ACPI people think about this change. > > Thanks, Sam. > --- > From: Randy Dunlap <[EMAIL PROTECTED]> > > Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived > value, based on the value of ACPI_CUSTOM_DSDT_FILE (string). > Only the latter is presented to the user as a config option. > > This fixes problems with "make randconfig" setting ACPI_CUSTOM_DSDT > but leaving ACPI_CUSTOM_DSDT_FILE empty/blank. > > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> > --- > drivers/acpi/Kconfig | 19 +-- > 1 file changed, 9 insertions(+), 10 deletions(-) > > --- linux-2.6.25-rc2-git5.orig/drivers/acpi/Kconfig > +++ linux-2.6.25-rc2-git5/drivers/acpi/Kconfig > @@ -283,24 +283,23 @@ config ACPI_TOSHIBA > If you have a legacy free Toshiba laptop (such as the Libretto L1 > series), say Y. > > -config ACPI_CUSTOM_DSDT > - bool "Include Custom DSDT" > +config ACPI_CUSTOM_DSDT_FILE > + string "Custom DSDT Table file to include" > + default "" > depends on !STANDALONE > - default n > help > This option supports a custom DSDT by linking it into the kernel. > See Documentation/acpi/dsdt-override.txt > > - If unsure, say N. > - > -config ACPI_CUSTOM_DSDT_FILE > - string "Custom DSDT Table file to include" > - depends on ACPI_CUSTOM_DSDT > - default "" > - help > Enter the full path name to the file which includes the AmlCode > declaration. > > + If unsure, don't enter a file name. > + > +config ACPI_CUSTOM_DSDT > + bool > + default ACPI_CUSTOM_DSDT_FILE != "" > + > config ACPI_CUSTOM_DSDT_INITRD > bool "Read Custom DSDT from initramfs" > depends on BLK_DEV_INITRD > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
Let's see what the ACPI people think about this change. Thanks, Sam. --- From: Randy Dunlap <[EMAIL PROTECTED]> Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived value, based on the value of ACPI_CUSTOM_DSDT_FILE (string). Only the latter is presented to the user as a config option. This fixes problems with "make randconfig" setting ACPI_CUSTOM_DSDT but leaving ACPI_CUSTOM_DSDT_FILE empty/blank. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/acpi/Kconfig | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) --- linux-2.6.25-rc2-git5.orig/drivers/acpi/Kconfig +++ linux-2.6.25-rc2-git5/drivers/acpi/Kconfig @@ -283,24 +283,23 @@ config ACPI_TOSHIBA If you have a legacy free Toshiba laptop (such as the Libretto L1 series), say Y. -config ACPI_CUSTOM_DSDT - bool "Include Custom DSDT" +config ACPI_CUSTOM_DSDT_FILE + string "Custom DSDT Table file to include" + default "" depends on !STANDALONE - default n help This option supports a custom DSDT by linking it into the kernel. See Documentation/acpi/dsdt-override.txt - If unsure, say N. - -config ACPI_CUSTOM_DSDT_FILE - string "Custom DSDT Table file to include" - depends on ACPI_CUSTOM_DSDT - default "" - help Enter the full path name to the file which includes the AmlCode declaration. + If unsure, don't enter a file name. + +config ACPI_CUSTOM_DSDT + bool + default ACPI_CUSTOM_DSDT_FILE != "" + config ACPI_CUSTOM_DSDT_INITRD bool "Read Custom DSDT from initramfs" depends on BLK_DEV_INITRD -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On Fri, Feb 22, 2008 at 10:29:38AM -0800, Randy Dunlap wrote: > Sam Ravnborg wrote: > >>Is there a way to generate (in Kconfig language) the boolean > >>CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE > >>== "" or != "" ? I tried to muck around with that last night but > >>couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE > >>config symbol to the user and then generate the ACPI_CUSTOM_DSDT bool > >>based on the string value. > > > >Something following this example? > > > >config STRING > >string > >prompt "What string" > >default "" > > > >config STRING_IS_NOT_EMPTY > >bool > >default STRING != "" > > > > > >But that seems too easy - were you trying to do something > >more complex than this? > > Yes, that's almost what I had. I used def_bool n on the second config > symbol, > but the bool value never changed when I changed the string value. > I'll be glad to look at it again though. I tested that above in a small Kconfig file and it works as expected. When I set the string to something STRING_IS_NOT_EMPTY is equal to y. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
Sam Ravnborg wrote: Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == "" or != "" ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config symbol to the user and then generate the ACPI_CUSTOM_DSDT bool based on the string value. Something following this example? config STRING string prompt "What string" default "" config STRING_IS_NOT_EMPTY bool default STRING != "" But that seems too easy - were you trying to do something more complex than this? Yes, that's almost what I had. I used def_bool n on the second config symbol, but the bool value never changed when I changed the string value. I'll be glad to look at it again though. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
> > Is there a way to generate (in Kconfig language) the boolean > CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE > == "" or != "" ? I tried to muck around with that last night but > couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE > config symbol to the user and then generate the ACPI_CUSTOM_DSDT bool > based on the string value. Something following this example? config STRING string prompt "What string" default "" config STRING_IS_NOT_EMPTY bool default STRING != "" But that seems too easy - were you trying to do something more complex than this? Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On 2/22/08, Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Fri, 22 Feb 2008 19:08:15 +0100 Sam Ravnborg wrote: > > > On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: > > > On 2/21/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > > On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: > > > > > On 2/20/08, Len Brown <[EMAIL PROTECTED]> wrote: > > > > > > On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: > > > > > > > Hi Andrew, > > > > > > > > > > > > > > The 2.6.25-rc2-mm1 kernel with randconfig build option, fails > > > > > > > to build on x86_64 machine > > > > > > > > > > > > > > CC drivers/acpi/osl.o > > > > > > > drivers/acpi/osl.c:60:38: error: empty filename in #include > > > > > > > drivers/acpi/osl.c: In function 'acpi_os_table_override': > > > > > > > drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use > in this function) > > > > > > > drivers/acpi/osl.c:399: error: (Each undeclared identifier is > reported only once > > > > > > > drivers/acpi/osl.c:399: error: for each function it appears > in.) > > > > > > > make[2]: *** [drivers/acpi/osl.o] Error 1 > > > > > > > make[1]: *** [drivers/acpi] Error 2 > > > > > > > make: *** [drivers] Error 2 > > > > > > > > > > > > > > # > > > > > > > # Automatically generated make config: don't edit > > > > > > > # Linux kernel version: 2.6.25-rc2-mm1 > > > > > > > # Sun Feb 17 08:07:17 2008 > > > > > > > # > > > > > > > > > > > > > > > > > > > CONFIG_ACPI_CUSTOM_DSDT=y > > > > > > > CONFIG_ACPI_CUSTOM_DSDT_FILE="" > > > > > > > > > > > > > > > > > > garbage in, garbage out. > > > > > > > > > > garbage explicitly *allowed* by Kconfig in this case, though. > > > > > > > > > > > If you don't give this build option a file name where AmlCode > lives, > > > > > > then the build will be unable to find AmlCode[]. > > > > > > > > > > > > http://www.lesswatts.org/projects/acpi/overridingDSDT.php > > > > > > > > > > So we have a .config option whose sole purpose is to use another > > > > > .config option? That seems ... less than ideal. Is there not some > > > > > Kconfig voodoo we can do to only require the one option? Maybe > > > > > something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to > the > > > > > Cc, in case he has any ideas. > > > > > > > > > > > > Make sure STANDALONE is y for your randconfig builds. > > > > See README for examples. > > > > > > Hrm, if this is needed for randconfig to work, perhaps randconfig > > > itself should somehow be specifying it? > > > > > > > STANALONE is there exactly to prevent the above but we cannot > > > > control randconfig. > > > > > > While setting STANDALONE does fix the above, it doesn't answer the > > > more basic question I had -- do we really need both .config options in > > > this case? If it's simply a case of "That's how it is, won't be fixed, > > > there are higher priorities", that's good enough by me. Just seems a > > > shame that we have an option to enable another option, which is > > > required for the first option to be sensible -- seems like we should > > > only need the second option... > > > > I really do not see what problem you are trying to address. > > > > STANDALONE is there as an easy way to turn of the options that requires > > sensible input to make a kernel compile. > > > > And that makes _perfect_ sense when you do randconfig builds. > > > > CONFIG_ACPI_CUSTOM_DSDT=y > > CONFIG_ACPI_CUSTOM_DSDT_FILE="" > > > Is there a way to generate (in Kconfig language) the boolean > CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE > == "" or != "" ? I tried to muck around with that last night but > couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE > config symbol to the user and then generate the ACPI_CUSTOM_DSDT bool > based on the string value. Thanks for re-expressing my question, Randy, this is exactly what I'm wondering. Thanks, Nish -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On Fri, 22 Feb 2008 19:08:15 +0100 Sam Ravnborg wrote: > On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: > > On 2/21/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: > > > > On 2/20/08, Len Brown <[EMAIL PROTECTED]> wrote: > > > > > On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: > > > > > > Hi Andrew, > > > > > > > > > > > > The 2.6.25-rc2-mm1 kernel with randconfig build option, fails > > > > > > to build on x86_64 machine > > > > > > > > > > > > CC drivers/acpi/osl.o > > > > > > drivers/acpi/osl.c:60:38: error: empty filename in #include > > > > > > drivers/acpi/osl.c: In function 'acpi_os_table_override': > > > > > > drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use in > > > this function) > > > > > > drivers/acpi/osl.c:399: error: (Each undeclared identifier is > > > reported only once > > > > > > drivers/acpi/osl.c:399: error: for each function it appears in.) > > > > > > make[2]: *** [drivers/acpi/osl.o] Error 1 > > > > > > make[1]: *** [drivers/acpi] Error 2 > > > > > > make: *** [drivers] Error 2 > > > > > > > > > > > > # > > > > > > # Automatically generated make config: don't edit > > > > > > # Linux kernel version: 2.6.25-rc2-mm1 > > > > > > # Sun Feb 17 08:07:17 2008 > > > > > > # > > > > > > > > > > > > > > > > CONFIG_ACPI_CUSTOM_DSDT=y > > > > > > CONFIG_ACPI_CUSTOM_DSDT_FILE="" > > > > > > > > > > > > > > > garbage in, garbage out. > > > > > > > > garbage explicitly *allowed* by Kconfig in this case, though. > > > > > > > > > If you don't give this build option a file name where AmlCode lives, > > > > > then the build will be unable to find AmlCode[]. > > > > > > > > > > http://www.lesswatts.org/projects/acpi/overridingDSDT.php > > > > > > > > So we have a .config option whose sole purpose is to use another > > > > .config option? That seems ... less than ideal. Is there not some > > > > Kconfig voodoo we can do to only require the one option? Maybe > > > > something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to the > > > > Cc, in case he has any ideas. > > > > > > > > > Make sure STANDALONE is y for your randconfig builds. > > > See README for examples. > > > > Hrm, if this is needed for randconfig to work, perhaps randconfig > > itself should somehow be specifying it? > > > > > STANALONE is there exactly to prevent the above but we cannot > > > control randconfig. > > > > While setting STANDALONE does fix the above, it doesn't answer the > > more basic question I had -- do we really need both .config options in > > this case? If it's simply a case of "That's how it is, won't be fixed, > > there are higher priorities", that's good enough by me. Just seems a > > shame that we have an option to enable another option, which is > > required for the first option to be sensible -- seems like we should > > only need the second option... > > I really do not see what problem you are trying to address. > > STANDALONE is there as an easy way to turn of the options that requires > sensible input to make a kernel compile. > > And that makes _perfect_ sense when you do randconfig builds. > CONFIG_ACPI_CUSTOM_DSDT=y > CONFIG_ACPI_CUSTOM_DSDT_FILE="" Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == "" or != "" ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config symbol to the user and then generate the ACPI_CUSTOM_DSDT bool based on the string value. --- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On 2/22/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: > > On 2/21/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: > > > > On 2/20/08, Len Brown <[EMAIL PROTECTED]> wrote: > > > > > On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: > > > > > > Hi Andrew, > > > > > > > > > > > > The 2.6.25-rc2-mm1 kernel with randconfig build option, fails > > > > > > to build on x86_64 machine > > > > > > > > > > > > CC drivers/acpi/osl.o > > > > > > drivers/acpi/osl.c:60:38: error: empty filename in #include > > > > > > drivers/acpi/osl.c: In function 'acpi_os_table_override': > > > > > > drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use > in this function) > > > > > > drivers/acpi/osl.c:399: error: (Each undeclared identifier is > reported only once > > > > > > drivers/acpi/osl.c:399: error: for each function it appears in.) > > > > > > make[2]: *** [drivers/acpi/osl.o] Error 1 > > > > > > make[1]: *** [drivers/acpi] Error 2 > > > > > > make: *** [drivers] Error 2 > > > > > > > > > > > > # > > > > > > # Automatically generated make config: don't edit > > > > > > # Linux kernel version: 2.6.25-rc2-mm1 > > > > > > # Sun Feb 17 08:07:17 2008 > > > > > > # > > > > > > > > > > > > > > > > CONFIG_ACPI_CUSTOM_DSDT=y > > > > > > CONFIG_ACPI_CUSTOM_DSDT_FILE="" > > > > > > > > > > > > > > > garbage in, garbage out. > > > > > > > > garbage explicitly *allowed* by Kconfig in this case, though. > > > > > > > > > If you don't give this build option a file name where AmlCode > lives, > > > > > then the build will be unable to find AmlCode[]. > > > > > > > > > > http://www.lesswatts.org/projects/acpi/overridingDSDT.php > > > > > > > > So we have a .config option whose sole purpose is to use another > > > > .config option? That seems ... less than ideal. Is there not some > > > > Kconfig voodoo we can do to only require the one option? Maybe > > > > something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to the > > > > Cc, in case he has any ideas. > > > > > > > > > Make sure STANDALONE is y for your randconfig builds. > > > See README for examples. > > > > Hrm, if this is needed for randconfig to work, perhaps randconfig > > itself should somehow be specifying it? > > > > > STANALONE is there exactly to prevent the above but we cannot > > > control randconfig. > > > > While setting STANDALONE does fix the above, it doesn't answer the > > more basic question I had -- do we really need both .config options in > > this case? If it's simply a case of "That's how it is, won't be fixed, > > there are higher priorities", that's good enough by me. Just seems a > > shame that we have an option to enable another option, which is > > required for the first option to be sensible -- seems like we should > > only need the second option... > > > I really do not see what problem you are trying to address. > > STANDALONE is there as an easy way to turn of the options that requires > sensible input to make a kernel compile. > > And that makes _perfect_ sense when you do randconfig builds. Yes it does. As I said above I'm *not* arguing about using STANDALONE for randconfig builds. What I was doing, perhaps unclearly, was asking if there was a real Kconfig need to have both CONFIG_ACPI_CUSTOM_DSDT and CONFIG_ACPI_CUSTOM_DSDT_FILE, when the latter *only* is visible with the former and the former *only* makes sense with the latter. Couldn't we just have CONFIG_ACPI_CUSTOM_DSDT_FILE and check that in the code? Why do we need a boolean option to make another string option available? Thanks, Nish -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: > On 2/21/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: > > > On 2/20/08, Len Brown <[EMAIL PROTECTED]> wrote: > > > > On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: > > > > > Hi Andrew, > > > > > > > > > > The 2.6.25-rc2-mm1 kernel with randconfig build option, fails > > > > > to build on x86_64 machine > > > > > > > > > > CC drivers/acpi/osl.o > > > > > drivers/acpi/osl.c:60:38: error: empty filename in #include > > > > > drivers/acpi/osl.c: In function 'acpi_os_table_override': > > > > > drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use in > > this function) > > > > > drivers/acpi/osl.c:399: error: (Each undeclared identifier is > > reported only once > > > > > drivers/acpi/osl.c:399: error: for each function it appears in.) > > > > > make[2]: *** [drivers/acpi/osl.o] Error 1 > > > > > make[1]: *** [drivers/acpi] Error 2 > > > > > make: *** [drivers] Error 2 > > > > > > > > > > # > > > > > # Automatically generated make config: don't edit > > > > > # Linux kernel version: 2.6.25-rc2-mm1 > > > > > # Sun Feb 17 08:07:17 2008 > > > > > # > > > > > > > > > > > > > CONFIG_ACPI_CUSTOM_DSDT=y > > > > > CONFIG_ACPI_CUSTOM_DSDT_FILE="" > > > > > > > > > > > > garbage in, garbage out. > > > > > > garbage explicitly *allowed* by Kconfig in this case, though. > > > > > > > If you don't give this build option a file name where AmlCode lives, > > > > then the build will be unable to find AmlCode[]. > > > > > > > > http://www.lesswatts.org/projects/acpi/overridingDSDT.php > > > > > > So we have a .config option whose sole purpose is to use another > > > .config option? That seems ... less than ideal. Is there not some > > > Kconfig voodoo we can do to only require the one option? Maybe > > > something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to the > > > Cc, in case he has any ideas. > > > > > > Make sure STANDALONE is y for your randconfig builds. > > See README for examples. > > Hrm, if this is needed for randconfig to work, perhaps randconfig > itself should somehow be specifying it? > > > STANALONE is there exactly to prevent the above but we cannot > > control randconfig. > > While setting STANDALONE does fix the above, it doesn't answer the > more basic question I had -- do we really need both .config options in > this case? If it's simply a case of "That's how it is, won't be fixed, > there are higher priorities", that's good enough by me. Just seems a > shame that we have an option to enable another option, which is > required for the first option to be sensible -- seems like we should > only need the second option... I really do not see what problem you are trying to address. STANDALONE is there as an easy way to turn of the options that requires sensible input to make a kernel compile. And that makes _perfect_ sense when you do randconfig builds. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: On 2/20/08, Len Brown [EMAIL PROTECTED] wrote: On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function 'acpi_os_table_override': drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use in this function) drivers/acpi/osl.c:399: error: (Each undeclared identifier is reported only once drivers/acpi/osl.c:399: error: for each function it appears in.) make[2]: *** [drivers/acpi/osl.o] Error 1 make[1]: *** [drivers/acpi] Error 2 make: *** [drivers] Error 2 # # Automatically generated make config: don't edit # Linux kernel version: 2.6.25-rc2-mm1 # Sun Feb 17 08:07:17 2008 # CONFIG_ACPI_CUSTOM_DSDT=y CONFIG_ACPI_CUSTOM_DSDT_FILE= garbage in, garbage out. garbage explicitly *allowed* by Kconfig in this case, though. If you don't give this build option a file name where AmlCode lives, then the build will be unable to find AmlCode[]. http://www.lesswatts.org/projects/acpi/overridingDSDT.php So we have a .config option whose sole purpose is to use another .config option? That seems ... less than ideal. Is there not some Kconfig voodoo we can do to only require the one option? Maybe something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to the Cc, in case he has any ideas. Make sure STANDALONE is y for your randconfig builds. See README for examples. Hrm, if this is needed for randconfig to work, perhaps randconfig itself should somehow be specifying it? STANALONE is there exactly to prevent the above but we cannot control randconfig. While setting STANDALONE does fix the above, it doesn't answer the more basic question I had -- do we really need both .config options in this case? If it's simply a case of That's how it is, won't be fixed, there are higher priorities, that's good enough by me. Just seems a shame that we have an option to enable another option, which is required for the first option to be sensible -- seems like we should only need the second option... I really do not see what problem you are trying to address. STANDALONE is there as an easy way to turn of the options that requires sensible input to make a kernel compile. And that makes _perfect_ sense when you do randconfig builds. Sam -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On 2/22/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: On 2/20/08, Len Brown [EMAIL PROTECTED] wrote: On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function 'acpi_os_table_override': drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use in this function) drivers/acpi/osl.c:399: error: (Each undeclared identifier is reported only once drivers/acpi/osl.c:399: error: for each function it appears in.) make[2]: *** [drivers/acpi/osl.o] Error 1 make[1]: *** [drivers/acpi] Error 2 make: *** [drivers] Error 2 # # Automatically generated make config: don't edit # Linux kernel version: 2.6.25-rc2-mm1 # Sun Feb 17 08:07:17 2008 # CONFIG_ACPI_CUSTOM_DSDT=y CONFIG_ACPI_CUSTOM_DSDT_FILE= garbage in, garbage out. garbage explicitly *allowed* by Kconfig in this case, though. If you don't give this build option a file name where AmlCode lives, then the build will be unable to find AmlCode[]. http://www.lesswatts.org/projects/acpi/overridingDSDT.php So we have a .config option whose sole purpose is to use another .config option? That seems ... less than ideal. Is there not some Kconfig voodoo we can do to only require the one option? Maybe something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to the Cc, in case he has any ideas. Make sure STANDALONE is y for your randconfig builds. See README for examples. Hrm, if this is needed for randconfig to work, perhaps randconfig itself should somehow be specifying it? STANALONE is there exactly to prevent the above but we cannot control randconfig. While setting STANDALONE does fix the above, it doesn't answer the more basic question I had -- do we really need both .config options in this case? If it's simply a case of That's how it is, won't be fixed, there are higher priorities, that's good enough by me. Just seems a shame that we have an option to enable another option, which is required for the first option to be sensible -- seems like we should only need the second option... I really do not see what problem you are trying to address. STANDALONE is there as an easy way to turn of the options that requires sensible input to make a kernel compile. And that makes _perfect_ sense when you do randconfig builds. Yes it does. As I said above I'm *not* arguing about using STANDALONE for randconfig builds. What I was doing, perhaps unclearly, was asking if there was a real Kconfig need to have both CONFIG_ACPI_CUSTOM_DSDT and CONFIG_ACPI_CUSTOM_DSDT_FILE, when the latter *only* is visible with the former and the former *only* makes sense with the latter. Couldn't we just have CONFIG_ACPI_CUSTOM_DSDT_FILE and check that in the code? Why do we need a boolean option to make another string option available? Thanks, Nish -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On Fri, 22 Feb 2008 19:08:15 +0100 Sam Ravnborg wrote: On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: On 2/20/08, Len Brown [EMAIL PROTECTED] wrote: On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function 'acpi_os_table_override': drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use in this function) drivers/acpi/osl.c:399: error: (Each undeclared identifier is reported only once drivers/acpi/osl.c:399: error: for each function it appears in.) make[2]: *** [drivers/acpi/osl.o] Error 1 make[1]: *** [drivers/acpi] Error 2 make: *** [drivers] Error 2 # # Automatically generated make config: don't edit # Linux kernel version: 2.6.25-rc2-mm1 # Sun Feb 17 08:07:17 2008 # CONFIG_ACPI_CUSTOM_DSDT=y CONFIG_ACPI_CUSTOM_DSDT_FILE= garbage in, garbage out. garbage explicitly *allowed* by Kconfig in this case, though. If you don't give this build option a file name where AmlCode lives, then the build will be unable to find AmlCode[]. http://www.lesswatts.org/projects/acpi/overridingDSDT.php So we have a .config option whose sole purpose is to use another .config option? That seems ... less than ideal. Is there not some Kconfig voodoo we can do to only require the one option? Maybe something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to the Cc, in case he has any ideas. Make sure STANDALONE is y for your randconfig builds. See README for examples. Hrm, if this is needed for randconfig to work, perhaps randconfig itself should somehow be specifying it? STANALONE is there exactly to prevent the above but we cannot control randconfig. While setting STANDALONE does fix the above, it doesn't answer the more basic question I had -- do we really need both .config options in this case? If it's simply a case of That's how it is, won't be fixed, there are higher priorities, that's good enough by me. Just seems a shame that we have an option to enable another option, which is required for the first option to be sensible -- seems like we should only need the second option... I really do not see what problem you are trying to address. STANDALONE is there as an easy way to turn of the options that requires sensible input to make a kernel compile. And that makes _perfect_ sense when you do randconfig builds. CONFIG_ACPI_CUSTOM_DSDT=y CONFIG_ACPI_CUSTOM_DSDT_FILE= Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == or != ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config symbol to the user and then generate the ACPI_CUSTOM_DSDT bool based on the string value. --- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On 2/22/08, Randy Dunlap [EMAIL PROTECTED] wrote: On Fri, 22 Feb 2008 19:08:15 +0100 Sam Ravnborg wrote: On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: On 2/20/08, Len Brown [EMAIL PROTECTED] wrote: On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function 'acpi_os_table_override': drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use in this function) drivers/acpi/osl.c:399: error: (Each undeclared identifier is reported only once drivers/acpi/osl.c:399: error: for each function it appears in.) make[2]: *** [drivers/acpi/osl.o] Error 1 make[1]: *** [drivers/acpi] Error 2 make: *** [drivers] Error 2 # # Automatically generated make config: don't edit # Linux kernel version: 2.6.25-rc2-mm1 # Sun Feb 17 08:07:17 2008 # CONFIG_ACPI_CUSTOM_DSDT=y CONFIG_ACPI_CUSTOM_DSDT_FILE= garbage in, garbage out. garbage explicitly *allowed* by Kconfig in this case, though. If you don't give this build option a file name where AmlCode lives, then the build will be unable to find AmlCode[]. http://www.lesswatts.org/projects/acpi/overridingDSDT.php So we have a .config option whose sole purpose is to use another .config option? That seems ... less than ideal. Is there not some Kconfig voodoo we can do to only require the one option? Maybe something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to the Cc, in case he has any ideas. Make sure STANDALONE is y for your randconfig builds. See README for examples. Hrm, if this is needed for randconfig to work, perhaps randconfig itself should somehow be specifying it? STANALONE is there exactly to prevent the above but we cannot control randconfig. While setting STANDALONE does fix the above, it doesn't answer the more basic question I had -- do we really need both .config options in this case? If it's simply a case of That's how it is, won't be fixed, there are higher priorities, that's good enough by me. Just seems a shame that we have an option to enable another option, which is required for the first option to be sensible -- seems like we should only need the second option... I really do not see what problem you are trying to address. STANDALONE is there as an easy way to turn of the options that requires sensible input to make a kernel compile. And that makes _perfect_ sense when you do randconfig builds. CONFIG_ACPI_CUSTOM_DSDT=y CONFIG_ACPI_CUSTOM_DSDT_FILE= Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == or != ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config symbol to the user and then generate the ACPI_CUSTOM_DSDT bool based on the string value. Thanks for re-expressing my question, Randy, this is exactly what I'm wondering. Thanks, Nish -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == or != ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config symbol to the user and then generate the ACPI_CUSTOM_DSDT bool based on the string value. Something following this example? config STRING string prompt What string default config STRING_IS_NOT_EMPTY bool default STRING != But that seems too easy - were you trying to do something more complex than this? Sam -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
Sam Ravnborg wrote: Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == or != ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config symbol to the user and then generate the ACPI_CUSTOM_DSDT bool based on the string value. Something following this example? config STRING string prompt What string default config STRING_IS_NOT_EMPTY bool default STRING != But that seems too easy - were you trying to do something more complex than this? Yes, that's almost what I had. I used def_bool n on the second config symbol, but the bool value never changed when I changed the string value. I'll be glad to look at it again though. -- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On Fri, Feb 22, 2008 at 10:29:38AM -0800, Randy Dunlap wrote: Sam Ravnborg wrote: Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == or != ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config symbol to the user and then generate the ACPI_CUSTOM_DSDT bool based on the string value. Something following this example? config STRING string prompt What string default config STRING_IS_NOT_EMPTY bool default STRING != But that seems too easy - were you trying to do something more complex than this? Yes, that's almost what I had. I used def_bool n on the second config symbol, but the bool value never changed when I changed the string value. I'll be glad to look at it again though. I tested that above in a small Kconfig file and it works as expected. When I set the string to something STRING_IS_NOT_EMPTY is equal to y. Sam -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
Let's see what the ACPI people think about this change. Thanks, Sam. --- From: Randy Dunlap [EMAIL PROTECTED] Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived value, based on the value of ACPI_CUSTOM_DSDT_FILE (string). Only the latter is presented to the user as a config option. This fixes problems with make randconfig setting ACPI_CUSTOM_DSDT but leaving ACPI_CUSTOM_DSDT_FILE empty/blank. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/acpi/Kconfig | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) --- linux-2.6.25-rc2-git5.orig/drivers/acpi/Kconfig +++ linux-2.6.25-rc2-git5/drivers/acpi/Kconfig @@ -283,24 +283,23 @@ config ACPI_TOSHIBA If you have a legacy free Toshiba laptop (such as the Libretto L1 series), say Y. -config ACPI_CUSTOM_DSDT - bool Include Custom DSDT +config ACPI_CUSTOM_DSDT_FILE + string Custom DSDT Table file to include + default depends on !STANDALONE - default n help This option supports a custom DSDT by linking it into the kernel. See Documentation/acpi/dsdt-override.txt - If unsure, say N. - -config ACPI_CUSTOM_DSDT_FILE - string Custom DSDT Table file to include - depends on ACPI_CUSTOM_DSDT - default - help Enter the full path name to the file which includes the AmlCode declaration. + If unsure, don't enter a file name. + +config ACPI_CUSTOM_DSDT + bool + default ACPI_CUSTOM_DSDT_FILE != + config ACPI_CUSTOM_DSDT_INITRD bool Read Custom DSDT from initramfs depends on BLK_DEV_INITRD -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
works for me! applied. thanks, -len ps. CONFIG_ACPI_CUSTOM_DSDT's only use is to guard the use of CONFIG_ACPI_CUSTOM_DSDT_FILE: #ifdef CONFIG_ACPI_CUSTOM_DSDT #include CONFIG_ACPI_CUSTOM_DSDT_FILE #endif we could get rid of it if cpp could so something like #if (CONFIG_ACPI_CUSTOM_DSDT_FILE != ) #include CONFIG_ACPI_CUSTOM_DSDT_FILE #endif but it doesn't look like cpp has a concept of strings in expressions. On Friday 22 February 2008 14:25, Randy Dunlap wrote: Let's see what the ACPI people think about this change. Thanks, Sam. --- From: Randy Dunlap [EMAIL PROTECTED] Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived value, based on the value of ACPI_CUSTOM_DSDT_FILE (string). Only the latter is presented to the user as a config option. This fixes problems with make randconfig setting ACPI_CUSTOM_DSDT but leaving ACPI_CUSTOM_DSDT_FILE empty/blank. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/acpi/Kconfig | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) --- linux-2.6.25-rc2-git5.orig/drivers/acpi/Kconfig +++ linux-2.6.25-rc2-git5/drivers/acpi/Kconfig @@ -283,24 +283,23 @@ config ACPI_TOSHIBA If you have a legacy free Toshiba laptop (such as the Libretto L1 series), say Y. -config ACPI_CUSTOM_DSDT - bool Include Custom DSDT +config ACPI_CUSTOM_DSDT_FILE + string Custom DSDT Table file to include + default depends on !STANDALONE - default n help This option supports a custom DSDT by linking it into the kernel. See Documentation/acpi/dsdt-override.txt - If unsure, say N. - -config ACPI_CUSTOM_DSDT_FILE - string Custom DSDT Table file to include - depends on ACPI_CUSTOM_DSDT - default - help Enter the full path name to the file which includes the AmlCode declaration. + If unsure, don't enter a file name. + +config ACPI_CUSTOM_DSDT + bool + default ACPI_CUSTOM_DSDT_FILE != + config ACPI_CUSTOM_DSDT_INITRD bool Read Custom DSDT from initramfs depends on BLK_DEV_INITRD -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On 2/21/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: > > On 2/20/08, Len Brown <[EMAIL PROTECTED]> wrote: > > > On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: > > > > Hi Andrew, > > > > > > > > The 2.6.25-rc2-mm1 kernel with randconfig build option, fails > > > > to build on x86_64 machine > > > > > > > > CC drivers/acpi/osl.o > > > > drivers/acpi/osl.c:60:38: error: empty filename in #include > > > > drivers/acpi/osl.c: In function 'acpi_os_table_override': > > > > drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use in > this function) > > > > drivers/acpi/osl.c:399: error: (Each undeclared identifier is > reported only once > > > > drivers/acpi/osl.c:399: error: for each function it appears in.) > > > > make[2]: *** [drivers/acpi/osl.o] Error 1 > > > > make[1]: *** [drivers/acpi] Error 2 > > > > make: *** [drivers] Error 2 > > > > > > > > # > > > > # Automatically generated make config: don't edit > > > > # Linux kernel version: 2.6.25-rc2-mm1 > > > > # Sun Feb 17 08:07:17 2008 > > > > # > > > > > > > > > > CONFIG_ACPI_CUSTOM_DSDT=y > > > > CONFIG_ACPI_CUSTOM_DSDT_FILE="" > > > > > > > > > garbage in, garbage out. > > > > garbage explicitly *allowed* by Kconfig in this case, though. > > > > > If you don't give this build option a file name where AmlCode lives, > > > then the build will be unable to find AmlCode[]. > > > > > > http://www.lesswatts.org/projects/acpi/overridingDSDT.php > > > > So we have a .config option whose sole purpose is to use another > > .config option? That seems ... less than ideal. Is there not some > > Kconfig voodoo we can do to only require the one option? Maybe > > something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to the > > Cc, in case he has any ideas. > > > Make sure STANDALONE is y for your randconfig builds. > See README for examples. Hrm, if this is needed for randconfig to work, perhaps randconfig itself should somehow be specifying it? > STANALONE is there exactly to prevent the above but we cannot > control randconfig. While setting STANDALONE does fix the above, it doesn't answer the more basic question I had -- do we really need both .config options in this case? If it's simply a case of "That's how it is, won't be fixed, there are higher priorities", that's good enough by me. Just seems a shame that we have an option to enable another option, which is required for the first option to be sensible -- seems like we should only need the second option... Thanks, Nish -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On 2/20/08, Len Brown <[EMAIL PROTECTED]> wrote: > On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: > > Hi Andrew, > > > > The 2.6.25-rc2-mm1 kernel with randconfig build option, fails > > to build on x86_64 machine > > > > CC drivers/acpi/osl.o > > drivers/acpi/osl.c:60:38: error: empty filename in #include > > drivers/acpi/osl.c: In function 'acpi_os_table_override': > > drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use in this > function) > > drivers/acpi/osl.c:399: error: (Each undeclared identifier is reported > only once > > drivers/acpi/osl.c:399: error: for each function it appears in.) > > make[2]: *** [drivers/acpi/osl.o] Error 1 > > make[1]: *** [drivers/acpi] Error 2 > > make: *** [drivers] Error 2 > > > > # > > # Automatically generated make config: don't edit > > # Linux kernel version: 2.6.25-rc2-mm1 > > # Sun Feb 17 08:07:17 2008 > > # > > > > CONFIG_ACPI_CUSTOM_DSDT=y > > CONFIG_ACPI_CUSTOM_DSDT_FILE="" > > > garbage in, garbage out. garbage explicitly *allowed* by Kconfig in this case, though. > If you don't give this build option a file name where AmlCode lives, > then the build will be unable to find AmlCode[]. > > http://www.lesswatts.org/projects/acpi/overridingDSDT.php So we have a .config option whose sole purpose is to use another .config option? That seems ... less than ideal. Is there not some Kconfig voodoo we can do to only require the one option? Maybe something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to the Cc, in case he has any ideas. Thanks, Nish -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On 2/20/08, Len Brown [EMAIL PROTECTED] wrote: On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function 'acpi_os_table_override': drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use in this function) drivers/acpi/osl.c:399: error: (Each undeclared identifier is reported only once drivers/acpi/osl.c:399: error: for each function it appears in.) make[2]: *** [drivers/acpi/osl.o] Error 1 make[1]: *** [drivers/acpi] Error 2 make: *** [drivers] Error 2 # # Automatically generated make config: don't edit # Linux kernel version: 2.6.25-rc2-mm1 # Sun Feb 17 08:07:17 2008 # CONFIG_ACPI_CUSTOM_DSDT=y CONFIG_ACPI_CUSTOM_DSDT_FILE= garbage in, garbage out. garbage explicitly *allowed* by Kconfig in this case, though. If you don't give this build option a file name where AmlCode lives, then the build will be unable to find AmlCode[]. http://www.lesswatts.org/projects/acpi/overridingDSDT.php So we have a .config option whose sole purpose is to use another .config option? That seems ... less than ideal. Is there not some Kconfig voodoo we can do to only require the one option? Maybe something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to the Cc, in case he has any ideas. Thanks, Nish -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: On 2/20/08, Len Brown [EMAIL PROTECTED] wrote: On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function 'acpi_os_table_override': drivers/acpi/osl.c:399: error: 'AmlCode' undeclared (first use in this function) drivers/acpi/osl.c:399: error: (Each undeclared identifier is reported only once drivers/acpi/osl.c:399: error: for each function it appears in.) make[2]: *** [drivers/acpi/osl.o] Error 1 make[1]: *** [drivers/acpi] Error 2 make: *** [drivers] Error 2 # # Automatically generated make config: don't edit # Linux kernel version: 2.6.25-rc2-mm1 # Sun Feb 17 08:07:17 2008 # CONFIG_ACPI_CUSTOM_DSDT=y CONFIG_ACPI_CUSTOM_DSDT_FILE= garbage in, garbage out. garbage explicitly *allowed* by Kconfig in this case, though. If you don't give this build option a file name where AmlCode lives, then the build will be unable to find AmlCode[]. http://www.lesswatts.org/projects/acpi/overridingDSDT.php So we have a .config option whose sole purpose is to use another .config option? That seems ... less than ideal. Is there not some Kconfig voodoo we can do to only require the one option? Maybe something like how CONFIG_INITRAMFS_SOURCE is done? Adding Sam to the Cc, in case he has any ideas. Make sure STANDALONE is y for your randconfig builds. See README for examples. Hrm, if this is needed for randconfig to work, perhaps randconfig itself should somehow be specifying it? STANALONE is there exactly to prevent the above but we cannot control randconfig. While setting STANDALONE does fix the above, it doesn't answer the more basic question I had -- do we really need both .config options in this case? If it's simply a case of That's how it is, won't be fixed, there are higher priorities, that's good enough by me. Just seems a shame that we have an option to enable another option, which is required for the first option to be sensible -- seems like we should only need the second option... Thanks, Nish -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: > Hi Andrew, > > The 2.6.25-rc2-mm1 kernel with randconfig build option, fails > to build on x86_64 machine > > CC drivers/acpi/osl.o > drivers/acpi/osl.c:60:38: error: empty filename in #include > drivers/acpi/osl.c: In function ‘acpi_os_table_override’: > drivers/acpi/osl.c:399: error: ‘AmlCode’ undeclared (first use in this > function) > drivers/acpi/osl.c:399: error: (Each undeclared identifier is reported only > once > drivers/acpi/osl.c:399: error: for each function it appears in.) > make[2]: *** [drivers/acpi/osl.o] Error 1 > make[1]: *** [drivers/acpi] Error 2 > make: *** [drivers] Error 2 > > # > # Automatically generated make config: don't edit > # Linux kernel version: 2.6.25-rc2-mm1 > # Sun Feb 17 08:07:17 2008 > # > CONFIG_ACPI_CUSTOM_DSDT=y > CONFIG_ACPI_CUSTOM_DSDT_FILE="" garbage in, garbage out. If you don't give this build option a file name where AmlCode lives, then the build will be unable to find AmlCode[]. http://www.lesswatts.org/projects/acpi/overridingDSDT.php cheers, -Len -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function ‘acpi_os_table_override’: drivers/acpi/osl.c:399: error: ‘AmlCode’ undeclared (first use in this function) drivers/acpi/osl.c:399: error: (Each undeclared identifier is reported only once drivers/acpi/osl.c:399: error: for each function it appears in.) make[2]: *** [drivers/acpi/osl.o] Error 1 make[1]: *** [drivers/acpi] Error 2 make: *** [drivers] Error 2 # # Automatically generated make config: don't edit # Linux kernel version: 2.6.25-rc2-mm1 # Sun Feb 17 08:07:17 2008 # CONFIG_ACPI_CUSTOM_DSDT=y CONFIG_ACPI_CUSTOM_DSDT_FILE= garbage in, garbage out. If you don't give this build option a file name where AmlCode lives, then the build will be unable to find AmlCode[]. http://www.lesswatts.org/projects/acpi/overridingDSDT.php cheers, -Len -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function ‘acpi_os_table_override’: drivers/acpi/osl.c:399: error: ‘AmlCode’ undeclared (first use in this function) drivers/acpi/osl.c:399: error: (Each undeclared identifier is reported only once drivers/acpi/osl.c:399: error: for each function it appears in.) make[2]: *** [drivers/acpi/osl.o] Error 1 make[1]: *** [drivers/acpi] Error 2 make: *** [drivers] Error 2 # # Automatically generated make config: don't edit # Linux kernel version: 2.6.25-rc2-mm1 # Sun Feb 17 08:07:17 2008 # CONFIG_64BIT=y # CONFIG_X86_32 is not set CONFIG_X86_64=y CONFIG_X86=y # CONFIG_GENERIC_LOCKBREAK is not set CONFIG_GENERIC_TIME=y CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_CLOCKSOURCE_WATCHDOG=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_HAVE_LATENCYTOP_SUPPORT=y CONFIG_SEMAPHORE_SLEEPERS=y CONFIG_FAST_CMPXCHG_LOCAL=y CONFIG_MMU=y CONFIG_ZONE_DMA=y # CONFIG_QUICKLIST is not set CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_IOMAP=y CONFIG_GENERIC_HWEIGHT=y # CONFIG_GENERIC_GPIO is not set CONFIG_ARCH_MAY_HAVE_PC_FDC=y CONFIG_RWSEM_GENERIC_SPINLOCK=y # CONFIG_RWSEM_XCHGADD_ALGORITHM is not set # CONFIG_ARCH_HAS_ILOG2_U32 is not set # CONFIG_ARCH_HAS_ILOG2_U64 is not set CONFIG_ARCH_HAS_CPU_IDLE_WAIT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_GENERIC_TIME_VSYSCALL=y CONFIG_ARCH_HAS_CPU_RELAX=y CONFIG_HAVE_SETUP_PER_CPU_AREA=y CONFIG_ARCH_HIBERNATION_POSSIBLE=y CONFIG_ARCH_SUSPEND_POSSIBLE=y CONFIG_ZONE_DMA32=y CONFIG_ARCH_POPULATES_NODE_MAP=y CONFIG_AUDIT_ARCH=y CONFIG_ARCH_SUPPORTS_AOUT=y CONFIG_GENERIC_HARDIRQS=y CONFIG_GENERIC_IRQ_PROBE=y # CONFIG_KTIME_SCALAR is not set CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" # # General setup # CONFIG_EXPERIMENTAL=y CONFIG_BROKEN_ON_SMP=y CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y # CONFIG_SYSVIPC is not set # CONFIG_POSIX_MQUEUE is not set CONFIG_BSD_PROCESS_ACCT=y CONFIG_BSD_PROCESS_ACCT_V3=y # CONFIG_TASKSTATS is not set # CONFIG_AUDIT is not set # CONFIG_IKCONFIG is not set CONFIG_LOG_BUF_SHIFT=14 # CONFIG_CGROUPS is not set CONFIG_GROUP_SCHED=y CONFIG_FAIR_GROUP_SCHED=y # CONFIG_RT_GROUP_SCHED is not set CONFIG_USER_SCHED=y # CONFIG_CGROUP_SCHED is not set CONFIG_SYSFS_DEPRECATED=y CONFIG_RELAY=y # CONFIG_NAMESPACES is not set CONFIG_BLK_DEV_INITRD=y CONFIG_INITRAMFS_SOURCE="" # CONFIG_CC_OPTIMIZE_FOR_SIZE is not set CONFIG_SYSCTL=y CONFIG_EMBEDDED=y CONFIG_SYSCTL_SYSCALL=y CONFIG_SYSCTL_SYSCALL_CHECK=y CONFIG_KALLSYMS=y CONFIG_KALLSYMS_ALL=y CONFIG_KALLSYMS_EXTRA_PASS=y # CONFIG_HOTPLUG is not set CONFIG_PRINTK=y # CONFIG_BUG is not set CONFIG_ELF_CORE=y # CONFIG_COMPAT_BRK is not set CONFIG_BASE_FULL=y CONFIG_FUTEX=y CONFIG_ANON_INODES=y # CONFIG_EPOLL is not set CONFIG_SIGNALFD=y CONFIG_TIMERFD=y CONFIG_EVENTFD=y # CONFIG_SHMEM is not set CONFIG_VM_EVENT_COUNTERS=y # CONFIG_SLAB is not set # CONFIG_SLUB is not set CONFIG_SLOB=y CONFIG_PROFILING=y CONFIG_MARKERS=y # CONFIG_OPROFILE is not set CONFIG_HAVE_OPROFILE=y CONFIG_KPROBES=y CONFIG_HAVE_KPROBES=y CONFIG_RT_MUTEXES=y CONFIG_TINY_SHMEM=y CONFIG_BASE_SMALL=0 CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y # CONFIG_MODULE_FORCE_UNLOAD is not set CONFIG_MODVERSIONS=y CONFIG_MODULE_SRCVERSION_ALL=y CONFIG_KMOD=y # CONFIG_BLOCK is not set CONFIG_CLASSIC_RCU=y # CONFIG_PREEMPT_RCU is not set # # Processor type and features # CONFIG_TICK_ONESHOT=y CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y CONFIG_GENERIC_CLOCKEVENTS_BUILD=y # CONFIG_SMP is not set CONFIG_X86_PC=y # CONFIG_X86_ELAN is not set # CONFIG_X86_VOYAGER is not set # CONFIG_X86_NUMAQ is not set # CONFIG_X86_SUMMIT is not set # CONFIG_X86_BIGSMP is not set # CONFIG_X86_VISWS is not set # CONFIG_X86_GENERICARCH is not set # CONFIG_X86_ES7000 is not set # CONFIG_X86_RDC321X is not set # CONFIG_X86_VSMP is not set # CONFIG_PARAVIRT_GUEST is not set # CONFIG_M386 is not set # CONFIG_M486 is not set # CONFIG_M586 is not set # CONFIG_M586TSC is not set # CONFIG_M586MMX is not set # CONFIG_M686 is not set # CONFIG_MPENTIUMII is not set # CONFIG_MPENTIUMIII is not set # CONFIG_MPENTIUMM is not set # CONFIG_MPENTIUM4 is not set # CONFIG_MK6 is not set # CONFIG_MK7 is not set # CONFIG_MK8 is not set # CONFIG_MCRUSOE is not set # CONFIG_MEFFICEON is not set # CONFIG_MWINCHIPC6 is not set # CONFIG_MWINCHIP2 is not set # CONFIG_MWINCHIP3D is not set # CONFIG_MGEODEGX1 is not set # CONFIG_MGEODE_LX is not set # CONFIG_MCYRIXIII is not set # CONFIG_MVIAC3_2 is not set # CONFIG_MVIAC7 is not set # CONFIG_MPSC is not set CONFIG_MCORE2=y # CONFIG_GENERIC_CPU is not set CONFIG_X86_L1_CACHE_BYTES=64 CONFIG_X86_INTERNODE_CACHE_BYTES=64 CONFIG_X86_CMPXCHG=y CONFIG_X86_L1_CACHE_SHIFT=6 CONFIG_X86_GOOD_APIC=y CONFIG_X86_INTEL_USERCOPY=y CONFIG_X86_USE_PPRO_CHECKSUM=y
[BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function ‘acpi_os_table_override’: drivers/acpi/osl.c:399: error: ‘AmlCode’ undeclared (first use in this function) drivers/acpi/osl.c:399: error: (Each undeclared identifier is reported only once drivers/acpi/osl.c:399: error: for each function it appears in.) make[2]: *** [drivers/acpi/osl.o] Error 1 make[1]: *** [drivers/acpi] Error 2 make: *** [drivers] Error 2 # # Automatically generated make config: don't edit # Linux kernel version: 2.6.25-rc2-mm1 # Sun Feb 17 08:07:17 2008 # CONFIG_64BIT=y # CONFIG_X86_32 is not set CONFIG_X86_64=y CONFIG_X86=y # CONFIG_GENERIC_LOCKBREAK is not set CONFIG_GENERIC_TIME=y CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_CLOCKSOURCE_WATCHDOG=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_HAVE_LATENCYTOP_SUPPORT=y CONFIG_SEMAPHORE_SLEEPERS=y CONFIG_FAST_CMPXCHG_LOCAL=y CONFIG_MMU=y CONFIG_ZONE_DMA=y # CONFIG_QUICKLIST is not set CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_IOMAP=y CONFIG_GENERIC_HWEIGHT=y # CONFIG_GENERIC_GPIO is not set CONFIG_ARCH_MAY_HAVE_PC_FDC=y CONFIG_RWSEM_GENERIC_SPINLOCK=y # CONFIG_RWSEM_XCHGADD_ALGORITHM is not set # CONFIG_ARCH_HAS_ILOG2_U32 is not set # CONFIG_ARCH_HAS_ILOG2_U64 is not set CONFIG_ARCH_HAS_CPU_IDLE_WAIT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_GENERIC_TIME_VSYSCALL=y CONFIG_ARCH_HAS_CPU_RELAX=y CONFIG_HAVE_SETUP_PER_CPU_AREA=y CONFIG_ARCH_HIBERNATION_POSSIBLE=y CONFIG_ARCH_SUSPEND_POSSIBLE=y CONFIG_ZONE_DMA32=y CONFIG_ARCH_POPULATES_NODE_MAP=y CONFIG_AUDIT_ARCH=y CONFIG_ARCH_SUPPORTS_AOUT=y CONFIG_GENERIC_HARDIRQS=y CONFIG_GENERIC_IRQ_PROBE=y # CONFIG_KTIME_SCALAR is not set CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config # # General setup # CONFIG_EXPERIMENTAL=y CONFIG_BROKEN_ON_SMP=y CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_LOCALVERSION= CONFIG_LOCALVERSION_AUTO=y # CONFIG_SYSVIPC is not set # CONFIG_POSIX_MQUEUE is not set CONFIG_BSD_PROCESS_ACCT=y CONFIG_BSD_PROCESS_ACCT_V3=y # CONFIG_TASKSTATS is not set # CONFIG_AUDIT is not set # CONFIG_IKCONFIG is not set CONFIG_LOG_BUF_SHIFT=14 # CONFIG_CGROUPS is not set CONFIG_GROUP_SCHED=y CONFIG_FAIR_GROUP_SCHED=y # CONFIG_RT_GROUP_SCHED is not set CONFIG_USER_SCHED=y # CONFIG_CGROUP_SCHED is not set CONFIG_SYSFS_DEPRECATED=y CONFIG_RELAY=y # CONFIG_NAMESPACES is not set CONFIG_BLK_DEV_INITRD=y CONFIG_INITRAMFS_SOURCE= # CONFIG_CC_OPTIMIZE_FOR_SIZE is not set CONFIG_SYSCTL=y CONFIG_EMBEDDED=y CONFIG_SYSCTL_SYSCALL=y CONFIG_SYSCTL_SYSCALL_CHECK=y CONFIG_KALLSYMS=y CONFIG_KALLSYMS_ALL=y CONFIG_KALLSYMS_EXTRA_PASS=y # CONFIG_HOTPLUG is not set CONFIG_PRINTK=y # CONFIG_BUG is not set CONFIG_ELF_CORE=y # CONFIG_COMPAT_BRK is not set CONFIG_BASE_FULL=y CONFIG_FUTEX=y CONFIG_ANON_INODES=y # CONFIG_EPOLL is not set CONFIG_SIGNALFD=y CONFIG_TIMERFD=y CONFIG_EVENTFD=y # CONFIG_SHMEM is not set CONFIG_VM_EVENT_COUNTERS=y # CONFIG_SLAB is not set # CONFIG_SLUB is not set CONFIG_SLOB=y CONFIG_PROFILING=y CONFIG_MARKERS=y # CONFIG_OPROFILE is not set CONFIG_HAVE_OPROFILE=y CONFIG_KPROBES=y CONFIG_HAVE_KPROBES=y CONFIG_RT_MUTEXES=y CONFIG_TINY_SHMEM=y CONFIG_BASE_SMALL=0 CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y # CONFIG_MODULE_FORCE_UNLOAD is not set CONFIG_MODVERSIONS=y CONFIG_MODULE_SRCVERSION_ALL=y CONFIG_KMOD=y # CONFIG_BLOCK is not set CONFIG_CLASSIC_RCU=y # CONFIG_PREEMPT_RCU is not set # # Processor type and features # CONFIG_TICK_ONESHOT=y CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y CONFIG_GENERIC_CLOCKEVENTS_BUILD=y # CONFIG_SMP is not set CONFIG_X86_PC=y # CONFIG_X86_ELAN is not set # CONFIG_X86_VOYAGER is not set # CONFIG_X86_NUMAQ is not set # CONFIG_X86_SUMMIT is not set # CONFIG_X86_BIGSMP is not set # CONFIG_X86_VISWS is not set # CONFIG_X86_GENERICARCH is not set # CONFIG_X86_ES7000 is not set # CONFIG_X86_RDC321X is not set # CONFIG_X86_VSMP is not set # CONFIG_PARAVIRT_GUEST is not set # CONFIG_M386 is not set # CONFIG_M486 is not set # CONFIG_M586 is not set # CONFIG_M586TSC is not set # CONFIG_M586MMX is not set # CONFIG_M686 is not set # CONFIG_MPENTIUMII is not set # CONFIG_MPENTIUMIII is not set # CONFIG_MPENTIUMM is not set # CONFIG_MPENTIUM4 is not set # CONFIG_MK6 is not set # CONFIG_MK7 is not set # CONFIG_MK8 is not set # CONFIG_MCRUSOE is not set # CONFIG_MEFFICEON is not set # CONFIG_MWINCHIPC6 is not set # CONFIG_MWINCHIP2 is not set # CONFIG_MWINCHIP3D is not set # CONFIG_MGEODEGX1 is not set # CONFIG_MGEODE_LX is not set # CONFIG_MCYRIXIII is not set # CONFIG_MVIAC3_2 is not set # CONFIG_MVIAC7 is not set # CONFIG_MPSC is not set CONFIG_MCORE2=y # CONFIG_GENERIC_CPU is not set CONFIG_X86_L1_CACHE_BYTES=64 CONFIG_X86_INTERNODE_CACHE_BYTES=64 CONFIG_X86_CMPXCHG=y CONFIG_X86_L1_CACHE_SHIFT=6 CONFIG_X86_GOOD_APIC=y CONFIG_X86_INTEL_USERCOPY=y CONFIG_X86_USE_PPRO_CHECKSUM=y
