Re: [Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit b81975eade8c
On 2015/1/15 22:22, Sander Eikelenboom wrote: > > Thursday, January 15, 2015, 2:04:34 PM, you wrote: > >> With more knowledge of Xen interrupt manangement subsytem, I realized >> previous three versions to fix https://lkml.org/lkml/2014/12/19/178 are >> just plainly wrong. Those patches try to fix the issue by creating >> irqdomain for IOAPICs for PV domains, which effectively let native >> IOAPIC driver and Xen PV interrupt management subsystem to manage >> IOAPIC irqs concurrently, sounds unpredictable. > >> Sorry for those wrong fixes. The good news is that the new fix does >> make code simpler and easier to maintain. > >> I have tested the patchset on Intel platform with bare metal and Dom0 >> kernels. > >> Hi Sander, >> Could you please help to test it again? > >> Regards! >> Gerry > > Hi Gerry, > > These patches fix the first symptom of the powerbutton not working. > > Unfortunately it doesn't fix the second symptoms with pci-passthrough, > the device still doesn't receive irq's on intel and the video device still > haas > issues on AMD. > > What i have tested extensively and works stable for me is: > david's patch + revert of cffe0a2b5a34c95a4dadc9ec7132690a5b0f6687 "x86, irq: > Keep balance of IOAPIC pin reference count" > > Hope that helps in finding the solution. Hi Sander, Yes, this is only a fix for power button(ACPI SCI allocation). I'm still reading xen-pciback code to figure out the possible cause and fix for the second issue. Thanks! Gerry. > > -- > Sander > > >> Jiang Liu (2): >> xen/pci: Kill function xen_setup_acpi_sci() >> xen/pci: Simplify x86/pci/xen.c by killing gsi_override related code > >> arch/x86/kernel/acpi/boot.c | 26 - >> arch/x86/pci/xen.c | 68 >> --- >> 2 files changed, 19 insertions(+), 75 deletions(-) > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit b81975eade8c
Thursday, January 15, 2015, 2:04:34 PM, you wrote: > With more knowledge of Xen interrupt manangement subsytem, I realized > previous three versions to fix https://lkml.org/lkml/2014/12/19/178 are > just plainly wrong. Those patches try to fix the issue by creating > irqdomain for IOAPICs for PV domains, which effectively let native > IOAPIC driver and Xen PV interrupt management subsystem to manage > IOAPIC irqs concurrently, sounds unpredictable. > Sorry for those wrong fixes. The good news is that the new fix does > make code simpler and easier to maintain. > I have tested the patchset on Intel platform with bare metal and Dom0 > kernels. > Hi Sander, > Could you please help to test it again? > Regards! > Gerry Hi Gerry, These patches fix the first symptom of the powerbutton not working. Unfortunately it doesn't fix the second symptoms with pci-passthrough, the device still doesn't receive irq's on intel and the video device still haas issues on AMD. What i have tested extensively and works stable for me is: david's patch + revert of cffe0a2b5a34c95a4dadc9ec7132690a5b0f6687 "x86, irq: Keep balance of IOAPIC pin reference count" Hope that helps in finding the solution. -- Sander > Jiang Liu (2): > xen/pci: Kill function xen_setup_acpi_sci() > xen/pci: Simplify x86/pci/xen.c by killing gsi_override related code > arch/x86/kernel/acpi/boot.c | 26 - > arch/x86/pci/xen.c | 68 > --- > 2 files changed, 19 insertions(+), 75 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit b81975eade8c
Thursday, January 15, 2015, 2:04:34 PM, you wrote: > With more knowledge of Xen interrupt manangement subsytem, I realized > previous three versions to fix https://lkml.org/lkml/2014/12/19/178 are > just plainly wrong. Those patches try to fix the issue by creating > irqdomain for IOAPICs for PV domains, which effectively let native > IOAPIC driver and Xen PV interrupt management subsystem to manage > IOAPIC irqs concurrently, sounds unpredictable. > Sorry for those wrong fixes. The good news is that the new fix does > make code simpler and easier to maintain. > I have tested the patchset on Intel platform with bare metal and Dom0 > kernels. > Hi Sander, > Could you please help to test it again? > Regards! > Gerry Hi Gerry, Sure, i will test this afternoon and report back. Thanks -- Sander > Jiang Liu (2): > xen/pci: Kill function xen_setup_acpi_sci() > xen/pci: Simplify x86/pci/xen.c by killing gsi_override related code > arch/x86/kernel/acpi/boot.c | 26 - > arch/x86/pci/xen.c | 68 > --- > 2 files changed, 19 insertions(+), 75 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit b81975eade8c
With more knowledge of Xen interrupt manangement subsytem, I realized previous three versions to fix https://lkml.org/lkml/2014/12/19/178 are just plainly wrong. Those patches try to fix the issue by creating irqdomain for IOAPICs for PV domains, which effectively let native IOAPIC driver and Xen PV interrupt management subsystem to manage IOAPIC irqs concurrently, sounds unpredictable. Sorry for those wrong fixes. The good news is that the new fix does make code simpler and easier to maintain. I have tested the patchset on Intel platform with bare metal and Dom0 kernels. Hi Sander, Could you please help to test it again? Regards! Gerry Jiang Liu (2): xen/pci: Kill function xen_setup_acpi_sci() xen/pci: Simplify x86/pci/xen.c by killing gsi_override related code arch/x86/kernel/acpi/boot.c | 26 - arch/x86/pci/xen.c | 68 --- 2 files changed, 19 insertions(+), 75 deletions(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit b81975eade8c
Thursday, January 15, 2015, 2:04:34 PM, you wrote: With more knowledge of Xen interrupt manangement subsytem, I realized previous three versions to fix https://lkml.org/lkml/2014/12/19/178 are just plainly wrong. Those patches try to fix the issue by creating irqdomain for IOAPICs for PV domains, which effectively let native IOAPIC driver and Xen PV interrupt management subsystem to manage IOAPIC irqs concurrently, sounds unpredictable. Sorry for those wrong fixes. The good news is that the new fix does make code simpler and easier to maintain. I have tested the patchset on Intel platform with bare metal and Dom0 kernels. Hi Sander, Could you please help to test it again? Regards! Gerry Hi Gerry, Sure, i will test this afternoon and report back. Thanks -- Sander Jiang Liu (2): xen/pci: Kill function xen_setup_acpi_sci() xen/pci: Simplify x86/pci/xen.c by killing gsi_override related code arch/x86/kernel/acpi/boot.c | 26 - arch/x86/pci/xen.c | 68 --- 2 files changed, 19 insertions(+), 75 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit b81975eade8c
With more knowledge of Xen interrupt manangement subsytem, I realized previous three versions to fix https://lkml.org/lkml/2014/12/19/178 are just plainly wrong. Those patches try to fix the issue by creating irqdomain for IOAPICs for PV domains, which effectively let native IOAPIC driver and Xen PV interrupt management subsystem to manage IOAPIC irqs concurrently, sounds unpredictable. Sorry for those wrong fixes. The good news is that the new fix does make code simpler and easier to maintain. I have tested the patchset on Intel platform with bare metal and Dom0 kernels. Hi Sander, Could you please help to test it again? Regards! Gerry Jiang Liu (2): xen/pci: Kill function xen_setup_acpi_sci() xen/pci: Simplify x86/pci/xen.c by killing gsi_override related code arch/x86/kernel/acpi/boot.c | 26 - arch/x86/pci/xen.c | 68 --- 2 files changed, 19 insertions(+), 75 deletions(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit b81975eade8c
Thursday, January 15, 2015, 2:04:34 PM, you wrote: With more knowledge of Xen interrupt manangement subsytem, I realized previous three versions to fix https://lkml.org/lkml/2014/12/19/178 are just plainly wrong. Those patches try to fix the issue by creating irqdomain for IOAPICs for PV domains, which effectively let native IOAPIC driver and Xen PV interrupt management subsystem to manage IOAPIC irqs concurrently, sounds unpredictable. Sorry for those wrong fixes. The good news is that the new fix does make code simpler and easier to maintain. I have tested the patchset on Intel platform with bare metal and Dom0 kernels. Hi Sander, Could you please help to test it again? Regards! Gerry Hi Gerry, These patches fix the first symptom of the powerbutton not working. Unfortunately it doesn't fix the second symptoms with pci-passthrough, the device still doesn't receive irq's on intel and the video device still haas issues on AMD. What i have tested extensively and works stable for me is: david's patch + revert of cffe0a2b5a34c95a4dadc9ec7132690a5b0f6687 x86, irq: Keep balance of IOAPIC pin reference count Hope that helps in finding the solution. -- Sander Jiang Liu (2): xen/pci: Kill function xen_setup_acpi_sci() xen/pci: Simplify x86/pci/xen.c by killing gsi_override related code arch/x86/kernel/acpi/boot.c | 26 - arch/x86/pci/xen.c | 68 --- 2 files changed, 19 insertions(+), 75 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit b81975eade8c
On 2015/1/15 22:22, Sander Eikelenboom wrote: Thursday, January 15, 2015, 2:04:34 PM, you wrote: With more knowledge of Xen interrupt manangement subsytem, I realized previous three versions to fix https://lkml.org/lkml/2014/12/19/178 are just plainly wrong. Those patches try to fix the issue by creating irqdomain for IOAPICs for PV domains, which effectively let native IOAPIC driver and Xen PV interrupt management subsystem to manage IOAPIC irqs concurrently, sounds unpredictable. Sorry for those wrong fixes. The good news is that the new fix does make code simpler and easier to maintain. I have tested the patchset on Intel platform with bare metal and Dom0 kernels. Hi Sander, Could you please help to test it again? Regards! Gerry Hi Gerry, These patches fix the first symptom of the powerbutton not working. Unfortunately it doesn't fix the second symptoms with pci-passthrough, the device still doesn't receive irq's on intel and the video device still haas issues on AMD. What i have tested extensively and works stable for me is: david's patch + revert of cffe0a2b5a34c95a4dadc9ec7132690a5b0f6687 x86, irq: Keep balance of IOAPIC pin reference count Hope that helps in finding the solution. Hi Sander, Yes, this is only a fix for power button(ACPI SCI allocation). I'm still reading xen-pciback code to figure out the possible cause and fix for the second issue. Thanks! Gerry. -- Sander Jiang Liu (2): xen/pci: Kill function xen_setup_acpi_sci() xen/pci: Simplify x86/pci/xen.c by killing gsi_override related code arch/x86/kernel/acpi/boot.c | 26 - arch/x86/pci/xen.c | 68 --- 2 files changed, 19 insertions(+), 75 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
