Re: [Cluster-devel] KASAN: slab-out-of-bounds Write in,gfs2_fill_super

2020-10-14 Thread Fox Chen

Yes, it's the same bug,

https://lkml.org/lkml/2020/10/5/538 this may help


thanks,


Re: [Cluster-devel] KASAN: slab-out-of-bounds Write in gfs2_fill_super

2020-10-14 Thread Andrew Price

On 14/10/2020 13:19, Anant Thazhemadam wrote:


On 30/09/20 7:52 pm, Andrew Price wrote:

On 30/09/2020 13:39, syzbot wrote:

Hello,

syzbot found the following issue on:

HEAD commit:    fb0155a0 Merge tag 'nfs-for-5.9-3' of git://git.linux-nfs...
git tree:   upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13458c0f90
kernel config:  https://syzkaller.appspot.com/x/.config?x=adebb40048274f92
dashboard link: https://syzkaller.appspot.com/bug?extid=af90d47a37376844e731




Just saw this report.
This seems to be the same as
     https://syzkaller.appspot.com/bug?extid=a5e2482a693e6b1e444b ,
for which I have recently sent in a fix (https://lkml.org/lkml/2020/10/13/588).


Thanks. The gfs2 maintainers are probably busy but I'll review the patch.


Since the "Reported-by" tag in the patch sent is for the other instance of the
same crash, can we close this one as a duplicate?


I expect the duplicates will get closed once a fix is in the tree so 
there's no need to spend time on that.


Andy



Re: [Cluster-devel] KASAN: slab-out-of-bounds Write in gfs2_fill_super

2020-10-14 Thread Anant Thazhemadam


On 30/09/20 7:52 pm, Andrew Price wrote:
> On 30/09/2020 13:39, syzbot wrote:
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit:    fb0155a0 Merge tag 'nfs-for-5.9-3' of git://git.linux-nfs...
>> git tree:   upstream
>> console output: https://syzkaller.appspot.com/x/log.txt?x=13458c0f90
>> kernel config:  https://syzkaller.appspot.com/x/.config?x=adebb40048274f92
>> dashboard link: https://syzkaller.appspot.com/bug?extid=af90d47a37376844e731
>> compiler:   clang version 10.0.0 (https://github.com/llvm/llvm-project/ 
>> c2443155a0fb245c8f17f2c1c72b6ea391e86e81)
>> syz repro:  https://syzkaller.appspot.com/x/repro.syz?x=15c307d390
>> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1353d58d90
>>
>> Bisection is inconclusive: the issue happens on the oldest tested release.
>>
>> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=106acbbb90
>> final oops: https://syzkaller.appspot.com/x/report.txt?x=126acbbb90
>> console output: https://syzkaller.appspot.com/x/log.txt?x=146acbbb90
>>
>> IMPORTANT: if you fix the issue, please add the following tag to the commit:
>> Reported-by: syzbot+af90d47a37376844e...@syzkaller.appspotmail.com
>>
>> gfs2: fsid=loop0: Trying to join cluster "lock_nolock", "loop0"
>> gfs2: fsid=loop0: Now mounting FS...
>> ==
>> BUG: KASAN: slab-out-of-bounds in gfs2_read_sb fs/gfs2/ops_fstype.c:342 
>> [inline]
>> BUG: KASAN: slab-out-of-bounds in init_sb fs/gfs2/ops_fstype.c:479 [inline]
>> BUG: KASAN: slab-out-of-bounds in gfs2_fill_super+0x1db5/0x3fe0 
>> fs/gfs2/ops_fstype.c:1096
>> Write of size 8 at addr 88809073d548 by task syz-executor940/6853
>
> Bug filed for this:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1883929
>
> Andy
>
>> CPU: 1 PID: 6853 Comm: syz-executor940 Not tainted 5.9.0-rc7-syzkaller #0
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
>> Google 01/01/2011
>> Call Trace:
>>   __dump_stack lib/dump_stack.c:77 [inline]
>>   dump_stack+0x1d6/0x29e lib/dump_stack.c:118
>>   print_address_description+0x66/0x620 mm/kasan/report.c:383
>>   __kasan_report mm/kasan/report.c:513 [inline]
>>   kasan_report+0x132/0x1d0 mm/kasan/report.c:530
>>   gfs2_read_sb fs/gfs2/ops_fstype.c:342 [inline]
>>   init_sb fs/gfs2/ops_fstype.c:479 [inline]
>>   gfs2_fill_super+0x1db5/0x3fe0 fs/gfs2/ops_fstype.c:1096
>>   get_tree_bdev+0x3e9/0x5f0 fs/super.c:1342
>>   gfs2_get_tree+0x4c/0x1f0 fs/gfs2/ops_fstype.c:1201
>>   vfs_get_tree+0x88/0x270 fs/super.c:1547
>>   do_new_mount fs/namespace.c:2875 [inline]
>>   path_mount+0x179d/0x29e0 fs/namespace.c:3192
>>   do_mount fs/namespace.c:3205 [inline]
>>   __do_sys_mount fs/namespace.c:3413 [inline]
>>   __se_sys_mount+0x126/0x180 fs/namespace.c:3390
>>   do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46
>>   entry_SYSCALL_64_after_hwframe+0x44/0xa9
>> RIP: 0033:0x446dba
>> Code: b8 08 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 fd ad fb ff c3 66 2e 0f 
>> 1f 84 00 00 00 00 00 66 90 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 
>> 0f 83 da ad fb ff c3 66 0f 1f 84 00 00 00 00 00
>> RSP: 002b:7fff4c56e748 EFLAGS: 0293 ORIG_RAX: 00a5
>> RAX: ffda RBX: 7fff4c56e7a0 RCX: 00446dba
>> RDX: 2000 RSI: 2100 RDI: 7fff4c56e760
>> RBP: 7fff4c56e760 R08: 7fff4c56e7a0 R09: 7fff0015
>> R10: 0220 R11: 0293 R12: 0001
>> R13: 0004 R14: 0003 R15: 0003
>>
>> Allocated by task 6853:
>>   kasan_save_stack mm/kasan/common.c:48 [inline]
>>   kasan_set_track mm/kasan/common.c:56 [inline]
>>   __kasan_kmalloc+0x100/0x130 mm/kasan/common.c:461
>>   kmem_cache_alloc_trace+0x1e4/0x2e0 mm/slab.c:3554
>>   kmalloc include/linux/slab.h:554 [inline]
>>   kzalloc include/linux/slab.h:666 [inline]
>>   init_sbd fs/gfs2/ops_fstype.c:77 [inline]
>>   gfs2_fill_super+0xb6/0x3fe0 fs/gfs2/ops_fstype.c:1018
>>   get_tree_bdev+0x3e9/0x5f0 fs/super.c:1342
>>   gfs2_get_tree+0x4c/0x1f0 fs/gfs2/ops_fstype.c:1201
>>   vfs_get_tree+0x88/0x270 fs/super.c:1547
>>   do_new_mount fs/namespace.c:2875 [inline]
>>   path_mount+0x179d/0x29e0 fs/namespace.c:3192
>>   do_mount fs/namespace.c:3205 [inline]
>>   __do_sys_mount fs/namespace.c:3413 [inline]
>>   __se_sys_mount+0x126/0x180 fs/namespace.c:3390
>>   do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46
>>   entry_SYSCALL_64_after_hwframe+0x44/0xa9
>>
>> The buggy address belongs to the object at 88809073c000
>>   which belongs to the cache kmalloc-8k of size 8192
>> The buggy address is located 5448 bytes inside of
>>   8192-byte region [88809073c000, 88809073e000)
>> The buggy address belongs to the page:
>> page:bd4b0b2d refcount:1 mapcount:0 mapping: 
>> index:0x0 pfn:0x9073c
>> head:bd4b0b2d order:2 compound_mapcount:0 compound_pincount:0
>> flags: 

Re: [Cluster-devel] KASAN: slab-out-of-bounds Write in gfs2_fill_super

2020-09-30 Thread Andrew Price

On 30/09/2020 13:39, syzbot wrote:

Hello,

syzbot found the following issue on:

HEAD commit:fb0155a0 Merge tag 'nfs-for-5.9-3' of git://git.linux-nfs...
git tree:   upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13458c0f90
kernel config:  https://syzkaller.appspot.com/x/.config?x=adebb40048274f92
dashboard link: https://syzkaller.appspot.com/bug?extid=af90d47a37376844e731
compiler:   clang version 10.0.0 (https://github.com/llvm/llvm-project/ 
c2443155a0fb245c8f17f2c1c72b6ea391e86e81)
syz repro:  https://syzkaller.appspot.com/x/repro.syz?x=15c307d390
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1353d58d90

Bisection is inconclusive: the issue happens on the oldest tested release.

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=106acbbb90
final oops: https://syzkaller.appspot.com/x/report.txt?x=126acbbb90
console output: https://syzkaller.appspot.com/x/log.txt?x=146acbbb90

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+af90d47a37376844e...@syzkaller.appspotmail.com

gfs2: fsid=loop0: Trying to join cluster "lock_nolock", "loop0"
gfs2: fsid=loop0: Now mounting FS...
==
BUG: KASAN: slab-out-of-bounds in gfs2_read_sb fs/gfs2/ops_fstype.c:342 [inline]
BUG: KASAN: slab-out-of-bounds in init_sb fs/gfs2/ops_fstype.c:479 [inline]
BUG: KASAN: slab-out-of-bounds in gfs2_fill_super+0x1db5/0x3fe0 
fs/gfs2/ops_fstype.c:1096
Write of size 8 at addr 88809073d548 by task syz-executor940/6853


Bug filed for this:

https://bugzilla.redhat.com/show_bug.cgi?id=1883929

Andy


CPU: 1 PID: 6853 Comm: syz-executor940 Not tainted 5.9.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 
01/01/2011
Call Trace:
  __dump_stack lib/dump_stack.c:77 [inline]
  dump_stack+0x1d6/0x29e lib/dump_stack.c:118
  print_address_description+0x66/0x620 mm/kasan/report.c:383
  __kasan_report mm/kasan/report.c:513 [inline]
  kasan_report+0x132/0x1d0 mm/kasan/report.c:530
  gfs2_read_sb fs/gfs2/ops_fstype.c:342 [inline]
  init_sb fs/gfs2/ops_fstype.c:479 [inline]
  gfs2_fill_super+0x1db5/0x3fe0 fs/gfs2/ops_fstype.c:1096
  get_tree_bdev+0x3e9/0x5f0 fs/super.c:1342
  gfs2_get_tree+0x4c/0x1f0 fs/gfs2/ops_fstype.c:1201
  vfs_get_tree+0x88/0x270 fs/super.c:1547
  do_new_mount fs/namespace.c:2875 [inline]
  path_mount+0x179d/0x29e0 fs/namespace.c:3192
  do_mount fs/namespace.c:3205 [inline]
  __do_sys_mount fs/namespace.c:3413 [inline]
  __se_sys_mount+0x126/0x180 fs/namespace.c:3390
  do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46
  entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x446dba
Code: b8 08 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 fd ad fb ff c3 66 2e 0f 1f 84 00 
00 00 00 00 66 90 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 da ad 
fb ff c3 66 0f 1f 84 00 00 00 00 00
RSP: 002b:7fff4c56e748 EFLAGS: 0293 ORIG_RAX: 00a5
RAX: ffda RBX: 7fff4c56e7a0 RCX: 00446dba
RDX: 2000 RSI: 2100 RDI: 7fff4c56e760
RBP: 7fff4c56e760 R08: 7fff4c56e7a0 R09: 7fff0015
R10: 0220 R11: 0293 R12: 0001
R13: 0004 R14: 0003 R15: 0003

Allocated by task 6853:
  kasan_save_stack mm/kasan/common.c:48 [inline]
  kasan_set_track mm/kasan/common.c:56 [inline]
  __kasan_kmalloc+0x100/0x130 mm/kasan/common.c:461
  kmem_cache_alloc_trace+0x1e4/0x2e0 mm/slab.c:3554
  kmalloc include/linux/slab.h:554 [inline]
  kzalloc include/linux/slab.h:666 [inline]
  init_sbd fs/gfs2/ops_fstype.c:77 [inline]
  gfs2_fill_super+0xb6/0x3fe0 fs/gfs2/ops_fstype.c:1018
  get_tree_bdev+0x3e9/0x5f0 fs/super.c:1342
  gfs2_get_tree+0x4c/0x1f0 fs/gfs2/ops_fstype.c:1201
  vfs_get_tree+0x88/0x270 fs/super.c:1547
  do_new_mount fs/namespace.c:2875 [inline]
  path_mount+0x179d/0x29e0 fs/namespace.c:3192
  do_mount fs/namespace.c:3205 [inline]
  __do_sys_mount fs/namespace.c:3413 [inline]
  __se_sys_mount+0x126/0x180 fs/namespace.c:3390
  do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46
  entry_SYSCALL_64_after_hwframe+0x44/0xa9

The buggy address belongs to the object at 88809073c000
  which belongs to the cache kmalloc-8k of size 8192
The buggy address is located 5448 bytes inside of
  8192-byte region [88809073c000, 88809073e000)
The buggy address belongs to the page:
page:bd4b0b2d refcount:1 mapcount:0 mapping: index:0x0 
pfn:0x9073c
head:bd4b0b2d order:2 compound_mapcount:0 compound_pincount:0
flags: 0xfffe010200(slab|head)
raw: 00fffe010200 ea00028e5608 8880aa441b50 8880aa440a00
raw:  88809073c000 00010001 
page dumped because: kasan: bad access detected

Memory state around the buggy address:
  88809073d400: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00