[GIT PULL] 9p: patches for the 4.1 merge window
The following changes since commit b314acaccd7e0d55314d96be4a33b5f50d0b3344: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input (2015-03-19 16:43:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git tags/for-linus-4.1-merge-window for you to fetch changes up to f569d3ef8254d4b3b8daa4f131f9397d48bf296c: net/9p: add a privport option for RDMA transport. (2015-03-21 19:32:33 -0700) 9p: patches for 4.1 merge window Some accumulated cleanup patches for kerneldoc and unused variables as well as some lock bug fixes and adding privateport option for RDMA. A quick check shows some merge-conflicts versus current-tip on 9p: use unsigned integers for nwqid/count If you would prefer I can rebase, remerge and fix the patch but didn't want to do that and look the for-next references. Signed-off-by: Eric Van Hensbergen Andrey Ryabinin (1): net/9p: use memcpy() instead of snprintf() in p9_mount_tag_show() Dominique Martinet (3): net/9p: Initialize opts->privport as it should be. fs/9p: Initialize status in v9fs_file_do_lock. net/9p: add a privport option for RDMA transport. Fabian Frederick (2): 9p: kerneldoc warning fixes 9p: remove unused variable in p9_fd_create() Kirill A. Shutemov (3): 9p: fix error handling in v9fs_file_do_lock 9p: do not crash on unknown lock status code 9p: use unsigned integers for nwqid/count fs/9p/v9fs.h | 1 - fs/9p/vfs_addr.c | 2 -- fs/9p/vfs_file.c | 10 ++ net/9p/protocol.c | 6 +++--- net/9p/trans_fd.c | 3 +-- net/9p/trans_rdma.c | 52 + net/9p/trans_virtio.c | 5 - 7 files changed, 58 insertions(+), 21 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] 9p: patches for the 4.1 merge window
The following changes since commit b314acaccd7e0d55314d96be4a33b5f50d0b3344: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input (2015-03-19 16:43:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git tags/for-linus-4.1-merge-window for you to fetch changes up to f569d3ef8254d4b3b8daa4f131f9397d48bf296c: net/9p: add a privport option for RDMA transport. (2015-03-21 19:32:33 -0700) 9p: patches for 4.1 merge window Some accumulated cleanup patches for kerneldoc and unused variables as well as some lock bug fixes and adding privateport option for RDMA. A quick check shows some merge-conflicts versus current-tip on 9p: use unsigned integers for nwqid/count If you would prefer I can rebase, remerge and fix the patch but didn't want to do that and look the for-next references. Signed-off-by: Eric Van Hensbergen eri...@gmail.com Andrey Ryabinin (1): net/9p: use memcpy() instead of snprintf() in p9_mount_tag_show() Dominique Martinet (3): net/9p: Initialize opts-privport as it should be. fs/9p: Initialize status in v9fs_file_do_lock. net/9p: add a privport option for RDMA transport. Fabian Frederick (2): 9p: kerneldoc warning fixes 9p: remove unused variable in p9_fd_create() Kirill A. Shutemov (3): 9p: fix error handling in v9fs_file_do_lock 9p: do not crash on unknown lock status code 9p: use unsigned integers for nwqid/count fs/9p/v9fs.h | 1 - fs/9p/vfs_addr.c | 2 -- fs/9p/vfs_file.c | 10 ++ net/9p/protocol.c | 6 +++--- net/9p/trans_fd.c | 3 +-- net/9p/trans_rdma.c | 52 + net/9p/trans_virtio.c | 5 - 7 files changed, 58 insertions(+), 21 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] 9p patches for 2.6.24 merge window
On Wed, Oct 17, 2007 at 06:19:53PM -0500, Eric Van Hensbergen wrote: > On 10/17/07, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > On Wed, Oct 17, 2007 at 04:34:02PM -0500, Eric Van Hensbergen wrote: > > > Linus, please pull from the 'for-linus' branch of: > > > git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus > > > > > > This tree contains the following: > > > > > > Latchesar Ionkov(3): > > > attach-per-user support > > > rename uid and gid parameters > > > define session flags > > > > > > Eric Van Hensbergen(4) > > > remove sysctl code > > > fix bad kconfig cross-dependency > > > soften invalidationin loose mode > > > make transports dynamic > > > > Could you please tag your patches with 9p: or [9p] so it > > is obvious that they belong to this subsystem. > > When browsing head-commits and other places this is a great help. > > > > They should be so tagged, I just stripped it in my pull email summary. OK - thanks. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] 9p patches for 2.6.24 merge window
On 10/17/07, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Wed, Oct 17, 2007 at 04:34:02PM -0500, Eric Van Hensbergen wrote: > > Linus, please pull from the 'for-linus' branch of: > > git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus > > > > This tree contains the following: > > > > Latchesar Ionkov(3): > > attach-per-user support > > rename uid and gid parameters > > define session flags > > > > Eric Van Hensbergen(4) > > remove sysctl code > > fix bad kconfig cross-dependency > > soften invalidationin loose mode > > make transports dynamic > > Could you please tag your patches with 9p: or [9p] so it > is obvious that they belong to this subsystem. > When browsing head-commits and other places this is a great help. > They should be so tagged, I just stripped it in my pull email summary. -eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] 9p patches for 2.6.24 merge window
On Wed, Oct 17, 2007 at 04:34:02PM -0500, Eric Van Hensbergen wrote: > Linus, please pull from the 'for-linus' branch of: > git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus > > This tree contains the following: > > Latchesar Ionkov(3): > attach-per-user support > rename uid and gid parameters > define session flags > > Eric Van Hensbergen(4) > remove sysctl code > fix bad kconfig cross-dependency > soften invalidationin loose mode > make transports dynamic Could you please tag your patches with 9p: or [9p] so it is obvious that they belong to this subsystem. When browsing head-commits and other places this is a great help. Thanks, Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] 9p patches for 2.6.24 merge window
Linus, please pull from the 'for-linus' branch of: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus This tree contains the following: Latchesar Ionkov(3): attach-per-user support rename uid and gid parameters define session flags Eric Van Hensbergen(4) remove sysctl code fix bad kconfig cross-dependency soften invalidationin loose mode make transports dynamic There are a few patches relating to a virtio transport support that I'm holding back until I know Rusty's lguest series is merged. b/Documentation/filesystems/9p.txt | 22 + b/fs/9p/fid.c | 157 +++-- b/fs/9p/v9fs.c | 189 +++- b/fs/9p/v9fs.h | 38 +-- b/fs/9p/vfs_file.c |6 b/fs/9p/vfs_inode.c| 50 ++-- b/fs/9p/vfs_super.c| 19 - b/include/net/9p/9p.h | 21 - b/include/net/9p/client.h |9 b/include/net/9p/conn.h|4 b/include/net/9p/transport.h | 27 +- b/net/9p/Kconfig | 10 b/net/9p/Makefile |5 b/net/9p/client.c | 13 - b/net/9p/conv.c| 32 ++ b/net/9p/mod.c | 71 +- b/net/9p/mux.c |5 b/net/9p/trans_fd.c| 419 +++-- net/9p/sysctl.c| 81 --- 19 files changed, 689 insertions(+), 489 deletions(-) Thanks, -eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] 9p patches for 2.6.24 merge window
Linus, please pull from the 'for-linus' branch of: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus This tree contains the following: Latchesar Ionkov(3): attach-per-user support rename uid and gid parameters define session flags Eric Van Hensbergen(4) remove sysctl code fix bad kconfig cross-dependency soften invalidationin loose mode make transports dynamic There are a few patches relating to a virtio transport support that I'm holding back until I know Rusty's lguest series is merged. b/Documentation/filesystems/9p.txt | 22 + b/fs/9p/fid.c | 157 +++-- b/fs/9p/v9fs.c | 189 +++- b/fs/9p/v9fs.h | 38 +-- b/fs/9p/vfs_file.c |6 b/fs/9p/vfs_inode.c| 50 ++-- b/fs/9p/vfs_super.c| 19 - b/include/net/9p/9p.h | 21 - b/include/net/9p/client.h |9 b/include/net/9p/conn.h|4 b/include/net/9p/transport.h | 27 +- b/net/9p/Kconfig | 10 b/net/9p/Makefile |5 b/net/9p/client.c | 13 - b/net/9p/conv.c| 32 ++ b/net/9p/mod.c | 71 +- b/net/9p/mux.c |5 b/net/9p/trans_fd.c| 419 +++-- net/9p/sysctl.c| 81 --- 19 files changed, 689 insertions(+), 489 deletions(-) Thanks, -eric - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] 9p patches for 2.6.24 merge window
On Wed, Oct 17, 2007 at 04:34:02PM -0500, Eric Van Hensbergen wrote: Linus, please pull from the 'for-linus' branch of: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus This tree contains the following: Latchesar Ionkov(3): attach-per-user support rename uid and gid parameters define session flags Eric Van Hensbergen(4) remove sysctl code fix bad kconfig cross-dependency soften invalidationin loose mode make transports dynamic Could you please tag your patches with 9p: or [9p] so it is obvious that they belong to this subsystem. When browsing head-commits and other places this is a great help. Thanks, Sam - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] 9p patches for 2.6.24 merge window
On 10/17/07, Sam Ravnborg [EMAIL PROTECTED] wrote: On Wed, Oct 17, 2007 at 04:34:02PM -0500, Eric Van Hensbergen wrote: Linus, please pull from the 'for-linus' branch of: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus This tree contains the following: Latchesar Ionkov(3): attach-per-user support rename uid and gid parameters define session flags Eric Van Hensbergen(4) remove sysctl code fix bad kconfig cross-dependency soften invalidationin loose mode make transports dynamic Could you please tag your patches with 9p: or [9p] so it is obvious that they belong to this subsystem. When browsing head-commits and other places this is a great help. They should be so tagged, I just stripped it in my pull email summary. -eric - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] 9p patches for 2.6.24 merge window
On Wed, Oct 17, 2007 at 06:19:53PM -0500, Eric Van Hensbergen wrote: On 10/17/07, Sam Ravnborg [EMAIL PROTECTED] wrote: On Wed, Oct 17, 2007 at 04:34:02PM -0500, Eric Van Hensbergen wrote: Linus, please pull from the 'for-linus' branch of: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus This tree contains the following: Latchesar Ionkov(3): attach-per-user support rename uid and gid parameters define session flags Eric Van Hensbergen(4) remove sysctl code fix bad kconfig cross-dependency soften invalidationin loose mode make transports dynamic Could you please tag your patches with 9p: or [9p] so it is obvious that they belong to this subsystem. When browsing head-commits and other places this is a great help. They should be so tagged, I just stripped it in my pull email summary. OK - thanks. Sam - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [V9fs-developer] [GIT PULL] 9p Patches for 2.6.23 merge window
The original patchset had three patches: 1. Renames all functions and macros 2. Moves the header files from fs/9p to include/net/9p and updates the C files with the new header locations 3. Moves the C files from fs/9p to net/9p Unfortunately the three patches were applied as a single one in Eric's repository and made tracking of the changes harder. We will be more careful next time. Thanks for you comments, Lucho On 7/16/07, Linus Torvalds <[EMAIL PROTECTED]> wrote: On Sun, 15 Jul 2007, Latchesar Ionkov wrote: > > I thought that it is not a good idea to keep the v9fs_ prefix for code > that is in different places (fs/9p and net/9p). If keeping the old > prefix is more acceptable, I can create a new patch without the > "v9fs_"->"p9_" renames. It's fine, I don't care *that* much, and I already pulled. If it had been something more central, I'd have rejected it, but soemthing as specialized as the Plan9 fs, I just wanted to point out that this is now how we should do things. In other words: when doing renames it is generally *much* nicer to do a 100% rename (perhaps with just _trivial_ changes to make it compile - the include statements etc change, and maybe you want to change the name in the comment header too). Doing "move the code and change it at the same time" is considered bad form. Movement diffs are much harder to read anyway (a traditional diff will show it as a new-file + delete, of course), so the general rule is: - move code around _without_ modifying it, so that code movement (whether it's a whole file, or just a set of functions between files) doesn't really introduce any real changes, and is easier to look through the changes. - do the actual changes to the code as a separate thing. This should be true in just about *any* development model, and it's especially true in Linux, where patches are the main way people communicate. And when using git, the whole "keep code movement separate from changes" has an even more fundamental reason: git can track code movement (again, whether moving a whole file or just a function between files), and doing a "git blame -C" will actually follow code movement between files. It does that by similarity analysis, but it does mean that if you both move the code *and* change it at the same time, git cannot see that "oh, that function came originally from that other file", and now you get worse annotations about where code actually originated. So next time, please don't move code and change it at the same time. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [V9fs-developer] [GIT PULL] 9p Patches for 2.6.23 merge window
On Sun, 15 Jul 2007, Latchesar Ionkov wrote: > > I thought that it is not a good idea to keep the v9fs_ prefix for code > that is in different places (fs/9p and net/9p). If keeping the old > prefix is more acceptable, I can create a new patch without the > "v9fs_"->"p9_" renames. It's fine, I don't care *that* much, and I already pulled. If it had been something more central, I'd have rejected it, but soemthing as specialized as the Plan9 fs, I just wanted to point out that this is now how we should do things. In other words: when doing renames it is generally *much* nicer to do a 100% rename (perhaps with just _trivial_ changes to make it compile - the include statements etc change, and maybe you want to change the name in the comment header too). Doing "move the code and change it at the same time" is considered bad form. Movement diffs are much harder to read anyway (a traditional diff will show it as a new-file + delete, of course), so the general rule is: - move code around _without_ modifying it, so that code movement (whether it's a whole file, or just a set of functions between files) doesn't really introduce any real changes, and is easier to look through the changes. - do the actual changes to the code as a separate thing. This should be true in just about *any* development model, and it's especially true in Linux, where patches are the main way people communicate. And when using git, the whole "keep code movement separate from changes" has an even more fundamental reason: git can track code movement (again, whether moving a whole file or just a function between files), and doing a "git blame -C" will actually follow code movement between files. It does that by similarity analysis, but it does mean that if you both move the code *and* change it at the same time, git cannot see that "oh, that function came originally from that other file", and now you get worse annotations about where code actually originated. So next time, please don't move code and change it at the same time. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [V9fs-developer] [GIT PULL] 9p Patches for 2.6.23 merge window
On Sun, 15 Jul 2007, Latchesar Ionkov wrote: I thought that it is not a good idea to keep the v9fs_ prefix for code that is in different places (fs/9p and net/9p). If keeping the old prefix is more acceptable, I can create a new patch without the v9fs_-p9_ renames. It's fine, I don't care *that* much, and I already pulled. If it had been something more central, I'd have rejected it, but soemthing as specialized as the Plan9 fs, I just wanted to point out that this is now how we should do things. In other words: when doing renames it is generally *much* nicer to do a 100% rename (perhaps with just _trivial_ changes to make it compile - the include statements etc change, and maybe you want to change the name in the comment header too). Doing move the code and change it at the same time is considered bad form. Movement diffs are much harder to read anyway (a traditional diff will show it as a new-file + delete, of course), so the general rule is: - move code around _without_ modifying it, so that code movement (whether it's a whole file, or just a set of functions between files) doesn't really introduce any real changes, and is easier to look through the changes. - do the actual changes to the code as a separate thing. This should be true in just about *any* development model, and it's especially true in Linux, where patches are the main way people communicate. And when using git, the whole keep code movement separate from changes has an even more fundamental reason: git can track code movement (again, whether moving a whole file or just a function between files), and doing a git blame -C will actually follow code movement between files. It does that by similarity analysis, but it does mean that if you both move the code *and* change it at the same time, git cannot see that oh, that function came originally from that other file, and now you get worse annotations about where code actually originated. So next time, please don't move code and change it at the same time. Linus - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [V9fs-developer] [GIT PULL] 9p Patches for 2.6.23 merge window
The original patchset had three patches: 1. Renames all functions and macros 2. Moves the header files from fs/9p to include/net/9p and updates the C files with the new header locations 3. Moves the C files from fs/9p to net/9p Unfortunately the three patches were applied as a single one in Eric's repository and made tracking of the changes harder. We will be more careful next time. Thanks for you comments, Lucho On 7/16/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Sun, 15 Jul 2007, Latchesar Ionkov wrote: I thought that it is not a good idea to keep the v9fs_ prefix for code that is in different places (fs/9p and net/9p). If keeping the old prefix is more acceptable, I can create a new patch without the v9fs_-p9_ renames. It's fine, I don't care *that* much, and I already pulled. If it had been something more central, I'd have rejected it, but soemthing as specialized as the Plan9 fs, I just wanted to point out that this is now how we should do things. In other words: when doing renames it is generally *much* nicer to do a 100% rename (perhaps with just _trivial_ changes to make it compile - the include statements etc change, and maybe you want to change the name in the comment header too). Doing move the code and change it at the same time is considered bad form. Movement diffs are much harder to read anyway (a traditional diff will show it as a new-file + delete, of course), so the general rule is: - move code around _without_ modifying it, so that code movement (whether it's a whole file, or just a set of functions between files) doesn't really introduce any real changes, and is easier to look through the changes. - do the actual changes to the code as a separate thing. This should be true in just about *any* development model, and it's especially true in Linux, where patches are the main way people communicate. And when using git, the whole keep code movement separate from changes has an even more fundamental reason: git can track code movement (again, whether moving a whole file or just a function between files), and doing a git blame -C will actually follow code movement between files. It does that by similarity analysis, but it does mean that if you both move the code *and* change it at the same time, git cannot see that oh, that function came originally from that other file, and now you get worse annotations about where code actually originated. So next time, please don't move code and change it at the same time. Linus - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [V9fs-developer] [GIT PULL] 9p Patches for 2.6.23 merge window
On Sun, 15 Jul 2007, Latchesar Ionkov wrote:
I thought that it is not a good idea to keep the v9fs_ prefix for code
that is in different places (fs/9p and net/9p). If keeping the old
prefix is more acceptable, I can create a new patch without the
"v9fs_"->"p9_" renames.
do the code reorg and the name changes as two different patches. it makes
it much easier to see that the rename doesn't change any functionality,
and makes the code reorg much easier to see.
David Lang
Thanks,
Lucho
On 7/15/07, Linus Torvalds <[EMAIL PROTECTED]> wrote:
On Sat, 14 Jul 2007, Eric Van Hensbergen wrote:
>
> The bulk of the changes were in the reorganization patch which mostly
> moved files and interfaces around in preparation for work on an
> in-kernel 9p server.
Please use "git diff -C --stat --summary" to generate the diffstat
summary.
In particular, because you didn't use -C (or -M), git have you an
old-style diffstat without renames, so the diffstat doesn't show that a
lot of it was moving code around.
(That said, you seem to have changed names a lot too, so it's not pure
code movement).
> 49 files changed, 5400 insertions(+), 5092 deletions(-)
With rename detection enabled, I get
36 files changed, 3444 insertions(+), 3130 deletions(-)
due to finding some (partially dubious) renames:
rename fs/9p/mux.h => include/net/9p/conn.h (53%)
rename {fs => include/net}/9p/transport.h (59%)
rename {fs => net}/9p/conv.c (55%)
rename {fs => net}/9p/fcprint.c (64%)
rename {fs => net}/9p/mux.c (55%)
even though is misses a lot of others (due to all the "v9fs" -> "p9"
changes in the source code too - was that really worth it?).
Linus
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
V9fs-developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/v9fs-developer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [V9fs-developer] [GIT PULL] 9p Patches for 2.6.23 merge window
I thought that it is not a good idea to keep the v9fs_ prefix for code
that is in different places (fs/9p and net/9p). If keeping the old
prefix is more acceptable, I can create a new patch without the
"v9fs_"->"p9_" renames.
Thanks,
Lucho
On 7/15/07, Linus Torvalds <[EMAIL PROTECTED]> wrote:
On Sat, 14 Jul 2007, Eric Van Hensbergen wrote:
>
> The bulk of the changes were in the reorganization patch which mostly
> moved files and interfaces around in preparation for work on an
> in-kernel 9p server.
Please use "git diff -C --stat --summary" to generate the diffstat
summary.
In particular, because you didn't use -C (or -M), git have you an
old-style diffstat without renames, so the diffstat doesn't show that a
lot of it was moving code around.
(That said, you seem to have changed names a lot too, so it's not pure
code movement).
> 49 files changed, 5400 insertions(+), 5092 deletions(-)
With rename detection enabled, I get
36 files changed, 3444 insertions(+), 3130 deletions(-)
due to finding some (partially dubious) renames:
rename fs/9p/mux.h => include/net/9p/conn.h (53%)
rename {fs => include/net}/9p/transport.h (59%)
rename {fs => net}/9p/conv.c (55%)
rename {fs => net}/9p/fcprint.c (64%)
rename {fs => net}/9p/mux.c (55%)
even though is misses a lot of others (due to all the "v9fs" -> "p9"
changes in the source code too - was that really worth it?).
Linus
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
V9fs-developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/v9fs-developer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] 9p Patches for 2.6.23 merge window
On Sat, 14 Jul 2007, Eric Van Hensbergen wrote:
>
> The bulk of the changes were in the reorganization patch which mostly
> moved files and interfaces around in preparation for work on an
> in-kernel 9p server.
Please use "git diff -C --stat --summary" to generate the diffstat
summary.
In particular, because you didn't use -C (or -M), git have you an
old-style diffstat without renames, so the diffstat doesn't show that a
lot of it was moving code around.
(That said, you seem to have changed names a lot too, so it's not pure
code movement).
> 49 files changed, 5400 insertions(+), 5092 deletions(-)
With rename detection enabled, I get
36 files changed, 3444 insertions(+), 3130 deletions(-)
due to finding some (partially dubious) renames:
rename fs/9p/mux.h => include/net/9p/conn.h (53%)
rename {fs => include/net}/9p/transport.h (59%)
rename {fs => net}/9p/conv.c (55%)
rename {fs => net}/9p/fcprint.c (64%)
rename {fs => net}/9p/mux.c (55%)
even though is misses a lot of others (due to all the "v9fs" -> "p9"
changes in the source code too - was that really worth it?).
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] 9p Patches for 2.6.23 merge window
On Sat, 14 Jul 2007, Eric Van Hensbergen wrote:
The bulk of the changes were in the reorganization patch which mostly
moved files and interfaces around in preparation for work on an
in-kernel 9p server.
Please use git diff -C --stat --summary to generate the diffstat
summary.
In particular, because you didn't use -C (or -M), git have you an
old-style diffstat without renames, so the diffstat doesn't show that a
lot of it was moving code around.
(That said, you seem to have changed names a lot too, so it's not pure
code movement).
49 files changed, 5400 insertions(+), 5092 deletions(-)
With rename detection enabled, I get
36 files changed, 3444 insertions(+), 3130 deletions(-)
due to finding some (partially dubious) renames:
rename fs/9p/mux.h = include/net/9p/conn.h (53%)
rename {fs = include/net}/9p/transport.h (59%)
rename {fs = net}/9p/conv.c (55%)
rename {fs = net}/9p/fcprint.c (64%)
rename {fs = net}/9p/mux.c (55%)
even though is misses a lot of others (due to all the v9fs - p9
changes in the source code too - was that really worth it?).
Linus
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [V9fs-developer] [GIT PULL] 9p Patches for 2.6.23 merge window
I thought that it is not a good idea to keep the v9fs_ prefix for code
that is in different places (fs/9p and net/9p). If keeping the old
prefix is more acceptable, I can create a new patch without the
v9fs_-p9_ renames.
Thanks,
Lucho
On 7/15/07, Linus Torvalds [EMAIL PROTECTED] wrote:
On Sat, 14 Jul 2007, Eric Van Hensbergen wrote:
The bulk of the changes were in the reorganization patch which mostly
moved files and interfaces around in preparation for work on an
in-kernel 9p server.
Please use git diff -C --stat --summary to generate the diffstat
summary.
In particular, because you didn't use -C (or -M), git have you an
old-style diffstat without renames, so the diffstat doesn't show that a
lot of it was moving code around.
(That said, you seem to have changed names a lot too, so it's not pure
code movement).
49 files changed, 5400 insertions(+), 5092 deletions(-)
With rename detection enabled, I get
36 files changed, 3444 insertions(+), 3130 deletions(-)
due to finding some (partially dubious) renames:
rename fs/9p/mux.h = include/net/9p/conn.h (53%)
rename {fs = include/net}/9p/transport.h (59%)
rename {fs = net}/9p/conv.c (55%)
rename {fs = net}/9p/fcprint.c (64%)
rename {fs = net}/9p/mux.c (55%)
even though is misses a lot of others (due to all the v9fs - p9
changes in the source code too - was that really worth it?).
Linus
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
V9fs-developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/v9fs-developer
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [V9fs-developer] [GIT PULL] 9p Patches for 2.6.23 merge window
On Sun, 15 Jul 2007, Latchesar Ionkov wrote:
I thought that it is not a good idea to keep the v9fs_ prefix for code
that is in different places (fs/9p and net/9p). If keeping the old
prefix is more acceptable, I can create a new patch without the
v9fs_-p9_ renames.
do the code reorg and the name changes as two different patches. it makes
it much easier to see that the rename doesn't change any functionality,
and makes the code reorg much easier to see.
David Lang
Thanks,
Lucho
On 7/15/07, Linus Torvalds [EMAIL PROTECTED] wrote:
On Sat, 14 Jul 2007, Eric Van Hensbergen wrote:
The bulk of the changes were in the reorganization patch which mostly
moved files and interfaces around in preparation for work on an
in-kernel 9p server.
Please use git diff -C --stat --summary to generate the diffstat
summary.
In particular, because you didn't use -C (or -M), git have you an
old-style diffstat without renames, so the diffstat doesn't show that a
lot of it was moving code around.
(That said, you seem to have changed names a lot too, so it's not pure
code movement).
49 files changed, 5400 insertions(+), 5092 deletions(-)
With rename detection enabled, I get
36 files changed, 3444 insertions(+), 3130 deletions(-)
due to finding some (partially dubious) renames:
rename fs/9p/mux.h = include/net/9p/conn.h (53%)
rename {fs = include/net}/9p/transport.h (59%)
rename {fs = net}/9p/conv.c (55%)
rename {fs = net}/9p/fcprint.c (64%)
rename {fs = net}/9p/mux.c (55%)
even though is misses a lot of others (due to all the v9fs - p9
changes in the source code too - was that really worth it?).
Linus
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
V9fs-developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/v9fs-developer
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] 9p Patches for 2.6.23 merge window
Linus, please pull from the 'for-linus' branch of: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus This tree contains the following: Latchesar Ionkov(3): Reorganization of 9p file system code Change net/9p module name to 9pnet Set error to EREMOTEIO if transport write returns zero Eric Van Hensbergen(3) Cache meta-data when loose cache option is set Renable mount-time debug option Fix a race condition bug in umount which caused segfault The bulk of the changes were in the reorganization patch which mostly moved files and interfaces around in preparation for work on an in-kernel 9p server. b/fs/9p/Makefile |6 b/fs/9p/fid.c| 168 ++ b/fs/9p/fid.h| 43 - b/fs/9p/v9fs.c | 288 ++- b/fs/9p/v9fs.h | 32 - b/fs/9p/v9fs_vfs.h |6 b/fs/9p/vfs_addr.c | 57 -- b/fs/9p/vfs_dentry.c | 37 - b/fs/9p/vfs_dir.c| 155 +- b/fs/9p/vfs_file.c | 160 +- b/fs/9p/vfs_inode.c | 753 +++--- b/fs/9p/vfs_super.c | 91 +-- b/fs/Kconfig |2 b/include/net/9p/9p.h| 417 + b/include/net/9p/client.h| 80 +++ b/include/net/9p/conn.h | 57 ++ b/include/net/9p/transport.h | 49 ++ b/net/9p/Kconfig | 21 b/net/9p/Makefile| 13 b/net/9p/client.c| 965 +++ b/net/9p/conv.c | 903 b/net/9p/error.c | 240 + b/net/9p/fcprint.c | 358 ++ b/net/9p/mod.c | 85 +++ b/net/9p/mux.c | 1050 +++ b/net/9p/sysctl.c| 86 +++ b/net/9p/trans_fd.c | 363 ++ b/net/9p/util.c | 125 + b/net/Kconfig|1 b/net/Makefile |2 fs/9p/9p.h | 375 --- fs/9p/conv.c | 845 -- fs/9p/conv.h | 50 -- fs/9p/debug.h| 77 --- fs/9p/error.c| 93 --- fs/9p/error.h| 177 --- fs/9p/fcall.c| 427 - fs/9p/fcprint.c | 345 -- fs/9p/mux.c | 1033 -- fs/9p/mux.h | 55 -- fs/9p/trans_fd.c | 308 fs/9p/transport.h| 45 - fs/9p/v9fs.c |7 fs/9p/vfs_file.c | 14 fs/9p/vfs_inode.c|4 fs/9p/vfs_super.c|3 net/9p/Makefile |7 net/9p/client.c |7 net/9p/mux.c |7 49 files changed, 5400 insertions(+), 5092 deletions(-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] 9p Patches for 2.6.23 merge window
Linus, please pull from the 'for-linus' branch of: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus This tree contains the following: Latchesar Ionkov(3): Reorganization of 9p file system code Change net/9p module name to 9pnet Set error to EREMOTEIO if transport write returns zero Eric Van Hensbergen(3) Cache meta-data when loose cache option is set Renable mount-time debug option Fix a race condition bug in umount which caused segfault The bulk of the changes were in the reorganization patch which mostly moved files and interfaces around in preparation for work on an in-kernel 9p server. b/fs/9p/Makefile |6 b/fs/9p/fid.c| 168 ++ b/fs/9p/fid.h| 43 - b/fs/9p/v9fs.c | 288 ++- b/fs/9p/v9fs.h | 32 - b/fs/9p/v9fs_vfs.h |6 b/fs/9p/vfs_addr.c | 57 -- b/fs/9p/vfs_dentry.c | 37 - b/fs/9p/vfs_dir.c| 155 +- b/fs/9p/vfs_file.c | 160 +- b/fs/9p/vfs_inode.c | 753 +++--- b/fs/9p/vfs_super.c | 91 +-- b/fs/Kconfig |2 b/include/net/9p/9p.h| 417 + b/include/net/9p/client.h| 80 +++ b/include/net/9p/conn.h | 57 ++ b/include/net/9p/transport.h | 49 ++ b/net/9p/Kconfig | 21 b/net/9p/Makefile| 13 b/net/9p/client.c| 965 +++ b/net/9p/conv.c | 903 b/net/9p/error.c | 240 + b/net/9p/fcprint.c | 358 ++ b/net/9p/mod.c | 85 +++ b/net/9p/mux.c | 1050 +++ b/net/9p/sysctl.c| 86 +++ b/net/9p/trans_fd.c | 363 ++ b/net/9p/util.c | 125 + b/net/Kconfig|1 b/net/Makefile |2 fs/9p/9p.h | 375 --- fs/9p/conv.c | 845 -- fs/9p/conv.h | 50 -- fs/9p/debug.h| 77 --- fs/9p/error.c| 93 --- fs/9p/error.h| 177 --- fs/9p/fcall.c| 427 - fs/9p/fcprint.c | 345 -- fs/9p/mux.c | 1033 -- fs/9p/mux.h | 55 -- fs/9p/trans_fd.c | 308 fs/9p/transport.h| 45 - fs/9p/v9fs.c |7 fs/9p/vfs_file.c | 14 fs/9p/vfs_inode.c|4 fs/9p/vfs_super.c|3 net/9p/Makefile |7 net/9p/client.c |7 net/9p/mux.c |7 49 files changed, 5400 insertions(+), 5092 deletions(-) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] 9p patches
Linus, please pull from the 'for-linus' branch of: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus This tree contains the following: Adrian Bunk(1): make struct v9fs_cached_file_operations static v9fs_vfs.h |1 - vfs_file.c |4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] 9p patches
Linus, please pull from the 'for-linus' branch of: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus This tree contains the following: Adrian Bunk(1): make struct v9fs_cached_file_operations static v9fs_vfs.h |1 - vfs_file.c |4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] 9p patches
Linus, please pull from the 'for-linus' branch of: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus This tree contains the following: Eric Van Hensbergen(1): Implement optional loose read cache Eric W. Biederman(1): Use kthread_strop instead of sending a SIGKILL. Documentation/filesystems/00-INDEX |4 ++-- Documentation/filesystems/9p.txt |4 fs/9p/fid.c|3 ++- fs/9p/mux.c|5 + fs/9p/v9fs.c |9 - fs/9p/v9fs.h |9 - fs/9p/v9fs_vfs.h |2 ++ fs/9p/vfs_addr.c |2 ++ fs/9p/vfs_dentry.c | 26 ++ fs/9p/vfs_file.c | 18 ++ fs/9p/vfs_inode.c | 20 11 files changed, 89 insertions(+), 13 deletions(-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] 9p patches
Linus, please pull from the 'for-linus' branch of: git://git.kernel.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ for-linus This tree contains the following: Eric Van Hensbergen(1): Implement optional loose read cache Eric W. Biederman(1): Use kthread_strop instead of sending a SIGKILL. Documentation/filesystems/00-INDEX |4 ++-- Documentation/filesystems/9p.txt |4 fs/9p/fid.c|3 ++- fs/9p/mux.c|5 + fs/9p/v9fs.c |9 - fs/9p/v9fs.h |9 - fs/9p/v9fs_vfs.h |2 ++ fs/9p/vfs_addr.c |2 ++ fs/9p/vfs_dentry.c | 26 ++ fs/9p/vfs_file.c | 18 ++ fs/9p/vfs_inode.c | 20 11 files changed, 89 insertions(+), 13 deletions(-) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
