Re: [GIT PULL] Btrfs fixes for 5.12-rc5
The pull request you sent on Thu, 25 Mar 2021 22:36:55 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.12-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/701c09c988bd60d950d49c48993b6c06efbfba7f Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.12-rc5
From: David Sterba Hi, there are few fixes for issues that have some user visibility and are simple enough for this time of development cycle. Please pull thanks. - a few fixes for rescue= mount option, adding more checks for missing trees - fix sleeping in atomic context on qgroup deletion - fix subvolume deletion on mount - fix build with M= syntax - fix checksum mismatch error message for direct io The following changes since commit 485df75554257e883d0ce39bb886e8212349748e: btrfs: always pin deleted leaves when there are active tree mod log users (2021-03-16 20:32:22 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.12-rc4-tag for you to fetch changes up to c1d6abdac46ca8127274bea195d804e3f2cec7ee: btrfs: fix check_data_csum() error message for direct I/O (2021-03-18 21:25:11 +0100) David Sterba (1): btrfs: fix build when using M=fs/btrfs Filipe Manana (2): btrfs: fix subvolume/snapshot deletion not triggered on mount btrfs: fix sleep while in non-sleep context during qgroup removal Johannes Thumshirn (1): btrfs: zoned: remove outdated WARN_ON in direct IO Josef Bacik (3): btrfs: do not initialize dev stats if we have no dev_root btrfs: initialize device::fs_info always btrfs: do not initialize dev replace for bad dev root Omar Sandoval (1): btrfs: fix check_data_csum() error message for direct I/O fs/btrfs/Makefile | 10 ++ fs/btrfs/dev-replace.c | 3 +++ fs/btrfs/disk-io.c | 19 +-- fs/btrfs/inode.c | 18 +- fs/btrfs/qgroup.c | 12 ++-- fs/btrfs/volumes.c | 3 +++ 6 files changed, 48 insertions(+), 17 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.12-rc4
The pull request you sent on Thu, 18 Mar 2021 21:14:11 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.12-rc3-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/81aa0968b7ea6dbabcdcda37dc8434dca6e1565b Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.12-rc4
From: David Sterba Hi, there are still regressions being found and fixed in the zoned mode and subpage code, the rest are fixes for bugs reported by users. Please pull, thanks. Regressions: - subpage block support: - readahead works on the proper block size - fix last page zeroing - zoned mode: - linked list corruption for tree log Fixes: - qgroup leak after falloc faiulre - tree mod log and backref resolving - extent buffer cloning race when resolving backrefs - pin deleted leaves with active tree mod log users - drop debugging flag from slab cache The following changes since commit badae9c86979c459bd7d895d6d7ddc7a01131ff7: btrfs: zoned: do not account freed region of read-only block group as zone_unusable (2021-03-04 16:16:58 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.12-rc3-tag for you to fetch changes up to 485df75554257e883d0ce39bb886e8212349748e: btrfs: always pin deleted leaves when there are active tree mod log users (2021-03-16 20:32:22 +0100) David Sterba (1): btrfs: fix slab cache flags for free space tree bitmap Filipe Manana (3): btrfs: zoned: fix linked list corruption after log root tree allocation failure btrfs: fix race when cloning extent buffer during rewind of an old root btrfs: always pin deleted leaves when there are active tree mod log users Qu Wenruo (5): btrfs: fix wrong offset to zero out range beyond i_size btrfs: track qgroup released data in own variable in insert_prealloc_file_extent btrfs: fix qgroup data rsv leak caused by falloc failure btrfs: subpage: fix wild pointer access during metadata read failure btrfs: subpage: make readahead work properly fs/btrfs/ctree.c | 2 ++ fs/btrfs/extent-tree.c | 23 ++- fs/btrfs/extent_io.c | 33 +++-- fs/btrfs/inode.c | 37 ++--- fs/btrfs/reada.c | 35 ++- fs/btrfs/tree-log.c| 8 6 files changed, 103 insertions(+), 35 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.12-rc1, part 2
The pull request you sent on Fri, 5 Mar 2021 16:55:17 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.12-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f09b04cc6447331e731629e8b72587287f3a4490 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.12-rc1, part 2
From: David Sterba Hi, more regression fixes and stabilization. Please pull, thanks. Regressions: - zoned mode - count zone sizes in wider int types - fix space accounting for read-only block groups - subpage: fix page tail zeroing Fixes: - fix spurious warning when remounting with free space tree - fix warning when creating a directory with smack enabled - ioctl checks for qgroup inheritance when creating a snapshot - qgroup - fix missing unlock on error path in zero range - fix amount of released reservation on error - fix flushing from unsafe context with open transaction, potentially deadlocking - minor build warning fixes The following changes since commit 6e37d245994189ba757df7dc2950a44d31421ac6: btrfs: zoned: fix deadlock on log sync (2021-02-22 18:08:48 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.12-rc1-tag for you to fetch changes up to badae9c86979c459bd7d895d6d7ddc7a01131ff7: btrfs: zoned: do not account freed region of read-only block group as zone_unusable (2021-03-04 16:16:58 +0100) Boris Burkov (1): btrfs: fix spurious free_space_tree remount warning Dan Carpenter (1): btrfs: validate qgroup inherit for SNAP_CREATE_V2 ioctl Filipe Manana (1): btrfs: fix warning when creating a directory with smack enabled Naohiro Aota (2): btrfs: zoned: use sector_t for zone sectors btrfs: zoned: do not account freed region of read-only block group as zone_unusable Nikolay Borisov (4): btrfs: unlock extents in btrfs_zero_range in case of quota reservation errors btrfs: free correct amount of space in btrfs_delayed_inode_reserve_metadata btrfs: export and rename qgroup_reserve_meta btrfs: don't flush from btrfs_delayed_inode_reserve_metadata Qu Wenruo (1): btrfs: subpage: fix the false data csum mismatch error Randy Dunlap (1): btrfs: ref-verify: use 'inline void' keyword ordering fs/btrfs/delayed-inode.c| 5 +++-- fs/btrfs/extent_io.c| 21 - fs/btrfs/file.c | 5 - fs/btrfs/free-space-cache.c | 7 ++- fs/btrfs/inode.c| 2 +- fs/btrfs/ioctl.c| 19 ++- fs/btrfs/qgroup.c | 8 fs/btrfs/qgroup.h | 2 ++ fs/btrfs/ref-verify.c | 4 ++-- fs/btrfs/super.c| 4 ++-- fs/btrfs/xattr.c| 31 +++ fs/btrfs/zoned.c| 4 ++-- 12 files changed, 87 insertions(+), 25 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.11-rc6
The pull request you sent on Sat, 30 Jan 2021 01:35:38 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.11-rc5-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c05d51c773fb365bdbd683b3e4e80679c8b8b176 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Re: [GIT PULL] Btrfs fixes for 5.11-rc6
On Fri, Jan 29, 2021 at 4:37 PM David Sterba wrote: > > I'm not sure the first post of this pull request made it through so > sending again. Already merged a few hours ago as commit c05d51c773fb. But you may have fallen afoul of the "either lkml or lore is sick" issue, so pr-tracker-bot isn't working. We've had a few of those lately. Linus
[GIT PULL] Btrfs fixes for 5.11-rc6
Hi, I'm not sure the first post of this pull request made it through so sending again. A few more fixes for a late rc: - fix lockdep complaint on 32bit arches and also remove an unsafe memory use due to device vs filesystem lifetime - two fixes for free space tree - race during log replay and cache rebuild, now more likely to happen due to changes in this dev cycle - possible free space tree corruption with online conversion during initial tree population Please pull, thanks. The following changes since commit 34d1eb0e599875064955a74712f08ff14c8e3d5f: btrfs: don't clear ret in btrfs_start_dirty_block_groups (2021-01-18 16:00:11 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.11-rc5-tag for you to fetch changes up to 9ad6d91f056b99dbe59a262810cb342519ea8d39: btrfs: fix log replay failure due to race with space cache rebuild (2021-01-25 18:44:53 +0100) Filipe Manana (1): btrfs: fix log replay failure due to race with space cache rebuild Josef Bacik (1): btrfs: fix possible free space tree corruption with online conversion Su Yue (1): btrfs: fix lockdep warning due to seqcount_mutex on 32bit arch fs/btrfs/block-group.c | 10 +++- fs/btrfs/ctree.h | 3 +++ fs/btrfs/extent-tree.c | 61 ++ fs/btrfs/free-space-tree.c | 10 +++- fs/btrfs/volumes.c | 2 +- fs/btrfs/volumes.h | 11 + 6 files changed, 46 insertions(+), 51 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.11-rc5
The pull request you sent on Wed, 20 Jan 2021 22:49:46 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.11-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9791581c049c10929e97098374dd1716a81fefcc Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.11-rc5
Hi, a few more one line fixes for various bugs, stable material. - fix send when emitting clone operation from the same file and root - fix double free on error when cleaning backrefs - lockdep fix during relocation - handle potential error during reloc when starting transaction - skip running delayed refs during commit (leftover from code removal in this dev cycle) Please pull thanks. The following changes since commit e076ab2a2ca70a0270232067cd49f76cd92efe64: btrfs: shrink delalloc pages instead of full inodes (2021-01-08 16:36:44 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.11-rc4-tag for you to fetch changes up to 34d1eb0e599875064955a74712f08ff14c8e3d5f: btrfs: don't clear ret in btrfs_start_dirty_block_groups (2021-01-18 16:00:11 +0100) David Sterba (1): btrfs: no need to run delayed refs after commit_fs_roots during commit Filipe Manana (1): btrfs: send: fix invalid clone operations when cloning from the same file and root Josef Bacik (4): btrfs: don't get an EINTR during drop_snapshot for reloc btrfs: do not double free backref nodes on error btrfs: fix lockdep splat in btrfs_recover_relocation btrfs: don't clear ret in btrfs_start_dirty_block_groups fs/btrfs/backref.c | 2 +- fs/btrfs/block-group.c | 3 ++- fs/btrfs/extent-tree.c | 10 +- fs/btrfs/send.c| 15 +++ fs/btrfs/transaction.c | 8 fs/btrfs/volumes.c | 2 ++ 6 files changed, 29 insertions(+), 11 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.11-rc4
The pull request you sent on Mon, 11 Jan 2021 22:09:55 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.11-rc3-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6e68b9961ff690ace07fac22c3c7752882ecc40a Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.11-rc4
Hi, more material for stable trees. Please pull, thanks. - tree-checker: check item end overflow - fix false warning during relocation regarding extent type - fix inode flushing logic, caused notable performance regression (since 5.10) - debugging fixups: - print correct offset for reloc tree key - pass reliable fs_info pointer to error reporting helper The following changes since commit a8cc263eb58ca133617662a5a5e07131d0ebf299: btrfs: run delayed iputs when remounting RO to avoid leaking them (2020-12-18 15:00:08 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.11-rc3-tag for you to fetch changes up to e076ab2a2ca70a0270232067cd49f76cd92efe64: btrfs: shrink delalloc pages instead of full inodes (2021-01-08 16:36:44 +0100) Josef Bacik (2): btrfs: print the actual offset in btrfs_root_name btrfs: shrink delalloc pages instead of full inodes Qu Wenruo (1): btrfs: reloc: fix wrong file extent type check to avoid false ENOENT Su Yue (2): btrfs: prevent NULL pointer dereference in extent_io_tree_panic btrfs: tree-checker: check if chunk item end overflows fs/btrfs/disk-io.c | 2 +- fs/btrfs/extent_io.c| 4 +--- fs/btrfs/inode.c| 60 +++-- fs/btrfs/print-tree.c | 10 - fs/btrfs/print-tree.h | 2 +- fs/btrfs/relocation.c | 7 +- fs/btrfs/space-info.c | 4 +++- fs/btrfs/tree-checker.c | 7 ++ 8 files changed, 67 insertions(+), 29 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.11-rc3
The pull request you sent on Wed, 6 Jan 2021 12:48:12 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.11-rc2-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/71c061d2443814de15e177489d5cc00a4a253ef3 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.11-rc3
Hi, a few more fixes that arrived before the end of the year. Please pull, thanks. - a bunch of fixes related to transaction handle lifetime wrt various operations (umount, remount, qgroup scan, orphan cleanup) - async discard scheduling fixes - fix item size calculation when item keys collide for extend refs (hardlinks) - fix qgroup flushing from running transaction - fix send, wrong file path when there is an inode with a pending rmdir - fix deadlock when cloning inline extent and low on free metadata space The following changes since commit b42fe98c92698d2a10094997e5f4d2dd968fd44f: btrfs: scrub: allow scrub to work with subpage sectorsize (2020-12-09 19:16:11 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.11-rc2-tag for you to fetch changes up to a8cc263eb58ca133617662a5a5e07131d0ebf299: btrfs: run delayed iputs when remounting RO to avoid leaking them (2020-12-18 15:00:08 +0100) Filipe Manana (7): btrfs: fix deadlock when cloning inline extent and low on free metadata space btrfs: send: fix wrong file path when there is an inode with a pending rmdir btrfs: fix transaction leak and crash after RO remount caused by qgroup rescan btrfs: fix transaction leak and crash after cleaning up orphans on RO mount btrfs: fix race between RO remount and the cleaner task btrfs: add assertion for empty list of transactions at late stage of umount btrfs: run delayed iputs when remounting RO to avoid leaking them Josef Bacik (1): btrfs: tests: initialize test inodes location Pavel Begunkov (3): btrfs: fix async discard stall btrfs: fix racy access to discard_ctl data btrfs: merge critical sections of discard lock in workfn Qu Wenruo (1): btrfs: qgroup: don't try to wait flushing if we're already holding a transaction ethanwu (1): btrfs: correctly calculate item size used when item key collision happens fs/btrfs/btrfs_inode.h | 9 ++ fs/btrfs/ctree.c | 24 +-- fs/btrfs/ctree.h | 29 -- fs/btrfs/dev-replace.c | 2 +- fs/btrfs/discard.c | 70 +++- fs/btrfs/disk-io.c | 13 fs/btrfs/extent-tree.c | 2 ++ fs/btrfs/file-item.c | 2 ++ fs/btrfs/inode.c | 15 +++--- fs/btrfs/ioctl.c | 2 +- fs/btrfs/qgroup.c| 43 +++ fs/btrfs/reflink.c | 15 ++ fs/btrfs/send.c | 49 +++ fs/btrfs/space-info.c| 2 +- fs/btrfs/super.c | 40 +++-- fs/btrfs/tests/btrfs-tests.c | 10 +-- fs/btrfs/tests/inode-tests.c | 9 -- fs/btrfs/volumes.c | 4 +-- 18 files changed, 243 insertions(+), 97 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.10-rc6
The pull request you sent on Fri, 27 Nov 2020 16:36:15 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.10-rc5-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a17a3ca55e96d20e25e8b1a7cd08192ce2bac3cc Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.10-rc6
Hi, a few fixes for various warnings that accumulated over past two weeks. - tree-checker: add missing return values for some errors - lockdep fixes - when reading qgroup config and starting quota rescan - reverse order of quota ioctl lock and VFS freeze lock - avoid accessing potentially stale fs info during device scan, reported by syzbot - add scope NOFS protection around qgroup relation changes - check for running transaction before flushing qgroups - fix tracking of new delalloc ranges for some cases Please pull, thanks. The following changes since commit 468600c6ec28613b756193c5f780aac062f1acdf: btrfs: ref-verify: fix memory leak in btrfs_ref_tree_mod (2020-11-05 13:03:39 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.10-rc5-tag for you to fetch changes up to a855fbe69229078cd8aecd8974fb996a5ca651e6: btrfs: fix lockdep splat when enabling and disabling qgroups (2020-11-23 21:16:43 +0100) Daniel Xu (1): btrfs: tree-checker: add missing return after error in root_item David Sterba (1): btrfs: tree-checker: add missing returns after data_ref alignment checks Filipe Manana (4): btrfs: fix missing delalloc new bit for new delalloc ranges btrfs: fix lockdep splat when reading qgroup config on mount btrfs: do nofs allocations when adding and removing qgroup relations btrfs: fix lockdep splat when enabling and disabling qgroups Johannes Thumshirn (1): btrfs: don't access possibly stale fs_info data for printing duplicate device Qu Wenruo (1): btrfs: qgroup: don't commit transaction when we already hold the handle fs/btrfs/ctree.h | 5 ++- fs/btrfs/file.c | 57 fs/btrfs/inode.c | 58 + fs/btrfs/qgroup.c| 88 +++- fs/btrfs/tests/inode-tests.c | 12 -- fs/btrfs/tree-checker.c | 3 ++ fs/btrfs/volumes.c | 8 +++- 7 files changed, 158 insertions(+), 73 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.10-rc2
The pull request you sent on Fri, 30 Oct 2020 17:12:27 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.10-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f5d808567a51d97e171e0a8111813f973bf4ac12 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.10-rc2
Hi, please pull the following branch with fixes. Thanks. - lockdep fixes - drop path locks before manipulating sysfs objects or qgroups - preliminary fixes before tree locks get switched to rwsem - use annotated seqlock - build warning fixes (printk format) - fix relocation vs fallocate race - tree checker properly validates number of stripes and parity - readahead vs device replace fixes - iomap dio fix for unnecessary buffered io fallback The following changes since commit 1fd4033dd011a3525bacddf37ab9eac425d25c4f: btrfs: rename BTRFS_INODE_ORDERED_DATA_CLOSE flag (2020-10-07 12:18:00 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.10-rc1-tag for you to fetch changes up to d5c8238849e7bae6063dfc16c08ed62cee7ee688: btrfs: convert data_seqcount to seqcount_mutex_t (2020-10-27 15:11:51 +0100) Daniel Xu (1): btrfs: tree-checker: validate number of chunk stripes and parity Davidlohr Bueso (1): btrfs: convert data_seqcount to seqcount_mutex_t Filipe Manana (3): btrfs: fix relocation failure due to race with fallocate btrfs: fix use-after-free on readahead extent after failure to create it btrfs: fix readahead hang and use-after-free after removing a device Johannes Thumshirn (1): btrfs: don't fallback to buffered read if we don't need to Josef Bacik (3): btrfs: drop the path before adding block group sysfs files btrfs: drop the path before adding qgroup items when enabling qgroups btrfs: add a helper to read the tree_root commit root for backref lookup Pujin Shi (1): btrfs: tree-checker: fix incorrect printk format fs/btrfs/backref.c | 13 - fs/btrfs/block-group.c | 1 + fs/btrfs/ctree.h| 2 + fs/btrfs/dev-replace.c | 5 ++ fs/btrfs/disk-io.c | 139 ++-- fs/btrfs/disk-io.h | 3 ++ fs/btrfs/extent-tree.c | 2 +- fs/btrfs/file.c | 3 +- fs/btrfs/inode.c| 8 ++- fs/btrfs/qgroup.c | 18 +++ fs/btrfs/reada.c| 47 fs/btrfs/tree-checker.c | 18 +++ fs/btrfs/volumes.c | 5 +- fs/btrfs/volumes.h | 12 ++--- 14 files changed, 225 insertions(+), 51 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.9-rc8
The pull request you sent on Fri, 2 Oct 2020 17:30:36 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.9-rc7-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4e3b9ce271b4b54d2293a3916d22e4ddc0c89aab Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.9-rc8
Hi, two more fixes. One is for a lockdep warning/lockup (also caught by syzbot), that one has been seen in practice. Regarding the other syzbot reports mentioned last time, they don't seem to be urgent and reliably reproducible so they'll be fixed later. The second fix is for a potential corruption when device replace finishes and the in-memory state of trim is not copied to the new device. Please pull, thanks. The following changes since commit b5ddcffa37778244d5e786fe32f778edf2bfc93e: btrfs: fix put of uninitialized kobject after seed device delete (2020-09-22 15:57:52 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.9-rc7-tag for you to fetch changes up to 4c8f353272dd1262013873990c0fafd0e3c8f274: btrfs: fix filesystem corruption after a device replace (2020-09-30 19:40:51 +0200) Filipe Manana (1): btrfs: fix filesystem corruption after a device replace Josef Bacik (2): btrfs: move btrfs_scratch_superblocks into btrfs_dev_replace_finishing btrfs: move btrfs_rm_dev_replace_free_srcdev outside of all locks fs/btrfs/dev-replace.c | 46 -- fs/btrfs/volumes.c | 13 + fs/btrfs/volumes.h | 3 +++ 3 files changed, 52 insertions(+), 10 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.9-rc7
The pull request you sent on Wed, 23 Sep 2020 11:07:20 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.9-rc6-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/bffac4b5435a07bf26604385ae533adff3cccf23 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.9-rc7
Hi, syzkaller started to hit us with reports, in this pull request there's a fix for one type (stack overflow when printing checksums on read error). The other patch is a fix for sysfs object, we have a test for that and it leads to a crash. The other syzkaller reports are most likely races around device locking, we have a candidate fix that's been in the development queue. Some reports don't have a reproducer and validating the fix is not straightforward, I'll send another pull request once this is finished. Please pull, thanks. The following changes since commit 1c78544eaa4660096aeb6a57ec82b42cdb3bfe5a: btrfs: fix wrong address when faulting in pages in the search ioctl (2020-09-14 17:27:16 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.9-rc6-tag for you to fetch changes up to b5ddcffa37778244d5e786fe32f778edf2bfc93e: btrfs: fix put of uninitialized kobject after seed device delete (2020-09-22 15:57:52 +0200) Anand Jain (1): btrfs: fix put of uninitialized kobject after seed device delete Johannes Thumshirn (1): btrfs: fix overflow when copying corrupt csums for a message fs/btrfs/disk-io.c | 11 +-- fs/btrfs/sysfs.c | 16 ++-- 2 files changed, 15 insertions(+), 12 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.9-rc5
The pull request you sent on Sat, 12 Sep 2020 19:01:18 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.9-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/edf6b0e1e4ddb12e022ce0c17829bad6d4161ea7 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.9-rc5
Hi, a few more fixes: - regression fix, crash after failed snapshot creation - one more lockep fix, use nofs allocation when allocating missing device - fix reloc tree leak on degraded mount - make some extent buffer alignment checks less strict to mount filesystems created by btrfs-convert Please pull, thanks. The following changes since commit f96d6960abbc52e26ad124e69e6815283d3e1674: btrfs: tree-checker: fix the error message for transid error (2020-08-27 14:16:05 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.9-rc4-tag for you to fetch changes up to 2d892ccdc163a3d2e08c5ed1cea8b61bf7e4f531: btrfs: fix NULL pointer dereference after failure to create snapshot (2020-09-07 21:18:35 +0200) Filipe Manana (1): btrfs: fix NULL pointer dereference after failure to create snapshot Josef Bacik (2): btrfs: fix lockdep splat in add_missing_dev btrfs: free data reloc tree on failed mount Qu Wenruo (1): btrfs: require only sector size alignment for parent eb bytenr fs/btrfs/disk-io.c | 2 ++ fs/btrfs/extent-tree.c | 19 +-- fs/btrfs/print-tree.c | 12 +++- fs/btrfs/transaction.c | 1 + fs/btrfs/volumes.c | 10 ++ 5 files changed, 29 insertions(+), 15 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.9-rc4
The pull request you sent on Tue, 1 Sep 2020 01:20:49 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.9-rc3-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/dcdfd9cc28ddd356d24d5461119e4c1d19284ff5 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.9-rc4
Hi, two small fixes and a bunch of lockdep fixes for warnings that show up with an upcoming tree locking update but are valid with current locks as well. Please pull, thanks. * fix bug in free space bitmap/extent switch logic * several lockdep warning fixes * clarify tree-checker error message The following changes since commit a84d5d429f9eb56f81b388609841ed993f0ddfca: btrfs: detect nocow for swap after snapshot delete (2020-08-21 12:21:23 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.9-rc3-tag for you to fetch changes up to f96d6960abbc52e26ad124e69e6815283d3e1674: btrfs: tree-checker: fix the error message for transid error (2020-08-27 14:16:05 +0200) Josef Bacik (5): btrfs: drop path before adding new uuid tree entry btrfs: fix potential deadlock in the search ioctl btrfs: allocate scrub workqueues outside of locks btrfs: set the correct lockdep class for new nodes btrfs: set the lockdep class for log tree extent buffers Marcos Paulo de Souza (1): btrfs: block-group: fix free-space bitmap threshold Qu Wenruo (1): btrfs: tree-checker: fix the error message for transid error fs/btrfs/block-group.c | 4 +- fs/btrfs/ctree.c | 6 ++- fs/btrfs/extent-tree.c | 2 +- fs/btrfs/extent_io.c | 8 +-- fs/btrfs/extent_io.h | 6 +-- fs/btrfs/free-space-tree.c | 4 ++ fs/btrfs/ioctl.c | 27 +++--- fs/btrfs/scrub.c | 122 ++--- fs/btrfs/tree-checker.c| 2 +- fs/btrfs/volumes.c | 3 +- 10 files changed, 113 insertions(+), 71 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.9-rc3
The pull request you sent on Mon, 24 Aug 2020 18:43:43 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.9-rc2-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9907ab371426da8b3cffa6cc3e4ae54829559207 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] Btrfs fixes for 5.9-rc3
Hi, a few more fixes. Please pull, Thanks. - fix swapfile activation on subvolumes with deleted snapshots - error value mixup when removing directory entries from tree log - fix lzo compression level reset after previous level setting - fix space cache memory leak after transaction abort - fix const function attribute - more error handling improvements The following changes since commit c57dd1f2f6a7cd1bb61802344f59ccdc5278c983: btrfs: trim: fix underflow in trim length to prevent access beyond device boundary (2020-08-12 10:15:58 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.9-rc2-tag for you to fetch changes up to a84d5d429f9eb56f81b388609841ed993f0ddfca: btrfs: detect nocow for swap after snapshot delete (2020-08-21 12:21:23 +0200) Boris Burkov (1): btrfs: detect nocow for swap after snapshot delete David Sterba (1): btrfs: use the correct const function attribute for btrfs_get_num_csums Filipe Manana (1): btrfs: fix space cache memory leak after transaction abort Johannes Thumshirn (1): btrfs: handle errors from async submission Josef Bacik (1): btrfs: check the right error variable in btrfs_del_dir_entries_in_log Marcos Paulo de Souza (1): btrfs: reset compression level for lzo on remount fs/btrfs/ctree.c| 2 +- fs/btrfs/ctree.h| 6 +++--- fs/btrfs/disk-io.c | 1 + fs/btrfs/extent-tree.c | 17 +++-- fs/btrfs/file.c | 2 +- fs/btrfs/free-space-cache.c | 2 +- fs/btrfs/inode.c| 29 ++--- fs/btrfs/super.c| 1 + fs/btrfs/tree-log.c | 10 ++ 9 files changed, 39 insertions(+), 31 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.8-rc7
The pull request you sent on Fri, 24 Jul 2020 13:21:32 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.8-rc6-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0669704270e142483d80cfda5c526426c1a89711 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
[GIT PULL] Btrfs fixes for 5.8-rc7
Hi, I've selected a few resouce leak fixes from recent patches, all are stable material. The problems have been observed during testing or have a reproducer. Please pull, thanks. The following changes since commit d77765911385b65fc82d74ab71b8983cddfe0b58: btrfs: wire up iter_file_splice_write (2020-07-09 19:57:58 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.8-rc6-tag for you to fetch changes up to 48cfa61b58a1fee0bc49eef04f8ccf31493b7cdd: btrfs: fix mount failure caused by race with umount (2020-07-21 22:08:54 +0200) Boris Burkov (1): btrfs: fix mount failure caused by race with umount Filipe Manana (1): btrfs: fix double free on ulist after backref resolution failure Qu Wenruo (1): btrfs: qgroup: fix data leak caused by race between writeback and truncate Robbie Ko (1): btrfs: fix page leaks after failure to lock page for delalloc fs/btrfs/backref.c | 1 + fs/btrfs/extent_io.c | 3 ++- fs/btrfs/inode.c | 23 ++- fs/btrfs/volumes.c | 8 4 files changed, 21 insertions(+), 14 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.8-rc5, part 2
The pull request you sent on Sun, 12 Jul 2020 12:14:58 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.8-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/72c34e8d7099c329c2934c2ac9c886f638b6edaf Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
[GIT PULL] Btrfs fixes for 5.8-rc5, part 2
Hi, please pull two refcounting fixes and one prepartory patch for upcoming splice cleanup. Thanks. - fix double put of block group with nodatacow - fix missing block group put when remounting with discard=async - explicitly set splice callback (no functional change), to ease integrating splice cleanup patches The following changes since commit 0465337c5599bbe360cdcff452992a1a6b7ed2d4: btrfs: reset tree root pointer after error in init_tree_roots (2020-07-02 10:27:12 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.8-rc4-tag for you to fetch changes up to d77765911385b65fc82d74ab71b8983cddfe0b58: btrfs: wire up iter_file_splice_write (2020-07-09 19:57:58 +0200) Christoph Hellwig (1): btrfs: wire up iter_file_splice_write Josef Bacik (1): btrfs: fix double put of block group with nocow Qu Wenruo (1): btrfs: discard: add missing put when grabbing block group from unused list fs/btrfs/discard.c | 1 + fs/btrfs/file.c| 1 + fs/btrfs/inode.c | 9 + 3 files changed, 3 insertions(+), 8 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.8-rc5
The pull request you sent on Tue, 7 Jul 2020 15:27:12 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.8-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/aa27b32b76d0b1b242d43977da0e5358da1c825f Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
[GIT PULL] Btrfs fixes for 5.8-rc5
Hi, please pull the following fixes, thanks. - regression fix of a leak in global block reserve accounting - fix a (hard to hit) race of readahead vs releasepage that could lead to crash - convert all remaining uses of comment fall through annotations to the pseudo keyword - fix crash when mounting a fuzzed image with -o recovery The following changes since commit b091f7fede97cc64f7aaad3eeb37965aebee3082: btrfs: use kfree() in btrfs_ioctl_get_subvol_info() (2020-06-16 19:24:03 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.8-rc4-tag for you to fetch changes up to 0465337c5599bbe360cdcff452992a1a6b7ed2d4: btrfs: reset tree root pointer after error in init_tree_roots (2020-07-02 10:27:12 +0200) Boris Burkov (1): btrfs: fix fatal extent_buffer readahead vs releasepage race Filipe Manana (1): btrfs: fix reclaim_size counter leak after stealing from global reserve Josef Bacik (1): btrfs: reset tree root pointer after error in init_tree_roots Marcos Paulo de Souza (1): btrfs: convert comments to fallthrough annotations fs/btrfs/ctree.c | 2 +- fs/btrfs/disk-io.c| 6 -- fs/btrfs/extent_io.c | 40 fs/btrfs/ref-verify.c | 2 +- fs/btrfs/space-info.c | 2 +- fs/btrfs/super.c | 6 +++--- fs/btrfs/volumes.h| 2 +- 7 files changed, 35 insertions(+), 25 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.8-rc3
The pull request you sent on Tue, 23 Jun 2020 15:53:45 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.8-rc2-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/3e08a95294a4fb3702bb3d35ed08028433c37fe6 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
[GIT PULL] Btrfs fixes for 5.8-rc3
Hi, a number of fixes, located in two areas, one performance fix and one fixup for better integration with another patchset. Please pull, thanks. - bug fixes in nowait aio: - fix snapshot creation hang after nowait-aio was used - fix failure to write to prealloc extent past EOF - don't block when extent range is locked - block group fixes: - relocation failure when scrub runs in parallel - refcount fix when removing fails - fix race between removal and creation - space accounting fixes - reinstante fast path check for log tree at unlink time, fixes performance drop up to 30% in REAIM - kzfree/kfree fixup to ease treewide patchset renaming kzfree The following changes since commit 55e20bd12a56e06c38b953177bb162cbbaa96004: Revert "btrfs: switch to iomap_dio_rw() for dio" (2020-06-14 01:19:02 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.8-rc2-tag for you to fetch changes up to b091f7fede97cc64f7aaad3eeb37965aebee3082: btrfs: use kfree() in btrfs_ioctl_get_subvol_info() (2020-06-16 19:24:03 +0200) Filipe Manana (9): btrfs: fix a block group ref counter leak after failure to remove block group btrfs: fix race between block group removal and block group creation btrfs: fix data block group relocation failure due to concurrent scrub btrfs: fix bytes_may_use underflow when running balance and scrub in parallel btrfs: check if a log root exists before locking the log_mutex on unlink btrfs: fix hang on snapshot creation after RWF_NOWAIT write btrfs: fix failure of RWF_NOWAIT write into prealloc extent beyond eof btrfs: fix RWF_NOWAIT write not failling when we need to cow btrfs: fix RWF_NOWAIT writes blocking on extent locks and waiting for IO Waiman Long (1): btrfs: use kfree() in btrfs_ioctl_get_subvol_info() fs/btrfs/block-group.c | 44 +++- fs/btrfs/ctree.h | 2 ++ fs/btrfs/file.c| 46 +- fs/btrfs/inode.c | 39 ++- fs/btrfs/ioctl.c | 2 +- fs/btrfs/tree-log.c| 5 + 6 files changed, 102 insertions(+), 36 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.7-rc4, part 2
The pull request you sent on Sun, 3 May 2020 18:25:37 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.7-rc3-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/262f7a6b8317a06e7d51befb690f0bca06a473ea Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
[GIT PULL] Btrfs fixes for 5.7-rc4, part 2
Hi, please pull a few more stability fixes, minor build warning fixes and git url fixup. Thanks. - fix partial loss of prealloc extent past i_size after fsync - fix potential deadlock due to wrong transaction handle passing via journal_info - fix gcc 4.8 struct intialization warning - update git URL in MAINTAINERS entry The following changes since commit 1402d17dfd9657be0da8458b2079d03c2d61c86a: btrfs: fix transaction leak in btrfs_recover_relocation (2020-04-23 17:24:56 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.7-rc3-tag for you to fetch changes up to eb91db63a90d8f8e8768b82fcb2cae5f7198cf6b: MAINTAINERS: btrfs: fix git repo URL (2020-05-03 18:13:18 +0200) Arnd Bergmann (1): btrfs: fix gcc-4.8 build warning for struct initializer Eric Biggers (1): MAINTAINERS: btrfs: fix git repo URL Filipe Manana (1): btrfs: fix partial loss of prealloc extent past i_size after fsync Qu Wenruo (1): btrfs: transaction: Avoid deadlock due to bad initialization timing of fs_info::journal_info MAINTAINERS| 2 +- fs/btrfs/backref.c | 2 +- fs/btrfs/transaction.c | 13 +++-- fs/btrfs/tree-log.c| 43 --- 4 files changed, 53 insertions(+), 7 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.4-rc2
The pull request you sent on Mon, 30 Sep 2019 16:25:08 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.4-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/bb48a59135926ece9b1361e8b96b33fc658830bc Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
Re: [GIT PULL] Btrfs fixes for 5.3-rc5
The pull request you sent on Sun, 18 Aug 2019 13:58:46 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.3-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/3039fadf2bfdc104dc963820c305778c7c1a6229 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
Re: [GIT PULL] Btrfs fixes for 5.3-rc2
The pull request you sent on Fri, 26 Jul 2019 18:42:24 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.3-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4792ba1f1ff0db30369f7016c1611fda3f84b895 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
Re: [GIT PULL] Btrfs fixes for 5.2-rc6
The pull request you sent on Tue, 18 Jun 2019 18:52:07 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.2-rc5-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/bed3c0d84e7e25c8e0964d297794f4c215b01f33 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
Re: [GIT PULL] Btrfs fixes for 5.0-rc5
The pull request you sent on Sun, 3 Feb 2019 10:48:46 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.0-rc4-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/312b3a93dda6db9354b0c6b0f1868c1434e8c787 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
[GIT PULL] Btrfs fixes for 5.0-rc5
Hi, there are a few fixes that I'd like to have in the 5.0 release. Last rc was skipped because one fix had to be reworked and more testing was needed. Please pull, thanks. - regression fix: transaction commit can run away due to delayed ref waiting heuristic, this is not necessary now because of the proper reservation mechanism introduced in 5.0 - regression fix: potential crash due to use-before-check of an ERR_PTR return value - fix for transaction abort during transaction commit that needs to properly clean up pending block groups - fix deadlock during b-tree node/leaf splitting, when this happens on some of the fundamental trees, we must prevent new tree block allocation to re-enter indirectly via the block group flushing path - potential memory leak after errors during mount The following changes since commit fd340d0f68cc87badfc9efcb226f23a5428826a0: btrfs: wakeup cleaner thread when adding delayed iput (2019-01-18 17:27:23 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.0-rc4-tag for you to fetch changes up to 532b618bdf237250d6d4566536d4b6ce3d0a31fe: btrfs: On error always free subvol_name in btrfs_mount (2019-01-30 18:16:47 +0100) Al Viro (1): btrfs: fix potential oops in device_list_add David Sterba (1): btrfs: clean up pending block groups when transaction commit aborts Eric W. Biederman (1): btrfs: On error always free subvol_name in btrfs_mount Filipe Manana (1): Btrfs: fix deadlock when allocating tree block during leaf/node split Josef Bacik (1): btrfs: don't end the transaction for delayed refs in throttle fs/btrfs/ctree.c | 78 -- fs/btrfs/super.c | 3 ++ fs/btrfs/transaction.c | 24 ++-- fs/btrfs/volumes.c | 4 +-- 4 files changed, 71 insertions(+), 38 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.0-rc3
The pull request you sent on Sun, 20 Jan 2019 16:51:29 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.0-rc2-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1be969f4682b0aa1995e46fba51502de55f15ce8 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
[GIT PULL] Btrfs fixes for 5.0-rc3
Hi, please pull the following branch to obtain a handful of fixes (some of them in testing for a long time, were briefly mentioned in the 1st pull): - fix some test failures regarding cleanup after transaction abort - revert of a patch that could cause a deadlock - delayed iput fixes, that can help in ENOSPC situation when there's low space and lot data to write Thanks. The following changes since commit 1b3922a8bc74231f9a767d1be6d9a061a4d4eeab: btrfs: Use real device structure to verify dev extent (2019-01-10 17:13:00 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.0-rc2-tag for you to fetch changes up to fd340d0f68cc87badfc9efcb226f23a5428826a0: btrfs: wakeup cleaner thread when adding delayed iput (2019-01-18 17:27:23 +0100) David Sterba (1): Revert "btrfs: balance dirty metadata pages in btrfs_finish_ordered_io" Josef Bacik (4): btrfs: handle delayed ref head accounting cleanup in abort btrfs: wait on ordered extents on abort cleanup btrfs: run delayed iputs before committing btrfs: wakeup cleaner thread when adding delayed iput fs/btrfs/ctree.h | 7 +++ fs/btrfs/disk-io.c | 12 fs/btrfs/extent-tree.c | 21 ++--- fs/btrfs/inode.c | 5 ++--- 4 files changed, 35 insertions(+), 10 deletions(-)
Re: [GIT PULL] Btrfs fixes for 5.0-rc2
The pull request you sent on Sun, 13 Jan 2019 17:39:38 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.0-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6b529fb0a3eabf9c4cc3e94c11477250379ce6d8 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
[GIT PULL] Btrfs fixes for 5.0-rc2
Hi, please pull the following branch to get: - 2 regression fixes in clone/dedupe ioctls, the generic check callback needs to lock extents properly and wait for io to avoid problems with writeback and relocation - fix deadlock when using free space tree due to block group creation - a recently added check refuses a valid fileystem with seeding device, make that work again with a quickfix, proper solution needs more intrusive changes Thanks. The following changes since commit 52042d8e82ff50d40e76a275ac0b97aa663328b0: btrfs: Fix typos in comments and strings (2018-12-17 14:51:50 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.0-rc1-tag for you to fetch changes up to 1b3922a8bc74231f9a767d1be6d9a061a4d4eeab: btrfs: Use real device structure to verify dev extent (2019-01-10 17:13:00 +0100) Filipe Manana (3): Btrfs: fix race between cloning range ending at eof and writeback Btrfs: fix race between reflink/dedupe and relocation Btrfs: fix deadlock when using free space tree due to block group creation Qu Wenruo (1): btrfs: Use real device structure to verify dev extent fs/btrfs/ctree.c | 16 +--- fs/btrfs/ioctl.c | 49 +++-- fs/btrfs/volumes.c | 12 3 files changed, 64 insertions(+), 13 deletions(-)
[GIT PULL] Btrfs fixes for 4.18-rc2
Hi, we have a few regression fixes for qgroup rescan status tracking and the vm_fault_t conversion that mixed up the error values. Please pull, thanks. The following changes since commit c5b4a50b74018b3677098151ec5f4fce07d5e6a0: Btrfs: fix return value on rename exchange failure (2018-06-22 12:59:08 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.18-rc2-tag for you to fetch changes up to e4e7ede739f7fb468686dfffa2d1e35dca35bacd: Btrfs: fix mount failure when qgroup rescan is in progress (2018-06-28 11:30:57 +0200) Chris Mason (1): Btrfs: fix regression in btrfs_page_mkwrite() from vm_fault_t conversion Filipe Manana (1): Btrfs: fix mount failure when qgroup rescan is in progress Qu Wenruo (1): btrfs: quota: Set rescan progress to (u64)-1 if we hit last leaf fs/btrfs/inode.c | 3 ++- fs/btrfs/qgroup.c | 17 + 2 files changed, 15 insertions(+), 5 deletions(-)
[GIT PULL] Btrfs fixes for 4.18-rc2
Hi, we have a few regression fixes for qgroup rescan status tracking and the vm_fault_t conversion that mixed up the error values. Please pull, thanks. The following changes since commit c5b4a50b74018b3677098151ec5f4fce07d5e6a0: Btrfs: fix return value on rename exchange failure (2018-06-22 12:59:08 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.18-rc2-tag for you to fetch changes up to e4e7ede739f7fb468686dfffa2d1e35dca35bacd: Btrfs: fix mount failure when qgroup rescan is in progress (2018-06-28 11:30:57 +0200) Chris Mason (1): Btrfs: fix regression in btrfs_page_mkwrite() from vm_fault_t conversion Filipe Manana (1): Btrfs: fix mount failure when qgroup rescan is in progress Qu Wenruo (1): btrfs: quota: Set rescan progress to (u64)-1 if we hit last leaf fs/btrfs/inode.c | 3 ++- fs/btrfs/qgroup.c | 17 + 2 files changed, 15 insertions(+), 5 deletions(-)
Re: [GIT PULL] Btrfs fixes for 4.17-rc6
On Sun, May 20, 2018 at 8:21 AM David Sterbawrote: > They IMHO qualify for a late rc, though I did not expect that many. Especially with the tree-log.c changes being fairly big, I took a look, and I have to say that I appreciate (a) the warning in the pull request and (b) the extensive log messages explaining the problems these patches fix. I obviously still prefer to see only small and simple one-liners just before I'm making ready to release rc6, but in the absence of oneliners I do appreciate good explanations. Thanks, Linus
Re: [GIT PULL] Btrfs fixes for 4.17-rc6
On Sun, May 20, 2018 at 8:21 AM David Sterba wrote: > They IMHO qualify for a late rc, though I did not expect that many. Especially with the tree-log.c changes being fairly big, I took a look, and I have to say that I appreciate (a) the warning in the pull request and (b) the extensive log messages explaining the problems these patches fix. I obviously still prefer to see only small and simple one-liners just before I'm making ready to release rc6, but in the absence of oneliners I do appreciate good explanations. Thanks, Linus
[GIT PULL] Btrfs fixes for 4.17-rc6
Hi, we've accumulated some fixes during the last week, some of them were in the works for a longer time but there are some newer ones too. Most of the fixes have a reproducer and fix user visible problems, also candidates for stable kernels. They IMHO qualify for a late rc, though I did not expect that many. The commit date may differ from author date because I added the stable and Fixes tags where missing. There are no merge conflicts against current master. Please pull, thanks. The following changes since commit a6aa10c70bf72fb28504cb5de5deac75da78b0f5: Btrfs: send, fix missing truncate for inode with prealloc extent past eof (2018-05-02 11:55:29 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.17-rc5-tag for you to fetch changes up to 02ee654d3a04563c67bfe658a05384548b9bb105: btrfs: fix crash when trying to resume balance without the resume flag (2018-05-17 14:38:24 +0200) Anand Jain (1): btrfs: fix crash when trying to resume balance without the resume flag Filipe Manana (2): Btrfs: fix xattr loss after power failure Btrfs: fix duplicate extents after fsync of file with prealloc extents Liu Bo (1): btrfs: fix reading stale metadata blocks after degraded raid1 mounts Misono Tomohiro (1): btrfs: property: Set incompat flag if lzo/zstd compression is set Nikolay Borisov (2): btrfs: Split btrfs_del_delalloc_inode into 2 functions btrfs: Fix delalloc inodes invalidation during transaction abort Robbie Ko (1): Btrfs: send, fix invalid access to commit roots due to concurrent snapshotting fs/btrfs/ctree.c| 22 ++-- fs/btrfs/ctree.h| 2 + fs/btrfs/disk-io.c | 26 ++ fs/btrfs/inode.c| 13 +++-- fs/btrfs/props.c| 12 +++-- fs/btrfs/tree-log.c | 144 +++- fs/btrfs/volumes.c | 9 7 files changed, 180 insertions(+), 48 deletions(-)
[GIT PULL] Btrfs fixes for 4.17-rc6
Hi, we've accumulated some fixes during the last week, some of them were in the works for a longer time but there are some newer ones too. Most of the fixes have a reproducer and fix user visible problems, also candidates for stable kernels. They IMHO qualify for a late rc, though I did not expect that many. The commit date may differ from author date because I added the stable and Fixes tags where missing. There are no merge conflicts against current master. Please pull, thanks. The following changes since commit a6aa10c70bf72fb28504cb5de5deac75da78b0f5: Btrfs: send, fix missing truncate for inode with prealloc extent past eof (2018-05-02 11:55:29 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.17-rc5-tag for you to fetch changes up to 02ee654d3a04563c67bfe658a05384548b9bb105: btrfs: fix crash when trying to resume balance without the resume flag (2018-05-17 14:38:24 +0200) Anand Jain (1): btrfs: fix crash when trying to resume balance without the resume flag Filipe Manana (2): Btrfs: fix xattr loss after power failure Btrfs: fix duplicate extents after fsync of file with prealloc extents Liu Bo (1): btrfs: fix reading stale metadata blocks after degraded raid1 mounts Misono Tomohiro (1): btrfs: property: Set incompat flag if lzo/zstd compression is set Nikolay Borisov (2): btrfs: Split btrfs_del_delalloc_inode into 2 functions btrfs: Fix delalloc inodes invalidation during transaction abort Robbie Ko (1): Btrfs: send, fix invalid access to commit roots due to concurrent snapshotting fs/btrfs/ctree.c| 22 ++-- fs/btrfs/ctree.h| 2 + fs/btrfs/disk-io.c | 26 ++ fs/btrfs/inode.c| 13 +++-- fs/btrfs/props.c| 12 +++-- fs/btrfs/tree-log.c | 144 +++- fs/btrfs/volumes.c | 9 7 files changed, 180 insertions(+), 48 deletions(-)
[GIT PULL] Btrfs fixes for 4.17-rc1
Hi, the branch contains a few fixups to qgroup patches that were merged this dev cycle, unaligned access fix, blockgroup removal corner case fix and a small debugging output tweak. Please pull, thanks. The following changes since commit 5d41be6f702f19f72db816c17175caf9dbdcdfa6: btrfs: Only check first key for committed tree blocks (2018-04-13 16:16:15 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.17-rc1-tag for you to fetch changes up to c0872323746e11fc79344e3738b283a8cda86654: btrfs: print-tree: debugging output enhancement (2018-04-20 19:18:16 +0200) David Sterba (1): btrfs: fix unaligned access in readdir Nikolay Borisov (1): btrfs: Fix race condition between delayed refs and blockgroup removal Qu Wenruo (5): btrfs: qgroup: Commit transaction in advance to reduce early EDQUOT btrfs: qgroup: Use independent and accurate per inode qgroup rsv btrfs: delayed-inode: Remove wrong qgroup meta reservation calls btrfs: Fix wrong btrfs_delalloc_release_extents parameter btrfs: print-tree: debugging output enhancement fs/btrfs/ctree.h | 25 + fs/btrfs/delayed-inode.c | 20 ++--- fs/btrfs/delayed-ref.c | 19 + fs/btrfs/delayed-ref.h | 1 + fs/btrfs/disk-io.c | 1 + fs/btrfs/extent-tree.c | 73 +--- fs/btrfs/file.c | 2 +- fs/btrfs/inode.c | 20 +++-- fs/btrfs/print-tree.c| 25 ++--- fs/btrfs/print-tree.h| 2 +- fs/btrfs/qgroup.c| 43 ++-- fs/btrfs/transaction.c | 1 + fs/btrfs/transaction.h | 14 ++ 13 files changed, 199 insertions(+), 47 deletions(-)
[GIT PULL] Btrfs fixes for 4.17-rc1
Hi, the branch contains a few fixups to qgroup patches that were merged this dev cycle, unaligned access fix, blockgroup removal corner case fix and a small debugging output tweak. Please pull, thanks. The following changes since commit 5d41be6f702f19f72db816c17175caf9dbdcdfa6: btrfs: Only check first key for committed tree blocks (2018-04-13 16:16:15 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.17-rc1-tag for you to fetch changes up to c0872323746e11fc79344e3738b283a8cda86654: btrfs: print-tree: debugging output enhancement (2018-04-20 19:18:16 +0200) David Sterba (1): btrfs: fix unaligned access in readdir Nikolay Borisov (1): btrfs: Fix race condition between delayed refs and blockgroup removal Qu Wenruo (5): btrfs: qgroup: Commit transaction in advance to reduce early EDQUOT btrfs: qgroup: Use independent and accurate per inode qgroup rsv btrfs: delayed-inode: Remove wrong qgroup meta reservation calls btrfs: Fix wrong btrfs_delalloc_release_extents parameter btrfs: print-tree: debugging output enhancement fs/btrfs/ctree.h | 25 + fs/btrfs/delayed-inode.c | 20 ++--- fs/btrfs/delayed-ref.c | 19 + fs/btrfs/delayed-ref.h | 1 + fs/btrfs/disk-io.c | 1 + fs/btrfs/extent-tree.c | 73 +--- fs/btrfs/file.c | 2 +- fs/btrfs/inode.c | 20 +++-- fs/btrfs/print-tree.c| 25 ++--- fs/btrfs/print-tree.h| 2 +- fs/btrfs/qgroup.c| 43 ++-- fs/btrfs/transaction.c | 1 + fs/btrfs/transaction.h | 14 ++ 13 files changed, 199 insertions(+), 47 deletions(-)
[GIT PULL] Btrfs fixes for 4.16-rc6
Hi, there's an important revert in this pull request that needs to go to stable as it causes a corruption on big endian machines. The other fix is for FIEMAP incorrectly reporting shared extents before a sync and one fix for a crash in raid56. So far we got only one report about the BE corruption, the stable kernels were out for like a week, so hopefully the scope of the damage is low. Please pull, thanks. The following changes since commit 1f250e929a9c9332fd6ea34da684afee73837cfe: Btrfs: fix log replay failure after unlink and link combination (2018-03-01 16:18:40 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.16-rc5-tag for you to fetch changes up to 093e037ca88e1767693bc6bcb2df3f49c6be68c7: Revert "btrfs: use proper endianness accessors for super_copy" (2018-03-16 14:49:44 +0100) David Sterba (1): Revert "btrfs: use proper endianness accessors for super_copy" Dmitriy Gorokh (1): btrfs: Fix NULL pointer exception in find_bio_stripe Edmund Nadolski (1): btrfs: add missing initialization in btrfs_check_shared fs/btrfs/backref.c | 1 + fs/btrfs/raid56.c | 1 + fs/btrfs/sysfs.c | 8 +--- fs/btrfs/transaction.c | 20 4 files changed, 15 insertions(+), 15 deletions(-)
[GIT PULL] Btrfs fixes for 4.16-rc6
Hi, there's an important revert in this pull request that needs to go to stable as it causes a corruption on big endian machines. The other fix is for FIEMAP incorrectly reporting shared extents before a sync and one fix for a crash in raid56. So far we got only one report about the BE corruption, the stable kernels were out for like a week, so hopefully the scope of the damage is low. Please pull, thanks. The following changes since commit 1f250e929a9c9332fd6ea34da684afee73837cfe: Btrfs: fix log replay failure after unlink and link combination (2018-03-01 16:18:40 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.16-rc5-tag for you to fetch changes up to 093e037ca88e1767693bc6bcb2df3f49c6be68c7: Revert "btrfs: use proper endianness accessors for super_copy" (2018-03-16 14:49:44 +0100) David Sterba (1): Revert "btrfs: use proper endianness accessors for super_copy" Dmitriy Gorokh (1): btrfs: Fix NULL pointer exception in find_bio_stripe Edmund Nadolski (1): btrfs: add missing initialization in btrfs_check_shared fs/btrfs/backref.c | 1 + fs/btrfs/raid56.c | 1 + fs/btrfs/sysfs.c | 8 +--- fs/btrfs/transaction.c | 20 4 files changed, 15 insertions(+), 15 deletions(-)
[GIT PULL] Btrfs fixes for 4.16-rc4
Hi, please consider the follwing btrfs updates, there are bugfixes or fixes for user visible behaviour. No merge conflicts. Please pull, thanks. - when NR_CPUS is large, a SRCU structure can significantly inflate size of the main filesystem structure that would not be possible to allocate by kmalloc, so the kvalloc fallback is used - improved error handling - fix endiannes when printing some filesystem attributes via sysfs, this is could happen when a filesystem is moved between different endianity hosts - send fixes: the NO_HOLE mode should not send a write operation for a file hole - fix log replay for for special files followed by file hardlinks - fix log replay failure after unlink and link combination - fix max chunk size calculation for DUP allocation The following changes since commit fd649f10c3d21ee9d7542c609f29978bdf73ab94: btrfs: Fix use-after-free when cleaning up fs_devs with a single stale device (2018-02-05 17:15:14 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.16-rc3-tag for you to fetch changes up to 1f250e929a9c9332fd6ea34da684afee73837cfe: Btrfs: fix log replay failure after unlink and link combination (2018-03-01 16:18:40 +0100) Anand Jain (1): btrfs: use proper endianness accessors for super_copy Filipe Manana (3): Btrfs: send, fix issuing write op when processing hole in no data mode Btrfs: fix log replay failure after linking special file and fsync Btrfs: fix log replay failure after unlink and link combination Hans van Kranenburg (1): btrfs: alloc_chunk: fix DUP stripe size handling Jeff Mahoney (1): btrfs: use kvzalloc to allocate btrfs_fs_info Nikolay Borisov (2): btrfs: handle failure of add_pending_csums btrfs: Handle btrfs_set_extent_delalloc failure in relocate_file_extent_cluster fs/btrfs/ctree.h | 7 ++- fs/btrfs/inode-item.c | 44 +++ fs/btrfs/inode.c | 11 - fs/btrfs/relocation.c | 18 +++- fs/btrfs/send.c| 3 ++ fs/btrfs/super.c | 2 +- fs/btrfs/sysfs.c | 8 ++-- fs/btrfs/transaction.c | 20 + fs/btrfs/tree-log.c| 114 +++-- fs/btrfs/volumes.c | 11 ++--- 10 files changed, 191 insertions(+), 47 deletions(-)
[GIT PULL] Btrfs fixes for 4.16-rc4
Hi, please consider the follwing btrfs updates, there are bugfixes or fixes for user visible behaviour. No merge conflicts. Please pull, thanks. - when NR_CPUS is large, a SRCU structure can significantly inflate size of the main filesystem structure that would not be possible to allocate by kmalloc, so the kvalloc fallback is used - improved error handling - fix endiannes when printing some filesystem attributes via sysfs, this is could happen when a filesystem is moved between different endianity hosts - send fixes: the NO_HOLE mode should not send a write operation for a file hole - fix log replay for for special files followed by file hardlinks - fix log replay failure after unlink and link combination - fix max chunk size calculation for DUP allocation The following changes since commit fd649f10c3d21ee9d7542c609f29978bdf73ab94: btrfs: Fix use-after-free when cleaning up fs_devs with a single stale device (2018-02-05 17:15:14 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.16-rc3-tag for you to fetch changes up to 1f250e929a9c9332fd6ea34da684afee73837cfe: Btrfs: fix log replay failure after unlink and link combination (2018-03-01 16:18:40 +0100) Anand Jain (1): btrfs: use proper endianness accessors for super_copy Filipe Manana (3): Btrfs: send, fix issuing write op when processing hole in no data mode Btrfs: fix log replay failure after linking special file and fsync Btrfs: fix log replay failure after unlink and link combination Hans van Kranenburg (1): btrfs: alloc_chunk: fix DUP stripe size handling Jeff Mahoney (1): btrfs: use kvzalloc to allocate btrfs_fs_info Nikolay Borisov (2): btrfs: handle failure of add_pending_csums btrfs: Handle btrfs_set_extent_delalloc failure in relocate_file_extent_cluster fs/btrfs/ctree.h | 7 ++- fs/btrfs/inode-item.c | 44 +++ fs/btrfs/inode.c | 11 - fs/btrfs/relocation.c | 18 +++- fs/btrfs/send.c| 3 ++ fs/btrfs/super.c | 2 +- fs/btrfs/sysfs.c | 8 ++-- fs/btrfs/transaction.c | 20 + fs/btrfs/tree-log.c| 114 +++-- fs/btrfs/volumes.c | 11 ++--- 10 files changed, 191 insertions(+), 47 deletions(-)
[GIT PULL] Btrfs fixes for 4.16-rc1
Hi, we have a few assorted fixes, some of them show up during fstests so I gave them more testing. Please pull, thanks. The following changes since commit 3acbcbfc8f06d4ade2aab2ebba0a2542a05ce90c: btrfs: drop devid as device_list_add() arg (2018-01-29 19:31:16 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.16-rc1-tag for you to fetch changes up to fd649f10c3d21ee9d7542c609f29978bdf73ab94: btrfs: Fix use-after-free when cleaning up fs_devs with a single stale device (2018-02-05 17:15:14 +0100) Filipe Manana (1): Btrfs: fix null pointer dereference when replacing missing device Liu Bo (6): Btrfs: fix deadlock in run_delalloc_nocow Btrfs: fix crash due to not cleaning up tree log block's dirty bits Btrfs: fix extent state leak from tree log Btrfs: fix btrfs_evict_inode to handle abnormal inodes correctly Btrfs: fix use-after-free on root->orphan_block_rsv Btrfs: fix unexpected -EEXIST when creating new inode Nikolay Borisov (2): btrfs: Ignore errors from btrfs_qgroup_trace_extent_post btrfs: Fix use-after-free when cleaning up fs_devs with a single stale device Zygo Blaxell (1): btrfs: remove spurious WARN_ON(ref->count < 0) in find_parent_nodes fs/btrfs/backref.c | 11 ++- fs/btrfs/delayed-ref.c | 3 ++- fs/btrfs/extent-tree.c | 4 fs/btrfs/inode.c | 41 ++--- fs/btrfs/qgroup.c | 9 +++-- fs/btrfs/tree-log.c| 32 ++-- fs/btrfs/volumes.c | 1 + 7 files changed, 80 insertions(+), 21 deletions(-)
[GIT PULL] Btrfs fixes for 4.16-rc1
Hi, we have a few assorted fixes, some of them show up during fstests so I gave them more testing. Please pull, thanks. The following changes since commit 3acbcbfc8f06d4ade2aab2ebba0a2542a05ce90c: btrfs: drop devid as device_list_add() arg (2018-01-29 19:31:16 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.16-rc1-tag for you to fetch changes up to fd649f10c3d21ee9d7542c609f29978bdf73ab94: btrfs: Fix use-after-free when cleaning up fs_devs with a single stale device (2018-02-05 17:15:14 +0100) Filipe Manana (1): Btrfs: fix null pointer dereference when replacing missing device Liu Bo (6): Btrfs: fix deadlock in run_delalloc_nocow Btrfs: fix crash due to not cleaning up tree log block's dirty bits Btrfs: fix extent state leak from tree log Btrfs: fix btrfs_evict_inode to handle abnormal inodes correctly Btrfs: fix use-after-free on root->orphan_block_rsv Btrfs: fix unexpected -EEXIST when creating new inode Nikolay Borisov (2): btrfs: Ignore errors from btrfs_qgroup_trace_extent_post btrfs: Fix use-after-free when cleaning up fs_devs with a single stale device Zygo Blaxell (1): btrfs: remove spurious WARN_ON(ref->count < 0) in find_parent_nodes fs/btrfs/backref.c | 11 ++- fs/btrfs/delayed-ref.c | 3 ++- fs/btrfs/extent-tree.c | 4 fs/btrfs/inode.c | 41 ++--- fs/btrfs/qgroup.c | 9 +++-- fs/btrfs/tree-log.c| 32 ++-- fs/btrfs/volumes.c | 1 + 7 files changed, 80 insertions(+), 21 deletions(-)
[GIT PULL] Btrfs fixes for 4.15-rc7
Hi, we have two more fixes for 4.15, aimed for stable. The leak fix is obvious, the second patch fixes a bug revealed by the refcount API, when it behaves differently than previous atomic_t and reports refs going from 0 to 1 in one case. No merge conflicts. Please pull, thanks. The following changes since commit c8bcbfbd239ed60a6562964b58034ac8a25f4c31: btrfs: Fix possible off-by-one in btrfs_search_path_in_tree (2017-12-07 00:35:15 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc7-tag for you to fetch changes up to ec35e48b286959991cdbb886f1bdeda4575c80b4: btrfs: fix refcount_t usage when deleting btrfs_delayed_nodes (2018-01-02 18:00:14 +0100) Chris Mason (1): btrfs: fix refcount_t usage when deleting btrfs_delayed_nodes Nikolay Borisov (1): btrfs: Fix flush bio leak fs/btrfs/delayed-inode.c | 45 ++--- fs/btrfs/volumes.c | 1 - 2 files changed, 34 insertions(+), 12 deletions(-)
[GIT PULL] Btrfs fixes for 4.15-rc7
Hi, we have two more fixes for 4.15, aimed for stable. The leak fix is obvious, the second patch fixes a bug revealed by the refcount API, when it behaves differently than previous atomic_t and reports refs going from 0 to 1 in one case. No merge conflicts. Please pull, thanks. The following changes since commit c8bcbfbd239ed60a6562964b58034ac8a25f4c31: btrfs: Fix possible off-by-one in btrfs_search_path_in_tree (2017-12-07 00:35:15 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc7-tag for you to fetch changes up to ec35e48b286959991cdbb886f1bdeda4575c80b4: btrfs: fix refcount_t usage when deleting btrfs_delayed_nodes (2018-01-02 18:00:14 +0100) Chris Mason (1): btrfs: fix refcount_t usage when deleting btrfs_delayed_nodes Nikolay Borisov (1): btrfs: Fix flush bio leak fs/btrfs/delayed-inode.c | 45 ++--- fs/btrfs/volumes.c | 1 - 2 files changed, 34 insertions(+), 12 deletions(-)
[GIT PULL] Btrfs fixes for 4.15-rc3
Hi, this update contains a few fixes (error handling, quota leak, FUA vs nobarrier mount option). There's one one worth mentioning separately - an off-by-one fix that leads to overwriting first byte of an adjacent page with 0, out of bounds of the memory allocated by an ioctl. This is under a privileged part of the ioctl, can be triggerd in some subvolume layouts. After the last tags and branches mess [1], let me note that the pull url is pointed to the signed tag. There are no merge conflics. Please pull, thanks. [1] https://lkml.org/lkml/2017/11/29/952 The following changes since commit ea37d5998b50a72b9045ba60a132eeb20e1c4230: Btrfs: incremental send, fix wrong unlink path after renaming file (2017-11-28 17:15:30 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc3-tag for you to fetch changes up to c8bcbfbd239ed60a6562964b58034ac8a25f4c31: btrfs: Fix possible off-by-one in btrfs_search_path_in_tree (2017-12-07 00:35:15 +0100) Jeff Mahoney (2): btrfs: handle errors while updating refcounts in update_ref_for_cow btrfs: fix missing error return in btrfs_drop_snapshot Justin Maggard (1): btrfs: Fix quota reservation leak on preallocated files Nikolay Borisov (1): btrfs: Fix possible off-by-one in btrfs_search_path_in_tree Omar Sandoval (1): Btrfs: disable FUA if mounted with nobarrier fs/btrfs/ctree.c | 18 -- fs/btrfs/disk-io.c | 12 +--- fs/btrfs/extent-tree.c | 1 + fs/btrfs/inode.c | 2 ++ fs/btrfs/ioctl.c | 2 +- 5 files changed, 21 insertions(+), 14 deletions(-)
[GIT PULL] Btrfs fixes for 4.15-rc3
Hi, this update contains a few fixes (error handling, quota leak, FUA vs nobarrier mount option). There's one one worth mentioning separately - an off-by-one fix that leads to overwriting first byte of an adjacent page with 0, out of bounds of the memory allocated by an ioctl. This is under a privileged part of the ioctl, can be triggerd in some subvolume layouts. After the last tags and branches mess [1], let me note that the pull url is pointed to the signed tag. There are no merge conflics. Please pull, thanks. [1] https://lkml.org/lkml/2017/11/29/952 The following changes since commit ea37d5998b50a72b9045ba60a132eeb20e1c4230: Btrfs: incremental send, fix wrong unlink path after renaming file (2017-11-28 17:15:30 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc3-tag for you to fetch changes up to c8bcbfbd239ed60a6562964b58034ac8a25f4c31: btrfs: Fix possible off-by-one in btrfs_search_path_in_tree (2017-12-07 00:35:15 +0100) Jeff Mahoney (2): btrfs: handle errors while updating refcounts in update_ref_for_cow btrfs: fix missing error return in btrfs_drop_snapshot Justin Maggard (1): btrfs: Fix quota reservation leak on preallocated files Nikolay Borisov (1): btrfs: Fix possible off-by-one in btrfs_search_path_in_tree Omar Sandoval (1): Btrfs: disable FUA if mounted with nobarrier fs/btrfs/ctree.c | 18 -- fs/btrfs/disk-io.c | 12 +--- fs/btrfs/extent-tree.c | 1 + fs/btrfs/inode.c | 2 ++ fs/btrfs/ioctl.c | 2 +- 5 files changed, 21 insertions(+), 14 deletions(-)
Re: [GIT PULL] Btrfs fixes for 4.15-rc2
On Wed, Nov 29, 2017 at 02:31:24PM -0800, Linus Torvalds wrote: > On Wed, Nov 29, 2017 at 11:28 AM, David Sterbawrote: > > > > With signed tag: for-4.15-rc2-tag > > > > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc2 > > Oh, please actually ask me to pull the signed tag (exact same > pull-request, just point git request-pull at the tag), Will do next time. > because now > what happened was that first I just pulled that branch you mentioned, > and only noticed that "With signed tag:" notice after I had already > pulled and was filling in the merge message. > > Anyway, I redid the pull with the proper signed tag, but it was just > annoying extra work. > > And I wonder how many times I _hadn't_ noticed that, because I didn't > have your key in my keyring either. Or maybe I caught it the first > time. All my previous pull requests were like that. I did the split branch/tag beacuse the ambiguous name for branch and brings some hassle to push or remove them. I thought a separate tag with same top commit as the branch plus mentioning the tag in the mail would be enough to verify the pulled branch. But apparently was not, sorry for the trouble.
Re: [GIT PULL] Btrfs fixes for 4.15-rc2
On Wed, Nov 29, 2017 at 02:31:24PM -0800, Linus Torvalds wrote: > On Wed, Nov 29, 2017 at 11:28 AM, David Sterba wrote: > > > > With signed tag: for-4.15-rc2-tag > > > > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc2 > > Oh, please actually ask me to pull the signed tag (exact same > pull-request, just point git request-pull at the tag), Will do next time. > because now > what happened was that first I just pulled that branch you mentioned, > and only noticed that "With signed tag:" notice after I had already > pulled and was filling in the merge message. > > Anyway, I redid the pull with the proper signed tag, but it was just > annoying extra work. > > And I wonder how many times I _hadn't_ noticed that, because I didn't > have your key in my keyring either. Or maybe I caught it the first > time. All my previous pull requests were like that. I did the split branch/tag beacuse the ambiguous name for branch and brings some hassle to push or remove them. I thought a separate tag with same top commit as the branch plus mentioning the tag in the mail would be enough to verify the pulled branch. But apparently was not, sorry for the trouble.
Re: [GIT PULL] Btrfs fixes for 4.15-rc2
On Wed, Nov 29, 2017 at 11:28 AM, David Sterbawrote: > > With signed tag: for-4.15-rc2-tag > > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc2 Oh, please actually ask me to pull the signed tag (exact same pull-request, just point git request-pull at the tag), because now what happened was that first I just pulled that branch you mentioned, and only noticed that "With signed tag:" notice after I had already pulled and was filling in the merge message. Anyway, I redid the pull with the proper signed tag, but it was just annoying extra work. And I wonder how many times I _hadn't_ noticed that, because I didn't have your key in my keyring either. Or maybe I caught it the first time. Linus
Re: [GIT PULL] Btrfs fixes for 4.15-rc2
On Wed, Nov 29, 2017 at 11:28 AM, David Sterba wrote: > > With signed tag: for-4.15-rc2-tag > > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc2 Oh, please actually ask me to pull the signed tag (exact same pull-request, just point git request-pull at the tag), because now what happened was that first I just pulled that branch you mentioned, and only noticed that "With signed tag:" notice after I had already pulled and was filling in the merge message. Anyway, I redid the pull with the proper signed tag, but it was just annoying extra work. And I wonder how many times I _hadn't_ noticed that, because I didn't have your key in my keyring either. Or maybe I caught it the first time. Linus
[GIT PULL] Btrfs fixes for 4.15-rc2
Hi, we've collected some fixes in since the pre-merge window freeze. There's technically only one regression fix for 4.15, but the rest seems important and candidates for stable. No merge conflicts, please pull, thanks. - fix missing flush bio puts in error cases (is serious, but rarely happens) - fix reporting stat::st_blocks for buffered append writes - fix space cache invalidation - fix out of bound memory access when setting zlib level - fix potential memory corruption when fsync fails in the middle - fix crash in integrity checker - incremetnal send fix, path mixup for certain unlink/rename combination - pass flags to writeback so compressed writes can be throttled properly - error handling fixes With signed tag: for-4.15-rc2-tag The following changes since commit d28e649a5c58b779b303c252c66ee84a0f2c3b32: btrfs: Fix bug for misused dev_t when lookup in dev state hash table. (2017-11-01 20:45:36 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc2 for you to fetch changes up to ea37d5998b50a72b9045ba60a132eeb20e1c4230: Btrfs: incremental send, fix wrong unlink path after renaming file (2017-11-28 17:15:30 +0100) David Sterba (2): btrfs: add missing device::flush_bio puts btrfs: dev_alloc_list is not protected by RCU, use normal list_del Filipe Manana (3): Btrfs: move definition of the function btrfs_find_new_delalloc_bytes Btrfs: fix reported number of inode blocks after buffered append writes Btrfs: incremental send, fix wrong unlink path after renaming file Josef Bacik (2): btrfs: clear space cache inode generation always btrfs: fix deadlock when writing out space cache Liu Bo (3): Btrfs: add write_flags for compression bio Btrfs: bail out gracefully rather than BUG_ON Btrfs: fix list_add corruption and soft lockups in fsync Nikolay Borisov (1): btrfs: Fix transaction abort during failure in btrfs_rm_dev_item Qu Wenruo (2): btrfs: Fix wild memory access in compression level parser btrfs: tree-checker: Fix false panic for sanity test fs/btrfs/compression.c | 9 +-- fs/btrfs/compression.h | 5 +- fs/btrfs/ctree.h | 1 + fs/btrfs/disk-io.c | 10 ++- fs/btrfs/extent-tree.c | 14 ++--- fs/btrfs/extent_io.c | 2 +- fs/btrfs/extent_io.h | 8 ++- fs/btrfs/file.c | 130 +-- fs/btrfs/free-space-cache.c | 3 +- fs/btrfs/inode.c | 34 +++--- fs/btrfs/relocation.c| 3 +- fs/btrfs/send.c | 124 +++-- fs/btrfs/super.c | 13 +++- fs/btrfs/tests/extent-io-tests.c | 6 +- fs/btrfs/tests/inode-tests.c | 12 ++-- fs/btrfs/tree-checker.c | 27 ++-- fs/btrfs/tree-checker.h | 14 - fs/btrfs/tree-log.c | 2 +- fs/btrfs/volumes.c | 32 +++--- 19 files changed, 314 insertions(+), 135 deletions(-)
[GIT PULL] Btrfs fixes for 4.15-rc2
Hi, we've collected some fixes in since the pre-merge window freeze. There's technically only one regression fix for 4.15, but the rest seems important and candidates for stable. No merge conflicts, please pull, thanks. - fix missing flush bio puts in error cases (is serious, but rarely happens) - fix reporting stat::st_blocks for buffered append writes - fix space cache invalidation - fix out of bound memory access when setting zlib level - fix potential memory corruption when fsync fails in the middle - fix crash in integrity checker - incremetnal send fix, path mixup for certain unlink/rename combination - pass flags to writeback so compressed writes can be throttled properly - error handling fixes With signed tag: for-4.15-rc2-tag The following changes since commit d28e649a5c58b779b303c252c66ee84a0f2c3b32: btrfs: Fix bug for misused dev_t when lookup in dev state hash table. (2017-11-01 20:45:36 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc2 for you to fetch changes up to ea37d5998b50a72b9045ba60a132eeb20e1c4230: Btrfs: incremental send, fix wrong unlink path after renaming file (2017-11-28 17:15:30 +0100) David Sterba (2): btrfs: add missing device::flush_bio puts btrfs: dev_alloc_list is not protected by RCU, use normal list_del Filipe Manana (3): Btrfs: move definition of the function btrfs_find_new_delalloc_bytes Btrfs: fix reported number of inode blocks after buffered append writes Btrfs: incremental send, fix wrong unlink path after renaming file Josef Bacik (2): btrfs: clear space cache inode generation always btrfs: fix deadlock when writing out space cache Liu Bo (3): Btrfs: add write_flags for compression bio Btrfs: bail out gracefully rather than BUG_ON Btrfs: fix list_add corruption and soft lockups in fsync Nikolay Borisov (1): btrfs: Fix transaction abort during failure in btrfs_rm_dev_item Qu Wenruo (2): btrfs: Fix wild memory access in compression level parser btrfs: tree-checker: Fix false panic for sanity test fs/btrfs/compression.c | 9 +-- fs/btrfs/compression.h | 5 +- fs/btrfs/ctree.h | 1 + fs/btrfs/disk-io.c | 10 ++- fs/btrfs/extent-tree.c | 14 ++--- fs/btrfs/extent_io.c | 2 +- fs/btrfs/extent_io.h | 8 ++- fs/btrfs/file.c | 130 +-- fs/btrfs/free-space-cache.c | 3 +- fs/btrfs/inode.c | 34 +++--- fs/btrfs/relocation.c| 3 +- fs/btrfs/send.c | 124 +++-- fs/btrfs/super.c | 13 +++- fs/btrfs/tests/extent-io-tests.c | 6 +- fs/btrfs/tests/inode-tests.c | 12 ++-- fs/btrfs/tree-checker.c | 27 ++-- fs/btrfs/tree-checker.h | 14 - fs/btrfs/tree-log.c | 2 +- fs/btrfs/volumes.c | 32 +++--- 19 files changed, 314 insertions(+), 135 deletions(-)
Re: [GIT PULL] Btrfs fixes for 4.14-rc4
On rc3 is possible to observe warning about possible circular locking dependency which I've reported on btrfs list few days ago: [ 101.326724] == [ 101.326728] WARNING: possible circular locking dependency detected [ 101.326734] 4.14.0-0.rc3.git1.1.fc28.x86_64 #1 Not tainted [ 101.326738] -- [ 101.326743] mysqld/1253 is trying to acquire lock: [ 101.326747] (>mmap_sem){}, at: [] get_user_pages_unlocked+0x5e/0x1b0 [ 101.326771] [ 101.326775] (>dio_sem){}, at: [] btrfs_direct_IO+0x39f/0x400 [btrfs] [ 101.326846] [ 101.326851] [ 101.326856] [ 101.326875]__lock_acquire+0x1107/0x11d0 [ 101.326883]lock_acquire+0xa3/0x1f0 [ 101.326892]down_write+0x51/0xc0 [ 101.326949]btrfs_log_changed_extents+0x7e/0x6c0 [btrfs] [ 101.327000]btrfs_log_inode+0x9c1/0x11d0 [btrfs] [ 101.327049]btrfs_log_inode_parent+0x2df/0xad0 [btrfs] [ 101.327096]btrfs_log_dentry_safe+0x60/0x80 [btrfs] [ 101.327144]btrfs_sync_file+0x344/0x4f0 [btrfs] [ 101.327155]vfs_fsync_range+0x4b/0xb0 [ 101.327162]do_fsync+0x3d/0x70 [ 101.327170]SyS_fsync+0x10/0x20 [ 101.327179]do_syscall_64+0x6c/0x1f0 [ 101.327185]return_from_SYSCALL_64+0x0/0x7a [ 101.327188] [ 101.327204]__lock_acquire+0x1107/0x11d0 [ 101.327212]lock_acquire+0xa3/0x1f0 [ 101.327219]__mutex_lock+0x7f/0xa40 [ 101.327226]mutex_lock_nested+0x1b/0x20 [ 101.327272]btrfs_log_inode+0x159/0x11d0 [btrfs] [ 101.327317]btrfs_log_inode_parent+0x2df/0xad0 [btrfs] [ 101.327360]btrfs_log_dentry_safe+0x60/0x80 [btrfs] [ 101.327407]btrfs_sync_file+0x344/0x4f0 [btrfs] [ 101.327415]vfs_fsync_range+0x4b/0xb0 [ 101.327422]do_fsync+0x3d/0x70 [ 101.327429]SyS_fsync+0x10/0x20 [ 101.327435]do_syscall_64+0x6c/0x1f0 [ 101.327441]return_from_SYSCALL_64+0x0/0x7a [ 101.327444] [ 101.327463]__sb_start_write+0x12b/0x1a0 [ 101.327508]start_transaction+0x368/0x4d0 [btrfs] [ 101.327549]btrfs_join_transaction+0x1d/0x20 [btrfs] [ 101.327589]delayed_ref_async_start+0x67/0xd0 [btrfs] [ 101.327637]btrfs_worker_helper+0x93/0x610 [btrfs] [ 101.327640] [ 101.327656]__lock_acquire+0x1107/0x11d0 [ 101.327664]lock_acquire+0xa3/0x1f0 [ 101.327671]wait_for_completion+0x62/0x1d0 [ 101.327710]btrfs_async_run_delayed_refs+0x163/0x180 [btrfs] [ 101.327752]__btrfs_end_transaction+0x1f2/0x2e0 [btrfs] [ 101.327790]btrfs_end_transaction+0x10/0x20 [btrfs] [ 101.327832]btrfs_dirty_inode+0x71/0xd0 [btrfs] [ 101.327871]btrfs_update_time+0x81/0xc0 [btrfs] [ 101.327877]touch_atime+0xab/0xd0 [ 101.327920]btrfs_file_mmap+0x44/0x60 [btrfs] [ 101.327927]mmap_region+0x3a3/0x5d0 [ 101.327932]do_mmap+0x2b6/0x410 [ 101.327938]vm_mmap_pgoff+0xcf/0x120 [ 101.327943]SyS_mmap_pgoff+0x1e1/0x280 [ 101.327949]SyS_mmap+0x1b/0x30 [ 101.327955]entry_SYSCALL_64_fastpath+0x1f/0xbe [ 101.327958] [ 101.327974]check_prev_add+0x351/0x700 [ 101.327981]__lock_acquire+0x1107/0x11d0 [ 101.327989]lock_acquire+0xa3/0x1f0 [ 101.327996]down_read+0x48/0xb0 [ 101.328003]get_user_pages_unlocked+0x5e/0x1b0 [ 101.328009]get_user_pages_fast+0x7a/0xc0 [ 101.328018]iov_iter_get_pages+0xc9/0x300 [ 101.328026]do_blockdev_direct_IO+0x192b/0x2940 [ 101.328034]__blockdev_direct_IO+0x2e/0x30 [ 101.328073]btrfs_direct_IO+0x171/0x400 [btrfs] [ 101.328080]generic_file_direct_write+0xa3/0x160 [ 101.328123]btrfs_file_write_iter+0x2fb/0x610 [btrfs] [ 101.328129]aio_write+0x116/0x1a0 [ 101.328134]do_io_submit+0x42d/0x940 [ 101.328139]SyS_io_submit+0x10/0x20 [ 101.328145]entry_SYSCALL_64_fastpath+0x1f/0xbe [ 101.328149] [ 101.328154] Chain exists of: [ 101.328169] Possible unsafe locking scenario: [ 101.328174]CPU0CPU1 [ 101.328177] [ 101.328180] lock(>dio_sem); [ 101.328187]lock(>log_mutex); [ 101.328194]lock(>dio_sem); [ 101.328200] lock(>mmap_sem); [ 101.328206] [ 101.328213] 2 locks held by mysqld/1253: [ 101.328217] #0: (sb_writers#10){.+.+}, at: [] aio_write+0x191/0x1a0 [ 101.328231] #1: (>dio_sem){}, at: [] btrfs_direct_IO+0x39f/0x400 [btrfs] [ 101.328277] [ 101.328285] CPU: 0 PID: 1253 Comm: mysqld Not tainted 4.14.0-0.rc3.git1.1.fc28.x86_64 #1 [ 101.328290] Hardware name: Sony Corporation VPCSB2M9E/VAIO, BIOS R2087H4 06/15/2012 [ 101.328294] Call Trace: [ 101.328304] dump_stack+0x8e/0xd6 [ 101.328314] print_circular_bug+0x1f6/0x2e0 [ 101.328322] ?
Re: [GIT PULL] Btrfs fixes for 4.14-rc4
On rc3 is possible to observe warning about possible circular locking dependency which I've reported on btrfs list few days ago: [ 101.326724] == [ 101.326728] WARNING: possible circular locking dependency detected [ 101.326734] 4.14.0-0.rc3.git1.1.fc28.x86_64 #1 Not tainted [ 101.326738] -- [ 101.326743] mysqld/1253 is trying to acquire lock: [ 101.326747] (>mmap_sem){}, at: [] get_user_pages_unlocked+0x5e/0x1b0 [ 101.326771] [ 101.326775] (>dio_sem){}, at: [] btrfs_direct_IO+0x39f/0x400 [btrfs] [ 101.326846] [ 101.326851] [ 101.326856] [ 101.326875]__lock_acquire+0x1107/0x11d0 [ 101.326883]lock_acquire+0xa3/0x1f0 [ 101.326892]down_write+0x51/0xc0 [ 101.326949]btrfs_log_changed_extents+0x7e/0x6c0 [btrfs] [ 101.327000]btrfs_log_inode+0x9c1/0x11d0 [btrfs] [ 101.327049]btrfs_log_inode_parent+0x2df/0xad0 [btrfs] [ 101.327096]btrfs_log_dentry_safe+0x60/0x80 [btrfs] [ 101.327144]btrfs_sync_file+0x344/0x4f0 [btrfs] [ 101.327155]vfs_fsync_range+0x4b/0xb0 [ 101.327162]do_fsync+0x3d/0x70 [ 101.327170]SyS_fsync+0x10/0x20 [ 101.327179]do_syscall_64+0x6c/0x1f0 [ 101.327185]return_from_SYSCALL_64+0x0/0x7a [ 101.327188] [ 101.327204]__lock_acquire+0x1107/0x11d0 [ 101.327212]lock_acquire+0xa3/0x1f0 [ 101.327219]__mutex_lock+0x7f/0xa40 [ 101.327226]mutex_lock_nested+0x1b/0x20 [ 101.327272]btrfs_log_inode+0x159/0x11d0 [btrfs] [ 101.327317]btrfs_log_inode_parent+0x2df/0xad0 [btrfs] [ 101.327360]btrfs_log_dentry_safe+0x60/0x80 [btrfs] [ 101.327407]btrfs_sync_file+0x344/0x4f0 [btrfs] [ 101.327415]vfs_fsync_range+0x4b/0xb0 [ 101.327422]do_fsync+0x3d/0x70 [ 101.327429]SyS_fsync+0x10/0x20 [ 101.327435]do_syscall_64+0x6c/0x1f0 [ 101.327441]return_from_SYSCALL_64+0x0/0x7a [ 101.327444] [ 101.327463]__sb_start_write+0x12b/0x1a0 [ 101.327508]start_transaction+0x368/0x4d0 [btrfs] [ 101.327549]btrfs_join_transaction+0x1d/0x20 [btrfs] [ 101.327589]delayed_ref_async_start+0x67/0xd0 [btrfs] [ 101.327637]btrfs_worker_helper+0x93/0x610 [btrfs] [ 101.327640] [ 101.327656]__lock_acquire+0x1107/0x11d0 [ 101.327664]lock_acquire+0xa3/0x1f0 [ 101.327671]wait_for_completion+0x62/0x1d0 [ 101.327710]btrfs_async_run_delayed_refs+0x163/0x180 [btrfs] [ 101.327752]__btrfs_end_transaction+0x1f2/0x2e0 [btrfs] [ 101.327790]btrfs_end_transaction+0x10/0x20 [btrfs] [ 101.327832]btrfs_dirty_inode+0x71/0xd0 [btrfs] [ 101.327871]btrfs_update_time+0x81/0xc0 [btrfs] [ 101.327877]touch_atime+0xab/0xd0 [ 101.327920]btrfs_file_mmap+0x44/0x60 [btrfs] [ 101.327927]mmap_region+0x3a3/0x5d0 [ 101.327932]do_mmap+0x2b6/0x410 [ 101.327938]vm_mmap_pgoff+0xcf/0x120 [ 101.327943]SyS_mmap_pgoff+0x1e1/0x280 [ 101.327949]SyS_mmap+0x1b/0x30 [ 101.327955]entry_SYSCALL_64_fastpath+0x1f/0xbe [ 101.327958] [ 101.327974]check_prev_add+0x351/0x700 [ 101.327981]__lock_acquire+0x1107/0x11d0 [ 101.327989]lock_acquire+0xa3/0x1f0 [ 101.327996]down_read+0x48/0xb0 [ 101.328003]get_user_pages_unlocked+0x5e/0x1b0 [ 101.328009]get_user_pages_fast+0x7a/0xc0 [ 101.328018]iov_iter_get_pages+0xc9/0x300 [ 101.328026]do_blockdev_direct_IO+0x192b/0x2940 [ 101.328034]__blockdev_direct_IO+0x2e/0x30 [ 101.328073]btrfs_direct_IO+0x171/0x400 [btrfs] [ 101.328080]generic_file_direct_write+0xa3/0x160 [ 101.328123]btrfs_file_write_iter+0x2fb/0x610 [btrfs] [ 101.328129]aio_write+0x116/0x1a0 [ 101.328134]do_io_submit+0x42d/0x940 [ 101.328139]SyS_io_submit+0x10/0x20 [ 101.328145]entry_SYSCALL_64_fastpath+0x1f/0xbe [ 101.328149] [ 101.328154] Chain exists of: [ 101.328169] Possible unsafe locking scenario: [ 101.328174]CPU0CPU1 [ 101.328177] [ 101.328180] lock(>dio_sem); [ 101.328187]lock(>log_mutex); [ 101.328194]lock(>dio_sem); [ 101.328200] lock(>mmap_sem); [ 101.328206] [ 101.328213] 2 locks held by mysqld/1253: [ 101.328217] #0: (sb_writers#10){.+.+}, at: [] aio_write+0x191/0x1a0 [ 101.328231] #1: (>dio_sem){}, at: [] btrfs_direct_IO+0x39f/0x400 [btrfs] [ 101.328277] [ 101.328285] CPU: 0 PID: 1253 Comm: mysqld Not tainted 4.14.0-0.rc3.git1.1.fc28.x86_64 #1 [ 101.328290] Hardware name: Sony Corporation VPCSB2M9E/VAIO, BIOS R2087H4 06/15/2012 [ 101.328294] Call Trace: [ 101.328304] dump_stack+0x8e/0xd6 [ 101.328314] print_circular_bug+0x1f6/0x2e0 [ 101.328322] ?
[GIT PULL] Btrfs fixes for 4.14-rc4
Hi, we have two more fixes for bugs introduced in 4.13. The sector_t problem with 32bit architecture and !LBDAF config seems serious but the number of affected deployments is hopefully low. The clashing status bits could lead to a confusing in-memory state of the whole-filesystem operations if used with the quota override sysfs knob. Please pull, thanks. The following changes since commit 8c6c592831a09a28428448e68fb08c6bbb8b9b8b: btrfs: log csums for all modified extents (2017-09-26 14:54:16 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.14-rc4 for you to fetch changes up to 69ad59767d094752c23c0fc180a79532fde073d0: Btrfs: fix overlap of fs_info::flags values (2017-10-04 16:44:18 +0200) Goffredo Baroncelli (1): btrfs: avoid overflow when sector_t is 32 bit Tsutomu Itoh (1): Btrfs: fix overlap of fs_info::flags values fs/btrfs/ctree.h | 2 +- fs/btrfs/extent_io.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
[GIT PULL] Btrfs fixes for 4.14-rc4
Hi, we have two more fixes for bugs introduced in 4.13. The sector_t problem with 32bit architecture and !LBDAF config seems serious but the number of affected deployments is hopefully low. The clashing status bits could lead to a confusing in-memory state of the whole-filesystem operations if used with the quota override sysfs knob. Please pull, thanks. The following changes since commit 8c6c592831a09a28428448e68fb08c6bbb8b9b8b: btrfs: log csums for all modified extents (2017-09-26 14:54:16 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.14-rc4 for you to fetch changes up to 69ad59767d094752c23c0fc180a79532fde073d0: Btrfs: fix overlap of fs_info::flags values (2017-10-04 16:44:18 +0200) Goffredo Baroncelli (1): btrfs: avoid overflow when sector_t is 32 bit Tsutomu Itoh (1): Btrfs: fix overlap of fs_info::flags values fs/btrfs/ctree.h | 2 +- fs/btrfs/extent_io.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
[GIT PULL] Btrfs fixes for 4.14-rc3
Hi, we've collected a bunch of isolated fixes, for crashes, user-visible behaviour or missing bits from other subsystem cleanups from the past. The overall number is not small but I was not able to make it significantly smaller. Most of the patches are supposed to go to stable. There are no merge conflicts. Please pull, thanks. The following changes since commit db95c876c568cef951fbbd4c0118cb5386e4bb99: btrfs: submit superblock io with REQ_META and REQ_PRIO (2017-08-22 13:22:05 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.14-rc3 for you to fetch changes up to 8c6c592831a09a28428448e68fb08c6bbb8b9b8b: btrfs: log csums for all modified extents (2017-09-26 14:54:16 +0200) Josef Bacik (1): btrfs: log csums for all modified extents Liu Bo (7): Btrfs: use the new helper wbc_to_write_flags Btrfs: do not reset bio->bi_ops while writing bio Btrfs: do not backup tree roots when fsync Btrfs: use btrfs_op instead of bio_op in __btrfs_map_block Btrfs: fix kernel oops while reading compressed data Btrfs: skip checksum when reading compressed data if some IO have failed Btrfs: fix unexpected result when dio reading corrupted blocks Misono, Tomohiro (1): btrfs: remove BTRFS_FS_QUOTA_DISABLING flag Naohiro Aota (4): btrfs: clear ordered flag on cleaning up ordered extents btrfs: finish ordered extent cleaning if no progress is found btrfs: fix NULL pointer dereference from free_reloc_roots() btrfs: propagate error to btrfs_cmp_data_prepare caller Omar Sandoval (1): Btrfs: fix incorrect {node,sector}size endianness from BTRFS_IOC_FS_INFO Sargun Dhillon (1): btrfs: Report error on removing qgroup if del_qgroup_item fails Tsutomu Itoh (1): Btrfs: send: fix error number for unknown inode types satoru takeuchi (1): btrfs: prevent to set invalid default subvolid fs/btrfs/compression.c | 18 +- fs/btrfs/ctree.h | 1 - fs/btrfs/disk-io.c | 9 - fs/btrfs/extent_io.c | 8 ++-- fs/btrfs/inode.c | 27 ++- fs/btrfs/ioctl.c | 12 fs/btrfs/qgroup.c | 6 ++ fs/btrfs/relocation.c | 2 +- fs/btrfs/send.c| 2 +- fs/btrfs/tree-log.c| 12 ++-- fs/btrfs/volumes.c | 2 +- 11 files changed, 72 insertions(+), 27 deletions(-)
[GIT PULL] Btrfs fixes for 4.14-rc3
Hi, we've collected a bunch of isolated fixes, for crashes, user-visible behaviour or missing bits from other subsystem cleanups from the past. The overall number is not small but I was not able to make it significantly smaller. Most of the patches are supposed to go to stable. There are no merge conflicts. Please pull, thanks. The following changes since commit db95c876c568cef951fbbd4c0118cb5386e4bb99: btrfs: submit superblock io with REQ_META and REQ_PRIO (2017-08-22 13:22:05 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.14-rc3 for you to fetch changes up to 8c6c592831a09a28428448e68fb08c6bbb8b9b8b: btrfs: log csums for all modified extents (2017-09-26 14:54:16 +0200) Josef Bacik (1): btrfs: log csums for all modified extents Liu Bo (7): Btrfs: use the new helper wbc_to_write_flags Btrfs: do not reset bio->bi_ops while writing bio Btrfs: do not backup tree roots when fsync Btrfs: use btrfs_op instead of bio_op in __btrfs_map_block Btrfs: fix kernel oops while reading compressed data Btrfs: skip checksum when reading compressed data if some IO have failed Btrfs: fix unexpected result when dio reading corrupted blocks Misono, Tomohiro (1): btrfs: remove BTRFS_FS_QUOTA_DISABLING flag Naohiro Aota (4): btrfs: clear ordered flag on cleaning up ordered extents btrfs: finish ordered extent cleaning if no progress is found btrfs: fix NULL pointer dereference from free_reloc_roots() btrfs: propagate error to btrfs_cmp_data_prepare caller Omar Sandoval (1): Btrfs: fix incorrect {node,sector}size endianness from BTRFS_IOC_FS_INFO Sargun Dhillon (1): btrfs: Report error on removing qgroup if del_qgroup_item fails Tsutomu Itoh (1): Btrfs: send: fix error number for unknown inode types satoru takeuchi (1): btrfs: prevent to set invalid default subvolid fs/btrfs/compression.c | 18 +- fs/btrfs/ctree.h | 1 - fs/btrfs/disk-io.c | 9 - fs/btrfs/extent_io.c | 8 ++-- fs/btrfs/inode.c | 27 ++- fs/btrfs/ioctl.c | 12 fs/btrfs/qgroup.c | 6 ++ fs/btrfs/relocation.c | 2 +- fs/btrfs/send.c| 2 +- fs/btrfs/tree-log.c| 12 ++-- fs/btrfs/volumes.c | 2 +- 11 files changed, 72 insertions(+), 27 deletions(-)
[GIT PULL] Btrfs fixes for 4.13-rc3
Hi, please pull the following btrfs fixes. They're addressing problems reported by users, and there's one more regression fix. Thanks. The next pull request will be sent by Chris, I'm heading off to vacation. The following changes since commit c3cfb656307583ddfea45375c10183737593c195: Btrfs: fix unexpected return value of bio_readpage_error (2017-07-14 20:42:37 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.13-part3 for you to fetch changes up to 0e4324a4c36b3eb5cd1f71cbbc38d888f919ebfc: btrfs: round down size diff when shrinking/growing device (2017-07-24 16:05:00 +0200) Filipe Manana (1): Btrfs: fix dir item validation when replaying xattr deletes Jeff Mahoney (1): btrfs: fix lockup in find_free_extent with read-only block groups Nikolay Borisov (1): btrfs: round down size diff when shrinking/growing device Omar Sandoval (1): Btrfs: fix early ENOSPC due to delalloc fs/btrfs/extent-tree.c | 11 +-- fs/btrfs/tree-log.c| 3 +-- fs/btrfs/volumes.c | 4 ++-- 3 files changed, 8 insertions(+), 10 deletions(-)
[GIT PULL] Btrfs fixes for 4.13-rc3
Hi, please pull the following btrfs fixes. They're addressing problems reported by users, and there's one more regression fix. Thanks. The next pull request will be sent by Chris, I'm heading off to vacation. The following changes since commit c3cfb656307583ddfea45375c10183737593c195: Btrfs: fix unexpected return value of bio_readpage_error (2017-07-14 20:42:37 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.13-part3 for you to fetch changes up to 0e4324a4c36b3eb5cd1f71cbbc38d888f919ebfc: btrfs: round down size diff when shrinking/growing device (2017-07-24 16:05:00 +0200) Filipe Manana (1): Btrfs: fix dir item validation when replaying xattr deletes Jeff Mahoney (1): btrfs: fix lockup in find_free_extent with read-only block groups Nikolay Borisov (1): btrfs: round down size diff when shrinking/growing device Omar Sandoval (1): Btrfs: fix early ENOSPC due to delalloc fs/btrfs/extent-tree.c | 11 +-- fs/btrfs/tree-log.c| 3 +-- fs/btrfs/volumes.c | 4 ++-- 3 files changed, 8 insertions(+), 10 deletions(-)
[GIT PULL] Btrfs fixes
Hi Linus, Dave Sterba queued up a few fixes for btrfs. I have them in my for-linus-4.10 branch: These are all over the place. The tracepoint part of the pull fixes a crash and adds a little more information to two tracepoints, while the rest are good old fashioned fixes. git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.10 Liu Bo (5) commits (+34/-11): Btrfs: adjust outstanding_extents counter properly when dio write is split (+9/-2) Btrfs: add truncated_len for ordered extent tracepoints (+4/-0) Btrfs: use down_read_nested to make lockdep silent (+2/-1) Btrfs: add 'inode' for extent map tracepoint (+9/-5) Btrfs: fix lockdep warning about log_mutex (+10/-3) David Sterba (2) commits (+80/-69): btrfs: fix crash when tracepoint arguments are freed by wq callbacks (+24/-13) btrfs: make tracepoint format strings more compact (+56/-56) Jeff Mahoney (2) commits (+4/-1): btrfs: fix locking when we put back a delayed ref that's too new (+1/-1) btrfs: fix error handling when run_delayed_extent_op fails (+3/-0) Pan Bian (1) commits (+1/-3): btrfs: return the actual error value from from btrfs_uuid_tree_iterate Total: (10) commits (+119/-84) fs/btrfs/async-thread.c | 15 +++-- fs/btrfs/extent-tree.c | 8 ++- fs/btrfs/inode.c | 13 +++- fs/btrfs/tree-log.c | 13 +++- fs/btrfs/uuid-tree.c | 4 +- include/trace/events/btrfs.h | 146 +++ 6 files changed, 117 insertions(+), 82 deletions(-)
[GIT PULL] Btrfs fixes
Hi Linus, Dave Sterba queued up a few fixes for btrfs. I have them in my for-linus-4.10 branch: These are all over the place. The tracepoint part of the pull fixes a crash and adds a little more information to two tracepoints, while the rest are good old fashioned fixes. git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.10 Liu Bo (5) commits (+34/-11): Btrfs: adjust outstanding_extents counter properly when dio write is split (+9/-2) Btrfs: add truncated_len for ordered extent tracepoints (+4/-0) Btrfs: use down_read_nested to make lockdep silent (+2/-1) Btrfs: add 'inode' for extent map tracepoint (+9/-5) Btrfs: fix lockdep warning about log_mutex (+10/-3) David Sterba (2) commits (+80/-69): btrfs: fix crash when tracepoint arguments are freed by wq callbacks (+24/-13) btrfs: make tracepoint format strings more compact (+56/-56) Jeff Mahoney (2) commits (+4/-1): btrfs: fix locking when we put back a delayed ref that's too new (+1/-1) btrfs: fix error handling when run_delayed_extent_op fails (+3/-0) Pan Bian (1) commits (+1/-3): btrfs: return the actual error value from from btrfs_uuid_tree_iterate Total: (10) commits (+119/-84) fs/btrfs/async-thread.c | 15 +++-- fs/btrfs/extent-tree.c | 8 ++- fs/btrfs/inode.c | 13 +++- fs/btrfs/tree-log.c | 13 +++- fs/btrfs/uuid-tree.c | 4 +- include/trace/events/btrfs.h | 146 +++ 6 files changed, 117 insertions(+), 82 deletions(-)
[GIT PULL] Btrfs fixes
Hi Linus, I have a few more fixes in my for-linus-4.1 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 The first commit is a fix from Filipe for a very old extent buffer reuse race that triggered a BUG_ON. It hasn't come up often, I looked through old logs at FB and we hit it a handful of times over the last year. The rest are other corners he hit during testing Filipe Manana (4) commits (+68/-10): Btrfs: fix race when reusing stale extent buffers that leads to BUG_ON (+19/-0) Btrfs: fix race between block group creation and their cache writeout (+27/-4) Btrfs: fix panic when starting bg cache writeout after IO error (+10/-4) Btrfs: fix crash after inode cache writeback failure (+12/-2) Total: (4) commits fs/btrfs/extent-tree.c | 31 +++ fs/btrfs/extent_io.c| 19 +++ fs/btrfs/free-space-cache.c | 14 -- fs/btrfs/ordered-data.c | 14 ++ 4 files changed, 68 insertions(+), 10 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, I have a few more fixes in my for-linus-4.1 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 The first commit is a fix from Filipe for a very old extent buffer reuse race that triggered a BUG_ON. It hasn't come up often, I looked through old logs at FB and we hit it a handful of times over the last year. The rest are other corners he hit during testing Filipe Manana (4) commits (+68/-10): Btrfs: fix race when reusing stale extent buffers that leads to BUG_ON (+19/-0) Btrfs: fix race between block group creation and their cache writeout (+27/-4) Btrfs: fix panic when starting bg cache writeout after IO error (+10/-4) Btrfs: fix crash after inode cache writeback failure (+12/-2) Total: (4) commits fs/btrfs/extent-tree.c | 31 +++ fs/btrfs/extent_io.c| 19 +++ fs/btrfs/free-space-cache.c | 14 -- fs/btrfs/ordered-data.c | 14 ++ 4 files changed, 68 insertions(+), 10 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, I have a few more btrfs fixes in my for-linus-4.1 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 These range from corners Filipe found in the new free space cache writeback to a grab bag of fixes from the list. Omar Sandoval (4) commits (+38/-19): btrfs: unlock i_mutex after attempting to delete subvolume during send (+2/-1) btrfs: check io_ctl_prepare_pages return in __btrfs_write_out_cache (+6/-4) btrfs: fix race on ENOMEM in alloc_extent_buffer (+2/-1) btrfs: handle ENOMEM in btrfs_alloc_tree_block (+28/-13) Forrest Liu (2) commits (+37/-29): Btrfs: btrfs_release_extent_buffer_page didn't free pages of dummy extent (+26/-25) Btrfs: fix find_free_dev_extent() malfunction in case device tree has hole (+11/-4) Filipe Manana (2) commits (+28/-18): Btrfs: fix race between start dirty bg cache writeout and bg deletion (+27/-17) Btrfs: fix deadlock when starting writeback of bg caches (+1/-1) Yang Dongsheng (1) commits (+14/-9): Btrfs: fill ->last_trans for delayed inode in btrfs_fill_inode. Chris Mason (1) commits (+1/-2): Btrfs: don't check for delalloc_bytes in cache_save_setup Total: (10) commits (+118/-77) fs/btrfs/delayed-inode.c| 2 + fs/btrfs/extent-tree.c | 90 - fs/btrfs/extent_io.c| 54 ++- fs/btrfs/free-space-cache.c | 10 +++-- fs/btrfs/inode.c| 21 ++- fs/btrfs/ioctl.c| 3 +- fs/btrfs/volumes.c | 15 ++-- 7 files changed, 118 insertions(+), 77 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, I have a few more btrfs fixes in my for-linus-4.1 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 These range from corners Filipe found in the new free space cache writeback to a grab bag of fixes from the list. Omar Sandoval (4) commits (+38/-19): btrfs: unlock i_mutex after attempting to delete subvolume during send (+2/-1) btrfs: check io_ctl_prepare_pages return in __btrfs_write_out_cache (+6/-4) btrfs: fix race on ENOMEM in alloc_extent_buffer (+2/-1) btrfs: handle ENOMEM in btrfs_alloc_tree_block (+28/-13) Forrest Liu (2) commits (+37/-29): Btrfs: btrfs_release_extent_buffer_page didn't free pages of dummy extent (+26/-25) Btrfs: fix find_free_dev_extent() malfunction in case device tree has hole (+11/-4) Filipe Manana (2) commits (+28/-18): Btrfs: fix race between start dirty bg cache writeout and bg deletion (+27/-17) Btrfs: fix deadlock when starting writeback of bg caches (+1/-1) Yang Dongsheng (1) commits (+14/-9): Btrfs: fill -last_trans for delayed inode in btrfs_fill_inode. Chris Mason (1) commits (+1/-2): Btrfs: don't check for delalloc_bytes in cache_save_setup Total: (10) commits (+118/-77) fs/btrfs/delayed-inode.c| 2 + fs/btrfs/extent-tree.c | 90 - fs/btrfs/extent_io.c| 54 ++- fs/btrfs/free-space-cache.c | 10 +++-- fs/btrfs/inode.c| 21 ++- fs/btrfs/ioctl.c| 3 +- fs/btrfs/volumes.c | 15 ++-- 7 files changed, 118 insertions(+), 77 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, Filipe hit two problems in my block group cache patches. We finalized the fixes last week and ran through more tests. Can you please pull: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 Chris Mason (2) commits (+25/-17): Btrfs: prevent list corruption during free space cache processing (+18/-14) Btrfs: fix inode cache writeout (+7/-3) Total: (2) commits (+25/-17) fs/btrfs/free-space-cache.c | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, Filipe hit two problems in my block group cache patches. We finalized the fixes last week and ran through more tests. Can you please pull: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 Chris Mason (2) commits (+25/-17): Btrfs: prevent list corruption during free space cache processing (+18/-14) Btrfs: fix inode cache writeout (+7/-3) Total: (2) commits (+25/-17) fs/btrfs/free-space-cache.c | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, Please grab my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Most of these are fixing extent reservation accounting, or corners with tree writeback during commit. Josef's set does add a test, which isn't strictly a fix, but it'll keep us from making this same mistake again. Josef Bacik (8) commits (+349/-46): Btrfs: account for the correct number of extents for delalloc reservations (+5/-1) Btrfs: add sanity test for outstanding_extents accounting (+217/-1) Btrfs: fix ASSERT(list_empty(_trans->dirty_bgs_list) (+18/-13) Btrfs: fix outstanding_extents accounting in DIO (+35/-2) Btrfs: prepare block group cache before writing (+32/-1) Btrfs: account merges/splits properly (+30/-27) Btrfs: just free dummy extent buffers (+6/-0) Btrfs: fix merge delalloc logic (+6/-1) Liu Bo (2) commits (+4/-1): Btrfs: catch transaction abortion after waiting for it (+3/-0) Btrfs: fix comp_oper to get right order (+1/-1) Fabian Frederick (1) commits (+1/-1): btrfs: fix sizeof format specifier in btrfs_check_super_valid() Total: (11) commits (+354/-48) fs/btrfs/ctree.h | 5 ++ fs/btrfs/disk-io.c | 2 +- fs/btrfs/extent-tree.c | 35 +++- fs/btrfs/extent_io.c | 6 ++ fs/btrfs/inode.c | 112 ++-- fs/btrfs/qgroup.c| 2 +- fs/btrfs/tests/inode-tests.c | 197 ++- fs/btrfs/transaction.c | 39 ++--- 8 files changed, 352 insertions(+), 46 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, Please grab my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Most of these are fixing extent reservation accounting, or corners with tree writeback during commit. Josef's set does add a test, which isn't strictly a fix, but it'll keep us from making this same mistake again. Josef Bacik (8) commits (+349/-46): Btrfs: account for the correct number of extents for delalloc reservations (+5/-1) Btrfs: add sanity test for outstanding_extents accounting (+217/-1) Btrfs: fix ASSERT(list_empty(cur_trans-dirty_bgs_list) (+18/-13) Btrfs: fix outstanding_extents accounting in DIO (+35/-2) Btrfs: prepare block group cache before writing (+32/-1) Btrfs: account merges/splits properly (+30/-27) Btrfs: just free dummy extent buffers (+6/-0) Btrfs: fix merge delalloc logic (+6/-1) Liu Bo (2) commits (+4/-1): Btrfs: catch transaction abortion after waiting for it (+3/-0) Btrfs: fix comp_oper to get right order (+1/-1) Fabian Frederick (1) commits (+1/-1): btrfs: fix sizeof format specifier in btrfs_check_super_valid() Total: (11) commits (+354/-48) fs/btrfs/ctree.h | 5 ++ fs/btrfs/disk-io.c | 2 +- fs/btrfs/extent-tree.c | 35 +++- fs/btrfs/extent_io.c | 6 ++ fs/btrfs/inode.c | 112 ++-- fs/btrfs/qgroup.c| 2 +- fs/btrfs/tests/inode-tests.c | 197 ++- fs/btrfs/transaction.c | 39 ++--- 8 files changed, 352 insertions(+), 46 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, We have a few fixes in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Qu Wenruo's batch fix a regression between some our merge window pull and the inode_cache feature. The rest are smaller bugs. Qu Wenruo (2) commits (+11/-1): btrfs: Don't call btrfs_start_transaction() on frozen fs to avoid deadlock. (+10/-0) btrfs: Fix the bug that fs_info->pending_changes is never cleared. (+1/-1) Satoru Takeuchi (1) commits (+1/-1): btrfs: fix state->private cast on 32 bit machines David Sterba (1) commits (+2/-2): btrfs: sync ioctl, handle errors after transaction start Filipe Manana (1) commits (+2/-1): Btrfs: fix race deleting block group from space_info->ro_bgs list Tsutomu Itoh (1) commits (+1/-1): Btrfs: fix incorrect freeing in scrub_stripe Total: (6) commits (+17/-6) fs/btrfs/ctree.h | 1 + fs/btrfs/extent-tree.c | 2 +- fs/btrfs/extent_io.c | 2 +- fs/btrfs/scrub.c | 2 +- fs/btrfs/super.c | 14 -- fs/btrfs/transaction.c | 2 +- 6 files changed, 17 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, We have a few fixes in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Qu Wenruo's batch fix a regression between some our merge window pull and the inode_cache feature. The rest are smaller bugs. Qu Wenruo (2) commits (+11/-1): btrfs: Don't call btrfs_start_transaction() on frozen fs to avoid deadlock. (+10/-0) btrfs: Fix the bug that fs_info-pending_changes is never cleared. (+1/-1) Satoru Takeuchi (1) commits (+1/-1): btrfs: fix state-private cast on 32 bit machines David Sterba (1) commits (+2/-2): btrfs: sync ioctl, handle errors after transaction start Filipe Manana (1) commits (+2/-1): Btrfs: fix race deleting block group from space_info-ro_bgs list Tsutomu Itoh (1) commits (+1/-1): Btrfs: fix incorrect freeing in scrub_stripe Total: (6) commits (+17/-6) fs/btrfs/ctree.h | 1 + fs/btrfs/extent-tree.c | 2 +- fs/btrfs/extent_io.c | 2 +- fs/btrfs/scrub.c | 2 +- fs/btrfs/super.c | 14 -- fs/btrfs/transaction.c | 2 +- 6 files changed, 17 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, We have a small queue of btrfs fixes in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus None of these are huge, but my commit does fix a regression from 3.18 that could cause lost files during log replay. This also adds Dave Sterba to the list of Btrfs maintainers. It doesn't mean we're doing things differently, but Dave has really been helping with the maintainer workload for years. Chris Mason (2) commits (+9/-0): Btrfs: don't delay inode ref updates during log replay (+8/-0) Btrfs: add more maintainers (+1/-0) Wang Shilong (1) commits (+3/-1): Btrfs: call inode_dec_link_count() on mkdir error path Filipe Manana (1) commits (+10/-3): Btrfs: correctly get tree level in tree_backref_for_extent Josef Bacik (1) commits (+6/-6): Btrfs: abort transaction if we don't find the block group Dan Carpenter (1) commits (+1/-1): Btrfs, scrub: uninitialized variable in scrub_extent_for_parity() Total: (6) commits (+29/-11) MAINTAINERS | 1 + fs/btrfs/backref.c | 13 ++--- fs/btrfs/delayed-inode.c | 8 fs/btrfs/extent-tree.c | 12 ++-- fs/btrfs/inode.c | 4 +++- fs/btrfs/scrub.c | 2 +- 6 files changed, 29 insertions(+), 11 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, We have a small queue of btrfs fixes in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus None of these are huge, but my commit does fix a regression from 3.18 that could cause lost files during log replay. This also adds Dave Sterba to the list of Btrfs maintainers. It doesn't mean we're doing things differently, but Dave has really been helping with the maintainer workload for years. Chris Mason (2) commits (+9/-0): Btrfs: don't delay inode ref updates during log replay (+8/-0) Btrfs: add more maintainers (+1/-0) Wang Shilong (1) commits (+3/-1): Btrfs: call inode_dec_link_count() on mkdir error path Filipe Manana (1) commits (+10/-3): Btrfs: correctly get tree level in tree_backref_for_extent Josef Bacik (1) commits (+6/-6): Btrfs: abort transaction if we don't find the block group Dan Carpenter (1) commits (+1/-1): Btrfs, scrub: uninitialized variable in scrub_extent_for_parity() Total: (6) commits (+29/-11) MAINTAINERS | 1 + fs/btrfs/backref.c | 13 ++--- fs/btrfs/delayed-inode.c | 8 fs/btrfs/extent-tree.c | 12 ++-- fs/btrfs/inode.c | 4 +++- fs/btrfs/scrub.c | 2 +- 6 files changed, 29 insertions(+), 11 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, We have a few fixes in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Filipe is nailing down some problems with our skinny extent variation, and Dave's patch fixes endian problems in the new super block checks. Filipe Manana (2) commits (+4/-18): Btrfs: fix race that makes btrfs_lookup_extent_info miss skinny extent items (+0/-8) Btrfs: fix invalid leaf slot access in btrfs_lookup_extent() (+4/-10) Josef Bacik (1) commits (+1/-0): Btrfs: properly clean up btrfs_end_io_wq_cache David Sterba (1) commits (+22/-21): btrfs: use macro accessors in superblock validation checks Total: (4) commits (+27/-39) fs/btrfs/ctree.h | 2 +- fs/btrfs/disk-io.c | 43 ++- fs/btrfs/extent-tree.c | 18 ++ fs/btrfs/super.c | 1 + fs/btrfs/tree-log.c| 2 +- 5 files changed, 27 insertions(+), 39 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, We have a few fixes in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Filipe is nailing down some problems with our skinny extent variation, and Dave's patch fixes endian problems in the new super block checks. Filipe Manana (2) commits (+4/-18): Btrfs: fix race that makes btrfs_lookup_extent_info miss skinny extent items (+0/-8) Btrfs: fix invalid leaf slot access in btrfs_lookup_extent() (+4/-10) Josef Bacik (1) commits (+1/-0): Btrfs: properly clean up btrfs_end_io_wq_cache David Sterba (1) commits (+22/-21): btrfs: use macro accessors in superblock validation checks Total: (4) commits (+27/-39) fs/btrfs/ctree.h | 2 +- fs/btrfs/disk-io.c | 43 ++- fs/btrfs/extent-tree.c | 18 ++ fs/btrfs/super.c | 1 + fs/btrfs/tree-log.c| 2 +- 5 files changed, 27 insertions(+), 39 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, We have two more fixes for pulling: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus I've got a revert to fix a regression with btrfs device registration, and Filipe has part two of his fsync fix from last week. Chris Mason (1) commits (+6/-7): Revert "Btrfs: device_list_add() should not update list when mounted" Filipe Manana (1) commits (+13/-14): Btrfs: set inode's logged_trans/last_log_commit after ranged fsync Total: (2) commits (+19/-21) fs/btrfs/btrfs_inode.h | 13 +++-- fs/btrfs/tree-log.c| 14 ++ fs/btrfs/volumes.c | 13 ++--- 3 files changed, 19 insertions(+), 21 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, We have two more fixes for pulling: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus I've got a revert to fix a regression with btrfs device registration, and Filipe has part two of his fsync fix from last week. Chris Mason (1) commits (+6/-7): Revert Btrfs: device_list_add() should not update list when mounted Filipe Manana (1) commits (+13/-14): Btrfs: set inode's logged_trans/last_log_commit after ranged fsync Total: (2) commits (+19/-21) fs/btrfs/btrfs_inode.h | 13 +++-- fs/btrfs/tree-log.c| 14 ++ fs/btrfs/volumes.c | 13 ++--- 3 files changed, 19 insertions(+), 21 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] Btrfs fixes
Hi Linus, My for-linus branch has some btrfs fixes: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Eric's rcu barrier patch fixes a long standing problem with our unmount code hanging on to devices in workqueue helpers. Liu Bo nailed down a difficult assertion for in-memory extent mappings. Liu Bo (4) commits (+9/-7): Btrfs: get better concurrency for snapshot-aware defrag work (+3/-0) Btrfs: fix warning when creating snapshots (+5/-6) Btrfs: fix warning of free_extent_map (+1/-0) Btrfs: remove btrfs_try_spin_lock (+0/-1) Josef Bacik (1) commits (+4/-1): Btrfs: return EIO if we have extent tree corruption Eric Sandeen (1) commits (+6/-0): btrfs: use rcu_barrier() to wait for bdev puts at unmount Wang Shilong (1) commits (+6/-4): Btrfs: return as soon as possible when edquot happens Total: (7) commits (+25/-12) fs/btrfs/extent-tree.c | 5 - fs/btrfs/file.c| 1 + fs/btrfs/inode.c | 3 +++ fs/btrfs/locking.h | 1 - fs/btrfs/qgroup.c | 10 ++ fs/btrfs/transaction.c | 11 +-- fs/btrfs/volumes.c | 6 ++ 7 files changed, 25 insertions(+), 12 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/