Re: [GIT PULL] namespaces fixes for 3.14-rcX
On 14/03/10, Eric W. Biederman wrote: > Eric Paris writes: > > > On Sun, 2014-03-09 at 20:06 -0700, Eric W. Biederman wrote: > >> My efforts to get these fixes noticed by people who care about audit > >> seem to have landed on deaf ears, so since these are namespace related I > >> have put them in my tree. > > > > This commentary sounds like a pile of crap seeing as how there was a > > whole discussion around how to handle this stuff, which you were a part > > of. And that the audit tree already picked up these 2 patches. > > My apologies for offending. Last night when I looked the audit tree had > not been updated in 7 weeks, and Andrew Morton wasn't ready to push > these fixes to Linus and was looking for someone who would. Keeping > important bug fixes in my retransmit queue leaves me very grumpy. Well, it is offensive. Please stick to the facts. Some of us may not be as smart as you, but continuing to suggest people don't care is starting to get abusive. > > In any case, since I haven't sent them to Linus and I'm glad that is > > done, so feel free to consider this me Acking the pull request. > > Eric - RGB -- Richard Guy Briggs Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] namespaces fixes for 3.14-rcX
On 14/03/10, Eric W. Biederman wrote: Eric Paris epa...@redhat.com writes: On Sun, 2014-03-09 at 20:06 -0700, Eric W. Biederman wrote: My efforts to get these fixes noticed by people who care about audit seem to have landed on deaf ears, so since these are namespace related I have put them in my tree. This commentary sounds like a pile of crap seeing as how there was a whole discussion around how to handle this stuff, which you were a part of. And that the audit tree already picked up these 2 patches. My apologies for offending. Last night when I looked the audit tree had not been updated in 7 weeks, and Andrew Morton wasn't ready to push these fixes to Linus and was looking for someone who would. Keeping important bug fixes in my retransmit queue leaves me very grumpy. Well, it is offensive. Please stick to the facts. Some of us may not be as smart as you, but continuing to suggest people don't care is starting to get abusive. In any case, since I haven't sent them to Linus and I'm glad that is done, so feel free to consider this me Acking the pull request. Eric - RGB -- Richard Guy Briggs rbri...@redhat.com Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat Remote, Ottawa, Canada Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] namespaces fixes for 3.14-rcX
Eric Paris writes: > On Sun, 2014-03-09 at 20:06 -0700, Eric W. Biederman wrote: >> My efforts to get these fixes noticed by people who care about audit >> seem to have landed on deaf ears, so since these are namespace related I >> have put them in my tree. > > This commentary sounds like a pile of crap seeing as how there was a > whole discussion around how to handle this stuff, which you were a part > of. And that the audit tree already picked up these 2 patches. My apologies for offending. Last night when I looked the audit tree had not been updated in 7 weeks, and Andrew Morton wasn't ready to push these fixes to Linus and was looking for someone who would. Keeping important bug fixes in my retransmit queue leaves me very grumpy. > In any case, since I haven't sent them to Linus and I'm glad that is > done, so feel free to consider this me Acking the pull request. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] namespaces fixes for 3.14-rcX
On Sun, 2014-03-09 at 20:06 -0700, Eric W. Biederman wrote: > Linus, > > Please pull the for-linus branch from the git tree: > >git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git > for-linus > >HEAD: d211f177b28ec070c25b3d0b960aa55f352f731f audit: Update kdoc for > audit_send_reply and audit_list_rules_send > > Starting with 3.14-rc1 the audit code is faulty (think oopses and races) > with respect to how it computes the network namespace of which socket to > reply to, and I happened to notice by chance when reading through the > code. > > My efforts to get these fixes noticed by people who care about audit > seem to have landed on deaf ears, so since these are namespace related I > have put them in my tree. This commentary sounds like a pile of crap seeing as how there was a whole discussion around how to handle this stuff, which you were a part of. And that the audit tree already picked up these 2 patches. In any case, since I haven't sent them to Linus and I'm glad that is done, so feel free to consider this me Acking the pull request. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] namespaces fixes for 3.14-rcX
On Sun, 2014-03-09 at 20:06 -0700, Eric W. Biederman wrote: Linus, Please pull the for-linus branch from the git tree: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-linus HEAD: d211f177b28ec070c25b3d0b960aa55f352f731f audit: Update kdoc for audit_send_reply and audit_list_rules_send Starting with 3.14-rc1 the audit code is faulty (think oopses and races) with respect to how it computes the network namespace of which socket to reply to, and I happened to notice by chance when reading through the code. My efforts to get these fixes noticed by people who care about audit seem to have landed on deaf ears, so since these are namespace related I have put them in my tree. This commentary sounds like a pile of crap seeing as how there was a whole discussion around how to handle this stuff, which you were a part of. And that the audit tree already picked up these 2 patches. In any case, since I haven't sent them to Linus and I'm glad that is done, so feel free to consider this me Acking the pull request. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] namespaces fixes for 3.14-rcX
Eric Paris epa...@redhat.com writes: On Sun, 2014-03-09 at 20:06 -0700, Eric W. Biederman wrote: My efforts to get these fixes noticed by people who care about audit seem to have landed on deaf ears, so since these are namespace related I have put them in my tree. This commentary sounds like a pile of crap seeing as how there was a whole discussion around how to handle this stuff, which you were a part of. And that the audit tree already picked up these 2 patches. My apologies for offending. Last night when I looked the audit tree had not been updated in 7 weeks, and Andrew Morton wasn't ready to push these fixes to Linus and was looking for someone who would. Keeping important bug fixes in my retransmit queue leaves me very grumpy. In any case, since I haven't sent them to Linus and I'm glad that is done, so feel free to consider this me Acking the pull request. Eric -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] namespaces fixes for 3.14-rcX
Linus, Please pull the for-linus branch from the git tree: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-linus HEAD: d211f177b28ec070c25b3d0b960aa55f352f731f audit: Update kdoc for audit_send_reply and audit_list_rules_send Starting with 3.14-rc1 the audit code is faulty (think oopses and races) with respect to how it computes the network namespace of which socket to reply to, and I happened to notice by chance when reading through the code. My efforts to get these fixes noticed by people who care about audit seem to have landed on deaf ears, so since these are namespace related I have put them in my tree. My testing and the automated build bots don't find any problems with these fixes. Eric W. Biederman (3): audit: Use struct net not pid_t to remember the network namespce to reply in audit: Send replies in the proper network namespace. audit: Update kdoc for audit_send_reply and audit_list_rules_send include/linux/audit.h |3 ++- kernel/audit.c| 31 --- kernel/audit.h|2 +- kernel/auditfilter.c | 10 +++--- 4 files changed, 26 insertions(+), 20 deletions(-) Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] namespaces fixes for 3.14-rcX
Linus, Please pull the for-linus branch from the git tree: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-linus HEAD: d211f177b28ec070c25b3d0b960aa55f352f731f audit: Update kdoc for audit_send_reply and audit_list_rules_send Starting with 3.14-rc1 the audit code is faulty (think oopses and races) with respect to how it computes the network namespace of which socket to reply to, and I happened to notice by chance when reading through the code. My efforts to get these fixes noticed by people who care about audit seem to have landed on deaf ears, so since these are namespace related I have put them in my tree. My testing and the automated build bots don't find any problems with these fixes. Eric W. Biederman (3): audit: Use struct net not pid_t to remember the network namespce to reply in audit: Send replies in the proper network namespace. audit: Update kdoc for audit_send_reply and audit_list_rules_send include/linux/audit.h |3 ++- kernel/audit.c| 31 --- kernel/audit.h|2 +- kernel/auditfilter.c | 10 +++--- 4 files changed, 26 insertions(+), 20 deletions(-) Eric -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/