Re: [GIT PULL] selftest: Add futex functional tests
On Fri, 2015-03-27 at 15:17 -0700, Darren Hart wrote: > Hi Shuah, > > This series begins the process of migrating my futextest tests into kselftest. > I've started with only the functional tests, as the performance and stress may > not be appropriate for kselftest as they stand. > > I cleaned up various complaints from checkpatch, but I ignored others that > would > require significant rework of the testcases, such as not using volatile and > not > creating new typedefs. > > The patches will follow, but I'm providing a pull request for your convenience > as well. > > The following changes since commit 0b63accf87225b5eb7e52814c374cf02d733d4bb: > > tools, update rtctest.c to verify passage of time (2015-03-24 22:02:59 > -0600) > > are available in the git repository at: > > git://git.infradead.org/users/dvhart/linux.git futextest > > Darren Hart (5): > selftests: Add futex functional tests > selftest/futex: Update Makefile to use lib.mk > selftest/futex: Increment ksft pass and fail counters > selftest: Add futex tests to the top-level Makefile > kselftest: Add exit code defines I haven't really gone through these, but given how much I use these tests from your tree, I'm very glad to see them converted for upstream. I hope its as easy to use in kselftests though. Acked-by: Davidlohr Bueso -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] selftest: Add futex functional tests
On 4/8/15, 10:41 PM, "Shuah Khan" wrote: >On 04/07/2015 10:12 PM, Darren Hart wrote: >> On Tue, Mar 31, 2015 at 10:37:51AM -0600, Shuah Khan wrote: >>> On 03/31/2015 10:24 AM, Darren Hart wrote: On 3/31/15, 8:32 AM, "Shuah Khan" wrote: > Hi Daren, > > On 03/27/2015 04:17 PM, Darren Hart wrote: >> Hi Shuah, >> >> This series begins the process of migrating my futextest tests into >> kselftest. >> I've started with only the functional tests, as the performance and >> stress may >> not be appropriate for kselftest as they stand. >> >> I cleaned up various complaints from checkpatch, but I ignored >>others >> that would >> require significant rework of the testcases, such as not using >>volatile >> and not >> creating new typedefs. >> >> The patches will follow, but I'm providing a pull request for your >> convenience >> as well. > > Thanks for acting on this so quickly after we talked about it at ELC. > Just a quick note that I am going to get to this soon once I get the > 4.1 content wrapped up. We can plan upon getting these into 4.2. OK. Michael E. provided some feedback which I can either incorporate and respin, or I can send as a follow-on to your -next after you merge these. Which do you prefer? >> >> ... >> >>> You can wait to re-do patches. I am planning to review the >>> patch set later on this week. That way you can avoid re-spin >>> just in case, I have other comments. >> >> Hi Shuah, >> >> Did you have any additional comments for the futex tests? >> >> Thanks, >> > > >Sorry Daren. I got called away on a family emergency. The patch >looks good to me and I don't have any additional comments. No problem, hope things are alright. > >Assume these get pulled in for 4.2 release. I will get to them >soon once the 4.1-rc1 is out. You had some initial comments, do you want me to tend to those and resend, or will you pull as is and have me follow-up - either is fine, just let me know what you prefer. Thanks, -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] selftest: Add futex functional tests
On 04/07/2015 10:12 PM, Darren Hart wrote: > On Tue, Mar 31, 2015 at 10:37:51AM -0600, Shuah Khan wrote: >> On 03/31/2015 10:24 AM, Darren Hart wrote: >>> On 3/31/15, 8:32 AM, "Shuah Khan" wrote: >>> Hi Daren, On 03/27/2015 04:17 PM, Darren Hart wrote: > Hi Shuah, > > This series begins the process of migrating my futextest tests into > kselftest. > I've started with only the functional tests, as the performance and > stress may > not be appropriate for kselftest as they stand. > > I cleaned up various complaints from checkpatch, but I ignored others > that would > require significant rework of the testcases, such as not using volatile > and not > creating new typedefs. > > The patches will follow, but I'm providing a pull request for your > convenience > as well. Thanks for acting on this so quickly after we talked about it at ELC. Just a quick note that I am going to get to this soon once I get the 4.1 content wrapped up. We can plan upon getting these into 4.2. >>> >>> OK. Michael E. provided some feedback which I can either incorporate and >>> respin, or I can send as a follow-on to your -next after you merge these. >>> Which do you prefer? >>> > > ... > >> You can wait to re-do patches. I am planning to review the >> patch set later on this week. That way you can avoid re-spin >> just in case, I have other comments. > > Hi Shuah, > > Did you have any additional comments for the futex tests? > > Thanks, > Sorry Daren. I got called away on a family emergency. The patch looks good to me and I don't have any additional comments. Assume these get pulled in for 4.2 release. I will get to them soon once the 4.1-rc1 is out. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shua...@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] selftest: Add futex functional tests
On Tue, Mar 31, 2015 at 10:37:51AM -0600, Shuah Khan wrote: > On 03/31/2015 10:24 AM, Darren Hart wrote: > > On 3/31/15, 8:32 AM, "Shuah Khan" wrote: > > > >> Hi Daren, > >> > >> On 03/27/2015 04:17 PM, Darren Hart wrote: > >>> Hi Shuah, > >>> > >>> This series begins the process of migrating my futextest tests into > >>> kselftest. > >>> I've started with only the functional tests, as the performance and > >>> stress may > >>> not be appropriate for kselftest as they stand. > >>> > >>> I cleaned up various complaints from checkpatch, but I ignored others > >>> that would > >>> require significant rework of the testcases, such as not using volatile > >>> and not > >>> creating new typedefs. > >>> > >>> The patches will follow, but I'm providing a pull request for your > >>> convenience > >>> as well. > >> > >> Thanks for acting on this so quickly after we talked about it at ELC. > >> Just a quick note that I am going to get to this soon once I get the > >> 4.1 content wrapped up. We can plan upon getting these into 4.2. > > > > OK. Michael E. provided some feedback which I can either incorporate and > > respin, or I can send as a follow-on to your -next after you merge these. > > Which do you prefer? > > ... > You can wait to re-do patches. I am planning to review the > patch set later on this week. That way you can avoid re-spin > just in case, I have other comments. Hi Shuah, Did you have any additional comments for the futex tests? Thanks, -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] selftest: Add futex functional tests
On 03/31/2015 10:24 AM, Darren Hart wrote: > On 3/31/15, 8:32 AM, "Shuah Khan" wrote: > >> Hi Daren, >> >> On 03/27/2015 04:17 PM, Darren Hart wrote: >>> Hi Shuah, >>> >>> This series begins the process of migrating my futextest tests into >>> kselftest. >>> I've started with only the functional tests, as the performance and >>> stress may >>> not be appropriate for kselftest as they stand. >>> >>> I cleaned up various complaints from checkpatch, but I ignored others >>> that would >>> require significant rework of the testcases, such as not using volatile >>> and not >>> creating new typedefs. >>> >>> The patches will follow, but I'm providing a pull request for your >>> convenience >>> as well. >> >> Thanks for acting on this so quickly after we talked about it at ELC. >> Just a quick note that I am going to get to this soon once I get the >> 4.1 content wrapped up. We can plan upon getting these into 4.2. > > OK. Michael E. provided some feedback which I can either incorporate and > respin, or I can send as a follow-on to your -next after you merge these. > Which do you prefer? > Working through my email. Yes I see Michael had comments on install. I would have the same ones. Please re-do the patch 2/5 to use shared logic and install framework in lib.mk. This need to be done to facilitate test install. If you were to create a script for running tests, please make it non-generic and unique. For example, run.sh is a very generic name. [PATCH 2/5] selftest/futex: Update Makefile to use lib.mk I took a quick look at the exit code discussion. If you would like improve what is in kselftest.h, please re-do that patch. [PATCH 5/5] kselftest: Add exit code defines You can wait to re-do patches. I am planning to review the patch set later on this week. That way you can avoid re-spin just in case, I have other comments. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shua...@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL] selftest: Add futex functional tests
On 3/31/15, 8:32 AM, "Shuah Khan" wrote: >Hi Daren, > >On 03/27/2015 04:17 PM, Darren Hart wrote: >> Hi Shuah, >> >> This series begins the process of migrating my futextest tests into >>kselftest. >> I've started with only the functional tests, as the performance and >>stress may >> not be appropriate for kselftest as they stand. >> >> I cleaned up various complaints from checkpatch, but I ignored others >>that would >> require significant rework of the testcases, such as not using volatile >>and not >> creating new typedefs. >> >> The patches will follow, but I'm providing a pull request for your >>convenience >> as well. > >Thanks for acting on this so quickly after we talked about it at ELC. >Just a quick note that I am going to get to this soon once I get the >4.1 content wrapped up. We can plan upon getting these into 4.2. OK. Michael E. provided some feedback which I can either incorporate and respin, or I can send as a follow-on to your -next after you merge these. Which do you prefer? -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] selftest: Add futex functional tests
Hi Shuah, This series begins the process of migrating my futextest tests into kselftest. I've started with only the functional tests, as the performance and stress may not be appropriate for kselftest as they stand. I cleaned up various complaints from checkpatch, but I ignored others that would require significant rework of the testcases, such as not using volatile and not creating new typedefs. The patches will follow, but I'm providing a pull request for your convenience as well. The following changes since commit 0b63accf87225b5eb7e52814c374cf02d733d4bb: tools, update rtctest.c to verify passage of time (2015-03-24 22:02:59 -0600) are available in the git repository at: git://git.infradead.org/users/dvhart/linux.git futextest Darren Hart (5): selftests: Add futex functional tests selftest/futex: Update Makefile to use lib.mk selftest/futex: Increment ksft pass and fail counters selftest: Add futex tests to the top-level Makefile kselftest: Add exit code defines tools/testing/selftests/Makefile | 1 + tools/testing/selftests/futex/Makefile | 29 ++ tools/testing/selftests/futex/README | 62 tools/testing/selftests/futex/functional/Makefile | 25 ++ .../selftests/futex/functional/futex_requeue_pi.c | 402 + .../functional/futex_requeue_pi_mismatched_ops.c | 136 +++ .../functional/futex_requeue_pi_signal_restart.c | 220 +++ .../functional/futex_wait_private_mapped_file.c| 126 +++ .../futex/functional/futex_wait_timeout.c | 85 + .../functional/futex_wait_uninitialized_heap.c | 124 +++ .../futex/functional/futex_wait_wouldblock.c | 79 tools/testing/selftests/futex/functional/run.sh| 79 tools/testing/selftests/futex/include/atomic.h | 83 + tools/testing/selftests/futex/include/futextest.h | 266 ++ tools/testing/selftests/futex/include/logging.h| 150 tools/testing/selftests/futex/run.sh | 33 ++ tools/testing/selftests/kselftest.h| 17 +- 17 files changed, 1912 insertions(+), 5 deletions(-) create mode 100644 tools/testing/selftests/futex/Makefile create mode 100644 tools/testing/selftests/futex/README create mode 100644 tools/testing/selftests/futex/functional/Makefile create mode 100644 tools/testing/selftests/futex/functional/futex_requeue_pi.c create mode 100644 tools/testing/selftests/futex/functional/futex_requeue_pi_mismatched_ops.c create mode 100644 tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c create mode 100644 tools/testing/selftests/futex/functional/futex_wait_private_mapped_file.c create mode 100644 tools/testing/selftests/futex/functional/futex_wait_timeout.c create mode 100644 tools/testing/selftests/futex/functional/futex_wait_uninitialized_heap.c create mode 100644 tools/testing/selftests/futex/functional/futex_wait_wouldblock.c create mode 100755 tools/testing/selftests/futex/functional/run.sh create mode 100644 tools/testing/selftests/futex/include/atomic.h create mode 100644 tools/testing/selftests/futex/include/futextest.h create mode 100644 tools/testing/selftests/futex/include/logging.h create mode 100755 tools/testing/selftests/futex/run.sh -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
