Re: [GIT PULL] tracing: Update for 4.21

2018-12-31 Thread Steven Rostedt
On Mon, 31 Dec 2018 11:50:18 -0800
Linus Torvalds  wrote:

> > OK, I'll modify my script not to make that diff.  
> 
> For small "fixes" pulls, the diffs are nice, and you actually see the
> details of the fixes. But for big things, the full diff is usually
> only a distraction.
> 
> I think the x86 maintainers have a script where it adds the diff if
> it's less than a hundred lines or something like that..
>

I can look into adding a size limit check, or perhaps it may be good
enough to just remove the diff for merge window pull requests, as those
tend to be the big ones.

-- Steve


Re: [GIT PULL] tracing: Update for 4.21

2018-12-31 Thread Linus Torvalds
On Mon, Dec 31, 2018 at 11:33 AM Steven Rostedt  wrote:
> >
> > Forgot to push out?
>
> Yeah, I did. I just pushed it out.

Thanks, I see it.

> > Btw, please don't include the whole diff in the same email when it's
> > ~seven thousand lines and over 200k in size. Yeah, I'm on a fast
> > connection, but that isn't *always* true. Did lkml even take this
> > email?
>
> OK, I'll modify my script not to make that diff.

For small "fixes" pulls, the diffs are nice, and you actually see the
details of the fixes. But for big things, the full diff is usually
only a distraction.

I think the x86 maintainers have a script where it adds the diff if
it's less than a hundred lines or something like that..

 Linus


Re: [GIT PULL] tracing: Update for 4.21

2018-12-31 Thread Steven Rostedt
On Mon, 31 Dec 2018 10:17:41 -0800
Linus Torvalds  wrote:

> On Fri, Dec 28, 2018 at 3:28 PM Steven Rostedt  wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> > trace-v4.21  
> 
> No such tag.
> 

Ug!

> > Tag SHA1: bcf1ea7cb12ce702d1d0660dfba0c3462c0b04e1
> > Head SHA1: 3d739c1f6156c70eb0548aa288dcfbac9e0bd162  
> 
> I can see branches with that commit SHA ("for-next" and "ftrace/core")
> but there is no tag with that name or that SHA1.
> 
> Forgot to push out?

Yeah, I did. I just pushed it out.

> 
> Btw, please don't include the whole diff in the same email when it's
> ~seven thousand lines and over 200k in size. Yeah, I'm on a fast
> connection, but that isn't *always* true. Did lkml even take this
> email?

OK, I'll modify my script not to make that diff.

It does appear to have still made it to LKML. I received it in my LKML
folder with:

 X-Mailing-List: linux-kernel@vger.kernel.org

-- Steve


Re: [GIT PULL] tracing: Update for 4.21

2018-12-31 Thread Linus Torvalds
On Fri, Dec 28, 2018 at 3:28 PM Steven Rostedt  wrote:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> trace-v4.21

No such tag.

> Tag SHA1: bcf1ea7cb12ce702d1d0660dfba0c3462c0b04e1
> Head SHA1: 3d739c1f6156c70eb0548aa288dcfbac9e0bd162

I can see branches with that commit SHA ("for-next" and "ftrace/core")
but there is no tag with that name or that SHA1.

Forgot to push out?

Btw, please don't include the whole diff in the same email when it's
~seven thousand lines and over 200k in size. Yeah, I'm on a fast
connection, but that isn't *always* true. Did lkml even take this
email?

 Linus