Re: [GIT PULL linux-next] Add Compiler Attributes tree
On Wed, 3 Oct 2018 14:14:28 +0200 Miguel Ojeda wrote: > HI Dominique, > > On Wed, Oct 3, 2018 at 12:37 AM Dominique Martinet > wrote: > > > > Miguel Ojeda wrote on Wed, Oct 03, 2018: > > > As I have read, -next is supposed to be a vision of what the merge > > > window will look like after merging everything, i.e. ideally -rc1. For > > > that to work for files out-of-tree (like these ones, which are not > > > maintained by a single tree), changes should be allowed to be stacked > > > on each other; otherwise, we cannot handle conflicts :-( > > > > The rule is the same as with a regular mainline pull; I don't have the > > reference at hand but in some recent-ish pull request Linus said he > > That is actually the first problem: there is no > reference/documentation at hand. :-P > Yes, and one of the topics for Maintainers Summit is to create one. One is actually in the works led by Dan Williams. -- Steve
Re: [GIT PULL linux-next] Add Compiler Attributes tree
On Wed, 3 Oct 2018 14:14:28 +0200 Miguel Ojeda wrote: > HI Dominique, > > On Wed, Oct 3, 2018 at 12:37 AM Dominique Martinet > wrote: > > > > Miguel Ojeda wrote on Wed, Oct 03, 2018: > > > As I have read, -next is supposed to be a vision of what the merge > > > window will look like after merging everything, i.e. ideally -rc1. For > > > that to work for files out-of-tree (like these ones, which are not > > > maintained by a single tree), changes should be allowed to be stacked > > > on each other; otherwise, we cannot handle conflicts :-( > > > > The rule is the same as with a regular mainline pull; I don't have the > > reference at hand but in some recent-ish pull request Linus said he > > That is actually the first problem: there is no > reference/documentation at hand. :-P > Yes, and one of the topics for Maintainers Summit is to create one. One is actually in the works led by Dan Williams. -- Steve
Re: [GIT PULL linux-next] Add Compiler Attributes tree
On Tue, Oct 2, 2018 at 2:11 PM Stephen Rothwell wrote:
>
> Hi Miguel,
>
> On Tue, 2 Oct 2018 15:47:12 +0200 Miguel Ojeda
> wrote:
> >
> > The Compiler Attributes series has been stable for 10+ days. To
> > increase testing before 4.20, I would to request it being picked up
> > for -next.
> >
> > The changes w.r.t. v5 in the LKML:
> >
> > - Rebased on top of next-20180928, which required removing
>
> Unfortunately, trees/branches included in linux-next must be based on
> something stable (usually Linus' tree, but it could be another
> tree/branch that is included in linux-next that does not rebase).
> Linux-next itself rebases every day, so snything based on it would drag
> in a previous version of all the other trees :-(
I think of this like a branch that's force pushed to. Can't base
other branches or trees off of it cause it's always moving/force
rewriting history.
>
> > aligned_largest, which was removed by 9503cd9cbaba
> > ("include/linux/compiler*.h: add version detection to
> > asm_volatile_goto").
>
> That commit is from Andrew's patch series which also rebases (usually
> at least every week), so you cannot depend on it.
Miguel, you should be able to drop that patch from your set then,
since Andrew's -mm tree flows into this -next tree as well, IIUC.
We'll take up that patch from there.
--
Thanks,
~Nick Desaulniers
Re: [GIT PULL linux-next] Add Compiler Attributes tree
On Tue, Oct 2, 2018 at 2:11 PM Stephen Rothwell wrote:
>
> Hi Miguel,
>
> On Tue, 2 Oct 2018 15:47:12 +0200 Miguel Ojeda
> wrote:
> >
> > The Compiler Attributes series has been stable for 10+ days. To
> > increase testing before 4.20, I would to request it being picked up
> > for -next.
> >
> > The changes w.r.t. v5 in the LKML:
> >
> > - Rebased on top of next-20180928, which required removing
>
> Unfortunately, trees/branches included in linux-next must be based on
> something stable (usually Linus' tree, but it could be another
> tree/branch that is included in linux-next that does not rebase).
> Linux-next itself rebases every day, so snything based on it would drag
> in a previous version of all the other trees :-(
I think of this like a branch that's force pushed to. Can't base
other branches or trees off of it cause it's always moving/force
rewriting history.
>
> > aligned_largest, which was removed by 9503cd9cbaba
> > ("include/linux/compiler*.h: add version detection to
> > asm_volatile_goto").
>
> That commit is from Andrew's patch series which also rebases (usually
> at least every week), so you cannot depend on it.
Miguel, you should be able to drop that patch from your set then,
since Andrew's -mm tree flows into this -next tree as well, IIUC.
We'll take up that patch from there.
--
Thanks,
~Nick Desaulniers
Re: [GIT PULL linux-next] Add Compiler Attributes tree
Hi Miguel,
On Tue, 2 Oct 2018 15:47:12 +0200 Miguel Ojeda
wrote:
>
> The Compiler Attributes series has been stable for 10+ days. To
> increase testing before 4.20, I would to request it being picked up
> for -next.
>
> The changes w.r.t. v5 in the LKML:
>
> - Rebased on top of next-20180928, which required removing
Unfortunately, trees/branches included in linux-next must be based on
something stable (usually Linus' tree, but it could be another
tree/branch that is included in linux-next that does not rebase).
Linux-next itself rebases every day, so snything based on it would drag
in a previous version of all the other trees :-(
> aligned_largest, which was removed by 9503cd9cbaba
> ("include/linux/compiler*.h: add version detection to
> asm_volatile_goto").
That commit is from Andrew's patch series which also rebases (usually
at least every week), so you cannot depend on it.
--
Cheers,
Stephen Rothwell
pgpFgQF90idom.pgp
Description: OpenPGP digital signature
Re: [GIT PULL linux-next] Add Compiler Attributes tree
Hi Miguel,
On Tue, 2 Oct 2018 15:47:12 +0200 Miguel Ojeda
wrote:
>
> The Compiler Attributes series has been stable for 10+ days. To
> increase testing before 4.20, I would to request it being picked up
> for -next.
>
> The changes w.r.t. v5 in the LKML:
>
> - Rebased on top of next-20180928, which required removing
Unfortunately, trees/branches included in linux-next must be based on
something stable (usually Linus' tree, but it could be another
tree/branch that is included in linux-next that does not rebase).
Linux-next itself rebases every day, so snything based on it would drag
in a previous version of all the other trees :-(
> aligned_largest, which was removed by 9503cd9cbaba
> ("include/linux/compiler*.h: add version detection to
> asm_volatile_goto").
That commit is from Andrew's patch series which also rebases (usually
at least every week), so you cannot depend on it.
--
Cheers,
Stephen Rothwell
pgpFgQF90idom.pgp
Description: OpenPGP digital signature
[GIT PULL linux-next] Add Compiler Attributes tree
Hi Stephen,
The Compiler Attributes series has been stable for 10+ days. To
increase testing before 4.20, I would to request it being picked up
for -next.
The changes w.r.t. v5 in the LKML:
- Rebased on top of next-20180928, which required removing
aligned_largest, which was removed by 9503cd9cbaba
("include/linux/compiler*.h: add version detection to
asm_volatile_goto").
- Added latest Reviewed-by's and Tested-by's.
Thanks!
Cheers,
Miguel
The following changes since commit 4794a36bf08dfa89fe636e5080db9d8350e255dd:
Add linux-next specific files for 20180928 (2018-09-28 15:26:51 +1000)
are available in the Git repository at:
https://github.com/ojeda/linux.git compiler-attributes
for you to fetch changes up to dbce062c0b519db1cdad8d87ab46851f0be6bdea:
Compiler Attributes: ext4: remove local __nonstring definition
(2018-10-02 15:11:26 +0200)
Miguel Ojeda (15):
Compiler Attributes: remove unused attributes
Compiler Attributes: always use the extra-underscores syntax
Compiler Attributes: remove unneeded tests
Compiler Attributes: homogenize __must_be_array
Compiler Attributes: remove unneeded sparse (__CHECKER__) tests
Compiler Attributes: add missing SPDX ID in compiler_types.h
Compiler Attributes: use feature checks instead of version checks
Compiler Attributes: KENTRY used twice the "used" attribute
Compiler Attributes: remove uses of __attribute__ from compiler.h
Compiler Attributes: add Doc/process/programming-language.rst
Compiler Attributes: add MAINTAINERS entry
Compiler Attributes: add support for __nonstring (gcc >= 8)
Compiler Attributes: enable -Wstringop-truncation on W=1 (gcc >= 8)
Compiler Attributes: auxdisplay: panel: use __nonstring
Compiler Attributes: ext4: remove local __nonstring definition
Documentation/process/index.rst| 1 +
Documentation/process/programming-language.rst | 45 +
MAINTAINERS| 5 +
drivers/auxdisplay/panel.c | 7 +-
fs/ext4/ext4.h | 9 -
include/linux/compiler-clang.h | 5 -
include/linux/compiler-gcc.h | 70 +--
include/linux/compiler-intel.h | 9 -
include/linux/compiler.h | 19 +-
include/linux/compiler_attributes.h| 257 +
include/linux/compiler_types.h | 100 ++
scripts/Makefile.extrawarn | 1 +
12 files changed, 340 insertions(+), 188 deletions(-)
create mode 100644 Documentation/process/programming-language.rst
create mode 100644 include/linux/compiler_attributes.h
[GIT PULL linux-next] Add Compiler Attributes tree
Hi Stephen,
The Compiler Attributes series has been stable for 10+ days. To
increase testing before 4.20, I would to request it being picked up
for -next.
The changes w.r.t. v5 in the LKML:
- Rebased on top of next-20180928, which required removing
aligned_largest, which was removed by 9503cd9cbaba
("include/linux/compiler*.h: add version detection to
asm_volatile_goto").
- Added latest Reviewed-by's and Tested-by's.
Thanks!
Cheers,
Miguel
The following changes since commit 4794a36bf08dfa89fe636e5080db9d8350e255dd:
Add linux-next specific files for 20180928 (2018-09-28 15:26:51 +1000)
are available in the Git repository at:
https://github.com/ojeda/linux.git compiler-attributes
for you to fetch changes up to dbce062c0b519db1cdad8d87ab46851f0be6bdea:
Compiler Attributes: ext4: remove local __nonstring definition
(2018-10-02 15:11:26 +0200)
Miguel Ojeda (15):
Compiler Attributes: remove unused attributes
Compiler Attributes: always use the extra-underscores syntax
Compiler Attributes: remove unneeded tests
Compiler Attributes: homogenize __must_be_array
Compiler Attributes: remove unneeded sparse (__CHECKER__) tests
Compiler Attributes: add missing SPDX ID in compiler_types.h
Compiler Attributes: use feature checks instead of version checks
Compiler Attributes: KENTRY used twice the "used" attribute
Compiler Attributes: remove uses of __attribute__ from compiler.h
Compiler Attributes: add Doc/process/programming-language.rst
Compiler Attributes: add MAINTAINERS entry
Compiler Attributes: add support for __nonstring (gcc >= 8)
Compiler Attributes: enable -Wstringop-truncation on W=1 (gcc >= 8)
Compiler Attributes: auxdisplay: panel: use __nonstring
Compiler Attributes: ext4: remove local __nonstring definition
Documentation/process/index.rst| 1 +
Documentation/process/programming-language.rst | 45 +
MAINTAINERS| 5 +
drivers/auxdisplay/panel.c | 7 +-
fs/ext4/ext4.h | 9 -
include/linux/compiler-clang.h | 5 -
include/linux/compiler-gcc.h | 70 +--
include/linux/compiler-intel.h | 9 -
include/linux/compiler.h | 19 +-
include/linux/compiler_attributes.h| 257 +
include/linux/compiler_types.h | 100 ++
scripts/Makefile.extrawarn | 1 +
12 files changed, 340 insertions(+), 188 deletions(-)
create mode 100644 Documentation/process/programming-language.rst
create mode 100644 include/linux/compiler_attributes.h
