Re: [GIT PULL v2] dynticks updates for 3.14
* Frederic Weisbecker wrote: > Ingo, > > Please pull the timers/core-v2 branch that can be found at: > > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git > timers/core-v2 > > It's a rebase of the previous pull request against 3.13-rc2 which addresses > your reviews: > > * Fix build error with tick_check_nohz() off case > > * Refine changelog of "posix-timers: Fix full dynticks CPUs kick on timer > rescheduling" > to make it clearer that it's a bug fix and not just an optimization. > Also add more overall details in the changelog about the description of the > issue. > > * Rename tick_check_nohz() and tick_check_oneshot_broadcast() to extend with > *_this_cpu() > suffix. Note that I left functions that use *_idle_* based naming as is > because idle > itself is a per cpu notion already. Now I can still extend these functions > as well > in a delta if you want, although IMHO I fear that would uglify the code > more than helping. > > --- > Here is a summary of the overall changes against tip:timers/core : > > * Optimizations and cleanups on the use of per CPU APIs to improve code > readability, > performance and debuggability in the nohz subsystem; > > * Rename some functions to extend with *_this_cpu() suffix for clarity > > * Refine the naming of some context tracking subsystem state accessors > > * Optimize posix cpu timer by sparing stub workqueue queue with full dynticks > off case > > * Trivial spelling fix by Paul Gortmaker > > * Fix a bug where posix cpu timers requeued due to interval got ignored on > full > dynticks CPUs (not a regression though as it only impacts full dynticks and > the > bug is there since we merged full dynticks). > > > Let me know if you find any issue. > > Thanks, > Frederic > --- > > Frederic Weisbecker (5): > nohz: Convert a few places to use local per cpu accesses > context_tracking: Wrap static key check into more intuitive function > name > context_tracking: Rename context_tracking_active() to > context_tracking_cpu_is_enabled() > posix-timers: Spare workqueue if there is no full dynticks CPU to kick > posix-timers: Fix full dynticks CPUs kick on timer rescheduling > > Paul Gortmaker (1): > trivial: fix spelling in CONTEXT_TRACKING_FORCE help text > > > include/linux/context_tracking.h | 10 - > include/linux/context_tracking_state.h | 11 +++--- > include/linux/tick.h | 8 +++ > include/linux/vtime.h | 4 ++-- > init/Kconfig | 2 +- > kernel/context_tracking.c | 8 +++ > kernel/posix-cpu-timers.c | 21 -- > kernel/softirq.c | 4 +--- > kernel/time/tick-broadcast.c | 6 +++--- > kernel/time/tick-internal.h| 4 ++-- > kernel/time/tick-sched.c | 39 > ++ > 11 files changed, 55 insertions(+), 62 deletions(-) Pulled into tip:timers/core, thanks a lot Frederic! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [GIT PULL v2] dynticks updates for 3.14
* Frederic Weisbecker fweis...@gmail.com wrote: Ingo, Please pull the timers/core-v2 branch that can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git timers/core-v2 It's a rebase of the previous pull request against 3.13-rc2 which addresses your reviews: * Fix build error with tick_check_nohz() off case * Refine changelog of posix-timers: Fix full dynticks CPUs kick on timer rescheduling to make it clearer that it's a bug fix and not just an optimization. Also add more overall details in the changelog about the description of the issue. * Rename tick_check_nohz() and tick_check_oneshot_broadcast() to extend with *_this_cpu() suffix. Note that I left functions that use *_idle_* based naming as is because idle itself is a per cpu notion already. Now I can still extend these functions as well in a delta if you want, although IMHO I fear that would uglify the code more than helping. --- Here is a summary of the overall changes against tip:timers/core : * Optimizations and cleanups on the use of per CPU APIs to improve code readability, performance and debuggability in the nohz subsystem; * Rename some functions to extend with *_this_cpu() suffix for clarity * Refine the naming of some context tracking subsystem state accessors * Optimize posix cpu timer by sparing stub workqueue queue with full dynticks off case * Trivial spelling fix by Paul Gortmaker * Fix a bug where posix cpu timers requeued due to interval got ignored on full dynticks CPUs (not a regression though as it only impacts full dynticks and the bug is there since we merged full dynticks). Let me know if you find any issue. Thanks, Frederic --- Frederic Weisbecker (5): nohz: Convert a few places to use local per cpu accesses context_tracking: Wrap static key check into more intuitive function name context_tracking: Rename context_tracking_active() to context_tracking_cpu_is_enabled() posix-timers: Spare workqueue if there is no full dynticks CPU to kick posix-timers: Fix full dynticks CPUs kick on timer rescheduling Paul Gortmaker (1): trivial: fix spelling in CONTEXT_TRACKING_FORCE help text include/linux/context_tracking.h | 10 - include/linux/context_tracking_state.h | 11 +++--- include/linux/tick.h | 8 +++ include/linux/vtime.h | 4 ++-- init/Kconfig | 2 +- kernel/context_tracking.c | 8 +++ kernel/posix-cpu-timers.c | 21 -- kernel/softirq.c | 4 +--- kernel/time/tick-broadcast.c | 6 +++--- kernel/time/tick-internal.h| 4 ++-- kernel/time/tick-sched.c | 39 ++ 11 files changed, 55 insertions(+), 62 deletions(-) Pulled into tip:timers/core, thanks a lot Frederic! Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL v2] dynticks updates for 3.14
Ingo, Please pull the timers/core-v2 branch that can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git timers/core-v2 It's a rebase of the previous pull request against 3.13-rc2 which addresses your reviews: * Fix build error with tick_check_nohz() off case * Refine changelog of "posix-timers: Fix full dynticks CPUs kick on timer rescheduling" to make it clearer that it's a bug fix and not just an optimization. Also add more overall details in the changelog about the description of the issue. * Rename tick_check_nohz() and tick_check_oneshot_broadcast() to extend with *_this_cpu() suffix. Note that I left functions that use *_idle_* based naming as is because idle itself is a per cpu notion already. Now I can still extend these functions as well in a delta if you want, although IMHO I fear that would uglify the code more than helping. --- Here is a summary of the overall changes against tip:timers/core : * Optimizations and cleanups on the use of per CPU APIs to improve code readability, performance and debuggability in the nohz subsystem; * Rename some functions to extend with *_this_cpu() suffix for clarity * Refine the naming of some context tracking subsystem state accessors * Optimize posix cpu timer by sparing stub workqueue queue with full dynticks off case * Trivial spelling fix by Paul Gortmaker * Fix a bug where posix cpu timers requeued due to interval got ignored on full dynticks CPUs (not a regression though as it only impacts full dynticks and the bug is there since we merged full dynticks). Let me know if you find any issue. Thanks, Frederic --- Frederic Weisbecker (5): nohz: Convert a few places to use local per cpu accesses context_tracking: Wrap static key check into more intuitive function name context_tracking: Rename context_tracking_active() to context_tracking_cpu_is_enabled() posix-timers: Spare workqueue if there is no full dynticks CPU to kick posix-timers: Fix full dynticks CPUs kick on timer rescheduling Paul Gortmaker (1): trivial: fix spelling in CONTEXT_TRACKING_FORCE help text include/linux/context_tracking.h | 10 - include/linux/context_tracking_state.h | 11 +++--- include/linux/tick.h | 8 +++ include/linux/vtime.h | 4 ++-- init/Kconfig | 2 +- kernel/context_tracking.c | 8 +++ kernel/posix-cpu-timers.c | 21 -- kernel/softirq.c | 4 +--- kernel/time/tick-broadcast.c | 6 +++--- kernel/time/tick-internal.h| 4 ++-- kernel/time/tick-sched.c | 39 ++ 11 files changed, 55 insertions(+), 62 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL v2] dynticks updates for 3.14
Ingo, Please pull the timers/core-v2 branch that can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git timers/core-v2 It's a rebase of the previous pull request against 3.13-rc2 which addresses your reviews: * Fix build error with tick_check_nohz() off case * Refine changelog of posix-timers: Fix full dynticks CPUs kick on timer rescheduling to make it clearer that it's a bug fix and not just an optimization. Also add more overall details in the changelog about the description of the issue. * Rename tick_check_nohz() and tick_check_oneshot_broadcast() to extend with *_this_cpu() suffix. Note that I left functions that use *_idle_* based naming as is because idle itself is a per cpu notion already. Now I can still extend these functions as well in a delta if you want, although IMHO I fear that would uglify the code more than helping. --- Here is a summary of the overall changes against tip:timers/core : * Optimizations and cleanups on the use of per CPU APIs to improve code readability, performance and debuggability in the nohz subsystem; * Rename some functions to extend with *_this_cpu() suffix for clarity * Refine the naming of some context tracking subsystem state accessors * Optimize posix cpu timer by sparing stub workqueue queue with full dynticks off case * Trivial spelling fix by Paul Gortmaker * Fix a bug where posix cpu timers requeued due to interval got ignored on full dynticks CPUs (not a regression though as it only impacts full dynticks and the bug is there since we merged full dynticks). Let me know if you find any issue. Thanks, Frederic --- Frederic Weisbecker (5): nohz: Convert a few places to use local per cpu accesses context_tracking: Wrap static key check into more intuitive function name context_tracking: Rename context_tracking_active() to context_tracking_cpu_is_enabled() posix-timers: Spare workqueue if there is no full dynticks CPU to kick posix-timers: Fix full dynticks CPUs kick on timer rescheduling Paul Gortmaker (1): trivial: fix spelling in CONTEXT_TRACKING_FORCE help text include/linux/context_tracking.h | 10 - include/linux/context_tracking_state.h | 11 +++--- include/linux/tick.h | 8 +++ include/linux/vtime.h | 4 ++-- init/Kconfig | 2 +- kernel/context_tracking.c | 8 +++ kernel/posix-cpu-timers.c | 21 -- kernel/softirq.c | 4 +--- kernel/time/tick-broadcast.c | 6 +++--- kernel/time/tick-internal.h| 4 ++-- kernel/time/tick-sched.c | 39 ++ 11 files changed, 55 insertions(+), 62 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
