Re: [Outreachy kernel] [PATCH v2 0/5] staging: rtl8723bs: Change
On Sun, Apr 11, 2021 at 09:11:43AM +0200, Fabio M. De Francesco wrote: > On Sunday, April 11, 2021 8:39:18 AM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 05:00:03PM +0200, Fabio M. De Francesco wrote: > > > Remove camelcase, correct misspelled words in comments, remove an > > > unused > > > variable, change the type of a variable and its use, change comparisons > > > with 'true' in controlling expressions. > > > > > > Changes from v1: Fix a typo in subject of patch 1/5, add patch 5/5. > > > > The subject line above is very odd :( > > > True. I've just read the output of git format in /tmp and noticed that the > line with the "subject" was broken in two different one. I think I had > pressed return while editing. > > I'm about to send that series again with v3. > > In the while I noticed you sent a note to let me know that the you have > added the patch titled "staging: rtl8723bs: core: Remove an unused > variable" to your staging git tree. > > I think this could be a potential issue because the same patch is in the > series that I have to send anew. I put that patch in the series because > yesterday you wrote that the message with subject "Outreachy patches caught > up on.", asking to rebase and resend. > > However, I'm about to send v3 of this patchset. I have no idea whether or > not you will have problems in applying that. If you have problems with it, > please let me know. I will, please rebase your tree against mine, which should remove the one patch that I did apply already as you do not need to send it again. thanks, greg k-h
Re: [Outreachy kernel] [PATCH v2 0/5] staging: rtl8723bs: Change
On Sunday, April 11, 2021 8:39:18 AM CEST Greg KH wrote: > On Sat, Apr 10, 2021 at 05:00:03PM +0200, Fabio M. De Francesco wrote: > > Remove camelcase, correct misspelled words in comments, remove an > > unused > > variable, change the type of a variable and its use, change comparisons > > with 'true' in controlling expressions. > > > > Changes from v1: Fix a typo in subject of patch 1/5, add patch 5/5. > > The subject line above is very odd :( > True. I've just read the output of git format in /tmp and noticed that the line with the "subject" was broken in two different one. I think I had pressed return while editing. I'm about to send that series again with v3. In the while I noticed you sent a note to let me know that the you have added the patch titled "staging: rtl8723bs: core: Remove an unused variable" to your staging git tree. I think this could be a potential issue because the same patch is in the series that I have to send anew. I put that patch in the series because yesterday you wrote that the message with subject "Outreachy patches caught up on.", asking to rebase and resend. However, I'm about to send v3 of this patchset. I have no idea whether or not you will have problems in applying that. If you have problems with it, please let me know. Thanks, Fabio
Re: [Outreachy kernel] [PATCH v2 0/5] staging: rtl8723bs: Change
On Sat, Apr 10, 2021 at 05:00:03PM +0200, Fabio M. De Francesco wrote: > Remove camelcase, correct misspelled words in comments, remove an unused > variable, change the type of a variable and its use, change comparisons > with 'true' in controlling expressions. > > Changes from v1: Fix a typo in subject of patch 1/5, add patch 5/5. The subject line above is very odd :(
[Outreachy kernel] [PATCH v2 0/5] staging: rtl8723bs: Change
Remove camelcase, correct misspelled words in comments, remove an unused variable, change the type of a variable and its use, change comparisons with 'true' in controlling expressions. Changes from v1: Fix a typo in subject of patch 1/5, add patch 5/5. Fabio M. De Francesco (5): staging: rtl8723bs: Remove camelcase in several files staging: rtl8723bs: include: Fix misspelled words in comments staging: rtl8723bs: core: Remove an unused variable staging: rtl8723bs: Change the type and use of a variable staging: rtl8723bs: core: Change a controlling expression drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- .../staging/rtl8723bs/core/rtw_ieee80211.c| 4 +-- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 +- drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 6 ++-- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +- drivers/staging/rtl8723bs/hal/sdio_ops.c | 14 .../rtl8723bs/include/Hal8192CPhyReg.h| 8 ++--- .../staging/rtl8723bs/include/basic_types.h | 2 +- drivers/staging/rtl8723bs/include/drv_types.h | 2 +- drivers/staging/rtl8723bs/include/hal_com.h | 2 +- .../staging/rtl8723bs/include/hal_com_reg.h | 34 +-- drivers/staging/rtl8723bs/include/hal_data.h | 2 +- .../staging/rtl8723bs/include/hal_pwr_seq.h | 2 +- drivers/staging/rtl8723bs/include/rtw_cmd.h | 6 ++-- drivers/staging/rtl8723bs/include/rtw_mlme.h | 18 +- .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- drivers/staging/rtl8723bs/include/rtw_mp.h| 2 +- .../staging/rtl8723bs/include/rtw_pwrctrl.h | 4 +-- drivers/staging/rtl8723bs/include/rtw_recv.h | 4 +-- drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- drivers/staging/rtl8723bs/include/sta_info.h | 2 +- drivers/staging/rtl8723bs/include/wifi.h | 2 +- 24 files changed, 71 insertions(+), 73 deletions(-) -- 2.31.1
