Re: [PATCH?] OSS: fix operator precedence in return of btaudio_dsp_ioctl
On Thu, Nov 29, 2007 at 07:59:26PM +0100, Tomas Carnecky wrote: > Roel Kluin wrote: > > First of all, is /sound/oss/* still maintained? > > > > Documentation/feature-removal-schedule.txt > > What: drivers depending on OSS_OBSOLETE > When: options in 2.6.23, code in 2.6.25 > Why: obsolete OSS drivers > Who: Adrian Bunk <[EMAIL PROTECTED]> I'm maintaining only the gradual removal. ;-) That's only the removal of some of the remaining OSS drivers, but btaudio is among them. > tom cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH?] OSS: fix operator precedence in return of btaudio_dsp_ioctl
Roel Kluin wrote: > First of all, is /sound/oss/* still maintained? > Documentation/feature-removal-schedule.txt What: drivers depending on OSS_OBSOLETE When: options in 2.6.23, code in 2.6.25 Why: obsolete OSS drivers Who: Adrian Bunk <[EMAIL PROTECTED]> tom - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH?] OSS: fix operator precedence in return of btaudio_dsp_ioctl
First of all, is /sound/oss/* still maintained?
#define HWBASE_AD (448000)
...
with if(bta->analog) evaluating to true bta->decimation may range
from 15 to 5
...
HWBASE_AD*4/bta->decimation>>bta->sampleshift
which is equivalent to
((HWBASE_AD * 4)/bta->decimation) >> bta->sampleshift
actually may evaluate to something like:
(1792000 / 15 ) >> bta->sampleshift
Isn't intended (HWBASE_AD * 4)/(bta->decimation >> bta->sampleshift)?
Then consider the patch below.
--
Fix operator precedence in return
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/sound/oss/btaudio.c b/sound/oss/btaudio.c
index 4d5cf05..2a5cace 100644
--- a/sound/oss/btaudio.c
+++ b/sound/oss/btaudio.c
@@ -661,7 +661,8 @@ static int btaudio_dsp_ioctl(struct inode *inode, struct
file *file,
/* fall through */
case SOUND_PCM_READ_RATE:
if (bta->analog) {
- return
put_user(HWBASE_AD*4/bta->decimation>>bta->sampleshift, p);
+ return put_user((HWBASE_AD * 4) /
+ (bta->decimation >> bta->sampleshift), p);
} else {
return put_user(bta->rate, p);
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH?] OSS: fix operator precedence in return of btaudio_dsp_ioctl
First of all, is /sound/oss/* still maintained?
#define HWBASE_AD (448000)
...
with if(bta-analog) evaluating to true bta-decimation may range
from 15 to 5
...
HWBASE_AD*4/bta-decimationbta-sampleshift
which is equivalent to
((HWBASE_AD * 4)/bta-decimation) bta-sampleshift
actually may evaluate to something like:
(1792000 / 15 ) bta-sampleshift
Isn't intended (HWBASE_AD * 4)/(bta-decimation bta-sampleshift)?
Then consider the patch below.
--
Fix operator precedence in return
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/sound/oss/btaudio.c b/sound/oss/btaudio.c
index 4d5cf05..2a5cace 100644
--- a/sound/oss/btaudio.c
+++ b/sound/oss/btaudio.c
@@ -661,7 +661,8 @@ static int btaudio_dsp_ioctl(struct inode *inode, struct
file *file,
/* fall through */
case SOUND_PCM_READ_RATE:
if (bta-analog) {
- return
put_user(HWBASE_AD*4/bta-decimationbta-sampleshift, p);
+ return put_user((HWBASE_AD * 4) /
+ (bta-decimation bta-sampleshift), p);
} else {
return put_user(bta-rate, p);
}
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH?] OSS: fix operator precedence in return of btaudio_dsp_ioctl
Roel Kluin wrote: First of all, is /sound/oss/* still maintained? Documentation/feature-removal-schedule.txt What: drivers depending on OSS_OBSOLETE When: options in 2.6.23, code in 2.6.25 Why: obsolete OSS drivers Who: Adrian Bunk [EMAIL PROTECTED] tom - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH?] OSS: fix operator precedence in return of btaudio_dsp_ioctl
On Thu, Nov 29, 2007 at 07:59:26PM +0100, Tomas Carnecky wrote: Roel Kluin wrote: First of all, is /sound/oss/* still maintained? Documentation/feature-removal-schedule.txt What: drivers depending on OSS_OBSOLETE When: options in 2.6.23, code in 2.6.25 Why: obsolete OSS drivers Who: Adrian Bunk [EMAIL PROTECTED] I'm maintaining only the gradual removal. ;-) That's only the removal of some of the remaining OSS drivers, but btaudio is among them. tom cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
